[GitHub] flink issue #3829: [FLINK-6442] [table] Extend TableAPI Support Sink Table R...

2017-08-07 Thread lincoln-lil
Github user lincoln-lil commented on the issue: https://github.com/apache/flink/pull/3829 @fhueske I will continue this PR according to the above conclusions. Thanks, Lincoln --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Created] (FLINK-7385) Fix ArrayIndexOutOfBoundsException when object-reuse is enabled

2017-08-07 Thread Ruidong Li (JIRA)
Ruidong Li created FLINK-7385: - Summary: Fix ArrayIndexOutOfBoundsException when object-reuse is enabled Key: FLINK-7385 URL: https://issues.apache.org/jira/browse/FLINK-7385 Project: Flink

[jira] [Commented] (FLINK-7385) Fix ArrayIndexOutOfBoundsException when object-reuse is enabled

2017-08-07 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117869#comment-16117869 ] Tzu-Li (Gordon) Tai commented on FLINK-7385: This looks like a blockers for the next releases.

[jira] [Updated] (FLINK-7385) Fix ArrayIndexOutOfBoundsException when object-reuse is enabled

2017-08-07 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-7385: --- Priority: Blocker (was: Major) > Fix ArrayIndexOutOfBoundsException when

[jira] [Updated] (FLINK-7385) Fix ArrayIndexOutOfBoundsException when object-reuse is enabled

2017-08-07 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-7385: --- Affects Version/s: 1.1.5 1.2.1 1.3.2 >

[jira] [Updated] (FLINK-7385) Fix ArrayIndexOutOfBoundsException when object-reuse is enabled

2017-08-07 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-7385: --- Fix Version/s: 1.3.3 1.4.0 > Fix ArrayIndexOutOfBoundsException

[GitHub] flink pull request #4496: [FLINK-7385] Fix ArrayIndexOutOfBoundsException wh...

2017-08-07 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4496#discussion_r131822675 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamOperatorChainingTest.java --- @@ -37,7 +38,7 @@

[jira] [Commented] (FLINK-7385) Fix ArrayIndexOutOfBoundsException when object-reuse is enabled

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117873#comment-16117873 ] ASF GitHub Bot commented on FLINK-7385: --- Github user tzulitai commented on a diff in the pull

[jira] [Updated] (FLINK-7385) Fix ArrayIndexOutOfBoundsException when object-reuse is enabled

2017-08-07 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-7385: --- Component/s: DataStream API > Fix ArrayIndexOutOfBoundsException when object-reuse is

[jira] [Commented] (FLINK-7367) Parameterize more configs for FlinkKinesisProducer (RecordMaxBufferedTime, MaxConnections, RequestTimeout, etc)

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117887#comment-16117887 ] ASF GitHub Bot commented on FLINK-7367: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-07 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 I'm in favor of the 3rd option. In that way, we don't need to 1) duplicate all KPL keys and documentation to flink-kinesis-connector and 2) always keep an eye on KPL configs when upgrading its

[jira] [Commented] (FLINK-7385) Fix ArrayIndexOutOfBoundsException when object-reuse is enabled

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117860#comment-16117860 ] ASF GitHub Bot commented on FLINK-7385: --- GitHub user Xpray opened a pull request:

[GitHub] flink pull request #4496: [FLINK-7385] Fix ArrayIndexOutOfBoundsException wh...

2017-08-07 Thread Xpray
GitHub user Xpray opened a pull request: https://github.com/apache/flink/pull/4496 [FLINK-7385] Fix ArrayIndexOutOfBoundsException when object-reuse is … …enabled *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve

[GitHub] flink pull request #4496: [FLINK-7385] Fix ArrayIndexOutOfBoundsException wh...

2017-08-07 Thread Xpray
Github user Xpray commented on a diff in the pull request: https://github.com/apache/flink/pull/4496#discussion_r131823239 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamOperatorChainingTest.java --- @@ -37,7 +38,7 @@ import

[GitHub] flink pull request #4404: [FLINK-4565] [table] Support for SQL IN operator

2017-08-07 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4404#discussion_r131823213 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/subquery.scala --- @@ -0,0 +1,95 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117877#comment-16117877 ] ASF GitHub Bot commented on FLINK-4565: --- Github user tedyu commented on a diff in the pull request:

[jira] [Commented] (FLINK-7385) Fix ArrayIndexOutOfBoundsException when object-reuse is enabled

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117878#comment-16117878 ] ASF GitHub Bot commented on FLINK-7385: --- Github user Xpray commented on a diff in the pull request:

[GitHub] flink pull request #4296: [FLINK-7147] [cep] Support greedy quantifier in CE...

2017-08-07 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/4296#discussion_r131804887 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GreedyITCase.java --- @@ -0,0 +1,1068 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-7147) Support greedy quantifier in CEP

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117809#comment-16117809 ] ASF GitHub Bot commented on FLINK-7147: --- Github user dianfu commented on a diff in the pull request:

[jira] [Commented] (FLINK-7147) Support greedy quantifier in CEP

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117811#comment-16117811 ] ASF GitHub Bot commented on FLINK-7147: --- Github user dianfu commented on a diff in the pull request:

[GitHub] flink pull request #4296: [FLINK-7147] [cep] Support greedy quantifier in CE...

2017-08-07 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/4296#discussion_r131804932 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GreedyITCase.java --- @@ -0,0 +1,1068 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4296: [FLINK-7147] [cep] Support greedy quantifier in CE...

2017-08-07 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/4296#discussion_r131804902 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GreedyITCase.java --- @@ -0,0 +1,1068 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-7147) Support greedy quantifier in CEP

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117806#comment-16117806 ] ASF GitHub Bot commented on FLINK-7147: --- Github user dianfu commented on a diff in the pull request:

[jira] [Commented] (FLINK-7147) Support greedy quantifier in CEP

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117810#comment-16117810 ] ASF GitHub Bot commented on FLINK-7147: --- Github user dianfu commented on a diff in the pull request:

[GitHub] flink pull request #4296: [FLINK-7147] [cep] Support greedy quantifier in CE...

2017-08-07 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/4296#discussion_r131804764 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -637,9 +675,23 @@ private boolean

[GitHub] flink pull request #4296: [FLINK-7147] [cep] Support greedy quantifier in CE...

2017-08-07 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/4296#discussion_r131804398 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -386,6 +387,19 @@ private void

[jira] [Commented] (FLINK-7367) Parameterize more configs for FlinkKinesisProducer (RecordMaxBufferedTime, MaxConnections, RequestTimeout, etc)

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117838#comment-16117838 ] ASF GitHub Bot commented on FLINK-7367: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4496: [FLINK-7385] Fix ArrayIndexOutOfBoundsException when obje...

2017-08-07 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4496 Thanks for the PR @Xpray! Changes looks good to me. Good that a test is also added. I think it would be safer if @aljoscha also takes a look before merging. One reminder: filling out

[jira] [Commented] (FLINK-7385) Fix ArrayIndexOutOfBoundsException when object-reuse is enabled

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117876#comment-16117876 ] ASF GitHub Bot commented on FLINK-7385: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117709#comment-16117709 ] ASF GitHub Bot commented on FLINK-6442: --- Github user lincoln-lil commented on the issue:

[jira] [Commented] (FLINK-7147) Support greedy quantifier in CEP

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117807#comment-16117807 ] ASF GitHub Bot commented on FLINK-7147: --- Github user dianfu commented on a diff in the pull request:

[jira] [Commented] (FLINK-7147) Support greedy quantifier in CEP

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117808#comment-16117808 ] ASF GitHub Bot commented on FLINK-7147: --- Github user dianfu commented on a diff in the pull request:

[GitHub] flink pull request #4296: [FLINK-7147] [cep] Support greedy quantifier in CE...

2017-08-07 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/4296#discussion_r131804949 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GreedyITCase.java --- @@ -0,0 +1,1068 @@ +/* + * Licensed to the Apache

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-07 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4473 @bowenli86 the third option actually strikes me as an overall good solution, I didn't know that was possible. I think it would make sense to deprecate the previous configuration keys in

[jira] [Commented] (FLINK-7367) Parameterize more configs for FlinkKinesisProducer (RecordMaxBufferedTime, MaxConnections, RequestTimeout, etc)

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117836#comment-16117836 ] ASF GitHub Bot commented on FLINK-7367: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-07 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4473 Also cc'ing @aljoscha to this PR, since we also had a bit of offline discussion on this configuration gap issue. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116968#comment-16116968 ] ASF GitHub Bot commented on FLINK-4565: --- Github user tedyu commented on a diff in the pull request:

[GitHub] flink pull request #4404: [FLINK-4565] [table] Support for SQL IN operator

2017-08-07 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4404#discussion_r131726341 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/subquery.scala --- @@ -0,0 +1,95 @@ +/* + * Licensed to the

[GitHub] flink issue #2425: FLINK-3930 Added shared secret based authorization for Fl...

2017-08-07 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/2425 Note to future self: to generate a self-signed certificate, use `CertAndKeyGen` and see [OPENDJ-2247](https://bugster.forgerock.org/jira/browse/OPENDJ-2247). --- If your project is set up for

[jira] [Commented] (FLINK-3930) Implement Service-Level Authorization

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116980#comment-16116980 ] ASF GitHub Bot commented on FLINK-3930: --- Github user EronWright commented on the issue:

[jira] [Commented] (FLINK-7026) Add shaded asm dependency

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117010#comment-16117010 ] ASF GitHub Bot commented on FLINK-7026: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #4495: [FLINK-6982] [guava] Introduce flink-shaded-guava-...

2017-08-07 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4495 [FLINK-6982] [guava] Introduce flink-shaded-guava-18 ## What is the purpose of the change This PR integrates the shaded guava dependency from flink-shaded. Basically, replace all usages of

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117024#comment-16117024 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117028#comment-16117028 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117029#comment-16117029 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131724317 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/CRowOutputProcessRunner.scala --- @@ -18,42 +18,54 @@

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131704708 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -502,6 +500,68 @@ abstract class

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131724882 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/CRowOutputProcessRunner.scala --- @@ -18,42 +18,54 @@

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131726136 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1136,25 +1142,31 @@ object

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116966#comment-16116966 ] ASF GitHub Bot commented on FLINK-4565: --- GitHub user tedyu opened a pull request:

[GitHub] flink pull request #4493: [FLINK-4565] [table] Support for SQL IN operator -...

2017-08-07 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/flink/pull/4493 [FLINK-4565] [table] Support for SQL IN operator - move case of equal check *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help

[GitHub] flink pull request #4494: [FLINK-7026] Introduce flink-shaded-asm-5

2017-08-07 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4494 [FLINK-7026] Introduce flink-shaded-asm-5 ## What is the purpose of the change This PR integrates the shaded asm dependency from flink-shaded. Basically, replace all usages of asm with the

[jira] [Commented] (FLINK-6982) Replace guava dependencies

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117016#comment-16117016 ] ASF GitHub Bot commented on FLINK-6982: --- GitHub user zentol opened a pull request:

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117033#comment-16117033 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117030#comment-16117030 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131705390 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -677,12 +748,43 @@ abstract class

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117036#comment-16117036 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117039#comment-16117039 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117035#comment-16117035 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117045#comment-16117045 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117027#comment-16117027 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117031#comment-16117031 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117044#comment-16117044 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117038#comment-16117038 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117041#comment-16117041 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117042#comment-16117042 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117046#comment-16117046 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131728686 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRangeOver.scala --- @@ -123,6 +124,8 @@ class

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131706849 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala --- @@ -311,19 +323,19 @@ object

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131704170 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -502,6 +500,68 @@ abstract class

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131720018 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala --- @@ -148,6

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131708260 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -245,14 +244,18 @@ abstract class

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131704138 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -502,6 +500,68 @@ abstract class

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131706276 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala --- @@ -172,45 +172,20 @@ class

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131708789 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -245,14 +244,18 @@ abstract class

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131720129 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala --- @@ -148,6

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131717969 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -937,15 +935,40 @@ object

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131707428 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala --- @@ -415,7 +406,13 @@ class

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131714343 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -937,15 +935,40 @@ object

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131709842 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1104,6 +1106,19 @@ abstract class

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131709106 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -719,12 +722,11 @@ abstract class

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117025#comment-16117025 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117037#comment-16117037 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117047#comment-16117047 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117026#comment-16117026 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117040#comment-16117040 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131704681 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -502,6 +500,68 @@ abstract class

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131718272 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/ProcTimeMaterializationSqlFunction.scala --- @@ -22,12 +22,12 @@

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131723377 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/CRowInputTupleOutputMapRunner.scala --- @@ -90,3 +95,35 @@ class

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131712146 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -245,14 +244,18 @@ abstract class

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131724363 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/CRowOutputProcessRunner.scala --- @@ -18,42 +18,54 @@

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117034#comment-16117034 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117032#comment-16117032 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117049#comment-16117049 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131713099 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1104,6 +1106,19 @@ abstract class

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117043#comment-16117043 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117048#comment-16117048 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131703254 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -677,12 +748,43 @@ abstract class

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117083#comment-16117083 ] ASF GitHub Bot commented on FLINK-7337: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-07 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r131739402 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala --- @@ -172,45 +172,20 @@ class

  1   2   3   4   >