[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265130#comment-16265130 ] Dian Fu commented on FLINK-8144: {{AbstractKeyedCEPPatternOperator}} has similar logic as

[jira] [Issue Comment Deleted] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-8144: --- Comment: was deleted (was: {{AbstractKeyedCEPPatternOperator}} has similar logic as

[GitHub] flink issue #5063: [FLINK-8144] [table] Optimize the timer logic in RowTimeU...

2017-11-24 Thread dianfu
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/5063 {{AbstractKeyedCEPPatternOperator}} has similar logic as {{RowTimeUnboundedOver}}. As described in FLINK-8106, we find that the performance is very bad under the current logic for

[jira] [Comment Edited] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265130#comment-16265130 ] Dian Fu edited comment on FLINK-8144 at 11/24/17 10:19 AM: ---

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265133#comment-16265133 ] ASF GitHub Bot commented on FLINK-8144: --- Github user dianfu commented on the issue:

[jira] [Commented] (FLINK-8145) IOManagerAsync not properly shut down in various tests

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265165#comment-16265165 ] ASF GitHub Bot commented on FLINK-8145: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #5055: [FLINK-7718] [flip6] Add JobVertexMetricsHandler t...

2017-11-24 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5055#discussion_r152951899 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/AbstractMetricsHandler.java --- @@ -0,0 +1,141 @@ +/* + *

[jira] [Commented] (FLINK-7718) Port JobVertixMetricsHandler to new REST endpoint

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265202#comment-16265202 ] ASF GitHub Bot commented on FLINK-7718: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5063: [FLINK-8144] [table] Optimize the timer logic in R...

2017-11-24 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/5063#discussion_r152955709 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/RowTimeUnboundedOver.scala --- @@ -116,7 +116,7 @@ abstract

[jira] [Resolved] (FLINK-8125) Support limiting the number of open FileSystem connections

2017-11-24 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-8125. - Resolution: Fixed Fixed in - 1.5.0 via d7c2c417213502130b1aeab1868313df178555cc - 1.4.1 via

[jira] [Closed] (FLINK-8125) Support limiting the number of open FileSystem connections

2017-11-24 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-8125. --- > Support limiting the number of open FileSystem connections >

[GitHub] flink pull request #5059: [FLINK-8125] [core] Introduce limiting of file sys...

2017-11-24 Thread StephanEwen
Github user StephanEwen closed the pull request at: https://github.com/apache/flink/pull/5059 ---

[GitHub] flink issue #5065: [FLINK-8139][table] Check for proper equals() and hashCod...

2017-11-24 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5065 Hi @Aegeaner, thanks for the pull request. I had a brief look at it and noticed a few things: 1. Please fill out the PR template (see #5063 as an example) 2. Please add unit tests

[jira] [Commented] (FLINK-8147) Support and to CEP's pattern API

2017-11-24 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265243#comment-16265243 ] Dian Fu commented on FLINK-8147: Any comments is welcome. Do you think it's useful? What do you think the

[jira] [Commented] (FLINK-5465) RocksDB fails with segfault while calling AbstractRocksDBState.clear()

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265138#comment-16265138 ] ASF GitHub Bot commented on FLINK-5465: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5058: [FLINK-5465] [streaming] Wait for pending timer threads t...

2017-11-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5058 I would like to make a few comments for followup: - I think `TimerServiceOptions` should not be an own class, we are getting a crazy fragmentation of options into classes (that have

[jira] [Commented] (FLINK-5465) RocksDB fails with segfault while calling AbstractRocksDBState.clear()

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265143#comment-16265143 ] ASF GitHub Bot commented on FLINK-5465: --- Github user StefanRRichter commented on the issue:

[jira] [Created] (FLINK-8146) Potential resource leak in PythonPlanBinder#unzipPythonLibrary

2017-11-24 Thread Ted Yu (JIRA)
Ted Yu created FLINK-8146: - Summary: Potential resource leak in PythonPlanBinder#unzipPythonLibrary Key: FLINK-8146 URL: https://issues.apache.org/jira/browse/FLINK-8146 Project: Flink Issue Type:

[GitHub] flink issue #5058: [FLINK-5465] [streaming] Wait for pending timer threads t...

2017-11-24 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5058 I was thinking about where to put those options and after all it was a choice between fragmentation and inconsistency. I considered `TaskManagerOptions` but it sounds like a wrong place, if

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152961281 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -572,20 +560,53 @@ void

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265251#comment-16265251 ] ASF GitHub Bot commented on FLINK-8144: --- Github user fhueske commented on the issue:

[GitHub] flink issue #5063: [FLINK-8144] [table] Optimize the timer logic in RowTimeU...

2017-11-24 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5063 I see. The bad performance is related to way that you generate the watermarks. Generating so many watermarks is very inefficient because you processing many more watermarks than actual records

[jira] [Commented] (FLINK-7316) always use off-heap network buffers

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265094#comment-16265094 ] ASF GitHub Bot commented on FLINK-7316: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #4481: [FLINK-7316][network] always use off-heap network buffers

2017-11-24 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4481 Will merge this now. ---

[jira] [Commented] (FLINK-7316) always use off-heap network buffers

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265093#comment-16265093 ] ASF GitHub Bot commented on FLINK-7316: --- Github user StefanRRichter commented on the issue:

[jira] [Created] (FLINK-8145) IOManagerAsync not properly shut down in various tests

2017-11-24 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-8145: -- Summary: IOManagerAsync not properly shut down in various tests Key: FLINK-8145 URL: https://issues.apache.org/jira/browse/FLINK-8145 Project: Flink Issue Type:

[GitHub] flink pull request #5064: [FLINK-8145][tests] fix various IOManagerAsync ins...

2017-11-24 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5064 [FLINK-8145][tests] fix various IOManagerAsync instances not being shut down ## What is the purpose of the change Fix several unit tests using `IOManagerAsync` but not shutting it down

[jira] [Commented] (FLINK-8139) Check for proper equals() and hashCode() when registering a table

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265184#comment-16265184 ] ASF GitHub Bot commented on FLINK-8139: --- GitHub user Aegeaner opened a pull request:

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152944166 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -320,4 +559,40 @@ void

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265213#comment-16265213 ] ASF GitHub Bot commented on FLINK-8144: --- Github user dianfu commented on a diff in the pull request:

[jira] [Commented] (FLINK-8125) Support limiting the number of open FileSystem connections

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265231#comment-16265231 ] ASF GitHub Bot commented on FLINK-8125: --- Github user StephanEwen closed the pull request at:

[jira] [Created] (FLINK-8147) Support and to CEP's pattern API

2017-11-24 Thread Dian Fu (JIRA)
Dian Fu created FLINK-8147: -- Summary: Support and to CEP's pattern API Key: FLINK-8147 URL: https://issues.apache.org/jira/browse/FLINK-8147 Project: Flink Issue Type: Bug Components: CEP

[jira] [Commented] (FLINK-8139) Check for proper equals() and hashCode() when registering a table

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265244#comment-16265244 ] ASF GitHub Bot commented on FLINK-8139: --- Github user fhueske commented on the issue:

[jira] [Resolved] (FLINK-8117) Eliminate modulo operation from RoundRobinChannelSelector and RebalancePartitioner

2017-11-24 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay resolved FLINK-8117. Resolution: Implemented > Eliminate modulo operation from RoundRobinChannelSelector and >

[GitHub] flink issue #4481: [FLINK-7316][network] always use off-heap network buffers

2017-11-24 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4481 LGTM 👍 ---

[GitHub] flink pull request #5063: [FLINK-8144] [table] Optimize the timer logic in R...

2017-11-24 Thread dianfu
GitHub user dianfu opened a pull request: https://github.com/apache/flink/pull/5063 [FLINK-8144] [table] Optimize the timer logic in RowTimeUnboundedOver ## What is the purpose of the change *This pull request optimize the timer handling in RowTimeUnboundedOver. Currently

[GitHub] flink pull request #4940: [FLINK-7959] [table] Split CodeGenerator into Code...

2017-11-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4940#discussion_r152920044 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -114,9 +113,10 @@ class

[jira] [Commented] (FLINK-6909) Flink should support Lombok POJO

2017-11-24 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265118#comment-16265118 ] Timo Walther commented on FLINK-6909: - This looks like a bug to me. I will assign the issue to me and

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-24 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152918616 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -320,4 +559,40 @@ void

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265044#comment-16265044 ] ASF GitHub Bot commented on FLINK-7499: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265043#comment-16265043 ] ASF GitHub Bot commented on FLINK-7499: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-24 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152918323 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -300,6 +315,230 @@ public void

[jira] [Commented] (FLINK-8125) Support limiting the number of open FileSystem connections

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265063#comment-16265063 ] ASF GitHub Bot commented on FLINK-8125: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #5059: [FLINK-8125] [core] Introduce limiting of file system con...

2017-11-24 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5059 LGTM 👍 ---

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265088#comment-16265088 ] Fabian Hueske commented on FLINK-8144: -- Did you observe this behavior in practice, i.e., while

[jira] [Commented] (FLINK-7316) always use off-heap network buffers

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265104#comment-16265104 ] ASF GitHub Bot commented on FLINK-7316: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-7316) always use off-heap network buffers

2017-11-24 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-7316. - Resolution: Fixed Fix Version/s: 1.5.0 Merged in 1854a3de19. > always use off-heap

[jira] [Assigned] (FLINK-6909) Flink should support Lombok POJO

2017-11-24 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-6909: --- Assignee: Timo Walther > Flink should support Lombok POJO >

[GitHub] flink issue #5062: [FLINK-7880][QS] Wait for proper resource cleanup after e...

2017-11-24 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5062 This is a follow-up to https://github.com/apache/flink/pull/5062 ---

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265060#comment-16265060 ] ASF GitHub Bot commented on FLINK-7880: --- Github user kl0u commented on the issue:

[GitHub] flink pull request #4940: [FLINK-7959] [table] Split CodeGenerator into Code...

2017-11-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4940#discussion_r152921868 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGeneratorContext.scala --- @@ -0,0 +1,507 @@ +/* + *

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265073#comment-16265073 ] ASF GitHub Bot commented on FLINK-8144: --- GitHub user dianfu opened a pull request:

[GitHub] flink pull request #4940: [FLINK-7959] [table] Split CodeGenerator into Code...

2017-11-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4940#discussion_r152919537 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -1002,11 +999,13 @@ abstract class

[GitHub] flink pull request #4940: [FLINK-7959] [table] Split CodeGenerator into Code...

2017-11-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4940#discussion_r152923370 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/FunctionCodeGenerator.scala --- @@ -21,75 +21,49 @@ import

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265083#comment-16265083 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265081#comment-16265081 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265077#comment-16265077 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265076#comment-16265076 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265078#comment-16265078 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4940: [FLINK-7959] [table] Split CodeGenerator into Code...

2017-11-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4940#discussion_r152923905 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/InputFormatCodeGenerator.scala --- @@ -19,50 +19,47 @@ package

[GitHub] flink pull request #4940: [FLINK-7959] [table] Split CodeGenerator into Code...

2017-11-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4940#discussion_r152921238 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenUtils.scala --- @@ -203,6 +210,569 @@ object CodeGenUtils {

[GitHub] flink pull request #4940: [FLINK-7959] [table] Split CodeGenerator into Code...

2017-11-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4940#discussion_r152924498 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/CurrentTimePointCallGen.scala --- @@ -31,28 +32,28 @@ class

[GitHub] flink pull request #4940: [FLINK-7959] [table] Split CodeGenerator into Code...

2017-11-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4940#discussion_r152918458 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -985,14 +985,11 @@ abstract class

[jira] [Created] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread Dian Fu (JIRA)
Dian Fu created FLINK-8144: -- Summary: Optimize the timer logic in RowTimeUnboundedOver Key: FLINK-8144 URL: https://issues.apache.org/jira/browse/FLINK-8144 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265079#comment-16265079 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265082#comment-16265082 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265080#comment-16265080 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4481: [FLINK-7316][network] always use off-heap network ...

2017-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4481 ---

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265097#comment-16265097 ] ASF GitHub Bot commented on FLINK-8144: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7718) Port JobVertixMetricsHandler to new REST endpoint

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265048#comment-16265048 ] ASF GitHub Bot commented on FLINK-7718: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5055: [FLINK-7718] [flip6] Add JobVertexMetricsHandler t...

2017-11-24 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5055#discussion_r152917601 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/AbstractMetricsHandler.java --- @@ -0,0 +1,141 @@ +/*

[GitHub] flink pull request #5063: [FLINK-8144] [table] Optimize the timer logic in R...

2017-11-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5063#discussion_r152929249 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/RowTimeUnboundedOver.scala --- @@ -116,7 +116,7 @@ abstract

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265155#comment-16265155 ] ASF GitHub Bot commented on FLINK-7499: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

2017-11-24 Thread Aegeaner
GitHub user Aegeaner opened a pull request: https://github.com/apache/flink/pull/5065 [FLINK-8139][table] Check for proper equals() and hashCode() when reg… https://issues.apache.org/jira/browse/FLINK-8139 Check for proper equals() and hashCode() when registering a table.

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265239#comment-16265239 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152972414 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -715,4 +686,58 @@ private

[jira] [Commented] (FLINK-8093) flink job fail because of kafka producer create fail of "javax.management.InstanceAlreadyExistsException"

2017-11-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265290#comment-16265290 ] Aljoscha Krettek commented on FLINK-8093: - Do you mean thread safe or *not* thread safe? I think

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265293#comment-16265293 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152972034 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -306,51 +306,88 @@ public

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265296#comment-16265296 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152969860 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -330,64 +332,120 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152963546 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -330,64 +332,120 @@ public

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265294#comment-16265294 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265298#comment-16265298 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152972315 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -729,6 +804,12 @@ public Void

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265295#comment-16265295 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265297#comment-16265297 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152962580 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -330,64 +332,120 @@ public

[jira] [Closed] (FLINK-6294) BucketingSink throws NPE while cancelling job

2017-11-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-6294. --- Resolution: Fixed Fixed on release-1.3 in 5aea4917662d80899d3adff0378b97ae58aa2afc Fixed on

[GitHub] flink pull request #5066: [FLINK-8148][yarn/s3] fix test instability in Yarn...

2017-11-24 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5066 [FLINK-8148][yarn/s3] fix test instability in YarnFileStageTestS3ITCase ## What is the purpose of the change `YarnFileStageTestS3ITCase.testRecursiveUploadForYarn` verifies that the test

[jira] [Commented] (FLINK-8148) Test instability in YarnFileStageTest

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265301#comment-16265301 ] ASF GitHub Bot commented on FLINK-8148: --- GitHub user NicoK opened a pull request:

[jira] [Assigned] (FLINK-7694) Port JobMetricsHandler to new REST handler

2017-11-24 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-7694: --- Assignee: Gary Yao (was: Bowen Li) > Port JobMetricsHandler to new REST handler >

[jira] [Commented] (FLINK-8090) Improve error message when registering different states under the same name.

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265363#comment-16265363 ] ASF GitHub Bot commented on FLINK-8090: --- Github user xccui commented on the issue:

[GitHub] flink issue #5032: [FLINK-8090] [DataStream] Improve the error message for d...

2017-11-24 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/5032 Hi @aljoscha, I wonder if you could help review this PR when you are convenient. Thanks, Xingcan ---

[jira] [Updated] (FLINK-8147) Support and to CEP's pattern API

2017-11-24 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-8147: -- Issue Type: New Feature (was: Bug) > Support and to CEP's pattern API >

[jira] [Updated] (FLINK-8147) Support and to CEP's pattern API

2017-11-24 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-8147: -- Priority: Minor (was: Major) > Support and to CEP's pattern API >

[jira] [Commented] (FLINK-6909) Flink should support Lombok POJO

2017-11-24 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265280#comment-16265280 ] Timo Walther commented on FLINK-6909: - I tested a simple Lombok POJO and it worked as expected.

[jira] [Updated] (FLINK-7694) Port JobMetricsHandler to new REST handler

2017-11-24 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-7694: Labels: flip6 (was: ) > Port JobMetricsHandler to new REST handler >

[jira] [Updated] (FLINK-7694) Port JobMetricsHandler to new REST handler

2017-11-24 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-7694: Component/s: Distributed Coordination > Port JobMetricsHandler to new REST handler >

[jira] [Updated] (FLINK-6294) BucketingSink throws NPE while cancelling job

2017-11-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-6294: Fix Version/s: 1.4.1 1.3.3 > BucketingSink throws NPE while cancelling

  1   2   >