[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268593#comment-16268593
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268586#comment-16268586
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268595#comment-16268595
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268587#comment-16268587
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268596#comment-16268596
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268592#comment-16268592
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268597#comment-16268597
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268588#comment-16268588
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268591#comment-16268591
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268589#comment-16268589
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268594#comment-16268594
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268590#comment-16268590
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on a diff in the pull request:
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153456278
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -230,7 +230,7 @@ void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153457926
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,8 +244,79 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153455324
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,8 +244,79 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153455238
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,8 +244,79 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153460586
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -584,4 +587,60 @@ static CloseRequest
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153454649
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,8 +244,79 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153448085
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyMessageSerializationTest.java
---
@@ -158,6 +158,15 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153456963
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -145,19 +171,29 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153447906
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -584,4 +587,60 @@ static CloseRequest
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153456919
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -122,21 +136,33 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153446896
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -102,13 +102,21 @@ void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153457551
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,8 +244,79 @@ public void
[
https://issues.apache.org/jira/browse/FLINK-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann reassigned FLINK-8150:
Assignee: Till Rohrmann
> WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as
[
https://issues.apache.org/jira/browse/FLINK-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268553#comment-16268553
]
ASF GitHub Bot commented on FLINK-8104:
---
Github user twalthr commented on the issue:
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5040
Thanks. I will have a look at it soon. I think it ok that the Table API is
a super set of features in this case.
---
[
https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268547#comment-16268547
]
ASF GitHub Bot commented on FLINK-4812:
---
GitHub user zentol opened a pull request:
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5092
[FLINK-4812][metrics] Expose currentLowWatermark for all operators
## What is the purpose of the change
This PR makes all operators expose the current low watermark through the
metric
[
https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268540#comment-16268540
]
ASF GitHub Bot commented on FLINK-8144:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5063
Great, thank you!
---
[
https://issues.apache.org/jira/browse/FLINK-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268522#comment-16268522
]
ASF GitHub Bot commented on FLINK-8143:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5082#discussion_r153450679
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/SubtaskIndexPathParameter.java
---
@@ -0,0 +1,47 @@
+/*
+ *
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5070#discussion_r153449102
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/MapTypeTest.scala
---
@@ -139,13 +139,6 @@ class MapTypeTest
[
https://issues.apache.org/jira/browse/FLINK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268515#comment-16268515
]
ASF GitHub Bot commented on FLINK-8151:
---
Github user twalthr commented on a diff in the pull
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5070#discussion_r153448795
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala
---
@@ -188,13 +188,6 @@ object
[
https://issues.apache.org/jira/browse/FLINK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268514#comment-16268514
]
ASF GitHub Bot commented on FLINK-8151:
---
Github user twalthr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268511#comment-16268511
]
ASF GitHub Bot commented on FLINK-7717:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5081#discussion_r153448441
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/TaskManagerMetricsHandler.java
---
@@ -0,0 +1,64 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268500#comment-16268500
]
ASF GitHub Bot commented on FLINK-8161:
---
Github user tillrohrmann closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-8161.
Resolution: Fixed
Fixed via 7f0c8344c3bd066085b9aa1564849d7716b1ec7e
> Flakey
Github user tillrohrmann closed the pull request at:
https://github.com/apache/flink/pull/5085
---
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153445970
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -283,10 +283,13 @@ public String
[
https://issues.apache.org/jira/browse/FLINK-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268496#comment-16268496
]
ASF GitHub Bot commented on FLINK-8161:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268497#comment-16268497
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on a diff in the pull request:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5085
Merging.
---
[
https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268495#comment-16268495
]
ASF GitHub Bot commented on FLINK-8144:
---
Github user dianfu commented on the issue:
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/5063
The current known impact is that it will need to checkpoint more timer. For
the impact to performance, I will do some benchmark later. :)
I think we only need to consider this optimization if
[
https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268494#comment-16268494
]
Hequn Cheng commented on FLINK-8158:
OK, I will make a pr with test cases to reproduce the problem.
>
[
https://issues.apache.org/jira/browse/FLINK-7903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268478#comment-16268478
]
ASF GitHub Bot commented on FLINK-7903:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4889
Thanks for the review @zentol. Rebasing and once Travis gives green light,
I'll merge it.
---
[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268475#comment-16268475
]
ASF GitHub Bot commented on FLINK-7406:
---
Github user NicoK commented on a diff in the pull request:
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r153441043
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -306,12 +306,10 @@ public void
[
https://issues.apache.org/jira/browse/FLINK-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kostas Kloudas reassigned FLINK-8163:
-
Assignee: Kostas Kloudas
> NonHAQueryableStateFsBackendITCase test getting stuck on
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4581
test failures are unrelated this time (failing kafka download for the
end-to-end tests)
---
Till Rohrmann created FLINK-8163:
Summary: NonHAQueryableStateFsBackendITCase test getting stuck on
Travis
Key: FLINK-8163
URL: https://issues.apache.org/jira/browse/FLINK-8163
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268467#comment-16268467
]
ASF GitHub Bot commented on FLINK-7499:
---
Github user NicoK commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268465#comment-16268465
]
ASF GitHub Bot commented on FLINK-8144:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5063
Thank you @dianfu for the discussion.
I raised concerns about this PR because it seem to me to optimize for a
special use case and possibly cause regression for more common workloads.
However,
[
https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268431#comment-16268431
]
ASF GitHub Bot commented on FLINK-7873:
---
Github user StefanRRichter commented on a diff in the pull
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5074#discussion_r153432998
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/CachedCheckpointStreamFactory.java
---
@@ -0,0 +1,195 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268429#comment-16268429
]
ASF GitHub Bot commented on FLINK-7873:
---
Github user StefanRRichter commented on a diff in the pull
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r153432702
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala
---
@@ -60,4 +60,14 @@ trait TableSource[T] {
[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268430#comment-16268430
]
ASF GitHub Bot commented on FLINK-8122:
---
Github user xccui commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268427#comment-16268427
]
ASF GitHub Bot commented on FLINK-8106:
---
Github user dianfu commented on the issue:
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5074#discussion_r153432415
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/CachedCheckpointStreamFactory.java
---
@@ -0,0 +1,195 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268428#comment-16268428
]
ASF GitHub Bot commented on FLINK-8106:
---
Github user dianfu closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dian Fu closed FLINK-8106.
--
Resolution: Not A Problem
> Optimize the timer logic in AbstractKeyedCEPPatternOperator
>
Github user dianfu closed the pull request at:
https://github.com/apache/flink/pull/5036
---
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/5036
Close this PR for the same reason as #5063
---
[
https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dian Fu closed FLINK-8144.
--
Resolution: Not A Problem
> Optimize the timer logic in RowTimeUnboundedOver
>
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/5063
For historical reasons, we only use punctuated watermark currently. But I
think you are right, we should consider using periodic watermark instead.
Thanks a lot for your explanation. I will close
[
https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268419#comment-16268419
]
ASF GitHub Bot commented on FLINK-8144:
---
Github user dianfu commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268420#comment-16268420
]
ASF GitHub Bot commented on FLINK-8144:
---
Github user dianfu closed the pull request at:
Github user dianfu closed the pull request at:
https://github.com/apache/flink/pull/5063
---
[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268413#comment-16268413
]
ASF GitHub Bot commented on FLINK-8122:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r153430172
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala
---
@@ -60,4 +60,14 @@ trait TableSource[T] {
[
https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268409#comment-16268409
]
Fabian Hueske commented on FLINK-8158:
--
Hi [~hequn8128], thanks for looking into this!
Can you
[
https://issues.apache.org/jira/browse/FLINK-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268403#comment-16268403
]
ASF GitHub Bot commented on FLINK-4822:
---
Github user taizilongxu commented on a diff in the pull
Github user taizilongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/5050#discussion_r153426741
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/ZookeeperOffsetHandler.java
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5063
I assume you had also tried periodic watermarks in your setting. I'm
curious why they didn't work for you.
A periodic watermark assigner extracts the timestamp from each record and
just
[
https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268381#comment-16268381
]
ASF GitHub Bot commented on FLINK-8144:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5047
IMO, the added comment might rather confuse readers than help them.
---
[
https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268374#comment-16268374
]
ASF GitHub Bot commented on FLINK-7499:
---
Github user NicoK commented on the issue:
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4581
sorry about that - tested locally now and it should go through...we'll see
---
101 - 185 of 185 matches
Mail list logo
