Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
mxm commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434199585 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434216202 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java: ## @@ -83,12 +92,27 @@ default void

[jira] [Created] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
Trystan created FLINK-33926: --- Summary: Can't start a job with a jar in the system classpath in native k8s mode Key: FLINK-33926 URL: https://issues.apache.org/jira/browse/FLINK-33926 Project: Flink

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-21 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1434166658 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +97,115 @@ public

[jira] [Updated] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trystan updated FLINK-33926: Description: It appears that the combination of the running operator-controlled jobs in native k8s

[PR] Mircea - module 1 [flink-training]

2023-12-21 Thread via GitHub
ness-MirceaLutic opened a new pull request, #68: URL: https://github.com/apache/flink-training/pull/68 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trystan updated FLINK-33926: Description: It appears that the combination of the running operator-controlled jobs in native k8s +

[jira] [Updated] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trystan updated FLINK-33926: Description: It appears that the combination of the running operator-controlled jobs in native k8s +

[jira] [Updated] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trystan updated FLINK-33926: Description: It appears that the combination of the running operator-controlled jobs in native k8s +

[jira] [Updated] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trystan updated FLINK-33926: Component/s: Kubernetes Operator > Can't start a job with a jar in the system classpath in native k8s

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434209212 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434220037 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434211420 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

[jira] [Commented] (FLINK-20772) RocksDBValueState with TTL occurs NullPointerException when calling update(null) method

2023-12-21 Thread Seongbae Chang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799448#comment-17799448 ] Seongbae Chang commented on FLINK-20772: [~masteryhx], [~Zakelly] Sorry for the late response.

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434212997 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

[jira] [Updated] (FLINK-33926) Can't start a job with a jar in the system classpath in native k8s mode

2023-12-21 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trystan updated FLINK-33926: Description: It appears that the combination of the running operator-controlled jobs in native k8s +

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799583#comment-17799583 ] Sai Sharath Dandi commented on FLINK-33611: --- Fwiw, I've run into this issue for one of our

Re: [PR] [BP-1.18][FLINK-27082][ci] Adds a github-actions profile that disables certain tests that do not run in GHA [flink]

2023-12-21 Thread via GitHub
XComp commented on PR #23982: URL: https://github.com/apache/flink/pull/23982#issuecomment-1867063585 @snuyanzin can you do another quick pass over this one considering that there were some conflicts which I had to resolve? -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]

2023-12-21 Thread via GitHub
snuyanzin commented on code in PR #23962: URL: https://github.com/apache/flink/pull/23962#discussion_r1434572736 ## flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemTest.java: ## @@ -236,6 +237,7 @@ public void testRenameNonExistingFile() throws

Re: [PR] [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2023-12-21 Thread via GitHub
snuyanzin commented on PR #35: URL: https://github.com/apache/flink-connector-hbase/pull/35#issuecomment-1867027544 There was snappy update, probably need to add explicit dependency to cope with

Re: [PR] [BP-1.18][FLINK-27082][ci] Adds a github-actions profile that disables certain tests that do not run in GHA [flink]

2023-12-21 Thread via GitHub
flinkbot commented on PR #23982: URL: https://github.com/apache/flink/pull/23982#issuecomment-1867064898 ## CI report: * 6c905021e5b09a3537a68d208749bdc8ee1061f5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]

2023-12-21 Thread via GitHub
XComp merged PR #23962: URL: https://github.com/apache/flink/pull/23962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-25476) CharType lost in the creation of MaxAggFunction & MinAggFunction

2023-12-21 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799640#comment-17799640 ] dalongliu commented on FLINK-25476: --- Merged to master: 085859ec19f59d2f8e73632e96fae59f7821c7d0 >

[jira] [Commented] (FLINK-32513) Job in BATCH mode with a significant number of transformations freezes on method StreamGraphGenerator.existsUnboundedSource()

2023-12-21 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799647#comment-17799647 ] Zhu Zhu commented on FLINK-32513: - The problem happens because the {{getTransitivePredecessors()}} of

[jira] [Comment Edited] (FLINK-32513) Job in BATCH mode with a significant number of transformations freezes on method StreamGraphGenerator.existsUnboundedSource()

2023-12-21 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799647#comment-17799647 ] Zhu Zhu edited comment on FLINK-32513 at 12/22/23 2:46 AM: --- The problem

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.partition package of flink-runtime module [flink]

2023-12-21 Thread via GitHub
Jiabao-Sun commented on PR #23974: URL: https://github.com/apache/flink/pull/23974#issuecomment-1867163701 > After this PR, whether all tests in `io.network` have been migrated? Yes. Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-25476][table-planner] support CHAR type in function MAX and MIN [flink]

2023-12-21 Thread via GitHub
lsyldliu closed pull request #18375: [FLINK-25476][table-planner] support CHAR type in function MAX and MIN URL: https://github.com/apache/flink/pull/18375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (FLINK-25476) CharType lost in the creation of MaxAggFunction & MinAggFunction

2023-12-21 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu resolved FLINK-25476. --- Fix Version/s: 1.19.0 Resolution: Fixed > CharType lost in the creation of MaxAggFunction &

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.partition package of flink-runtime module [flink]

2023-12-21 Thread via GitHub
reswqa commented on PR #23974: URL: https://github.com/apache/flink/pull/23974#issuecomment-1867145877 After this PR, whether all tests in `io.network` have been migrated? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799560#comment-17799560 ] Sai Sharath Dandi commented on FLINK-33611: --- [~libenchao] , The constant pool size

Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]

2023-12-21 Thread via GitHub
XComp commented on code in PR #23962: URL: https://github.com/apache/flink/pull/23962#discussion_r1434558666 ## flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemTest.java: ## @@ -236,6 +237,7 @@ public void testRenameNonExistingFile() throws IOException {

Re: [PR] [FLINK-33611] [flink-protobuf] Support Large Protobuf Schemas [flink]

2023-12-21 Thread via GitHub
sharath1709 commented on PR #23937: URL: https://github.com/apache/flink/pull/23937#issuecomment-1866817077 @libenchao Thanks for the quick response. Sure, let's try to reach an agreement on the JIRA first -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Comment Edited] (FLINK-33611) Support Large Protobuf Schemas

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799560#comment-17799560 ] Sai Sharath Dandi edited comment on FLINK-33611 at 12/21/23 8:18 PM: -

[jira] [Comment Edited] (FLINK-33611) Support Large Protobuf Schemas

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799560#comment-17799560 ] Sai Sharath Dandi edited comment on FLINK-33611 at 12/21/23 9:22 PM: -

[jira] [Comment Edited] (FLINK-33611) Support Large Protobuf Schemas

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799560#comment-17799560 ] Sai Sharath Dandi edited comment on FLINK-33611 at 12/21/23 9:23 PM: -

[jira] [Updated] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Sharath Dandi updated FLINK-33817: -- Description: *Background*   The current Protobuf format

[jira] [Commented] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2023-12-21 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799584#comment-17799584 ] Sai Sharath Dandi commented on FLINK-33817: --- [~libenchao] , Can you please take a look at this

[jira] [Created] (FLINK-33920) StandaloneKubernetesTaskManagerFactory doesn't support recent config additions

2023-12-21 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-33920: -- Summary: StandaloneKubernetesTaskManagerFactory doesn't support recent config additions Key: FLINK-33920 URL: https://issues.apache.org/jira/browse/FLINK-33920 Project:

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-21 Thread via GitHub
yunfengzhou-hub commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1433735764 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CancelPartitionRequestTest.java: ## @@ -100,7 +102,12 @@ void

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-21 Thread via GitHub
yunfengzhou-hub commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1433736474 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionIndexRange.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-21 Thread via GitHub
yunfengzhou-hub commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1433743541 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/PartitionRequestClient.java: ## @@ -62,9 +62,11 @@ void requestSubpartition( *

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-21 Thread via GitHub
yunfengzhou-hub commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1433747654 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageConsumerClient.java: ## @@ -52,33 +55,39 @@

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-21 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1433757961 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,21 @@ private static Map

[PR] [Flink-33414] Fix the unstable test MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot [flink]

2023-12-21 Thread via GitHub
jiangxin369 opened a new pull request, #23977: URL: https://github.com/apache/flink/pull/23977 ## What is the purpose of the change Fix the unstable test MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot. ## Brief change log - Disable the resource

[jira] [Commented] (FLINK-33528) Externalize Python connector code

2023-12-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799315#comment-17799315 ] Sergey Nuyanzin commented on FLINK-33528: - [~pvary], [~dianfu] could you please clarify: once

Re: [PR] [Flink-33414] Fix the unstable test MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot [flink]

2023-12-21 Thread via GitHub
flinkbot commented on PR #23977: URL: https://github.com/apache/flink/pull/23977#issuecomment-1865908560 ## CI report: * 1c44cc409cb33b52bc60bb7582731ad90944993d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33528) Externalize Python connector code

2023-12-21 Thread Peter Vary (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799320#comment-17799320 ] Peter Vary commented on FLINK-33528: [~Sergey Nuyanzin]: FLINK-33762 is needed, so the connectors

Re: [PR] [FLINK-33877][streaming] Adjusting CollectSinkFunctionTest.testConfiguredPortIsUsed's assertion message to work with JDK 17 & 21 [flink]

2023-12-21 Thread via GitHub
Jiabao-Sun commented on PR #23976: URL: https://github.com/apache/flink/pull/23976#issuecomment-1865928438 @snuyanzin could you have a look please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-33877][streaming] Adjusting CollectSinkFunctionTest.testConfiguredPortIsUsed's assertion message to work with JDK 17 & 21 [flink]

2023-12-21 Thread via GitHub
snuyanzin commented on code in PR #23976: URL: https://github.com/apache/flink/pull/23976#discussion_r1433803550 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/collect/CollectSinkFunctionTest.java: ## @@ -136,9 +135,8 @@ void

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

2023-12-21 Thread via GitHub
pvary commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1433804590 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/TwoPhaseCommittingSink.java: ## @@ -40,17 +37,9 @@ * @param The type of the committables. */

Re: [PR] [FLINK-33877][streaming] Adjusting CollectSinkFunctionTest.testConfiguredPortIsUsed's assertion message to work with JDK 17 & 21 [flink]

2023-12-21 Thread via GitHub
snuyanzin commented on code in PR #23976: URL: https://github.com/apache/flink/pull/23976#discussion_r1433803072 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/collect/CollectSinkFunctionTest.java: ## @@ -136,9 +135,8 @@ void

[jira] [Updated] (FLINK-33922) table-planner jar will be removed as it is created at /tmp by default

2023-12-21 Thread Guojun Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guojun Li updated FLINK-33922: -- Attachment: (was: image-2023-12-21-17-31-29-220.png) > table-planner jar will be removed as it is

Re: [PR] [FLINK-33877][streaming] Adjusting CollectSinkFunctionTest.testConfiguredPortIsUsed's assertion message to work with JDK 17 & 21 [flink]

2023-12-21 Thread via GitHub
Jiabao-Sun commented on code in PR #23976: URL: https://github.com/apache/flink/pull/23976#discussion_r1433822304 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/collect/CollectSinkFunctionTest.java: ## @@ -136,9 +135,8 @@ void

Re: [PR] [FLINK-33877][streaming] Adjusting CollectSinkFunctionTest.testConfiguredPortIsUsed's assertion message to work with JDK 17 & 21 [flink]

2023-12-21 Thread via GitHub
Jiabao-Sun commented on code in PR #23976: URL: https://github.com/apache/flink/pull/23976#discussion_r1433817373 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/collect/CollectSinkFunctionTest.java: ## @@ -136,9 +135,8 @@ void

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

2023-12-21 Thread via GitHub
leonardBang commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1433838959 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/TwoPhaseCommittingSink.java: ## @@ -40,17 +37,9 @@ * @param The type of the committables. */

[jira] [Commented] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799347#comment-17799347 ] Sergey Nuyanzin commented on FLINK-33877: - Merged to master as

[jira] [Closed] (FLINK-33277) Upgrading to actions/checkout@v4 requires GLIBC 2.25, 2.27, or 2.28 to be installed, apparently

2023-12-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-33277. - Resolution: Duplicate I'm closing this one and created a duplicate issue under the FLINK-33901

[jira] [Assigned] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-33877: --- Assignee: Jiabao Sun > CollectSinkFunctionTest.testConfiguredPortIsUsed fails due

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-21 Thread via GitHub
yunfengzhou-hub commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1433753103 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SubpartitionSelector.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-21 Thread via GitHub
yunfengzhou-hub commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1433752308 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java: ## @@ -281,15 +271,9 @@ public SingleInputGate(

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-21 Thread via GitHub
yunfengzhou-hub commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1433793487 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/UnionResultSubpartitionViewTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the

[PR] Test [flink]

2023-12-21 Thread via GitHub
WencongLiu opened a new pull request, #23978: URL: https://github.com/apache/flink/pull/23978 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring

Re: [PR] Test [flink]

2023-12-21 Thread via GitHub
flinkbot commented on PR #23978: URL: https://github.com/apache/flink/pull/23978#issuecomment-1865950777 ## CI report: * 97d1ff4f56dfda3429263d7edf0493d4120d7d9c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33877][streaming] Adjusting CollectSinkFunctionTest.testConfiguredPortIsUsed's assertion message to work with JDK 17 & 21 [flink]

2023-12-21 Thread via GitHub
Jiabao-Sun commented on code in PR #23976: URL: https://github.com/apache/flink/pull/23976#discussion_r1433817373 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/collect/CollectSinkFunctionTest.java: ## @@ -136,9 +135,8 @@ void

Re: [PR] [FLINK-33877][streaming] Adjusting CollectSinkFunctionTest.testConfiguredPortIsUsed's assertion message to work with JDK 17 & 21 [flink]

2023-12-21 Thread via GitHub
snuyanzin merged PR #23976: URL: https://github.com/apache/flink/pull/23976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-33923) Upgrade upload-artifacts and download-artifacts to version 4

2023-12-21 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33923: - Summary: Upgrade upload-artifacts and download-artifacts to version 4 Key: FLINK-33923 URL: https://issues.apache.org/jira/browse/FLINK-33923 Project: Flink

Re: [PR] [FLINK-33883][jdbc] Bump CI flink version on flink-connector-jdbc to support flink 1.19 [flink-connector-jdbc]

2023-12-21 Thread via GitHub
snuyanzin merged PR #85: URL: https://github.com/apache/flink-connector-jdbc/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (FLINK-33883) Bump CI flink version on flink-connector-jdbc

2023-12-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33883. - Resolution: Fixed > Bump CI flink version on flink-connector-jdbc >

[jira] [Assigned] (FLINK-33883) Bump CI flink version on flink-connector-jdbc

2023-12-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-33883: --- Assignee: Jiabao Sun > Bump CI flink version on flink-connector-jdbc >

[jira] [Updated] (FLINK-33883) Bump CI flink version on flink-connector-jdbc

2023-12-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33883: Fix Version/s: jdbc-3.2.0 > Bump CI flink version on flink-connector-jdbc >

[jira] [Closed] (FLINK-33883) Bump CI flink version on flink-connector-jdbc

2023-12-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33883. --- > Bump CI flink version on flink-connector-jdbc > -

[jira] [Commented] (FLINK-33883) Bump CI flink version on flink-connector-jdbc

2023-12-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799351#comment-17799351 ] Sergey Nuyanzin commented on FLINK-33883: - Merged to main as

Re: [PR] [FLINK-33914][ci] Adds basic Flink CI workflow [flink]

2023-12-21 Thread via GitHub
snuyanzin commented on code in PR #23970: URL: https://github.com/apache/flink/pull/23970#discussion_r1433730346 ## .github/actions/set_java_in_container/action.yml: ## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-21 Thread via GitHub
yunfengzhou-hub commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1433740732 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java: ## @@ -1736,7 +1738,8 @@ private

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2023-12-21 Thread via GitHub
xintongsong commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1433693565 ## flink-core/src/main/java/org/apache/flink/api/common/TaskInfoImpl.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Updated] (FLINK-33905) FLIP-382: Unify the Provision of Diverse Metadata for Context-like APIs

2023-12-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33905: --- Labels: pull-request-available (was: ) > FLIP-382: Unify the Provision of Diverse Metadata

[jira] [Commented] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2023-12-21 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799308#comment-17799308 ] Jiang Xin commented on FLINK-33414: --- I also met the exception and after delving into the code, I found

[jira] [Comment Edited] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2023-12-21 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799308#comment-17799308 ] Jiang Xin edited comment on FLINK-33414 at 12/21/23 8:59 AM: - [~mapohl]

[jira] [Commented] (FLINK-33528) Externalize Python connector code

2023-12-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799321#comment-17799321 ] Sergey Nuyanzin commented on FLINK-33528: - ok I see, thanks for clarification > Externalize

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-21 Thread via GitHub
yunfengzhou-hub commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1433794402 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java: ## @@ -304,7 +306,15 @@ enum DataType {

[jira] [Comment Edited] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2023-12-21 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799308#comment-17799308 ] Jiang Xin edited comment on FLINK-33414 at 12/21/23 9:26 AM: - [~mapohl]

[jira] [Created] (FLINK-33921) Cleanup usage of deprecated IdleStateRetentionTime related method in org.apache.flink.table.api.TableConfig

2023-12-21 Thread Yubin Li (Jira)
Yubin Li created FLINK-33921: Summary: Cleanup usage of deprecated IdleStateRetentionTime related method in org.apache.flink.table.api.TableConfig Key: FLINK-33921 URL:

[jira] [Commented] (FLINK-33921) Cleanup usage of deprecated IdleStateRetentionTime related method in org.apache.flink.table.api.TableConfig

2023-12-21 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799328#comment-17799328 ] Yubin Li commented on FLINK-33921: -- [~qingyue] Could you please assign this to me? thanks! > Cleanup

[jira] [Created] (FLINK-33922) table-planner jar will be removed as it is created at /tmp by default

2023-12-21 Thread Guojun Li (Jira)
Guojun Li created FLINK-33922: - Summary: table-planner jar will be removed as it is created at /tmp by default Key: FLINK-33922 URL: https://issues.apache.org/jira/browse/FLINK-33922 Project: Flink

[jira] [Updated] (FLINK-33921) Cleanup usage of deprecated IdleStateRetentionTime related method in org.apache.flink.table.api.TableConfig

2023-12-21 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li updated FLINK-33921: - Parent: FLINK-31596 Issue Type: Sub-task (was: Improvement) > Cleanup usage of deprecated

Re: [PR] [FLINK-32721] [planner] Support CharType for the MaxAggFunction and M… [flink]

2023-12-21 Thread via GitHub
lsyldliu closed pull request #23121: [FLINK-32721] [planner] Support CharType for the MaxAggFunction and M… URL: https://github.com/apache/flink/pull/23121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (FLINK-33921) Cleanup usage of deprecated IdleStateRetentionTime related method in org.apache.flink.table.api.TableConfig

2023-12-21 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li updated FLINK-33921: - Description: getMinIdleStateRetentionTime() getMaxIdleStateRetentionTime() was:

Re: [PR] [FLINK-33877][streaming] Adjusting CollectSinkFunctionTest.testConfiguredPortIsUsed's assertion message to work with JDK 17 & 21 [flink]

2023-12-21 Thread via GitHub
snuyanzin commented on code in PR #23976: URL: https://github.com/apache/flink/pull/23976#discussion_r1433842115 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/collect/CollectSinkFunctionTest.java: ## @@ -136,9 +135,8 @@ void

[jira] [Closed] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33877. --- > CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException >

[jira] [Commented] (FLINK-33923) Upgrade upload-artifacts and download-artifacts to version 4

2023-12-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799346#comment-17799346 ] Matthias Pohl commented on FLINK-33923: --- See further reasoning in FLINK-33277 > Upgrade

[jira] [Resolved] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33877. - Resolution: Fixed > CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to

[jira] [Commented] (FLINK-33917) IllegalArgumentException: hostname can't be null

2023-12-21 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799352#comment-17799352 ] Maximilian Michels commented on FLINK-33917: The description doesn’t describe under which

[jira] [Commented] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-12-21 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799652#comment-17799652 ] Weijie Guo commented on FLINK-32850: master(1.19) via 462708228df253de09e0a002ee0f2bee94e701c5. >

[jira] [Updated] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-12-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-32850: --- Affects Version/s: 1.18.0 > [JUnit5 Migration] The io package of flink-runtime module >

[jira] [Resolved] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-12-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-32850. Resolution: Implemented All PRs merged, close this ticket > [JUnit5 Migration] The io package of

[jira] [Updated] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-12-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-32850: --- Fix Version/s: 1.19.0 > [JUnit5 Migration] The io package of flink-runtime module >

[jira] [Commented] (FLINK-33917) IllegalArgumentException: hostname can't be null

2023-12-21 Thread Tom (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799677#comment-17799677 ] Tom commented on FLINK-33917: - Actually uri("123-test") does work. The issue here is the  '.' followed by a

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-21 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799679#comment-17799679 ] xuyang commented on FLINK-33490: Hi, [~libenchao] .IIUC, do you mean we need to support the following

[jira] [Updated] (FLINK-33927) Cleanup usage of deprecated ExecutionConfigOptions#(TABLE_EXEC_SHUFFLE_MODE, TABLE_EXEC_LEGACY_TRANSFORMATION_UIDS)

2023-12-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33927: --- Labels: pull-request-available (was: ) > Cleanup usage of deprecated

[PR] [FLINK-33792] Generate the same code for the same logic [flink]

2023-12-21 Thread via GitHub
zoudan opened a new pull request, #23984: URL: https://github.com/apache/flink/pull/23984 ## What is the purpose of the change This pull request ensure that we generate the same code for the same logic, it is a precondition for sharing generated classes between different jobs.

  1   2   >