[jira] [Updated] (FLINK-2493) Simplify names of example program JARs

2015-08-12 Thread chenliang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenliang updated FLINK-2493: - Description: I find the names of the example JARs a bit annoying. Why not name the file {{examples/Connec

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694658#comment-14694658 ] ASF GitHub Bot commented on FLINK-2490: --- Github user HuangWHWHW commented on the pul

[jira] [Commented] (FLINK-2512) Add client.close() before throw RuntimeException

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694566#comment-14694566 ] ASF GitHub Bot commented on FLINK-2512: --- Github user ffbin commented on the pull req

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694548#comment-14694548 ] ASF GitHub Bot commented on FLINK-1901: --- Github user ChengXiangLi commented on a dif

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-12 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1008#issuecomment-130388161 No worries =) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...

2015-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1010 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694338#comment-14694338 ] ASF GitHub Bot commented on FLINK-1745: --- Github user kno10 commented on the pull req

[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...

2015-08-12 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1010#issuecomment-130443578 Thanks @StephanEwen merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Assigned] (FLINK-2501) [py] Remove the need to specify types for transformations

2015-08-12 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-2501: --- Assignee: Chesnay Schepler > [py] Remove the need to specify types for transformation

[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...

2015-08-12 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1010#issuecomment-130415584 +1, good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...

2015-08-12 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1010#issuecomment-130386385 +1 We agree that we would play it loose with style but this kind of cleanup helps readability. I will send PR to change the check style to be more stri

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-12 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1008#issuecomment-130369569 I thought not, but you are right, I pushed the wrong branch. Sorry, git-fail on my side! I'll push an update in a bit... --- If your project is set up f

[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...

2015-08-12 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1010#issuecomment-130386480 Builds pass, will merge this EOD if no more comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-2512]Add client.close() before throw Ru...

2015-08-12 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1009#issuecomment-130363877 Since ``getTopologyJobId`` can also throw exception, we could just move up the try-catch to include the call to that method and rely on finally to close the client. -

[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...

2015-08-12 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1010#issuecomment-130383158 I like this. I would actually like to make this a checkstyle rule. Most of the code is in this shape, occasional files go with a different style. --- If your pr

[jira] [Commented] (FLINK-2509) Improve error messages when user code classes are not found

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693925#comment-14693925 ] ASF GitHub Bot commented on FLINK-2509: --- Github user hsaputra commented on the pull

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-12 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-130384903 Oh apologies. I only saw the first comment on the email thread. I guess it's more or less settled. I'll leave it up to you guys to make a final decision on

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693899#comment-14693899 ] ASF GitHub Bot commented on FLINK-1819: --- Github user sachingoel0101 commented on the

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693893#comment-14693893 ] ASF GitHub Bot commented on FLINK-1819: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-12 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-130383984 I agree with Stephan's argument that addition of context to I/O formats is a very marginal enhancement. He literally stole my words. :') However, from my per

[jira] [Commented] (FLINK-2509) Improve error messages when user code classes are not found

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693831#comment-14693831 ] ASF GitHub Bot commented on FLINK-2509: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-12 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1008#issuecomment-130362926 HI @StephanEwen why is this PR is merged without addressing existing comments? --- If your project is set up for it, you can reply to this email and have your reply ap

[jira] [Commented] (FLINK-2512) Add client.close() before throw RuntimeException

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693775#comment-14693775 ] ASF GitHub Bot commented on FLINK-2512: --- Github user hsaputra commented on the pull

[jira] [Commented] (FLINK-2509) Improve error messages when user code classes are not found

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693766#comment-14693766 ] ASF GitHub Bot commented on FLINK-2509: --- Github user hsaputra commented on the pull

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693603#comment-14693603 ] ASF GitHub Bot commented on FLINK-1819: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-12 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-130324909 Functions also need to extend RichFunction to have access to `open()` and `close()`. I think the two things a different enough that any strife for "consistency" i

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-12 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-130324770 "Rich" does not refer to the number of methods but the fact that it has the RuntimeContext available. All non-rich variants do not get state inserted. This follows a naming c

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693602#comment-14693602 ] ASF GitHub Bot commented on FLINK-1819: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-2457] Integrate Tuple0

2015-08-12 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/983#issuecomment-130323723 I did the following changes: - added Tuple0 to `TupleGenerator.modifyTupleType()` - changes `LinkedList` to `ArrayList` in TupleGenerator to create code for `Tuple

[jira] [Commented] (FLINK-2457) Integrate Tuple0

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693595#comment-14693595 ] ASF GitHub Bot commented on FLINK-2457: --- Github user mjsax commented on the pull req

[jira] [Commented] (FLINK-2512) Add client.close() before throw RuntimeException

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693593#comment-14693593 ] ASF GitHub Bot commented on FLINK-2512: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-2512]Add client.close() before throw Ru...

2015-08-12 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1009#issuecomment-130323420 If you move the try up, you can certainly remove the manual close. Regarding the check in 103, it really depends on whether the Strom compat layer depends on having only a s

[jira] [Commented] (FLINK-2457) Integrate Tuple0

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693572#comment-14693572 ] ASF GitHub Bot commented on FLINK-2457: --- Github user mjsax commented on the pull req

[jira] [Commented] (FLINK-2457) Integrate Tuple0

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693570#comment-14693570 ] ASF GitHub Bot commented on FLINK-2457: --- Github user twalthr commented on the pull r

[GitHub] flink pull request: [FLINK-2457] Integrate Tuple0

2015-08-12 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/983#issuecomment-130320695 Your are right Tuple0 support for the TupleGenerator is not important. Actually, I meant the change of `import java.util.LinkedList;` to `import java.util.ArrayList;` oth

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-12 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-130318970 For transformation functions, there is a clear case for "thin" versus "rich", for Java8 lambdas. Input formats are a different game. They are super rich by default

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-12 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-130319656 To keep it consistent with the remaining API. For functions you need to extend a RichFunction if you want to have access to the RuntimeContext. I agree that the name is n

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693553#comment-14693553 ] ASF GitHub Bot commented on FLINK-1819: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-12 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-130319611 The suggestion `AbstractInputFormat` was not so bad, in my opinion. If you want a name that explains what's happening, you can always call it `InputFormatWithConte

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693554#comment-14693554 ] ASF GitHub Bot commented on FLINK-1819: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693549#comment-14693549 ] ASF GitHub Bot commented on FLINK-1819: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693546#comment-14693546 ] ASF GitHub Bot commented on FLINK-1819: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

2015-08-12 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-130318553 We are back to square one ;-) - `Function`: single abstract method - `RichFunction` = 5 methods. I see how that gets rich. - `InputFormat`:

[GitHub] flink pull request: [FLINK-2457] Integrate Tuple0

2015-08-12 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/983#issuecomment-130316822 Agree, Tuple0 should probably not go through the tuple generator. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[jira] [Commented] (FLINK-2457) Integrate Tuple0

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693527#comment-14693527 ] ASF GitHub Bot commented on FLINK-2457: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693496#comment-14693496 ] ASF GitHub Bot commented on FLINK-2490: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-12 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-130311909 Thank you! I`ll try again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-2508) Confusing sharing of StreamExecutionEnvironment

2015-08-12 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693474#comment-14693474 ] Maximilian Michels commented on FLINK-2508: --- Just like in {{ExecutionEnvironment

[GitHub] flink pull request: [FLINK-2457] Integrate Tuple0

2015-08-12 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/983#issuecomment-130298853 I modified by hand. Was not aware of `TupleGenerator`. Just had a look into it. Not sure if `Tuple0` can be included appropriately. For example, it is no generic class; it

[jira] [Commented] (FLINK-2457) Integrate Tuple0

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693466#comment-14693466 ] ASF GitHub Bot commented on FLINK-2457: --- Github user mjsax commented on the pull req

[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693457#comment-14693457 ] ASF GitHub Bot commented on FLINK-2480: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-2480][test]Add tests for PrintSinkFunct...

2015-08-12 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/991#issuecomment-130295740 Your pull request doesn't compile: https://s3.amazonaws.com/archive.travis-ci.org/jobs/74504427/log.txt --- If your project is set up for it, you can reply to this email and

[jira] [Updated] (FLINK-2506) HBase connection closing down (table distributed over more than 1 region server - Flink Cluster-Mode)

2015-08-12 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-2506: -- Description: If I fill a default table (create 'test-table', 'someCf') with the HBaseWr

[jira] [Commented] (FLINK-2491) Operators are not participating in state checkpointing in some cases

2015-08-12 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693387#comment-14693387 ] Márton Balassi commented on FLINK-2491: --- Here is the root cause. [1] [1] https://g

[GitHub] flink pull request: [FLINK-2457] Integrate Tuple0

2015-08-12 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/983#issuecomment-130251096 The typeutil classes look good. I see that you have modified the TupleXXBuilders, have you modified them by hand or by running the `TupleGenerator`? I can't see the modif

[jira] [Commented] (FLINK-2491) Operators are not participating in state checkpointing in some cases

2015-08-12 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693304#comment-14693304 ] Márton Balassi commented on FLINK-2491: --- This is troublesome, when setting log level

[GitHub] flink pull request: [FLINK-2437] Fix default constructor detection...

2015-08-12 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/960#issuecomment-130251642 Thanks for your contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[jira] [Closed] (FLINK-2437) TypeExtractor.analyzePojo has some problems around the default constructor detection

2015-08-12 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-2437. - Resolution: Fixed > TypeExtractor.analyzePojo has some problems around the default constru

[jira] [Commented] (FLINK-2437) TypeExtractor.analyzePojo has some problems around the default constructor detection

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693298#comment-14693298 ] ASF GitHub Bot commented on FLINK-2437: --- Github user mxm commented on the pull reque

[jira] [Updated] (FLINK-2437) TypeExtractor.analyzePojo has some problems around the default constructor detection

2015-08-12 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-2437: -- Affects Version/s: 0.9.0 0.10 > TypeExtractor.analyzePojo has som

[jira] [Updated] (FLINK-2437) TypeExtractor.analyzePojo has some problems around the default constructor detection

2015-08-12 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-2437: -- Fix Version/s: 0.9.1 0.10 > TypeExtractor.analyzePojo has some proble

[jira] [Commented] (FLINK-2437) TypeExtractor.analyzePojo has some problems around the default constructor detection

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693294#comment-14693294 ] ASF GitHub Bot commented on FLINK-2437: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2437] Fix default constructor detection...

2015-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (FLINK-2457) Integrate Tuple0

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693292#comment-14693292 ] ASF GitHub Bot commented on FLINK-2457: --- Github user twalthr commented on the pull r

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693288#comment-14693288 ] ASF GitHub Bot commented on FLINK-1901: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request: [FLINK-1901] [core] Create sample operator for...

2015-08-12 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/949#discussion_r36844879 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/operators/util/RandomSamplerTest.java --- @@ -0,0 +1,425 @@ +/* + * Licensed to the Ap

[jira] [Commented] (FLINK-2508) Confusing sharing of StreamExecutionEnvironment

2015-08-12 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693282#comment-14693282 ] Márton Balassi commented on FLINK-2508: --- Thanks for spotting this, I think the purpo

[jira] [Commented] (FLINK-2437) TypeExtractor.analyzePojo has some problems around the default constructor detection

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693245#comment-14693245 ] ASF GitHub Bot commented on FLINK-2437: --- Github user ggevay commented on a diff in t

[GitHub] flink pull request: [FLINK-2437] Fix default constructor detection...

2015-08-12 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/960#discussion_r36843332 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -1328,24 +1329,29 @@ else if(typeHierarchy.size() <= 1) {

[jira] [Commented] (FLINK-2399) Fail when actor versions don't match

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693235#comment-14693235 ] ASF GitHub Bot commented on FLINK-2399: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [FLINK-2399] Version checks for Job Manager an...

2015-08-12 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/945#issuecomment-130241985 I've already added a version check between `JobClient` and `JobManager`. Will there be any further review of this? --- If your project is set up for it, you can r

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-12 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-130237642 > 1.In using StringBuilder, does it mean that we should use BufferedReader.readLine() instead of BufferedReader.read()? Reading by character is the way to go if we us

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693224#comment-14693224 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on the pull reque

[jira] [Closed] (FLINK-2507) Rename the function tansformAndEmit in org.apache.flink.stormcompatibility.wrappers.AbstractStormCollector

2015-08-12 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-2507. - Resolution: Fixed Fix Version/s: 0.10 Via 54311aa. > Rename the function tansformAndEmit i

[GitHub] flink pull request: [FLINK-2507]Rename the function tansformAndEmi...

2015-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1007 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2507) Rename the function tansformAndEmit in org.apache.flink.stormcompatibility.wrappers.AbstractStormCollector

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693214#comment-14693214 ] ASF GitHub Bot commented on FLINK-2507: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2512]Add client.close() before throw Ru...

2015-08-12 Thread ffbin
Github user ffbin commented on the pull request: https://github.com/apache/flink/pull/1009#issuecomment-130233136 @uce Thanks. What about remove "if(client.getTopologyJobId(name) != null) {...}" in line 103, because submitTopologyWithOpts() has check it at the head of function and wil

[jira] [Commented] (FLINK-2512) Add client.close() before throw RuntimeException

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693199#comment-14693199 ] ASF GitHub Bot commented on FLINK-2512: --- Github user ffbin commented on the pull req

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693183#comment-14693183 ] ASF GitHub Bot commented on FLINK-2490: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-12 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-130228505 Hi, there are two more questions: 1.In using StringBuilder, does it mean that we should use BufferedReader.readLine() instead of BufferedReader.read()? 2.Could

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693170#comment-14693170 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-12 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-130222078 Actually point 3 is not so bad because we're using a buffered reader that fills the buffer and does not read a character from the socket on every call to `read()`. T

[GitHub] flink pull request: [FLINK-2507]Rename the function tansformAndEmi...

2015-08-12 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/1007#issuecomment-130219835 Will merge this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[jira] [Commented] (FLINK-2507) Rename the function tansformAndEmit in org.apache.flink.stormcompatibility.wrappers.AbstractStormCollector

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693147#comment-14693147 ] ASF GitHub Bot commented on FLINK-2507: --- Github user mbalassi commented on the pull

[GitHub] flink pull request: [FLINK-2437] Fix default constructor detection...

2015-08-12 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/960#issuecomment-130219402 Your changes look good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-2437) TypeExtractor.analyzePojo has some problems around the default constructor detection

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693141#comment-14693141 ] ASF GitHub Bot commented on FLINK-2437: --- Github user mxm commented on the pull reque

[jira] [Commented] (FLINK-2437) TypeExtractor.analyzePojo has some problems around the default constructor detection

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693133#comment-14693133 ] ASF GitHub Bot commented on FLINK-2437: --- Github user mxm commented on a diff in the

[GitHub] flink pull request: [FLINK-2437] Fix default constructor detection...

2015-08-12 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/960#discussion_r36837638 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -1328,24 +1329,29 @@ else if(typeHierarchy.size() <= 1) {

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693127#comment-14693127 ] ASF GitHub Bot commented on FLINK-2490: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-12 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-130217420 @mxm Hi, thank you for suggestions. I will try to follow your suggestions and improve the test. I understand almost of yours and I also read the Class docum

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-12 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-130213092 @HuangWHWHW `read()` method of the `BufferedReader` object returns `-1` in case the end of the stream has been reached. A couple of things I noticed apart from the `r

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693104#comment-14693104 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on the pull reque

[jira] [Commented] (FLINK-2457) Integrate Tuple0

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693091#comment-14693091 ] ASF GitHub Bot commented on FLINK-2457: --- Github user mjsax commented on the pull req

[GitHub] flink pull request: [FLINK-2457] Integrate Tuple0

2015-08-12 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/983#issuecomment-130211866 Any news about this PR? @twalthr : Are you going to review it again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Closed] (FLINK-2509) Improve error messages when user code classes are not found

2015-08-12 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2509. --- > Improve error messages when user code classes are not found > --

[jira] [Resolved] (FLINK-2509) Improve error messages when user code classes are not found

2015-08-12 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2509. - Resolution: Implemented Implemented in eeec1912b478ed43a045449d82e0a2fd3700d720 > Improve error m

[jira] [Commented] (FLINK-2509) Improve error messages when user code classes are not found

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693086#comment-14693086 ] ASF GitHub Bot commented on FLINK-2509: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1008 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693076#comment-14693076 ] ASF GitHub Bot commented on FLINK-2490: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-12 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1008#discussion_r36834144 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/ClassLoaderUtilsTest.java --- @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Softwa

  1   2   >