Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131496338
I'd like to get this merged soon. This removes multiple constructors for
Runtime contexts and establishes a clean hierarchy, making any changes to the
[
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698561#comment-14698561
]
ASF GitHub Bot commented on FLINK-2458:
---
Github user sachingoel0101 commented on the
zhangrucong created FLINK-2531:
--
Summary: combining the if branch to improve the performance
Key: FLINK-2531
URL: https://issues.apache.org/jira/browse/FLINK-2531
Project: Flink
Issue Type: Bug
GitHub user Rucongzhang opened a pull request:
https://github.com/apache/flink/pull/1025
[flink-2532]fix the function name and the variable name are the same
In class StreamWindow, in function split, there is a list variable also
called split. Two split are confusing , and the
[
https://issues.apache.org/jira/browse/FLINK-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698546#comment-14698546
]
ASF GitHub Bot commented on FLINK-2478:
---
Github user Rucongzhang commented on the
Github user Rucongzhang commented on the pull request:
https://github.com/apache/flink/pull/1021#issuecomment-131493503
Yes,stephan it should throw an exception.I will modify .Thank you very
much!
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/FLINK-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698556#comment-14698556
]
ASF GitHub Bot commented on FLINK-2526:
---
Github user ffbin commented on the pull
Github user ffbin closed the pull request at:
https://github.com/apache/flink/pull/1020
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1020#issuecomment-131495368
@StephanEwen Thanks. I think you pull request has fixes this.I will close
my pull request and view your code.
---
If your project is set up for it, you can reply to
fangfengbin created FLINK-2530:
--
Summary: optimize equal() of AcknowledgeCheckpoint
Key: FLINK-2530
URL: https://issues.apache.org/jira/browse/FLINK-2530
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698569#comment-14698569
]
Henry Saputra commented on FLINK-2531:
--
Could you please add more description on how
[
https://issues.apache.org/jira/browse/FLINK-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698557#comment-14698557
]
ASF GitHub Bot commented on FLINK-2526:
---
Github user ffbin closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698566#comment-14698566
]
ASF GitHub Bot commented on FLINK-2462:
---
Github user zentol commented on a diff in
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1017#discussion_r37143081
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -27,114
[
https://issues.apache.org/jira/browse/FLINK-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Saputra closed FLINK-2531.
Resolution: Cannot Reproduce
Closing it until the reporter add more description to reproduce the
[
https://issues.apache.org/jira/browse/FLINK-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sachin Goel reassigned FLINK-2524:
--
Assignee: Sachin Goel
Add getTaskNameWithSubtasks() to RuntimeContext
[
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698600#comment-14698600
]
ASF GitHub Bot commented on FLINK-2458:
---
Github user sachingoel0101 commented on a
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r37143936
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -897,7 +897,7 @@ class TaskManager(
Github user ffbin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1017#discussion_r37142604
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -27,114
[
https://issues.apache.org/jira/browse/FLINK-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698554#comment-14698554
]
ASF GitHub Bot commented on FLINK-2462:
---
Github user ffbin commented on a diff in
GitHub user Rucongzhang opened a pull request:
https://github.com/apache/flink/pull/1023
[FLINK-2531]combining the if branch to improve the judge logic
In function receiveAcknowledgeMessage, the if branch
checkpoint.isFullyAcknowledged() can combine with the if branch if
[
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698592#comment-14698592
]
ASF GitHub Bot commented on FLINK-2458:
---
Github user sachingoel0101 commented on the
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698595#comment-14698595
]
Sachin Goel commented on FLINK-2488:
Implemented in
[
https://issues.apache.org/jira/browse/FLINK-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698596#comment-14698596
]
Sachin Goel commented on FLINK-2449:
This functionality is now supported through
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/1024
[FLINK-2530]optimize equal() of AcknowledgeCheckpoint
optimize repeated check of this.state == null
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/FLINK-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Saputra reopened FLINK-2531:
--
PR is submitted, so re-open the issue. Please add more description to the JIRA
issue.
combining
Github user Rucongzhang commented on the pull request:
https://github.com/apache/flink/pull/1023#issuecomment-131504171
@chiwanpark , you are right. isFullyAcknowledged() must be called after
calling function acknowledgeTask.
---
If your project is set up for it, you can reply to
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37143932
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/FieldStats.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1023#issuecomment-131503780
-1 for merging. I'm not an expert on flink-runtime, so I'm not sure but we
cannot merge this PR.
Because `acknowledgeTask` method change status of
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131504643
I decided to go ahead and implement things which touch the Runtime Context
constructors with this PR. This now closes five Jiras, namely 2449, 2458, 2488,
2496
[
https://issues.apache.org/jira/browse/FLINK-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698571#comment-14698571
]
Henry Saputra commented on FLINK-2530:
--
Could you kindly add more information on the
[
https://issues.apache.org/jira/browse/FLINK-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698581#comment-14698581
]
ASF GitHub Bot commented on FLINK-2530:
---
GitHub user ffbin opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698583#comment-14698583
]
ASF GitHub Bot commented on FLINK-2531:
---
Github user chiwanpark commented on the
[
https://issues.apache.org/jira/browse/FLINK-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698588#comment-14698588
]
ASF GitHub Bot commented on FLINK-2531:
---
Github user Rucongzhang commented on the
[
https://issues.apache.org/jira/browse/FLINK-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698594#comment-14698594
]
Sachin Goel commented on FLINK-2524:
Implemented in
[
https://issues.apache.org/jira/browse/FLINK-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698593#comment-14698593
]
Sachin Goel commented on FLINK-2496:
This is implemented in
[
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698598#comment-14698598
]
ASF GitHub Bot commented on FLINK-2458:
---
Github user hsaputra commented on a diff in
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r37143896
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -897,7 +897,7 @@ class TaskManager(
[
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698614#comment-14698614
]
ASF GitHub Bot commented on FLINK-2458:
---
Github user sachingoel0101 commented on the
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131519550
Reverting back to make this PR only about the distributed cache.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-131512180
@sachingoel0101 There is no need to forgive. I just reviewed this PR and
left my opinions. :) If you feel that my comments is aggressive, I'm sorry
about that.
[
https://issues.apache.org/jira/browse/FLINK-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698603#comment-14698603
]
ASF GitHub Bot commented on FLINK-2530:
---
Github user zentol commented on the pull
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37144073
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/MLUtils.scala ---
@@ -119,4 +120,31 @@ object MLUtils {
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1024#issuecomment-131512254
i don't think these statements are equivalent.
Assume that this.state == null and that.state != null.
In the original version we evaluate that.state ==
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37144068
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/MLUtils.scala ---
@@ -119,4 +120,31 @@ object MLUtils {
[
https://issues.apache.org/jira/browse/FLINK-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698638#comment-14698638
]
ASF GitHub Bot commented on FLINK-2530:
---
Github user zentol commented on the pull
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1024#issuecomment-131534953
Looking at the pure logic this would work, but you can't remove that.state
!= null since that could result in a NullPointerException inside equals.
---
If your project
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r37144152
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -897,7 +897,7 @@ class TaskManager(
[
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698604#comment-14698604
]
ASF GitHub Bot commented on FLINK-2458:
---
Github user zentol commented on a diff in
Github user gyfora commented on a diff in the pull request:
https://github.com/apache/flink/pull/1017#discussion_r37144298
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamIterationTail.java
---
@@ -25,65
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-131518423
The occasional space issues are because I stopped using Idea's reformat
tool. It sometimes messes up the indentations. :')
And no. Your comments weren't
[
https://issues.apache.org/jira/browse/FLINK-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698612#comment-14698612
]
ASF GitHub Bot commented on FLINK-2462:
---
Github user gyfora commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698610#comment-14698610
]
ASF GitHub Bot commented on FLINK-2458:
---
Github user zentol commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698616#comment-14698616
]
ASF GitHub Bot commented on FLINK-2488:
---
GitHub user sachingoel0101 opened a pull
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-131523559
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-131509499
Hi @chiwanpark , I've fixed the *cosmetic* issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37144130
--- Diff: docs/libs/ml/statistics.md ---
@@ -0,0 +1,100 @@
+---
+mathjax: include
+htmlTitle: FlinkML - Statistics
+title: a
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-131514958
I found some points to improve and added line notes. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37144066
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/MLUtils.scala ---
@@ -119,4 +120,31 @@ object MLUtils {
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37144175
--- Diff: docs/libs/ml/statistics.md ---
@@ -0,0 +1,100 @@
+---
+mathjax: include
+htmlTitle: FlinkML - Statistics
+title: a
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37144173
--- Diff: docs/libs/ml/statistics.md ---
@@ -0,0 +1,100 @@
+---
+mathjax: include
+htmlTitle: FlinkML - Statistics
+title: a
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37144171
--- Diff: docs/libs/ml/statistics.md ---
@@ -0,0 +1,100 @@
+---
+mathjax: include
+htmlTitle: FlinkML - Statistics
+title: a
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r37144275
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -897,7 +897,7 @@ class TaskManager(
[
https://issues.apache.org/jira/browse/FLINK-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huang Wei updated FLINK-2529:
-
Description:
In file BlobServer.java, I found the Thread.currentThread() will never return
null in my
[
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698607#comment-14698607
]
ASF GitHub Bot commented on FLINK-2458:
---
Github user sachingoel0101 commented on a
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37144183
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/CategoricalHistogram.scala
---
@@ -0,0 +1,129 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37144182
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/CategoricalHistogram.scala
---
@@ -0,0 +1,129 @@
+/*
+ * Licensed
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r37144194
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -897,7 +897,7 @@ class TaskManager(
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37144195
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/CategoricalHistogram.scala
---
@@ -0,0 +1,129 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37144192
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/statistics/CategoricalHistogram.scala
---
@@ -0,0 +1,129 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698613#comment-14698613
]
ASF GitHub Bot commented on FLINK-2458:
---
Github user sachingoel0101 commented on a
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/1026
[FLINK-2488][FLINK-2496] Expose Task Manager configuration and Task attempt
number to Runtime context
This PR fixes these issues:
1. [FLINK-2496]Expose Task Manager configuration to
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37144137
--- Diff: docs/libs/ml/statistics.md ---
@@ -0,0 +1,100 @@
+---
+mathjax: include
+htmlTitle: FlinkML - Statistics
+title: a
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-131520764
I just found that `Predef.assume` could be replaced by `assume`. Sorry for
wrong guidance. Could you change `Predef.assume` to `assume`?
---
If your project is set
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1024#issuecomment-131577837
Is this really in need of optimization? It is written failsafe, where it
does not crash even if `state` does not handle null values properly. This is
good, because
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131579342
Looks good, merging this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698745#comment-14698745
]
ASF GitHub Bot commented on FLINK-2458:
---
Github user StephanEwen commented on the
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated FLINK-2525:
---
Affects Version/s: (was: 0.8.1)
Add configuration support in Storm-compatibility
GitHub user ggevay opened a pull request:
https://github.com/apache/flink/pull/1027
[FLINK-2527] [gelly] Ensure that VertexUpdateFunction.setNewVertexValue is
called at most once
I implemented (1), with the check to enforce that it is called at most
once. Unfortunately, I had to
[
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698711#comment-14698711
]
ASF GitHub Bot commented on FLINK-2458:
---
Github user StephanEwen commented on the
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1019#issuecomment-131578024
This looks good, will merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698743#comment-14698743
]
ASF GitHub Bot commented on FLINK-2314:
---
Github user StephanEwen commented on the
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131570065
We are indeed falling behind on merging pull requests, right now. Many
committers are on vacation this month, and for the others, the large amount of
pull requests
[
https://issues.apache.org/jira/browse/FLINK-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698717#comment-14698717
]
ASF GitHub Bot commented on FLINK-2462:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131570789
Aside from the comment above, this looks good. Would merge this, after the
comment is addressed.
---
If your project is set up for it, you can reply to this email
[
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698716#comment-14698716
]
ASF GitHub Bot commented on FLINK-2458:
---
Github user StephanEwen commented on the
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1017#discussion_r37146789
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamIterationTail.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698738#comment-14698738
]
ASF GitHub Bot commented on FLINK-2527:
---
Github user StephanEwen commented on the
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1027#issuecomment-131576936
I think you can make this non-API-breaking by simply throwing an
`IllegalStateException`, which is a `RuntimeException` and therefore needs no
part in the
[
https://issues.apache.org/jira/browse/FLINK-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698670#comment-14698670
]
ASF GitHub Bot commented on FLINK-2527:
---
GitHub user ggevay opened a pull request:
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1017#discussion_r37146808
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698718#comment-14698718
]
ASF GitHub Bot commented on FLINK-2462:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698790#comment-14698790
]
ASF GitHub Bot commented on FLINK-2458:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698793#comment-14698793
]
Stephan Ewen commented on FLINK-2487:
-
Added a fix in
[
https://issues.apache.org/jira/browse/FLINK-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698791#comment-14698791
]
ASF GitHub Bot commented on FLINK-2478:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/970
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/997#issuecomment-131578723
Thanks for updating the pull request. I'll try to have a look at this in a
bit!
---
If your project is set up for it, you can reply to this email and have your
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated FLINK-2525:
---
Description: Spouts and Bolt are initialized by a call to `Spout.open(...)`
and
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1021
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131570435
In the `CollectionExecutor`, can you skip creating the `ExecutiorService`?
You can eagerly resolve the path and then put an already finished future into
the map.
1 - 100 of 129 matches
Mail list logo
