[jira] [Commented] (FLINK-6588) Rename NumberOfFullRestarts metric

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091114#comment-16091114 ] ASF GitHub Bot commented on FLINK-6588: --- Github user zjureel commented on the issue:

[GitHub] flink issue #4292: [FLINK-6588] Rename NumberOfFullRestarts metric

2017-07-17 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4292 @zentol What do you think of @StephanEwen 's suggestion? I think this change does cause some incompatibilities for user, thanks --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-6667) Pass a callback type to the RestartStrategy, rather than the full ExecutionGraph

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091112#comment-16091112 ] ASF GitHub Bot commented on FLINK-6667: --- Github user zjureel commented on the issue:

[GitHub] flink issue #4277: [FLINK-6667] Pass a callback type to the RestartStrategy,...

2017-07-17 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4277 Thank you for your reply, I will fix [FLINK-6665](https://issues.apache.org/jira/browse/FLINK-6665) after this PR is merged, thanks :) --- If your project is set up for it, you can reply to this em

[jira] [Commented] (FLINK-7118) Remove hadoop1.x code in HadoopUtils

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091067#comment-16091067 ] ASF GitHub Bot commented on FLINK-7118: --- Github user zhangminglei commented on the i

[GitHub] flink issue #4285: [FLINK-7118] [hadoop] Remove hadoop1.x code in HadoopUtil...

2017-07-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4285 @StephanEwen PR have been updated. Please check it out again ~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] flink issue #4347: [FLINK-7201] fix concurrency in JobLeaderIdService when s...

2017-07-17 Thread XuPingyong
Github user XuPingyong commented on the issue: https://github.com/apache/flink/pull/4347 @StephanEwen , rpcService of ResourceManager executes with only one single thread, so there is no conflicts when resourcemanager is in service. When resourceManager is shutdown by the other threa

[jira] [Commented] (FLINK-7201) ConcurrentModificationException in JobLeaderIdService

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091053#comment-16091053 ] ASF GitHub Bot commented on FLINK-7201: --- Github user XuPingyong commented on the iss

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-17 Thread Ruidong Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091036#comment-16091036 ] Ruidong Li commented on FLINK-7194: --- {{ScalarFunction.getResultType()}} has parameters w

[GitHub] flink issue #4328: [FLINK-6493] Fix ineffective null check in RegisteredOper...

2017-07-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4328 PR has been updated. Please helps to check again. Thanks ~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[jira] [Commented] (FLINK-6493) Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091034#comment-16091034 ] ASF GitHub Bot commented on FLINK-6493: --- Github user zhangminglei commented on the i

[jira] [Commented] (FLINK-6105) Properly handle InterruptedException in HadoopInputFormatBase

2017-07-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091003#comment-16091003 ] Ted Yu commented on FLINK-6105: --- Using InterruptedIOException is common practice in handling

[jira] [Commented] (FLINK-6105) Properly handle InterruptedException in HadoopInputFormatBase

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090997#comment-16090997 ] ASF GitHub Bot commented on FLINK-6105: --- Github user zhangminglei commented on the i

[GitHub] flink issue #4316: [FLINK-6105] Use InterruptedIOException instead of IOExce...

2017-07-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4316 Maybe @tedyu could share some light on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[jira] [Commented] (FLINK-6893) Add BIN supported in SQL

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090992#comment-16090992 ] ASF GitHub Bot commented on FLINK-6893: --- Github user wuchong commented on a diff in

[jira] [Commented] (FLINK-6893) Add BIN supported in SQL

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090993#comment-16090993 ] ASF GitHub Bot commented on FLINK-6893: --- Github user wuchong commented on a diff in

[jira] [Commented] (FLINK-6893) Add BIN supported in SQL

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090994#comment-16090994 ] ASF GitHub Bot commented on FLINK-6893: --- Github user wuchong commented on a diff in

[GitHub] flink pull request #4128: [FLINK-6893][table]Add BIN supported in SQL

2017-07-17 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4128#discussion_r127868400 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala --- @@ -33,6 +33,14 @@ object ScalarSqlFu

[GitHub] flink pull request #4128: [FLINK-6893][table]Add BIN supported in SQL

2017-07-17 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4128#discussion_r127866461 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala --- @@ -82,4 +82,24 @@ object ScalarFunc

[GitHub] flink pull request #4128: [FLINK-6893][table]Add BIN supported in SQL

2017-07-17 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4128#discussion_r127868565 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala --- @@ -352,6 +352,14 @@ class ScalarFunct

[jira] [Commented] (FLINK-7162) Tests should not write outside 'target' directory.

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090948#comment-16090948 ] ASF GitHub Bot commented on FLINK-7162: --- Github user zhangminglei commented on the i

[GitHub] flink issue #4311: [FLINK-7162] [test] Tests should not write outside 'targe...

2017-07-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4311 Thanks @StephanEwen for generous review. All proposes have been addressed. PR updated again. Please helps to check :) --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-6923) Kafka connector needs to expose information about in-flight record in AbstractFetcher base class

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090762#comment-16090762 ] ASF GitHub Bot commented on FLINK-6923: --- Github user zhenzhongxu commented on the is

[GitHub] flink issue #4149: [FLINK-6923] [Kafka Connector] Expose in-processing/in-fl...

2017-07-17 Thread zhenzhongxu
Github user zhenzhongxu commented on the issue: https://github.com/apache/flink/pull/4149 Sounds fair. @aljoscha @tzulitai Any recommendations on what particular test and where I should put the tests in? I'll also improve the documentation as well. --- If your project is set up for

[GitHub] flink pull request #4187: [FLINK-6998][Kafka Connector] Add kafka offset com...

2017-07-17 Thread zhenzhongxu
Github user zhenzhongxu commented on a diff in the pull request: https://github.com/apache/flink/pull/4187#discussion_r127842765 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -505,

[jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090699#comment-16090699 ] ASF GitHub Bot commented on FLINK-6998: --- Github user zhenzhongxu commented on a diff

[jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090659#comment-16090659 ] ASF GitHub Bot commented on FLINK-6998: --- Github user zhenzhongxu commented on a diff

[GitHub] flink pull request #4187: [FLINK-6998][Kafka Connector] Add kafka offset com...

2017-07-17 Thread zhenzhongxu
Github user zhenzhongxu commented on a diff in the pull request: https://github.com/apache/flink/pull/4187#discussion_r127838984 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -185,

[jira] [Created] (FLINK-7216) ExecutionGraph can perform concurrent global restarts to scheduling

2017-07-17 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-7216: --- Summary: ExecutionGraph can perform concurrent global restarts to scheduling Key: FLINK-7216 URL: https://issues.apache.org/jira/browse/FLINK-7216 Project: Flink

[jira] [Commented] (FLINK-6667) Pass a callback type to the RestartStrategy, rather than the full ExecutionGraph

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090420#comment-16090420 ] ASF GitHub Bot commented on FLINK-6667: --- Github user StephanEwen commented on the is

[GitHub] flink issue #4277: [FLINK-6667] Pass a callback type to the RestartStrategy,...

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4277 @zjureel Thanks for this patch. I will pick it up from here. I think there is a small additional change needed, and a test, but I can do that... --- If your project is set up for it, you can

[jira] [Commented] (FLINK-7067) Cancel with savepoint does not restart checkpoint scheduler on failure

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090415#comment-16090415 ] ASF GitHub Bot commented on FLINK-7067: --- Github user StephanEwen commented on the is

[GitHub] flink issue #4254: [FLINK-7067] [jobmanager] Fix side effects after failed c...

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4254 I think this is a meaningful fix. I would suggest to do the tests different, though. The tests of the CheckpointCoordinator overdo the mockito stuff so heavily that it becomes an extreme

[jira] [Assigned] (FLINK-7067) Cancel with savepoint does not restart checkpoint scheduler on failure

2017-07-17 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen reassigned FLINK-7067: --- Assignee: Ufuk Celebi > Cancel with savepoint does not restart checkpoint scheduler on failur

[jira] [Updated] (FLINK-7067) Cancel with savepoint does not restart checkpoint scheduler on failure

2017-07-17 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-7067: Fix Version/s: 1.3.2 > Cancel with savepoint does not restart checkpoint scheduler on failure >

[jira] [Updated] (FLINK-7067) Cancel with savepoint does not restart checkpoint scheduler on failure

2017-07-17 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-7067: Priority: Blocker (was: Major) > Cancel with savepoint does not restart checkpoint scheduler on fai

[jira] [Commented] (FLINK-6588) Rename NumberOfFullRestarts metric

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090374#comment-16090374 ] ASF GitHub Bot commented on FLINK-6588: --- Github user StephanEwen commented on the is

[GitHub] flink issue #4292: [FLINK-6588] Rename NumberOfFullRestarts metric

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4292 I am very hesitant to rename such metrics, because there may be production users that defined monitoring or alterting based on that metric. Those installations would be broken through this change

[jira] [Updated] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-17 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7058: Priority: Critical (was: Blocker) > flink-scala-shell unintended dependencies for scala 2.1

[jira] [Commented] (FLINK-7178) Datadog Metric Reporter Jar is Lacking Dependencies

2017-07-17 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090369#comment-16090369 ] Chesnay Schepler commented on FLINK-7178: - 1.3: 3c0f38369000ed4a1a5f16140e7f88770a

[jira] [Updated] (FLINK-7178) Datadog Metric Reporter Jar is Lacking Dependencies

2017-07-17 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7178: Priority: Critical (was: Blocker) > Datadog Metric Reporter Jar is Lacking Dependencies > -

[jira] [Commented] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-17 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090368#comment-16090368 ] Chesnay Schepler commented on FLINK-7058: - 1.3: 09a4a4bdfb03887387d47f366193d1216a

[jira] [Commented] (FLINK-7118) Remove hadoop1.x code in HadoopUtils

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090362#comment-16090362 ] ASF GitHub Bot commented on FLINK-7118: --- Github user StephanEwen commented on the is

[GitHub] flink issue #4285: [FLINK-7118] [hadoop] Remove hadoop1.x code in HadoopUtil...

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4285 Since these utility methods are now so simple, I think it makes sense to inline them in the two places where they are called. Then we could also get rid of the extra exception catch blocks and av

[jira] [Commented] (FLINK-6493) Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090349#comment-16090349 ] ASF GitHub Bot commented on FLINK-6493: --- Github user StephanEwen commented on the is

[GitHub] flink issue #4328: [FLINK-6493] Fix ineffective null check in RegisteredOper...

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4328 Good fix, thanks! I would suggest to improve the `equals(...)` method all together by pulling out the repeated casts to `Snapshot`. --- If your project is set up for it, you can reply t

[jira] [Commented] (FLINK-7176) Failed builds (due to compilation) don't upload logs

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090344#comment-16090344 ] ASF GitHub Bot commented on FLINK-7176: --- Github user zentol commented on a diff in t

[GitHub] flink issue #4325: [hotfix] [hadoopCompat] Fix tests to verify results new H...

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4325 +1, please merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] flink pull request #4329: [FLINK-7176] [travis] Improve error handling

2017-07-17 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4329#discussion_r127794837 --- Diff: tools/travis_mvn_watchdog.sh --- @@ -225,9 +226,14 @@ echo "MVN exited with EXIT CODE: ${EXIT_CODE}." rm $MVN_PID rm $MVN_EXIT -c

[jira] [Commented] (FLINK-6105) Properly handle InterruptedException in HadoopInputFormatBase

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090343#comment-16090343 ] ASF GitHub Bot commented on FLINK-6105: --- Github user StephanEwen commented on the is

[GitHub] flink issue #4316: [FLINK-6105] Use InterruptedIOException instead of IOExce...

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4316 We could make this change. I have not seen a lot of use of `InterruptedIOException`, probably because it is a bit of a strange class, with its public mutable int field. I am +/- 0 on thi

[GitHub] flink pull request #4311: [FLINK-7162] [test] Tests should not write outside...

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4311#discussion_r127793662 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerStartupTest.java --- @@ -51,11 +54,14 @@ private File

[jira] [Commented] (FLINK-7162) Tests should not write outside 'target' directory.

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090335#comment-16090335 ] ASF GitHub Bot commented on FLINK-7162: --- Github user StephanEwen commented on a diff

[jira] [Commented] (FLINK-7162) Tests should not write outside 'target' directory.

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090333#comment-16090333 ] ASF GitHub Bot commented on FLINK-7162: --- Github user StephanEwen commented on a diff

[jira] [Commented] (FLINK-7162) Tests should not write outside 'target' directory.

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090334#comment-16090334 ] ASF GitHub Bot commented on FLINK-7162: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #4311: [FLINK-7162] [test] Tests should not write outside...

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4311#discussion_r127793602 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobUtilsTest.java --- @@ -22,26 +22,29 @@ import static org.junit.Assume.assume

[GitHub] flink pull request #4311: [FLINK-7162] [test] Tests should not write outside...

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4311#discussion_r127793846 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobUtilsTest.java --- @@ -22,26 +22,29 @@ import static org.junit.Assume.assume

[jira] [Commented] (FLINK-7141) enable travis cache again

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090329#comment-16090329 ] ASF GitHub Bot commented on FLINK-7141: --- Github user StephanEwen commented on the is

[GitHub] flink issue #4293: [FLINK-7141][build] enable travis cache again

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4293 @zentol Do you want to merge and validate this this as part of your ongoing build optimization project? --- If your project is set up for it, you can reply to this email and have your reply appe

[jira] [Commented] (FLINK-6980) TypeExtractor.getForObject can't get typeinfo correctly.

2017-07-17 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090318#comment-16090318 ] Stephan Ewen commented on FLINK-6980: - Thanks for reporting this. [~twalthr] This wou

[jira] [Commented] (FLINK-7176) Failed builds (due to compilation) don't upload logs

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090302#comment-16090302 ] ASF GitHub Bot commented on FLINK-7176: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #4329: [FLINK-7176] [travis] Improve error handling

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4329#discussion_r127788859 --- Diff: tools/travis_mvn_watchdog.sh --- @@ -225,9 +226,14 @@ echo "MVN exited with EXIT CODE: ${EXIT_CODE}." rm $MVN_PID rm $MVN_EXIT

[jira] [Commented] (FLINK-7201) ConcurrentModificationException in JobLeaderIdService

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090301#comment-16090301 ] ASF GitHub Bot commented on FLINK-7201: --- Github user StephanEwen commented on the is

[GitHub] flink issue #4347: [FLINK-7201] fix concurrency in JobLeaderIdService when s...

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4347 @XuPingyong Can you give us a bit of context for the review? From the initial exception I would expect that there is something that also needs to be addressed in the `JobLeaderIdService` class

[jira] [Commented] (FLINK-7212) JobManagerLeaderSessionIDITSuite not executed

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090255#comment-16090255 ] ASF GitHub Bot commented on FLINK-7212: --- Github user StephanEwen commented on the is

[GitHub] flink issue #4354: [FLINK-7212][tests] re-enable JobManagerLeaderSessionIDIT...

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4354 +1, please merge to `master`... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Created] (FLINK-7215) Typo in FAQ page

2017-07-17 Thread Bowen Li (JIRA)
Bowen Li created FLINK-7215: --- Summary: Typo in FAQ page Key: FLINK-7215 URL: https://issues.apache.org/jira/browse/FLINK-7215 Project: Flink Issue Type: Bug Components: Documentation

[GitHub] flink issue #4136: [FLINK-6940][docs] Clarify the effect of configuring per-...

2017-07-17 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4136 @zentol @alpinegizmo Let me know your thoughts on it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[jira] [Commented] (FLINK-6940) Clarify the effect of configuring per-job state backend

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090157#comment-16090157 ] ASF GitHub Bot commented on FLINK-6940: --- Github user bowenli86 commented on the issu

[jira] [Commented] (FLINK-7143) Partition assignment for Kafka consumer is not stable

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090113#comment-16090113 ] ASF GitHub Bot commented on FLINK-7143: --- Github user aljoscha commented on the issue

[GitHub] flink issue #4301: (release-1.3) [FLINK-7143] [kafka] Fix indeterminate part...

2017-07-17 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4301 Oye, this is more complicated than I thought. On `release-1.3` the assignment actually works if the Kafka brokers always return the partitions in the same order. The reason is that the assignment of

[jira] [Updated] (FLINK-7214) Add a sink that writes to ORCFile on HDFS

2017-07-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-7214: - Component/s: (was: Batch Connectors and Input/Output Formats) Streaming Connec

[jira] [Created] (FLINK-7214) Add a sink that writes to ORCFile on HDFS

2017-07-17 Thread Robert Rapplean (JIRA)
Robert Rapplean created FLINK-7214: -- Summary: Add a sink that writes to ORCFile on HDFS Key: FLINK-7214 URL: https://issues.apache.org/jira/browse/FLINK-7214 Project: Flink Issue Type: New F

[jira] [Commented] (FLINK-7143) Partition assignment for Kafka consumer is not stable

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090028#comment-16090028 ] ASF GitHub Bot commented on FLINK-7143: --- Github user aljoscha commented on the issue

[GitHub] flink issue #4301: (release-1.3) [FLINK-7143] [kafka] Fix indeterminate part...

2017-07-17 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4301 Note, that this doesn't normally occur because the strategy for assigning Kafka partitions and for assigning operator state is the same (right now). However, this means that you will have active par

[jira] [Commented] (FLINK-7143) Partition assignment for Kafka consumer is not stable

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089969#comment-16089969 ] ASF GitHub Bot commented on FLINK-7143: --- Github user aljoscha commented on the issue

[GitHub] flink issue #4301: (release-1.3) [FLINK-7143] [kafka] Fix indeterminate part...

2017-07-17 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4301 Yes, I don't think we can get around this when restoring from "old" state. I also have another suspicion: I don't think that `KafkaConsumerTestBase.runMultipleSourcesOnePartitionExactlyOnceT

[jira] [Updated] (FLINK-6997) SavepointITCase fails in master branch sometimes

2017-07-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-6997: -- Description: I got the following test failure (with commit a0b781461bcf8c2f1d00b93464995f03eda589f1) {code} te

[jira] [Comment Edited] (FLINK-7049) TestingApplicationMaster keeps running after integration tests finish

2017-07-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069086#comment-16069086 ] Ted Yu edited comment on FLINK-7049 at 7/17/17 3:28 PM: Stack trac

[jira] [Commented] (FLINK-6893) Add BIN supported in SQL

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089938#comment-16089938 ] ASF GitHub Bot commented on FLINK-6893: --- Github user sunjincheng121 commented on the

[jira] [Assigned] (FLINK-6974) Add BIN supported in TableAPI

2017-07-17 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng reassigned FLINK-6974: -- Assignee: sunjincheng > Add BIN supported in TableAPI > - > >

[GitHub] flink issue #4128: [FLINK-6893][table]Add BIN supported in SQL

2017-07-17 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4128 I have rebase the code. I appreciated if you can review this PR. @wuchong @shaoxuan-wang Best, Jincheng --- If your project is set up for it, you can reply to this email and have yo

[jira] [Closed] (FLINK-7101) Fix Non-windowed group-aggregate error when using `minIdleStateRetentionTime` config and retract agg

2017-07-17 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-7101. -- Resolution: Fixed Fixed in 1125122a75d25c3d3aa55d7f51d84ed25ee69c56 . > Fix Non-windowed group-aggregat

[jira] [Commented] (FLINK-7101) Fix Non-windowed group-aggregate error when using `minIdleStateRetentionTime` config and retract agg

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089913#comment-16089913 ] ASF GitHub Bot commented on FLINK-7101: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4348: [FLINK-7101][table] add condition of !stateCleanin...

2017-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4348 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-7178) Datadog Metric Reporter Jar is Lacking Dependencies

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089883#comment-16089883 ] ASF GitHub Bot commented on FLINK-7178: --- Github user zentol commented on the issue:

[GitHub] flink issue #4326: [FLINK-7178] [metrics] Do not create separate shaded jars

2017-07-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4326 @aljoscha The fix is not quite correct since I didn't update the flink-dist assembly files. Just pushed a fix for that though. I can merge it later today. (once my local travis passed for it) --- If

[jira] [Commented] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089878#comment-16089878 ] ASF GitHub Bot commented on FLINK-7058: --- Github user aljoscha commented on the issue

[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies

2017-07-17 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4240 Perfect! (I mean the "making it a blocker and fixing it" part, not the "it being broken" part). 😅 --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-7101) Fix Non-windowed group-aggregate error when using `minIdleStateRetentionTime` config and retract agg

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089877#comment-16089877 ] ASF GitHub Bot commented on FLINK-7101: --- Github user sunjincheng121 commented on the

[GitHub] flink issue #4348: [FLINK-7101][table] add condition of !stateCleaningEnable...

2017-07-17 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4348 Hi @fhueske Thanks for the review. I'll address the description. and merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Updated] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-17 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7058: Fix Version/s: 1.3.2 1.4.0 > flink-scala-shell unintended dependencies fo

[jira] [Commented] (FLINK-7101) Fix Non-windowed group-aggregate error when using `minIdleStateRetentionTime` config and retract agg

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089875#comment-16089875 ] ASF GitHub Bot commented on FLINK-7101: --- Github user sunjincheng121 commented on a d

[GitHub] flink pull request #4348: [FLINK-7101][table] add condition of !stateCleanin...

2017-07-17 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4348#discussion_r127715580 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala --- @@ -131,7 +131,8 @@ c

[jira] [Commented] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089876#comment-16089876 ] ASF GitHub Bot commented on FLINK-7058: --- Github user zentol commented on the issue:

[jira] [Updated] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-17 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7058: Priority: Blocker (was: Minor) > flink-scala-shell unintended dependencies for scala 2.11 >

[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies

2017-07-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4240 I made this a blocker since it means you cannot build 1.3 with the scala 2.11 profile. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089874#comment-16089874 ] ASF GitHub Bot commented on FLINK-7206: --- GitHub user kaibozhou opened a pull request

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-07-17 Thread kaibozhou
GitHub user kaibozhou opened a pull request: https://github.com/apache/flink/pull/4355 [FLINK-7206] [table] Implementation of DataView to support state access for UDAGG Thanks for contributing to Apache Flink. Before you open your pull request, please take the following che

[jira] [Commented] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089868#comment-16089868 ] ASF GitHub Bot commented on FLINK-7058: --- Github user zentol commented on the issue:

  1   2   >