[GitHub] [flink] chenqin commented on pull request #15442: [FLINK-22081][flink-core] handle entropy injection metadata path in pluggable HadoopS3FileSystem

2021-04-02 Thread GitBox
chenqin commented on pull request #15442: URL: https://github.com/apache/flink/pull/15442#issuecomment-812803257 @AHeise can you take a look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] flinkbot edited a comment on pull request #15484: [FLINK-21999][Runtime/Coordination] uniformize the logic about whether checkpoint is enabled and fix some typo.

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15484: URL: https://github.com/apache/flink/pull/15484#issuecomment-812771848 ## CI report: * 35826f519cf9b91ca759b4e13dcc7af811e8d0a8 Azure:

[jira] [Commented] (FLINK-11838) Create RecoverableWriter for GCS

2021-04-02 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314161#comment-17314161 ] Xintong Song commented on FLINK-11838: -- Thanks for the update, [~galenwarren]. Either updating the

[GitHub] [flink] flinkbot edited a comment on pull request #15484: [FLINK-21999][Runtime/Coordination] uniformize the logic about whether checkpoint is enabled and fix some typo.

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15484: URL: https://github.com/apache/flink/pull/15484#issuecomment-812771848 ## CI report: * 35826f519cf9b91ca759b4e13dcc7af811e8d0a8 Azure:

[GitHub] [flink] flinkbot commented on pull request #15484: [FLINK-21999][Runtime/Coordination] uniformize the logic about whether checkpoint is enabled and fix some typo.

2021-04-02 Thread GitBox
flinkbot commented on pull request #15484: URL: https://github.com/apache/flink/pull/15484#issuecomment-812771848 ## CI report: * 35826f519cf9b91ca759b4e13dcc7af811e8d0a8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #15484: [FLINK-21999][Runtime/Coordination] uniformize the logic about whether checkpoint is enabled and fix some typo.

2021-04-02 Thread GitBox
flinkbot commented on pull request #15484: URL: https://github.com/apache/flink/pull/15484#issuecomment-812765923 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-21999) The logic about whether Checkpoint is enabled.

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21999: --- Labels: pull-request-available (was: ) > The logic about whether Checkpoint is enabled. >

[GitHub] [flink] est08zw opened a new pull request #15484: [FLINK-21999][Runtime/Coordination] uniformize the logic about whether checkpoint is enabled and fix some typo.

2021-04-02 Thread GitBox
est08zw opened a new pull request #15484: URL: https://github.com/apache/flink/pull/15484 ## What is the purpose of the change Make the logic about whether Checkpoint is enabled consistent in DefaultExecutionGraphBuilder, CheckpointConfig and JobGraph. Fix some typo in

[GitHub] [flink] est08zw commented on pull request #15399: [hotfix] add coordinatorState into hashCode() to comply with equals().

2021-04-02 Thread GitBox
est08zw commented on pull request #15399: URL: https://github.com/apache/flink/pull/15399#issuecomment-812728024 It is ok to leave it as before if the method mainly used for tests and feel free to close this pr then. -- This is an automated message from the Apache Git Service. To

[jira] [Comment Edited] (FLINK-11838) Create RecoverableWriter for GCS

2021-04-02 Thread Galen Warren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314079#comment-17314079 ] Galen Warren edited comment on FLINK-11838 at 4/2/21, 8:54 PM: ---

[jira] [Commented] (FLINK-11838) Create RecoverableWriter for GCS

2021-04-02 Thread Galen Warren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314079#comment-17314079 ] Galen Warren commented on FLINK-11838: -- [~xintongsong] – actually, is that the right thing to do,

[jira] [Commented] (FLINK-18071) CoordinatorEventsExactlyOnceITCase.checkListContainsSequence fails on CI

2021-04-02 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314074#comment-17314074 ] Kezhu Wang commented on FLINK-18071: Hi all, I dug and thought some time about this. I want to share

[jira] [Created] (FLINK-22108) Ephemeral socket address was checkpointed to state and restored back in CollectSinkOperatorCoordinator

2021-04-02 Thread Kezhu Wang (Jira)
Kezhu Wang created FLINK-22108: -- Summary: Ephemeral socket address was checkpointed to state and restored back in CollectSinkOperatorCoordinator Key: FLINK-22108 URL:

[jira] [Commented] (FLINK-11838) Create RecoverableWriter for GCS

2021-04-02 Thread Galen Warren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314067#comment-17314067 ] Galen Warren commented on FLINK-11838: -- Hi [~xintongsong] – sorry for the long delay. I plan to

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * 4ea2496e67e1b5da116eac2058d51296e5b14edc Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * b5e4eb916a93c6c81cd2cc6a133838e26ac062f9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15483: [FLINK-22092][hive] Ignore static conf file URLs in HiveConf

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15483: URL: https://github.com/apache/flink/pull/15483#issuecomment-812520117 ## CI report: * 4aba800848a69d11dbbddf7afe2b3a87e95f8f87 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15441: [FLINK-22052][python] Add FLIP-142 public classes to python API

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15441: URL: https://github.com/apache/flink/pull/15441#issuecomment-810695518 ## CI report: * a4daf4b2b785878d576c7f759c5126d6e195a0c3 Azure:

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812640029 @fsk119 Added `FilterableSourceTest` and `FilterableSourceITCase`, waiting for your review. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] flinkbot edited a comment on pull request #15466: [FLINK-22003][checkpointing] Prevent checkpoint from starting if any Source isn't running

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15466: URL: https://github.com/apache/flink/pull/15466#issuecomment-811978896 ## CI report: * ad1b080091b48a82188261ef9fab9c4229af4c9a Azure:

[jira] [Commented] (FLINK-17957) Forbidden syntax "CREATE SYSTEM FUNCTION" for sql parser

2021-04-02 Thread WeiNan Zhao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313938#comment-17313938 ] WeiNan Zhao commented on FLINK-17957: - [~fsk119],please assgin this issue to to me , i will fix it.

[jira] [Assigned] (FLINK-22003) UnalignedCheckpointITCase fail

2021-04-02 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan reassigned FLINK-22003: - Assignee: Roman Khachatryan > UnalignedCheckpointITCase fail >

[GitHub] [flink] zzfukai edited a comment on pull request #15054: [FLINK-13550][rest][ui] Vertex Flame Graph

2021-04-02 Thread GitBox
zzfukai edited a comment on pull request #15054: URL: https://github.com/apache/flink/pull/15054#issuecomment-812486880 Thank you Arvid! It works. By the way, I detected a bug that the popover content like

[GitHub] [flink] flinkbot edited a comment on pull request #15482: [FLINK-22103][hive] Fix HiveModuleTest for 1.2.1

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15482: URL: https://github.com/apache/flink/pull/15482#issuecomment-812447703 ## CI report: * 2d9cd4f63f2e806f0a9a0466e4e6b6cbba02bd89 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15441: [FLINK-22052][python] Add FLIP-142 public classes to python API

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15441: URL: https://github.com/apache/flink/pull/15441#issuecomment-810695518 ## CI report: * 5f75c7d27817bd8e0822708aacab720ed1e2e394 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * b5e4eb916a93c6c81cd2cc6a133838e26ac062f9 Azure:

[jira] [Commented] (FLINK-21247) flink iceberg table map cannot convert to datastream

2021-04-02 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313879#comment-17313879 ] Jark Wu commented on FLINK-21247: - Thanks [~openinx], I changed the type to BUG, and fix version to

[jira] [Updated] (FLINK-21247) flink iceberg table map cannot convert to datastream

2021-04-02 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-21247: Issue Type: Bug (was: New Feature) > flink iceberg table map cannot convert to datastream >

[jira] [Updated] (FLINK-21247) flink iceberg table map cannot convert to datastream

2021-04-02 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-21247: Fix Version/s: 1.13.0 > flink iceberg table map cannot convert to datastream >

[GitHub] [flink] flinkbot edited a comment on pull request #15483: [FLINK-22092][hive] Ignore static conf file URLs in HiveConf

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15483: URL: https://github.com/apache/flink/pull/15483#issuecomment-812520117 ## CI report: * 4aba800848a69d11dbbddf7afe2b3a87e95f8f87 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15441: [FLINK-22052][python] Add FLIP-142 public classes to python API

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15441: URL: https://github.com/apache/flink/pull/15441#issuecomment-810695518 ## CI report: * 5f75c7d27817bd8e0822708aacab720ed1e2e394 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15425: [FLINK-21133][connector/checkpoint] Fix the stop-with-savepoint case …

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15425: URL: https://github.com/apache/flink/pull/15425#issuecomment-809890369 ## CI report: * 1b248e49e4695b3ac7d21320a377fb74ff460687 Azure:

[GitHub] [flink] flinkbot commented on pull request #15483: [FLINK-22092][hive] Ignore static conf file URLs in HiveConf

2021-04-02 Thread GitBox
flinkbot commented on pull request #15483: URL: https://github.com/apache/flink/pull/15483#issuecomment-812520117 ## CI report: * 4aba800848a69d11dbbddf7afe2b3a87e95f8f87 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * dcfc0b3d5083c0b2eaf95b0c5ea0e11baeeb4eed Azure:

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812514484 Please take a look at #13449 I think SourceWatermarkTest and SourceWatermarkITCase are good example. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] flinkbot commented on pull request #15483: [FLINK-22092][hive] Ignore static conf file URLs in HiveConf

2021-04-02 Thread GitBox
flinkbot commented on pull request #15483: URL: https://github.com/apache/flink/pull/15483#issuecomment-812514496 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Created] (FLINK-22107) Include antlr into hive connector uber jars

2021-04-02 Thread Rui Li (Jira)
Rui Li created FLINK-22107: -- Summary: Include antlr into hive connector uber jars Key: FLINK-22107 URL: https://issues.apache.org/jira/browse/FLINK-22107 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-22092) Prevent HiveCatalog from reading hive-site in classpath

2021-04-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-22092: --- Labels: pull-request-available (was: ) > Prevent HiveCatalog from reading hive-site in

[GitHub] [flink] lirui-apache opened a new pull request #15483: [FLINK-22092][hive] Ignore static conf file URLs in HiveConf

2021-04-02 Thread GitBox
lirui-apache opened a new pull request #15483: URL: https://github.com/apache/flink/pull/15483 ## What is the purpose of the change `HiveConf` automatically detects hive-site from classpath and stores the URL into static variable `hiveSiteURL`. This can cause problems if a

[GitHub] [flink] YuvalItzchakov edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812512544 @fsk119 I'm looking at `org.apache.flink.table.planner.plan.stream.sql.CalcTest` and all I see is basic tests there over table source, what do you think should be

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812512544 @fsk119 I'm looking at `org.apache.flink.table.planner.plan.stream.sql.CalcTest` and all I see is basic tests there over table source, what do you think should be tested

[jira] [Commented] (FLINK-22092) Prevent HiveCatalog from reading hive-site in classpath

2021-04-02 Thread Rui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313853#comment-17313853 ] Rui Li commented on FLINK-22092: Put more thoughts into this and I guess it's not a good idea to stop

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * f4e94916e5c597341059d98bbff2b37d23cc4203 Azure:

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812509449 > > OK, I see what you're saying. Is there a reason though that the `FlinkLogicalCalc` is being generated twice? > > In optimization, we alway build a new node

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812507579 > > OK, I see what you're saying. Is there a reason though that the `FlinkLogicalCalc` is being generated twice? In optimization, we alway build a new node rather than

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * f4e94916e5c597341059d98bbff2b37d23cc4203 Azure:

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812504803 > > @YuvalItzchakov . I think the added test is not enough to cover all. > > I think you should also need to add end to end Tests in the

[GitHub] [flink] YuvalItzchakov edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812503994 > > @YuvalItzchakov . I think the added test is not enough to cover all. > > I think you should also need to add end to end Tests in the

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812503994 > > @YuvalItzchakov . I think the added test is not enough to cover all. > > I think you should also need to add end to end Tests in the

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812503759 > @YuvalItzchakov . I think the added test is not enough to cover all. > > I think you should also need to add end to end Tests in the

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812502909 > @fsk119 After the change, my partial predicate match no longer works: > > ```java > @Test > public void testPushdownAcrossWatermarkPartialPredicateMatch() {

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812502234 > @fsk119 Pushed the changes after your comments. Can you take a look? Sure. I will take a look tomorrow. -- This is an automated message from the Apache Git Service.

[GitHub] [flink] YuvalItzchakov edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812499504 @fsk119 After the change, my partial predicate match no longer works: ```java @Test public void

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812499504 @fsk119 After the change, my partial predicate match no longer works: ```java @Test public void testPushdownAcrossWatermarkPartialPredicateMatch() {

[GitHub] [flink] flinkbot edited a comment on pull request #15480: [FLINK-22006][k8s] Support to configure max concurrent requests for fabric8 Kubernetes client via JAVA opts or envs

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15480: URL: https://github.com/apache/flink/pull/15480#issuecomment-812378052 ## CI report: * 8c7eca17544f157b58f4100af3527e346a63bbcb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15466: [FLINK-22003][checkpointing] Prevent checkpoint from starting if any Source isn't running

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15466: URL: https://github.com/apache/flink/pull/15466#issuecomment-811978896 ## CI report: * f013abdc90d9b504720c1c94c1d847e144d38a7c Azure:

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812497261 @fsk119 Pushed the changes after your comments. Can you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] fsk119 edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
fsk119 edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812484309 > @fsk119 I'm confused with all the suggestions. Should I keep working off this branch but have this as a logical rewrite instead? Are all the comments you left above

[GitHub] [flink] fsk119 edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
fsk119 edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812492176 > > > @fsk119 I see you also added a test for partition pushdown, are those related? > > > > > > Not related. I just try to find why the change breaks the test.

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812492176 > > > @fsk119 I see you also added a test for partition pushdown, are those related? > > > > > > Not related. I just try to find why the change breaks the test. > >

[GitHub] [flink] YuvalItzchakov edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812490603 > > @fsk119 I see you also added a test for partition pushdown, are those related? > > Not related. I just try to find why the change breaks the test. >

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812490603 > > @fsk119 I see you also added a test for partition pushdown, are those related? > > Not related. I just try to find why the change breaks the test. > >

[GitHub] [flink] flinkbot edited a comment on pull request #15466: [FLINK-22003][checkpointing] Prevent checkpoint from starting if any Source isn't running

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15466: URL: https://github.com/apache/flink/pull/15466#issuecomment-811978896 ## CI report: * f013abdc90d9b504720c1c94c1d847e144d38a7c Azure:

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812488407 > @fsk119 I see you also added a test for partition pushdown, are those related? Not related. I just try to find why the change breaks the test. It will try to

[GitHub] [flink] zzfukai commented on pull request #15054: [FLINK-13550][rest][ui] Vertex Flame Graph

2021-04-02 Thread GitBox
zzfukai commented on pull request #15054: URL: https://github.com/apache/flink/pull/15054#issuecomment-812486880 Thank you Arvid! It works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812485639 @fsk119 Awesome, OK. Fixes coming in a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] fsk119 edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
fsk119 edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812484309 > @fsk119 I'm confused with all the suggestions. Should I keep working off this branch but have this as a logical rewrite instead? Are all the comments you left above

[GitHub] [flink] fsk119 edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
fsk119 edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812484309 > @fsk119 I'm confused with all the suggestions. Should I keep working off this branch but have this as a logical rewrite instead? Are all the comments you left above

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812484309 > @fsk119 I'm confused with all the suggestions. Should I keep working off this branch but have this as a logical rewrite instead? Are all the comments you left above still

[GitHub] [flink] flinkbot edited a comment on pull request #15479: [FLINK-19606][table-runtime-blink] Implement streaming window join operator

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15479: URL: https://github.com/apache/flink/pull/15479#issuecomment-812344008 ## CI report: * 93b9b3d8dac2c3ecd13e3e3ede46f4a73263e34d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15477: [FLINK-22099][table-planner-blink] Fix bug for semi/anti window join.

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15477: URL: https://github.com/apache/flink/pull/15477#issuecomment-812337208 ## CI report: * 68bacb55c3c718eddba8cf5596bf94c3e4931d40 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15396: [FLINK-21008][coordination] Register a shutdown supplier in the SignalHandler for ClusterEntrypoint

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15396: URL: https://github.com/apache/flink/pull/15396#issuecomment-808861897 ## CI report: * 5e152ddd93611a57bf3659bd1c46967e46a9e4c2 Azure:

[jira] [Resolved] (FLINK-22083) Python tests fail on azure

2021-04-02 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo resolved FLINK-22083. -- Resolution: Fixed > Python tests fail on azure > -- > >

[jira] [Resolved] (FLINK-22101) PyFlinkBatchUserDefinedTableFunctionTests fail

2021-04-02 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo resolved FLINK-22101. -- Resolution: Fixed This issue should have been addressed in

[jira] [Commented] (FLINK-22083) Python tests fail on azure

2021-04-02 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313795#comment-17313795 ] Huang Xingbo commented on FLINK-22083: -- This issue should have been addressed in

[jira] [Updated] (FLINK-22076) Python Test failed with "OSError: [Errno 12] Cannot allocate memory"

2021-04-02 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo updated FLINK-22076: - Fix Version/s: 1.13.0 > Python Test failed with "OSError: [Errno 12] Cannot allocate memory" >

[jira] [Resolved] (FLINK-22076) Python Test failed with "OSError: [Errno 12] Cannot allocate memory"

2021-04-02 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo resolved FLINK-22076. -- Resolution: Fixed Merged into master via 000c69dcfb9632c152a45a7971bdef7e3ef0556e > Python

[GitHub] [flink] HuangXingBo closed pull request #15481: [FLINK-22076][python] Split the global test into multiple module tests

2021-04-02 Thread GitBox
HuangXingBo closed pull request #15481: URL: https://github.com/apache/flink/pull/15481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [flink] rkhachatryan commented on pull request #15466: [FLINK-22003][checkpointing] Prevent checkpoint from starting if any Source isn't running

2021-04-02 Thread GitBox
rkhachatryan commented on pull request #15466: URL: https://github.com/apache/flink/pull/15466#issuecomment-812478658 Thanks @gaoyunhaii , I think you are right, I'll update the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812478187 @fsk119 I see you also added a test for partition pushdown, are those related? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Assigned] (FLINK-20103) Improve test coverage for network stack

2021-04-02 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-20103: -- Assignee: Piotr Nowojski (was: Roman Khachatryan) > Improve test coverage for

[GitHub] [flink] YuvalItzchakov commented on a change in pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on a change in pull request #15307: URL: https://github.com/apache/flink/pull/15307#discussion_r606178436 ## File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java ## @@

[GitHub] [flink] YuvalItzchakov commented on a change in pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on a change in pull request #15307: URL: https://github.com/apache/flink/pull/15307#discussion_r606178294 ## File path:

[GitHub] [flink] YuvalItzchakov commented on a change in pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on a change in pull request #15307: URL: https://github.com/apache/flink/pull/15307#discussion_r606177935 ## File path:

[GitHub] [flink] YuvalItzchakov edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812471049 @fsk119 I'm confused with all the suggestions. Should I keep working off this branch but have this as a logical rewrite instead? Are all the comments you left

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812471049 @fsk119 I'm confused with all the suggestions. Should I keep working off this branch but have this as a logical rewrite instead? Are all the comments you left above

[jira] [Commented] (FLINK-21247) flink iceberg table map cannot convert to datastream

2021-04-02 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313779#comment-17313779 ] Zheng Hu commented on FLINK-21247: -- I think this will need to get merged in flink 1.13.0, otherwise

[GitHub] [flink] flinkbot edited a comment on pull request #15280: [FLINK-21714][table-api] Use TIMESTAMP_LTZ as return type for function PROCTIME()

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15280: URL: https://github.com/apache/flink/pull/15280#issuecomment-802654466 ## CI report: * 3b4b5fcd9d8108b51e0bf62a0bee888b4fdb5186 UNKNOWN * 621905dc52204133a9d610a2d0c9a5f1aeaafd53 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15247: [FLINK-21833][Table SQL / Runtime] TemporalRowTimeJoinOperator.java will lead to the state expansion by short-life-cycle & huge RowDa

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15247: URL: https://github.com/apache/flink/pull/15247#issuecomment-800773807 ## CI report: * a30faa8be8081f0037cd56e24396ad292fe49de7 Azure:

[jira] [Updated] (FLINK-22088) CheckpointCoordinator might not be able to abort triggering checkpoint if failover happens during triggering

2021-04-02 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-22088: --- Affects Version/s: 1.13.0 1.12.2 > CheckpointCoordinator might not

[jira] [Updated] (FLINK-22088) CheckpointCoordinator might not be able to abort triggering checkpoint if failover happens during triggering

2021-04-02 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-22088: --- Component/s: Runtime / Checkpointing > CheckpointCoordinator might not be able to abort

[GitHub] [flink] flinkbot edited a comment on pull request #15482: [FLINK-22103][hive] Fix HiveModuleTest for 1.2.1

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15482: URL: https://github.com/apache/flink/pull/15482#issuecomment-812447703 ## CI report: * 2d9cd4f63f2e806f0a9a0466e4e6b6cbba02bd89 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15425: [FLINK-21133][connector/checkpoint] Fix the stop-with-savepoint case …

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15425: URL: https://github.com/apache/flink/pull/15425#issuecomment-809890369 ## CI report: * 1b248e49e4695b3ac7d21320a377fb74ff460687 Azure:

[jira] [Closed] (FLINK-21963) ReactiveModelITCase.testScaleDownOnTaskManagerLoss failed / hangs

2021-04-02 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger closed FLINK-21963. -- Resolution: Fixed Resolved in

[GitHub] [flink] rmetzger closed pull request #15417: [FLINK-21963] Harden ReactiveModeITCase

2021-04-02 Thread GitBox
rmetzger closed pull request #15417: URL: https://github.com/apache/flink/pull/15417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [flink] flinkbot commented on pull request #15482: [FLINK-22103][hive] Fix HiveModuleTest for 1.2.1

2021-04-02 Thread GitBox
flinkbot commented on pull request #15482: URL: https://github.com/apache/flink/pull/15482#issuecomment-812447703 ## CI report: * 2d9cd4f63f2e806f0a9a0466e4e6b6cbba02bd89 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #15481: [FLINK-22076][python] Split the global test into multiple module tests

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15481: URL: https://github.com/apache/flink/pull/15481#issuecomment-812435755 ## CI report: * e05738d21a61981ede35c8a3e6e6676f03d7d470 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15425: [FLINK-21133][connector/checkpoint] Fix the stop-with-savepoint case …

2021-04-02 Thread GitBox
flinkbot edited a comment on pull request #15425: URL: https://github.com/apache/flink/pull/15425#issuecomment-809890369 ## CI report: * 1b248e49e4695b3ac7d21320a377fb74ff460687 Azure:

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-02 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812446500 Please also rebase to the latest branch... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] rmetzger commented on pull request #15417: [FLINK-21963] Harden ReactiveModeITCase

2021-04-02 Thread GitBox
rmetzger commented on pull request #15417: URL: https://github.com/apache/flink/pull/15417#issuecomment-812446102 Thanks a lot for your review! I'll merge this change now with your comments addressed! -- This is an automated message from the Apache Git Service. To respond to the

  1   2   3   4   >