[GitHub] [flink] FangYongs commented on pull request #22832: [FLINK-32396][jdbc-driver] Support timestamp and timestamp_ltz for jdbc driver and sql gateway

2023-06-20 Thread via GitHub
FangYongs commented on PR #22832: URL: https://github.com/apache/flink/pull/22832#issuecomment-1600231857 @libenchao Please help to review this PR when you are free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] flinkbot commented on pull request #22836: [FLINK-32191][netty] support set keepalive options to NettyClient.

2023-06-20 Thread via GitHub
flinkbot commented on PR #22836: URL: https://github.com/apache/flink/pull/22836#issuecomment-1600083070 ## CI report: * 73cfe58f8e19ceaf36302a37249704b7c751ff85 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] huwh opened a new pull request, #22836: [FLINK-32191][netty] support set keepalive options to NettyClient.

2023-06-20 Thread via GitHub
huwh opened a new pull request, #22836: URL: https://github.com/apache/flink/pull/22836 ## What is the purpose of the change Add keepalive options to NettyClient. refer to: https://issues.apache.org/jira/browse/FLINK-32191 ## Brief change log - *Add tcp keepalive related

[jira] [Updated] (FLINK-32191) Support for configuring tcp keepalive related parameters.

2023-06-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32191: --- Labels: pull-request-available (was: ) > Support for configuring tcp keepalive related

[GitHub] [flink] flinkbot commented on pull request #22835: [hotfix] Remove local timeout for Hybrid and Tiered result partition test.

2023-06-20 Thread via GitHub
flinkbot commented on PR #22835: URL: https://github.com/apache/flink/pull/22835#issuecomment-1600061126 ## CI report: * b2bbd9451339f465e655fb70f6feaced3f837ab2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] reswqa opened a new pull request, #22835: [hotfix] Remove local timeout for Hybrid and Tiered result partition test.

2023-06-20 Thread via GitHub
reswqa opened a new pull request, #22835: URL: https://github.com/apache/flink/pull/22835 ## What is the purpose of the change *`HsResultPartitionTest#testRelease` and `TieredResultPartitionTest#testRelease` depend on local timeout, which will make the test unstable.* ##

[GitHub] [flink] luoyuxia commented on a diff in pull request #22818: [FLINK-31956][table] Extend COMPILE AND EXECUTE PLAN statement to read/write from/to Flink FileSystem

2023-06-20 Thread via GitHub
luoyuxia commented on code in PR #22818: URL: https://github.com/apache/flink/pull/22818#discussion_r1235201385 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -731,38 +731,46 @@ public TableResultInternal

[GitHub] [flink] luoyuxia commented on a diff in pull request #22249: [FLINK-17398][connector/filesystem] Filesystem sources support flexible path reading

2023-06-20 Thread via GitHub
luoyuxia commented on code in PR #22249: URL: https://github.com/apache/flink/pull/22249#discussion_r1236243710 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/enumerate/BlockSplittingRecursiveAllDirEnumerator.java: ## @@ -0,0 +1,165

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #22249: [FLINK-17398][connector/filesystem] Filesystem sources support flexible path reading

2023-06-20 Thread via GitHub
ruanhang1993 commented on code in PR #22249: URL: https://github.com/apache/flink/pull/22249#discussion_r1236234583 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/enumerate/BlockSplittingRecursiveAllDirEnumerator.java: ## @@ -0,0

[GitHub] [flink] reswqa commented on pull request #21774: [FLINK-28227][connectors] Migrate o.a.f.streaming.examples to the new Source API

2023-06-20 Thread via GitHub
reswqa commented on PR #21774: URL: https://github.com/apache/flink/pull/21774#issuecomment-1600011332 Hi @afedulov, would you minding telling me how it is progressing now, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

2023-06-20 Thread via GitHub
fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1236225638 ## flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroup.java: ## @@ -196,6 +204,23 @@ public void markTaskStart() {

[GitHub] [flink] zhougit86 commented on pull request #22624: [FLINK-32132][table-planner] Cast function CODEGEN does not work as e…

2023-06-20 Thread via GitHub
zhougit86 commented on PR #22624: URL: https://github.com/apache/flink/pull/22624#issuecomment-156291 > also could you please rebase to the latest master? The failure was fixed in later commits, so rebase should help with passing tests thx for the instruction... my bad not modify

[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

2023-06-20 Thread via GitHub
fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1236220893 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -695,6 +695,7 @@ void restoreInternal() throws Exception {

[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

2023-06-20 Thread via GitHub
fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1236211241 ## flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroup.java: ## @@ -67,10 +70,12 @@ public class TaskIOMetricGroup extends

[jira] [Updated] (FLINK-32400) KafkaSourceBuilder#maybeOverride get property as a string to checking if has value may not be the best way

2023-06-20 Thread KianChen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KianChen updated FLINK-32400: - Affects Version/s: 1.17.0 1.16.0 1.15.0

[jira] [Updated] (FLINK-32400) KafkaSourceBuilder#maybeOverride get property as a string to checking if has value may not be the best way

2023-06-20 Thread KianChen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KianChen updated FLINK-32400: - Description: Since flink 1.14 the FlinkKafkaConsumer is deprecated, using KafkaSouce instead. As the

[jira] [Created] (FLINK-32400) KafkaSourceBuilder#maybeOverride get property as a string to checking if has value may not be the best way

2023-06-20 Thread KianChen (Jira)
KianChen created FLINK-32400: Summary: KafkaSourceBuilder#maybeOverride get property as a string to checking if has value may not be the best way Key: FLINK-32400 URL:

[jira] [Resolved] (FLINK-27241) Support DROP PARTITION statement for partitioned table

2023-06-20 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-27241. -- Resolution: Fixed master: f1233a32546893849632fdb64dca40c2f686d4fe > Support DROP PARTITION

[GitHub] [flink] luoyuxia merged pull request #22720: [FLINK-27241][table] Support DROP PARTITIONS statement for partitioned table

2023-06-20 Thread via GitHub
luoyuxia merged PR #22720: URL: https://github.com/apache/flink/pull/22720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] luoyuxia commented on pull request #22720: [FLINK-27241][table] Support DROP PARTITIONS statement for partitioned table

2023-06-20 Thread via GitHub
luoyuxia commented on PR #22720: URL: https://github.com/apache/flink/pull/22720#issuecomment-1599926921 @ruanhang1993 Thanks for reviewing. Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] mas-chen commented on pull request #22797: [FLINK-30859][DO NOT MERGE] [WIP] Remove all Kafka connector code from main repo

2023-06-20 Thread via GitHub
mas-chen commented on PR #22797: URL: https://github.com/apache/flink/pull/22797#issuecomment-1599747152 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-32399) Fix flink-sql-connector-kinesis build for maven 3.8.6+

2023-06-20 Thread Aleksandr Pilipenko (Jira)
Aleksandr Pilipenko created FLINK-32399: --- Summary: Fix flink-sql-connector-kinesis build for maven 3.8.6+ Key: FLINK-32399 URL: https://issues.apache.org/jira/browse/FLINK-32399 Project: Flink

[jira] [Commented] (FLINK-32137) Flame graph is hard to use with many task managers

2023-06-20 Thread Vladimir Matveev (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735410#comment-17735410 ] Vladimir Matveev commented on FLINK-32137: -- Hi [~fanrui], thank you! I was able to clear this

[jira] [Comment Edited] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735346#comment-17735346 ] Sergey Nuyanzin edited comment on FLINK-32379 at 6/20/23 5:18 PM: --

[jira] [Comment Edited] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735346#comment-17735346 ] Sergey Nuyanzin edited comment on FLINK-32379 at 6/20/23 5:17 PM: --

[jira] [Updated] (FLINK-28227) Migrate o.a.f.streaming.examples to the new Source API

2023-06-20 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-28227: -- Summary: Migrate o.a.f.streaming.examples to the new Source API (was: Migrate

[jira] [Updated] (FLINK-28227) Migrate o.a.f.streaming.examples to new Source API

2023-06-20 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-28227: -- Description: Reimplement  * CarSource * SimpleSource * SessionWindowing *

[jira] [Updated] (FLINK-28227) Migrate o.a.f.streaming.examples to new Source API

2023-06-20 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-28227: -- Description: Reimplement  * CarSource * SimpleSource * SessionWindowing *

[jira] [Updated] (FLINK-28227) Migrate o.a.f.streaming.examples to new Source API

2023-06-20 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-28227: -- Summary: Migrate o.a.f.streaming.examples to new Source API (was: Add

[jira] [Updated] (FLINK-28227) Add implementations for classes in o.a.f.streaming.examples based on the new new Source API

2023-06-20 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-28227: -- Description: Reimplement  * CarSource * SimpleSource * SessionWindowing *

[GitHub] [flink] akalash commented on pull request #22761: [FLINK-32298][network] Fix the bug that totalWrittenBytes of BufferWritingResultPartition misses some data

2023-06-20 Thread via GitHub
akalash commented on PR #22761: URL: https://github.com/apache/flink/pull/22761#issuecomment-1599159711 Hi @1996fanrui , thanks for the fix. I will try to take a look at it this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #614: [FLINK-32057] Support 1.18 rescale api for applying parallelism overrides

2023-06-20 Thread via GitHub
gyfora commented on code in PR #614: URL: https://github.com/apache/flink-kubernetes-operator/pull/614#discussion_r1235495074 ## .github/workflows/ci.yml: ## @@ -92,6 +95,18 @@ jobs: exclude: - namespace: default test: test_multi_sessionjob.sh

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #614: [FLINK-32057] Support 1.18 rescale api for applying parallelism overrides

2023-06-20 Thread via GitHub
gyfora commented on code in PR #614: URL: https://github.com/apache/flink-kubernetes-operator/pull/614#discussion_r1235495355 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java: ## @@ -150,6 +150,14 @@

[jira] [Commented] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735346#comment-17735346 ] Sergey Nuyanzin commented on FLINK-32379: - That I'm not sure Currently there is in use

[GitHub] [flink] snuyanzin commented on pull request #22624: [FLINK-32132][table-planner] Cast function CODEGEN does not work as e…

2023-06-20 Thread via GitHub
snuyanzin commented on PR #22624: URL: https://github.com/apache/flink/pull/22624#issuecomment-1599038504 also could you please rebase to the latest master? The failure was fixed in later commits, so rebase should help with passing tests -- This is an automated message from the Apache

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #614: [FLINK-32057] Support 1.18 rescale api for applying parallelism overrides

2023-06-20 Thread via GitHub
gyfora commented on code in PR #614: URL: https://github.com/apache/flink-kubernetes-operator/pull/614#discussion_r1235448620 ## .github/workflows/ci.yml: ## @@ -67,7 +67,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: -version:

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #614: [FLINK-32057] Support 1.18 rescale api for applying parallelism overrides

2023-06-20 Thread via GitHub
gyfora commented on code in PR #614: URL: https://github.com/apache/flink-kubernetes-operator/pull/614#discussion_r1235447279 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java: ## @@ -165,30 +159,6 @@

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #614: [FLINK-32057] Support 1.18 rescale api for applying parallelism overrides

2023-06-20 Thread via GitHub
gyfora commented on code in PR #614: URL: https://github.com/apache/flink-kubernetes-operator/pull/614#discussion_r1235448023 ## flink-kubernetes-operator-autoscaler/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutorTest.java: ## @@ -85,50 +82,6 @@

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22788: [FLINK-32345][state] Improve parallel download of RocksDB incremental state.

2023-06-20 Thread via GitHub
rkhachatryan commented on code in PR #22788: URL: https://github.com/apache/flink/pull/22788#discussion_r1235441523 ## flink-core/src/main/java/org/apache/flink/util/CollectionUtil.java: ## @@ -133,4 +140,71 @@ public static Map map(Map.Entry... entries) { }

[GitHub] [flink] XComp commented on pull request #22830: [FLINK-30343][test] Migrates KubernetesLeaderElectionAndRetrievalITCase to use the MultipleComponentLeaderElectionDriver interface

2023-06-20 Thread via GitHub
XComp commented on PR #22830: URL: https://github.com/apache/flink/pull/22830#issuecomment-1599013453 Rebased branch to `master` and squashed commits for a final CI run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Resolved] (FLINK-30344) Migrate KubernetesHighAvailabilityTestBase and implementing test classes

2023-06-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-30344. --- Fix Version/s: 1.18.0 Resolution: Fixed master:

[jira] [Updated] (FLINK-30344) Migrate KubernetesHighAvailabilityTestBase and implementing test classes

2023-06-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30344: -- Parent: (was: FLINK-30338) Issue Type: Technical Debt (was: Sub-task) > Migrate

[jira] [Updated] (FLINK-30344) Migrate KubernetesHighAvailabilityTestBase and implementing test classes

2023-06-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30344: -- Parent: FLINK-26522 Issue Type: Sub-task (was: Technical Debt) > Migrate

[GitHub] [flink] XComp merged pull request #22828: [FLINK-30344][test] Migrates KubernetesHighAvailabilityTestBase-related tests to use the MultipleComponentLeaderElectionDriver interface

2023-06-20 Thread via GitHub
XComp merged PR #22828: URL: https://github.com/apache/flink/pull/22828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] StefanRRichter commented on a diff in pull request #22788: [FLINK-32345][state] Improve parallel download of RocksDB incremental state.

2023-06-20 Thread via GitHub
StefanRRichter commented on code in PR #22788: URL: https://github.com/apache/flink/pull/22788#discussion_r1235435483 ## flink-core/src/main/java/org/apache/flink/util/CollectionUtil.java: ## @@ -133,4 +140,71 @@ public static Map map(Map.Entry... entries) { }

[GitHub] [flink] StefanRRichter commented on a diff in pull request #22788: [FLINK-32345][state] Improve parallel download of RocksDB incremental state.

2023-06-20 Thread via GitHub
StefanRRichter commented on code in PR #22788: URL: https://github.com/apache/flink/pull/22788#discussion_r1235432295 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloader.java: ## @@ -90,27 +80,62 @@

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22788: [FLINK-32345][state] Improve parallel download of RocksDB incremental state.

2023-06-20 Thread via GitHub
rkhachatryan commented on code in PR #22788: URL: https://github.com/apache/flink/pull/22788#discussion_r1235431867 ## flink-core/src/main/java/org/apache/flink/util/CollectionUtil.java: ## @@ -133,4 +140,71 @@ public static Map map(Map.Entry... entries) { }

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #614: [FLINK-32057] Support 1.18 rescale api for applying parallelism overrides

2023-06-20 Thread via GitHub
mxm commented on code in PR #614: URL: https://github.com/apache/flink-kubernetes-operator/pull/614#discussion_r1233570095 ## .github/workflows/ci.yml: ## @@ -92,6 +95,18 @@ jobs: exclude: - namespace: default test: test_multi_sessionjob.sh +

[GitHub] [flink] StefanRRichter commented on a diff in pull request #22788: [FLINK-32345][state] Improve parallel download of RocksDB incremental state.

2023-06-20 Thread via GitHub
StefanRRichter commented on code in PR #22788: URL: https://github.com/apache/flink/pull/22788#discussion_r1235425320 ## flink-core/src/main/java/org/apache/flink/util/CollectionUtil.java: ## @@ -133,4 +140,71 @@ public static Map map(Map.Entry... entries) { }

[GitHub] [flink] StefanRRichter commented on a diff in pull request #22788: [FLINK-32345][state] Improve parallel download of RocksDB incremental state.

2023-06-20 Thread via GitHub
StefanRRichter commented on code in PR #22788: URL: https://github.com/apache/flink/pull/22788#discussion_r1235422689 ## flink-core/src/main/java/org/apache/flink/util/CollectionUtil.java: ## @@ -133,4 +140,71 @@ public static Map map(Map.Entry... entries) { }

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22788: [FLINK-32345][state] Improve parallel download of RocksDB incremental state.

2023-06-20 Thread via GitHub
rkhachatryan commented on code in PR #22788: URL: https://github.com/apache/flink/pull/22788#discussion_r1235141374 ## flink-core/src/main/java/org/apache/flink/util/CollectionUtil.java: ## @@ -133,4 +140,71 @@ public static Map map(Map.Entry... entries) { }

[jira] [Commented] (FLINK-32398) Support Avro SpecificRecord in DataStream and Table conversion.

2023-06-20 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735328#comment-17735328 ] Jiangjie Qin commented on FLINK-32398: -- [~twalthr] [~jark] If this already works and I missed

[GitHub] [flink] flinkbot commented on pull request #22834: [FLINK-32260]-table-Add-ARRAY_SLICE-function

2023-06-20 Thread via GitHub
flinkbot commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1598932020 ## CI report: * 7803aab7cc5edfdcc434df43940357dbcfbc3d40 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32260) Add SLICE support in SQL & Table API

2023-06-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32260: --- Labels: pull-request-available (was: ) > Add SLICE support in SQL & Table API >

[GitHub] [flink] hanyuzheng7 opened a new pull request, #22834: [FLINK-32260]-table-Add-ARRAY_SLICE-function

2023-06-20 Thread via GitHub
hanyuzheng7 opened a new pull request, #22834: URL: https://github.com/apache/flink/pull/22834 Implement the array_slice function to extract a subset of elements from an array. Description: The array_slice function in the ETL pipeline allows you to extract a subset of elements from

[jira] [Created] (FLINK-32398) Support Avro SpecificRecord in DataStream and Table conversion.

2023-06-20 Thread Jiangjie Qin (Jira)
Jiangjie Qin created FLINK-32398: Summary: Support Avro SpecificRecord in DataStream and Table conversion. Key: FLINK-32398 URL: https://issues.apache.org/jira/browse/FLINK-32398 Project: Flink

[GitHub] [flink] snuyanzin commented on pull request #22624: [FLINK-32132][table-planner] Cast function CODEGEN does not work as e…

2023-06-20 Thread via GitHub
snuyanzin commented on PR #22624: URL: https://github.com/apache/flink/pull/22624#issuecomment-1598826176 hmm, it looks like you renamed class however not renamed file... could you also please rename file in order to have them in sync? -- This is an automated message from the Apache Git

[GitHub] [flink] je-ik commented on a diff in pull request #22551: [FLINK-31919][core] Only run closure cleaner if serialization fails

2023-06-20 Thread via GitHub
je-ik commented on code in PR #22551: URL: https://github.com/apache/flink/pull/22551#discussion_r1235292316 ## flink-core/src/main/java/org/apache/flink/api/java/ClosureCleaner.java: ## @@ -169,7 +175,17 @@ && needsRecursion(f, fieldObject)) { private static boolean

[GitHub] [flink] zhougit86 commented on pull request #22624: [FLINK-32132][table-planner] Cast function CODEGEN does not work as e…

2023-06-20 Thread via GitHub
zhougit86 commented on PR #22624: URL: https://github.com/apache/flink/pull/22624#issuecomment-1598820824 > hi @zhougit86 it looks ok from my side thanks for addressing comments > > the only nit pick: could you please rename `CastFunctionMiscITLegacyCase` in way that it matches regex

[jira] [Commented] (FLINK-15773) ClosureCleaner fails with joda DateTimeZone

2023-06-20 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735295#comment-17735295 ] Jan Lukavský commented on FLINK-15773: -- Makes sense it will fix it. Unfortunately, Apache Beam

[jira] [Commented] (FLINK-15773) ClosureCleaner fails with joda DateTimeZone

2023-06-20 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735293#comment-17735293 ] Chesnay Schepler commented on FLINK-15773: -- I'd be curious if this still fails on the current

[jira] [Updated] (FLINK-32396) Support timestamp for jdbc driver and gateway

2023-06-20 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong updated FLINK-32396: -- Parent: (was: FLINK-31496) Issue Type: Improvement (was: Sub-task) > Support timestamp

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #622: [FLINK-32012] Provide rollback feature on savepoint upgrade mode if HA missing and JM never started

2023-06-20 Thread via GitHub
gyfora commented on code in PR #622: URL: https://github.com/apache/flink-kubernetes-operator/pull/622#discussion_r1235269862 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -281,6 +284,17 @@ public

[jira] [Assigned] (FLINK-24911) Enable line numbers in SQL Client

2023-06-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-24911: --- Assignee: Sergey Nuyanzin > Enable line numbers in SQL Client >

[jira] [Closed] (FLINK-24592) FlinkSQL multiline parser improvements

2023-06-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-24592. --- > FlinkSQL multiline parser improvements > -- > >

[jira] [Resolved] (FLINK-24592) FlinkSQL multiline parser improvements

2023-06-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-24592. - Resolution: Fixed Merged to master as

[jira] [Commented] (FLINK-15773) ClosureCleaner fails with joda DateTimeZone

2023-06-20 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735283#comment-17735283 ] Jan Lukavský commented on FLINK-15773: -- [~rocketraman] The only workaround, unfortunately, is to

[GitHub] [flink] flinkbot commented on pull request #22833: [FLINK-32283][network] Implement the SortBufferAccumulator for the tiered storage

2023-06-20 Thread via GitHub
flinkbot commented on PR #22833: URL: https://github.com/apache/flink/pull/22833#issuecomment-1598705770 ## CI report: * 6bae94bd7afb6d8fad6634fa4f4e4ebbf45919cb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] TanYuxin-tyx opened a new pull request, #22833: [FLINK-32283][network] Implement the SortBufferAccumulator for the tiered storage

2023-06-20 Thread via GitHub
TanYuxin-tyx opened a new pull request, #22833: URL: https://github.com/apache/flink/pull/22833 ## What is the purpose of the change *Implement the SortBufferAccumulator for the tiered storage* ## Brief change log - *Implement the

[jira] [Updated] (FLINK-32283) Implement SortBufferAccumulator

2023-06-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32283: --- Labels: pull-request-available (was: ) > Implement SortBufferAccumulator >

[GitHub] [flink-kubernetes-operator] ashangit commented on a diff in pull request #622: [FLINK-32012] Provide rollback feature on savepoint upgrade mode if HA missing and JM never started

2023-06-20 Thread via GitHub
ashangit commented on code in PR #622: URL: https://github.com/apache/flink-kubernetes-operator/pull/622#discussion_r1235200832 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -281,6 +284,17 @@ public

[GitHub] [flink-kubernetes-operator] ashangit commented on a diff in pull request #622: [FLINK-32012] Provide rollback feature on savepoint upgrade mode if HA missing and JM never started

2023-06-20 Thread via GitHub
ashangit commented on code in PR #622: URL: https://github.com/apache/flink-kubernetes-operator/pull/622#discussion_r1235200832 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -281,6 +284,17 @@ public

[jira] [Commented] (FLINK-32397) Add doc for add/drop/show partition

2023-06-20 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735268#comment-17735268 ] luoyuxia commented on FLINK-32397: -- [~ruanhang1993] Thanks for voluntering.  > Add doc for

[jira] [Assigned] (FLINK-32397) Add doc for add/drop/show partition

2023-06-20 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-32397: Assignee: Hang Ruan > Add doc for add/drop/show partition > ---

[jira] [Commented] (FLINK-32397) Add doc for add/drop/show partition

2023-06-20 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735266#comment-17735266 ] Hang Ruan commented on FLINK-32397: --- I would like to help. Please assign this to me. Thanks. > Add

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #622: [FLINK-32012] Provide rollback feature on savepoint upgrade mode if HA missing and JM never started

2023-06-20 Thread via GitHub
gyfora commented on code in PR #622: URL: https://github.com/apache/flink-kubernetes-operator/pull/622#discussion_r1235180304 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -281,6 +284,17 @@ public

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #622: [FLINK-32012] Provide rollback feature on savepoint upgrade mode if HA missing and JM never started

2023-06-20 Thread via GitHub
gyfora commented on code in PR #622: URL: https://github.com/apache/flink-kubernetes-operator/pull/622#discussion_r1235179801 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -281,6 +284,17 @@ public

[jira] [Comment Edited] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-20 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735264#comment-17735264 ] Chesnay Schepler edited comment on FLINK-32379 at 6/20/23 12:15 PM:

[jira] [Commented] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-20 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735264#comment-17735264 ] Chesnay Schepler commented on FLINK-32379: -- The simple colution would be to annotate the

[GitHub] [flink-kubernetes-operator] ashangit commented on a diff in pull request #622: [FLINK-32012] Provide rollback feature on savepoint upgrade mode if HA missing and JM never started

2023-06-20 Thread via GitHub
ashangit commented on code in PR #622: URL: https://github.com/apache/flink-kubernetes-operator/pull/622#discussion_r1235168059 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -281,6 +284,17 @@ public

[GitHub] [flink] StefanRRichter commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-20 Thread via GitHub
StefanRRichter commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1235160538 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalKeyedStateHandle.java: ## @@ -32,9 +36,62 @@ UUID getBackendIdentifier();

[GitHub] [flink] flinkbot commented on pull request #22832: [FLINK-32396][jdbc-driver] Support timestamp and timestamp_ltz for jdbc driver and sql gateway

2023-06-20 Thread via GitHub
flinkbot commented on PR #22832: URL: https://github.com/apache/flink/pull/22832#issuecomment-1598627991 ## CI report: * 6f2882efb05d470afc77de12aa0ee262a12c8663 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-32397) Add doc for add/drop/show partition

2023-06-20 Thread luoyuxia (Jira)
luoyuxia created FLINK-32397: Summary: Add doc for add/drop/show partition Key: FLINK-32397 URL: https://issues.apache.org/jira/browse/FLINK-32397 Project: Flink Issue Type: Sub-task

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-20 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1235147823 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandle.java: ## @@ -359,11 +357,12 @@ IncrementalRemoteKeyedStateHandle

[jira] [Resolved] (FLINK-27243) Support SHOW PARTITIONS statement for partitioned table

2023-06-20 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-27243. -- Resolution: Fixed master: d7f2ec3414cf72a714337041da9a74bbb3c394f6 > Support SHOW PARTITIONS

[jira] [Updated] (FLINK-32396) Support timestamp for jdbc driver and gateway

2023-06-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32396: --- Labels: pull-request-available (was: ) > Support timestamp for jdbc driver and gateway >

[GitHub] [flink] luoyuxia commented on pull request #22721: [FLINK-27243][table] Support SHOW PARTITIONS statement for partitioned table

2023-06-20 Thread via GitHub
luoyuxia commented on PR #22721: URL: https://github.com/apache/flink/pull/22721#issuecomment-1598621744 @ruanhang1993 Thanks for reviewing. Merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] luoyuxia merged pull request #22721: [FLINK-27243][table] Support SHOW PARTITIONS statement for partitioned table

2023-06-20 Thread via GitHub
luoyuxia merged PR #22721: URL: https://github.com/apache/flink/pull/22721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] FangYongs opened a new pull request, #22832: [FLINK-32396][jdbc-driver] Support timestamp and timestamp_ltz for jdbc driver and sql gateway

2023-06-20 Thread via GitHub
FangYongs opened a new pull request, #22832: URL: https://github.com/apache/flink/pull/22832 ## What is the purpose of the change This PR aims to support timestamp and timestamp_ltz data type in jdbc driver. ## Brief change log - Add zone id in statement result for

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-20 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1235146158 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalKeyedStateHandle.java: ## @@ -32,9 +36,62 @@ UUID getBackendIdentifier(); /** -

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-20 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1235145121 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalKeyedStateHandle.java: ## @@ -32,9 +36,62 @@ UUID getBackendIdentifier(); /** -

[jira] [Updated] (FLINK-32396) Support timestamp for jdbc driver and gateway

2023-06-20 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong updated FLINK-32396: -- Parent: FLINK-31496 Issue Type: Sub-task (was: Improvement) > Support timestamp for jdbc

[jira] [Created] (FLINK-32396) Support timestamp for jdbc driver and gateway

2023-06-20 Thread Fang Yong (Jira)
Fang Yong created FLINK-32396: - Summary: Support timestamp for jdbc driver and gateway Key: FLINK-32396 URL: https://issues.apache.org/jira/browse/FLINK-32396 Project: Flink Issue Type:

[jira] [Closed] (FLINK-31642) Introduce memory tier reader

2023-06-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-31642. -- Fix Version/s: 1.18.0 Resolution: Done master(1.18) via

[GitHub] [flink] reswqa merged pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-20 Thread via GitHub
reswqa merged PR #22733: URL: https://github.com/apache/flink/pull/22733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] StefanRRichter commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-20 Thread via GitHub
StefanRRichter commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1235123408 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandle.java: ## @@ -359,11 +357,12 @@ IncrementalRemoteKeyedStateHandle

[GitHub] [flink] XComp commented on a diff in pull request #22830: [FLINK-30343][test] Migrates KubernetesLeaderElectionAndRetrievalITCase to use the MultipleComponentLeaderElectionDriver interface

2023-06-20 Thread via GitHub
XComp commented on code in PR #22830: URL: https://github.com/apache/flink/pull/22830#discussion_r1235122006 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesLeaderElectionAndRetrievalITCase.java: ## @@ -89,68 +92,67 @@ void

[GitHub] [flink] XComp commented on a diff in pull request #22830: [FLINK-30343][test] Migrates KubernetesLeaderElectionAndRetrievalITCase to use the MultipleComponentLeaderElectionDriver interface

2023-06-20 Thread via GitHub
XComp commented on code in PR #22830: URL: https://github.com/apache/flink/pull/22830#discussion_r1235120950 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesLeaderElectionAndRetrievalITCase.java: ## @@ -89,68 +92,67 @@ void

[GitHub] [flink] XComp commented on a diff in pull request #22829: [FLINK-30342][test] Migrates ZooKeeperLeaderElectionTest to use the MultipleComponentLeaderElectionDriver interface

2023-06-20 Thread via GitHub
XComp commented on code in PR #22829: URL: https://github.com/apache/flink/pull/22829#discussion_r1235120608 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionTest.java: ## @@ -438,13 +441,20 @@ void

[GitHub] [flink] XComp commented on a diff in pull request #22829: [FLINK-30342][test] Migrates ZooKeeperLeaderElectionTest to use the MultipleComponentLeaderElectionDriver interface

2023-06-20 Thread via GitHub
XComp commented on code in PR #22829: URL: https://github.com/apache/flink/pull/22829#discussion_r1235120307 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionTest.java: ## @@ -396,17 +391,22 @@ void

  1   2   >