Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2371#discussion_r74724570
--- Diff:
flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java
---
@@ -88,4 +90,49 @@ private String typeParamToString
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2345
@StephanEwen That would probably be good, on a side note, time is
calculated in the `CheckpointCoordinator` as ` - ` right now.
This is somewhat confusing because it does not give the
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/2379
Add ManualSpeedTestITCase For Assessing State Performance
This should be used to test whether there are any obvious performance
regressions between releases. Somewhat similar to the other
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2355#discussion_r75305677
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingEventTimeWindows.java
---
@@ -52,16 +52,19
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2355#discussion_r75305650
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingEventTimeWindows.java
---
@@ -52,16 +52,19
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2355#discussion_r75305729
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingEventTimeWindows.java
---
@@ -102,7 +105,32
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2355#discussion_r75305993
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
---
@@ -553,7 +553,7 @@ public
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2355#discussion_r75306168
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
---
@@ -2550,4 +2550,36
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2355#discussion_r75306425
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowingTestHarnessTest.java
---
@@ -84,6 +86,84
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2355
The code looks very good! I had some comments about whitespace/formatting
and the placement of tests. (It's quite hard to know where to put these without
a lot of experience with the code
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2379#discussion_r75336239
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/state/ManualWindowSpeedITCase.java
---
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apache
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2355
@Renkai Unfortunately I'm not aware of such a tool. The IDE I use
(IntelliJ) tends to always do changes in a lot of other places when I use the
reformat tool so I try to stay away from
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2387
I really like the new look/structure. ð
What's strange is that when I click the breadcrumb links, I get an empty
page. For example if I click "API"
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2379
@rmetzger I changed to `FsStateBackend`. What do you think now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2350
I made one inline comments about moving the `SourceContext` and the
instantiation code.
Also, the problem with the "async exception check" can be solved by
introducing an
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2350#discussion_r75488070
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -103,12 +103,28
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/2379
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2390
+1, when adding this we should probably replace all uses of the `Guava`
version and check that we don't use it using checkstyle rules. (If our goal is
to one day remove our dependency on `
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2355
I merged it. Thanks for your work! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2350#discussion_r75647030
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -63,22 +66,22
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2350
This looks very good now! ð
I'm running it a last time on Travis and them I'm merging.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2350
Ah, seems I was a bit to quick earlier. I added one more inline comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2350#discussion_r75652728
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java
---
@@ -188,18 +189,19 @@ public void close
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2413
It should be fixed by not loading the `StateDescriptor` anymore, yes. We
should maybe only merge it on the 1.1.* release branch because for 1.2 it will
be overwritten by our changes.
---
If your
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2413
Yes, please. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2413
I think so, yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2109
Hi,
I just saw that this was merged but I still have some comments. What is the
reason for the added Guava (test)-dependency? (Probably a leftover but should
nevertheless not be in this) And
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2269
Hi,
I'm very for the delays! I still have this sitting at the top of my list
and I'm hoping to get this in by beginning of next week.
---
If your project is set up for it, you ca
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2109
@mxm @mushketyk Technically this change does add a new method that is the
now deprecated method minus the `FilePathFilter`. That's a good change, though,
since it simplifies the API in the lon
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2414
Minus @rmetzger's comment this looks good to merge! Thanks for fixing this
@tzulitai!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2434#discussion_r76624448
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/MockRuntimeContext.java
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2434#discussion_r76624854
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/DefaultTimeServiceProvider.java
---
@@ -28,15 +31,22
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2434#discussion_r76625434
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/OneInputStreamOperatorTestHarness.java
---
@@ -98,7 +99,7 @@ public
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2434
I had comments about introducing an interface for the asynchronous excepts,
other than that and @rmetzger's comment this looks good. I like the addition of
the `TimeProviderTest`. ð
-
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2269
I merged it, could you please close this PR if it's not closed
automatically.
Thanks for your work, and sorry again for taking so long to get it in! ð
---
If your project is s
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2356
The changes look good! ð Thanks for the work. We recently (today) merged
an updated version of `RollingSink` called `BucketingSink`. Would you be
willing to forward port your changes to that as
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2446
I merged it, thanks for the fix. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/2345
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/2476
[FLINK-4589] Fix Merging of Covering Window in MergingWindowSet
This also adds two new test cases for that problem.
R: @StephanEwen
You can merge this pull request into a Git repository
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2386#discussion_r78147868
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/collector/selector/DirectedOutput.java
---
@@ -95,11 +100,17 @@ public
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2386#discussion_r78148192
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -125,6 +126,11
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2386#discussion_r78148223
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
---
@@ -322,6 +346,151 @@ public final
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2512
I think most of the proposed renames are good. One thing that would be good
to change is to remove `SnapshotProvider` and just have that method directly on
`OperatorStateBackend`.
I really
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2525
No worries. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2434#discussion_r79853936
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -212,10 +212,6 @@ public void setTimeService
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2434#discussion_r79854449
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -486,6 +472,9 @@ private void
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2434#discussion_r79858930
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/TimeProviderTest.java
---
@@ -0,0 +1,198
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2434#discussion_r79854646
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -326,6 +322,9 @@ public Long getValue
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2434#discussion_r79854335
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -365,19 +364,6 @@ public Long getValue
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2533
@StephanEwen we can do that but then we won't have any sanity checks for
the `TypeSerializer` any more. Right now, even the RocksDB backed will
serializer the `TypeSerializer`/`StateDescr
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2533#discussion_r80005604
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -266,18 +265,20 @@ public void
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2532
Good work. ð
I merged this, so could you please close the two PRs and the relevant
issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105368360
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -419,6 +435,14 @@ public
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105372676
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -419,6 +435,14 @@ public
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3509
[FLINK-5808] Fix Missing verification for setParallelism and
setMaxParallelism
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105409533
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordWriterOutput.java
---
@@ -72,6 +76,11 @@ public
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105435806
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordWriterOutput.java
---
@@ -72,6 +76,11 @@ public
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105436193
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -387,14 +403,25 @@ public int
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105436408
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -539,5 +625,26 @@ public void collect
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105441456
--- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3484
Thanks @kl0u for the (already) quite thorough review! I'll push a commit
with fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3484
@kl0u @chenqin I cleaned up the commits, distributed the fixes from the
comments to the right commits. I also added more tests/ITCases for: detecting
name clashes in side output IDs, side outputs
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3514#discussion_r105648422
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalWatermarkCallbackService.java
---
@@ -58,7 +59,17
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3479#discussion_r105661210
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -628,6 +644,123
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3479#discussion_r105661470
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/functions/InternalAggregateProcessAllWindowFunction.java
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3479#discussion_r105662139
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/windowing/FoldApplyProcessWindowFunction.java
---
@@ -92,12 +93,45
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3479#discussion_r105660519
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -153,6 +161,8
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3509#discussion_r105667466
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -280,13 +289,18 @@ public int getParallelism
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3509#discussion_r105671778
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -38,14 +38,10
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3509#discussion_r105672152
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -83,6 +83,15 @@
*/
public static final int
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3445#discussion_r105682110
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPMigrationTest.java
---
@@ -75,9 +94,15 @@ public void
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3445#discussion_r105683186
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPMigrationTest.java
---
@@ -240,4 +270,159 @@ public Byte getKey(Event
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3509#discussion_r105690923
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -38,14 +38,10
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3535
[FLINK-5713] Protect against NPE in WindowOperator window cleanup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink jira-5713
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3535
R: @kl0u for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3445#discussion_r105937053
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPMigration11to13Test.java
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3445#discussion_r105936184
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPMigrationTestBase.java
---
@@ -0,0 +1,241 @@
+/*
+ * Licensed
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3535#discussion_r105956185
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -354,22 +354,27 @@ public
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3509#discussion_r106040063
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -38,14 +38,10
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3509#discussion_r106125756
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -38,14 +38,10
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3544
[FLINK-6001] Fix ContinuousEventTimeTrigger firing without state
R: @kl0u
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink jira
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/3544
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3534
This looks good! I'll wait for travis and then merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3483#discussion_r106135988
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java
---
@@ -359,4 +360,8 @@ public KeyGroupRange
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3483#discussion_r106138010
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteStateTable.java
---
@@ -0,0 +1,1021 @@
+/*
+ * Licensed to
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3483#discussion_r106138099
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteStateTable.java
---
@@ -0,0 +1,1021 @@
+/*
+ * Licensed to
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3483#discussion_r106132624
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/NestedMapsStateTable.java
---
@@ -0,0 +1,348 @@
+/*
+ * Licensed to the
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3483#discussion_r106137387
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackendSnapshotBackwardsCompatibilityTest.java
---
@@ -0,0 +1,107
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3483#discussion_r106139194
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/StateEntry.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3483#discussion_r106133243
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/AbstractHeapMergingState.java
---
@@ -47,77 +44,62
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3483#discussion_r106136980
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackendSnapshotBackwardsCompatibilityTest.java
---
@@ -0,0 +1,107
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3534
Thanks for your contribution! ð I just merged.
Could you please close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3483#discussion_r106132349
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/KeyContext.java
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3483#discussion_r106138741
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackendSnapshotBackwardsCompatibilityTest.java
---
@@ -0,0 +1,107
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3483#discussion_r106137929
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteStateTable.java
---
@@ -0,0 +1,1021 @@
+/*
+ * Licensed to
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/commit/0a501e9f7f56baba2905002b74746998458db007#commitcomment-21347344
In
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java:
In
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/commit/0a501e9f7f56baba2905002b74746998458db007#commitcomment-21351102
In
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java:
In
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3534
@StephanEwen you're right, this is problematic. The funny thing is, that
this actually works for Kryo. Having a serialiser without any registered
types/serializer works when the rest
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3508
I would like us to take some time and think about the name. We are about to
introduce a thing called "broadcast state" somewhat soon in the effort to make
streaming joins possible. This
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3508
+1 on not exposing the Java Serialisation shortcut, btw. I was very unhappy
that we even have it for the normal operator state. ð
---
If your project is set up for it, you can reply to this
1 - 100 of 5077 matches
Mail list logo
