[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...

2015-01-26 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/333#discussion_r23527422 --- Diff: flink-dist/pom.xml --- @@ -436,6 +436,37 @@ under the License. /gitDescribe

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-26 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/304 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1396][FLINK-1303] Hadoop Input/Output d...

2015-02-04 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/363 [FLINK-1396][FLINK-1303] Hadoop Input/Output directly in API This adds methods on ExecutionEnvironment for reading with Hadoop Input/OutputFormat. This also adds support in the Scala

[GitHub] flink pull request: [FLINK-1463] Fix stateful/stateless Serializer...

2015-01-30 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/353 [FLINK-1463] Fix stateful/stateless Serializers and Comparators Before, Serializers would announce whether they are stateful or not and rely on RuntimeStatefulSerializerFactory to do

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-02-02 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/236#issuecomment-72433217 Yes, it is not a good solution But what you propose isn't either: If we use Kryo for those subclasses that we cannot handle then nothing works anymore. The whole reason

[GitHub] flink pull request: [FLINK-1458] Allow Interfaces and abstract typ...

2015-02-02 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/357 [FLINK-1458] Allow Interfaces and abstract types in TypeExtractor Kryo already supports them, so it was just a question of the TypeExtractor allowing them. I also added tests

[GitHub] flink pull request: [FLINK-1458] Allow Interfaces and abstract typ...

2015-02-03 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/357#issuecomment-72642370 You're right. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1396][FLINK-1303] Hadoop Input/Output d...

2015-02-05 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/363#issuecomment-73040767 I think if executing it in an IDE the dependencies are not there. Since flink-java does not depend on flink-runtime, which has the hadoop dependencies. --- If your

[GitHub] flink pull request: [FLINK-1396][FLINK-1303] Hadoop Input/Output d...

2015-02-05 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/363#issuecomment-73039917 @StephanEwen If I add the exclusions then users that just add flink-java as a dependency will get weird errors when using Hadoop InputFormats. --- If your

[GitHub] flink pull request: [FLINK-1463] Fix stateful/stateless Serializer...

2015-02-05 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/353#issuecomment-73077279 Do you think that with the additional checking logic this would really make up for one superfluous duplication? --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1463] Fix stateful/stateless Serializer...

2015-02-05 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/353#issuecomment-73079161 Ok, then I'll add this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1458] Allow Interfaces and abstract typ...

2015-02-05 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1396][FLINK-1303] Hadoop Input/Output d...

2015-02-05 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/363#issuecomment-73020223 I addressed the comments. What do the others think about overloading readFile()? I made it like this on purpose. So that the user sees in the API that they are using

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-02-03 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72752435 Nope, sorry, also have no Idea why this is happening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-14 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/304#issuecomment-69988955 Ok, I looked at the existing LICENSE and NOTICE files and they don't contain any entries for apache licences projects. jodatime and the kaffee serialisers are also

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-14 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r22968923 --- Diff: flink-java/pom.xml --- @@ -64,6 +64,18 @@ under the License. version0.5.1/version /dependency

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-14 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r22968293 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/typeutils/SerializerTestBase.java --- @@ -99,6 +104,7 @@ public void testCopy

[GitHub] flink pull request: FLINK-1402 - Remove Serializable extends from ...

2015-01-14 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/306#issuecomment-69989899 I also find it quite helpful to have Serialised repeated in such cases. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-01-15 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/236#issuecomment-70216890 No objections, your honour. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-15 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r22999053 --- Diff: flink-java/pom.xml --- @@ -64,6 +64,18 @@ under the License. version0.5.1/version /dependency

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-15 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-70065763 I added register methods at the ExecutionEnvironment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: https://issues.apache.org/jira/browse/FLINK-13...

2015-01-15 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/312#issuecomment-70071567 Did you do anything besides trying to add all release-0.8 commits to the master? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-15 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/304#issuecomment-70063665 I added to LICENSE AND NOTICE and also addressed the other issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-947] Add a declarative expression API

2015-02-18 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/405#issuecomment-74842606 Yeah, I'm not sure about linq as well. I like the name but realise that it might be problematic. What do the others think. I could call it flink-expressions. I

[GitHub] flink pull request: [FLINK-1417] Automatically register types with...

2015-02-18 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/393#issuecomment-74843783 Yes please, go ahead. But if our Pojo stuff is really that slow we should think about how to improve that or remove it alltogether. --- If your project is set up

[GitHub] flink pull request: [FLINK-1417] Automatically register types with...

2015-02-17 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/393#issuecomment-74744132 What exactly are you running? TPC-H Query 3? Maybe we should test how fast Kryo would be with the PojoComparator. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1417] Automatically register types with...

2015-02-16 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/393#discussion_r24749284 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java --- @@ -292,7 +360,76 @@ public void registerKryoType(Class? type

[GitHub] flink pull request: [FLINK-947] Add a declarative expression API

2015-02-16 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/405 [FLINK-947] Add a declarative expression API This one is quite big. So you should check out the documentation, skaldic, examples and test cases to see how the API works. You can merge this pull

[GitHub] flink pull request: [FLINK-1193][java-api][scala-api] Complete sup...

2015-01-29 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/348#discussion_r23773125 --- Diff: flink-tests/src/test/scala/org/apache/flink/api/scala/types/TypeInformationGenTest.scala --- @@ -255,6 +255,53 @@ class TypeInformationGenTest

[GitHub] flink pull request: [FLINK-1422] Add withParameters() to documenta...

2015-01-29 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/350#issuecomment-72039131 +1 looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-01-29 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/236#issuecomment-72006969 We could try and analyse the type as a POJO. If it is a POJO add it to the PojoSerializer, otherwise, add it to the KryoSerializer. --- If your project is set up

[GitHub] flink pull request: [FLINK-1460] fix typos

2015-01-29 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/346#issuecomment-72036147 +1, can you merge it @hsaputra or should I? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-01-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/236#issuecomment-71436404 I will have to rework this now that the support for registering Types and Serializers at Kryo was merged. The POJO subclass with tagging is slower because we do

[GitHub] flink pull request: [FLINK-1369] [types] Add support for Subclasse...

2015-01-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/316#issuecomment-71445361 It's almost the same, except for the change to handle Interfaces and Abstract Classes with GenericTypeInfo, correct? The part that changes the KryoSerializer

[GitHub] flink pull request: Fix nested generics scala

2015-01-11 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/293#issuecomment-69487377 Ok, if no one has any objections I will merge this and also cherry-pick in onto the 0.8 release branch. --- If your project is set up for it, you can reply

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-02-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/236#discussion_r24403182 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java --- @@ -169,4 +186,113 @@ public ExecutionConfig disableObjectReuse

[GitHub] flink pull request: [FLINK-1463] Fix stateful/stateless Serializer...

2015-02-09 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/353#issuecomment-73501310 Manually merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1622][java-api][scala-api] add a GroupC...

2015-03-18 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/466#issuecomment-82886862 I would say it's good to go now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-1720] Integrate ScalaDoc into JavaDoc

2015-03-18 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/497 [FLINK-1720] Integrate ScalaDoc into JavaDoc This uses genjavadoc to generate Fake Java Source that only serves as a proxy for the Scala code. ScalaDoc syntax in the original will be converted

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-20 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-83969916 Correct, that's why I'm doing a Pull Request. People can chime in here if they want. Or should we continue the discussion on the mailing list? I though everyone

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-19 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/503 Make Expression API available to Java, Rename it to Table API This also adds tests and more Javadoc documentation for the Table API. You can merge this pull request into a Git repository by running

[GitHub] flink pull request: [FLINK-1622][java-api][scala-api] add a partia...

2015-03-12 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/466#issuecomment-78101926 Sorry, I completely blanked, of course, You still need the grouping, only the shuffle step you don't need. So, I suggest only better tests, using a combination

[GitHub] flink pull request: [FLINK-1622][java-api][scala-api] add a partia...

2015-03-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/466#discussion_r26105008 --- Diff: flink-compiler/src/main/java/org/apache/flink/compiler/operators/GroupReducePartialProperties.java --- @@ -0,0 +1,112 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-1622][java-api][scala-api] add a partia...

2015-03-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/466#discussion_r26105136 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/SortedGrouping.java --- @@ -156,6 +156,23 @@ public SortedGrouping(DataSetT set

[GitHub] flink pull request: [FLINK-1622][java-api][scala-api] add a partia...

2015-03-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/466#discussion_r26105155 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/UnsortedGrouping.java --- @@ -159,7 +159,23 @@ public UnsortedGrouping(DataSetT set

[GitHub] flink pull request: [FLINK-1622][java-api][scala-api] add a partia...

2015-03-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/466#discussion_r26105226 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala --- @@ -355,6 +355,63 @@ class GroupedDataSet[T: ClassTag

[GitHub] flink pull request: [FLINK-1622][java-api][scala-api] add a partia...

2015-03-10 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/466#issuecomment-78016698 I like the implementation, except for my comments on groupReducePartial() on grouped DataSets. Also, the tests seem a bit shady because of all the grouping and regular

[GitHub] flink pull request: [FLINK-1769] Fix deploy bug caused by ScalaDoc...

2015-03-25 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/535 [FLINK-1769] Fix deploy bug caused by ScalaDoc aggregation I added a new profile that should be used when building the combined JavaDoc. I will add a jira issue for changing this in the nightly

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-25 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-86112294 I fixed @rmetzger's remarks. Still waiting for a solution to the naming issue. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-1769] Fix deploy bug caused by ScalaDoc...

2015-03-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/535#issuecomment-86416475 I just wanted to leave it sitting here for a while. But if no-one has any reservations I'll merge it today. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1788] [table] Make logical plans transf...

2015-03-31 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/550 [FLINK-1788] [table] Make logical plans transformable You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink flinq-mutable-plans

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-03-03 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-76973194 Yes, this sounds good? Another thing: it has probably already come up but I just want to make sure, you implement CoGroup and Reduce the way you do because

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-03-03 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-76981299 You could call it CoGroupRaw, just an idea... Once that and the split into the python and generic part is done I vote for merging this. The API looks good

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-03-02 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-76738603 I'm the next person to be looking at this. Hopefully wan can merge it after I've looked at it. :smile: @zentol Do you want to keep in in the current location

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-03-04 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-77127742 Thanks, I have two last requests, sorry for that. Could you rename flink-generic to flink-language-binding-generic? The problem is, that the package name is now

[GitHub] flink pull request: [FLINK-1769] Fix deploy bug caused by ScalaDoc...

2015-03-26 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-01-29 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/236#issuecomment-72161285 Then it fails at runtime, which makes me very uneasy. But then again, stuff can always fail at runtime when the user uses some strange subclass. Even more so without

[GitHub] flink pull request: Stream graph + internal refactor

2015-04-14 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/594#issuecomment-92854325 Regarding StreamRecord, is the UID still required? In my understanding we are working towards state-snapshotting, so that would not require to have IDs in records

[GitHub] flink pull request: Stream graph + internal refactor

2015-04-14 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/594#issuecomment-92856455 By the way, all these comments I'm making. I'm just making them to keep track of things. If we discuss them and want to implement some changes I can also do this myself

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-04-20 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-94443054 I just ran it on the cluster. Works like a charm. :smile: For word count, python takes 12 minutes, java about 2:40. But this should be expected, I guess

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-04-20 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-94402978 I was referring to the way that communication is handled between the java host and the generic language client: Communication between them is not based on a fixed set

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-04-20 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-94400959 I'll test it again on a cluster. Could you please elaborate a bit. Is the timeout still in? Communication is through TCP instead of the mapped files. but still

[GitHub] flink pull request: [FLINK-1799][scala] Fix handling of generic ar...

2015-04-20 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/582#issuecomment-94392757 Any more thoughts? Otherwise I would like to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1799][scala] Fix handling of generic ar...

2015-04-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/582#discussion_r28692599 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/ObjectArrayTypeInfo.java --- @@ -143,6 +143,18 @@ else if (type instanceof Class

[GitHub] flink pull request: [FLINK-1867/1880] Raise test timeouts in hope ...

2015-04-20 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/612 [FLINK-1867/1880] Raise test timeouts in hope of fixing Travis fails You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink raise-test

[GitHub] flink pull request: [FLINK-1867/1880] Raise test timeouts in hope ...

2015-04-21 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/612#issuecomment-94799019 Any thoughts on this? I would really like to merge this to improve Travis reliability. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-04-21 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-94798439 I merged it. :smile: Thanks a lot @zentol for staying with this for so long. Great work! P.S. Could you please close this PR, I always forget adding

[GitHub] flink pull request: [FLINK-1799][scala] Fix handling of generic ar...

2015-04-21 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/582#issuecomment-94799103 So, any thoughts about merging this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-1615] [java api] SimpleTweetInputFormat

2015-04-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/442#issuecomment-95846017 The problem is, that I can't see it in the github interface. On what branch are your changes? Could you please rebase them on top of the current master? --- If your

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-04-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/593#issuecomment-95845500 OK, @StephanEwen, any thoughts on this? Should we allow that the local user code class loader in the client potentially doesn't have the same jars available

[GitHub] flink pull request: [FLINK-1867/1880] Raise test timeouts in hope ...

2015-04-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/612#issuecomment-95946066 Manually merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1867/1880] Raise test timeouts in hope ...

2015-04-24 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/612 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1615] [java api] SimpleTweetInputFormat

2015-04-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/621#issuecomment-95926348 The build still fails because of missing license headers in the model package. By the way, did you write the files in the model package yourself or were

[GitHub] flink pull request: [FLINK-1615] [java api] SimpleTweetInputFormat

2015-04-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/442#issuecomment-95570894 Where is your git repository? So that I can checkout your commit and merge it? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-1867/1880] Raise test timeouts in hope ...

2015-04-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/612#discussion_r28943704 --- Diff: flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/jobmanager/JobManagerFailsITCase.scala --- @@ -18,24 +18,23 @@ package

[GitHub] flink pull request: [FLINK-1867/1880] Raise test timeouts in hope ...

2015-04-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/612#discussion_r28943849 --- Diff: flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractProcessFailureRecoveryTest.java --- @@ -112,9 +112,9 @@ public void

[GitHub] flink pull request: [FLINK-1867/1880] Raise test timeouts in hope ...

2015-04-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/612#discussion_r28943875 --- Diff: flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractProcessFailureRecoveryTest.java --- @@ -112,9 +112,9 @@ public void

[GitHub] flink pull request: [FLINK-1867/1880] Raise test timeouts in hope ...

2015-04-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/612#discussion_r28943824 --- Diff: flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractProcessFailureRecoveryTest.java --- @@ -112,9 +112,9 @@ public void

[GitHub] flink pull request: [FLINK-1867/1880] Raise test timeouts in hope ...

2015-04-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/612#discussion_r28943731 --- Diff: flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/jobmanager/JobManagerFailsITCase.scala --- @@ -136,9 +135,9 @@ with WordSpecLike

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-04-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/593#issuecomment-95500680 This does not work if the user uses classes that are not available on the local machine since you don't add the additional class path entries

[GitHub] flink pull request: [FLINK-1615] [java api] SimpleTweetInputFormat

2015-04-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/442#issuecomment-95511047 This looks good to merge. Any objections? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-1867/1880] Raise test timeouts in hope ...

2015-04-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/612#discussion_r28943598 --- Diff: flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/taskmanager/TaskManagerFailsITCase.scala --- @@ -231,9 +231,9 @@ with WordSpecLike

[GitHub] flink pull request: [FLINK-1472] Fixed Web frontend config overvie...

2015-04-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-95517673 Hi, sorry for the long wait on this. I really like the feature but the implementation is not scalable: If new config values are added this needs to be updated

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-04-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-95521509 I'm against merging this, to me this seems like a lot of code for something that can be achieved using a simple mapper. Also, if we add this, then we should also have

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-04-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/593#issuecomment-95564844 Yes, this is true, but the way it is implemented, the folders are not always added to the class loader. Maybe I'm wrong here, but JobWithJars.getUserCodeClassLoader

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-04-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-95566780 Yes, I think we should start a discussion there. I just wanted to give the reasons for my opinion here. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1472] Fixed Web frontend config overvie...

2015-04-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-95580562 Yes, but then we should change this now and not build more code on top of this that can fail in the future if someone forgets to add the names to the correct hash set

[GitHub] flink pull request: [FLINK-1472] Fixed Web frontend config overvie...

2015-04-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-95581307 I added a Jira for this: https://issues.apache.org/jira/browse/FLINK-1936 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-924] Add automatic dependency retrieval...

2015-04-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/35#issuecomment-95590430 Hi @qmlmoon, sorry for the long wait on this PR. Could you please rebase on top of the current master and also get rid of the merge commits in the process

[GitHub] flink pull request: [FLINK-1867/1880] Raise test timeouts in hope ...

2015-04-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/612#discussion_r28961799 --- Diff: flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/taskmanager/TaskManagerFailsITCase.scala --- @@ -231,9 +231,9 @@ with WordSpecLike

[GitHub] flink pull request: [FLINK-1472] Fixed Web frontend config overvie...

2015-04-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-95561718 But then I think the solution is to normalise the constants in ConfigConstants. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-1799][scala] Fix handling of generic ar...

2015-04-20 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/582#issuecomment-94483743 I fixed @StephanEwen's complaint. It was incorrect but the type class of TypeInformation does not seem to be used in any places where it matters. --- If your project

[GitHub] flink pull request: [FLINK-1927] [py] Operator distribution rework

2015-04-29 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/638#issuecomment-97412959 But doesn't this mean that the lambdas now must be stateless, i.e. if a user refers to some variable outside the lambda this will not be serialised with the closure

[GitHub] flink pull request: [FLINK-1615] [java api] SimpleTweetInputFormat

2015-04-29 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/621#issuecomment-97401561 Our travis builds are a bit unstable right now. I'm running some last tests and then I'll merge this. Thanks for staying with this and working on my requests! :smile

[GitHub] flink pull request: [FLINK-1924] Minor Refactoring

2015-04-27 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/616#issuecomment-96573887 +1, can you merge it @mxm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1615] [java api] SimpleTweetInputFormat

2015-04-27 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/621#issuecomment-96565454 The tests are failing because you use spaces in you code for indentation. Could you please change all indentation to tabs to satisfy the style checker? --- If your

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-04-27 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/593#issuecomment-96532907 Yes, this would make things a lot cleaner. @twalthr what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-924] Add automatic dependency retrieval...

2015-04-28 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/35#issuecomment-96960370 Thanks for working with this on me. Very nice contribution. :smile: --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [streaming] New Source and state checkpointing...

2015-05-04 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/643#issuecomment-98690522 Also, the key would be a property of a DataStream, and other operations could also use this. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-1615] [java api] SimpleTweetInputFormat

2015-04-28 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/621#issuecomment-96953776 Unfortunately, Travis cuts of the log if it is too long, like here: https://travis-ci.org/aljoscha/flink/jobs/60177866 (that's from your pull request). You have to click

  1   2   3   4   5   6   7   8   9   10   >