Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1810#issuecomment-198181543
Thanks for contribution! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1816#issuecomment-198181490
Thanks for contribution! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1816#issuecomment-198178456
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1810#issuecomment-198174591
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1812#issuecomment-198181529
Thanks for contribution! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1786#issuecomment-197206450
+1 for your suggestion @s1ck.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1786#issuecomment-196093870
Hi @s1ck, thanks for opening pull request! I would like to change this link
to "Contributing Code" (http://flink.apache.org/contribute-code.html) page
r
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-193580086
Hi @danielblazevski, thanks for update and sorry for late reply. I tried to
test your implementation and have found few things to do before merging
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1682#issuecomment-187148301
Tested on vanila Hadoop 2.7.2:
- Flink cluster is started successfully.
- WordCount example is working.
---
If your project is set up for it, you can
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1649#discussion_r53151157
--- Diff:
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java
---
@@ -432,11 +436,11 @@ private void
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1585#issuecomment-181833677
Thanks for review @fhueske. I have addressed your comments. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1186#issuecomment-181739512
Hi @chobeat, thanks for leaving your comments.
About compatibility with other system (such as R or MLlib), I meant that we
cannot achieve compatibility
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1186#issuecomment-181509602
Hi @chobeat, thanks for pinging this issue. I forgot sending a discuss
email to mailing thread. I think we have to discuss about followings:
* What is main
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1585#discussion_r52098334
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/SortPartitionOperator.java
---
@@ -79,16 +112,33 @@ public SortPartitionOperator
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/1585
[FLINK-3234] [dataSet] Add KeySelector support to sortPartition operation.
This PR contains following changes:
* Add `sortPartition` methods which receive a `KeySelector` instance
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1585#issuecomment-180224231
@fhueske I addressed your comments.
To reduce modifying original code, I added some variables for key selector
only. But this make the source code quite
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1585#issuecomment-179843708
Thanks for review @fhueske! I'll address your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1500#issuecomment-179160309
@tillrohrmann Thanks for review. I'll address the comment in today.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1500#issuecomment-179182603
I've addressed @tillrohrmann comment. After running CI, we can merge this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1500#issuecomment-179643330
Failing test seems not related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1500#issuecomment-175588417
@tillrohrmann Thanks for review! I have addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1500#issuecomment-175600967
About the type of number of containers for TaskManagers, it should be
optional because the user can the Scala Shell without specifying the number
when the user wants
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-174369547
Hi @danielblazevski, you don't need to open a new PR and merge master
branch. Instead, you update `master` branch and rebase your local `FLINK-1745`
branch
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r50647700
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache Software
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-173869263
@tillrohrmann Thanks! It is good news.
@rawkintrevo Thanks for contribution :+1:
---
If your project is set up for it, you can reply to this email and have your
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50395017
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
---
@@ -291,31 +297,54 @@ public
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50395062
--- Diff:
flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala
---
@@ -104,36 +105,52 @@ object
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50395674
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
---
@@ -291,31 +297,54 @@ public
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50394492
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala
---
@@ -107,6 +107,11 @@ class
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50394812
--- Diff:
flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala
---
@@ -104,36 +105,52 @@ object
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50394801
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
---
@@ -291,31 +297,54 @@ public
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50501474
--- Diff: docs/libs/ml/optimization.md ---
@@ -276,6 +369,8 @@ val sgd = GradientDescentL1()
.setRegularizationConstant(0.2)
.setIterations
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50498429
--- Diff:
flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala
---
@@ -26,53 +27,84 @@ import
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-173806495
@rawkintrevo Thanks for update! I still prefer using a learning method
instance as parameter to remove method-specific parameter such as `decay
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1527#discussion_r50360393
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/CoGroupJoinITCase.java
---
@@ -234,6 +234,109
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/899#issuecomment-171581363
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/1504
[FLINK-2984] [ml] Extend libSVM file format support
Currently, FlinkML libSVM file reader cannot read some datasets (such as
splice-site) in libSVM official site. This PR extends libSVM file
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-171852976
@danielblazevski, I think we can use `crossWithTiny` and `crossWithHuge`
method to reduce shuffle cost. Best approach is that counting elements in both
datasets
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1504#issuecomment-171835207
Thanks for review @tillrohrmann! I'll merge this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1510#issuecomment-171833764
Looks good to merge, :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/899#issuecomment-171141103
Looks good to merge. If there is no other opinions in 2-3 days, I'll merge
this to master.
---
If your project is set up for it, you can reply to this email and have
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/1500
[FLINK-2935] [scala-shell] Allow Scala shell to connect Flink cluster on
YARN
Please check a [JIRA
issue](https://issues.apache.org/jira/browse/FLINK-2935) related to this PR.
This PR
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-170875879
Hi @danielblazevski, I'm sorry for late reply. If you turn off IntelliJ
IDEA align option (Turn off Preferences -> Editor -> Code Style -> Scala -&g
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/730#issuecomment-170877495
Is there any updates? The tests are failing because of style checking of
test data.
---
If your project is set up for it, you can reply to this email and have your
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1501#issuecomment-171119408
The failing CI seems unrelated. Looks good to merge. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-170451422
I still would like to use enumeration because if we use string parameters,
the user cannot check that the input parameter is valid. But if you have some
problems
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-170200015
Hi @rawkintrevo, you can convert scala Enum to Int like following:
```scala
object Parameter extends Enumeration {
type Parameter = Value
val
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-169861378
Hi @rawkintrevo, I'm sorry about waiting you.
I have looked your pull request. Almost of changes are good but I have some
few comments.
First
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1486#issuecomment-169283768
Hi @ajaybhat, thanks for opening pull request.
I read your pull request quickly and have a comment.
Currently, Flink has a lot of tests that create
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-167079605
Hi @rawkintrevo, I think you should rebase your branch instead of merging
master branch. Could you update your branch? Note that you should force push
(`git push -f
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1032#issuecomment-162821875
How about base class with declaration of the both statistics values and
child class with the implementation of that values?
```scala
abstract class
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-162804155
@nikste, Yes that is what I mean.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-162529724
I also prefer multiple environments during startup of the shell. I'm adding
YARN session support of the shell. If there is another startup mode,
implementation could
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1032#issuecomment-162506577
I would like to shepherd this pull request. Sorry for long delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1032#issuecomment-162518625
Hi @sachingoel0101, I just reviewed quickly. I have some questions and
comments for this pull request.
First, why `FieldStats` covers statistics value
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1032#issuecomment-162519456
Additionally, if you will modify your pull request, please do not rebase
the commit because I'm tracking your branch
(`sachingoel0101/flink.git/statistics`). We can
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1424#issuecomment-160944538
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1424#issuecomment-160877990
Looks good to merge. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46092390
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46092387
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46092399
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46092526
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46092532
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46092558
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093222
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093216
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093209
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093220
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093234
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093242
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093248
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093243
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093240
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093251
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093280
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093270
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093279
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093265
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093267
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093319
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093306
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093466
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46092369
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala ---
@@ -0,0 +1,316 @@
+/*
+ * Licensed to the Apache Software
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46092377
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala ---
@@ -0,0 +1,316 @@
+/*
+ * Licensed to the Apache Software
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46092375
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala ---
@@ -0,0 +1,316 @@
+/*
+ * Licensed to the Apache Software
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093688
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala ---
@@ -0,0 +1,316 @@
+/*
+ * Licensed to the Apache Software
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093714
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala ---
@@ -0,0 +1,316 @@
+/*
+ * Licensed to the Apache Software
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093728
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala ---
@@ -0,0 +1,316 @@
+/*
+ * Licensed to the Apache Software
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093717
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala ---
@@ -0,0 +1,316 @@
+/*
+ * Licensed to the Apache Software
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093744
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093740
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1220#discussion_r46093852
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-160427679
Hi @danielblazevski, I reviewed your updated pull request. There are only
few problems to merge. Maybe after addressing them, we can merge this to master
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r45942541
--- Diff: flink-staging/flink-ml/pom.xml ---
@@ -80,7 +80,7 @@
- org.scala
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-159217613
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-159220295
@gallenvara Because I forgot add close message in the commit, the PR should
be closed manually. Could you close this PR? This change is merged. Sorry
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-158914256
@gallenvara Thanks for update! Looks good to merge for me. If there is no
objection until tomorrow, I'll merge this.
---
If your project is set up for it, you can
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1337#issuecomment-158914974
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1337#issuecomment-159005519
I think github bot is not working for this PR. I close this manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chiwanpark closed the pull request at:
https://github.com/apache/flink/pull/1337
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
101 - 200 of 583 matches
Mail list logo
