Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106468487
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/TestFilterableTableSource.scala
---
@@ -0,0 +1,142
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106445598
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala
---
@@ -36,36
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106446820
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FilterableTableSource.scala
---
@@ -20,47 +20,40 @@ package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106460094
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/util/RexProgramTestBase.scala
---
@@ -16,106 +16,96 @@
* limitations
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106452031
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/TableSourceTest.scala
---
@@ -0,0 +1,382 @@
+/*
+ * Licensed to the
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106447875
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/TestFilterableTableSource.scala
---
@@ -18,20 +18,20
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106488388
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverWindowFunction.scala
---
@@ -0,0 +1,97
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106513895
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -17,34 +17,41
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106532760
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/ProcTimeRowBoundedAggregationTest.scala
---
@@ -0,0 +1,311
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106528174
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverAllWindowFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106517261
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -89,6 +116,58 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106526547
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -89,6 +116,58 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106516596
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -17,35 +17,62
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106520755
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -89,6 +116,58 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106538072
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -106,9 +113,14
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106525346
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -89,6 +116,58 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106517060
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -89,6 +116,58 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106523715
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -89,6 +116,58 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106534604
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/ProcTimeRowBoundedAggregationTest.scala
---
@@ -0,0 +1,311
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106517628
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -130,32 +142,77
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2460
Thanks for the reminder @shijinkui!
I'll put this one on my list for next week.
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106519205
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -130,32 +142,76
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106519460
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -130,32 +142,77
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3547
One more thing. The PR includes a merge commit which makes squashing the
commits and merging the PR a lot more difficult (see also the [contribution
guidelines](http://flink.apache.org/contribute
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106603629
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala
---
@@ -36,36
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3520
Can you squash the commits of the PR into two commits before merging? One
for @tonycox and one for your changes? Thanks!
---
If your project is set up for it, you can reply to this email and have
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3520
yes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106609749
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala
---
@@ -36,36
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3166
Hi @tonycox, the follow up PR #3520 to this one was merged including the
changes of this PR.
Can you close this PR?
Thanks, Fabian
---
If your project is set up for it, you can reply
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106625475
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -317,4 +320,119 @@ class SqlITCase
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106624582
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106617971
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -112,7 +113,14
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106622479
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106624514
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106623704
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106626434
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -317,4 +320,119 @@ class SqlITCase
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106623012
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106623601
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106623827
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106622821
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106621564
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -91,6 +91,35 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106620612
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -159,6 +167,46
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106625858
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -317,4 +320,119 @@ class SqlITCase
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106627282
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -106,9 +113,14
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106627390
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -17,34 +17,41
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106631183
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -17,23 +17,54
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106547467
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106630898
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/DataStreamProcTimeBoundAggIntegrationITCase.scala
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106546529
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -191,3 +287,31
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106630541
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -785,7 +785,7 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106629913
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,66
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106547382
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106546112
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106545668
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106544854
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -106,6 +137,10
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106630745
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106546899
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -191,3 +287,31
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106630792
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106548270
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/DataStreamProcTimeBoundAggIntegrationTest.scala
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106545012
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106629136
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,66
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106949663
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106950142
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106950646
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3572#discussion_r106967721
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/calcite/rules/FlinkAggregateExpandDistinctAggregatesRule.java
---
@@ -114,15
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106997447
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -239,4 +239,61 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106966705
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateAggOverFunction.scala
---
@@ -0,0 +1,102
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106993805
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -661,6 +679,36 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106965219
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateAggOverFunction.scala
---
@@ -0,0 +1,102
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106955390
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -106,6 +112,10
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106997276
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -239,4 +239,61 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106963715
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -150,12 +160,71
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106965395
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateAggOverFunction.scala
---
@@ -0,0 +1,102
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106996212
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -317,4 +317,465 @@ class SqlITCase
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106962344
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/IncrementalAggregateOverWindowFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106957084
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -150,12 +160,71
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106964910
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateAggOverFunction.scala
---
@@ -0,0 +1,102
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106958710
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -150,12 +160,71
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107023400
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107020630
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +152,60
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107017682
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +152,60
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107024511
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -317,4 +317,92 @@ class SqlITCase
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107017957
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +152,60
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107023802
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107022806
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107022459
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107019094
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +152,60
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107020368
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +152,60
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107022916
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107020183
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +152,60
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107018828
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +152,60
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107019651
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +152,60
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107024971
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -317,4 +317,92 @@ class SqlITCase
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107023458
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107026831
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -785,7 +785,7 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107017278
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -106,6 +135,10
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107025846
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -239,4 +252,179 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107018019
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +152,60
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107023706
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r107023660
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
201 - 300 of 6299 matches
Mail list logo
