[GitHub] flink issue #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6.x

2018-07-25 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6391 @twalthr I've addressed most of your comments. Thanks a lot for the detailed review. However, now it seems like the Elasticsearch 6.x IT cases are failing, due to ceased support

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r205037835 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/test/resources/log4j-test.properties --- @@ -0,0 +1,27

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r205037795 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/connectors/elasticsearch6/examples

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r205031956 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/connectors/elasticsearch

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r205029480 --- Diff: flink-end-to-end-tests/run-nightly-tests.sh --- @@ -96,6 +96,7 @@ run_test "Local recovery and sticky scheduling end-to-end

[GitHub] flink pull request #6413: [FLINK-8993] [tests] Let general purpose DataStrea...

2018-07-25 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/6413 [FLINK-8993] [tests] Let general purpose DataStream job uses KryoSerializer via type extraction ## What is the purpose of the change The general purpose DataStream job previously only

[GitHub] flink pull request #6408: [FLINK-9897][Kinesis Connector] Make adaptive read...

2018-07-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6408#discussion_r204999405 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@ -233,26

[GitHub] flink pull request #6408: [FLINK-9897][Kinesis Connector] Make adaptive read...

2018-07-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6408#discussion_r204996330 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@ -233,26

[GitHub] flink pull request #6408: [FLINK-9897][Kinesis Connector] Make adaptive read...

2018-07-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6408#discussion_r204998677 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@ -233,26

[GitHub] flink issue #6392: [FLINK-9694][table] Fix NPE in CRowSerializerConfigSnapsh...

2018-07-25 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6392 LGTM, +1 ---

[GitHub] flink pull request #6392: [FLINK-9694][table] Fix NPE in CRowSerializerConfi...

2018-07-24 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6392#discussion_r204684670 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java --- @@ -46,8 +46,6 @@ public

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-23 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/6391 [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6.x PR ## What is the purpose of the change This PR adds the Elasticsearch 6.x PR, as well as an end-to-end test for it. ## Brief

[GitHub] flink pull request #6351: [FLINK-9862] [test] Extend general puropose DataSt...

2018-07-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6351#discussion_r204342877 --- Diff: flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/SequenceGeneratorSource.java --- @@ -197,6

[GitHub] flink issue #6043: [FLINK-7386] evolve RequestIndexer API to make it working...

2018-07-19 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6043 @cjolif no problem, thanks for the notice. I'll try to incorporate the changes you mentioned above to the previous work you've already done. Thanks a lot! ---

[GitHub] flink issue #6043: [FLINK-7386] evolve RequestIndexer API to make it working...

2018-07-19 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6043 @cjolif Ideally we have ES 6.x connector merged by the beginning of next week. Let me know if this is possible for you. I'll proceed to merge this PR first. ---

[GitHub] flink issue #6043: [FLINK-7386] evolve RequestIndexer API to make it working...

2018-07-19 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6043 @cjolif do you think you would be able to quickly open a PR for the REST 6.x connector that includes the new changes you mentioned, based on this one? ---

[GitHub] flink issue #6043: [FLINK-7386] evolve RequestIndexer API to make it working...

2018-07-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6043 I took another look at the PR, and also talked with @tillrohrmann about merging this for 1.6. I think this LGTM, and with these changes we will at least have an ES 5.x connector that is 5.3

[GitHub] flink pull request #6351: [FLINK-9862] [test] Extend general puropose DataSt...

2018-07-17 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/6351 [FLINK-9862] [test] Extend general puropose DataStream test to have a tumbling window ## What is the purpose of the change This allows our end-to-end tests to have coverage

[GitHub] flink pull request #6273: [FLINK-9377] [core] Implement restore serializer f...

2018-07-06 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/6273 [FLINK-9377] [core] Implement restore serializer factory method for simple composite serializers ## What is the purpose of the change This PR is built on top of #6235. It is a WIP PR

[GitHub] flink issue #6206: [FLINK-9654] [core] Changed the check for anonymous class...

2018-07-02 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6206 Thanks for looking into this @zsolt-donca. The changes looks good to me, but as @yanghua mentioned, a test to cover the previous bug would be nice here and allow the reviewer to understand

[GitHub] flink pull request #6221: [FLINK-9686] [kinesis] Enable Kinesis authenticati...

2018-07-02 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6221#discussion_r199420811 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/AWSConfigConstants.java

[GitHub] flink issue #6209: [FLINK-9655][tests] Add missing parallelism parameters

2018-07-02 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6209 Thanks @zentol for fixing this, merging .. ---

[GitHub] flink pull request #6235: [FLINK-9377] [core] Remove serializers from checkp...

2018-07-02 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/6235 [FLINK-9377] [core] Remove serializers from checkpointed state meta infos ## What is the purpose of the change This PR is the first step towards a smoother state evolution experience

[GitHub] flink issue #6177: Backport of Kinesis connector changes from 1.5 to release...

2018-06-22 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6177 @tweise I've manually merged this, but forgot to add the "This closes #" message. Could you close this PR manually? Thanks! ---

[GitHub] flink issue #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer Backpr...

2018-06-22 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6021 @fmthoma I've merged this manually. Thanks for the contribution. Could you close this PR? ---

[GitHub] flink issue #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer Backpr...

2018-06-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6021 Thanks @fmthoma, will proceed to merge this .. ---

[GitHub] flink issue #6197: [FLINK-9638][E2E Tests] Add helper script to run single t...

2018-06-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6197 Tried this locally, and it works. +1, will merge this .. ---

[GitHub] flink issue #6172: [FLINK-9594][E2E tests] Improve docs for new test runner

2018-06-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6172 Thanks @florianschmidt1994, merging this .. ---

[GitHub] flink issue #6193: [hotfix] [docs] Fix typo in index.md

2018-06-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6193 LGTM, thanks for catching this @MichealShin, will merge this. ---

[GitHub] flink issue #6182: [FLINK-8795] Fixed local scala shell for Flip6

2018-06-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6182 Merging this .. ---

[GitHub] flink issue #6177: Backport of Kinesis connector changes from 1.5 to release...

2018-06-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6177 @tweise ok, I don't really have a strong opinion on not including the other changes. Changes LGTM then, will merge this. ---

[GitHub] flink pull request #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer...

2018-06-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6021#discussion_r197071117 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java --- @@ -326,6

[GitHub] flink pull request #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer...

2018-06-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6021#discussion_r197067733 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java --- @@ -326,6

[GitHub] flink pull request #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer...

2018-06-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6021#discussion_r197065346 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java --- @@ -55,6

[GitHub] flink pull request #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer...

2018-06-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6021#discussion_r197067136 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java --- @@ -326,6

[GitHub] flink pull request #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer...

2018-06-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6021#discussion_r197065961 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java --- @@ -144,6

[GitHub] flink pull request #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer...

2018-06-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6021#discussion_r197070282 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducerTest.java --- @@ -267,6

[GitHub] flink pull request #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer...

2018-06-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6021#discussion_r197068370 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/TimeoutLatch.java --- @@ -0,0 +1,41

[GitHub] flink pull request #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer...

2018-06-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6021#discussion_r197069244 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/TimeoutLatch.java --- @@ -0,0 +1,41

[GitHub] flink pull request #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer...

2018-06-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6021#discussion_r197064931 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java --- @@ -326,6

[GitHub] flink pull request #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer...

2018-06-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6021#discussion_r197063764 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java --- @@ -326,6

[GitHub] flink issue #6182: [FLINK-8795] Fixed local scala shell for Flip6

2018-06-20 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6182 Thanks for the fix @dawidwys! The changes LGTM on my side, +1. ---

[GitHub] flink pull request #6172: [FLINK-9594][E2E tests] Improve docs for new test ...

2018-06-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6172#discussion_r195992732 --- Diff: flink-end-to-end-tests/README.md --- @@ -33,6 +33,53 @@ $ FLINK_DIR= flink-end-to-end-tests/test-scripts/test_batch_wordcount

[GitHub] flink pull request #6172: [FLINK-9594][E2E tests] Improve docs for new test ...

2018-06-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6172#discussion_r195992679 --- Diff: flink-end-to-end-tests/README.md --- @@ -33,6 +33,53 @@ $ FLINK_DIR= flink-end-to-end-tests/test-scripts/test_batch_wordcount

[GitHub] flink pull request #6172: [FLINK-9594][E2E tests] Improve docs for new test ...

2018-06-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6172#discussion_r195992920 --- Diff: flink-end-to-end-tests/README.md --- @@ -33,6 +33,53 @@ $ FLINK_DIR= flink-end-to-end-tests/test-scripts/test_batch_wordcount

[GitHub] flink pull request #6172: [FLINK-9594][E2E tests] Improve docs for new test ...

2018-06-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6172#discussion_r195991753 --- Diff: flink-end-to-end-tests/README.md --- @@ -33,6 +33,53 @@ $ FLINK_DIR= flink-end-to-end-tests/test-scripts/test_batch_wordcount

[GitHub] flink issue #6177: Backport of Kinesis connector changes from 1.5 to release...

2018-06-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6177 I'm not sure that we want to backport the shard-mapping hash function. IMO, that is a new feature and shouldn't go into a bugfix release. What do you think @tweise? ---

[GitHub] flink issue #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass" messag...

2018-06-14 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6053 ``` == Running 'Streaming Python Wordcount end-to-end test

[GitHub] flink pull request #6151: [FLINK-9569] [avro] Fix confusing construction of ...

2018-06-12 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/6151 [FLINK-9569] [avro] Fix confusing construction of GenericRecord AvroSerializers ## What is the purpose of the change The `AvroSerializer` previously had a `AvroSerializer(Class type

[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector

2018-06-11 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5845 Sorry for delays on my reply here. I'll take a look at this week, over the next days. If there is going to be a new PR, please also let me know. Thanks! ---

[GitHub] flink issue #6043: [FLINK-7386] evolve RequestIndexer API to make it working...

2018-05-30 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6043 @cjolif do you think it would be possible that with a clean cut using a REST implementation, we no longer need to have separate modules anymore for ES 6.x, 7.x, 8.x or so on? i.e., it would

[GitHub] flink issue #6038: [FLINK-9394] [e2e] Test rescaling when resuming from exte...

2018-05-28 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6038 @StefanRRichter thanks for the review, will merge this. ---

[GitHub] flink issue #6072: [hotfix][doc] Clarify kinesis docs and fix debugging clas...

2018-05-24 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6072 Will only merge the Kinesis doc fix, as the classloading docs already has a substantial fix meanwhile in master. ---

[GitHub] flink pull request #6074: [FLINK-9429] [test] Fix does not properly terminat...

2018-05-24 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6074#discussion_r190786548 --- Diff: flink-end-to-end-tests/test-scripts/elasticsearch-common.sh --- @@ -61,8 +61,9 @@ function verify_result { rm $TEST_DATA_DIR/output

[GitHub] flink issue #6043: [FLINK-7386] evolve RequestIndexer API to make it working...

2018-05-24 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6043 One more thing to clarify: When planning to switch to REST, are we speaking of an implementation that works directly against Elasticsearch's REST API? Or are we thinking of using

[GitHub] flink issue #6043: [FLINK-7386] evolve RequestIndexer API to make it working...

2018-05-24 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6043 The main reason why the discussion leaned towards the current proposed change by this PR, was that only Elasticsearch 5.6+ supports REST. Only working towards a clean-cut module that uses

[GitHub] flink issue #6072: [hotfix][doc] Clarify kinesis docs and fix debugging clas...

2018-05-24 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6072 +1, thanks for the fixes @pnowojski. Will merge this .. ---

[GitHub] flink issue #6061: [FLINK-9425] Make release scripts compliant with ASF rele...

2018-05-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6061 +1, thanks for the compliance updates. LGTM. ---

[GitHub] flink issue #6058: [FLINK-9415] Remove reference to StreamingMultipleProgram...

2018-05-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6058 +1, LGTM Merging this .. ---

[GitHub] flink issue #6040: [FLINK-9349][Kafka Connector] KafkaConnector Exception wh...

2018-05-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6040 Using `CheckedThread` is more preferable, as it simplifies some of the test code. But yes, the utility was introduced at a later point in time in Flink, so some parts of the test code might

[GitHub] flink issue #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer Backpr...

2018-05-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6021 @fmthoma yes, that would be great. ---

[GitHub] flink pull request #5991: [FLINK-9303] [kafka] Adding support for unassign d...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5991#discussion_r190153528 --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java

[GitHub] flink pull request #5991: [FLINK-9303] [kafka] Adding support for unassign d...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5991#discussion_r190150419 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -235,7

[GitHub] flink pull request #5991: [FLINK-9303] [kafka] Adding support for unassign d...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5991#discussion_r190152570 --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java

[GitHub] flink pull request #5863: [FLINK-8985][e2etest] initial support for End-to-e...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5863#discussion_r190146869 --- Diff: flink-end-to-end-tests/test-scripts/test_cli_api.sh --- @@ -0,0 +1,196 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #5863: [FLINK-8985][e2etest] initial support for End-to-e...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5863#discussion_r190145819 --- Diff: flink-end-to-end-tests/test-scripts/test_cli_api.sh --- @@ -0,0 +1,155 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #6023: [FLINK-9383][runtime] Test directories in Distribu...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6023#discussion_r190144815 --- Diff: flink-end-to-end-tests/run-pre-commit-tests.sh --- @@ -93,6 +93,14 @@ if [ $EXIT_CODE == 0 ]; then EXIT_CODE=$? fi

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r190140597 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java --- @@ -26,20

[GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in...

2018-05-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r190140724 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java --- @@ -26,20

[GitHub] flink issue #6021: [FLINK-9374] [kinesis] Enable FlinkKinesisProducer Backpr...

2018-05-23 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6021 @fmthoma I think this might benefit from an actual documentation, not only Javadocs. ---

[GitHub] flink pull request #6043: [FLINK-7386] evolve RequestIndexer API to make it ...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6043#discussion_r190127059 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/RequestIndexer.java

[GitHub] flink pull request #6043: [FLINK-7386] evolve RequestIndexer API to make it ...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6043#discussion_r190127406 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/RequestIndexer.java

[GitHub] flink pull request #6043: [FLINK-7386] evolve RequestIndexer API to make it ...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6043#discussion_r190126862 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/BulkProcessorIndexer.java

[GitHub] flink pull request #6043: [FLINK-7386] evolve RequestIndexer API to make it ...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6043#discussion_r190126707 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/RequestIndexer.java

[GitHub] flink pull request #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass"...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6053#discussion_r190126277 --- Diff: flink-end-to-end-tests/run-nightly-tests.sh --- @@ -30,168 +30,50 @@ if [ -z "$FLINK_DIR" ] ; then exit 1 fi

[GitHub] flink pull request #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass"...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6053#discussion_r190126071 --- Diff: flink-end-to-end-tests/test-scripts/test_local_recovery_and_scheduling.sh --- @@ -53,8 +53,6 @@ function cleanup_after_test

[GitHub] flink pull request #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass"...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6053#discussion_r190124962 --- Diff: flink-end-to-end-tests/run-pre-commit-tests.sh --- @@ -31,56 +31,23 @@ if [ -z "$FLINK_DIR" ] ; then fi source &quo

[GitHub] flink pull request #6053: [FLINK-9257][E2E Tests] Fix wrong "All tests pass"...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6053#discussion_r190125404 --- Diff: flink-end-to-end-tests/test-scripts/test-runner-common.sh --- @@ -0,0 +1,76 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #6058: [FLINK-9415] Remove reference to StreamingMultiple...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6058#discussion_r190123863 --- Diff: docs/dev/stream/testing.md --- @@ -181,7 +181,7 @@ public class ExampleIntegrationTest extends StreamingMultipleProgramsTestBase

[GitHub] flink pull request #6058: [FLINK-9415] Remove reference to StreamingMultiple...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6058#discussion_r190123818 --- Diff: docs/dev/stream/testing.md --- @@ -181,7 +181,7 @@ public class ExampleIntegrationTest extends StreamingMultipleProgramsTestBase

[GitHub] flink pull request #6040: [FLINK-9349][Kafka Connector] KafkaConnector Excep...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6040#discussion_r190120134 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcherTest.java

[GitHub] flink pull request #6040: [FLINK-9349][Kafka Connector] KafkaConnector Excep...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6040#discussion_r190111529 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcherTest.java

[GitHub] flink pull request #6040: [FLINK-9349][Kafka Connector] KafkaConnector Excep...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6040#discussion_r190110928 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcherTest.java

[GitHub] flink pull request #6040: [FLINK-9349][Kafka Connector] KafkaConnector Excep...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6040#discussion_r190112933 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java

[GitHub] flink pull request #6040: [FLINK-9349][Kafka Connector] KafkaConnector Excep...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6040#discussion_r190111239 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcherTest.java

[GitHub] flink pull request #6040: [FLINK-9349][Kafka Connector] KafkaConnector Excep...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6040#discussion_r190120209 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcherTest.java

[GitHub] flink pull request #6040: [FLINK-9349][Kafka Connector] KafkaConnector Excep...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6040#discussion_r190111078 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcherTest.java

[GitHub] flink pull request #6040: [FLINK-9349][Kafka Connector] KafkaConnector Excep...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6040#discussion_r190114844 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcherTest.java

[GitHub] flink issue #6045: [FLINK-9402] [kinesis] Kinesis consumer configuration req...

2018-05-22 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6045 Thanks @tweise. Have only one comment, otherwise this looks good to merge. ---

[GitHub] flink pull request #6045: [FLINK-9402] [kinesis] Kinesis consumer configurat...

2018-05-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6045#discussion_r189815405 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java --- @@ -244,7

[GitHub] flink issue #5977: [FLINK-9295][kafka] Fix transactional.id collisions for F...

2018-05-22 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5977 Thanks for the update @pnowojski. Changes LGTM, +1. Merging this .. ---

[GitHub] flink issue #5761: [FLINK-8989] [e2eTests] Elasticsearch1&2&5 end to end tes...

2018-05-22 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5761 +1, LGTM, merging ... ---

[GitHub] flink issue #5849: [FLINK-8986][e2e-test][WIP] Flink end to end test REST AP...

2018-05-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5849 @walterddr yes, you can do that. In the description, just leave some notice that the PR is based on another, and which of the commits are relevant. ---

[GitHub] flink issue #5958: [FLINK-8500] Get the timestamp of the Kafka message from ...

2018-05-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5958 @FredTing we had some offline discussion on how to proceed with this. @aljoscha, @twalthr, or @StephanEwen can probably comment more here if I missed anything. The conflict that Stephan

[GitHub] flink issue #5849: [FLINK-8986][e2e-test][WIP] Flink end to end test REST AP...

2018-05-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5849 Hi @walterddr, what is the status of this PR? Would be nice if we can move forward with this PR (and also the CLI e2e test PR that also you opened.) ---

[GitHub] flink pull request #5863: [FLINK-8985][e2etest] initial support for End-to-e...

2018-05-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5863#discussion_r189185140 --- Diff: flink-end-to-end-tests/test-scripts/test_cli_api.sh --- @@ -0,0 +1,155 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #5863: [FLINK-8985][e2etest] initial support for End-to-e...

2018-05-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5863#discussion_r189185253 --- Diff: flink-end-to-end-tests/test-scripts/test_cli_api.sh --- @@ -0,0 +1,155 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #5863: [FLINK-8985][e2etest] initial support for End-to-e...

2018-05-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5863#discussion_r189185689 --- Diff: flink-end-to-end-tests/test-scripts/test_cli_api.sh --- @@ -0,0 +1,155 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #5863: [FLINK-8985][e2etest] initial support for End-to-e...

2018-05-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5863#discussion_r189185232 --- Diff: flink-end-to-end-tests/test-scripts/test_cli_api.sh --- @@ -0,0 +1,155 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #5863: [FLINK-8985][e2etest] initial support for End-to-e...

2018-05-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5863#discussion_r189185047 --- Diff: flink-end-to-end-tests/test-scripts/test_cli_api.sh --- @@ -0,0 +1,155 @@ +#!/usr/bin/env bash

  1   2   3   4   5   6   7   8   9   10   >