[GitHub] [flink] xiangyuf opened a new pull request, #23328: [FLINK-32755][docs] Add doc for OLAP quickstart

xiangyuf opened a new pull request, #23328: URL: https://github.com/apache/flink/pull/23328 ## What is the purpose of the change Add quick-start docs for Flink OLAP ## Brief change log - added olap_quickstart.md in docs ## Verifying this change

[GitHub] [flink] YesOrNo828 commented on pull request #23292: [FLINK-32817] Harnessing Jackson for Secure Serialization of YarnLocalResourceDescriptor

YesOrNo828 commented on PR #23292: URL: https://github.com/apache/flink/pull/23292#issuecomment-1698975618 @xintongsong The CI is a success now. Do you have time to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] XComp commented on a diff in pull request #23327: [FLINK-32994][runtime] Adds human-readable toString implementations to the LeaderElectionDriver classes

XComp commented on code in PR #23327: URL: https://github.com/apache/flink/pull/23327#discussion_r1310207449 ## flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java: ## @@ -610,12 +611,41 @@ FileSystemStateStorageHelper createFileSystemStateStorage(

[GitHub] [flink] gaborgsomogyi opened a new pull request, #23329: [FLINK-32989][python] Fix version parsing issue

gaborgsomogyi opened a new pull request, #23329: URL: https://github.com/apache/flink/pull/23329 ## What is the purpose of the change https://github.com/apache/flink/pull/23306 introduced a blocker issue because the underneath directories to detect Flink home are not always exist.

[GitHub] [flink] gaborgsomogyi commented on pull request #23329: [FLINK-32989][python] Fix version parsing issue

gaborgsomogyi commented on PR #23329: URL: https://github.com/apache/flink/pull/23329#issuecomment-1698967507 Issue fixed: ``` Aug 30 10:36:02 ./setup.py:20:1: F401 'glob' imported but unused ``` -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] wangyang0918 commented on a diff in pull request #23327: [FLINK-32994][runtime] Adds human-readable toString implementations to the LeaderElectionDriver classes

wangyang0918 commented on code in PR #23327: URL: https://github.com/apache/flink/pull/23327#discussion_r1310156765 ## flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java: ## @@ -610,12 +611,41 @@ FileSystemStateStorageHelper

[GitHub] [flink] flinkbot commented on pull request #23331: [FLINK-32996][Tests] Fix the CheckpointAfterAllTasksFinishedITCase.testFailoverAfterSomeTasksFinished fails

flinkbot commented on PR #23331: URL: https://github.com/apache/flink/pull/23331#issuecomment-1699062306 ## CI report: * fc529ecf4f254ad6519abf359ea9b5dca062b182 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] wanglijie95 closed pull request #23282: [FlINK-32865][table-planner] Add ExecutionOrderEnforcer to exec plan and put it into BatchExecMultipleInput

wanglijie95 closed pull request #23282: [FlINK-32865][table-planner] Add ExecutionOrderEnforcer to exec plan and put it into BatchExecMultipleInput URL: https://github.com/apache/flink/pull/23282 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] lindong28 commented on pull request #23268: [FLINK-32945][runtime] Fix NPE when task reached end-of-data but checkpoint failed

lindong28 commented on PR #23268: URL: https://github.com/apache/flink/pull/23268#issuecomment-169887 Thanks for the update. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] lindong28 merged pull request #23268: [FLINK-32945][runtime] Fix NPE when task reached end-of-data but checkpoint failed

lindong28 merged PR #23268: URL: https://github.com/apache/flink/pull/23268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] jiangxin369 opened a new pull request, #23332: [FLINK-32996][Tests] Fix the CheckpointAfterAllTasksFinishedITCase.testFailoverAfterSomeTasksFinished fails

jiangxin369 opened a new pull request, #23332: URL: https://github.com/apache/flink/pull/23332 ## What is the purpose of the change Fix the CheckpointAfterAllTasksFinishedITCase.testFailoverAfterSomeTasksFinished fails ## Brief change log - Make the test

[GitHub] [flink] XComp commented on pull request #11752: [FLINK-14713][rest]Show All Attempts For Vertex SubTask In Rest Api

XComp commented on PR #11752: URL: https://github.com/apache/flink/pull/11752#issuecomment-1699141573 I'm closing this one. It seems to be out-dated and the corresponding issue is labeled as `Not a Priority`. Feel free to reinitiate the discussion if this work shall be picked up again.

[GitHub] [flink] XComp closed pull request #11752: [FLINK-14713][rest]Show All Attempts For Vertex SubTask In Rest Api

XComp closed pull request #11752: [FLINK-14713][rest]Show All Attempts For Vertex SubTask In Rest Api URL: https://github.com/apache/flink/pull/11752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] lincoln-lil commented on a diff in pull request #23316: [FLINK-18445][table] Add pre-filter optimization for lookup join

lincoln-lil commented on code in PR #23316: URL: https://github.com/apache/flink/pull/23316#discussion_r1310026882 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java: ## @@ -175,9 +177,14 @@ public

[GitHub] [flink] flinkbot commented on pull request #23332: [FLINK-32996][Tests] Fix the CheckpointAfterAllTasksFinishedITCase.testFailoverAfterSomeTasksFinished fails

flinkbot commented on PR #23332: URL: https://github.com/apache/flink/pull/23332#issuecomment-1699073820 ## CI report: * 8a269ba9ac373c162690da15950813e469a7df2a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] libenchao commented on pull request #23323: [FLINK-32738][formats] PROTOBUF format supports projection push down

libenchao commented on PR #23323: URL: https://github.com/apache/flink/pull/23323#issuecomment-1699103904 > @libenchao Hi Master, This CI seems failed with Node.js related issue. Would you please help review the Pb projection logic first? I have made it pass all the proto2row test. Let me

[GitHub] [flink] flinkbot commented on pull request #23328: [FLINK-32755][docs] Add doc for OLAP quickstart

flinkbot commented on PR #23328: URL: https://github.com/apache/flink/pull/23328#issuecomment-1698809092 ## CI report: * a902af4910f278bee77ea76b34d331393589ff39 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Jiabao-Sun commented on pull request #23330: [FLINK-32997][table-planner][JUnit5 Migration] Module: flink-table-planner (StreamingTestBase)

Jiabao-Sun commented on PR #23330: URL: https://github.com/apache/flink/pull/23330#issuecomment-1699022432 > Hi, @Jiabao-Sun, thanks for your contribution. IMO, there are too many tests in the table-planner module. Migrating all tests to junit5 at once has a significant impact to current

[GitHub] [flink] jiangxin369 opened a new pull request, #23331: [FLINK-32996][Tests] Fix the CheckpointAfterAllTasksFinishedITCase.testFailoverAfterSomeTasksFinished fails

jiangxin369 opened a new pull request, #23331: URL: https://github.com/apache/flink/pull/23331 ## What is the purpose of the change Fix the CheckpointAfterAllTasksFinishedITCase.testFailoverAfterSomeTasksFinished fails ## Brief change log - Make the test

[GitHub] [flink] wangyang0918 commented on a diff in pull request #23327: [FLINK-32994][runtime] Adds human-readable toString implementations to the LeaderElectionDriver classes

wangyang0918 commented on code in PR #23327: URL: https://github.com/apache/flink/pull/23327#discussion_r1310176627 ## flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java: ## @@ -610,12 +611,41 @@ FileSystemStateStorageHelper

[GitHub] [flink] lsyldliu commented on a diff in pull request #23316: [FLINK-18445][table] Add pre-filter optimization for lookup join

lsyldliu commented on code in PR #23316: URL: https://github.com/apache/flink/pull/23316#discussion_r1309992056 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java: ## @@ -175,9 +177,14 @@ public

[GitHub] [flink-kubernetes-operator] 1996fanrui commented on a diff in pull request #660: [FLINK-32991] Ensure registration of all scaling metrics

1996fanrui commented on code in PR #660: URL: https://github.com/apache/flink-kubernetes-operator/pull/660#discussion_r1309993283 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/AutoscalerFlinkMetrics.java: ## @@ -62,54

[GitHub] [flink] XComp commented on a diff in pull request #23327: [FLINK-32994][runtime] Adds human-readable toString implementations to the LeaderElectionDriver classes

XComp commented on code in PR #23327: URL: https://github.com/apache/flink/pull/23327#discussion_r1310169296 ## flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java: ## @@ -610,12 +611,41 @@ FileSystemStateStorageHelper createFileSystemStateStorage(

[GitHub] [flink] flinkbot commented on pull request #23329: [FLINK-32989][python] Fix version parsing issue

flinkbot commented on PR #23329: URL: https://github.com/apache/flink/pull/23329#issuecomment-1698851565 ## CI report: * d286d64246300766c511593f998d4bad0861dec7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #23330: [FLINK-32997][table-planner][JUnit5 Migration] Module: flink-table-planner (StreamingTestBase)

flinkbot commented on PR #23330: URL: https://github.com/apache/flink/pull/23330#issuecomment-1698892576 ## CI report: * f4a6a5fa3de66084b970b2e4796cf505d6a0e11c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] swuferhong commented on pull request #23330: [FLINK-32997][table-planner][JUnit5 Migration] Module: flink-table-planner (StreamingTestBase)

swuferhong commented on PR #23330: URL: https://github.com/apache/flink/pull/23330#issuecomment-1698994681 Hi, @Jiabao-Sun, thanks for your contribution. IMO, there are too many tests in the table-planner module. Migrating all tests to junit5 at once has a significant impact to current pr

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #659: [FLINK-32973] Add capability to configure kubernetes.operator.job.savepoint-on-deletion on a per-resource level

gyfora merged PR #659: URL: https://github.com/apache/flink-kubernetes-operator/pull/659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #660: [FLINK-32991] Ensure registration of all scaling metrics

mxm commented on code in PR #660: URL: https://github.com/apache/flink-kubernetes-operator/pull/660#discussion_r1309972633 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/AutoscalerFlinkMetrics.java: ## @@ -62,54 +61,49 @@

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #660: [FLINK-32991] Ensure registration of all scaling metrics

mxm commented on code in PR #660: URL: https://github.com/apache/flink-kubernetes-operator/pull/660#discussion_r1309971918 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/AutoscalerFlinkMetrics.java: ## @@ -62,54 +61,49 @@

[GitHub] [flink] Jiabao-Sun opened a new pull request, #23330: [FLINK-32997][table-planner][JUnit5 Migration] Module: flink-table-planner (StreamingTestBase)

Jiabao-Sun opened a new pull request, #23330: URL: https://github.com/apache/flink/pull/23330 [FLINK-32997][table-planner][JUnit5 Migration] Module: flink-table-planner (StreamingTestBase) ## What is the purpose of the change [table-planner][JUnit5 Migration] Module:

[GitHub] [flink] swuferhong commented on pull request #23316: [FLINK-18445][table] Add pre-filter optimization for lookup join

swuferhong commented on PR #23316: URL: https://github.com/apache/flink/pull/23316#issuecomment-1699005015 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-ml] weibozhao opened a new pull request, #254: [Flink 33036] Add transformer and estimator of Als.

weibozhao opened a new pull request, #254: URL: https://github.com/apache/flink-ml/pull/254 ## What is the purpose of the change This pull request adds transformer and estimator of Als. ## Brief change log - *Adds Transformer and Estimator implementation of Als in Java and

[GitHub] [flink] X-czh commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI

X-czh commented on code in PR #20232: URL: https://github.com/apache/flink/pull/20232#discussion_r1315734864 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java: ## @@ -203,7 +203,8 @@ public static

[GitHub] [flink] flinkbot commented on pull request #23358: [FLINK-33032][table-planner][JUnit5 Migration] Module: flink-table-planner (ExpressionTestBase)

flinkbot commented on PR #23358: URL: https://github.com/apache/flink/pull/23358#issuecomment-1706421683 ## CI report: * 789cf16c03d471953f81e54cfb26d74c087ece1e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zhougit86 opened a new pull request, #23360: [FLINK-33038][table-planner] remove getMinRetentionTime in StreamExec…

zhougit86 opened a new pull request, #23360: URL: https://github.com/apache/flink/pull/23360 ## What is the purpose of the change remove code no longer needed ## Brief change log - *remove the getMinRetentionTime* ## Verifying this change

[GitHub] [flink] Jiabao-Sun opened a new pull request, #23358: [FLINK-33032][table-planner][JUnit5 Migration] Module: flink-table-planner (ExpressionTestBase)

Jiabao-Sun opened a new pull request, #23358: URL: https://github.com/apache/flink/pull/23358 ## What is the purpose of the change [FLINK-33032][table-planner][JUnit5 Migration] Module: flink-table-planner (ExpressionTestBase) ## Brief change log JUnit5

[GitHub] [flink] ldadima commented on pull request #23357: [FLINK-33034][Backport][runtime] Correct ValueState creating for StateBackendTestBase#testGetKeysAndNamespaces

ldadima commented on PR #23357: URL: https://github.com/apache/flink/pull/23357#issuecomment-1706625083 > ## CI report: > * [a9237c9](https://github.com/apache/flink/commit/a9237c916b63aa90ac8f84d42b76881936045948) Azure:

[GitHub] [flink] flinkbot commented on pull request #23360: [FLINK-33038][table-planner] remove getMinRetentionTime in StreamExec…

flinkbot commented on PR #23360: URL: https://github.com/apache/flink/pull/23360#issuecomment-1706612522 ## CI report: * c0dfad2fb5cd29d508fb610e64acbc1d8a3509cb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] X-czh commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI

X-czh commented on code in PR #20232: URL: https://github.com/apache/flink/pull/20232#discussion_r1315725139 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/TaskManagerLocation.java: ## @@ -275,6 +275,15 @@ public static String getHostName(InetAddress

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI

1996fanrui commented on code in PR #20232: URL: https://github.com/apache/flink/pull/20232#discussion_r1315731682 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java: ## @@ -203,7 +203,8 @@ public static

[GitHub] [flink] X-czh commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI

X-czh commented on code in PR #20232: URL: https://github.com/apache/flink/pull/20232#discussion_r1315777208 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java: ## @@ -203,7 +203,8 @@ public static

[GitHub] [flink] huwh commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI

huwh commented on code in PR #20232: URL: https://github.com/apache/flink/pull/20232#discussion_r1315762231 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java: ## @@ -203,7 +203,8 @@ public static

[GitHub] [flink] flinkbot commented on pull request #23359: [FLINK-33029][python] Drop python 3.7 support

flinkbot commented on PR #23359: URL: https://github.com/apache/flink/pull/23359#issuecomment-1706520017 ## CI report: * 03d9cb05239f6b88a84c174e3547ad0aa773c33d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #664: [FLINK-33027] Allow users to override parallelism of excluded vertices

gyfora commented on PR #664: URL: https://github.com/apache/flink-kubernetes-operator/pull/664#issuecomment-1706730826 > Thanks for the cleanup! Ideally, autoscaling would manage the overrides end-to-end but this is already cleaner than before. I agree, but for that as you said we

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #664: [FLINK-33027] Allow users to override parallelism of excluded vertices

gyfora merged PR #664: URL: https://github.com/apache/flink-kubernetes-operator/pull/664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI

1996fanrui commented on code in PR #20232: URL: https://github.com/apache/flink/pull/20232#discussion_r1315713611 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java: ## @@ -203,7 +203,8 @@ public static

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI

1996fanrui commented on code in PR #20232: URL: https://github.com/apache/flink/pull/20232#discussion_r1315711282 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/TaskManagerLocation.java: ## @@ -275,6 +275,15 @@ public static String getHostName(InetAddress

[GitHub] [flink] hlteoh37 merged pull request #23352: [FLINK-28513][Backport][release-1.18] Fix Flink Table API CSV streaming sink throws

hlteoh37 merged PR #23352: URL: https://github.com/apache/flink/pull/23352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] gaborgsomogyi opened a new pull request, #23359: [FLINK-][python] Drop python 3.7 support

gaborgsomogyi opened a new pull request, #23359: URL: https://github.com/apache/flink/pull/23359 ## What is the purpose of the change * Python 3.7.17 is the latest security patch of the 3.7 line. This version is end-of-life and is no longer supported:

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #665: [FLINK-33005] Upgrade JOSDK to 4.4.2 and Fabric8 to 6.8.1

gyfora opened a new pull request, #665: URL: https://github.com/apache/flink-kubernetes-operator/pull/665 ## What is the purpose of the change Upgrade the core fabric8 and josdk dependencies and eliminate some deprecated calls. ## Brief change log - *Update

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #664: [FLINK-33027] Allow users to override parallelism of excluded vertices

mxm commented on code in PR #664: URL: https://github.com/apache/flink-kubernetes-operator/pull/664#discussion_r1315892963 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/JobAutoScaler.java: ## @@ -30,6 +28,6 @@ public

[GitHub] [flink] zhangyy91 commented on a diff in pull request #23265: [FLINK-32853][runtime][JUnit5 Migration] The security, taskmanager an…

zhangyy91 commented on code in PR #23265: URL: https://github.com/apache/flink/pull/23265#discussion_r1314270221 ## flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskCancelAsyncProducerConsumerITCase.java: ## @@ -150,10 +147,11 @@ public void

[GitHub] [flink] zhangyy91 commented on a diff in pull request #23265: [FLINK-32853][runtime][JUnit5 Migration] The security, taskmanager an…

zhangyy91 commented on code in PR #23265: URL: https://github.com/apache/flink/pull/23265#discussion_r1314270371 ## flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java: ## @@ -540,9 +527,9 @@ public void testFailExternallyDuringInvoke() throws

[GitHub] [flink] Samrat002 commented on pull request #21458: [FLINK-28513] Fix Flink Table API CSV streaming sink throws SerializedThrowable exception

Samrat002 commented on PR #21458: URL: https://github.com/apache/flink/pull/21458#issuecomment-1703902505 I have taken an example where a datagen table is created with 2 fields `fname` and `lname`. Also created another table which is of type filesystem and points to a specfic s3 path and

[GitHub] [flink] asha-boyapati commented on pull request #23298: [FLINK-32963][Test] Remove flakiness from testKeyedMapStateStateMigration

asha-boyapati commented on PR #23298: URL: https://github.com/apache/flink/pull/23298#issuecomment-1704040989 I want to add that this PR not only removes flakiness from the test mentioned in the title and description

[GitHub] [flink] Zakelly opened a new pull request, #23348: [FLINK-5279] Print state name and type in error message when trying to access keyed state in non-keyed operator

Zakelly opened a new pull request, #23348: URL: https://github.com/apache/flink/pull/23348 ## What is the purpose of the change Improve the error message when trying to access keyed state in non-keyed operator, printing the state name and state type. It is more convenient for user

[GitHub] [flink] flinkbot commented on pull request #23348: [FLINK-5279] Print state name and type in error message when trying to access keyed state in non-keyed operator

flinkbot commented on PR #23348: URL: https://github.com/apache/flink/pull/23348#issuecomment-1703860991 ## CI report: * a9ed979e1ac92962d30a9221bcbca4609b7ae729 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

lindong28 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1313857237 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForestParams.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [flink] dependabot[bot] opened a new pull request, #23361: Bump org.apache.kafka:kafka-clients from 2.2.2 to 2.6.3 in /flink-end-to-end-tests/flink-sql-client-test

dependabot[bot] opened a new pull request, #23361: URL: https://github.com/apache/flink/pull/23361 Bumps org.apache.kafka:kafka-clients from 2.2.2 to 2.6.3. [![Dependabot compatibility

[GitHub] [flink-connector-elasticsearch] mtfelisb commented on a diff in pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

mtfelisb commented on code in PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1316470031 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Operation.java: ## @@ -0,0 +1,70 @@ +/* + * + *

[GitHub] [flink] gaborgsomogyi commented on pull request #23359: [WIP][FLINK-33029][python] Drop python 3.7 support

gaborgsomogyi commented on PR #23359: URL: https://github.com/apache/flink/pull/23359#issuecomment-1706959682 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-statefun] dependabot[bot] opened a new pull request, #338: Bump org.apache.kafka:kafka-clients from 2.4.1 to 2.6.3 in /statefun-e2e-tests/statefun-e2e-tests-common

dependabot[bot] opened a new pull request, #338: URL: https://github.com/apache/flink-statefun/pull/338 Bumps org.apache.kafka:kafka-clients from 2.4.1 to 2.6.3. [![Dependabot compatibility

[GitHub] [flink-connector-elasticsearch] mtfelisb commented on a diff in pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

mtfelisb commented on code in PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1316465669 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Operation.java: ## @@ -0,0 +1,70 @@ +/* + * + *

[GitHub] [flink] flinkbot commented on pull request #23361: Bump org.apache.kafka:kafka-clients from 2.2.2 to 2.6.3 in /flink-end-to-end-tests/flink-sql-client-test

flinkbot commented on PR #23361: URL: https://github.com/apache/flink/pull/23361#issuecomment-1707368077 ## CI report: * 62c67c387d6c6f77581977f93ba230057d765803 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314375629 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForestModel.java: ## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314378326 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForest.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache

[GitHub] [flink] X-czh commented on pull request #23264: Refactor @Test(expected) with assertThrows

X-czh commented on PR #23264: URL: https://github.com/apache/flink/pull/23264#issuecomment-1704648003 Hi @Taher-Ghaleb, thanks for your notice on Flink. If you would like to contribute to Flink, you should follow the [guideline](https://flink.apache.org/how-to-contribute/contribute-code/)

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314379507 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForest.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache

[GitHub] [flink] wangzzu commented on a diff in pull request #22468: FLINK-31889: Add documentation for implementing/loading enrichers

wangzzu commented on code in PR #22468: URL: https://github.com/apache/flink/pull/22468#discussion_r1314383990 ## docs/content/docs/deployment/advanced/failure_enrichers.md: ## @@ -0,0 +1,93 @@ +--- +title: "Failure Enrichers" +nav-title: failure-enrichers +nav-parent_id:

[GitHub] [flink] wangzzu commented on pull request #23243: [FLINK-32846][runtime][JUnit5 Migration] The metrics package of flink-runtime module

wangzzu commented on PR #23243: URL: https://github.com/apache/flink/pull/23243#issuecomment-1704527997 @1996fanrui @Jiabao-Sun if you have time, can you help review this again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314373790 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForestParams.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314374284 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForestParams.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314376355 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForest.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314376830 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForestModelData.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the

[GitHub] [flink] FangYongs commented on pull request #23328: [FLINK-32755][docs] Add doc for OLAP quickstart

FangYongs commented on PR #23328: URL: https://github.com/apache/flink/pull/23328#issuecomment-1704484615 Thanks @xiangyuf , LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] FangYongs merged pull request #23328: [FLINK-32755][docs] Add doc for OLAP quickstart

FangYongs merged PR #23328: URL: https://github.com/apache/flink/pull/23328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314372168 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForest.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314378789 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForest.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache

[GitHub] [flink] libenchao commented on a diff in pull request #22832: [FLINK-32396][jdbc-driver] Support timestamp and timestamp_ltz for jdbc driver and sql gateway

libenchao commented on code in PR #22832: URL: https://github.com/apache/flink/pull/22832#discussion_r1314446016 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/serde/ResultInfo.java: ## @@ -64,12 +67,21 @@ public class ResultInfo {

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314376152 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForest.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314375469 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForestParams.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #662: [FLINK-33008] Refactor to use KubernetesClient from JOSDK Context

gyfora commented on code in PR #662: URL: https://github.com/apache/flink-kubernetes-operator/pull/662#discussion_r1314474313 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/listener/FlinkResourceListener.java: ## @@ -45,8 +44,6 @@

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #46: [FLINK-33017] Remove dependency on shaded guava

tzulitai commented on code in PR #46: URL: https://github.com/apache/flink-connector-kafka/pull/46#discussion_r1316526004 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -452,12 +453,9 @@ public void

[GitHub] [flink-connector-kafka] Gerrrr commented on a diff in pull request #46: [FLINK-33017] Remove dependency on shaded guava

Ge commented on code in PR #46: URL: https://github.com/apache/flink-connector-kafka/pull/46#discussion_r1316546163 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -452,12 +453,9 @@ public void

[GitHub] [flink-connector-kafka] Gerrrr commented on a diff in pull request #46: [FLINK-33017] Remove dependency on shaded guava

Ge commented on code in PR #46: URL: https://github.com/apache/flink-connector-kafka/pull/46#discussion_r1316546436 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -245,12 +245,12 @@ public void close() throws Exception

[GitHub] [flink] luoyuxia merged pull request #23346: [BP-1.18][FLINK-32475][docs] Add doc for time travel

luoyuxia merged PR #23346: URL: https://github.com/apache/flink/pull/23346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] YasuoStudyJava commented on a diff in pull request #17676: [FLINK-14100][connectors] Add Oracle dialect

YasuoStudyJava commented on code in PR #17676: URL: https://github.com/apache/flink/pull/17676#discussion_r1316599115 ## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/converter/OracleRowConverter.java: ## @@ -123,21 +121,33 @@

[GitHub] [flink] wanglijie95 opened a new pull request, #23363: [FLINK-32974][client] Clean up the temp dir on RestClusterClient#close if the temp dir is created by the client

wanglijie95 opened a new pull request, #23363: URL: https://github.com/apache/flink/pull/23363 ## What is the purpose of the change Fix FLINK-32974 ## Verifying this change Add test `RestClusterClientTest#testTempDirCleanedUpOnClose` ## Does this pull request potentially

[GitHub] [flink-kubernetes-operator] HuangZhenQiu commented on pull request #663: [FLINK-32777] add config for opt out okhttp hostname verification

HuangZhenQiu commented on PR #663: URL: https://github.com/apache/flink-kubernetes-operator/pull/663#issuecomment-1707763535 @gyfora The user reported a work around by using environment variable before the new Okhttp version upgrade. If so, the config is not needed. I will create

[GitHub] [flink-kubernetes-operator] HuangZhenQiu closed pull request #663: [FLINK-32777] add config for opt out okhttp hostname verification

HuangZhenQiu closed pull request #663: [FLINK-32777] add config for opt out okhttp hostname verification URL: https://github.com/apache/flink-kubernetes-operator/pull/663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink-connector-kafka] Gerrrr commented on a diff in pull request #46: [FLINK-33017] Remove dependency on shaded guava

Ge commented on code in PR #46: URL: https://github.com/apache/flink-connector-kafka/pull/46#discussion_r1316546581 ## flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/shuffle/KafkaShuffleITCase.java: ## @@ -374,17 +371,16 @@ private void

[GitHub] [flink] YasuoStudyJava commented on a diff in pull request #17676: [FLINK-14100][connectors] Add Oracle dialect

YasuoStudyJava commented on code in PR #17676: URL: https://github.com/apache/flink/pull/17676#discussion_r1316599115 ## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/converter/OracleRowConverter.java: ## @@ -123,21 +121,33 @@

[GitHub] [flink-web] JingsongLi commented on a diff in pull request #665: [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store

JingsongLi commented on code in PR #665: URL: https://github.com/apache/flink-web/pull/665#discussion_r1316749601 ## docs/content.zh/documentation/flink-table-store-0.3.md: ## @@ -1,7 +1,7 @@ --- -weight: 10 -title: Table Store Master (snapshot) Review Comment: Maybe we

[GitHub] [flink] snuyanzin commented on pull request #23342: [FLINK-32999][connectors/hbase] Remove HBase connector code from main repo

snuyanzin commented on PR #23342: URL: https://github.com/apache/flink/pull/23342#issuecomment-1707783072 Thanks for your contribution @ferenc-csaky the build is still failiing it seems some more things should be done I addressed them and submitted as a PR to your branch, the

[GitHub] [flink] snuyanzin commented on pull request #23343: [BP-1.18][FLINK-32999][connectors/hbase] Remove HBase connector code from main repo

snuyanzin commented on PR #23343: URL: https://github.com/apache/flink/pull/23343#issuecomment-1707783637 Thanks for your contribution @ferenc-csaky the build is still failiing it seems some more things should be done I addressed them and submitted as a PR to your branch, the

[GitHub] [flink] lincoln-lil merged pull request #23350: [FLINK-33026][doc] Fix the title of sql 'Performance Tuning' in the chinese index page

lincoln-lil merged PR #23350: URL: https://github.com/apache/flink/pull/23350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #23362: [FLINK-33041][docs] Add an article to guide users to migrate their DataSet jobs to DataStream

flinkbot commented on PR #23362: URL: https://github.com/apache/flink/pull/23362#issuecomment-1707583009 ## CI report: * 4de1347037bc376bd3587ee4f3265b75ffe058fd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #657: [FLINK-31406] Do not delete jobgraph on scale only last-state upgrades

SteNicholas commented on code in PR #657: URL: https://github.com/apache/flink-kubernetes-operator/pull/657#discussion_r1316695338 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconcilerTest.java: ## @@ -847,6

[GitHub] [flink] flinkbot commented on pull request #23364: [FLINK-15922] Only remember expired checkpoints and log received late messages of those in CheckpointCoordinator

flinkbot commented on PR #23364: URL: https://github.com/apache/flink/pull/23364#issuecomment-1707646214 ## CI report: * d8550dd33aaf0c8760f7f070c63446236d43d3ac UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] ldadima commented on pull request #23357: [FLINK-33034][Backport][runtime] Correct ValueState creating for StateBackendTestBase#testGetKeysAndNamespaces

ldadima commented on PR #23357: URL: https://github.com/apache/flink/pull/23357#issuecomment-1707734798 > ## CI report: > * [a9237c9](https://github.com/apache/flink/commit/a9237c916b63aa90ac8f84d42b76881936045948) Azure:

  1   2   3   4   5   6   7   8   9   10   >