Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38191418
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -534,7 +536,70 @@ public int compare(JobStatusMessage o1,
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38179681
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java
---
@@ -218,4 +228,113 @@ public void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38188243
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager(
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38191682
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -588,15 +653,16 @@ protected int cancel(String[] args) {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38184487
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -534,7 +536,70 @@ public int compare(JobStatusMessage o1,
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38186404
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendInfoTest.java ---
@@ -107,28 +89,28 @@ public InfoTestCliFrontend(int
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38186717
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java ---
@@ -1,22 +1,16 @@
/*
- * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38186990
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/RemoteExecutorHostnameResolutionTest.java
---
@@ -88,15 +65,14 @@ private static void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38188430
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphConstructionTest.java
---
@@ -450,8 +414,8 @@ private void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38194969
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager(
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38195523
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager(
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38191972
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java ---
@@ -1,22 +1,16 @@
/*
- * Licensed to the Apache Software
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38193714
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager(
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38194441
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -588,15 +653,16 @@ protected int cancel(String[] args) {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38195614
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager(
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135768996
Wow that is some really big piece of work @mjsax. Thanks for your
contribution. To be honest, I actually thought you would only adapt your newly
written test. As
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38193807
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphConstructionTest.java
---
@@ -450,8 +414,8 @@ private void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38194785
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendAddressConfigurationTest.java
---
@@ -45,163 +43,122 @@
@Rule
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38204935
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager(
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135852748
I just pushed an update addressing your comments. I additionally rework all
TaskManager and JobManager test.
Open issues:
1. how to deal with (potentially
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135901379
Travis fails due to instable test. Own Travis is green:
https://travis-ci.org/mjsax/flink/builds/77750320
---
If your project is set up for it, you can reply to this
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38227043
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager(
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38119693
--- Diff:
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38132263
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager(
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38130678
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerTest.java
---
@@ -363,7 +363,135 @@ protected void run() {
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135523032
I just pushed three commits on top addressing your comment. The first two,
include reworking all test cases in a whole package each, to change the test
pattern from catch
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135069357
Good work @mjsax, I added some comments.
Even though this might be a corner case, but I was wondering what happens
when you've issued the stopping call and
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37999652
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager(
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37996420
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/test/java/org/apache/flink/stormcompatibility/api/FlinkTestCluster.java
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135075011
Thanks for your review. I will add some more answers to the specific
comments (if necessary) and address all others. Do you want me to put a new
commit on top or should I
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37997669
--- Diff:
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37987315
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -586,6 +653,12 @@ protected int cancel(String[] args) {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37987571
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -491,9 +495,58 @@ public void cancel(JobID jobId) throws
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37987664
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -491,9 +495,58 @@ public void cancel(JobID jobId) throws
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37987699
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -491,9 +495,58 @@ public void cancel(JobID jobId) throws
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37988223
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendStopTest.java ---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37988117
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -491,9 +495,58 @@ public void cancel(JobID jobId) throws
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37988485
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkClient.java
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37989216
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -694,6 +695,18 @@ public void cancel() {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37989854
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java
---
@@ -0,0 +1,141 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37990019
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerTest.java
---
@@ -363,7 +363,135 @@ protected void run() {
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37990248
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendStopTest.java ---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37990829
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager(
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37987162
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -536,6 +541,68 @@ public int compare(JobStatusMessage o1,
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37988911
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -536,6 +541,68 @@ public int compare(JobStatusMessage o1,
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37988711
--- Diff:
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37989925
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java
---
@@ -218,4 +228,113 @@ public void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37989991
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerTest.java
---
@@ -363,7 +363,135 @@ protected void run() {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37990761
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/Stopable.java
---
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37991061
--- Diff:
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37991329
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -536,6 +541,68 @@ public int compare(JobStatusMessage o1,
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37991348
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/test/java/org/apache/flink/stormcompatibility/api/FlinkTestCluster.java
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135032541
Just rebased. Failing test in unrelated (Yarn and instable test in
flink-runtime). Both have alread a JIRA.
This PR is ready to get merged from my point of view.
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37991819
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java
---
@@ -0,0 +1,141 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37994413
--- Diff:
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37995193
--- Diff:
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37992103
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -833,15 +846,15 @@ void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37992003
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobStatus.java ---
@@ -29,32 +29,35 @@
/** Some tasks are scheduled or
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37993145
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -411,6 +411,23 @@ class TaskManager(
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37994888
--- Diff:
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37995322
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendStopTest.java ---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37995477
--- Diff:
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-131800322
Failing KafkaConnector test. This in unrelated. Failing run is green on
personal Travis ((https://travis-ci.org/mjsax/flink/builds/75910791).
---
If your project is set
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-131633170
I just rebased to current master. What is the status of this PR? Can it get
merged (from my point of view, yes)?
---
If your project is set up for it, you can reply to
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r36059082
--- Diff: docs/apis/cli.md ---
@@ -176,6 +180,18 @@ Action list lists running and scheduled programs.
-s,--scheduledShow only
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r36059148
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -517,7 +522,70 @@ public int compare(JobStatusMessage o1,
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-127331090
Addressed @hsaputra comments and rebased to current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-122071560
Added fix for https://issues.apache.org/jira/browse/FLINK-2338
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-121534709
@StephanEwen Any news on this PR? It applies some changes to JobManager
WebFrontend. Would be great, if this could be merged before #677 and/or #297
---
If your project
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-120408249
Changes applied:
- renamed signal name from TERMINATE to STOP (as decided by community vote)
- reverted changes to execution graph state machine
- added
201 - 270 of 270 matches
Mail list logo
