[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544495#comment-16544495 ] ASF GitHub Bot commented on FLINK-8866: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536522#comment-16536522 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 closed the pull request at:

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536523#comment-16536523 ] ASF GitHub Bot commented on FLINK-8866: --- GitHub user suez1224 reopened a pull request:

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535682#comment-16535682 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535680#comment-16535680 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535678#comment-16535678 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535676#comment-16535676 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534329#comment-16534329 ] ASF GitHub Bot commented on FLINK-8866: --- Github user walterddr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534332#comment-16534332 ] ASF GitHub Bot commented on FLINK-8866: --- Github user walterddr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534334#comment-16534334 ] ASF GitHub Bot commented on FLINK-8866: --- Github user walterddr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534328#comment-16534328 ] ASF GitHub Bot commented on FLINK-8866: --- Github user walterddr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534330#comment-16534330 ] ASF GitHub Bot commented on FLINK-8866: --- Github user walterddr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534333#comment-16534333 ] ASF GitHub Bot commented on FLINK-8866: --- Github user walterddr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534331#comment-16534331 ] ASF GitHub Bot commented on FLINK-8866: --- Github user walterddr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534327#comment-16534327 ] ASF GitHub Bot commented on FLINK-8866: --- Github user walterddr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532428#comment-16532428 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531930#comment-16531930 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531920#comment-16531920 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on the issue:

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531237#comment-16531237 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531114#comment-16531114 ] ASF GitHub Bot commented on FLINK-8866: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530939#comment-16530939 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on the issue:

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527653#comment-16527653 ] ASF GitHub Bot commented on FLINK-8866: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527379#comment-16527379 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527250#comment-16527250 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527249#comment-16527249 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527247#comment-16527247 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on the issue:

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527246#comment-16527246 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525764#comment-16525764 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525761#comment-16525761 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525755#comment-16525755 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525757#comment-16525757 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524016#comment-16524016 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523996#comment-16523996 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523997#comment-16523997 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524000#comment-16524000 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524009#comment-16524009 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523998#comment-16523998 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524002#comment-16524002 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524008#comment-16524008 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524015#comment-16524015 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524011#comment-16524011 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524005#comment-16524005 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524013#comment-16524013 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524012#comment-16524012 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523999#comment-16523999 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524003#comment-16524003 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524007#comment-16524007 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524010#comment-16524010 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524001#comment-16524001 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524014#comment-16524014 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524004#comment-16524004 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524006#comment-16524006 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523995#comment-16523995 ] ASF GitHub Bot commented on FLINK-8866: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520057#comment-16520057 ] ASF GitHub Bot commented on FLINK-8866: --- GitHub user suez1224 opened a pull request:

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477127#comment-16477127 ] Fabian Hueske commented on FLINK-8866: -- Regarding (3), originally, {{TableSink}} was designed to be

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475416#comment-16475416 ] Timo Walther commented on FLINK-8866: - I agree with (1), we could definitely reduce the number of

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475177#comment-16475177 ] Rong Rong commented on FLINK-8866: -- +1 on the (1) and (2) point, I found like huge trunk of component

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474801#comment-16474801 ] Shuyi Chen commented on FLINK-8866: --- Hi [~walterddr], [~twalthr], [~fhueske], thanks a lot for the

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474463#comment-16474463 ] Rong Rong commented on FLINK-8866: -- I think they should be designed to use in both source and sink cases.

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474115#comment-16474115 ] Fabian Hueske commented on FLINK-8866: -- I think we should design the system properties in a way that

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474096#comment-16474096 ] Timo Walther commented on FLINK-8866: - Hi [~walterddr], the changes for FLINK-8866 look good to me. I

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472571#comment-16472571 ] Rong Rong commented on FLINK-8866: -- Hi [~suez1224] I was working on FLINK-8880 and I thought it will be