Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2275
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355845
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/SecureTestEnvironment.java
---
@@ -0,0 +1,249 @@
+/*
+ *
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355618
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -460,9 +463,27 @@ public static void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355653
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskManagerRunner.java ---
@@ -75,34 +85,66 @@ public static void runYarnTaskManager(String[] args,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355820
--- Diff:
flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/RollingSinkSecuredITCase.java
---
@@ -0,0
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355451
--- Diff: pom.xml ---
@@ -107,6 +107,13 @@ under the License.
2.7.4
3.1.0
4.11
+
+
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355908
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/SecureTestEnvironment.java
---
@@ -0,0 +1,249 @@
+/*
+ *
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79377160
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -0,0 +1,313 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355282
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -523,6 +544,7 @@ public YarnClusterClient createCluster(String
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79356049
--- Diff:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ---
@@ -374,7 +409,39 @@ public static void startYARNWithConfig(Configuration
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79221254
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -155,6 +157,58 @@ public static void
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79221107
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -161,6 +161,8 @@ public CliFrontend(String configDir) throws
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79190433
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -1233,6 +1239,9 @@
/** ZooKeeper default leader
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79153661
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
---
@@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79155885
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -158,22 +157,37 @@ public static void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79153742
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
---
@@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79153795
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
---
@@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79152436
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -79,9 +82,8 @@ public static void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79152195
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -155,6 +157,58 @@ public static void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79154968
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -155,6 +157,58 @@ public static void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79156099
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -1233,6 +1239,9 @@
/** ZooKeeper default leader port. */
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79151542
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -161,6 +161,8 @@ public CliFrontend(String configDir) throws Exception {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79151877
--- Diff: flink-dist/src/main/flink-bin/conf/flink-jaas.conf ---
@@ -0,0 +1,26 @@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79154987
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1585,6 +1585,8 @@ object TaskManager {
}
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73245570
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -1016,6 +1016,23 @@
/** The environment variable
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73160331
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaShortRetentionTestBase.java
---
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73159602
--- Diff:
flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/RollingSinkSecuredITCase.java
---
@@ -0,0
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73159441
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73159333
--- Diff: docs/internals/flink_security.md ---
@@ -0,0 +1,87 @@
+---
+title: "Flink Security"
+# Top navigation
+top-nav-group: internals
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73159225
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -1016,6 +1016,23 @@
/** The environment variable name which
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73159038
--- Diff: flink-core/src/main/java/org/apache/flink/util/Preconditions.java
---
@@ -293,6 +293,16 @@ private static String format(@Nullable String
template,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73158919
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/JaasConfiguration.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73037620
--- Diff: docs/internals/flink_security.md ---
@@ -0,0 +1,87 @@
+---
+title: "Flink Security"
+# Top navigation
+top-nav-group: internals
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73028461
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskManagerRunner.java ---
@@ -75,34 +84,47 @@ public static void runYarnTaskManager(String[]
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73027093
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/RunTypeSelectionRunner.java
---
@@ -0,0 +1,54 @@
+/*
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73023852
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/RunTypeHolder.java
---
@@ -0,0 +1,36 @@
+/*
+ *
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73023816
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
---
@@
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73023705
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/RunTypeHolder.java
---
@@ -0,0 +1,36 @@
+/*
+ *
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73020806
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaShortRetentionTestBase.java
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73017860
--- Diff:
flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/RollingSinkSecuredITCase.java
---
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73015565
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73014755
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73013795
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/JaasConfiguration.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73013657
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/JaasConfiguration.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73012870
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/JaasConfiguration.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73012593
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/JaasConfiguration.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73012055
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -1016,6 +1016,23 @@
/** The environment variable
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72472262
--- Diff: flink-core/src/main/java/org/apache/flink/util/Preconditions.java
---
@@ -293,6 +293,16 @@ private static String format(@Nullable String
template,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72456165
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java
---
@@ -125,29 +124,35 @@ protected int run(String[] args) {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72450591
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/SecureTestEnvironment.java
---
@@ -0,0 +1,207 @@
+/*
+ *
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72448326
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
---
@@ -123,6
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72449798
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/SecureTestEnvironment.java
---
@@ -0,0 +1,207 @@
+/*
+ *
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72449664
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/SecureTestEnvironment.java
---
@@ -0,0 +1,207 @@
+/*
+ *
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72448057
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaShortRetentionTestBase.java
---
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72449205
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/RunTypeSelectionRunner.java
---
@@ -0,0 +1,54 @@
+/*
+ *
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72448259
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
---
@@ -81,13
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72439360
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache
GitHub user vijikarthi opened a pull request:
https://github.com/apache/flink/pull/2275
FLINK-3929 Support for Kerberos Authentication with Keytab Credential
This PR addresses FLINK-3929 requirements:
1) Added Keytab support to Flink (Standalone and Yarn mode deployment)
2)
58 matches
Mail list logo
