Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1245#discussion_r119541625
--- Diff: ranger-plugin/scripts/enable-ranger-plugin.sh ---
@@ -20,7 +20,7 @@
#
function usage() {
- echo "USAGE: e
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1245
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1245#discussion_r119519516
--- Diff: ranger-plugin/conf/ranger-servicedef-hawq.json ---
@@ -244,7 +244,7 @@
"name": "authentication",
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1228#discussion_r114693454
--- Diff: tools/bin/hawq_ctl ---
@@ -737,25 +739,28 @@ class HawqStart:
logger.info("Segments started success
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1228#discussion_r114693412
--- Diff: tools/bin/hawq_ctl ---
@@ -737,25 +739,28 @@ class HawqStart:
logger.info("Segments started success
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1228#discussion_r114693437
--- Diff: tools/bin/hawq_ctl ---
@@ -1042,30 +1046,34 @@ class HawqStop:
return total_return_flag
-def _stop_rps
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1199
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1180#discussion_r107157220
--- Diff: src/backend/catalog/aclchk.c ---
@@ -2335,19 +2335,25 @@ char *getClassNameFromOid(Oid object_oid)
"
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1171
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1163
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1161
LGTM now. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1163#discussion_r104688429
--- Diff: src/backend/gp_libpq_fe/fe-protocol3.c ---
@@ -2296,20 +2261,8 @@ build_startup_packet(const PGconn *conn, char
*packet
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1161#discussion_r104350130
--- Diff: src/backend/utils/misc/etc/hawq-site.xml ---
@@ -149,4 +149,39 @@ under the License
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1161#discussion_r104350069
--- Diff: src/backend/utils/misc/etc/hawq-site.xml ---
@@ -149,4 +149,39 @@ under the License
Github user ictmalili closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user ictmalili opened a pull request:
https://github.com/apache/incubator-hawq/pull/1153
HAWQ-1366. Throw unsupported error out for dictionary page in Parquetâ¦
⦠storage
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1141
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1143#discussion_r102667786
--- Diff: config/tomcat.m4 ---
@@ -0,0 +1,59 @@
+dnl
+dnl tomcat.m4: Locates the Apache Tomcat/6.0.x and its scripts and jars.
+dnl
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1141#discussion_r102650337
--- Diff: src/backend/executor/nodeShareInputScan.c ---
@@ -925,9 +923,12 @@ writer_wait_for_acks(ShareInput_Lk_Context *pctxt, int
share_id, int
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1119
OK. Got your point, Thanks @denalex
This commit LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1119
@denalex What do you mean by "even though with deny conditions access might
not be determined, the RPS will continue to interpret it as access not
allowed"? Doesn't
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1118
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1106#discussion_r99488834
--- Diff: src/backend/catalog/aclchk.c ---
@@ -298,6 +298,14 @@ ExecuteGrantStmt(GrantStmt *stmt)
booladded_objs = false
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1096#discussion_r96797703
--- Diff: src/include/executor/nodeShareInputScan.h ---
@@ -30,6 +30,8 @@
#define NODESHAREINPUTSCAN_H
#include "nodes/execno
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1092#discussion_r96780739
--- Diff: ranger-plugin/scripts/register_hawq.sh ---
@@ -0,0 +1,217 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1092#discussion_r96560193
--- Diff:
ranger-plugin/admin-plugin/src/main/java/org/apache/hawq/ranger/service/HawqClient.java
---
@@ -0,0 +1,314 @@
+/*
+ * Licensed
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1092
+1 except above comments I have made.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1092#discussion_r96557248
--- Diff: ranger-plugin/conf/ranger-servicedef-hawq.json ---
@@ -0,0 +1,287 @@
+{
+ "name": "hawq"
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1092#discussion_r96557368
--- Diff: ranger-plugin/integration/admin/pom.xml ---
@@ -0,0 +1,70 @@
+
+
+
+http://maven.apache.org/POM/4.0.0
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1092#discussion_r96558081
--- Diff: ranger-plugin/scripts/register_hawq.sh ---
@@ -0,0 +1,217 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1092#discussion_r96558333
--- Diff:
ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorization/RangerHawqAuthorizer.java
---
@@ -0,0 +1,263
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1092#discussion_r96556661
--- Diff: .gitignore ---
@@ -41,6 +41,12 @@ objfiles.txt
.pydevproject
.cproject
.settings
+.classpath
+
+# IDEA Project
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1092#discussion_r96556724
--- Diff:
ranger-plugin/admin-plugin/src/main/java/org/apache/hawq/ranger/service/HawqClient.java
---
@@ -0,0 +1,314 @@
+/*
+ * Licensed
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1092#discussion_r96556516
--- Diff: ranger-plugin/admin-plugin/pom.xml ---
@@ -0,0 +1,90 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1092
@linwen @zhangh43 @stanlyxiang @interma @wcl14 @xunzhang Please review this
PR and provide some comments. Thanks :)
---
If your project is set up for it, you can reply to this email
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1087#discussion_r96171369
--- Diff: src/backend/catalog/aclchk.c ---
@@ -2670,28 +2670,50 @@ List *getActionName(AclMode mask)
bool fallBackToNativeCheck(AclObjectKind
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1087#discussion_r96171295
--- Diff: src/include/catalog/pg_namespace.h ---
@@ -123,7 +123,7 @@ DESCR("Standard public schema");
DATA(insert OID = 6104 (
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1085
@denalex Why this PR includes a second commit for "Revert "HAWQ-1248. Merge
Dockerfiles for HAWQ Dev into HAWQ code base." â¦
huor committed 3 days ago "
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1055#discussion_r92971308
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -273,10 +245,10 @@ json_object *create_ranger_request_json_batch(List
*args
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1036#discussion_r90798944
--- Diff: src/backend/cdb/cdbgang.c ---
@@ -444,7 +444,7 @@ disconnectAndDestroyGang(Gang *gp)
elog(DEBUG2, "Wa
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1024
@xunzhang , Thanks.
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1024
@xunzhang What's the purpose of this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1017
@wcl14 I think this has been committed, right? If yes, please close this
PR. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/1028
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/955#discussion_r84825338
--- Diff: tools/bin/hawqregister ---
@@ -422,9 +462,9 @@ class HawqRegister(object):
Format = 'AO
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/955#discussion_r84825537
--- Diff: tools/bin/hawqregister ---
@@ -855,6 +895,85 @@ class HawqRegister(object):
logger.info('Hawq Register Succeed
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/967
LGTM. +1
Huge work here! Thanks @wcl14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/961#discussion_r83187014
--- Diff: tools/bin/hawqregister ---
@@ -60,14 +60,18 @@ def option_parser():
def register_yaml_dict_check(D, table_column_num
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/961#discussion_r83187352
--- Diff: tools/bin/hawqregister ---
@@ -432,7 +436,8 @@ class HawqRegister(object):
if len(params[Format_FileLocations]['Files
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/940#discussion_r83185244
--- Diff: tools/bin/hawqsync-falcon ---
@@ -0,0 +1,1331 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/940#discussion_r83184770
--- Diff: tools/bin/hawqsync-falcon ---
@@ -0,0 +1,1331 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/940#discussion_r83184402
--- Diff: tools/bin/hawqsync-falcon ---
@@ -0,0 +1,1331 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/945
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/934
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/883#discussion_r80217715
--- Diff: tools/doc/hawqregister_help ---
@@ -37,10 +35,19 @@ The file(s) to be registered and the table in HAWQ must
be in the
same HDFS
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/883#discussion_r80218098
--- Diff: tools/doc/hawqregister_help ---
@@ -37,10 +35,19 @@ The file(s) to be registered and the table in HAWQ must
be in the
same HDFS
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/883#discussion_r80217825
--- Diff: tools/doc/hawqregister_help ---
@@ -37,10 +35,19 @@ The file(s) to be registered and the table in HAWQ must
be in the
same HDFS
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/883#discussion_r80218089
--- Diff: tools/doc/hawqregister_help ---
@@ -110,14 +113,24 @@ table 'pg_aoseg.pg_paqseg_77160
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/926
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/919
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/911
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/907#discussion_r79321399
--- Diff: tools/bin/hawqregister ---
@@ -242,6 +253,13 @@ class HawqRegister(object):
logger.error('Files to be registered
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/904
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/904#discussion_r79295805
--- Diff: tools/bin/hawqregister ---
@@ -126,182 +127,319 @@ def option_parser_yml(yml_file):
return 'AO', files, sizes, params['AO_Schema
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/904#discussion_r79295812
--- Diff: tools/bin/hawqregister ---
@@ -126,182 +127,319 @@ def option_parser_yml(yml_file):
return 'AO', files, sizes, params['AO_Schema
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/904#discussion_r79295886
--- Diff: tools/bin/hawqregister ---
@@ -126,182 +127,319 @@ def option_parser_yml(yml_file):
return 'AO', files, sizes, params['AO_Schema
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/904#discussion_r79296000
--- Diff: tools/bin/hawqregister ---
@@ -126,182 +127,319 @@ def option_parser_yml(yml_file):
return 'AO', files, sizes, params['AO_Schema
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/904#discussion_r79296004
--- Diff: tools/bin/hawqregister ---
@@ -126,182 +127,319 @@ def option_parser_yml(yml_file):
return 'AO', files, sizes, params['AO_Schema
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/904#discussion_r79295934
--- Diff: tools/bin/hawqregister ---
@@ -126,182 +127,319 @@ def option_parser_yml(yml_file):
return 'AO', files, sizes, params['AO_Schema
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/904#discussion_r79295956
--- Diff: tools/bin/hawqregister ---
@@ -126,182 +127,319 @@ def option_parser_yml(yml_file):
return 'AO', files, sizes, params['AO_Schema
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/904#discussion_r79295485
--- Diff: tools/bin/hawqregister ---
@@ -126,182 +127,319 @@ def option_parser_yml(yml_file):
return 'AO', files, sizes, params['AO_Schema
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/904#discussion_r79295436
--- Diff: tools/bin/hawqregister ---
@@ -126,182 +127,319 @@ def option_parser_yml(yml_file):
return 'AO', files, sizes, params['AO_Schema
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/901
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/899
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/900
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/885
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/885#discussion_r77564199
--- Diff: tools/bin/hawqregister ---
@@ -336,8 +338,25 @@ def insert_metadata_into_database(dburl, databasename,
tablename, seg_name, firs
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/885#discussion_r77564087
--- Diff: src/test/feature/ManagementTool/test_hawq_register.cpp ---
@@ -369,3 +369,25 @@ TEST_F(TestHawqRegister, TestUsage2Behavior2
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/885#discussion_r77564020
--- Diff: tools/bin/hawqregister ---
@@ -388,11 +415,31 @@ if __name__ == '__main__':
logger.error('Files to be registered
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/878#discussion_r77285478
--- Diff: tools/bin/hawqregister ---
@@ -297,8 +297,8 @@ def move_files_in_hdfs(databasename, tablename, files,
firstsegno, tabledir, nor
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/880#discussion_r77279779
--- Diff: src/test/feature/ManagementTool/test_hawq_register.cpp ---
@@ -3,18 +3,36 @@
#include "lib/command.h"
#include "
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/883#discussion_r77279576
--- Diff: tools/doc/hawqregister_help ---
@@ -100,7 +100,7 @@ Assume the location of the database is
'hdfs://localhost:8020/hawq_default
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/883#discussion_r77279552
--- Diff: tools/doc/hawqregister_help ---
@@ -7,8 +7,8 @@ Usage2: Register parquet/ao table from
laterst-sync-metadata in yaml format
SYNOPSIS
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/878
LGTM except the three comments. Thanks ð±
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/878#discussion_r77279326
--- Diff: tools/bin/hawqregister ---
@@ -327,50 +327,85 @@ def insert_metadata_into_database(dburl,
databasename, tablename, seg_name, firs
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/878#discussion_r77279215
--- Diff: tools/bin/hawqregister ---
@@ -297,8 +297,8 @@ def move_files_in_hdfs(databasename, tablename, files,
firstsegno, tabledir, nor
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/881
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/859
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/859#discussion_r76351833
--- Diff: tools/bin/hawqregister ---
@@ -131,6 +130,18 @@ def option_parser_yml(yml_file):
def create_table(dburl, tablename, schema_info
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/855
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/846
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/846#discussion_r75243419
--- Diff: tools/bin/hawqregister ---
@@ -40,186 +39,195 @@ EXECNAME = os.path.split(__file__)[-1]
setup_tool_logging(EXECNAME,getLocalHostname
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/846#discussion_r75243104
--- Diff: tools/bin/hawqregister ---
@@ -40,186 +39,195 @@ EXECNAME = os.path.split(__file__)[-1]
setup_tool_logging(EXECNAME,getLocalHostname
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/846#discussion_r75243154
--- Diff: tools/bin/hawqregister ---
@@ -40,186 +39,195 @@ EXECNAME = os.path.split(__file__)[-1]
setup_tool_logging(EXECNAME,getLocalHostname
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/846#discussion_r75242515
--- Diff: tools/bin/hawqregister ---
@@ -40,186 +39,195 @@ EXECNAME = os.path.split(__file__)[-1]
setup_tool_logging(EXECNAME,getLocalHostname
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/846#discussion_r75242545
--- Diff: tools/bin/hawqregister ---
@@ -40,186 +39,195 @@ EXECNAME = os.path.split(__file__)[-1]
setup_tool_logging(EXECNAME,getLocalHostname
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/846#discussion_r75241823
--- Diff: src/test/feature/ManagementTool/test_hawq_register.cpp ---
@@ -199,9 +199,121 @@ TEST_F(TestHawqRegister, TestNotHDFSPath
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/850
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/847
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/846#discussion_r74715268
--- Diff: tools/bin/hawqregister ---
@@ -40,119 +38,126 @@ EXECNAME = os.path.split(__file__)[-1]
setup_tool_logging(EXECNAME,getLocalHostname
1 - 100 of 125 matches
Mail list logo
