[GitHub] incubator-hawq issue #1384: HAWQ-1628. Add HDFS protocol for external storag...

2018-08-13 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1384 Though some similar problems(indent, format, free Uri, etc) were not pointed out, pls go through the code and fix all similar problems above. ---

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-13 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r209506292 --- Diff: contrib/exthdfs/exthdfs.c --- @@ -0,0 +1,469 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] incubator-hawq issue #1333: HAWQ-1582. hawq ssh cmd bug when pipe in cmd

2018-01-23 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1333 +1 ---

[GitHub] incubator-hawq issue #1324: HAWQ-1573. Clear debug_query_string in proc_exit...

2017-12-20 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1324 +1 ---

[GitHub] incubator-hawq issue #1314: HAWQ-1555. Add access interfaces for protocol an...

2017-11-30 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1314 +1 ---

[GitHub] incubator-hawq pull request #1314: HAWQ-1555. Add access interfaces for prot...

2017-11-30 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1314#discussion_r154280568 --- Diff: src/backend/access/external/plugstorage.c --- @@ -0,0 +1,533 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] incubator-hawq pull request #1310: HAWQ-1548 Correct ambiguous message while...

2017-11-18 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1310#discussion_r151854548 --- Diff: src/backend/resourcemanager/resourcebroker/resourcebroker_LIBYARN.c --- @@ -782,7 +782,7 @@ int handleRB2RM_ClusterReport(void

[GitHub] incubator-hawq pull request #1310: HAWQ-1548 Correct ambiguous message while...

2017-11-18 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1310#discussion_r151854472 --- Diff: src/backend/resourcemanager/resourcebroker/resourcebroker_LIBYARN.c --- @@ -773,7 +773,7 @@ int handleRB2RM_ClusterReport(void

[GitHub] incubator-hawq pull request #1280: HAWQ-1510. Add TDE-related functionality ...

2017-08-22 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1280#discussion_r134641796 --- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c --- @@ -6,9 +6,9 @@ * to you under the Apache License, Version 2.0 (the * "Li

[GitHub] incubator-hawq issue #1279: HAWQ-1310. Reformat resource_negotiator().

2017-08-10 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1279 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #1277: add hawq start "userinput.ask_yesno"

2017-08-10 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1277 @wangbincmss Since hawq opened source and use apache JIRA to tracker all the changes, so for every pull request please create a apache jira first for your pull request like other

[GitHub] incubator-hawq pull request #1265: HAWQ-1500. HAWQ-1501. HAWQ-1502. Support ...

2017-07-12 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1265#discussion_r127112526 --- Diff: depends/libhdfs3/src/client/HttpClient.h --- @@ -0,0 +1,155

[GitHub] incubator-hawq issue #1258: HAWQ-1458. The maximum value of guc share_input_...

2017-06-22 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1258 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

2017-06-14 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 If we add "hawq reload-config", I think there is no need for "hawq stop cluster -u". 2 commands have same function make me more confused. --- If your project is se

[GitHub] incubator-hawq issue #1226: HAWQ-1447. Fix ranger build failure

2017-06-07 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1226 I tested on my rhel7. After build rps rpm, there are 2 commands after the rpm generate. ` [INFO] + cd /home/xsheng/hawq/incubator-hawq/ranger-plugin/target/rpm/hawq-ranger

[GitHub] incubator-hawq pull request #1250: Hawq 1477. Ranger-plugin connect to Range...

2017-06-06 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1250#discussion_r120274829 --- Diff: ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorization/RangerHawqPluginResource.java --- @@ -45,8 +47,43

[GitHub] incubator-hawq pull request #1250: Hawq 1477. Ranger-plugin connect to Range...

2017-06-04 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1250#discussion_r120044242 --- Diff: ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorization/RangerHawqPluginResource.java --- @@ -45,8 +47,43

[GitHub] incubator-hawq pull request #1250: Hawq 1477. Ranger-plugin connect to Range...

2017-06-04 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1250#discussion_r120044685 --- Diff: ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorization/RangerHawqPluginResource.java --- @@ -45,8 +47,43

[GitHub] incubator-hawq pull request #1250: Hawq 1477. Ranger-plugin connect to Range...

2017-06-04 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1250#discussion_r120043142 --- Diff: ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorization/Utils.java --- @@ -68,6 +77,30 @@ public static String

[GitHub] incubator-hawq pull request #1250: Hawq 1477. Ranger-plugin connect to Range...

2017-06-04 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1250#discussion_r120042673 --- Diff: ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorization/RangerHawqPluginResource.java --- @@ -45,8 +47,43

[GitHub] incubator-hawq pull request #1248: HAWQ-1476. Augment enable-ranger-plugin.s...

2017-06-01 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1248 HAWQ-1476. Augment enable-ranger-plugin.sh to support kerberos. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyxiang

[GitHub] incubator-hawq pull request #1245: HAWQ-1476. Augment enable-ranger-plugin.s...

2017-05-28 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1245#discussion_r118834619 --- Diff: ranger-plugin/scripts/enable-ranger-plugin.sh --- @@ -20,7 +20,7 @@ # function usage() { - echo "USAGE: e

[GitHub] incubator-hawq pull request #1235: HAWQ-1456. Copy RPS configuration files t...

2017-05-09 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1235#discussion_r115425270 --- Diff: ranger-plugin/scripts/enable-ranger-plugin.sh --- @@ -104,8 +157,18 @@ function get_hawq_password() { done

[GitHub] incubator-hawq pull request #1235: HAWQ-1456. Copy RPS configuration files t...

2017-05-09 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1235#discussion_r115424467 --- Diff: tools/bin/hawq_ctl --- @@ -387,6 +387,10 @@ class HawqInit: (self.GPHOME, self.standby_host_name, self.GPHOME

[GitHub] incubator-hawq pull request #1235: HAWQ-1456. Copy RPS configuration files t...

2017-05-09 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1235#discussion_r115425328 --- Diff: ranger-plugin/scripts/enable-ranger-plugin.sh --- @@ -237,9 +305,13 @@ main() { if [[ $# -lt 1 ]]; then usage

[GitHub] incubator-hawq pull request #1234: HAWQ-1436. Implement ranger pulgin servic...

2017-05-08 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1234#discussion_r115410444 --- Diff: src/backend/libpq/rangerrest.c --- @@ -383,58 +383,100 @@ static size_t write_callback(char *contents, size_t size, size_t nitems

[GitHub] incubator-hawq pull request #1234: HAWQ-1436. Implement ranger pulgin servic...

2017-05-08 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1234#discussion_r115410368 --- Diff: src/backend/libpq/rangerrest.c --- @@ -383,58 +383,100 @@ static size_t write_callback(char *contents, size_t size, size_t nitems

[GitHub] incubator-hawq issue #1231: HAWQ-1452. Remove hawq_rps_address_suffix and ha...

2017-05-04 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1231 Merged into master. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request #1231: HAWQ-1452. Remove hawq_rps_address_suffix...

2017-05-04 Thread stanlyxiang
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/1231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1229: HAWQ-1451. HAWQ state should be able to r...

2017-05-03 Thread stanlyxiang
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/1229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1228: HAWQ-1449. HAWQ start/stop cluster should...

2017-05-03 Thread stanlyxiang
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/1228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #1229: HAWQ-1451. HAWQ state should be able to report t...

2017-05-03 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1229 Merged into master. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq issue #1228: HAWQ-1449. HAWQ start/stop cluster should be abl...

2017-05-03 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1228 Merged into master. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request #1228: HAWQ-1449. HAWQ start/stop cluster should...

2017-05-03 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1228#discussion_r114693788 --- Diff: tools/bin/hawq_ctl --- @@ -737,25 +739,28 @@ class HawqStart: logger.info("Segments started success

[GitHub] incubator-hawq pull request #1229: HAWQ-1451. HAWQ state should be able to r...

2017-05-03 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1229#discussion_r114692327 --- Diff: tools/bin/hawqstate --- @@ -135,12 +138,14 @@ def show_brief_status(hawq_site, segment_list, standby_host): else

[GitHub] incubator-hawq pull request #1231: HAWQ-1452. Remove hawq_rps_address_suffix...

2017-05-03 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1231 HAWQ-1452. Remove hawq_rps_address_suffix and hawq_rps_address_host i… …n hawq-site.xml to simplify configuration for RPS High Availability You can merge this pull request

[GitHub] incubator-hawq pull request #1229: HAWQ-1451. HAWQ state should be able to r...

2017-05-03 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1229 HAWQ-1451. HAWQ state should be able to report the status of both RPS… … and standby RPS You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-hawq pull request #1228: HAWQ-1449. HAWQ start/stop cluster should...

2017-05-03 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1228 HAWQ-1449. HAWQ start/stop cluster should be able to start/stop RPS o… …n standby node You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-hawq issue #1228: HAWQ-1449. HAWQ start/stop cluster should be abl...

2017-05-03 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1228 @interma @linwen @zhangh43 @ictmalili pls review, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-hawq pull request #1226: HAWQ-1447. Fix ranger build failure

2017-05-01 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1226 HAWQ-1447. Fix ranger build failure @interma @zhangh43 @linwen @ictmalili pls review, thanks You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-hawq issue #1219: HAWQ-1433. ALTER RESOURCE QUEUE DDL does not che...

2017-04-26 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1219 Merged into master. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq issue #1219: HAWQ-1433. ALTER RESOURCE QUEUE DDL does not che...

2017-04-17 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1219 @linwen Yes. Currently only support percentage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hawq pull request #1219: HAWQ-1433. ALTER RESOURCE QUEUE DDL does ...

2017-04-17 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1219 HAWQ-1433. ALTER RESOURCE QUEUE DDL does not check the format of attr… …ibute MEMORY_CLUSTER_LIMIT and CORE_CLUSTER_LIMIT You can merge this pull request into a Git repository

[GitHub] incubator-hawq issue #1217: HAWQ-1430. Update ranger related log level to av...

2017-04-13 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1217 Merged into master. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request #1217: HAWQ-1430. Update ranger related log leve...

2017-04-13 Thread stanlyxiang
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/1217 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1217: HAWQ-1430. Update ranger related log leve...

2017-04-12 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1217 HAWQ-1430. Update ranger related log level to avoid log flood @interma @zhangh43 @ictmalili please help to review. thanks. You can merge this pull request into a Git repository

[GitHub] incubator-hawq issue #1188: HAWQ-1406. Update HAWQ product version strings f...

2017-03-26 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1188 We CAN copy. But better to GENERATE the version.json file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-hawq pull request #1186: HAWQ-1405. 'hawq stop --reload' should no...

2017-03-23 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1186#discussion_r107836478 --- Diff: tools/bin/hawq_ctl --- @@ -1041,14 +1041,14 @@ class HawqStop: logger.info("Segments %s success

[GitHub] incubator-hawq pull request #1171: HAWQ-1359. Add test cases for Ranger supp...

2017-03-15 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1171#discussion_r106091426 --- Diff: src/test/feature/Ranger/test_ranger.cpp --- @@ -24,19 +24,34 @@ #include "lib/command.h" #include &quo

[GitHub] incubator-hawq pull request #1171: HAWQ-1359. Add test cases for Ranger supp...

2017-03-14 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1171#discussion_r106078845 --- Diff: ranger-plugin/.gitignore --- @@ -1,2 +1,3 @@ target/ Makefile.global +/bin/ --- End diff -- is there any

[GitHub] incubator-hawq pull request #1171: HAWQ-1359. Add test cases for Ranger supp...

2017-03-14 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1171#discussion_r106079103 --- Diff: src/test/feature/Ranger/test_ranger.cpp --- @@ -24,19 +24,34 @@ #include "lib/command.h" #include &quo

[GitHub] incubator-hawq pull request #1171: HAWQ-1359. Add test cases for Ranger supp...

2017-03-14 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1171#discussion_r106078042 --- Diff: src/test/feature/Ranger/test_ranger.cpp --- @@ -24,19 +24,34 @@ #include "lib/command.h" #include &quo

[GitHub] incubator-hawq pull request #1166: HAWQ-1362. remove SYS_CATALINA_HOME to st...

2017-03-08 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1166 HAWQ-1362. remove SYS_CATALINA_HOME to stay consistent with build che… …ck CATALINA_HOME You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-hawq issue #1164: HAWQ-1362. Add RPS start/stop script in HAWQ sta...

2017-03-07 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1164 Merged into master. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request #1164: HAWQ-1362. Add RPS start/stop script in H...

2017-03-07 Thread stanlyxiang
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/1164 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1164: HAWQ-1362. Add RPS start/stop script in H...

2017-03-07 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1164#discussion_r104841513 --- Diff: ranger-plugin/conf/rps.properties --- @@ -29,4 +29,7 @@ RPS_SHUTDOWN_PORT=8405 RANGER_HAWQ_INSTANCE=hawq # version

[GitHub] incubator-hawq pull request #1164: HAWQ-1362. Add RPS start/stop script in H...

2017-03-07 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1164 HAWQ-1362. Add RPS start/stop script in HAWQ start/stop script please review, thanks. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-hawq pull request #1147: HAWQ-1350. Fix ranger-plugin makefile err...

2017-02-27 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1147 HAWQ-1350. Fix ranger-plugin makefile error @interma @ictmalili @linwen You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-hawq pull request #1143: HAWQ-1350. Add --enable-rps option to bui...

2017-02-24 Thread stanlyxiang
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/1143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #1143: HAWQ-1350. Add --enable-rps option to build rang...

2017-02-24 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1143 Merged into master. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request #1137: HAWQ-1349. make uninstall failed for make...

2017-02-24 Thread stanlyxiang
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/1137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #1137: HAWQ-1349. make uninstall failed for make target...

2017-02-24 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1137 Merged into master. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request #1143: HAWQ-1350. Add --enable-rps option to bui...

2017-02-23 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1143#discussion_r102678227 --- Diff: config/tomcat.m4 --- @@ -0,0 +1,59 @@ +dnl +dnl tomcat.m4: Locates the Apache Tomcat/6.0.x and its scripts and jars. +dnl

[GitHub] incubator-hawq issue #1143: HAWQ-1350. Add --enable-rps option to build rang...

2017-02-23 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1143 Yes. This is for ranger support only. In our work, we avoid to confuse users with ranger and ranger-plugin. Because users should install ranger (apache ranger) before use HAWQ

[GitHub] incubator-hawq pull request #1143: HAWQ-1350. Add --enable-rps option to bui...

2017-02-23 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1143 HAWQ-1350. Add --enable-rps option to build ranger-plugin when build … …hawq. please help to review, thanks. @ictmalili @linwen @zhangh43 @interma @wcl14 You can merge

[GitHub] incubator-hawq pull request #:

2017-02-22 Thread stanlyxiang
Github user stanlyxiang commented on the pull request: https://github.com/apache/incubator-hawq/commit/b37f18768dceec5600f8a90f6f8b17045954629c#commitcomment-21010171 Agree with wengyanqing. And we'd better rebase multiple commits into one commit if we are doing one thing, except

[GitHub] incubator-hawq pull request #1137: HAWQ-1349. make uninstall failed for make...

2017-02-22 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1137 HAWQ-1349. make uninstall failed for make target gpmodcat_uninstall just a typo, please help to review. thanks. @ictmalili @zhangh43 @linwen @interma You can merge this pull request

[GitHub] incubator-hawq issue #1120: HAWQ-1329. pg_catalog view fallback failed.

2017-02-14 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1120 Merged into master. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request #1120: HAWQ-1329. pg_catalog view fallback faile...

2017-02-14 Thread stanlyxiang
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/1120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1120: HAWQ-1329. pg_catalog view fallback faile...

2017-02-14 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1120 HAWQ-1329. pg_catalog view fallback failed. @zhangh43 @linwen You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyxiang

[GitHub] incubator-hawq issue #1106: HAWQ-1312. Forbid grant/revoke command in HAWQ s...

2017-02-06 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1106 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1103: HAWQ-1292. Change GUC enable_ranger(bool)...

2017-02-05 Thread stanlyxiang
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/1103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #1103: HAWQ-1292. Change GUC enable_ranger(bool) to a t...

2017-02-05 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1103 Merged into master. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq issue #1103: HAWQ-1292. Change GUC enable_ranger(bool) to a t...

2017-01-25 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1103 @zhangh43 @ictmalili @xunzhangplease help to review. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-hawq pull request #1103: HAWQ-1292. Change GUC enable_ranger(bool)...

2017-01-25 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1103 HAWQ-1292. Change GUC enable_ranger(bool) to a text GUC(hawq_acl_type… …), which can allow other kinds of ACL. You can merge this pull request into a Git repository by running

[GitHub] incubator-hawq issue #1097: HAWQ-1285. resource manager outputs uninitialize...

2017-01-19 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1097 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1095: HAWQ-1276. hawq should error out directly...

2017-01-18 Thread stanlyxiang
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/1095 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #1095: HAWQ-1276. hawq should error out directly when r...

2017-01-18 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1095 merged into master. closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq issue #1095: HAWQ-1276. hawq should error out directly when r...

2017-01-18 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1095 cc @ictmalili @interma --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request #1095: HAWQ-1276. hawq should error out directly...

2017-01-17 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1095 HAWQ-1276. hawq should error out directly when ranger plugin service … …is unavailable, not a warning. You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-hawq issue #1094: HAWQ-1279. Force to recompute namespace_path whe...

2017-01-17 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1094 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1088: HAWQ-1276. The error message is not frien...

2017-01-17 Thread stanlyxiang
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/1088 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #1088: HAWQ-1276. The error message is not friendly whe...

2017-01-17 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1088 merged into master. closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request #1090: HAWQ-1203. Ranger Plugin Service Implemen...

2017-01-16 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1090#discussion_r96338779 --- Diff: ranger-plugin/integration/service/src/test/java/org/apache/hawq/ranger/integration/service/tests/RPSRequest.java --- @@ -0,0 +1,41

[GitHub] incubator-hawq pull request #1090: HAWQ-1203. Ranger Plugin Service Implemen...

2017-01-16 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1090#discussion_r96338796 --- Diff: ranger-plugin/integration/service/src/test/java/org/apache/hawq/ranger/integration/service/tests/RPSResponse.java --- @@ -0,0 +1,23

[GitHub] incubator-hawq pull request #1090: HAWQ-1203. Ranger Plugin Service Implemen...

2017-01-16 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1090#discussion_r96338825 --- Diff: ranger-plugin/integration/service/src/test/java/org/apache/hawq/ranger/integration/service/tests/Utils.java --- @@ -0,0 +1,57

[GitHub] incubator-hawq issue #1089: HAWQ-1243. Add suffix name for ranger restful se...

2017-01-16 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1089 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1088: HAWQ-1276. The error message is not frien...

2017-01-16 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1088#discussion_r96181179 --- Diff: src/backend/libpq/rangerrest.c --- @@ -366,7 +365,7 @@ static size_t write_callback(char *contents, size_t size, size_t nitems

[GitHub] incubator-hawq pull request #1088: HAWQ-1276. The error message is not frien...

2017-01-16 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1088#discussion_r96179729 --- Diff: src/backend/libpq/rangerrest.c --- @@ -366,7 +365,7 @@ static size_t write_callback(char *contents, size_t size, size_t nitems

[GitHub] incubator-hawq issue #1087: HAWQ-1275. Check build-in catalogs, tables and f...

2017-01-15 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1087 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #1088: HAWQ-1276. The error message is not friendly whe...

2017-01-15 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1088 cc @interma @zhangh43 @linwen @ictmalili @wcl14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hawq pull request #1088: HAWQ-1276. The error message is not frien...

2017-01-15 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1088 HAWQ-1276. The error message is not friendly when ranger plugin servi… …ce is unavailable. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-hawq issue #1086: HAWQ-1274. Add apache rat check in travis CI.

2017-01-13 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1086 LGTM , +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-hawq pull request #1086: HAWQ-1274. Add apache rat check in travis...

2017-01-13 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1086#discussion_r96110581 --- Diff: .travis.yml --- @@ -38,6 +39,7 @@ script: - make -j$(sysctl -n hw.ncpu) - make feature-test - make feature-test

[GitHub] incubator-hawq pull request #1081: HAWQ-1257. Prompt all tables which user d...

2017-01-12 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1081#discussion_r95751617 --- Diff: src/backend/libpq/rangerrest.c --- @@ -463,7 +464,12 @@ int check_privilege_from_ranger(List *request_list, List *result_list

[GitHub] incubator-hawq pull request #1081: HAWQ-1257. Prompt all tables which user d...

2017-01-11 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1081#discussion_r95715330 --- Diff: src/backend/libpq/rangerrest.c --- @@ -381,29 +449,38 @@ int call_ranger_rest(CURL_HANDLE curl_handle, const char* request

[GitHub] incubator-hawq pull request #1082: HAWQ-1256. non-superuser connect to db wi...

2017-01-11 Thread stanlyxiang
GitHub user stanlyxiang opened a pull request: https://github.com/apache/incubator-hawq/pull/1082 HAWQ-1256. non-superuser connect to db will do aclcheck through range… …r and curl handle haven't been initialized. You can merge this pull request into a Git repository by running

[GitHub] incubator-hawq pull request #1081: HAWQ-1257. Prompt all tables which user d...

2017-01-11 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1081#discussion_r95528917 --- Diff: src/backend/libpq/rangerrest.c --- @@ -68,51 +69,99 @@ static void getClientIP(char *remote_host

[GitHub] incubator-hawq pull request #1081: HAWQ-1257. Prompt all tables which user d...

2017-01-11 Thread stanlyxiang
Github user stanlyxiang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1081#discussion_r95531777 --- Diff: src/backend/libpq/rangerrest.c --- @@ -381,29 +449,38 @@ int call_ranger_rest(CURL_HANDLE curl_handle, const char* request

[GitHub] incubator-hawq pull request #1079: HAWQ-1256. Enhance libcurl connection to ...

2017-01-11 Thread stanlyxiang
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/1079 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

  1   2   >