[GitHub] [hbase] saintstack commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-09 Thread GitBox
saintstack commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r437876487 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -3921,4 +3996,85 @@ public MetaRegionLocationCache

[GitHub] [hbase] saintstack commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-09 Thread GitBox
saintstack commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r437876145 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java ## @@ -365,8 +365,6 @@ protected static

[GitHub] [hbase] saintstack commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-09 Thread GitBox
saintstack commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r437875533 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java ## @@ -552,4 +553,12 @@ default SplitWALManager

[GitHub] [hbase] saintstack commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-09 Thread GitBox
saintstack commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-641736719 Hopefully we can do work up front that makes it so new clients do not have to take a big pause while downloading MBs joining a big cluster. `There is no paging support

[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2020-06-09 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128349#comment-17128349 ] Danil Lipovoy edited comment on HBASE-23887 at 6/10/20, 5:40 AM: - Is it

[GitHub] [hbase] Apache-HBase commented on pull request #1881: HBASE-24529 hbase.rs.evictblocksonclose is not honored when removing …

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1881: URL: https://github.com/apache/hbase/pull/1881#issuecomment-641733406 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase-native-client] bharathv commented on a change in pull request #3: HBASE-24400: Download folly, wangle, zookeeper, and protobuf

2020-06-09 Thread GitBox
bharathv commented on a change in pull request #3: URL: https://github.com/apache/hbase-native-client/pull/3#discussion_r437867365 ## File path: CMakeLists.txt ## @@ -162,12 +284,29 @@ add_custom_target( linter COMMAND ${CMAKE_SOURCE_DIR}/bin/cpplint.sh) # Copy the

[GitHub] [hbase-native-client] bharathv commented on a change in pull request #3: HBASE-24400: Download folly, wangle, zookeeper, and protobuf

2020-06-09 Thread GitBox
bharathv commented on a change in pull request #3: URL: https://github.com/apache/hbase-native-client/pull/3#discussion_r437833597 ## File path: .gitignore ## @@ -33,7 +33,7 @@ simple-client # CMake temporary files CMakeCache.txt CMakeFiles -*.cmake +#*.cmake Review

[GitHub] [hbase] brfrn169 opened a new pull request #1881: HBASE-24529 hbase.rs.evictblocksonclose is not honored when removing …

2020-06-09 Thread GitBox
brfrn169 opened a new pull request #1881: URL: https://github.com/apache/hbase/pull/1881 …compacted files and closing the storefiles This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (HBASE-24529) hbase.rs.evictblocksonclose is not honored when removing compacted files and closing the storefiles

2020-06-09 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-24529: - Description: Currently, when removing compacted files and closing the storefiles, RS

[jira] [Created] (HBASE-24529) hbase.rs.evictblocksonclose is not honored when removing compacted files and closing the storefiles

2020-06-09 Thread Toshihiro Suzuki (Jira)
Toshihiro Suzuki created HBASE-24529: Summary: hbase.rs.evictblocksonclose is not honored when removing compacted files and closing the storefiles Key: HBASE-24529 URL:

[GitHub] [hbase] saintstack commented on a change in pull request #1866: HBASE-24517 AssignmentManager.start should add meta region to ServerS…

2020-06-09 Thread GitBox
saintstack commented on a change in pull request #1866: URL: https://github.com/apache/hbase/pull/1866#discussion_r436981312 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManagerLoadMetaRegionState.java ## @@ -0,0 +1,76 @@

[GitHub] [hbase] bharathv commented on a change in pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
bharathv commented on a change in pull request #1879: URL: https://github.com/apache/hbase/pull/1879#discussion_r437846013 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java ## @@ -66,8 +66,14 @@ public

[jira] [Reopened] (HBASE-24517) AssignmentManager.start should add meta region to ServerStateNode

2020-06-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-24517: --- Reopen for applying addendum. > AssignmentManager.start should add meta region to ServerStateNode >

[GitHub] [hbase] zhaoyim commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2020-06-09 Thread GitBox
zhaoyim commented on a change in pull request #746: URL: https://github.com/apache/hbase/pull/746#discussion_r437817573 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java ## @@ -270,39 +267,23 @@ public void unbuffer() {

[jira] [Commented] (HBASE-23202) ExportSnapshot (import) will fail if copying files to root directory takes longer than cleaner TTL

2020-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129931#comment-17129931 ] Hudson commented on HBASE-23202: Results for branch branch-2 [build #2699 on

[jira] [Commented] (HBASE-24340) PerformanceEvaluation options should not mandate any specific order

2020-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129932#comment-17129932 ] Hudson commented on HBASE-24340: Results for branch branch-2 [build #2699 on

[jira] [Commented] (HBASE-24441) CacheConfig details logged at Store open is not really useful

2020-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129934#comment-17129934 ] Hudson commented on HBASE-24441: Results for branch branch-2 [build #2699 on

[jira] [Commented] (HBASE-24367) ScheduledChore log elapsed timespan in a human-friendly format

2020-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129935#comment-17129935 ] Hudson commented on HBASE-24367: Results for branch branch-2 [build #2699 on

[jira] [Commented] (HBASE-24468) Add region info when log meessages in HStore.

2020-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129933#comment-17129933 ] Hudson commented on HBASE-24468: Results for branch branch-2 [build #2699 on

[jira] [Updated] (HBASE-24184) Backport HBASE-23896 to branch-1

2020-06-09 Thread tianhang tang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tianhang tang updated HBASE-24184: -- Summary: Backport HBASE-23896 to branch-1 (was: listSnapshots returns empty when just use

[jira] [Commented] (HBASE-24184) Backport HBASE-23896 to branch-1

2020-06-09 Thread tianhang tang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129930#comment-17129930 ] tianhang tang commented on HBASE-24184: --- [~zghao] done : ) > Backport HBASE-23896 to branch-1 >

[GitHub] [hbase] Apache-HBase commented on pull request #1670: HBASE-24337 Backport HBASE-23968 to branch-2

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1670: URL: https://github.com/apache/hbase/pull/1670#issuecomment-641667381 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24517) AssignmentManager.start should add meta region to ServerStateNode

2020-06-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129918#comment-17129918 ] Duo Zhang commented on HBASE-24517: --- {quote} You pushed but there was an outstanding question on the

[GitHub] [hbase] Apache-HBase commented on pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1879: URL: https://github.com/apache/hbase/pull/1879#issuecomment-641658595 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Commented] (HBASE-24184) listSnapshots returns empty when just use simple acl but not use authentication

2020-06-09 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129914#comment-17129914 ] Guanghao Zhang commented on HBASE-24184: How about change this to "Backport HBASE-23896 to

[jira] [Commented] (HBASE-24403) FsDelegationToken should cache Token

2020-06-09 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129913#comment-17129913 ] Guanghao Zhang commented on HBASE-24403: [~wuchang1989] Can you prepare a new patch for

[jira] [Updated] (HBASE-24403) FsDelegationToken should cache Token

2020-06-09 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24403: --- Fix Version/s: 2.2.6 2.3.0 3.0.0-alpha-1 >

[GitHub] [hbase] infraio merged pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-06-09 Thread GitBox
infraio merged pull request #1743: URL: https://github.com/apache/hbase/pull/1743 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Assigned] (HBASE-24403) FsDelegationToken should cache Token

2020-06-09 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24403: -- Assignee: wuchang > FsDelegationToken should cache Token >

[GitHub] [hbase] apurtell commented on a change in pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
apurtell commented on a change in pull request #1879: URL: https://github.com/apache/hbase/pull/1879#discussion_r437788463 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java ## @@ -66,8 +66,14 @@ public

[GitHub] [hbase] apurtell commented on a change in pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
apurtell commented on a change in pull request #1879: URL: https://github.com/apache/hbase/pull/1879#discussion_r437787274 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java ## @@ -66,8 +66,14 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #1880: HBASE-24144 Update docs from master

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1880: URL: https://github.com/apache/hbase/pull/1880#issuecomment-641641239 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Created] (HBASE-24528) Improve balancer decision observability

2020-06-09 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-24528: --- Summary: Improve balancer decision observability Key: HBASE-24528 URL: https://issues.apache.org/jira/browse/HBASE-24528 Project: HBase Issue

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129893#comment-17129893 ] Hudson commented on HBASE-11288: Results for branch HBASE-11288.splittable-meta [build #6 on

[jira] [Updated] (HBASE-24527) Improve region housekeeping status observability

2020-06-09 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24527: Description: We provide a coarse grained admin API and associated shell command

[jira] [Updated] (HBASE-24527) Improve region housekeeping status observability

2020-06-09 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24527: Description: We provide a coarse grained admin API and associated shell command

[jira] [Created] (HBASE-24527) Improve region housekeeping status observability

2020-06-09 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-24527: --- Summary: Improve region housekeeping status observability Key: HBASE-24527 URL: https://issues.apache.org/jira/browse/HBASE-24527 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #1670: HBASE-24337 Backport HBASE-23968 to branch-2

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1670: URL: https://github.com/apache/hbase/pull/1670#issuecomment-641632737 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase-operator-tools] ndimiduk commented on a change in pull request #64: HBASE-23927 recommit the fix with updates for PR review feedback

2020-06-09 Thread GitBox
ndimiduk commented on a change in pull request #64: URL: https://github.com/apache/hbase-operator-tools/pull/64#discussion_r437772726 ## File path: hbase-hbck2/src/test/java/org/apache/hbase/TestHBCK2.java ## @@ -70,6 +73,8 @@ private static final TableName TABLE_NAME =

[GitHub] [hbase] Apache-HBase commented on pull request #1880: HBASE-24144 Update docs from master

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1880: URL: https://github.com/apache/hbase/pull/1880#issuecomment-641627049 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #1880: HBASE-24144 Update docs from master

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1880: URL: https://github.com/apache/hbase/pull/1880#issuecomment-641626709 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-09 Thread GitBox
saintstack commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-641626808 FlushPolicy does seem to cut across what you are trying to do here where you only flush a subset even though reading the original issue, it seems to be trying to do subset

[GitHub] [hbase-operator-tools] clarax commented on pull request #61: taking one or more files for regions for assigns

2020-06-09 Thread GitBox
clarax commented on pull request #61: URL: https://github.com/apache/hbase-operator-tools/pull/61#issuecomment-641625372 > Please pull the cleanup into its own PR Thank you. Closed and opened a new PR https://github.com/apache/hbase-operator-tools/pull/64

[GitHub] [hbase] saintstack commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-09 Thread GitBox
saintstack commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r437769058 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java ## @@ -58,8 +60,8 @@ protected void scheduleFlush(String

[jira] [Work started] (HBASE-24144) Update docs from master

2020-06-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24144 started by Nick Dimiduk. > Update docs from master > --- > > Key:

[GitHub] [hbase-operator-tools] clarax opened a new pull request #64: HBASE-23927 recommit the fix with updates for PR review feedback

2020-06-09 Thread GitBox
clarax opened a new pull request #64: URL: https://github.com/apache/hbase-operator-tools/pull/64 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] ndimiduk opened a new pull request #1880: HBASE-24144 Update docs from master

2020-06-09 Thread GitBox
ndimiduk opened a new pull request #1880: URL: https://github.com/apache/hbase/pull/1880 Bring back documentation from master branch (9ef17c2784), using ``` $ git checkout master -- src/main/asciidoc/ $ git checkout master -- src/site/asciidoc/ ``` Followed up with a

[jira] [Commented] (HBASE-24444) Should shutdown mini cluster after class in TestMetaAssignmentWithStopMaster

2020-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129865#comment-17129865 ] Hudson commented on HBASE-2: Results for branch branch-2.2 [build #889 on

[jira] [Commented] (HBASE-24117) Shutdown AssignmentManager before ProcedureExecutor may cause SCP to accidentally skip assigning a region

2020-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129867#comment-17129867 ] Hudson commented on HBASE-24117: Results for branch branch-2.2 [build #889 on

[jira] [Commented] (HBASE-24367) ScheduledChore log elapsed timespan in a human-friendly format

2020-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129868#comment-17129868 ] Hudson commented on HBASE-24367: Results for branch branch-2.2 [build #889 on

[jira] [Commented] (HBASE-24517) AssignmentManager.start should add meta region to ServerStateNode

2020-06-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129866#comment-17129866 ] Hudson commented on HBASE-24517: Results for branch branch-2.2 [build #889 on

[jira] [Commented] (HBASE-18659) Use HDFS ACL to give user the ability to read snapshot directly on HDFS

2020-06-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129863#comment-17129863 ] Nick Dimiduk commented on HBASE-18659: -- Looks like this has basically been implemented and applied

[jira] [Updated] (HBASE-22625) documet use scan snapshot feature

2020-06-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-22625: - Fix Version/s: 3.0.0-alpha-1 > documet use scan snapshot feature >

[jira] [Resolved] (HBASE-24005) Document maven invocation with JDK11

2020-06-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24005. -- Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed > Document maven invocation with JDK11

[GitHub] [hbase] ndimiduk commented on pull request #1871: HBASE-24005 Document maven invocation with JDK11

2020-06-09 Thread GitBox
ndimiduk commented on pull request #1871: URL: https://github.com/apache/hbase/pull/1871#issuecomment-641616500 Thanks for the reviews! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] ndimiduk merged pull request #1871: HBASE-24005 Document maven invocation with JDK11

2020-06-09 Thread GitBox
ndimiduk merged pull request #1871: URL: https://github.com/apache/hbase/pull/1871 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase-operator-tools] huaxiangsun merged pull request #63: Revert "HBASE-23927 HBCK takes one or more files for assigns"

2020-06-09 Thread GitBox
huaxiangsun merged pull request #63: URL: https://github.com/apache/hbase-operator-tools/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-641614369 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-641612849 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase-operator-tools] huaxiangsun opened a new pull request #63: Revert "HBASE-23927 HBCK takes one or more files for assigns"

2020-06-09 Thread GitBox
huaxiangsun opened a new pull request #63: URL: https://github.com/apache/hbase-operator-tools/pull/63 Reverts apache/hbase-operator-tools#62 because no correct jira info is in the commit message. This is an automated

[GitHub] [hbase-operator-tools] huaxiangsun commented on pull request #62: HBASE-23927 HBCK takes one or more files for assigns

2020-06-09 Thread GitBox
huaxiangsun commented on pull request #62: URL: https://github.com/apache/hbase-operator-tools/pull/62#issuecomment-641611553 Sorry @busbey, did not notice that jira id is missing. I will revert and ask @clarax to resubmit the patch with correct jira info.

[jira] [Commented] (HBASE-12187) Review in source the paper "Simple Testing Can Prevent Most Critical Failures"

2020-06-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129842#comment-17129842 ] Michael Stack commented on HBASE-12187: --- 2.4.0 was released 11 days ago

[GitHub] [hbase] bharathv commented on a change in pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
bharathv commented on a change in pull request #1879: URL: https://github.com/apache/hbase/pull/1879#discussion_r437747899 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java ## @@ -66,8 +66,14 @@ public

[GitHub] [hbase] apurtell commented on pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
apurtell commented on pull request #1879: URL: https://github.com/apache/hbase/pull/1879#issuecomment-641601976 Another update to fix checkstyle nits. This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] apurtell commented on pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
apurtell commented on pull request #1879: URL: https://github.com/apache/hbase/pull/1879#issuecomment-641601299 @bharathv I attempted to address your feedback with comments. Please let me know if this works for you or if more should be done.

[GitHub] [hbase] Apache-HBase commented on pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1879: URL: https://github.com/apache/hbase/pull/1879#issuecomment-641601238 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-641597316 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] apurtell commented on a change in pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
apurtell commented on a change in pull request #1879: URL: https://github.com/apache/hbase/pull/1879#discussion_r437738544 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestHQuorumPeer.java ## @@ -111,25 +115,39 @@ QuorumPeerConfig config =

[GitHub] [hbase] apurtell commented on a change in pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
apurtell commented on a change in pull request #1879: URL: https://github.com/apache/hbase/pull/1879#discussion_r437738171 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java ## @@ -85,14 +85,20 @@ public static void main(String[] args)

[GitHub] [hbase] apurtell commented on a change in pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
apurtell commented on a change in pull request #1879: URL: https://github.com/apache/hbase/pull/1879#discussion_r437737505 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java ## @@ -85,14 +85,20 @@ public static void main(String[] args)

[GitHub] [hbase] apurtell commented on a change in pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
apurtell commented on a change in pull request #1879: URL: https://github.com/apache/hbase/pull/1879#discussion_r437737134 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java ## @@ -66,8 +66,14 @@ public

[GitHub] [hbase] apurtell commented on a change in pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
apurtell commented on a change in pull request #1879: URL: https://github.com/apache/hbase/pull/1879#discussion_r437737134 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java ## @@ -66,8 +66,14 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #1871: HBASE-24005 Document maven invocation with JDK11

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1871: URL: https://github.com/apache/hbase/pull/1871#issuecomment-641584181 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-12187) Review in source the paper "Simple Testing Can Prevent Most Critical Failures"

2020-06-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129804#comment-17129804 ] Michael Stack commented on HBASE-12187: --- We are currently on 2.3.4. Could update. > Review in

[GitHub] [hbase] Apache-HBase commented on pull request #1871: HBASE-24005 Document maven invocation with JDK11

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1871: URL: https://github.com/apache/hbase/pull/1871#issuecomment-641566105 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-09 Thread GitBox
ndimiduk commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r437717024 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCacheWithDifferentWorkingDir.java ## @@ -0,0 +1,64 @@

[GitHub] [hbase] Apache-HBase commented on pull request #1871: HBASE-24005 Document maven invocation with JDK11

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1871: URL: https://github.com/apache/hbase/pull/1871#issuecomment-641565361 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24510) Remove HBaseTestCase and GenericTestUtils

2020-06-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129794#comment-17129794 ] Nick Dimiduk commented on HBASE-24510: -- bq. IIRC the assumption is, the code under test directory

[GitHub] [hbase] ndimiduk commented on a change in pull request #1871: HBASE-24005 Document maven invocation with JDK11

2020-06-09 Thread GitBox
ndimiduk commented on a change in pull request #1871: URL: https://github.com/apache/hbase/pull/1871#discussion_r437707270 ## File path: src/main/asciidoc/_chapters/developer.adoc ## @@ -397,28 +396,109 @@ mvn clean install -DskipTests See the <> section in <>

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-641558578 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-641556810 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-12187) Review in source the paper "Simple Testing Can Prevent Most Critical Failures"

2020-06-09 Thread Ding Yuan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129775#comment-17129775 ] Ding Yuan commented on HBASE-12187: --- [~mattf] the empty catch block rule is now part of [error-prone's

[jira] [Commented] (HBASE-24523) Include target hostname/ip/port in `ipc.ServerNotRunningYetException`

2020-06-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129774#comment-17129774 ] Nick Dimiduk commented on HBASE-24523: -- I am not. Please help yourself. > Include target

[GitHub] [hbase-operator-tools] ndimiduk commented on a change in pull request #62: HBCK takes one or more files for assigns

2020-06-09 Thread GitBox
ndimiduk commented on a change in pull request #62: URL: https://github.com/apache/hbase-operator-tools/pull/62#discussion_r437699655 ## File path: hbase-hbck2/src/test/java/org/apache/hbase/TestHBCK2.java ## @@ -266,6 +277,29 @@ public void

[jira] [Commented] (HBASE-24526) Deadlock executing assign meta procedure

2020-06-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129770#comment-17129770 ] Michael Stack commented on HBASE-24526: --- These went in last night; seem related: {code} commit

[jira] [Updated] (HBASE-24367) ScheduledChore log elapsed timespan in a human-friendly format

2020-06-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24367: - Fix Version/s: (was: 2.4.0) (was: 2.3.3) 2.3.0 >

[jira] [Updated] (HBASE-24521) Reenable the TestExportSnapshot family of tests

2020-06-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24521: - Affects Version/s: 2.3.0 3.0.0-alpha-1 > Reenable the TestExportSnapshot

[jira] [Commented] (HBASE-24521) Reenable the TestExportSnapshot family of tests

2020-06-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129769#comment-17129769 ] Nick Dimiduk commented on HBASE-24521: -- Filed a ticket back with YARN to see about getting things

[jira] [Commented] (HBASE-24526) Deadlock executing assign meta procedure

2020-06-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129760#comment-17129760 ] Nick Dimiduk commented on HBASE-24526: -- I have a couple observations, I propose each here for

[jira] [Commented] (HBASE-24526) Deadlock executing assign meta procedure

2020-06-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129756#comment-17129756 ] Nick Dimiduk commented on HBASE-24526: -- bq. Is there reason to believe this is new for 2.3, or we

[GitHub] [hbase] bharathv commented on a change in pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
bharathv commented on a change in pull request #1879: URL: https://github.com/apache/hbase/pull/1879#discussion_r437681253 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java ## @@ -85,14 +85,20 @@ public static void main(String[] args)

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-641538051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24526) Deadlock executing assign meta procedure

2020-06-09 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129749#comment-17129749 ] Sean Busbey commented on HBASE-24526: - Is there reason to believe this is new for 2.3, or we just

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2020-06-09 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-641521867 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24526) Deadlock executing assign meta procedure

2020-06-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24526: - Description: I have what appears to be a deadlock while assigning meta. During recovery,

[jira] [Created] (HBASE-24526) Deadlock executing assign meta procedure

2020-06-09 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24526: Summary: Deadlock executing assign meta procedure Key: HBASE-24526 URL: https://issues.apache.org/jira/browse/HBASE-24526 Project: HBase Issue Type: Bug

[GitHub] [hbase] apurtell commented on a change in pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
apurtell commented on a change in pull request #1879: URL: https://github.com/apache/hbase/pull/1879#discussion_r437643117 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java ## @@ -1811,9 +1811,10 @@ private static Op

[GitHub] [hbase] apurtell commented on a change in pull request #1879: HBASE-24525 [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread GitBox
apurtell commented on a change in pull request #1879: URL: https://github.com/apache/hbase/pull/1879#discussion_r437643393 ## File path: hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon ## @@ -294,7 +294,7 @@ AssignmentManager

[jira] [Updated] (HBASE-24525) [branch-1] Support ZooKeeper 3.6.0+

2020-06-09 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24525: Status: Patch Available (was: Open) PR https://github.com/apache/hbase/pull/1879

  1   2   3   >