[GitHub] [hbase] Apache-HBase commented on pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1552: URL: https://github.com/apache/hbase/pull/1552#issuecomment-643080706 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread GitBox
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-643076776 The ut failture on jdk8 seems not related to this PR. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #1881: HBASE-24529 hbase.rs.evictblocksonclose is not honored when removing …

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1881: URL: https://github.com/apache/hbase/pull/1881#issuecomment-643073797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-643072872 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1869: HBASE-24518 : waitForNamespaceOnline() should return false if any region is offline

2020-06-11 Thread GitBox
anoopsjohn commented on a change in pull request #1869: URL: https://github.com/apache/hbase/pull/1869#discussion_r439206892 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1285,7 +1285,9 @@ private boolean waitForNamespaceOnline()

[jira] [Commented] (HBASE-24529) hbase.rs.evictblocksonclose is not honored when removing compacted files and closing the storefiles

2020-06-11 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133919#comment-17133919 ] Toshihiro Suzuki commented on HBASE-24529: -- [~anoop.hbase] Thank you for the clarification. I

[GitHub] [hbase] brfrn169 commented on a change in pull request #1881: HBASE-24529 hbase.rs.evictblocksonclose is not honored when removing …

2020-06-11 Thread GitBox
brfrn169 commented on a change in pull request #1881: URL: https://github.com/apache/hbase/pull/1881#discussion_r439204094 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -2741,7 +2741,8 @@ private void

[GitHub] [hbase] Apache9 commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-11 Thread GitBox
Apache9 commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-643058209 > `The point here is when do you want to do this? In normal single read/write path, we just need to locate a single region. And for scanning, we need to locate to the next region

[jira] [Created] (HBASE-24544) Recommend upping zk jute.maxbuffer in all but minor installs

2020-06-11 Thread Michael Stack (Jira)
Michael Stack created HBASE-24544: - Summary: Recommend upping zk jute.maxbuffer in all but minor installs Key: HBASE-24544 URL: https://issues.apache.org/jira/browse/HBASE-24544 Project: HBase

[GitHub] [hbase] Apache9 commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-11 Thread GitBox
Apache9 commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-643056999 > Trying to discuss to understand what is here, the direction, and to avoid having to do this explicitly. We have loads of experience in this area. The answer to suggestions or

[jira] [Commented] (HBASE-24189) WALSplit recreates region dirs for deleted table with recovered edits data

2020-06-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133909#comment-17133909 ] Hudson commented on HBASE-24189: Results for branch branch-2 [build #2703 on

[GitHub] [hbase] saintstack commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-11 Thread GitBox
saintstack commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-643055266 `The point here is when do you want to do this? In normal single read/write path, we just need to locate a single region. And for scanning, we need to locate to the next

[GitHub] [hbase] saintstack commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-11 Thread GitBox
saintstack commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-643052700 `To be honest, I do not fully get your point on why we need to stick on the RegionLocator interface. ` This is not my point. My point is re-use known API or Interfaces

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1881: HBASE-24529 hbase.rs.evictblocksonclose is not honored when removing …

2020-06-11 Thread GitBox
anoopsjohn commented on a change in pull request #1881: URL: https://github.com/apache/hbase/pull/1881#discussion_r439193707 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -2741,7 +2741,8 @@ private void

[jira] [Commented] (HBASE-24529) hbase.rs.evictblocksonclose is not honored when removing compacted files and closing the storefiles

2020-06-11 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133900#comment-17133900 ] Anoop Sam John commented on HBASE-24529: Sorry [~brfrn169], I was not so clear on one comment.

[GitHub] [hbase] Apache-HBase commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-643047660 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-643045429 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] busbey commented on pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-11 Thread GitBox
busbey commented on pull request #1620: URL: https://github.com/apache/hbase/pull/1620#issuecomment-643025027 > I'd like to try this out from a vagrant/VirtualBox vm, instead of going to GCE. thoughts? I do not know of any reason that would not work. I only did GCE because Stack's

[GitHub] [hbase] busbey commented on a change in pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-11 Thread GitBox
busbey commented on a change in pull request #1620: URL: https://github.com/apache/hbase/pull/1620#discussion_r439169131 ## File path: dev-support/create-release/mac-sshd-gpg-agent/Dockerfile ## @@ -0,0 +1,100 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [hbase] busbey commented on a change in pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-11 Thread GitBox
busbey commented on a change in pull request #1620: URL: https://github.com/apache/hbase/pull/1620#discussion_r439168692 ## File path: dev-support/create-release/do-release-docker.sh ## @@ -162,15 +219,15 @@ GIT_NAME=$GIT_NAME GIT_EMAIL=$GIT_EMAIL GPG_KEY=$GPG_KEY

[GitHub] [hbase] busbey commented on a change in pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-11 Thread GitBox
busbey commented on a change in pull request #1620: URL: https://github.com/apache/hbase/pull/1620#discussion_r439168475 ## File path: dev-support/create-release/README.txt ## @@ -37,15 +47,53 @@ $ sudo add-apt-repository -y \ stable" $ sudo apt-get update $ sudo apt-get

[GitHub] [hbase] busbey commented on a change in pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-11 Thread GitBox
busbey commented on a change in pull request #1620: URL: https://github.com/apache/hbase/pull/1620#discussion_r439168143 ## File path: dev-support/create-release/README.txt ## @@ -37,15 +47,53 @@ $ sudo add-apt-repository -y \ stable" $ sudo apt-get update $ sudo apt-get

[jira] [Commented] (HBASE-24529) hbase.rs.evictblocksonclose is not honored when removing compacted files and closing the storefiles

2020-06-11 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133818#comment-17133818 ] Toshihiro Suzuki commented on HBASE-24529: -- [~anoop.hbase] I reverted the change to the first

[GitHub] [hbase] Apache-HBase commented on pull request #1890: HBASE-24535: Tweak the master registry docs for branch-2

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1890: URL: https://github.com/apache/hbase/pull/1890#issuecomment-643001254 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1890: HBASE-24535: Tweak the master registry docs for branch-2

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1890: URL: https://github.com/apache/hbase/pull/1890#issuecomment-642993132 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1890: HBASE-24535: Tweak the master registry docs for branch-2

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1890: URL: https://github.com/apache/hbase/pull/1890#issuecomment-642992895 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bharathv commented on pull request #1888: HBASE-24535: Tweak the master registry docs for branch-2

2020-06-11 Thread GitBox
bharathv commented on pull request #1888: URL: https://github.com/apache/hbase/pull/1888#issuecomment-642990727 Closing in favor of #1890 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] bharathv opened a new pull request #1890: HBASE-24535: Tweak the master registry docs for branch-2

2020-06-11 Thread GitBox
bharathv opened a new pull request #1890: URL: https://github.com/apache/hbase/pull/1890 Updated to include changes in HBASE-24265 and some rewording to make it version agnostic. This is an automated message from the

[GitHub] [hbase] bharathv closed pull request #1888: HBASE-24535: Tweak the master registry docs for branch-2

2020-06-11 Thread GitBox
bharathv closed pull request #1888: URL: https://github.com/apache/hbase/pull/1888 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] bharathv commented on pull request #1888: HBASE-24535: Tweak the master registry docs for branch-2

2020-06-11 Thread GitBox
bharathv commented on pull request #1888: URL: https://github.com/apache/hbase/pull/1888#issuecomment-642986426 Sure, let me do that and add you. This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (HBASE-24543) ScheduledChore logging is too chatty, replace with metrics

2020-06-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24543: Description: ScheduledChore logs at DEBUG level the execution time of each chore.

[jira] [Created] (HBASE-24543) ScheduledChore logging is too chatty, replace with metrics

2020-06-11 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-24543: --- Summary: ScheduledChore logging is too chatty, replace with metrics Key: HBASE-24543 URL: https://issues.apache.org/jira/browse/HBASE-24543 Project:

[jira] [Commented] (HBASE-24532) Execute region plans with throttle should return succeeded plans

2020-06-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133760#comment-17133760 ] Hudson commented on HBASE-24532: Results for branch branch-2.2 [build #891 on

[GitHub] [hbase] Apache-HBase commented on pull request #1860: HBASE-24380 : Provide WAL splitting journal logging

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1860: URL: https://github.com/apache/hbase/pull/1860#issuecomment-642961114 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1860: HBASE-24380 : Provide WAL splitting journal logging

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1860: URL: https://github.com/apache/hbase/pull/1860#issuecomment-642958552 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-24528) Improve balancer decision observability

2020-06-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133734#comment-17133734 ] Andrew Kyle Purtell edited comment on HBASE-24528 at 6/11/20, 10:07 PM:

[GitHub] [hbase] ndimiduk commented on a change in pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-11 Thread GitBox
ndimiduk commented on a change in pull request #1620: URL: https://github.com/apache/hbase/pull/1620#discussion_r439096517 ## File path: dev-support/create-release/mac-sshd-gpg-agent/Dockerfile ## @@ -0,0 +1,100 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (HBASE-24528) Improve balancer decision observability

2020-06-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133734#comment-17133734 ] Andrew Kyle Purtell commented on HBASE-24528: - For example: - For the slow log case, can we

[jira] [Commented] (HBASE-24528) Improve balancer decision observability

2020-06-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133726#comment-17133726 ] Andrew Kyle Purtell commented on HBASE-24528: - If we are going to discuss this let’s not use

[jira] [Updated] (HBASE-23927) hbck2 assigns command should accept a file containing a list of region names

2020-06-11 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clara Xiong updated HBASE-23927: Release Note: This adds a new option -i or --inputFile to assigns function to allow one or more

[jira] [Resolved] (HBASE-24534) Delete reference off to Hadoop wiki's HBase FAQ

2020-06-11 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24534. -- Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed > Delete reference off to Hadoop wiki's

[GitHub] [hbase] ndimiduk commented on pull request #1887: HBASE-24534 Delete reference off to Hadoop wiki's HBase FAQ

2020-06-11 Thread GitBox
ndimiduk commented on pull request #1887: URL: https://github.com/apache/hbase/pull/1887#issuecomment-642933582 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] ndimiduk merged pull request #1887: HBASE-24534 Delete reference off to Hadoop wiki's HBase FAQ

2020-06-11 Thread GitBox
ndimiduk merged pull request #1887: URL: https://github.com/apache/hbase/pull/1887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (HBASE-24542) Update anonymous git url on website

2020-06-11 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24542: Summary: Update anonymous git url on website Key: HBASE-24542 URL: https://issues.apache.org/jira/browse/HBASE-24542 Project: HBase Issue Type: Task

[jira] [Commented] (HBASE-24532) Execute region plans with throttle should return succeeded plans

2020-06-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133693#comment-17133693 ] Hudson commented on HBASE-24532: Results for branch branch-2 [build #2702 on

[jira] [Commented] (HBASE-24528) Improve balancer decision observability

2020-06-11 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133685#comment-17133685 ] Nick Dimiduk commented on HBASE-24528: -- I'm not a fan of standing up these ring buffers everywhere.

[jira] [Commented] (HBASE-24528) Improve balancer decision observability

2020-06-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133684#comment-17133684 ] Andrew Kyle Purtell commented on HBASE-24528: - Ok, so either way we develop on branch-2 and

[jira] [Commented] (HBASE-24528) Improve balancer decision observability

2020-06-11 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133683#comment-17133683 ] Nick Dimiduk commented on HBASE-24528: -- bq. On the other hand a RM might have objection to such a

[GitHub] [hbase] Apache-HBase commented on pull request #1860: HBASE-24380 : Provide WAL splitting journal logging

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1860: URL: https://github.com/apache/hbase/pull/1860#issuecomment-642924574 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24539) Fix the classpath for the local mini-cluster

2020-06-11 Thread Marc Parisi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133642#comment-17133642 ] Marc Parisi commented on HBASE-24539: - perfect [~bharathv]  ! Will take a look, thanks! > Fix the

[jira] [Commented] (HBASE-24539) Fix the classpath for the local mini-cluster

2020-06-11 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133640#comment-17133640 ] Bharath Vissapragada commented on HBASE-24539: -- [~phrocker] I already had a patch for this,

[GitHub] [hbase-native-client] bharathv commented on pull request #4: HBASE-24539: Fix the classpath for mini-cluster

2020-06-11 Thread GitBox
bharathv commented on pull request #4: URL: https://github.com/apache/hbase-native-client/pull/4#issuecomment-642894184 @phrocker FYI This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase-native-client] bharathv opened a new pull request #4: HBASE-24539: Fix the classpath for mini-cluster

2020-06-11 Thread GitBox
bharathv opened a new pull request #4: URL: https://github.com/apache/hbase-native-client/pull/4 Fixes the classpath and HBaseTestingUtility c'tor invocation. Promoted some local JNI refs to global to avoid GC cleaning them up. Tested locally with a single unit-test that can

[jira] [Resolved] (HBASE-24400) Automatically download CMake Dependencies

2020-06-11 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada resolved HBASE-24400. -- Fix Version/s: master Resolution: Fixed > Automatically download CMake

[GitHub] [hbase] Apache-HBase commented on pull request #1889: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1889: URL: https://github.com/apache/hbase/pull/1889#issuecomment-642887661 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase-native-client] bharathv closed pull request #3: HBASE-24400: Download folly, wangle, zookeeper, and protobuf

2020-06-11 Thread GitBox
bharathv closed pull request #3: URL: https://github.com/apache/hbase-native-client/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase-native-client] bharathv commented on pull request #3: HBASE-24400: Download folly, wangle, zookeeper, and protobuf

2020-06-11 Thread GitBox
bharathv commented on pull request #3: URL: https://github.com/apache/hbase-native-client/pull/3#issuecomment-642887361 Pushed to master. Thanks. This is an automated message from the Apache Git Service. To respond to the

[jira] [Comment Edited] (HBASE-24528) Improve balancer decision observability

2020-06-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133627#comment-17133627 ] Andrew Kyle Purtell edited comment on HBASE-24528 at 6/11/20, 7:33 PM:

[jira] [Commented] (HBASE-24528) Improve balancer decision observability

2020-06-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133627#comment-17133627 ] Andrew Kyle Purtell commented on HBASE-24528: - IS.Private means we can change the

[GitHub] [hbase] Apache-HBase commented on pull request #1860: HBASE-24380 : Provide WAL splitting journal logging

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1860: URL: https://github.com/apache/hbase/pull/1860#issuecomment-642877842 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on a change in pull request #1869: HBASE-24518 : waitForNamespaceOnline() should return false if any region is offline

2020-06-11 Thread GitBox
virajjasani commented on a change in pull request #1869: URL: https://github.com/apache/hbase/pull/1869#discussion_r438996904 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1285,7 +1285,9 @@ private boolean waitForNamespaceOnline()

[GitHub] [hbase] joshelser commented on pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2020-06-11 Thread GitBox
joshelser commented on pull request #746: URL: https://github.com/apache/hbase/pull/746#issuecomment-642860417 @Apache9 shout if you have any issues, please. Otherwise, I'll come back and merge this. This is an automated

[GitHub] [hbase] joshelser commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2020-06-11 Thread GitBox
joshelser commented on a change in pull request #746: URL: https://github.com/apache/hbase/pull/746#discussion_r438992500 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java ## @@ -270,39 +267,23 @@ public void unbuffer() {

[GitHub] [hbase] Apache-HBase commented on pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1825: URL: https://github.com/apache/hbase/pull/1825#issuecomment-642843923 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1825: URL: https://github.com/apache/hbase/pull/1825#issuecomment-642838886 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23340) hmaster /hbase/replication/rs session expired (hbase replication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in old

2020-06-11 Thread Chao Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133525#comment-17133525 ] Chao Wang commented on HBASE-23340: --- yes,I can > hmaster /hbase/replication/rs session expired

[GitHub] [hbase] apurtell commented on a change in pull request #1860: HBASE-24380 : Provide WAL splitting journal logging

2020-06-11 Thread GitBox
apurtell commented on a change in pull request #1860: URL: https://github.com/apache/hbase/pull/1860#discussion_r438943247 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RecoveredEditsOutputSink.java ## @@ -52,15 +53,16 @@ public

[GitHub] [hbase] ndimiduk commented on pull request #1888: HBASE-24535: Tweak the master registry docs for branch-2

2020-06-11 Thread GitBox
ndimiduk commented on pull request #1888: URL: https://github.com/apache/hbase/pull/1888#issuecomment-642820241 Thanks, taking a look later this morning. This is an automated message from the Apache Git Service. To respond

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1869: HBASE-24518 : waitForNamespaceOnline() should return false if any region is offline

2020-06-11 Thread GitBox
anoopsjohn commented on a change in pull request #1869: URL: https://github.com/apache/hbase/pull/1869#discussion_r438941753 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1285,7 +1285,9 @@ private boolean waitForNamespaceOnline()

[jira] [Commented] (HBASE-24520) Change the IA for MutableSizeHistogram and MutableTimeHistogram

2020-06-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133426#comment-17133426 ] Andrew Kyle Purtell commented on HBASE-24520: - The thread has picked up replies and poses

[GitHub] [hbase] Apache-HBase commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-642808990 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-24380) Improve WAL splitting log lines to enable sessionization

2020-06-11 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133176#comment-17133176 ] Viraj Jasani edited comment on HBASE-24380 at 6/11/20, 4:35 PM:

[jira] [Commented] (HBASE-23990) [Flakey Tests] TestSecureExport.testVisibilityLabels fails with SaslException

2020-06-11 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133369#comment-17133369 ] Josh Elser commented on HBASE-23990: Looks like in master, we have a different failure happenign

[jira] [Commented] (HBASE-24520) Change the IA for MutableSizeHistogram and MutableTimeHistogram

2020-06-11 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133364#comment-17133364 ] Josh Elser commented on HBASE-24520: Just replied on the thread – a quick glance makes me think you

[GitHub] [hbase] anoopsjohn merged pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-11 Thread GitBox
anoopsjohn merged pull request #1825: URL: https://github.com/apache/hbase/pull/1825 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1825: URL: https://github.com/apache/hbase/pull/1825#issuecomment-642761560 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-8458) Support for batch version of checkAndMutate()

2020-06-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133358#comment-17133358 ] Hudson commented on HBASE-8458: --- Results for branch master [build #1754 on

[GitHub] [hbase] Apache-HBase commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-642754292 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] anoopsjohn opened a new pull request #1889: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-11 Thread GitBox
anoopsjohn opened a new pull request #1889: URL: https://github.com/apache/hbase/pull/1889 …overed edits data. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (HBASE-24541) Add support to run LoadIncrementalHFiles in a distributed manner

2020-06-11 Thread Constantin-Catalin Luca (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Constantin-Catalin Luca updated HBASE-24541: Attachment: HBASE_24541-1.4.0.patch Status: Patch Available (was:

[GitHub] [hbase] Apache-HBase commented on pull request #1881: HBASE-24529 hbase.rs.evictblocksonclose is not honored when removing …

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1881: URL: https://github.com/apache/hbase/pull/1881#issuecomment-642682669 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-24541) Add support to run LoadIncrementalHFiles in a distributed manner

2020-06-11 Thread Constantin-Catalin Luca (Jira)
Constantin-Catalin Luca created HBASE-24541: --- Summary: Add support to run LoadIncrementalHFiles in a distributed manner Key: HBASE-24541 URL: https://issues.apache.org/jira/browse/HBASE-24541

[GitHub] [hbase] Apache-HBase commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-642665704 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] songxincun edited a comment on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-06-11 Thread GitBox
songxincun edited a comment on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-642653665 > hi @songxincun. Thanks for your contributing. Please fix similar usages in

[GitHub] [hbase] songxincun commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-06-11 Thread GitBox
songxincun commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-642653665 > hi @songxincun. Thanks for your contributing. Please fix similar usages in

[GitHub] [hbase] bsglz commented on a change in pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread GitBox
bsglz commented on a change in pull request #1337: URL: https://github.com/apache/hbase/pull/1337#discussion_r438769700 ## File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp ## @@ -227,6 +227,9 @@ if (fqtn != null && master.isInitialized()) {

[jira] [Updated] (HBASE-24532) Execute region plans with throttle should return succeeded plans

2020-06-11 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24532: - Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch

[jira] [Comment Edited] (HBASE-24528) Improve balancer decision observability

2020-06-11 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133174#comment-17133174 ] Viraj Jasani edited comment on HBASE-24528 at 6/11/20, 12:58 PM: - All

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-642623974 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani merged pull request #1884: HBASE-24532 : Execute region plans with throttle should return succeeded plans

2020-06-11 Thread GitBox
virajjasani merged pull request #1884: URL: https://github.com/apache/hbase/pull/1884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-11 Thread GitBox
anoopsjohn commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r438696429 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSourceImpl.java ## @@ -311,6 +322,27 @@ void

[GitHub] [hbase] Apache-HBase commented on pull request #1881: HBASE-24529 hbase.rs.evictblocksonclose is not honored when removing …

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1881: URL: https://github.com/apache/hbase/pull/1881#issuecomment-642616006 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on a change in pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread GitBox
bsglz commented on a change in pull request #1337: URL: https://github.com/apache/hbase/pull/1337#discussion_r438737311 ## File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp ## @@ -227,6 +227,9 @@ if (fqtn != null && master.isInitialized()) {

[GitHub] [hbase] bsglz commented on a change in pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread GitBox
bsglz commented on a change in pull request #1337: URL: https://github.com/apache/hbase/pull/1337#discussion_r438740260 ## File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp ## @@ -227,6 +227,9 @@ if (fqtn != null && master.isInitialized()) {

[GitHub] [hbase] bsglz commented on a change in pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread GitBox
bsglz commented on a change in pull request #1337: URL: https://github.com/apache/hbase/pull/1337#discussion_r438737311 ## File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp ## @@ -227,6 +227,9 @@ if (fqtn != null && master.isInitialized()) {

[GitHub] [hbase] wchevreuil commented on a change in pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread GitBox
wchevreuil commented on a change in pull request #1337: URL: https://github.com/apache/hbase/pull/1337#discussion_r438735982 ## File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp ## @@ -227,6 +227,9 @@ if (fqtn != null && master.isInitialized()) {

[jira] [Updated] (HBASE-24038) Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-24038: - Attachment: Screen Shot 2020-06-11 at 13.01.56.png > Add a metric to show the

[GitHub] [hbase] Apache-HBase commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-06-11 Thread GitBox
Apache-HBase commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-642591776 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-11 Thread GitBox
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-642585212 Ping @wchevreuil @virajjasani This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HBASE-24380) Improve WAL splitting log lines to enable sessionization

2020-06-11 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133176#comment-17133176 ] Viraj Jasani commented on HBASE-24380: -- [~apurtell] If you get some bandwidth, please review: 

  1   2   >