[jira] [Updated] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-22 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16665: -- Attachment: HBASE-16665.v1.patch patch v1 deal with createLastOnRow and address [~anoop.hbase]

[jira] [Updated] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-22 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16665: -- Status: Patch Available (was: Open) > Check whether KeyValueUtil.createXXX could be replaced by

[jira] [Commented] (HBASE-16675) Average region size may be incorrect when there is region whose RegionLoad cannot be retrieved

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512022#comment-15512022 ] Heng Chen commented on HBASE-16675: --- +1 > Average region size may be incorrect when there is region

[jira] [Updated] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16665: -- Attachment: HBASE-16665.patch The first patch deal with createFirstOnRow > Check whether

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509251#comment-15509251 ] Heng Chen commented on HBASE-16665: --- Not sure for the two place whether KeyValueUtil.createFirstOnRow

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509227#comment-15509227 ] Heng Chen commented on HBASE-16664: --- {quote} We don't considier rpc timeout any where... {quote} Yes,

[jira] [Updated] (HBASE-16659) Use CellUtil.createFirstOnRow instead of KeyValueUtil.createFirstOnRow in some places.

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16659: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) >

[jira] [Commented] (HBASE-16659) Use CellUtil.createFirstOnRow instead of KeyValueUtil.createFirstOnRow in some places.

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509054#comment-15509054 ] Heng Chen commented on HBASE-16659: --- To be continued in HBASE-16665 > Use CellUtil.createFirstOnRow

[jira] [Created] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-21 Thread Heng Chen (JIRA)
Heng Chen created HBASE-16665: - Summary: Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy Key: HBASE-16665 URL: https://issues.apache.org/jira/browse/HBASE-16665 Project:

[jira] [Commented] (HBASE-16659) Use CellUtil.createFirstOnRow instead of KeyValueUtil.createFirstOnRow in some places.

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509029#comment-15509029 ] Heng Chen commented on HBASE-16659: --- {quote} we can make it to use with out copy. We might need new API

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509008#comment-15509008 ] Heng Chen commented on HBASE-16664: --- yes, the default one in ap is rpcTimeout, but you could see

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508974#comment-15508974 ] Heng Chen commented on HBASE-16664: --- {quote} And AP is complicated so I have not found where is the

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508894#comment-15508894 ] Heng Chen commented on HBASE-16664: --- Let me try it. > Timeout logic in AsyncProcess is broken >

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-20 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508615#comment-15508615 ] Heng Chen commented on HBASE-15921: --- Another thing, currently user could use his own thread pool for

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-20 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508572#comment-15508572 ] Heng Chen commented on HBASE-15921: --- {quote} IMHO, current AP is still blocking although it uses

[jira] [Commented] (HBASE-16652) Figure out performance difference between increment and append

2016-09-20 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508452#comment-15508452 ] Heng Chen commented on HBASE-16652: --- Increment entry size is stable due to it just one long size,

[jira] [Comment Edited] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-20 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508442#comment-15508442 ] Heng Chen edited comment on HBASE-15921 at 9/21/16 2:12 AM: The patch

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-20 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508442#comment-15508442 ] Heng Chen commented on HBASE-15921: --- The patch [~carp84] supplied missed some thing but i think it has

[jira] [Commented] (HBASE-16659) Use CellUtil.createFirstOnRow instead of KeyValueUtil.createFirstOnRow in some places.

2016-09-20 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506245#comment-15506245 ] Heng Chen commented on HBASE-16659: --- It seems KeyValueUtil.createFirstOnRow is used in many places,

[jira] [Comment Edited] (HBASE-16652) Figure out performance difference between increment and append

2016-09-20 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506121#comment-15506121 ] Heng Chen edited comment on HBASE-16652 at 9/20/16 9:17 AM: add time log for

[jira] [Comment Edited] (HBASE-16652) Figure out performance difference between increment and append

2016-09-20 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506121#comment-15506121 ] Heng Chen edited comment on HBASE-16652 at 9/20/16 9:14 AM: add time log for

[jira] [Updated] (HBASE-16652) Figure out performance difference between increment and append

2016-09-20 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16652: -- Attachment: 1.diff add time log for each step in append/increment path, and do tests with PE 3

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-20 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505949#comment-15505949 ] Heng Chen commented on HBASE-15921: --- As for unified "sync scan" with AP, we need to pass AP into

[jira] [Commented] (HBASE-16652) Figure out performance difference between increment and append

2016-09-19 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503102#comment-15503102 ] Heng Chen commented on HBASE-16652: --- Will be back later. > Figure out performance difference between

[jira] [Commented] (HBASE-16652) Figure out performance difference between increment and append

2016-09-19 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502851#comment-15502851 ] Heng Chen commented on HBASE-16652: --- Let me test it again with cache closed. > Figure out

[jira] [Commented] (HBASE-16652) Figure out performance difference between increment and append

2016-09-19 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502816#comment-15502816 ] Heng Chen commented on HBASE-16652: --- En The time comes from server-side, it is only 'get' action

[jira] [Commented] (HBASE-16652) Figure out performance difference between increment and append

2016-09-19 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502811#comment-15502811 ] Heng Chen commented on HBASE-16652: --- Sounds reasonable. > Figure out performance difference between

[jira] [Commented] (HBASE-16652) Figure out performance difference between increment and append

2016-09-19 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502791#comment-15502791 ] Heng Chen commented on HBASE-16652: --- Good question. We could test it, it seems should be faster. >

[jira] [Updated] (HBASE-16652) Figure out performance difference between increment and append

2016-09-19 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16652: -- Attachment: HBASE-16652.patch > Figure out performance difference between increment and append >

[jira] [Commented] (HBASE-16652) Figure out performance difference between increment and append

2016-09-19 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502720#comment-15502720 ] Heng Chen commented on HBASE-16652: --- Found the reason why 'get' in Increment is slower than append.

[jira] [Updated] (HBASE-16652) Figure out performance difference between increment and append

2016-09-19 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16652: -- Attachment: increment_get_profile.png append_get_profile.png > Figure out performance

[jira] [Commented] (HBASE-16652) Figure out performance difference between increment and append

2016-09-19 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502496#comment-15502496 ] Heng Chen commented on HBASE-16652: --- I add time log about 'get' operation, and do test with pe command,

[jira] [Commented] (HBASE-16652) Figure out performance difference between increment and append

2016-09-18 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502322#comment-15502322 ] Heng Chen commented on HBASE-16652: --- Thanks [~yangzhe1991]. As profile shows, the main difference

[jira] [Commented] (HBASE-16652) Figure out performance difference between increment and append

2016-09-18 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502137#comment-15502137 ] Heng Chen commented on HBASE-16652: --- Thanks [~allan163]. Increment has one get and one put too

[jira] [Updated] (HBASE-16652) Figure out performance difference between increment and append

2016-09-18 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16652: -- Attachment: increment.jfr append.jfr server-side profile with JFR, almost looks the

[jira] [Updated] (HBASE-16652) Figure out performance difference between increment and append

2016-09-18 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16652: -- Labels: performance (was: ) > Figure out performance difference between increment and append >

[jira] [Created] (HBASE-16652) Figure out performance difference between increment and append

2016-09-18 Thread Heng Chen (JIRA)
Heng Chen created HBASE-16652: - Summary: Figure out performance difference between increment and append Key: HBASE-16652 URL: https://issues.apache.org/jira/browse/HBASE-16652 Project: HBase

[jira] [Updated] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-16 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16631: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) >

[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-16 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496770#comment-15496770 ] Heng Chen commented on HBASE-16631: --- Timeout test case could pass locally, relates testcase such as

[jira] [Commented] (HBASE-16349) TestClusterId may hang during cluster shutdown

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495347#comment-15495347 ] Heng Chen commented on HBASE-16349: --- +1. Try it. > TestClusterId may hang during cluster shutdown >

[jira] [Comment Edited] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495140#comment-15495140 ] Heng Chen edited comment on HBASE-16631 at 9/16/16 2:20 AM: Create one new

[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495140#comment-15495140 ] Heng Chen commented on HBASE-16631: --- Create one new issue for it, maybe someone has related

[jira] [Updated] (HBASE-16641) QA tests for hbase-client skip the second part.

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16641: -- Description: See

[jira] [Created] (HBASE-16641) QA tests for hbase-client skip the second part.

2016-09-15 Thread Heng Chen (JIRA)
Heng Chen created HBASE-16641: - Summary: QA tests for hbase-client skip the second part. Key: HBASE-16641 URL: https://issues.apache.org/jira/browse/HBASE-16641 Project: HBase Issue Type: Bug

[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494973#comment-15494973 ] Heng Chen commented on HBASE-16631: --- QA use the 'runAllTests' profile. And it looks good to me.

[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494923#comment-15494923 ] Heng Chen commented on HBASE-16631: --- Timeout test case could pass locally, commit with

[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494880#comment-15494880 ] Heng Chen commented on HBASE-16631: --- It is not changed recently, last change for this part is

[jira] [Updated] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16631: -- Attachment: HBASE-16631.v2.patch v2 trigger the secondaryPart tests in hbase-client/pom.xml > Extract

[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493737#comment-15493737 ] Heng Chen commented on HBASE-16631: --- Notice this: hbase-client/pom.xml {code}

[jira] [Commented] (HBASE-16610) Unify append, increment with AP

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493245#comment-15493245 ] Heng Chen commented on HBASE-16610: --- In PE, append size is 26 bytes {code} static class AppendTest

[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493223#comment-15493223 ] Heng Chen commented on HBASE-16626: --- {code} commit 56be3ac7c8d203710f844cd799f2fa3496f0515a Author:

[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493202#comment-15493202 ] Heng Chen commented on HBASE-16631: --- Not in flakey tests. Very weird, it seems everything looks good in

[jira] [Updated] (HBASE-16625) Performance test for interface unified with AP

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16625: -- Attachment: pe_wo_patch_incremnt.log pe_wo_patch_append.log

[jira] [Commented] (HBASE-16610) Unify append, increment with AP

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493150#comment-15493150 ] Heng Chen commented on HBASE-16610: --- Very interesting, for append, after unified with AP, there is

[jira] [Commented] (HBASE-16625) Performance test for interface unified with AP

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493142#comment-15493142 ] Heng Chen commented on HBASE-16625: --- Retest increment, 10 runs for command: {code} bin/hbase

[jira] [Commented] (HBASE-16625) Performance test for interface unified with AP

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493099#comment-15493099 ] Heng Chen commented on HBASE-16625: --- Append Test, 10 runs for command {code} bin/hbase

[jira] [Commented] (HBASE-16381) Shell deleteall command should support row key prefixes

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493036#comment-15493036 ] Heng Chen commented on HBASE-16381: --- Thanks [~easyliangjob] for your patch. Thanks [~jinghe] for your

[jira] [Updated] (HBASE-16381) Shell deleteall command should support row key prefixes

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16381: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) >

[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493028#comment-15493028 ] Heng Chen commented on HBASE-16631: --- Why TestAsyncProcess not be triggered in QA? Do you know the

[jira] [Updated] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16631: -- Attachment: HBASE-16631.v1.patch retry > Extract AsyncRequestFuture related code from AsyncProcess >

[jira] [Comment Edited] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491921#comment-15491921 ] Heng Chen edited comment on HBASE-16631 at 9/15/16 12:43 AM: - {quote} We'll

[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491921#comment-15491921 ] Heng Chen commented on HBASE-16631: --- {quote} We'll probably want to change our Future to subclass

[jira] [Commented] (HBASE-16381) Shell deleteall command should support row key prefixes

2016-09-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491904#comment-15491904 ] Heng Chen commented on HBASE-16381: --- LGTM. +1 Will commit it if no other concerns. > Shell deleteall

[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491896#comment-15491896 ] Heng Chen commented on HBASE-16631: --- There is no logic changed, just split the AP and a little changes

[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490724#comment-15490724 ] Heng Chen commented on HBASE-16631: --- wdyt? [~stack] > Extract AsyncRequestFuture related code from

[jira] [Updated] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16631: -- Status: Patch Available (was: Open) > Extract AsyncRequestFuture related code from AsyncProcess >

[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490683#comment-15490683 ] Heng Chen commented on HBASE-16631: --- With this patch, AsyncProcess has 966 lines, and

[jira] [Updated] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16631: -- Attachment: HBASE-16631.v1.patch > Extract AsyncRequestFuture related code from AsyncProcess >

[jira] [Updated] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess

2016-09-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16631: -- Summary: Extract AsyncRequestFuture related code from AsyncProcess (was: Extract AsyncRequestFuture

[jira] [Updated] (HBASE-16631) Extract AsyncRequestFuture relates code from AsyncProcess

2016-09-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16631: -- Attachment: HBASE-16631.wip.patch > Extract AsyncRequestFuture relates code from AsyncProcess >

[jira] [Updated] (HBASE-16631) Extract AsyncRequestFuture relates code from AsyncProcess

2016-09-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16631: -- Issue Type: Sub-task (was: Bug) Parent: HBASE-16593 > Extract AsyncRequestFuture relates code

[jira] [Updated] (HBASE-16631) Extract AsyncRequestFuture relates code from AsyncProcess

2016-09-14 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16631: -- Description: Now, AsyncProcess class is too large (over 2000+ lines), and there are so many sub

[jira] [Created] (HBASE-16631) Extract AsyncRequestFuture relates code from AsyncProcess

2016-09-14 Thread Heng Chen (JIRA)
Heng Chen created HBASE-16631: - Summary: Extract AsyncRequestFuture relates code from AsyncProcess Key: HBASE-16631 URL: https://issues.apache.org/jira/browse/HBASE-16631 Project: HBase Issue

[jira] [Comment Edited] (HBASE-16381) Shell deleteall command should support row key prefixes

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489035#comment-15489035 ] Heng Chen edited comment on HBASE-16381 at 9/14/16 1:29 AM: {code} + if

[jira] [Commented] (HBASE-16381) Shell deleteall command should support row key prefixes

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489035#comment-15489035 ] Heng Chen commented on HBASE-16381: --- {quote} + if list.size >= 100 + @table.delete(list) +

[jira] [Commented] (HBASE-16625) Performance test for interface unified with AP

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487768#comment-15487768 ] Heng Chen commented on HBASE-16625: --- Test for Increment w/ or w/o patch in HBASE-16610, in standalone

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487675#comment-15487675 ] Heng Chen commented on HBASE-15921: --- After unified, lots of callables could be removed. We could

[jira] [Assigned] (HBASE-16625) Performance test for interface unified with AP

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen reassigned HBASE-16625: - Assignee: Heng Chen > Performance test for interface unified with AP >

[jira] [Updated] (HBASE-16625) Performance test for interface unified with AP

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16625: -- Description: Due to one more thread context changed in AP, the performance should be tested. Let me

[jira] [Commented] (HBASE-16610) Unify append, increment with AP

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486855#comment-15486855 ] Heng Chen commented on HBASE-16610: --- see HBASE-16625 > Unify append, increment with AP >

[jira] [Updated] (HBASE-16625) Performance test for interface unified with AP

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16625: -- Description: Due to one thread context changed in AP, the performance should be tested. Let me do it

[jira] [Created] (HBASE-16625) Performance test for interface unified with AP

2016-09-13 Thread Heng Chen (JIRA)
Heng Chen created HBASE-16625: - Summary: Performance test for interface unified with AP Key: HBASE-16625 URL: https://issues.apache.org/jira/browse/HBASE-16625 Project: HBase Issue Type:

[jira] [Commented] (HBASE-16610) Unify append, increment with AP

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486751#comment-15486751 ] Heng Chen commented on HBASE-16610: --- I will make a performance test for the new interface. Because it

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486670#comment-15486670 ] Heng Chen commented on HBASE-15921: --- Yeah, actually ap not use async rpc stub because it has it's own

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486626#comment-15486626 ] Heng Chen commented on HBASE-15921: --- yeah, AP is complicated but powerful, just need some refactor

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486558#comment-15486558 ] Heng Chen commented on HBASE-15921: --- Awkward! Just notice the issue here. As [~Apache9] said, yes,

[jira] [Updated] (HBASE-16610) Unify append, increment with AP

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16610: -- Attachment: HBASE-16610.v1.patch retry > Unify append, increment with AP >

[jira] [Updated] (HBASE-16611) Flakey org.apache.hadoop.hbase.client.TestReplicasClient.testCancelOfMultiGet

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16611: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) >

[jira] [Updated] (HBASE-16611) Flakey org.apache.hadoop.hbase.client.TestReplicasClient.testCancelOfMultiGet

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16611: -- Fix Version/s: 2.0.0 > Flakey org.apache.hadoop.hbase.client.TestReplicasClient.testCancelOfMultiGet >

[jira] [Commented] (HBASE-16611) Flakey org.apache.hadoop.hbase.client.TestReplicasClient.testCancelOfMultiGet

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486437#comment-15486437 ] Heng Chen commented on HBASE-16611: --- All timeout testcase could pass locally, and TestReplicasClient

[jira] [Commented] (HBASE-16611) Flakey org.apache.hadoop.hbase.client.TestReplicasClient.testCancelOfMultiGet

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486408#comment-15486408 ] Heng Chen commented on HBASE-16611: --- Thanks [~stack] for your review. > Flakey

[jira] [Updated] (HBASE-16592) Unify Delete request with AP

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16592: -- Attachment: HBASE-16592.v3.patch > Unify Delete request with AP > > >

[jira] [Commented] (HBASE-16592) Unify Delete request with AP

2016-09-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486402#comment-15486402 ] Heng Chen commented on HBASE-16592: --- just remove the line in patch v2

[jira] [Commented] (HBASE-16611) Flakey org.apache.hadoop.hbase.client.TestReplicasClient.testCancelOfMultiGet

2016-09-12 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486164#comment-15486164 ] Heng Chen commented on HBASE-16611: --- All timeout testcase could pass locally, and TestReplicasClient

[jira] [Updated] (HBASE-16611) Flakey org.apache.hadoop.hbase.client.TestReplicasClient.testCancelOfMultiGet

2016-09-12 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16611: -- Attachment: HBASE-16611.v2.patch > Flakey

[jira] [Created] (HBASE-16623) Unify Get with AP

2016-09-12 Thread Heng Chen (JIRA)
Heng Chen created HBASE-16623: - Summary: Unify Get with AP Key: HBASE-16623 URL: https://issues.apache.org/jira/browse/HBASE-16623 Project: HBase Issue Type: Sub-task Reporter: Heng

[jira] [Updated] (HBASE-16610) Unify append, increment with AP

2016-09-12 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16610: -- Attachment: HBASE-16610.v1.patch fix findbugs and trigger server tests > Unify append, increment with

[jira] [Updated] (HBASE-16610) Unify append, increment with AP

2016-09-12 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16610: -- Status: Patch Available (was: Open) > Unify append, increment with AP >

[jira] [Updated] (HBASE-16592) Unify Delete request with AP

2016-09-12 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heng Chen updated HBASE-16592: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) >

[jira] [Commented] (HBASE-16592) Unify Delete request with AP

2016-09-12 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485978#comment-15485978 ] Heng Chen commented on HBASE-16592: --- commit it to master with whitespace fixed > Unify Delete request

<    1   2   3   4   5   6   7   8   9   10   >