bbeaudreault merged PR #5591:
URL: https://github.com/apache/hbase/pull/5591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
bbeaudreault commented on code in PR #5591:
URL: https://github.com/apache/hbase/pull/5591#discussion_r1478245286
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java:
##
@@ -234,6 +242,7 @@ public class TableDescriptorBuilder {
bbeaudreault commented on code in PR #5591:
URL: https://github.com/apache/hbase/pull/5591#discussion_r1469690752
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java:
##
@@ -234,6 +242,7 @@ public class TableDescriptorBuilder {
bbeaudreault commented on code in PR #5591:
URL: https://github.com/apache/hbase/pull/5591#discussion_r1469684089
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java:
##
@@ -234,6 +242,7 @@ public class TableDescriptorBuilder {
bbeaudreault commented on code in PR #5591:
URL: https://github.com/apache/hbase/pull/5591#discussion_r1469682877
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java:
##
@@ -234,6 +242,7 @@ public class TableDescriptorBuilder {
Apache9 commented on code in PR #5591:
URL: https://github.com/apache/hbase/pull/5591#discussion_r1469636111
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java:
##
@@ -234,6 +242,7 @@ public class TableDescriptorBuilder {
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909361432
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909357199
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909183769
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
bbeaudreault commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909171517
@NihalJain can you take a look? The guts of the change is the same, but I
had to update much of ErasureCodingUtils to use reflection. The tests have been
updated to work in both
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909148092
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 55s |
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1909122434
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1908883547
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 20s |
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1907359918
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 42s |
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1907358582
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1907152047
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1891049274
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 54s |
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1891048607
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m 20s |
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1890986037
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 29s |
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1863738900
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1863556360
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5591:
URL: https://github.com/apache/hbase/pull/5591#issuecomment-1863542520
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
bbeaudreault opened a new pull request, #5591:
URL: https://github.com/apache/hbase/pull/5591
This is a draft because I expect it to fail for hadoop2. I want to take a
stab at making it work on branch-2, but will need to iterate on some reflection
stuff. Will convert to real once I'm
bbeaudreault commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1863389213
Thank you both for the reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bbeaudreault merged PR #5579:
URL: https://github.com/apache/hbase/pull/5579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1863377152
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1863368305
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
bbeaudreault commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1431852597
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache
jojochuang commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1431834943
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache
jojochuang commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1431834943
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache
jojochuang commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1431834302
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache
NihalJain commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1863123181
> If you don't mind, I might file a new jira for this.
Sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
bbeaudreault commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1863113068
> +1 to the change.
>
> Just realized, we may want to add sample command which sets EC in doc
section of `create.rb` and `alter.rb`. We usually add those for any new feature
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1863098799
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
NihalJain commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1862997997
+1 to the change.
Just realized, we may want to add sample command which sets EC in doc
section of `create.rb` and `alter.rb`. We usually add those for any new feature
that we
bbeaudreault commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1431558036
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java:
##
@@ -70,6 +71,7 @@ public class RestoreSnapshotProcedure
NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1431122568
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java:
##
@@ -70,6 +71,7 @@ public class RestoreSnapshotProcedure
NihalJain commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1862405012
Hi @bbeaudreault added a new comment, please have a look. Otherwise changes
looks good and all previous feedbacks seemed to be covered. Thanks :)
--
This is an automated message from
NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1431132156
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache
NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1431131167
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache
NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1431122568
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java:
##
@@ -70,6 +71,7 @@ public class RestoreSnapshotProcedure
NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1431099222
##
hbase-server/src/main/java/org/apache/hadoop/hbase/fs/ErasureCodingUtils.java:
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1862139602
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1862107094
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1861937353
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1861901463
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1861865851
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1861519591
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
bbeaudreault commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1861432187
Thanks for the review @NihalJain! I believe I covered all of your feedback.
I also made sure it works in the shell @jojochuang.
--
This is an automated message from the Apache Git
bbeaudreault commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1430569902
##
hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java:
##
@@ -184,19 +190,13 @@ public static void sanityCheck(final Configuration
bbeaudreault commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1430563242
##
hbase-server/src/main/java/org/apache/hadoop/hbase/fs/ErasureCodingUtils.java:
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
bbeaudreault commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1430560027
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java:
##
@@ -143,6 +143,14 @@ public class TableDescriptorBuilder {
private
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1859062441
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1859061539
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
NihalJain commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1859050441
Hi @bbeaudreault thanks for the PR, overall looks good. Also have posted a
few questions/reviews. Please let me know of your opinion on same.
--
This is an automated message from the
NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1429032871
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache
NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1429032871
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache
NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1429029998
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactedHFilesDischarger.java:
##
@@ -70,7 +70,7 @@ public CompactedHFilesDischarger(final int
NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1429028180
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java:
##
@@ -143,6 +143,14 @@ public class TableDescriptorBuilder {
private
NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1429026847
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -512,6 +527,23 @@ private void
NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1429026847
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -512,6 +527,23 @@ private void
NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1429026506
##
hbase-server/src/main/java/org/apache/hadoop/hbase/fs/ErasureCodingUtils.java:
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1429025305
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java:
##
@@ -98,6 +99,15 @@ protected Flow executeFromState(final
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1859033192
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
bbeaudreault commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1858644778
Great question! That actually slipped my mind and I will get that working
next week
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1855291046
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1855272554
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1855088738
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1855052992
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1855046902
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5579:
URL: https://github.com/apache/hbase/pull/5579#issuecomment-1854862102
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
bbeaudreault opened a new pull request, #5579:
URL: https://github.com/apache/hbase/pull/5579
Since we require hadoop-3 for master and branch-3, I can use the EC APIs
directly. If we want to backport to branch-2, we'll need to figure out how to
do this with reflection.
--
This is an
72 matches
Mail list logo
