[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356845#comment-15356845
]
Heng Chen commented on HBASE-14279:
---
Thanks for take it up. Please go on. [~ikeda]
> Race condition
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356764#comment-15356764
]
Hadoop QA commented on HBASE-14279:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356599#comment-15356599
]
Hiroshi Ikeda commented on HBASE-14279:
---
bq. If someone want it, open another issue for it.
Oops,
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356521#comment-15356521
]
Hiroshi Ikeda commented on HBASE-14279:
---
I again re-checked and considered how ConcurrentIndex is
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354872#comment-15354872
]
Heng Chen commented on HBASE-14279:
---
The issue pending here so long time. Let me resolve it as
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072528#comment-15072528
]
Hiroshi Ikeda commented on HBASE-14279:
---
The last patch contains a hash function coming from old
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072574#comment-15072574
]
Heng Chen commented on HBASE-14279:
---
{quote}
The last patch contains a hash function coming from old
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072384#comment-15072384
]
Heng Chen commented on HBASE-14279:
---
{quote}
I worry about whether the hash calculation is well
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070375#comment-15070375
]
Hiroshi Ikeda commented on HBASE-14279:
---
I worry about whether the hash calculation is well
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070496#comment-15070496
]
Hiroshi Ikeda commented on HBASE-14279:
---
I misunderstood for some reason and the same thing can be
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070502#comment-15070502
]
Hadoop QA commented on HBASE-14279:
---
{color:green}+1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068374#comment-15068374
]
stack commented on HBASE-14279:
---
What [~ikeda] says... if really copied, thats a problem (CHM is not like
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069350#comment-15069350
]
Hadoop QA commented on HBASE-14279:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067585#comment-15067585
]
Hiroshi Ikeda commented on HBASE-14279:
---
I have second thought about the sentence:
{quote}
+
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067510#comment-15067510
]
Heng Chen commented on HBASE-14279:
---
I need one more +1 before commit.
> Race condition in
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066238#comment-15066238
]
Hadoop QA commented on HBASE-14279:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066325#comment-15066325
]
Heng Chen commented on HBASE-14279:
---
[~ikeda] Thanks for your good suggestions. I update patch.
I use
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067672#comment-15067672
]
Heng Chen commented on HBASE-14279:
---
{quote}
It is better to remove the sentence because of avoiding a
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066425#comment-15066425
]
Hadoop QA commented on HBASE-14279:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066143#comment-15066143
]
Hiroshi Ikeda commented on HBASE-14279:
---
{quote}
Using a concurrent or synchronized set wastes
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998256#comment-14998256
]
Hiroshi Ikeda commented on HBASE-14279:
---
Sorry, these days ConcurrentHashMap seems much more
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998240#comment-14998240
]
Hiroshi Ikeda commented on HBASE-14279:
---
To tell the truth ConcurrentHashMap is more sophisticated
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998353#comment-14998353
]
Hadoop QA commented on HBASE-14279:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996970#comment-14996970
]
stack commented on HBASE-14279:
---
bq. We really need one DataStructure 'multiMapSet'.
Where else we need
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998045#comment-14998045
]
Heng Chen commented on HBASE-14279:
---
{quote}
Where else we need this Heng Chen? KeyLocker?
{quote}
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996278#comment-14996278
]
Heng Chen commented on HBASE-14279:
---
Thanks [~ikeda]. Let's see what the other talk about. [~stack]
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995958#comment-14995958
]
Hiroshi Ikeda commented on HBASE-14279:
---
I'm not sure whether you are creating a class for general
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992097#comment-14992097
]
Hadoop QA commented on HBASE-14279:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993240#comment-14993240
]
Hadoop QA commented on HBASE-14279:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992856#comment-14992856
]
Hiroshi Ikeda commented on HBASE-14279:
---
{code}
public Set values(K key) {
-return
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993063#comment-14993063
]
Heng Chen commented on HBASE-14279:
---
{quote}
Defensively copy under the lock of the segment
{quote}
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993302#comment-14993302
]
Hiroshi Ikeda commented on HBASE-14279:
---
{quote}
Currently there is only one place to call this
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993313#comment-14993313
]
Heng Chen commented on HBASE-14279:
---
{quote}
I think ConcurrentIndex is never appropriate for the
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993241#comment-14993241
]
Hiroshi Ikeda commented on HBASE-14279:
---
{quote}
BucketCache will define sortedSet by itself, so we
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993268#comment-14993268
]
Heng Chen commented on HBASE-14279:
---
{quote}
Is it important to be able to select between hash-set and
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988401#comment-14988401
]
stack commented on HBASE-14279:
---
Can we get the LockedStripedBag into a state where it could be tried in
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988862#comment-14988862
]
Hiroshi Ikeda commented on HBASE-14279:
---
I'm ashamed that I used the word "bag" because I just
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976171#comment-14976171
]
Heng Chen commented on HBASE-14279:
---
Sorry for being late, i think we should see what the others talk
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944386#comment-14944386
]
Hiroshi Ikeda commented on HBASE-14279:
---
You cannot freely use the internal striped locks in the
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944268#comment-14944268
]
Heng Chen commented on HBASE-14279:
---
{quote}
Added an example of lock striping.
{quote}
Why not use
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942891#comment-14942891
]
Hiroshi Ikeda commented on HBASE-14279:
---
Oops, {{remove}} contains a bug :(
> Race condition in
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723055#comment-14723055
]
Heng Chen commented on HBASE-14279:
---
{quote}
There is a similar class, KeyLoccker, whose key type is a
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723201#comment-14723201
]
Heng Chen commented on HBASE-14279:
---
It has a problem.
{code}
public class KeyLocker> {
{code}
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724726#comment-14724726
]
Hiroshi Ikeda commented on HBASE-14279:
---
Sorry I didn't realize {{KeyLocker}} has such restriction.
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718316#comment-14718316
]
Hiroshi Ikeda commented on HBASE-14279:
---
There is a similar class, {{KeyLoccker}},
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718440#comment-14718440
]
Hadoop QA commented on HBASE-14279:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716135#comment-14716135
]
Hiroshi Ikeda commented on HBASE-14279:
---
{code}
public void put(K key, V value) {
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716198#comment-14716198
]
Heng Chen commented on HBASE-14279:
---
{quote}
But in that case you just lock the
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710787#comment-14710787
]
Hiroshi Ikeda commented on HBASE-14279:
---
Go ahead :-)
Race condition in
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710691#comment-14710691
]
Heng Chen commented on HBASE-14279:
---
May I upload a patch ?
Race condition in
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712256#comment-14712256
]
Hiroshi Ikeda commented on HBASE-14279:
---
Exclusive access is required to lock the
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709066#comment-14709066
]
Hiroshi Ikeda commented on HBASE-14279:
---
It is better to use lock striping because
[
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706430#comment-14706430
]
Heng Chen commented on HBASE-14279:
---
yeah... maybe we can replace {{ConcurrentMapK,
53 matches
Mail list logo
