[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233710#comment-16233710
]
Guanghao Zhang commented on HBASE-18770:
bq. Do I need to do anything more in here sir?
No more,
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227410#comment-16227410
]
Chia-Ping Tsai commented on HBASE-18770:
bq. Looks like the patch passed in all but checkstyle
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227391#comment-16227391
]
stack commented on HBASE-18770:
---
Looks like the patch passed in all but checkstyle. Going to commit.
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227145#comment-16227145
]
stack commented on HBASE-18770:
---
Thank you [~elserj] Agree.
Waiting on hadoopqa just to make sure nothing
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227112#comment-16227112
]
Josh Elser commented on HBASE-18770:
bq. and I think Josh Elser is giving it a go over – he found a
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227108#comment-16227108
]
stack commented on HBASE-18770:
---
Thanks [~anoop.hbase] Yeah, can do a follow-up. I'll wait till the
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227107#comment-16227107
]
Anoop Sam John commented on HBASE-18770:
Lets commit this.. Any more things to cleanup, we can
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227105#comment-16227105
]
Hadoop QA commented on HBASE-18770:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226827#comment-16226827
]
stack commented on HBASE-18770:
---
.012 addresses last round of comments up on rb and in here (or filed
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226742#comment-16226742
]
stack commented on HBASE-18770:
---
[~chia7712] HBASE-19134. I'll take a look for beta-1.
[~zghaobac] Thank
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226649#comment-16226649
]
Guanghao Zhang commented on HBASE-18770:
bq. What is the read/write metric?
Now we have two class
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226498#comment-16226498
]
Chia-Ping Tsai commented on HBASE-18770:
bq. A CP could try setting compression context, original
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226205#comment-16226205
]
Hadoop QA commented on HBASE-18770:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226195#comment-16226195
]
stack commented on HBASE-18770:
---
On a read-only WALKey, I think I'll skip. It is yet another object
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226170#comment-16226170
]
stack commented on HBASE-18770:
---
bq. If CP bypass, we skip the real operation so it don't need update
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226126#comment-16226126
]
Guanghao Zhang commented on HBASE-18770:
bq. preAppend Metrics were being updated whether CP
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226091#comment-16226091
]
stack commented on HBASE-18770:
---
And thank you for the @deprecated [~chia7712] Let me do that too
>
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226086#comment-16226086
]
stack commented on HBASE-18770:
---
I like this idea. Let me do it.
> Remove bypass method in ObserverContext
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226079#comment-16226079
]
Chia-Ping Tsai commented on HBASE-18770:
{quote}
@Deprecated public boolean preWALRestore(final
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226052#comment-16226052
]
Chia-Ping Tsai commented on HBASE-18770:
{code}
@Deprecated public boolean
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225993#comment-16225993
]
stack commented on HBASE-18770:
---
I looked at the original dev mailing list again. The two cases
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225855#comment-16225855
]
stack commented on HBASE-18770:
---
h1. Survey on Metric updates when bypass
Highlevel, all bypasses update
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225714#comment-16225714
]
Andrew Purtell commented on HBASE-18770:
bq. Related, perhaps purge 'complete'?
It would
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225709#comment-16225709
]
stack commented on HBASE-18770:
---
Related, perhaps purge 'complete'?
> Remove bypass method in
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225185#comment-16225185
]
stack commented on HBASE-18770:
---
Fixed the above (removed bypass from scanner close). Thanks [~elserj] for
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224332#comment-16224332
]
Josh Elser commented on HBASE-18770:
LGTM. Tried to give it a close eye throughout. Nice work fixing
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224271#comment-16224271
]
Hadoop QA commented on HBASE-18770:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224242#comment-16224242
]
Hadoop QA commented on HBASE-18770:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224241#comment-16224241
]
stack commented on HBASE-18770:
---
.010 rebase.
> Remove bypass method in ObserverContext and implement the
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224239#comment-16224239
]
stack commented on HBASE-18770:
---
This issue implements HBASE-15071
> Remove bypass method in
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224236#comment-16224236
]
stack commented on HBASE-18770:
---
.009 is ready for review. TODO: Study what Scanners are up to, add more
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224220#comment-16224220
]
stack commented on HBASE-18770:
---
.008 should have fixed all tests and javadoc complaint. .008 incorporates
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224187#comment-16224187
]
stack commented on HBASE-18770:
---
bq. I used to think whether we can throw an UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223982#comment-16223982
]
Duo Zhang commented on HBASE-18770:
---
{quote}
Yes. This is how it works now. The bypass and complete
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223881#comment-16223881
]
Hadoop QA commented on HBASE-18770:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223843#comment-16223843
]
stack commented on HBASE-18770:
---
.007 more cleanup and fix TestMasterObserver test. More to do. Not ready
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223786#comment-16223786
]
Hadoop QA commented on HBASE-18770:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223728#comment-16223728
]
stack commented on HBASE-18770:
---
.008 Not for review. Just trying to get a run in against hadoopqa while I
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223305#comment-16223305
]
Hadoop QA commented on HBASE-18770:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223268#comment-16223268
]
Hadoop QA commented on HBASE-18770:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223219#comment-16223219
]
stack commented on HBASE-18770:
---
.005 Fix NPE. Going to see some interesting failures now we fail bypass
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223213#comment-16223213
]
stack commented on HBASE-18770:
---
.004 Rebase.
> Remove bypass method in ObserverContext and implement the
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223165#comment-16223165
]
Hadoop QA commented on HBASE-18770:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223113#comment-16223113
]
stack commented on HBASE-18770:
---
.003 fixes some unit tests. Throws exceptions if you try to bypass on a
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222919#comment-16222919
]
stack commented on HBASE-18770:
---
I went back to have another look. The current operation execution engine
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222535#comment-16222535
]
stack commented on HBASE-18770:
---
[~Apache9]
bq. So we will still have a bypass method for ObserverContext
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222324#comment-16222324
]
Duo Zhang commented on HBASE-18770:
---
So what is the final decision here? IIRC I saw a email alert that
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221641#comment-16221641
]
Hadoop QA commented on HBASE-18770:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221503#comment-16221503
]
Andrew Purtell commented on HBASE-18770:
bq. (Sorry Andrew Purtell – I didn't have the courage to
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221326#comment-16221326
]
stack commented on HBASE-18770:
---
.002 Abandons all previous attempts at a grand change and instead settles
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220053#comment-16220053
]
stack commented on HBASE-18770:
---
Thanks for reviews so far. I think I have a pattern now. Methods that are
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219543#comment-16219543
]
stack commented on HBASE-18770:
---
You are right [~mdrob] Edited my comment. Thanks.
> Remove bypass method
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219496#comment-16219496
]
Mike Drob commented on HBASE-18770:
---
{quote}
default Optional
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219413#comment-16219413
]
stack commented on HBASE-18770:
---
After Andrew comment up on RB made me think, and indeed we can do bypass
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219012#comment-16219012
]
Mike Drob commented on HBASE-18770:
---
Patch doesn't apply for me... looks like minor conflict in the
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218083#comment-16218083
]
stack commented on HBASE-18770:
---
.001 is start. See edit of RegionObserver to see how it does bypass
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211460#comment-16211460
]
Andrew Purtell commented on HBASE-18770:
bq. Even if we bypass, we must update pertinent core
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210595#comment-16210595
]
stack commented on HBASE-18770:
---
Summarizing the above and what came of the discussion up on the dev list
58 matches
Mail list logo
