[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

2018-03-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385035#comment-16385035 ] Hudson commented on HBASE-19985: Results for branch branch-1, done in 2 hr 7 min and counting

[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

2018-03-03 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384696#comment-16384696 ] Appy commented on HBASE-19985: -- Sorry for late reply, was traveling in a 15hr flight. I'd recommend using

[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

2018-03-02 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384517#comment-16384517 ] Chia-Ping Tsai commented on HBASE-19985: The findbugs warnings is stale. And I believe the patch

[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

2018-03-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384263#comment-16384263 ] Ted Yu commented on HBASE-19985: [~chia7712]: Can you take a look ? > Redundant instanceof check in

[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

2018-03-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384253#comment-16384253 ] Hadoop QA commented on HBASE-19985: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

2018-03-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384224#comment-16384224 ] Hadoop QA commented on HBASE-19985: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

2018-03-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384217#comment-16384217 ] Hadoop QA commented on HBASE-19985: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

2018-03-02 Thread Artem Ervits (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384206#comment-16384206 ] Artem Ervits commented on HBASE-19985: -- I'm attaching git diff patch instead of yetus generated

[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

2018-03-02 Thread Artem Ervits (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384144#comment-16384144 ] Artem Ervits commented on HBASE-19985: -- [~appy] I was told to ping you, I'm trying to create a patch

[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

2018-02-20 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371009#comment-16371009 ] Chia-Ping Tsai commented on HBASE-19985: {quote}It seems dropping the 'e instanceof

[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

2018-02-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370623#comment-16370623 ] Ted Yu commented on HBASE-19985: It seems dropping the 'e instanceof ServiceException' check but keeping

[jira] [Commented] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException

2018-02-14 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363966#comment-16363966 ] Chia-Ping Tsai commented on HBASE-19985: The code in master is shown below. {code:java} public