[jira] [Commented] (HBASE-22774) [WAL] RegionGroupingStrategy loses its function after split
[
https://issues.apache.org/jira/browse/HBASE-22774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906960#comment-16906960
]
Hudson commented on HBASE-22774:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #617 (See
[https://builds.apache.org/job/HBase-1.3-IT/617/])
HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
(reidchan: rev d2b310bca8140515b436aa34b2bda5c8d0236803)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RegionGroupingProvider.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedGroupingStrategy.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/NamespaceGroupingStrategy.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransaction.java
> [WAL] RegionGroupingStrategy loses its function after split
> ---
>
> Key: HBASE-22774
> URL: https://issues.apache.org/jira/browse/HBASE-22774
> Project: HBase
> Issue Type: Bug
> Components: Performance, wal
>Affects Versions: 1.4.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22774.branch-1.001.patch,
> HBASE-22774.branch-1.002.patch
>
>
> Having {{hbase.wal.provider}} set {{multiwal}}, it works fine on regionserver
> restart, at the beginning.
> But when region split happened, those daughter regions would inherit her
> parent's WAL, which violates the setting. For example, when
> {{hbase.wal.regiongrouping.strategy}} set {{identity}}, each daughter regions
> should create its own WAL instead of inheriting.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
Apache-HBase commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… URL: https://github.com/apache/hbase/pull/484#issuecomment-521128018 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 1556 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ branch-1.3 Compile Tests _ | | +1 | mvninstall | 437 | branch-1.3 passed | | +1 | compile | 42 | branch-1.3 passed | | +1 | checkstyle | 116 | branch-1.3 passed | | -1 | shadedjars | 13 | branch has 10 errors when building our shaded downstream artifacts. | | +1 | javadoc | 40 | branch-1.3 passed | | 0 | spotbugs | 156 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 153 | branch-1.3 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 110 | the patch passed | | +1 | compile | 43 | the patch passed | | +1 | javac | 43 | the patch passed | | -1 | checkstyle | 111 | hbase-server: The patch generated 1 new + 372 unchanged - 23 fixed = 373 total (was 395) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 11 | patch has 10 errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 585 | Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7. | | +1 | javadoc | 30 | the patch passed | | +1 | findbugs | 262 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 9089 | hbase-server in the patch failed. | | +1 | asflicense | 133 | The patch does not generate ASF License warnings. | | | | 12912 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestEncryptionKeyRotation | | | hadoop.hbase.regionserver.TestRegionReplicas | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/484 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a112393a1bb9 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh | | git revision | branch-1.3 / d2b310b | | Default Java | 1.8.0_222 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/branch-shadedjars.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/patch-shadedjars.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/testReport/ | | Max. process+thread count | 3809 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #490: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Apache-HBase commented on issue #490: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. URL: https://github.com/apache/hbase/pull/490#issuecomment-521129018 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 1346 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1.3 Compile Tests _ | | +1 | mvninstall | 464 | branch-1.3 passed | | +1 | compile | 51 | branch-1.3 passed with JDK v1.8.0_222 | | +1 | compile | 54 | branch-1.3 passed with JDK v1.7.0_232 | | +1 | checkstyle | 109 | branch-1.3 passed | | +1 | shadedjars | 188 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 56 | branch-1.3 passed with JDK v1.8.0_222 | | +1 | javadoc | 60 | branch-1.3 passed with JDK v1.7.0_232 | | 0 | spotbugs | 204 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 201 | branch-1.3 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 134 | the patch passed | | +1 | compile | 50 | the patch passed with JDK v1.8.0_222 | | +1 | javac | 50 | the patch passed | | +1 | compile | 51 | the patch passed with JDK v1.7.0_232 | | +1 | javac | 51 | the patch passed | | +1 | checkstyle | 117 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 199 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 691 | Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7. | | +1 | javadoc | 34 | the patch passed with JDK v1.8.0_222 | | +1 | javadoc | 47 | the patch passed with JDK v1.7.0_232 | | +1 | findbugs | 208 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8951 | hbase-server in the patch failed. | | +1 | asflicense | 35 | The patch does not generate ASF License warnings. | | | | 13162 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationSource | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/490 | | JIRA Issue | HBASE-22601 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e817aa692df5 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-490/out/precommit/personality/provided.sh | | git revision | branch-1.3 / d2b310b | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/3/testReport/ | | Max. process+thread count | 3747 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/3/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906965#comment-16906965
]
Hadoop QA commented on HBASE-22601:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 22m
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1.3 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
44s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
49s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
8s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_232 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
24s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
21s{color} | {color:green} branch-1.3 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
19s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
11m 31s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.1 2.5.2 2.6.5 2.7.7. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}149m 11s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
35s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black
[jira] [Commented] (HBASE-22828) Log a region close journal
[
https://issues.apache.org/jira/browse/HBASE-22828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906973#comment-16906973
]
Hudson commented on HBASE-22828:
Results for branch branch-2
[build #2167 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2167/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2167//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2167//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2167//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Log a region close journal
> --
>
> Key: HBASE-22828
> URL: https://issues.apache.org/jira/browse/HBASE-22828
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22828-branch-1.patch, HBASE-22828.patch
>
>
> We already track region close activity with a MonitoredTask. Enable the
> status journal and dump it at DEBUG log level so if for some reasons region
> closes are taking a long time we have a timestamped journal of the activity
> and how long each step took.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22845) Revert MetaTableAccessor#makePutFromTableState access to public
[
https://issues.apache.org/jira/browse/HBASE-22845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906979#comment-16906979
]
Hudson commented on HBASE-22845:
Results for branch master
[build #1332 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1332/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1332//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1332//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1332//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Revert MetaTableAccessor#makePutFromTableState access to public
> ---
>
> Key: HBASE-22845
> URL: https://issues.apache.org/jira/browse/HBASE-22845
> Project: HBase
> Issue Type: Sub-task
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> Discussions in HBASE-22843.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22828) Log a region close journal
[
https://issues.apache.org/jira/browse/HBASE-22828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906980#comment-16906980
]
Hudson commented on HBASE-22828:
Results for branch master
[build #1332 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1332/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1332//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1332//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1332//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Log a region close journal
> --
>
> Key: HBASE-22828
> URL: https://issues.apache.org/jira/browse/HBASE-22828
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22828-branch-1.patch, HBASE-22828.patch
>
>
> We already track region close activity with a MonitoredTask. Enable the
> status journal and dump it at DEBUG log level so if for some reasons region
> closes are taking a long time we have a timestamped journal of the activity
> and how long each step took.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906981#comment-16906981
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #58 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/58/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/58//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/58//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/58//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again
Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456#issuecomment-521143200 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 315 | branch-2.1 passed | | +1 | compile | 57 | branch-2.1 passed | | +1 | checkstyle | 80 | branch-2.1 passed | | +1 | shadedjars | 250 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | branch-2.1 passed | | 0 | spotbugs | 182 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 180 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 285 | the patch passed | | +1 | compile | 58 | the patch passed | | +1 | javac | 58 | the patch passed | | +1 | checkstyle | 81 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 239 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1250 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 37 | the patch passed | | +1 | findbugs | 177 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8259 | hbase-server in the patch failed. | | +1 | asflicense | 23 | The patch does not generate ASF License warnings. | | | | 11731 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/26/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/456 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9fdb9ef04c49 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-456/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 0c906f0fd0 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/26/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/26/testReport/ | | Max. process+thread count | 5135 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/26/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22828) Log a region close journal
[
https://issues.apache.org/jira/browse/HBASE-22828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906999#comment-16906999
]
Hudson commented on HBASE-22828:
Results for branch branch-2.2
[build #514 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/514/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/514//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/514//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/514//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Log a region close journal
> --
>
> Key: HBASE-22828
> URL: https://issues.apache.org/jira/browse/HBASE-22828
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22828-branch-1.patch, HBASE-22828.patch
>
>
> We already track region close activity with a MonitoredTask. Enable the
> status journal and dump it at DEBUG log level so if for some reasons region
> closes are taking a long time we have a timestamped journal of the activity
> and how long each step took.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22845) Revert MetaTableAccessor#makePutFromTableState access to public
[
https://issues.apache.org/jira/browse/HBASE-22845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906998#comment-16906998
]
Hudson commented on HBASE-22845:
Results for branch branch-2.2
[build #514 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/514/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/514//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/514//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/514//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Revert MetaTableAccessor#makePutFromTableState access to public
> ---
>
> Key: HBASE-22845
> URL: https://issues.apache.org/jira/browse/HBASE-22845
> Project: HBase
> Issue Type: Sub-task
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> Discussions in HBASE-22843.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
Apache-HBase commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… URL: https://github.com/apache/hbase/pull/484#issuecomment-521150870 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 55 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ branch-1.3 Compile Tests _ | | +1 | mvninstall | 438 | branch-1.3 passed | | +1 | compile | 37 | branch-1.3 passed with JDK v1.8.0_222 | | +1 | compile | 39 | branch-1.3 passed with JDK v1.7.0_232 | | +1 | checkstyle | 94 | branch-1.3 passed | | +1 | shadedjars | 151 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | branch-1.3 passed with JDK v1.8.0_222 | | +1 | javadoc | 39 | branch-1.3 passed with JDK v1.7.0_232 | | 0 | spotbugs | 161 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 158 | branch-1.3 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 98 | the patch passed | | +1 | compile | 36 | the patch passed with JDK v1.8.0_222 | | +1 | javac | 36 | the patch passed | | +1 | compile | 37 | the patch passed with JDK v1.7.0_232 | | +1 | javac | 37 | the patch passed | | +1 | checkstyle | 86 | hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 144 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 534 | Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7. | | +1 | javadoc | 32 | the patch passed with JDK v1.8.0_222 | | +1 | javadoc | 38 | the patch passed with JDK v1.7.0_232 | | +1 | findbugs | 156 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 5580 | hbase-server in the patch passed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 7920 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/484 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ea2a6c88e389 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh | | git revision | branch-1.3 / d2b310b | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/5/testReport/ | | Max. process+thread count | 4223 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/5/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again
Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456#issuecomment-521154604 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 62 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 332 | branch-2.1 passed | | +1 | compile | 52 | branch-2.1 passed | | +1 | checkstyle | 80 | branch-2.1 passed | | +1 | shadedjars | 243 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 33 | branch-2.1 passed | | 0 | spotbugs | 173 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 171 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 320 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | +1 | checkstyle | 76 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 234 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1383 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 195 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 14467 | hbase-server in the patch failed. | | +1 | asflicense | 50 | The patch does not generate ASF License warnings. | | | | 18171 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.quotas.TestSpaceQuotas | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/25/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/456 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6df2ba870996 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-456/out/precommit/personality/provided.sh | | git revision | branch-2.1 / fb7e7d810d | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/25/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/25/testReport/ | | Max. process+thread count | 4652 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/25/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22380) break circle replication when doing bulkload
[ https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907021#comment-16907021 ] Wellington Chevreuil commented on HBASE-22380: -- Hi [~openinx], I had been played around this a bit, lately. Would you mind if I take this over, in case you had not started work in a solution yet? > break circle replication when doing bulkload > > > Key: HBASE-22380 > URL: https://issues.apache.org/jira/browse/HBASE-22380 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.5, 1.3.5 >Reporter: chenxu >Assignee: Zheng Hu >Priority: Critical > Labels: bulkload > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.1.7, 2.2.2 > > > when enabled master-master bulkload replication, HFiles will be replicated > circularly between two clusters -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: HBASE-22728.branch-1.18.patch > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (HBASE-22380) break circle replication when doing bulkload
[ https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu reassigned HBASE-22380: Assignee: (was: Zheng Hu) > break circle replication when doing bulkload > > > Key: HBASE-22380 > URL: https://issues.apache.org/jira/browse/HBASE-22380 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.5, 1.3.5 >Reporter: chenxu >Priority: Critical > Labels: bulkload > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.1.7, 2.2.2 > > > when enabled master-master bulkload replication, HFiles will be replicated > circularly between two clusters -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] sbarnoud commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
sbarnoud commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-521156901 I’m on holiday. Anyway, i’m just surprised you close a performance patch without doing any performance test. So, i will keep the improvement for me ;-) > Le 14 août 2019 à 08:24, Duo Zhang a écrit : > > Close since no big progress here. Can open a new PR which targets to branch-2 if you have time @sbarnoud . Or I will try to port the patch if I have time. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22380) break circle replication when doing bulkload
[ https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907024#comment-16907024 ] Zheng Hu commented on HBASE-22380: -- Fine, I've assigned to you. I can help to review your github PR. Thanks. > break circle replication when doing bulkload > > > Key: HBASE-22380 > URL: https://issues.apache.org/jira/browse/HBASE-22380 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.5, 1.3.5 >Reporter: chenxu >Assignee: Wellington Chevreuil >Priority: Critical > Labels: bulkload > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.1.7, 2.2.2 > > > when enabled master-master bulkload replication, HFiles will be replicated > circularly between two clusters -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (HBASE-22380) break circle replication when doing bulkload
[ https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu reassigned HBASE-22380: Assignee: Wellington Chevreuil > break circle replication when doing bulkload > > > Key: HBASE-22380 > URL: https://issues.apache.org/jira/browse/HBASE-22380 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.5, 1.3.5 >Reporter: chenxu >Assignee: Wellington Chevreuil >Priority: Critical > Labels: bulkload > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.1.7, 2.2.2 > > > when enabled master-master bulkload replication, HFiles will be replicated > circularly between two clusters -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907025#comment-16907025 ] Viraj Jasani commented on HBASE-22728: -- Thanks. Sure it should be good enough to call out in release note. With latest patch attached, we are including vulnerable mapper only in hbase-common and hbase-assembly. > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907025#comment-16907025 ] Viraj Jasani edited comment on HBASE-22728 at 8/14/19 8:42 AM: --- Thanks. Sure it should be good enough to call out in release note. With latest patch attached, we are including vulnerable mapper in hbase-common and hbase-assembly. was (Author: vjasani): Thanks. Sure it should be good enough to call out in release note. With latest patch attached, we are including vulnerable mapper only in hbase-common and hbase-assembly. > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch, HBASE-22728.branch-1.16.patch, > HBASE-22728.branch-1.18.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22380) break circle replication when doing bulkload
[ https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907027#comment-16907027 ] Wellington Chevreuil commented on HBASE-22380: -- Thanks, will submit a PR soon. > break circle replication when doing bulkload > > > Key: HBASE-22380 > URL: https://issues.apache.org/jira/browse/HBASE-22380 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.5, 1.3.5 >Reporter: chenxu >Assignee: Wellington Chevreuil >Priority: Critical > Labels: bulkload > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.1.7, 2.2.2 > > > when enabled master-master bulkload replication, HFiles will be replicated > circularly between two clusters -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-521161206 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 2 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 68 | Maven dependency ordering for branch | | +1 | mvninstall | 435 | master passed | | +1 | compile | 237 | master passed | | +1 | checkstyle | 197 | master passed | | +1 | shadedjars | 374 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 232 | master passed | | 0 | spotbugs | 34 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 34 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 393 | the patch passed | | +1 | compile | 235 | the patch passed | | +1 | javac | 235 | the patch passed | | +1 | checkstyle | 189 | the patch passed | | +1 | shellcheck | 2 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 7 | The patch has no ill-formed XML file. | | +1 | shadedjars | 371 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1253 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 236 | the patch passed | | 0 | findbugs | 37 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 13785 | root in the patch failed. | | +1 | asflicense | 105 | The patch does not generate ASF License warnings. | | | | 21172 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/12/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 6e3fc1c0e5b0 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/12/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/12/testReport/ | | Max. process+thread count | 5006 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/12/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache9 commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-521163341 Performance is not everything. To be honest, the patch is still not qualified enough to be merged. Please see my last comments, doing busy wait( sleep(1) ) on a critical path is usually a no no, especially that you are waiting for external I/O to complete rather than an in memory operation... Anyway, I got your point that the current implementation of BufferMutator could be optimized to increase the concurrency. Will take a look if I have time. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
openinx commented on a change in pull request #486: HBASE-22810 Initialize an
separate ThreadPoolExecutor for taking/restoring snapshot
URL: https://github.com/apache/hbase/pull/486#discussion_r313780895
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -1431,6 +1431,8 @@ private void startServiceThreads() throws IOException{
conf.getInt("hbase.master.executor.meta.serverops.threads", 5));
this.executorService.startExecutorService(ExecutorType.M_LOG_REPLAY_OPS,
conf.getInt("hbase.master.executor.logreplayops.threads", 10));
+
this.executorService.startExecutorService(ExecutorType.MASTER_SNAPSHOT_OPERATIONS,
Review comment:
Different table can snapshot at the same time , for the given table, only
one snapshot can be taking (Have a tableLock to ensure that).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
openinx commented on a change in pull request #486: HBASE-22810 Initialize an
separate ThreadPoolExecutor for taking/restoring snapshot
URL: https://github.com/apache/hbase/pull/486#discussion_r313778032
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventType.java
##
@@ -321,11 +321,6 @@ public static EventType get(final int code) {
throw new IllegalArgumentException("Unknown code " + code);
}
- public boolean isOnlineSchemaChangeSupported() {
Review comment:
Yes, can remove now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
openinx commented on a change in pull request #486: HBASE-22810 Initialize an
separate ThreadPoolExecutor for taking/restoring snapshot
URL: https://github.com/apache/hbase/pull/486#discussion_r313780930
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -1431,6 +1431,8 @@ private void startServiceThreads() throws IOException{
conf.getInt("hbase.master.executor.meta.serverops.threads", 5));
this.executorService.startExecutorService(ExecutorType.M_LOG_REPLAY_OPS,
conf.getInt("hbase.master.executor.logreplayops.threads", 10));
+
this.executorService.startExecutorService(ExecutorType.MASTER_SNAPSHOT_OPERATIONS,
+ conf.getInt("hbase.master.executor.snapshot.threads", 3));
Review comment:
Fine
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] sbarnoud commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
sbarnoud commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-521170448 The sleep is on a « backpressure » path. Of course, we can replace it with a notify. But, when a system is overloaded it is often better to let it some time to unbuffer and not to overload it as soon as possible. This kind of decision can only be taken after a benchmark and not just after a code review > Le 14 août 2019 à 10:59, Duo Zhang a écrit : > > Performance is not everything. To be honest, the patch is still not qualified enough to be merged. Please see my last comments, doing busy wait( sleep(1) ) on a critical path is usually a no no, especially that you are waiting for external I/O to complete rather than an in memory operation... > > Anyway, I got your point that the current implementation of BufferMutator could be optimized to increase the concurrency. Will take a look if I have time. > > Thanks. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] PierreZ commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
PierreZ commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-521171549 Hi! It seems I have different failed junit tests at each run, should I be worried? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache9 commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-521177611 Not sure why you keep saying 'benchmark' since I never challenge the performance improvement of your patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22795) Align the API interfaces in TimeRange
[ https://issues.apache.org/jira/browse/HBASE-22795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu resolved HBASE-22795. -- Resolution: Duplicate The issue HBASE-22841 is working on this. > Align the API interfaces in TimeRange > -- > > Key: HBASE-22795 > URL: https://issues.apache.org/jira/browse/HBASE-22795 > Project: HBase > Issue Type: Improvement >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > > There's a mail from user list , says TimeRange API is not good enough now. > https://mail-archives.apache.org/mod_mbox/hbase-user/201908.mbox/%3C1D1D5676-615A-47ED-9A48-77445FAF1B29%40csiro.au%3E > Need to align the API interfaces in TimeRange. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22605) Ref guide includes dev guidance only applicable to EOM versions
[
https://issues.apache.org/jira/browse/HBASE-22605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-22605:
---
Fix Version/s: 2.2.1
> Ref guide includes dev guidance only applicable to EOM versions
> ---
>
> Key: HBASE-22605
> URL: https://issues.apache.org/jira/browse/HBASE-22605
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Trivial
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22605.000.patch
>
>
> The ref guide section on developer guidance has this blurb:
> {quote}
> h2. Implementing Writable
> h3. Applies pre-0.96 only
> bq. In 0.96, HBase moved to protocol buffers (protobufs). The below section
> on Writables applies to 0.94.x and previous, not to 0.96 and beyond.
> Every class returned by RegionServers must implement the Writable interface.
> If you are creating a new class that needs to implement this interface, do
> not forget the default constructor.
> {quote}
> ([ref|http://hbase.apache.org/book.html#common.patch.feedback.writable])
> this should be removed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Reopened] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reopened HBASE-22771: Forgot to pushed to branch-2.2. Reopened for branch-2.2. > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch, HBASE-22771.master.003.patch, > HBASE-22771.master.004.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] sbarnoud commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
sbarnoud commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-521189467 What i’m saying is that the sleep may provide better performance than a notify because it is called when the server latency increases (probably because it is overloaded). In that case, it may be better to give some time to the server to dequeue queries instead of submitting as soon as possible new one. Only a benchmark could differentiate the 2 approach, not a code review > Le 14 août 2019 à 11:42, Duo Zhang a écrit : > > Not sure why you keep saying 'benchmark' since I never challenge the performance improvement of your patch? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22013) SpaceQuota utilization issue with region replicas enabled
[ https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shardul Singh updated HBASE-22013: -- Attachment: HBASE-22013.master.v002.patch > SpaceQuota utilization issue with region replicas enabled > - > > Key: HBASE-22013 > URL: https://issues.apache.org/jira/browse/HBASE-22013 > Project: HBase > Issue Type: Bug >Reporter: Ajeet Rai >Assignee: Shardul Singh >Priority: Major > Labels: Quota, Space > Fix For: 2.1.0 > > Attachments: HBASE-22013.master.v001.patch, > HBASE-22013.master.v002.patch > > > Space Quota: Space Quota Issue: If a table is created with region replica > then quota calculation is not happening > Steps: > 1: Create a table with 100 regions with region replica 3 > 2: Observe that 'hbase:quota' table doesn't have entry of usage for this > table So In UI only policy Limit and Policy is shown but not Usage and State. > Reason: > It looks like File system utilization core is sending data of 100 reasons > but not the size of region replicas. > But in quota observer chore, it is considering total region(actual regions+ > replica reasons) > So the ratio of reported regions is less then configured > percentRegionsReportedThreshold. > SO quota calculation is not happening -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22013) SpaceQuota utilization issue with region replicas enabled
[ https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shardul Singh updated HBASE-22013: -- Attachment: (was: HBASE-22013.master.v002.patch) > SpaceQuota utilization issue with region replicas enabled > - > > Key: HBASE-22013 > URL: https://issues.apache.org/jira/browse/HBASE-22013 > Project: HBase > Issue Type: Bug >Reporter: Ajeet Rai >Assignee: Shardul Singh >Priority: Major > Labels: Quota, Space > Fix For: 2.1.0 > > Attachments: HBASE-22013.master.v001.patch > > > Space Quota: Space Quota Issue: If a table is created with region replica > then quota calculation is not happening > Steps: > 1: Create a table with 100 regions with region replica 3 > 2: Observe that 'hbase:quota' table doesn't have entry of usage for this > table So In UI only policy Limit and Policy is shown but not Usage and State. > Reason: > It looks like File system utilization core is sending data of 100 reasons > but not the size of region replicas. > But in quota observer chore, it is considering total region(actual regions+ > replica reasons) > So the ratio of reported regions is less then configured > percentRegionsReportedThreshold. > SO quota calculation is not happening -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22013) SpaceQuota utilization issue with region replicas enabled
[ https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shardul Singh updated HBASE-22013: -- Status: Patch Available (was: Open) > SpaceQuota utilization issue with region replicas enabled > - > > Key: HBASE-22013 > URL: https://issues.apache.org/jira/browse/HBASE-22013 > Project: HBase > Issue Type: Bug >Reporter: Ajeet Rai >Assignee: Shardul Singh >Priority: Major > Labels: Quota, Space > Fix For: 2.1.0 > > Attachments: HBASE-22013.master.v001.patch > > > Space Quota: Space Quota Issue: If a table is created with region replica > then quota calculation is not happening > Steps: > 1: Create a table with 100 regions with region replica 3 > 2: Observe that 'hbase:quota' table doesn't have entry of usage for this > table So In UI only policy Limit and Policy is shown but not Usage and State. > Reason: > It looks like File system utilization core is sending data of 100 reasons > but not the size of region replicas. > But in quota observer chore, it is considering total region(actual regions+ > replica reasons) > So the ratio of reported regions is less then configured > percentRegionsReportedThreshold. > SO quota calculation is not happening -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-22771. Resolution: Fixed > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch, HBASE-22771.master.003.patch, > HBASE-22771.master.004.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907152#comment-16907152 ] Guanghao Zhang commented on HBASE-22771: Cherry-picked from branch-2. And Pushed to branch-2.2. > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch, HBASE-22771.master.003.patch, > HBASE-22771.master.004.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907155#comment-16907155
]
HBase QA commented on HBASE-22804:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
55s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
2s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
23s{color} | {color:red} hbase-server: The patch generated 13 new + 23
unchanged - 0 fixed = 36 total (was 23) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
32s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 26s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}180m
54s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
30s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}250m 7s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/769/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22804 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977555/HBASE-22804.master.003.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ead2cbed67c2 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 27ed2ac071 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/769/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/769/testReport/ |
| Max. process+thread count | 4560 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
htt
[jira] [Commented] (HBASE-22699) refactor isMetaClearingException
[ https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907154#comment-16907154 ] Guanghao Zhang commented on HBASE-22699: Move the fix version to 2.2.2. > refactor isMetaClearingException > > > Key: HBASE-22699 > URL: https://issues.apache.org/jira/browse/HBASE-22699 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Junhong Xu >Assignee: Junhong Xu >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > It is not so readable -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache9 commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache9 commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-521193007 Please read my comment carefully > So this means we will do a busy waiting here? This is not always the best choice, maybe we should provide a configurable way to wait here, the default one should be the typical wait/notify, and if do not care wasting the CPU cycles but only want the maximum throughput, you can use busy waiting. I'm not telling that sleep will have a worse performance right? Just make it configurable. Maximum throughput is not always the best choice. User may have a mixed workload and do not want to waste too many CPU cycles here. > In that case, it may be better to give some time to the server to dequeue queries instead of submitting as soon as possible new one. I can not get the point here, we must wait until the server dequeue queries right? Otherwise we do not need to introduce the complicated slot logic... The difference here is whether to use a 'while sleep' or a 'wait/notify'. My suggestion is to provide both. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22850) Generate CHANGES.md and RELEASENOTES.md for 2.2.1
Guanghao Zhang created HBASE-22850: -- Summary: Generate CHANGES.md and RELEASENOTES.md for 2.2.1 Key: HBASE-22850 URL: https://issues.apache.org/jira/browse/HBASE-22850 Project: HBase Issue Type: Sub-task Reporter: Guanghao Zhang Assignee: Guanghao Zhang -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] mymeiyi commented on a change in pull request #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature
mymeiyi commented on a change in pull request #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature URL: https://github.com/apache/hbase/pull/485#discussion_r313809511 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java ## @@ -319,19 +320,22 @@ void checkTempDir(final Path tmpdir, final Configuration c, final FileSystem fs) HFileArchiver.archiveRegions(c, fs, this.rootdir, tableDir, Review comment: The tmp namespace or table dirs are deleted if namespace or table are dropped. There are UTs in TestSnapshotScannerHDFSAclController to check it. Add a warn log to record unarchived regions, if this problem happens in practice, we can fix this? And add UT in TestSnapshotScannerHDFSAclController. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio opened a new pull request #492: HBASE-22850 Generate CHANGES.md and RELEASENOTES.md for 2.2.1
infraio opened a new pull request #492: HBASE-22850 Generate CHANGES.md and RELEASENOTES.md for 2.2.1 URL: https://github.com/apache/hbase/pull/492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #492: HBASE-22850 Generate CHANGES.md and RELEASENOTES.md for 2.2.1
Apache-HBase commented on issue #492: HBASE-22850 Generate CHANGES.md and RELEASENOTES.md for 2.2.1 URL: https://github.com/apache/hbase/pull/492#issuecomment-521198778 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 113 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ branch-2.2 Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 | whitespace | 0 | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 | asflicense | 23 | The patch does not generate ASF License warnings. | | | | 261 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-492/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/492 | | Optional Tests | dupname asflicense | | uname | Linux 6e6586c1374d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-492/out/precommit/personality/provided.sh | | git revision | branch-2.2 / 58a79618b1 | | Max. process+thread count | 51 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-492/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio merged pull request #492: HBASE-22850 Generate CHANGES.md and RELEASENOTES.md for 2.2.1
infraio merged pull request #492: HBASE-22850 Generate CHANGES.md and RELEASENOTES.md for 2.2.1 URL: https://github.com/apache/hbase/pull/492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22850) Generate CHANGES.md and RELEASENOTES.md for 2.2.1
[ https://issues.apache.org/jira/browse/HBASE-22850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-22850. Resolution: Fixed Fix Version/s: 2.2.1 > Generate CHANGES.md and RELEASENOTES.md for 2.2.1 > - > > Key: HBASE-22850 > URL: https://issues.apache.org/jira/browse/HBASE-22850 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 2.2.1 > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22851) Preparing HBase release 2.2.1RC0: set version to 2.2.1 in branch-2.2
Guanghao Zhang created HBASE-22851: -- Summary: Preparing HBase release 2.2.1RC0: set version to 2.2.1 in branch-2.2 Key: HBASE-22851 URL: https://issues.apache.org/jira/browse/HBASE-22851 Project: HBase Issue Type: Sub-task Reporter: Guanghao Zhang Assignee: Guanghao Zhang -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907214#comment-16907214
]
HBase QA commented on HBASE-22728:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 12 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
54s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
34s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 12m
1s{color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
10s{color} | {color:red} branch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
17s{color} | {color:green} branch-1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} The patch passed checkstyle in hbase-common {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch passed checkstyle in hbase-procedure
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} The patch passed checkstyle in hbase-client {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch passed checkstyle in hbase-metrics-api
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} The patch passed checkstyle in hbase-metrics {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch passed checkstyle in hbase-hadoop2-compat
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} The patch passed checkstyle in hbase-prefix-tree
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
31s{color} | {color:green} hbase-server: The patch generated 0 new + 260
unchanged - 3 fixed = 260 total (was 263) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} The patch passed checkstyle in hbase-testing-util
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} The patch passed checkstyle in hbase-thrift {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} hbase-rest: The patch generated 0 new + 66 unchanged
- 7 fixed = 66 total (was 73) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch passed checkstyle in hbase-rsgroup {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch passed checkstyle in hbase-shell {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {
[jira] [Commented] (HBASE-22013) SpaceQuota utilization issue with region replicas enabled
[
https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907236#comment-16907236
]
Sakthi commented on HBASE-22013:
Thanks for putting up a patch [~shardulsingh]. Let's follow the naming
convention of the patches here according to
[http://hbase.apache.org/book.html#submitting.patches.create] . In particular:
_Patch name should be as follows to adhere to Yetus' naming convention:_
_{{(JIRA).(branch name).(patch number).patch}}_
_For eg. HBASE-11625.master.001.patch, HBASE-X.branch-1.2.0005.patch, etc._
Could you please update the name of the patch accordingly, while I review your
patch? Thanks.
> SpaceQuota utilization issue with region replicas enabled
> -
>
> Key: HBASE-22013
> URL: https://issues.apache.org/jira/browse/HBASE-22013
> Project: HBase
> Issue Type: Bug
>Reporter: Ajeet Rai
>Assignee: Shardul Singh
>Priority: Major
> Labels: Quota, Space
> Fix For: 2.1.0
>
> Attachments: HBASE-22013.master.v001.patch
>
>
> Space Quota: Space Quota Issue: If a table is created with region replica
> then quota calculation is not happening
> Steps:
> 1: Create a table with 100 regions with region replica 3
> 2: Observe that 'hbase:quota' table doesn't have entry of usage for this
> table So In UI only policy Limit and Policy is shown but not Usage and State.
> Reason:
> It looks like File system utilization core is sending data of 100 reasons
> but not the size of region replicas.
> But in quota observer chore, it is considering total region(actual regions+
> replica reasons)
> So the ratio of reported regions is less then configured
> percentRegionsReportedThreshold.
> SO quota calculation is not happening
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22013) SpaceQuota utilization issue with region replicas enabled
[
https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907244#comment-16907244
]
Sakthi commented on HBASE-22013:
The patch looks good. Few comments:
1. In the below fn in SpaceQuotaHelperForTests:
{code:java}
TableName createTableWithRegions(Admin admin, int numRegions){code}
The parameter admin is never used. Let's use that rather than
testutil.getAdmin()?
2. Also, let's add few test cases for 0 replicas?
3. I think it's better to wait for the tables to enter violation(with timeout)
before verifying for violation. Or in a simpler way - just do a thread sleep
for 5 secs before verification to avoid flakeyness of the tests.
[~shardulsingh]
> SpaceQuota utilization issue with region replicas enabled
> -
>
> Key: HBASE-22013
> URL: https://issues.apache.org/jira/browse/HBASE-22013
> Project: HBase
> Issue Type: Bug
>Reporter: Ajeet Rai
>Assignee: Shardul Singh
>Priority: Major
> Labels: Quota, Space
> Fix For: 2.1.0
>
> Attachments: HBASE-22013.master.v001.patch
>
>
> Space Quota: Space Quota Issue: If a table is created with region replica
> then quota calculation is not happening
> Steps:
> 1: Create a table with 100 regions with region replica 3
> 2: Observe that 'hbase:quota' table doesn't have entry of usage for this
> table So In UI only policy Limit and Policy is shown but not Usage and State.
> Reason:
> It looks like File system utilization core is sending data of 100 reasons
> but not the size of region replicas.
> But in quota observer chore, it is considering total region(actual regions+
> replica reasons)
> So the ratio of reported regions is less then configured
> percentRegionsReportedThreshold.
> SO quota calculation is not happening
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (HBASE-22852) hbase nightlies leaking gpg-agents
Allen Wittenauer created HBASE-22852:
Summary: hbase nightlies leaking gpg-agents
Key: HBASE-22852
URL: https://issues.apache.org/jira/browse/HBASE-22852
Project: HBase
Issue Type: Bug
Reporter: Allen Wittenauer
FYI, just triggered yetus master, which includes code to find and kill
long-running processes still attached to the Jenkins workspace directory. It
came up with this:
https://builds.apache.org/view/S-Z/view/Yetus/job/yetus-github-multibranch/job/master/134/console
{code}
USER PID %CPU %MEMVSZ RSS TTY STAT START TIME COMMAND
jenkins752 0.0 0.0 93612 584 ?Ss Aug12 0:00 gpg-agent
--homedir
/home/jenkins/jenkins-slave/workspace/HBase_Nightly_HBASE-20952/downloads-hadoop-2/.gpg
--use-standard-socket --daemon
Killing 752 ***
{code}
(repeat 10s of times, which slightly different dates, pids, versions, etc)
Also, be aware that any other process running on the node (such as the other
executor) has extremely easy access to whatever gpg creds you are using...
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22852) hbase nightlies leaking gpg-agents
[
https://issues.apache.org/jira/browse/HBASE-22852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-22852:
Component/s: build
> hbase nightlies leaking gpg-agents
> --
>
> Key: HBASE-22852
> URL: https://issues.apache.org/jira/browse/HBASE-22852
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Allen Wittenauer
>Priority: Major
>
> FYI, just triggered yetus master, which includes code to find and kill
> long-running processes still attached to the Jenkins workspace directory. It
> came up with this:
> https://builds.apache.org/view/S-Z/view/Yetus/job/yetus-github-multibranch/job/master/134/console
> {code}
> USER PID %CPU %MEMVSZ RSS TTY STAT START TIME COMMAND
> jenkins752 0.0 0.0 93612 584 ?Ss Aug12 0:00 gpg-agent
> --homedir
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_HBASE-20952/downloads-hadoop-2/.gpg
> --use-standard-socket --daemon
> Killing 752 ***
> {code}
> (repeat 10s of times, which slightly different dates, pids, versions, etc)
> Also, be aware that any other process running on the node (such as the other
> executor) has extremely easy access to whatever gpg creds you are using...
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22852) hbase nightlies leaking gpg-agents
[
https://issues.apache.org/jira/browse/HBASE-22852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907267#comment-16907267
]
Sean Busbey commented on HBASE-22852:
-
how sloppy of me. Luckily we just load up the project KEYS file so we can
verify artifacts, so we're def not concerned about other processes on the node
getting access.
> hbase nightlies leaking gpg-agents
> --
>
> Key: HBASE-22852
> URL: https://issues.apache.org/jira/browse/HBASE-22852
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Allen Wittenauer
>Priority: Major
>
> FYI, just triggered yetus master, which includes code to find and kill
> long-running processes still attached to the Jenkins workspace directory. It
> came up with this:
> https://builds.apache.org/view/S-Z/view/Yetus/job/yetus-github-multibranch/job/master/134/console
> {code}
> USER PID %CPU %MEMVSZ RSS TTY STAT START TIME COMMAND
> jenkins752 0.0 0.0 93612 584 ?Ss Aug12 0:00 gpg-agent
> --homedir
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_HBASE-20952/downloads-hadoop-2/.gpg
> --use-standard-socket --daemon
> Killing 752 ***
> {code}
> (repeat 10s of times, which slightly different dates, pids, versions, etc)
> Also, be aware that any other process running on the node (such as the other
> executor) has extremely easy access to whatever gpg creds you are using...
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature
Apache-HBase commented on issue #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature URL: https://github.com/apache/hbase/pull/485#issuecomment-521249997 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 36 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 325 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 77 | master passed | | +1 | shadedjars | 271 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 38 | master passed | | 0 | spotbugs | 246 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 243 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 297 | the patch passed | | +1 | compile | 50 | the patch passed | | +1 | javac | 50 | the patch passed | | -1 | checkstyle | 73 | hbase-server: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 269 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 918 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 244 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 6862 | hbase-server in the patch passed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 10201 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/485 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d1f755e8aea1 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/6/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/6/testReport/ | | Max. process+thread count | 4872 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907283#comment-16907283
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #208 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/208/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/208//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/208//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/208//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22013) SpaceQuota utilization issue with region replicas enabled
[
https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907307#comment-16907307
]
HBase QA commented on HBASE-22013:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
59s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
49s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 50s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}177m
17s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}236m 11s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/771/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22013 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977131/HBASE-22013.master.v001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 18be99afdcf5 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2
18:22:20 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 27ed2ac071 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/771/testReport/ |
| Max. process+thread count | 4553 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/771/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> SpaceQuota utiliza
[jira] [Commented] (HBASE-22852) hbase nightlies leaking gpg-agents
[
https://issues.apache.org/jira/browse/HBASE-22852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907326#comment-16907326
]
Duo Zhang commented on HBASE-22852:
---
So at least we should kill these processes at the end?
> hbase nightlies leaking gpg-agents
> --
>
> Key: HBASE-22852
> URL: https://issues.apache.org/jira/browse/HBASE-22852
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Allen Wittenauer
>Priority: Major
>
> FYI, just triggered yetus master, which includes code to find and kill
> long-running processes still attached to the Jenkins workspace directory. It
> came up with this:
> https://builds.apache.org/view/S-Z/view/Yetus/job/yetus-github-multibranch/job/master/134/console
> {code}
> USER PID %CPU %MEMVSZ RSS TTY STAT START TIME COMMAND
> jenkins752 0.0 0.0 93612 584 ?Ss Aug12 0:00 gpg-agent
> --homedir
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_HBASE-20952/downloads-hadoop-2/.gpg
> --use-standard-socket --daemon
> Killing 752 ***
> {code}
> (repeat 10s of times, which slightly different dates, pids, versions, etc)
> Also, be aware that any other process running on the node (such as the other
> executor) has extremely easy access to whatever gpg creds you are using...
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22214) [2.x] Backport missing filter improvements
[ https://issues.apache.org/jira/browse/HBASE-22214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907333#comment-16907333 ] stack commented on HBASE-22214: --- Oh. I see. Just backported HBASE-19008 and HBASE-21129. No patch associated w/ this JIRA. Thanks. > [2.x] Backport missing filter improvements > -- > > Key: HBASE-22214 > URL: https://issues.apache.org/jira/browse/HBASE-22214 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 2.0.6, 2.1.5 > > > HBASE-19008 and HBASE-21129 were never backported beyond branch-2. I can't > find any reason that this was not done. Despite these being public-tagged > classes, no incompatible changes were added. > The lack of these changes prevents HBASE-22144 from being backported cleanly. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22214) [2.x] Backport missing filter improvements
[ https://issues.apache.org/jira/browse/HBASE-22214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907333#comment-16907333 ] stack edited comment on HBASE-22214 at 8/14/19 3:04 PM: Oh. I see. Just backported HBASE-19008 and HBASE-21129. No patch associated w/ this JIRA. Which explains why no corresponding commit in the git log. Thanks. was (Author: stack): Oh. I see. Just backported HBASE-19008 and HBASE-21129. No patch associated w/ this JIRA. Thanks. > [2.x] Backport missing filter improvements > -- > > Key: HBASE-22214 > URL: https://issues.apache.org/jira/browse/HBASE-22214 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 2.0.6, 2.1.5 > > > HBASE-19008 and HBASE-21129 were never backported beyond branch-2. I can't > find any reason that this was not done. Despite these being public-tagged > classes, no incompatible changes were added. > The lack of these changes prevents HBASE-22144 from being backported cleanly. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22838) assembly:single failure: user id or group id 'xxxxx' is too big
[
https://issues.apache.org/jira/browse/HBASE-22838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907348#comment-16907348
]
stack commented on HBASE-22838:
---
Added to branch-2.0.
> assembly:single failure: user id or group id 'x' is too big
> ---
>
> Key: HBASE-22838
> URL: https://issues.apache.org/jira/browse/HBASE-22838
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 3.0.0, 1.5.0, 2.3.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
>
> tarball build with assembly:single command fails with user id(mac) or group
> id(ubuntu) too big error:
> {code:java}
> $ mvn clean install package assembly:single -DskipTests
>
>
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:3.0.0:single (default-cli) on
> project hbase-assembly: Execution default-cli of goal
> org.apache.maven.plugins:maven-assembly-plugin:3.0.0:single failed: user id
> '' is too big ( > 2097151 ). -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :hbase-assembly
> {code}
> To avoid this error and to get better features for tarball build, we should
> upgrade tarLongFileMode from gnu to posix: MPOM-132
> This works for assembly plugin >= 2.5.0: MASSEMBLY-728
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
Apache-HBase commented on issue #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot URL: https://github.com/apache/hbase/pull/486#issuecomment-521294847 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 84 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 40 | Maven dependency ordering for branch | | +1 | mvninstall | 455 | master passed | | +1 | compile | 96 | master passed | | +1 | checkstyle | 136 | master passed | | +1 | shadedjars | 376 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 64 | master passed | | 0 | spotbugs | 308 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 366 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 413 | the patch passed | | +1 | compile | 100 | the patch passed | | +1 | javac | 100 | the patch passed | | -1 | checkstyle | 104 | hbase-server: The patch generated 3 new + 162 unchanged - 7 fixed = 165 total (was 169) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 371 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1282 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 65 | the patch passed | | +1 | findbugs | 393 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 204 | hbase-common in the patch passed. | | -1 | unit | 13817 | hbase-server in the patch failed. | | +1 | asflicense | 66 | The patch does not generate ASF License warnings. | | | | 18990 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.client.TestFromClientSide3 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/486 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux cd6837ae2514 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-486/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/4/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/4/testReport/ | | Max. process+thread count | 4725 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22214) [2.x] Backport missing filter improvements
[ https://issues.apache.org/jira/browse/HBASE-22214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907369#comment-16907369 ] Josh Elser commented on HBASE-22214: Right on, Stack. > [2.x] Backport missing filter improvements > -- > > Key: HBASE-22214 > URL: https://issues.apache.org/jira/browse/HBASE-22214 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 2.0.6, 2.1.5 > > > HBASE-19008 and HBASE-21129 were never backported beyond branch-2. I can't > find any reason that this was not done. Despite these being public-tagged > classes, no incompatible changes were added. > The lack of these changes prevents HBASE-22144 from being backported cleanly. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22853) RC pre-run JIRA<->GIT sync tool
stack created HBASE-22853: - Summary: RC pre-run JIRA<->GIT sync tool Key: HBASE-22853 URL: https://issues.apache.org/jira/browse/HBASE-22853 Project: HBase Issue Type: Task Components: build Reporter: stack Before cutting RC, need to make reconciliation between what's in JIRA and then what has been actually committed to ensure JIRA is accurate before starting the RC build (in order to ensure CHANGES/RELEASENOTES are accurate, etc.). Would be good to have a tool that compared git log for the release to fixVersion in JIRA (and then fixVersion in JIRA to what is in git) to ensure matching mentions in both places. It can get complicated when there has been reverts in git or when an issue is an umbrella issue w/ no direct patch associated in JIRA but tool could start out simple dumping out a list of hashes/JIRAs for the RM to 'check' where anomalies; i.e. mention in one system but not in the other. This would save on a bunch of work aligning the two systems. Could also do stuff like check git log to ensure all commits have associated JIRA, and so on. (Should there be a PR component?). -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] titsuki opened a new pull request #493: HBASE-22833: MultiRowRangeFilter should provide a method for creating…
titsuki opened a new pull request #493: HBASE-22833: MultiRowRangeFilter should provide a method for creating… URL: https://github.com/apache/hbase/pull/493 … a filter which is functionally equivalent to multiple prefix filters This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22854) Remove +x shell spew from do-release-*.sh create-release scripts
stack created HBASE-22854: - Summary: Remove +x shell spew from do-release-*.sh create-release scripts Key: HBASE-22854 URL: https://issues.apache.org/jira/browse/HBASE-22854 Project: HBase Issue Type: Improvement Reporter: stack Remove the +x from the create-release scripts now they seem to be working. Can consult build log anyways if issue. Also did minor tuneup to the 'making a release candidate doc' and add a README in the create-release dir that points there in case poor dev can't figure what this dir is all about. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (HBASE-22854) Remove +x shell spew from do-release-*.sh create-release scripts
[ https://issues.apache.org/jira/browse/HBASE-22854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-22854. --- Resolution: Fixed Assignee: stack Pushed on master. > Remove +x shell spew from do-release-*.sh create-release scripts > > > Key: HBASE-22854 > URL: https://issues.apache.org/jira/browse/HBASE-22854 > Project: HBase > Issue Type: Improvement >Reporter: stack >Assignee: stack >Priority: Major > > Remove the +x from the create-release scripts now they seem to be working. > Can consult build log anyways if issue. Also did minor tuneup to the 'making > a release candidate doc' and add a README in the create-release dir that > points there in case poor dev can't figure what this dir is all about. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22854) Remove +x shell spew from do-release-*.sh create-release scripts
[ https://issues.apache.org/jira/browse/HBASE-22854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22854: -- Attachment: 0001-HBASE-22854-Remove-x-shell-spew-from-do-release-.sh-.patch > Remove +x shell spew from do-release-*.sh create-release scripts > > > Key: HBASE-22854 > URL: https://issues.apache.org/jira/browse/HBASE-22854 > Project: HBase > Issue Type: Improvement >Reporter: stack >Assignee: stack >Priority: Major > Attachments: > 0001-HBASE-22854-Remove-x-shell-spew-from-do-release-.sh-.patch > > > Remove the +x from the create-release scripts now they seem to be working. > Can consult build log anyways if issue. Also did minor tuneup to the 'making > a release candidate doc' and add a README in the create-release dir that > points there in case poor dev can't figure what this dir is all about. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22854) Remove +x shell spew from do-release-*.sh create-release scripts
[ https://issues.apache.org/jira/browse/HBASE-22854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907454#comment-16907454 ] stack edited comment on HBASE-22854 at 8/14/19 5:08 PM: .0001 is what I pushed on master. was (Author: stack): Pushed on master. > Remove +x shell spew from do-release-*.sh create-release scripts > > > Key: HBASE-22854 > URL: https://issues.apache.org/jira/browse/HBASE-22854 > Project: HBase > Issue Type: Improvement >Reporter: stack >Assignee: stack >Priority: Major > Attachments: > 0001-HBASE-22854-Remove-x-shell-spew-from-do-release-.sh-.patch > > > Remove the +x from the create-release scripts now they seem to be working. > Can consult build log anyways if issue. Also did minor tuneup to the 'making > a release candidate doc' and add a README in the create-release dir that > points there in case poor dev can't figure what this dir is all about. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22854) Remove +x shell spew from do-release-*.sh create-release scripts
[ https://issues.apache.org/jira/browse/HBASE-22854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22854: -- Component/s: RC > Remove +x shell spew from do-release-*.sh create-release scripts > > > Key: HBASE-22854 > URL: https://issues.apache.org/jira/browse/HBASE-22854 > Project: HBase > Issue Type: Improvement > Components: RC >Reporter: stack >Assignee: stack >Priority: Major > Attachments: > 0001-HBASE-22854-Remove-x-shell-spew-from-do-release-.sh-.patch > > > Remove the +x from the create-release scripts now they seem to be working. > Can consult build log anyways if issue. Also did minor tuneup to the 'making > a release candidate doc' and add a README in the create-release dir that > points there in case poor dev can't figure what this dir is all about. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline updated HBASE-22804: - Attachment: HBASE-22804.branch-2.003.patch HBASE-22804.branch-1.003.patch > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, > HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, > HBASE-22804.branch-2.003.patch, HBASE-22804.master.001.patch, > HBASE-22804.master.002.patch, HBASE-22804.master.003.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-521337265 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 75 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 32 | Maven dependency ordering for branch | | +1 | mvninstall | 369 | master passed | | +1 | compile | 79 | master passed | | +1 | checkstyle | 122 | master passed | | +1 | shadedjars | 313 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 59 | master passed | | 0 | spotbugs | 289 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 342 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 347 | the patch passed | | +1 | compile | 91 | the patch passed | | +1 | javac | 91 | the patch passed | | +1 | checkstyle | 29 | hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50) | | +1 | checkstyle | 95 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 319 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1080 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 56 | the patch passed | | -1 | findbugs | 61 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 180 | hbase-common in the patch passed. | | -1 | unit | 13436 | hbase-server in the patch failed. | | +1 | asflicense | 52 | The patch does not generate ASF License warnings. | | | | 17863 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.nio.MultiByteBuff$1.next() can't throw NoSuchElementException At MultiByteBuff.java:At MultiByteBuff.java:[line 66] | | Failed junit tests | hadoop.hbase.client.TestMobSnapshotCloneIndependence | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux cf1714ae9789 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/8/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/8/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/8/testReport/ | | Max. process+thread count | 4800 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907472#comment-16907472
]
Rushabh S Shah commented on HBASE-22601:
{noformat}
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 116.573
s - in org.apache.hadoop.hbase.regionserver.TestScannerHeartbeatMessages
[INFO] Running org.apache.hadoop.hbase.replication.TestReplicationSource
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 37.863 s
- in org.apache.hadoop.hbase.replication.TestReplicationSource
[INFO] Running
org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithTwoDifferentZKClusters
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 28.504 s
- in
org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithTwoDifferentZKClusters
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
{noformat}
I ran all the failed tests multiple times and it succeeded all the time. Could
someone please review the patch ?
> Misconfigured addition of peers leads to cluster shutdown.
> --
>
> Key: HBASE-22601
> URL: https://issues.apache.org/jira/browse/HBASE-22601
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.2
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Major
>
> Recently we added a peer to a production cluster which were in different
> kerberos realm.
> *Steps to reproduce:*
> 1. Add a misconfigured peer which is in different kerberos realm.
> 2. Remove that peer.
> 3. All region servers will start to crash.
> *RCA*
> Enabled trace logging on one Region server for a short amount of time.
> After adding peer, saw the following log lines.
> {noformat}
> 2019-06-18 22:19:20,949 INFO [main-EventThread]
> replication.ReplicationTrackerZKImpl - /hbase/replication/peers znode
> expired, triggering peerListChanged event
> 2019-06-18 22:19:20,992 INFO [main-EventThread]
> replication.ReplicationPeersZKImpl - Added new peer
> cluster=:/hbase
> 2019-06-18 22:19:21,113 INFO [main-EventThread]
> zookeeper.RecoverableZooKeeper - Process identifier=hconnection-0x794a56d6
> connecting to ZooKeeper ensemble=
> 2019-06-18 22:20:01,280 WARN [main-EventThread] zookeeper.ZKUtil -
> hconnection-0x794a56d6-0x16b56265fbebb1b, quorum=,
> baseZNode=/hbase Unable to set watcher on znode (/hbase/hbaseid)
> org.apache.zookeeper.KeeperException$AuthFailedException: KeeperErrorCode =
> AuthFailed for /hbase/hbaseid
> at
> org.apache.zookeeper.KeeperException.create(KeeperException.java:123)
> at
> org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1102)
> at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)
> at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:421)
> at
> org.apache.hadoop.hbase.zookeeper.ZKClusterId.readClusterIdZNode(ZKClusterId.java:65)
> at
> org.apache.hadoop.hbase.client.ZooKeeperRegistry.getClusterId(ZooKeeperRegistry.java:105)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.retrieveClusterId(ConnectionManager.java:922)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.(ConnectionManager.java:706)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.(ConnectionManager.java:638)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:238)
> at
> org.apache.hadoop.hbase.client.ConnectionManager.createConnection(ConnectionManager.java:432)
> at
> org.apache.hadoop.hbase.client.ConnectionManager.createConnectionInternal(ConnectionManager.java:341)
> at
> org.apache.hadoop.hbase.client.HConnectionManager.createConnection(HConnectionManager.java:144)
> at
> org.apache.hadoop.hbase.replication.regionserver.HBaseInterClusterReplicationEndpoint.init(HBaseInterClusterReplicationEndpoint.java:135)
> at
> com.salesforce.hbase.replication.TenantReplicationEndpoint.init(TenantReplicationEndpoint.java:30)
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.getReplicationSource(ReplicationSourceManager.java
[jira] [Comment Edited] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.
[
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907472#comment-16907472
]
Rushabh S Shah edited comment on HBASE-22601 at 8/14/19 5:26 PM:
-
{noformat}
[INFO] ---
[INFO] T E S T S
[INFO] ---
[INFO] Running org.apache.hadoop.hbase.regionserver.TestScannerHeartbeatMessages
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 116.573
s - in org.apache.hadoop.hbase.regionserver.TestScannerHeartbeatMessages
[INFO] Running org.apache.hadoop.hbase.replication.TestReplicationSource
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 37.863 s
- in org.apache.hadoop.hbase.replication.TestReplicationSource
[INFO] Running
org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithTwoDifferentZKClusters
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 28.504 s
- in
org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithTwoDifferentZKClusters
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
{noformat}
I ran all the failed tests multiple times and it succeeded all the time. Could
someone please review the patch ?
was (Author: shahrs87):
{noformat}
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 116.573
s - in org.apache.hadoop.hbase.regionserver.TestScannerHeartbeatMessages
[INFO] Running org.apache.hadoop.hbase.replication.TestReplicationSource
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 37.863 s
- in org.apache.hadoop.hbase.replication.TestReplicationSource
[INFO] Running
org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithTwoDifferentZKClusters
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 28.504 s
- in
org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithTwoDifferentZKClusters
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
{noformat}
I ran all the failed tests multiple times and it succeeded all the time. Could
someone please review the patch ?
> Misconfigured addition of peers leads to cluster shutdown.
> --
>
> Key: HBASE-22601
> URL: https://issues.apache.org/jira/browse/HBASE-22601
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.2
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Major
>
> Recently we added a peer to a production cluster which were in different
> kerberos realm.
> *Steps to reproduce:*
> 1. Add a misconfigured peer which is in different kerberos realm.
> 2. Remove that peer.
> 3. All region servers will start to crash.
> *RCA*
> Enabled trace logging on one Region server for a short amount of time.
> After adding peer, saw the following log lines.
> {noformat}
> 2019-06-18 22:19:20,949 INFO [main-EventThread]
> replication.ReplicationTrackerZKImpl - /hbase/replication/peers znode
> expired, triggering peerListChanged event
> 2019-06-18 22:19:20,992 INFO [main-EventThread]
> replication.ReplicationPeersZKImpl - Added new peer
> cluster=:/hbase
> 2019-06-18 22:19:21,113 INFO [main-EventThread]
> zookeeper.RecoverableZooKeeper - Process identifier=hconnection-0x794a56d6
> connecting to ZooKeeper ensemble=
> 2019-06-18 22:20:01,280 WARN [main-EventThread] zookeeper.ZKUtil -
> hconnection-0x794a56d6-0x16b56265fbebb1b, quorum=,
> baseZNode=/hbase Unable to set watcher on znode (/hbase/hbaseid)
> org.apache.zookeeper.KeeperException$AuthFailedException: KeeperErrorCode =
> AuthFailed for /hbase/hbaseid
> at
> org.apache.zookeeper.KeeperException.create(KeeperException.java:123)
> at
> org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1102)
> at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)
> at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:421)
> at
> org.apache.hadoop.hbase.zookeeper.ZKClusterId.readClusterIdZNode(ZKClusterId.java:65)
> at
> org.apache.hadoop.hbase.client.ZooKeeperRegistry.getClusterId(ZooKeeperRegistry.java:105)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.retrieveClusterId(ConnectionManager.java:922)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.(ConnectionManager.java:706)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.(ConnectionManager.java:638)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(
[jira] [Commented] (HBASE-22774) [WAL] RegionGroupingStrategy loses its function after split
[
https://issues.apache.org/jira/browse/HBASE-22774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907489#comment-16907489
]
Hudson commented on HBASE-22774:
Results for branch branch-1.3
[build #918 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/918/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/918//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/918//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/918//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> [WAL] RegionGroupingStrategy loses its function after split
> ---
>
> Key: HBASE-22774
> URL: https://issues.apache.org/jira/browse/HBASE-22774
> Project: HBase
> Issue Type: Bug
> Components: Performance, wal
>Affects Versions: 1.4.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22774.branch-1.001.patch,
> HBASE-22774.branch-1.002.patch
>
>
> Having {{hbase.wal.provider}} set {{multiwal}}, it works fine on regionserver
> restart, at the beginning.
> But when region split happened, those daughter regions would inherit her
> parent's WAL, which violates the setting. For example, when
> {{hbase.wal.regiongrouping.strategy}} set {{identity}}, each daughter regions
> should create its own WAL instead of inheriting.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions
Apache-HBase commented on issue #487: HBASE-22844 Fixed Checkstyle violations in client snapshot exceptions URL: https://github.com/apache/hbase/pull/487#issuecomment-521353036 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 333 | master passed | | +1 | compile | 23 | master passed | | +1 | checkstyle | 31 | master passed | | +1 | shadedjars | 277 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | master passed | | 0 | spotbugs | 71 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 70 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 305 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 30 | hbase-client: The patch generated 0 new + 0 unchanged - 13 fixed = 0 total (was 13) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 281 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 964 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 21 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 | findbugs | 75 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 106 | hbase-client in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 2983 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/487 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9f6a6c729385 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-487/out/precommit/personality/provided.sh | | git revision | master / 53db390f60 | | Default Java | 1.8.0_181 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/4/artifact/out/diff-javadoc-javadoc-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/4/testReport/ | | Max. process+thread count | 293 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-487/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22774) [WAL] RegionGroupingStrategy loses its function after split
[
https://issues.apache.org/jira/browse/HBASE-22774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907504#comment-16907504
]
Hudson commented on HBASE-22774:
Results for branch branch-1.4
[build #957 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/957/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/957//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/957//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/957//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> [WAL] RegionGroupingStrategy loses its function after split
> ---
>
> Key: HBASE-22774
> URL: https://issues.apache.org/jira/browse/HBASE-22774
> Project: HBase
> Issue Type: Bug
> Components: Performance, wal
>Affects Versions: 1.4.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22774.branch-1.001.patch,
> HBASE-22774.branch-1.002.patch
>
>
> Having {{hbase.wal.provider}} set {{multiwal}}, it works fine on regionserver
> restart, at the beginning.
> But when region split happened, those daughter regions would inherit her
> parent's WAL, which violates the setting. For example, when
> {{hbase.wal.regiongrouping.strategy}} set {{identity}}, each daughter regions
> should create its own WAL instead of inheriting.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-521356437 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 61 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 326 | master passed | | +1 | compile | 22 | master passed | | +1 | checkstyle | 11 | master passed | | +1 | shadedjars | 274 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 19 | master passed | | 0 | spotbugs | 49 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 47 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 464 | the patch passed | | +1 | compile | 62 | the patch passed | | +1 | javac | 62 | the patch passed | | +1 | checkstyle | 13 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 267 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 936 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 19 | the patch passed | | +1 | findbugs | 51 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 588 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3523 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/88/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 545fbc769302 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 53db390f60 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/88/testReport/ | | Max. process+thread count | 4420 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/88/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] jatsakthi opened a new pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
jatsakthi opened a new pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758 URL: https://github.com/apache/hbase-operator-tools/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22843) [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
[
https://issues.apache.org/jira/browse/HBASE-22843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907523#comment-16907523
]
Sakthi commented on HBASE-22843:
[~stack], I plan to do the former one. I have my draft patch as a PR (#14)
which is linked over here. Could you please take a look & guide if I have
strayed away from the path? :)
> [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
> -
>
> Key: HBASE-22843
> URL: https://issues.apache.org/jira/browse/HBASE-22843
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-operator-tools
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Blocker
>
> There were few changes made in HBASE-22777 & HBASE-22758, which would require
> their propogation to HBCK2 as well to prevent compilation issues. These are
> the ones:
> 1. MetaTableAccessor#makePutFromTableState was changed from public to
> private. HBCK2 uses it in HBaseFsck#generatePuts() for rebuildMeta(). We
> either need to revert the change to public or make similar adjustments in
> HBCK2.
> 2.
> {code:java}
> -PairOfSameType getMergeRegions(Result data)
> +List getMergeRegions(Cell[] cells){code}
> Due to this change, HBaseFsck was fixed accordingly but not HBCK2. Let's do
> it there as well.
> 3. MetaTableAccessor#deleteRegion() was renamed to
> MetaTableAccessor#deleteRegionInfo(). Even this should be integrated with
> HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22848) Set version as 2.1.6 in branch-2.1 in prep for first RC of 2.1.6
[
https://issues.apache.org/jira/browse/HBASE-22848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907526#comment-16907526
]
Hudson commented on HBASE-22848:
Results for branch branch-2.1
[build #1483 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1483/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1483//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1483//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1483//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Set version as 2.1.6 in branch-2.1 in prep for first RC of 2.1.6
>
>
> Key: HBASE-22848
> URL: https://issues.apache.org/jira/browse/HBASE-22848
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.1.6
>
> Attachments: HBASE-22848.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22799) Generate CHANGES.md and RELEASENOTES.md for 2.1.6
[
https://issues.apache.org/jira/browse/HBASE-22799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907525#comment-16907525
]
Hudson commented on HBASE-22799:
Results for branch branch-2.1
[build #1483 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1483/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1483//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1483//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1483//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Generate CHANGES.md and RELEASENOTES.md for 2.1.6
> -
>
> Key: HBASE-22799
> URL: https://issues.apache.org/jira/browse/HBASE-22799
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.1.6
>
> Attachments: HBASE-22799-addendum.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase-operator-tools] asf-ci commented on issue #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
asf-ci commented on issue #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758 URL: https://github.com/apache/hbase-operator-tools/pull/14#issuecomment-521364283 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/55/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] asf-ci commented on issue #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758
asf-ci commented on issue #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758 URL: https://github.com/apache/hbase-operator-tools/pull/14#issuecomment-521366650 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/56/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] wchevreuil opened a new pull request #494: HBASE-22380 break circle replication when doing bulkload
wchevreuil opened a new pull request #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494 Creating an initial PR on branch-2. Had done some manual tests within two single node cluster and it seems to work. Am gonna work on UTs tomorrow and update this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] wchevreuil commented on issue #494: HBASE-22380 break circle replication when doing bulkload
wchevreuil commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-521375953 Also need to work on some javadocs for modified interfaces. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22380) break circle replication when doing bulkload
[ https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907544#comment-16907544 ] Wellington Chevreuil commented on HBASE-22380: -- Submitted an initial PR to branch-2. Have just gone through manual tests yet, seems to work between two clusters. Let me know if this idea is ok, and I can proceed with UTs and extra polishing, such as reviewing javadocs for new/changed methods signature. > break circle replication when doing bulkload > > > Key: HBASE-22380 > URL: https://issues.apache.org/jira/browse/HBASE-22380 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.5, 1.3.5 >Reporter: chenxu >Assignee: Wellington Chevreuil >Priority: Critical > Labels: bulkload > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.1.7, 2.2.2 > > > when enabled master-master bulkload replication, HFiles will be replicated > circularly between two clusters -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work started] (HBASE-22380) break circle replication when doing bulkload
[ https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22380 started by Wellington Chevreuil. > break circle replication when doing bulkload > > > Key: HBASE-22380 > URL: https://issues.apache.org/jira/browse/HBASE-22380 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.5, 1.3.5 >Reporter: chenxu >Assignee: Wellington Chevreuil >Priority: Critical > Labels: bulkload > Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.1.7, 2.2.2 > > > when enabled master-master bulkload replication, HFiles will be replicated > circularly between two clusters -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[
https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907561#comment-16907561
]
Hudson commented on HBASE-22771:
Results for branch branch-2.2
[build #515 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/515/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/515//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/515//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/515//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [HBCK2] fixMeta method and server-side support
> --
>
> Key: HBASE-22771
> URL: https://issues.apache.org/jira/browse/HBASE-22771
> Project: HBase
> Issue Type: Sub-task
> Components: hbck2
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22771.master.001.patch,
> HBASE-22771.master.002.patch, HBASE-22771.master.003.patch,
> HBASE-22771.master.004.patch
>
>
> Add a fixMeta method to hbck Service.
> HBCK2 tool in hbase-operator-tools will use this if it is available otherwise
> it will do its own client-side version. Making these server-side versions so
> can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version.
> This does pure meta fixup plug holes and fix overlaps.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22851) Preparing HBase release 2.2.1RC0: set version to 2.2.1 in branch-2.2
[
https://issues.apache.org/jira/browse/HBASE-22851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907563#comment-16907563
]
Hudson commented on HBASE-22851:
Results for branch branch-2.2
[build #515 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/515/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/515//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/515//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/515//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Preparing HBase release 2.2.1RC0: set version to 2.2.1 in branch-2.2
>
>
> Key: HBASE-22851
> URL: https://issues.apache.org/jira/browse/HBASE-22851
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22850) Generate CHANGES.md and RELEASENOTES.md for 2.2.1
[
https://issues.apache.org/jira/browse/HBASE-22850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907562#comment-16907562
]
Hudson commented on HBASE-22850:
Results for branch branch-2.2
[build #515 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/515/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/515//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/515//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/515//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Generate CHANGES.md and RELEASENOTES.md for 2.2.1
> -
>
> Key: HBASE-22850
> URL: https://issues.apache.org/jira/browse/HBASE-22850
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 2.2.1
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #493: HBASE-22833 MultiRowRangeFilter should provide a method for creating…
Apache-HBase commented on issue #493: HBASE-22833 MultiRowRangeFilter should provide a method for creating… URL: https://github.com/apache/hbase/pull/493#issuecomment-521389192 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 339 | master passed | | +1 | compile | 82 | master passed | | +1 | checkstyle | 110 | master passed | | +1 | shadedjars | 292 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 63 | master passed | | 0 | spotbugs | 275 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 349 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 311 | the patch passed | | +1 | compile | 85 | the patch passed | | +1 | javac | 85 | the patch passed | | -1 | checkstyle | 29 | hbase-client: The patch generated 3 new + 15 unchanged - 1 fixed = 18 total (was 16) | | -1 | checkstyle | 83 | hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 291 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 989 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 56 | the patch passed | | +1 | findbugs | 362 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 112 | hbase-client in the patch passed. | | +1 | unit | 6740 | hbase-server in the patch passed. | | +1 | asflicense | 59 | The patch does not generate ASF License warnings. | | | | 10823 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/493 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fa02af3a4b63 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-493/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/2/artifact/out/diff-checkstyle-hbase-client.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/2/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/2/testReport/ | | Max. process+thread count | 5186 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-493/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-521392582 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 77 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 55 | Maven dependency ordering for branch | | +1 | mvninstall | 310 | master passed | | +1 | compile | 81 | master passed | | +1 | checkstyle | 98 | master passed | | +1 | shadedjars | 297 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 53 | master passed | | 0 | spotbugs | 237 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 285 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 308 | the patch passed | | +1 | compile | 77 | the patch passed | | +1 | javac | 77 | the patch passed | | +1 | checkstyle | 24 | hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50) | | +1 | checkstyle | 73 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 294 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 952 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 54 | the patch passed | | -1 | findbugs | 56 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 180 | hbase-common in the patch passed. | | -1 | unit | 13392 | hbase-server in the patch failed. | | +1 | asflicense | 60 | The patch does not generate ASF License warnings. | | | | 17391 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.nio.MultiByteBuff$1.next() can't throw NoSuchElementException At MultiByteBuff.java:At MultiByteBuff.java:[lines 66-67] | | Failed junit tests | hadoop.hbase.client.TestFromClientSide3 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0721a3d48f72 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / 27ed2ac071 | | Default Java | 1.8.0_181 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/9/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/9/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/9/testReport/ | | Max. process+thread count | 4710 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature
Apache-HBase commented on issue #485: HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature URL: https://github.com/apache/hbase/pull/485#issuecomment-521397526 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 325 | master passed | | +1 | compile | 51 | master passed | | +1 | checkstyle | 74 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 248 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 246 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 298 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | -1 | checkstyle | 74 | hbase-server: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 915 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 32 | the patch passed | | +1 | findbugs | 239 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 7131 | hbase-server in the patch passed. | | +1 | asflicense | 32 | The patch does not generate ASF License warnings. | | | | 10451 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/485 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1407a5b3e703 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh | | git revision | master / 53db390f60 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/7/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/7/testReport/ | | Max. process+thread count | 4042 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/7/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-521398572 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 44 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 351 | master passed | | +1 | compile | 57 | master passed | | +1 | checkstyle | 75 | master passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 252 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 249 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 295 | the patch passed | | +1 | compile | 52 | the patch passed | | +1 | javac | 52 | the patch passed | | +1 | checkstyle | 71 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 910 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 32 | the patch passed | | +1 | findbugs | 244 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 7281 | hbase-server in the patch passed. | | +1 | asflicense | 23 | The patch does not generate ASF License warnings. | | | | 10614 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/19/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/468 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux bd2a9d4b1f7a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh | | git revision | master / 53db390f60 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/19/testReport/ | | Max. process+thread count | 4679 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/19/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot
Apache-HBase commented on issue #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot URL: https://github.com/apache/hbase/pull/486#issuecomment-521398602 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 39 | Maven dependency ordering for branch | | +1 | mvninstall | 340 | master passed | | +1 | compile | 74 | master passed | | +1 | checkstyle | 93 | master passed | | +1 | shadedjars | 263 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 54 | master passed | | 0 | spotbugs | 257 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 305 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 286 | the patch passed | | +1 | compile | 71 | the patch passed | | +1 | javac | 71 | the patch passed | | -1 | checkstyle | 69 | hbase-server: The patch generated 3 new + 162 unchanged - 7 fixed = 165 total (was 169) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 893 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 55 | the patch passed | | +1 | findbugs | 310 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 174 | hbase-common in the patch passed. | | -1 | unit | 6870 | hbase-server in the patch failed. | | +1 | asflicense | 38 | The patch does not generate ASF License warnings. | | | | 10643 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/486 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2b37abec7345 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-486/out/precommit/personality/provided.sh | | git revision | master / 53db390f60 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/5/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/5/testReport/ | | Max. process+thread count | 4656 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-486/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-521399423 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 332 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 71 | master passed | | +1 | shadedjars | 262 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 267 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 265 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 305 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | +1 | checkstyle | 71 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 265 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 934 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 36 | the patch passed | | +1 | findbugs | 269 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 7341 | hbase-server in the patch passed. | | +1 | asflicense | 38 | The patch does not generate ASF License warnings. | | | | 10744 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/42/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/446 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 49bbba810e8b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh | | git revision | master / 53db390f60 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/42/testReport/ | | Max. process+thread count | 4197 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/42/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-521399154 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 336 | master passed | | +1 | compile | 57 | master passed | | +1 | checkstyle | 74 | master passed | | +1 | shadedjars | 265 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 40 | master passed | | 0 | spotbugs | 267 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 265 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 309 | the patch passed | | +1 | compile | 58 | the patch passed | | +1 | javac | 58 | the patch passed | | +1 | checkstyle | 71 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 262 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 901 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 271 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 7339 | hbase-server in the patch passed. | | +1 | asflicense | 31 | The patch does not generate ASF License warnings. | | | | 10715 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/50/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2f9f92cd9447 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439/out/precommit/personality/provided.sh | | git revision | master / 53db390f60 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/50/testReport/ | | Max. process+thread count | 4071 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/50/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-521401937 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 41 | Maven dependency ordering for branch | | +1 | mvninstall | 312 | master passed | | +1 | compile | 77 | master passed | | +1 | checkstyle | 97 | master passed | | +1 | shadedjars | 265 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 51 | master passed | | 0 | spotbugs | 253 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 301 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 296 | the patch passed | | +1 | compile | 73 | the patch passed | | +1 | javac | 73 | the patch passed | | +1 | checkstyle | 24 | hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50) | | +1 | checkstyle | 69 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 257 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 903 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 60 | the patch passed | | -1 | findbugs | 61 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 175 | hbase-common in the patch passed. | | -1 | unit | 7402 | hbase-server in the patch failed. | | +1 | asflicense | 48 | The patch does not generate ASF License warnings. | | | | 11201 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.nio.MultiByteBuff$1.next() can't throw NoSuchElementException At MultiByteBuff.java:At MultiByteBuff.java:[lines 66-67] | | Failed junit tests | hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8e60fb1ccdba 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / 53db390f60 | | Default Java | 1.8.0_181 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/10/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/10/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/10/testReport/ | | Max. process+thread count | 4510 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
