[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316304#comment-15316304
]
Hudson commented on HBASE-15174:
FAILURE: Integrated in HBase-Trunk_matrix #996 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/996/])
HBASE-15174 Client Public API should not have PB objects in 2.0 (Ram)
(ramkrishna: rev b21c56e7958652ca6e6daf04642eb51abaf2b3d7)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionLoadStats.java
*
hbase-client/src/test/java/org/apache/hadoop/hbase/TestInterfaceAudienceAnnotations.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/util/Triple.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/RegionLoad.java
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-15174.patch, HBASE-15174_1.patch,
> HBASE-15174_2.patch, HBASE-15174_3.patch, HBASE-15174_4.patch,
> HBASE-15174_5.patch
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314701#comment-15314701
]
Enis Soztutar commented on HBASE-15174:
---
Looks good to go.
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-15174.patch, HBASE-15174_1.patch,
> HBASE-15174_2.patch, HBASE-15174_3.patch, HBASE-15174_4.patch
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314477#comment-15314477
]
stack commented on HBASE-15174:
---
This looks excellent. Only comment is that the classfinder seems to be the same
in all three methods? If so, make a method of it and maybe better still, reuse
the found list of classes (this is a nit).
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-15174.patch, HBASE-15174_1.patch,
> HBASE-15174_2.patch, HBASE-15174_3.patch, HBASE-15174_4.patch
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314479#comment-15314479
]
stack commented on HBASE-15174:
---
Can be addressed on commit.
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-15174.patch, HBASE-15174_1.patch,
> HBASE-15174_2.patch, HBASE-15174_3.patch, HBASE-15174_4.patch
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313892#comment-15313892
]
ramkrishna.s.vasudevan commented on HBASE-15174:
Should be good to go now. [~enis], [~saint@gmail.com]?
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-15174.patch, HBASE-15174_1.patch,
> HBASE-15174_2.patch, HBASE-15174_3.patch, HBASE-15174_4.patch
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313807#comment-15313807
]
Hadoop QA commented on HBASE-15174:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
57s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
42s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
37s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 47s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 47s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
26m 41s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 45s
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 56s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 45m 52s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12807902/HBASE-15174_4.patch |
| JIRA Issue | HBASE-15174 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
|
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313755#comment-15313755
]
ramkrishna.s.vasudevan commented on HBASE-15174:
{code}
location: class org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/hbase-client/src/test/java/org/apache/hadoop/hbase/TestInterfaceAudienceAnnotations.java:[368,48]
cannot find symbol
symbol: class Parameter
location: class org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/hbase-client/src/test/java/org/apache/hadoop/hbase/TestInterfaceAudienceAnnotations.java:[375,37]
cannot find symbol
symbol: class Parameter
location: class org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/hbase-client/src/test/java/org/apache/hadoop/hbase/TestInterfaceAudienceAnnotations.java:[399,11]
cannot find symbol
symbol: class Parameter
location: class org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations
{code}
I think Parameters is not part of jdk 1.7. Hence the compilation failure. How
to over come this?
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-15174.patch, HBASE-15174_1.patch,
> HBASE-15174_2.patch, HBASE-15174_3.patch
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313726#comment-15313726
]
Hadoop QA commented on HBASE-15174:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
8s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
40s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 19s
{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 51s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 17s
{color} | {color:red} hbase-client in the patch failed with JDK v1.7.0_79.
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 17s {color}
| {color:red} hbase-client in the patch failed with JDK v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
20s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m 35s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.4.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 11s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 47s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 23s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 59s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.5.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 36s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 12s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 48s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 24s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.7.1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 12s
{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s
{color} |
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312810#comment-15312810
]
Enis Soztutar commented on HBASE-15174:
---
Thanks [~ram_krish]. Instead of adding ServerLoadProtosWrapper and
RegionLoadProtosWrapper, we can instead annotate the constructors of RegionLoad
and ServerLoad with InterfaceAudience.Private. The public API for both is for
the users to call various get methods, so constructors can be treated as
private API.
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-15174.patch, HBASE-15174_1.patch,
> HBASE-15174_2.patch
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312185#comment-15312185
]
Hadoop QA commented on HBASE-15174:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
6s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 25s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
35s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
33s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 17s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 8s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 17s
{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 22s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 25s
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0. {color}
|
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 25s {color}
| {color:red} hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 17s
{color} | {color:red} hbase-client in the patch failed with JDK v1.7.0_79.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 23s
{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_79.
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 17s {color}
| {color:red} hbase-client in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 23s {color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
34s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 1 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m 35s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.4.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 11s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 46s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 22s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 58s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.5.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 34s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 10s
{color} | {color:red} Patch causes 64 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311742#comment-15311742
]
ramkrishna.s.vasudevan commented on HBASE-15174:
I can upload the UT that i have to this JIRA.
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308198#comment-15308198
]
Enis Soztutar commented on HBASE-15174:
---
[~ramkrishna.s.vasude...@gmail.com] do you have the UT code to generate the
list above? We can turn that into a UT to make sure that new APIs will not
creep in with PB signatures. I can work on a patch if you want.
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305953#comment-15305953
]
Jurriaan Mous commented on HBASE-15174:
---
It seems all tasks are done so this issue can be closed?
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230703#comment-15230703
]
Enis Soztutar commented on HBASE-15174:
---
bq. we need to maintain a correpsonding state POJO or enum in the Admin itself
I think these can be top level POJOs in the client package, or inside
XXDescriptor objects.
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230700#comment-15230700
]
Enis Soztutar commented on HBASE-15174:
---
bq. Just noticed that, APIs like the above cannot be caught easily with this
tool because here the return is a List of SnapshotDescription.
Good point. I think we can inspect the generic types through reflection, it has
been some time I've looked at that area though.
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229967#comment-15229967
]
ramkrishna.s.vasudevan commented on HBASE-15174:
bq.List listSnapshots()
Just noticed that, APIs like the above cannot be caught easily with this tool
because here the return is a List of SnapshotDescription.
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229630#comment-15229630
]
ramkrishna.s.vasudevan commented on HBASE-15174:
I completed my analysis and all these items. Few are straight forward and few
can be directly removed.
But regarding the ones that depend on the PB's enum for different states, like
Admin getCompactionState() which returns the PB compaction state - we need to
maintain a correpsonding state POJO or enum in the Admin itself?
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229147#comment-15229147
]
Sean Busbey commented on HBASE-15174:
-
{quote}
All convert methods, ex. org.apache.hadoop.hbase.ClusterStatus convert() can go
to ProtobufUtil, so that they are not part of the public API.
{quote}
This is not necessary. We can just annotate the methods with IA.Private to
denote that they aren't in the public API.
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228735#comment-15228735
]
Enis Soztutar commented on HBASE-15174:
---
Great list. Most of these can be addressed with relative ease.
- All convert methods, ex. {{org.apache.hadoop.hbase.ClusterStatus convert()}}
can go to ProtobufUtil, so that they are not part of the public API.
- HConnection itself is deprecated. Maybe we should remove it in 2.0? If not,
we can remove those methods and make them part of ClusterConnection if needed.
- Snapshot descriptor / type should be top level POJO classes that correspond
to PB structures.
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228110#comment-15228110
]
ramkrishna.s.vasudevan commented on HBASE-15174:
The readability is a problem in the above comment, just noticed that.
Read it as the
(either as argument or return type).
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228103#comment-15228103
]
ramkrishna.s.vasudevan commented on HBASE-15174:
Following the suggestion by Enis, I got this following files and methods that
needs to be addressed as part of this JIRA
{code}
org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.ServerLoad obtainServerLoadPB()
org.apache.hadoop.hbase.protobuf.generated.ClusterStatusProtos$ServerLoad
org.apache.hadoop.hbase.client.UnmodifyableHTableDescriptor convert()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$TableSchema
org.apache.hadoop.hbase.snapshot.SnapshotExistsException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.ipc.RemoteWithExtrasException getErrorCode()
org.apache.hadoop.ipc.protobuf.RpcHeaderProtos$RpcResponseHeaderProto$RpcErrorCodeProto
org.apache.hadoop.hbase.snapshot.SnapshotCreationException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.ProcedureInfo getForeignExceptionMessage()
org.apache.hadoop.hbase.protobuf.generated.ErrorHandlingProtos$ForeignExceptionMessage
org.apache.hadoop.hbase.ProcedureInfo getProcState()
org.apache.hadoop.hbase.protobuf.generated.ProcedureProtos$ProcedureState
org.apache.hadoop.hbase.client.coprocessor.DoubleColumnInterpreter initialize()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$EmptyMsg
org.apache.hadoop.hbase.client.coprocessor.DoubleColumnInterpreter
getCellValueFromProto()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$DoubleMsg
org.apache.hadoop.hbase.client.coprocessor.DoubleColumnInterpreter
getPromotedValueFromProto()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$DoubleMsg
org.apache.hadoop.hbase.client.coprocessor.DoubleColumnInterpreter
getProtoForCellType()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$DoubleMsg
org.apache.hadoop.hbase.client.coprocessor.DoubleColumnInterpreter
getProtoForPromotedType()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$DoubleMsg
org.apache.hadoop.hbase.client.coprocessor.DoubleColumnInterpreter
getRequestData() org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$EmptyMsg
org.apache.hadoop.hbase.ClusterStatus convert()
org.apache.hadoop.hbase.protobuf.generated.ClusterStatusProtos$ClusterStatus
org.apache.hadoop.hbase.snapshot.CorruptedSnapshotException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.snapshot.HBaseSnapshotException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.snapshot.UnknownSnapshotException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.HTableDescriptor convert()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$TableSchema
org.apache.hadoop.hbase.client.HConnection getClient()
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$BlockingInterface
org.apache.hadoop.hbase.client.HConnection getAdmin()
org.apache.hadoop.hbase.protobuf.generated.AdminProtos$AdminService$BlockingInterface
org.apache.hadoop.hbase.client.HConnection getAdmin()
org.apache.hadoop.hbase.protobuf.generated.AdminProtos$AdminService$BlockingInterface
org.apache.hadoop.hbase.client.HConnection getMaster()
org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$BlockingInterface
org.apache.hadoop.hbase.snapshot.ExportSnapshotException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.HColumnDescriptor convert()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$ColumnFamilySchema
org.apache.hadoop.hbase.client.Result getStats()
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$RegionLoadStats
org.apache.hadoop.hbase.client.Result addResults()
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$RegionLoadStats
org.apache.hadoop.hbase.client.Result setStatistics()
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$RegionLoadStats
org.apache.hadoop.hbase.snapshot.RestoreSnapshotException
getSnapshotDescription()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.client.Admin snapshot()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription$Type
org.apache.hadoop.hbase.client.Admin snapshot()
org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$SnapshotDescription
org.apache.hadoop.hbase.client.Admin isSnapshotFinished()
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227685#comment-15227685
]
ramkrishna.s.vasudevan commented on HBASE-15174:
[~enis]
That looks like a good idea. Infact I had not thought about of how to go about
addressing this problem. We would any way next need our patched PB changes to
get in for all the reduction in GCs created. So if this task is a blocker for
that let us first complete it.
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
[
https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226778#comment-15226778
]
Enis Soztutar commented on HBASE-15174:
---
[~ram_krish] I was thinking that we can write a unit test for this so that it
does not happen again. The unit test can get the public method signatures of
all InterfaceAudience.Public classes and make sure that return values or
arguments are not PB. Something like TestInterfaceAudienceAnnotations. wdyt?
> Client Public API should not have PB objects in 2.0
> ---
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Blocker
> Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final
> TableName tableName)
> throws IOException;
>
>
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException,
> SnapshotCreationException,
> IllegalArgumentException;
>
> MasterProtos.SnapshotResponse
> takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
