[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204297#comment-16204297
]
Josh Elser commented on HBASE-18901:
Awesome. Thanks for the review. Let me get this committed and
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204275#comment-16204275
]
Enis Soztutar commented on HBASE-18901:
---
I was able to test v5 successfully. The build goes
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204209#comment-16204209
]
Enis Soztutar commented on HBASE-18901:
---
bq. we just need to make sure that we're consistently
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203939#comment-16203939
]
Josh Elser commented on HBASE-18901:
Some problems I'm seeing are related to the {{CXX11_ABI=0}}
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203030#comment-16203030
]
Josh Elser commented on HBASE-18901:
bq. This is definitely a defect. Let me see if I can come up
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203029#comment-16203029
]
Josh Elser commented on HBASE-18901:
bq. version.h is a generated file which is generated from the
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202752#comment-16202752
]
Enis Soztutar commented on HBASE-18901:
---
The v4 patch compilation failed for me:
{code}
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202759#comment-16202759
]
Enis Soztutar commented on HBASE-18901:
---
After running bin/copy-version.sh, I still get the build
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202728#comment-16202728
]
Enis Soztutar commented on HBASE-18901:
---
Also the naming should be {{libhbaseclient}}, or
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202695#comment-16202695
]
marco polo commented on HBASE-18901:
[~enis] That line should have been removed. I removed it in my
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202686#comment-16202686
]
Josh Elser commented on HBASE-18901:
bq. Shouldn't we remove the current Makefile in this patch as
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202679#comment-16202679
]
Enis Soztutar commented on HBASE-18901:
---
Great, this is a good start.
I think we should stick
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202594#comment-16202594
]
marco polo commented on HBASE-18901:
[~elserj] I agree with everything above. I most certainly do
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202586#comment-16202586
]
Josh Elser commented on HBASE-18901:
Let me just get a v3 together for Marc. He's already gone way
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202583#comment-16202583
]
Josh Elser commented on HBASE-18901:
Disclaimer: I've been working closely with [~phrocker] on this
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202386#comment-16202386
]
marco polo commented on HBASE-18901:
I'll be happy to provide some information in the README
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202351#comment-16202351
]
marco polo commented on HBASE-18901:
My apologies. the previous file was from my Mac where I was
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202248#comment-16202248
]
Josh Elser commented on HBASE-18901:
bq. There are quite several conflicts:
Looks like maybe we need
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202200#comment-16202200
]
Ted Yu commented on HBASE-18901:
What's the expectation w.r.t. QA run for the patch ?
To my knowledge,
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202178#comment-16202178
]
Ted Yu commented on HBASE-18901:
There are quite several conflicts:
-rw-r--r-- 1 tyu staff 451 Oct 12
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202166#comment-16202166
]
Hadoop QA commented on HBASE-18901:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202120#comment-16202120
]
Hadoop QA commented on HBASE-18901:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
22 matches
Mail list logo
