[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238476#comment-15238476 ] Ted Yu commented on HBASE-7066: --- [~toffer]: Can you pick this up, please ? > Some HMaster c

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651615#comment-13651615 ] Hudson commented on HBASE-7066: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #519 (See [https

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651614#comment-13651614 ] Hudson commented on HBASE-7066: --- Integrated in hbase-0.95-on-hadoop2 #90 (See [https://buil

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651419#comment-13651419 ] Ted Yu commented on HBASE-7066: --- @Francis: Since the original patch came from you, it would

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651416#comment-13651416 ] Francis Liu commented on HBASE-7066: I'd be willing to offer a up a patch for 0.94. Le

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651412#comment-13651412 ] Francis Liu commented on HBASE-7066: {quote} Can we punt on this in 0.94? {quote} We'v

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651298#comment-13651298 ] Hudson commented on HBASE-7066: --- Integrated in HBase-TRUNK #4101 (See [https://builds.apach

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651290#comment-13651290 ] Hudson commented on HBASE-7066: --- Integrated in hbase-0.95 #180 (See [https://builds.apache.

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650368#comment-13650368 ] Hadoop QA commented on HBASE-7066: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649988#comment-13649988 ] Hadoop QA commented on HBASE-7066: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649876#comment-13649876 ] stack commented on HBASE-7066: -- [~ted_yu] "We can change the coprocessor interface in 0.95/tr

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649870#comment-13649870 ] Ted Yu commented on HBASE-7066: --- bq. Can we punt on this in 0.94? Sure. bq. Is there still

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649863#comment-13649863 ] Lars Hofhansl commented on HBASE-7066: -- Let me try to summarize: * Without this we ca

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649848#comment-13649848 ] stack commented on HBASE-7066: -- [~ted_yu] Last comment by Lars is " Count me officially c

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649838#comment-13649838 ] Ted Yu commented on HBASE-7066: --- bq. we can have the pre/post methods return false This woul

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649211#comment-13649211 ] stack commented on HBASE-7066: -- [~ted_yu] Can you summarize state of this issue? You committ

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494158#comment-13494158 ] Ted Yu commented on HBASE-7066: --- Comment on addendum would be appreciated.

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490130#comment-13490130 ] Ted Yu commented on HBASE-7066: --- For 0.94, I think one benefit of throwing exception is that

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490115#comment-13490115 ] Lars Hofhansl commented on HBASE-7066: -- OK... Count me officially confused then. If t

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490057#comment-13490057 ] Hadoop QA commented on HBASE-7066: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490040#comment-13490040 ] Lars Hofhansl commented on HBASE-7066: -- What I am saying is that a current 0.94 clien

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490030#comment-13490030 ] Ted Yu commented on HBASE-7066: --- The intention of introducing subclass of DoNotRetryIOExcept

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489946#comment-13489946 ] Hadoop QA commented on HBASE-7066: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489939#comment-13489939 ] Lars Hofhansl commented on HBASE-7066: -- Hmm... I agree that for security related exce

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489868#comment-13489868 ] Francis Liu commented on HBASE-7066: Scratch that, the return class would come from th

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489867#comment-13489867 ] Francis Liu commented on HBASE-7066: return vs exceptions: The problem with both is th

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489825#comment-13489825 ] Andrew Purtell commented on HBASE-7066: --- bq. Passing information out of methods via

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489824#comment-13489824 ] Andrew Purtell commented on HBASE-7066: --- bq. Should we have a marker Interface 'Disa

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489820#comment-13489820 ] Andrew Purtell commented on HBASE-7066: --- bq. Have we ever considered making security

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489815#comment-13489815 ] Ted Yu commented on HBASE-7066: --- I concur with Stack's suggestion above @ 02/Nov/12 20:44 A

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489812#comment-13489812 ] Francis Liu commented on HBASE-7066: Sounds like we need to change the return type fro

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489811#comment-13489811 ] Francis Liu commented on HBASE-7066: How will we communicate to the user the reason be

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489804#comment-13489804 ] Lars Hofhansl commented on HBASE-7066: -- Can we instead make the coprocessor protocol

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489788#comment-13489788 ] Francis Liu commented on HBASE-7066: That sounds fine to me, though what do we do with

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489739#comment-13489739 ] stack commented on HBASE-7066: -- Although ADE is from the security package. If we add ADE to

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489737#comment-13489737 ] stack commented on HBASE-7066: -- Sounds right to me > Some HMaster coprocesso

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489708#comment-13489708 ] Francis Liu commented on HBASE-7066: So just to summarize what to do with this issue:

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489704#comment-13489704 ] Francis Liu commented on HBASE-7066: Stack, Good to know, we can do it in increments M

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489668#comment-13489668 ] stack commented on HBASE-7066: -- Regards security as first class citizen rather than as a CP w

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489646#comment-13489646 ] Francis Liu commented on HBASE-7066: Stack, I see what you're trying to get at, we can

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489625#comment-13489625 ] Ted Yu commented on HBASE-7066: --- I understand Stack's concern. In 0.94, secure and insecure

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489554#comment-13489554 ] stack commented on HBASE-7066: -- [~toffer] Should the signature here, + public void shutdown(

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488822#comment-13488822 ] Francis Liu commented on HBASE-7066: Lars, if you agree that this fix is the right way

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488818#comment-13488818 ] Francis Liu commented on HBASE-7066: More specifically if AccessController.preShutdown

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488363#comment-13488363 ] Lars Hofhansl commented on HBASE-7066: -- So what happens when shutdown throws an IOExc

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488215#comment-13488215 ] Francis Liu commented on HBASE-7066: Ted, I did not change the signatures for HMaster

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488198#comment-13488198 ] Francis Liu commented on HBASE-7066: Stack, IMHO it really depends on what the coproce

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488098#comment-13488098 ] Hudson commented on HBASE-7066: --- Integrated in HBase-TRUNK #3501 (See [https://builds.apach

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487891#comment-13487891 ] Ted Yu commented on HBASE-7066: --- If AccessDeniedException is thrown, shutdown would not succ

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487854#comment-13487854 ] stack commented on HBASE-7066: -- Previously, if an exception in CPs in say the shutdown method

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487798#comment-13487798 ] Ted Yu commented on HBASE-7066: --- Integrated to trunk. Thanks for the patch Francis. Do you

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487567#comment-13487567 ] Hadoop QA commented on HBASE-7066: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487526#comment-13487526 ] Francis Liu commented on HBASE-7066: Ted, Fixed the nit. > Some HMast

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487521#comment-13487521 ] ramkrishna.s.vasudevan commented on HBASE-7066: --- +1 for trunk patch. Also i

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487219#comment-13487219 ] Ted Yu commented on HBASE-7066: --- Looks good. nit: {code} + LOG.error("Error invoking ba

[jira] [Commented] (HBASE-7066) Some HMaster coprocessor exceptions are being swallowed in try catch blocks

[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486538#comment-13486538 ] Hadoop QA commented on HBASE-7066: -- {color:red}-1 overall{color}. Here are the results o