[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541353#comment-13541353
]
Hudson commented on HBASE-7390:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #321 (See
[https
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541330#comment-13541330
]
Hudson commented on HBASE-7390:
---
Integrated in HBase-TRUNK #3676 (See
[https://builds.apach
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541327#comment-13541327
]
nkeywal commented on HBASE-7390:
v11 is what I committed.
> Add extra tes
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541165#comment-13541165
]
stack commented on HBASE-7390:
--
Above sounds reasonable to me.
Regards encapsulating RIT, J
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541164#comment-13541164
]
nkeywal commented on HBASE-7390:
bq. You have lines > 100 characters according to the hado
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541162#comment-13541162
]
stack commented on HBASE-7390:
--
Patch is great. You have two +1s up in RB. Here is another
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1354#comment-1354
]
Hadoop QA commented on HBASE-7390:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540576#comment-13540576
]
Hadoop QA commented on HBASE-7390:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540490#comment-13540490
]
nkeywal commented on HBASE-7390:
Thanks Nick & Jimmy.
v9 contains the fixes for your point
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540064#comment-13540064
]
Jimmy Xiang commented on HBASE-7390:
Here is the link to the review: https://reviews.
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539867#comment-13539867
]
nkeywal commented on HBASE-7390:
It's on a review board, there it a +1 from Nick there.
Is
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539285#comment-13539285
]
Hadoop QA commented on HBASE-7390:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539278#comment-13539278
]
nkeywal commented on HBASE-7390:
v7. More bug fixes & more comments. I'm gonna put it on t
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538328#comment-13538328
]
Hadoop QA commented on HBASE-7390:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538257#comment-13538257
]
Hadoop QA commented on HBASE-7390:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538253#comment-13538253
]
nkeywal commented on HBASE-7390:
v6. Likely not final, but enough to be tested and global
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538231#comment-13538231
]
nkeywal commented on HBASE-7390:
@[~saint@gmail.com]
It's quite complicated :-(. I thi
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538227#comment-13538227
]
stack commented on HBASE-7390:
--
Nice analysis @nkeywal. I am trying to follow but cannot (I
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537874#comment-13537874
]
nkeywal commented on HBASE-7390:
bq. I'm not sure I follow.
{code}
Boolean openActio
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537311#comment-13537311
]
stack commented on HBASE-7390:
--
On the patch, what Sergey said about different closeRegion re
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537280#comment-13537280
]
stack commented on HBASE-7390:
--
bq. What's strange to me is that it seems similar to a RS_ZK_
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537232#comment-13537232
]
Sergey Shelukhin commented on HBASE-7390:
-
+1 on v4 patch
> Add e
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537185#comment-13537185
]
nkeywal commented on HBASE-7390:
[~saint@gmail.com]
bq. Yes. In case the master went a
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536634#comment-13536634
]
Hadoop QA commented on HBASE-7390:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536570#comment-13536570
]
stack commented on HBASE-7390:
--
bq. But on master failover, when we iterate on the znodes, we
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536508#comment-13536508
]
nkeywal commented on HBASE-7390:
for the tests, we have the usual suspects again it seems.
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536490#comment-13536490
]
Hadoop QA commented on HBASE-7390:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536474#comment-13536474
]
nkeywal commented on HBASE-7390:
Yes, that's what we do. But we should never miss the fina
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536469#comment-13536469
]
stack commented on HBASE-7390:
--
[~nkeywal] I follow you now. Yes, we can miss events and yes
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536454#comment-13536454
]
nkeywal commented on HBASE-7390:
@[~saint@gmail.com]
For SPLITTING and OPENING, I misr
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536452#comment-13536452
]
Sergey Shelukhin commented on HBASE-7390:
-
{code}
protected boolean closeRegion(
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536439#comment-13536439
]
nkeywal commented on HBASE-7390:
v3 with everything included. Ready for review :-)
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536403#comment-13536403
]
nkeywal commented on HBASE-7390:
Seems to be ok ok imho.
For testCloseByMasterWithoutZNod
[
https://issues.apache.org/jira/browse/HBASE-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536390#comment-13536390
]
Hadoop QA commented on HBASE-7390:
--
{color:red}-1 overall{color}. Here are the results o
34 matches
Mail list logo
