[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988366#comment-16988366
]
Saikat Maitra commented on IGNITE-7285:
---
[~Pavlukhin]
I have created this follow up documentation issue:
**https://issues.apache.org/jira/browse/IGNITE-12418
I have also updated this issue as RESOLVED and updated Fix Version to 2.8
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986040#comment-16986040
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], could you please fill in release notes field, create a follow-up
documentation ticket and resolve this ticket?
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975505#comment-16975505
]
Saikat Maitra commented on IGNITE-7285:
---
[~Pavlukhin] Thank you so much for your help with review and your guidance. I
really appreciate it.
Sorry, I am responding late. I was in In-Memory Computing Summit NA 2019 for
last 2 days and just got back.
I have merged the changes.
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973145#comment-16973145
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], so, from my side ticket looks as ready to merge.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973143#comment-16973143
]
Ignite TC Bot commented on IGNITE-7285:
---
{panel:title=Branch: [pull/6490/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4759899&buildTypeId=IgniteTests24Java8_RunAll]
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972615#comment-16972615
]
Saikat Maitra commented on IGNITE-7285:
---
[~ipavlukhin] The initial build failed as I had 3 unused import statements. I
fixed that issue and ran the Queries2 build.
Your understanding about included change in this PR is correct, this PR add
support for default query timeout for java.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972231#comment-16972231
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], could you please elaborate what is in scope of the ticket and what
is outside? I suppose that current ticket enables default timeout for Java API
(thick client) and Java Thin Client. Is everything else out of scope? Do we
have all needed follow-up tickets?
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971332#comment-16971332
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], currently common practice is attaching TC bot visa to a ticket
before merge. But now I see many failures in
[report|https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull/6490/head&action=Latest].
And I suppose there is no such failures in master. Do you know why there are
many failures in the aforementioned report?
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971236#comment-16971236
]
Saikat Maitra commented on IGNITE-7285:
---
[~Pavlukhin]
The teamcity build has passed :)
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970868#comment-16970868
]
Saikat Maitra commented on IGNITE-7285:
---
[~Pavlukhin]
I have started the teamcity build
[https://ci.ignite.apache.org/viewLog.html?buildId=4757200&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_RunAll&branch_IgniteTests24Java8=pull%2F6490%2Fhead]
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970861#comment-16970861
]
Saikat Maitra commented on IGNITE-7285:
---
[~Pavlukhin] [~ptupitsyn]
Thank you for sharing feedback. I have removed the changes from
PlatformConfigurationUtils.
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970752#comment-16970752
]
Pavel Tupitsyn commented on IGNITE-7285:
[~samaitra] please revert all changes in PlatformConfigurationUtils. Those
changes should have counterparts in .NET code, but we have decided to handle
that in a separate ticket.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970725#comment-16970725
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], by the way. Do not forget to get TC bot visa before merge.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970655#comment-16970655
]
Saikat Maitra commented on IGNITE-7285:
---
[~Pavlukhin] Thank you
[~ptupitsyn] [~isapego] Do you think keeping the change for
PlatformConfigurationUtils.java will cause regression on the .NET component or
C++ components?
[https://github.com/apache/ignite/pull/6490]
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969864#comment-16969864
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], thank you for describing the issue scope.
{quote}
Do you think keeping the change for PlatformConfigurationUtils.java will cause
regression on the .NET component?
{quote}
Sincerely, I do not know =(. Would be great to check it.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969687#comment-16969687
]
Saikat Maitra commented on IGNITE-7285:
---
[~Pavlukhin]
Thank you for your feedback.
Do you think keeping the change for PlatformConfigurationUtils.java will cause
regression on the .NET component?
The change I removed is the changes in IgniteConfiguration.cs
I have also created these 2 follow up Jira issues that can be taken up in
separate PR.
https://issues.apache.org/jira/browse/IGNITE-12352
https://issues.apache.org/jira/browse/IGNITE-12354
The items excluded from this PR are as follows:
* Update {{SqlFieldsQuery}} and {{QueryOptions}} classes in .NET accordingly -
set {{Timeout}} to {{TimeSpan.FromMilliseconds(-1)}} by default
* Full test coverage for those additions is necessary on the .NET part
* Ignite C++ should be updated as well. I suppose that we should update
{{query_sql.h}} and {{query_sql_fields.h}}, and pass -1 there as the timeout.
* QueryTimeoutException need to be added to differentiate query is cancelled
due to timeout
HTH
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969205#comment-16969205
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], could you please add comment about items excluded from current
ticket scope? Platforms support, different timeout/cancel exceptions and etc.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969085#comment-16969085
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra],
Could you please clarify about .NET changes? I still see
{{PlatformConfigurationUtils|https://github.com/apache/ignite/pull/6490/files#diff-f9fe4213d324408d45a3daa2dc34605c}}
in PR. Is it correct?
Everything else looks good to me.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968927#comment-16968927
]
Saikat Maitra commented on IGNITE-7285:
---
[~Pavlukhin]
I have updated the PR and replied on your comments. Please take a look.
If the changes looks good from this issue's scope perspective then we can merge
this PR and take up additional changes in separate Jira issue and PR.
Let me know your thoughts?
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968918#comment-16968918
]
Saikat Maitra commented on IGNITE-7285:
---
[~ptupitsyn]
As discussed I have updated the PR and removed the .NET changes.
I have also created a separate issue for .NET changes
https://issues.apache.org/jira/browse/IGNITE-12352
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962892#comment-16962892
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], I left a couple more comments on GitHub.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960947#comment-16960947
]
Igor Sapego commented on IGNITE-7285:
-
[~ptupitsyn] [~samaitra] I confirm, we need to update C++ as well.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960763#comment-16960763
]
Pavel Tupitsyn commented on IGNITE-7285:
[~samaitra] yes, we can do .NET changes as a separate PR. There is no problem
if we don't make those changes right away.
So feel free to revert all .NET changes and create a separate ticket. Thanks!
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960746#comment-16960746
]
Saikat Maitra commented on IGNITE-7285:
---
[~ptupitsyn]
Thank you for reviewing and sharing feedback.
I wanted to connect on the changes required for .NET side. As I have not
modified any .NET files in Ignite before I wanted to connect if the .NET
changes can be taken as a separate PR.
Do you think making changes on Ignite configuration and not making similar
changes will be breaking change for .NET or will it be a change where the
default query timeout will not be accepted by .NET clients?
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957198#comment-16957198
]
Pavel Tupitsyn commented on IGNITE-7285:
[~samaitra]
* Please see comment on GitHub
* Please update {{SqlFieldsQuery}} and {{QueryOptions}} classes in .NET
accordingly - set {{Timeout}} to {{TimeSpan.FromMilliseconds(-1)}} by default
* Ignite C++ should be updated as well. I suppose that we should update
{{query_sql.h}} and {{query_sql_fields.h}}, and pass -1 there as the timeout.
[~isapego] please confirm.
*
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957134#comment-16957134
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], I left some comments related to tests.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957135#comment-16957135
]
Ivan Pavlukhin commented on IGNITE-7285:
[~ptupitsyn], could you please check that everything is ok in .NET part?
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955332#comment-16955332
]
Saikat Maitra commented on IGNITE-7285:
---
Hi Ivan,
Thank you for sharing your feedback.
I have incorporated most of your review comments and have shared questions for
few changes.
Can you please take a look and share your thoughts?
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951040#comment-16951040
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], sorry for a delay. I left my
[comments|https://github.com/apache/ignite/pull/6490#pullrequestreview-301331326]
on GitHub.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947344#comment-16947344
]
Saikat Maitra commented on IGNITE-7285:
---
[~Pavlukhin]
I have updated the PR as per review feedback.
Please take a look and share if you have any feedback.
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16936714#comment-16936714
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], thank you for continuing work on it. I left
[comments|https://github.com/apache/ignite/pull/6490#pullrequestreview-292345841].
If you agree with them please proceed with tests.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935439#comment-16935439
]
Saikat Maitra commented on IGNITE-7285:
---
[~Pavlukhin]
Thank you for sharing your feedback and reviewing the PR.
I have incorporated the changes, Please take a look.
If it looks good, I will work on the test cases.
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925649#comment-16925649
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], I left a couple of comments on GitHub.
Regarding _unset_ timeout. I think that it would be more straightforward to
have a following logic:
* Unset timeout means that a default one should be used.
* Explicitly set timeout must be used.
* Timeout values have the same meaning for {{SqlFieldsQuery.setTimeout}} and
{{IgniteConfiguration.setDefaultQueryTimeout}}. Consequently 0 means infinite
timeout for both methods.
Technically it can be done in a following way:
# {{SqlFieldsQuery}} declares {{private int timeout = -1}}.
# {{SqlFieldsQuery.setTimeout}} forbids negative arguments.
# Upon {{QueryParameters}} initialization we treat -1 as _unset_ value and use
a default one.
A care should be taken when we create {{SqlFieldsQuery}} internally for an
execution, like in {{OdbcRequestHandler}}.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920508#comment-16920508
]
Saikat Maitra commented on IGNITE-7285:
---
[~Pavlukhin]
# I have modified QueryParameters#fromQuery and moved to QueryParser class.
This will take care of
org.apache.ignite.internal.processors.query.h2.CommandProcessor#processTxCommand.
# This is also taken care as I moved fromQuery method to QueryParser class.
# Can you share an example of how you are thinking to use -1 to indicate user
did not call setTimeout. I was thinking that if user provide
defaultQueryTimeout they may make an assumption that although SqlFieldsQuery
has a timeout value (0) for infinite timeout value the defaultQueryTimeout will
still apply and protect from undesirable system operations.
Please review and share feedback
PR : [https://github.com/apache/ignite/pull/6490/files]
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916143#comment-16916143
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra],
bq. 1. I ran tests for Distributed Query and local query like
IgniteCacheReplicatedQuerySelfTest,
IgniteCacheLocalQueryCancelOrTimeoutSelfTest and I see that timeout value is
passed. Can you share an example in which Query or execution mode you can see
that timeout is not passed?
Good to know that it works for different cases. I am concerned about timeout
propagation
{{org.apache.ignite.internal.processors.query.h2.CommandProcessor#processTxCommand}}.
It seems that _default timeout_ is not used in that class in PR. But I must
say that I do not fully understand why query timeout is used by transactional
commands.
bq. 2. I observed that QueryParameters initialization is occurring in
QueryParameters.fromQuery(SqlFieldsQuery qry) method and QueryParameters does
not have GridKernalContext reference so it will not be feasible to access the
ctx.config().getDefaultQueryTimeout() upon QueryParameters initialization.
{{org.apache.ignite.internal.processors.query.h2.QueryParameters#fromQuery}} is
used only in {{QueryParser}}, we can make it aware of ignite configuration by
placing {{fromQuery}} method to {{QueryParser}} or by introducing a class
responsible for {{QueryParameters}} construction in presence of default values
in configuration (only timeout so far). Are there major disadvantages of such
approach?
.bq If you observe timeout in SqlFieldsQuery get validated in
QueryUtils.validateTimeout(timeout, timeUnit) and it asserts that timeout value
of SqlFieldsQuery is more than equal 0. Now if we allow feature to disable
timeout of particular query using (SqlFieldsQuery.setTimeout(0)) then
ctx.config().getDefaultQueryTimeout() will never get used.
I understood that disabling a timeout in presence of non-zero default value is
not so trivial. But I am still concerned how usable it would be? It is
desirable to protect a user from surprising behavior of {{setTimeout(0)}} when
default timeout is configured. Actually, to distinguish between _unset_ vs
_disabled_ timeout I thought about using -1 to indicate that a user did not
call {{setTimeout}}. Of course some care is needed to implement such approach
properly.
One more additional note. We have
{{org.apache.ignite.internal.sql.command.SqlBulkLoadCommand}} and we should
consider a _default timeout_ for it, at least roughly estimate how challenging
is it.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915082#comment-16915082
]
Saikat Maitra commented on IGNITE-7285:
---
Hi [~Pavlukhin]
Thank you for your feedback. I have following clarification and questions
related to the changes you have asked.
# I ran tests for Distributed Query and local query like
IgniteCacheReplicatedQuerySelfTest,
IgniteCacheLocalQueryCancelOrTimeoutSelfTest and I see that timeout value is
passed. Can you share an example in which Query or execution mode you can see
that timeout is not passed?
# I observed that QueryParameters initialization is occurring in
QueryParameters.fromQuery(SqlFieldsQuery qry) method and QueryParameters does
not have GridKernalContext reference so it will not be feasible to access the
ctx.config().getDefaultQueryTimeout() upon {{QueryParameters}} initialization.
# If you observe timeout in SqlFieldsQuery get validated in
QueryUtils.validateTimeout(timeout, timeUnit) and it asserts that timeout value
of SqlFieldsQuery is more than equal 0. Now if we allow feature to disable
timeout of particular query using ({{SqlFieldsQuery.setTimeout(0)}}) then
ctx.config().getDefaultQueryTimeout() will never get used.
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911729#comment-16911729
]
Ivan Pavlukhin commented on IGNITE-7285:
[~amashenkov], could you please step in and continue the review? Unfortunately,
for a couple of weeks I have limited access to my computer and cannot do a
review in a timely manner.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911725#comment-16911725
]
Ivan Pavlukhin commented on IGNITE-7285:
Hi [~samaitra],
I suspect that not all places where a timeout should be passed are covered yet.
For me it looks more natural to calculate a query timeout (taking default one
into account) upon {{QueryParameters}} initialization. It is worth to consider
following points for an implementation:
1. Reduce a number of places where _default timeout_ is read from configuration
(ideally there should be only one place).
2. Be able to disable a timeout for a particular query
({{SqlFieldsQuery.setTimeout(0)}}) when default non-zero timeout is configured.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910057#comment-16910057
]
Saikat Maitra commented on IGNITE-7285:
---
Hi [~Pavlukhin]
I have updated the PR and made changes in IgniteH2Indexing for query timeout so
that default query timeout get used during query execution.
Please take a look and let me know if this change looks good.
I will update tests if the approach looks good.
PR [https://github.com/apache/ignite/pull/6490]
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16909863#comment-16909863
]
Saikat Maitra commented on IGNITE-7285:
---
[~Pavlukhin]
Thank you for your feedback, I am looking into the changes needed for this
issue.
I am also looking into these configurations parameters
[https://apacheignite.readme.io/v2.2/docs/configuration-parameters] to see if
there are similar attributes being used in {{SqlFieldsQuery}} and {{SqlQuery.}}
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907948#comment-16907948
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], from configuration standpoint changes look good. But a default
value is not passed properly. Method {{GridCacheQueryAdapter#timeout(long)}}
using _default timeout_ from configuration is never used in a production code,
so I suppose that a timeout is not propagated properly. In API we have 2 types
of queries supporting timeouts {{SqlFieldsQuery}} and {{SqlQuery}}.
Mechanically {{QueryParameters#fromQuery}} looks as a good starting point to
see how timeout is propagated from a user {{SqlFieldsQuery}} for an actual
execution. Note, that timeout should be propagated to _map_ queries as well.
Also, all behavior should be validated by tests, at least following execution
modes should be covered:
* Distributed query against PARTITIONED cache.
* Distributed query against REPLICATED cache.
* Local query.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904545#comment-16904545
]
Saikat Maitra commented on IGNITE-7285:
---
[~Pavlukhin] [~dma...@apache.org]
As discussed I have updated the PR and incorporated review comments.
[https://github.com/apache/ignite/pull/6490|https://github.com/apache/ignite/pull/6490/files]
Please take a look and share your feedback.
Regard,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866385#comment-16866385
]
Ivan Pavlukhin commented on IGNITE-7285:
[~samaitra], please see my comments on GitHub.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841887#comment-16841887
]
Ignite TC Bot commented on IGNITE-7285:
---
{panel:title=--> Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}ZooKeeper (Discovery) 3{color} [[tests 0
CANCELLED|https://ci.ignite.apache.org/viewLog.html?buildId=3853240]]
{color:#d04437}Platform .NET (Long Running){color} [[tests 164 Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=3853236]]
* exe: IgniteStartStopTest.TestUsageAfterStop
* exe: PeerAssemblyLoadingAllApisTest.TestComputeBroadcastOutFunc(False)
* exe: MessagingTest.TestLocalListenMultithreaded
* exe: ExamplesTest.TestRemoteNodes(TaskExample)
* exe: ExamplesTest.TestRemoteNodesClientMode(AtomicReferenceExample)
* exe: ExamplesTest.TestRemoteNodes(NearCacheExample)
* exe: CacheDynamicStartTest.TestTransactional
* exe: ExamplesTest.TestRemoteNodesClientMode(TaskExample)
* exe: SslConfigurationTest.TestStartWithConfigPath
* exe: ExamplesTest.TestLocalNode(TransactionExample)
* exe: ExamplesTest.TestRemoteNodes(SqlExample)
* exe: ExamplesTest.TestRemoteNodesClientMode(OptimisticTransactionExample)
* exe: SslConfigurationTest.TestTwoServers
* exe: ExamplesTest.TestLocalNode(ServicesExample)
* exe: PeerAssemblyLoadingAllApisTest.TestComputeCall(True)
* exe: ClientConnectionTest.TestCustomConfig
* exe: ExecutableTest.TestJvmMemoryOptsCmdCombined
* exe: ExamplesTest.TestRemoteNodesClientMode(SqlExample)
* exe: ExecutableTest.TestJvmMemoryOptsCmdCustom
* exe: ExecutableTest.TestJvmMemoryOptsCmdRaw
* exe: ExamplesTest.TestRemoteNodesClientMode(AtomicSequenceExample)
* exe: ExamplesTest.TestLocalNode(ClientReconnectExample)
* exe: PeerAssemblyLoadingAllApisTest.TestComputeBroadcastAction(True)
* exe: ExamplesTest.TestRemoteNodes(ClosureExample)
* exe: ClientConnectionTest.TestIdleTimeout
* exe: ExamplesTest.TestLocalNode(SqlDdlExample)
* exe: ExamplesTest.TestRemoteNodes(AtomicLongExample)
* exe: IgniteStartStopTest.TestStartStopLeak
* exe: AtomicLongTest.TestMultithreaded
* exe: ExamplesTest.TestRemoteNodesClientMode(PeerAssemblyLoadingExample)
* exe: ReconnectTest.TestFailedConnection
* exe: ExamplesTest.TestRemoteNodes(OptimisticTransactionExample)
* exe: ExamplesTest.TestLocalNode(SqlDmlExample)
* exe: ClientConnectionTest.TestIncorrectProtocolVersionError
* exe: ExamplesTest.TestLocalNode(EventsExample)
* exe: MessagingTest.TestRemoteListenMultithreaded
* exe: PeerAssemblyLoadingAllApisTest.TestComputeAffinityCall(True)
* exe: ExamplesTest.TestRemoteNodesClientMode(LinqExample)
* exe: IgniteConfigurationTest.TestConsistentId
* exe: ExamplesTest.TestRemoteNodesClientMode(ThinClientPutGetExample)
* exe: ExamplesTest.TestRemoteNodesClientMode(ThinClientQueryExample)
* exe: ExamplesTest.TestRemoteNodesClientMode(ThinClientSqlExample)
* exe: ExamplesTest.TestRemoteNodes(ThinClientPutGetExample)
* exe:
ExamplesTest.TestRemoteNodesClientMode(TransactionDeadlockDetectionExample)
* exe: ExamplesTest.TestRemoteNodesClientMode(BinaryModeExample)
* exe: MultiAppDomainTest.TestIisBehavior
* exe: PartitionPreloadTest.TestLocalPreloadPartitionClient
* exe: ExamplesTest.TestRemoteNodes(ThinClientQueryExample)
* exe: Cache.CacheTestAsync
* exe: PartitionPreloadTest.TestLocalPreloadPartition
* exe: Cache.CacheTest
* exe: PartitionPreloadTest.TestPreloadPartitionAsync
* exe: PartitionPreloadTest.TestPreloadPartition
* exe: ExamplesTest.TestRemoteNodes(DataStreamerExample)
* exe: PartitionPreloadTest.TestPreloadPartitionInMemoryFail
* exe: ExamplesTest.TestLocalNode(LifecycleExample)
* exe: Dataload.DataStreamerTest
* exe: ExamplesTest.TestRemoteNodesClientMode(PutGetExample)
* exe: ExamplesTest.TestRemoteNodes(ThinClientSqlExample)
* exe: ExamplesTest.TestRemoteNodes(TransactionDeadlockDetectionExample)
* exe: ExamplesTest.TestRemoteNodes(SqlDmlExample)
* exe: IgniteStartStopTest.TestClientMode
* exe: ExamplesTest.TestRemoteNodes(ServicesExample)
* exe: ExamplesTest.TestLocalNode(LinqExample)
* exe: ExceptionsTest.TestPartialUpdateExceptionAsyncBinarizable
* exe: ExamplesTest.TestRemoteNodes(MessagingExample)
* exe: ExamplesTest.TestRemoteNodesClientMode(TransactionExample)
* exe: IgniteStartStopTest.TestProcessorInit
* exe: ExamplesTest.TestRemoteNodesClientMode(MessagingExample)
* exe: ExamplesTest.TestLocalNode(MultiTieredCacheExample)
* exe: PeerAssemblyLoadingAllApisTest.TestComputeBroadcastFunc(True)
* exe: ExamplesTest.TestLocalNode(ClosureExample)
* exe: ExamplesTest.TestRemoteNodes(AtomicReferenceExample)
* exe: PeerAssemblyLoadingAllApisTest.TestComputeCall(False)
* exe: PersistentStoreTestObsolete.TestCacheDataSurvivesNodeRestart
* exe: Cache.CachePartitionedAtomicNearEnabledTest
* exe: ExamplesTest.TestLocalNode(ContinuousQueryExample)
* exe: Cache.CachePartitionedAtomicTest
* exe: ExceptionsTest.TestPartialUpdateException
* ex
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824241#comment-16824241
]
Andrew Mashenkov commented on IGNITE-7285:
--
[~samaitra], I've left few comments to PR.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822571#comment-16822571
]
Saikat Maitra commented on IGNITE-7285:
---
Hi,
I have raised a PR for the issue.
PR - [https://github.com/apache/ignite/pull/6490]
Please take a look and share feedback.
Regards,
Saikat
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7285) Add default query timeout
[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629914#comment-16629914
]
Vladimir Ozerov commented on IGNITE-7285:
-
Removing 2.7 version as there is no activity around the ticket at the moment.
> Add default query timeout
> -
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
>Affects Versions: 2.3
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
>Priority: Major
> Labels: sql-stability
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
