[GitHub] [maven] rmannibucau commented on issue #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rmannibucau commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-537334130 About attaching pom: i take gradle users as a reference. They create a fake pom which makes the project link completly lost. So

[GitHub] [maven] rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330370622 ## File path:

[GitHub] [maven-surefire] Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r330330659 ## File path:

[GitHub] [maven-surefire] Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r330329094 ## File path:

[GitHub] [maven-surefire] Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-537282390 > If you are done, you can squash it. There's one failing test. I guess you forgot to use JUnit assumption of Java

[jira] [Updated] (MPLUGIN-354) Use Java 7 APIs and language features

2019-10-01 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated MPLUGIN-354: - Fix Version/s: (was: 3.6.1) > Use Java 7 APIs and language features >

[GitHub] [maven-plugin-tools] Tibor17 commented on issue #18: Use Java 7 APIs and language features

2019-10-01 Thread GitBox
Tibor17 commented on issue #18: Use Java 7 APIs and language features URL: https://github.com/apache/maven-plugin-tools/pull/18#issuecomment-537275089 @gaul ok, i will delete mine. Can you rewrite the commit message to: `[MPLUGIN-353] Use Java 7 APIs and language features` Thx

[jira] [Updated] (MPLUGIN-353) Use Java 7 APIs and language features

2019-10-01 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated MPLUGIN-353: - Fix Version/s: 3.6.1 > Use Java 7 APIs and language features >

[jira] [Closed] (MPLUGIN-354) Use Java 7 APIs and language features

2019-10-01 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed MPLUGIN-354. Assignee: Tibor Digana Resolution: Duplicate > Use Java 7 APIs and language features >

[jira] [Assigned] (MPLUGIN-353) Use Java 7 APIs and language features

2019-10-01 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned MPLUGIN-353: Assignee: Tibor Digana > Use Java 7 APIs and language features >

[GitHub] [maven-plugin-tools] gaul commented on issue #18: Use Java 7 APIs and language features

2019-10-01 Thread GitBox
gaul commented on issue #18: Use Java 7 APIs and language features URL: https://github.com/apache/maven-plugin-tools/pull/18#issuecomment-537274359 I created [MPLUGIN-353](https://issues.apache.org/jira/browse/MPLUGIN-353) earlier.

[GitHub] [maven-plugin-tools] Tibor17 commented on issue #18: Use Java 7 APIs and language features

2019-10-01 Thread GitBox
Tibor17 commented on issue #18: Use Java 7 APIs and language features URL: https://github.com/apache/maven-plugin-tools/pull/18#issuecomment-537274012 Jira ticket created https://issues.apache.org/jira/browse/MPLUGIN-354 Let's check this fix on Jenkins tomorrow.

[jira] [Created] (MPLUGIN-354) Use Java 7 APIs and language features

2019-10-01 Thread Tibor Digana (Jira)
Tibor Digana created MPLUGIN-354: Summary: Use Java 7 APIs and language features Key: MPLUGIN-354 URL: https://issues.apache.org/jira/browse/MPLUGIN-354 Project: Maven Plugin Tools Issue

[GitHub] [maven] Tibor17 commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
Tibor17 commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330305750 ## File path:

[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330304611 ## File path: maven-xml/src/test/java/org/apache/maven/xml/filter/AbstractXMLFilterTests.java ##

[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330303476 ## File path: maven-xml/src/main/java/org/apache/maven/xml/SAXEventFactory.java ## @@ -0,0 +1,111

[GitHub] [maven] Tibor17 commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
Tibor17 commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330302922 ## File path:

[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330296938 ## File path: maven-core/src/main/java/org/apache/maven/xml/filter/FastForwardFilter.java ## @@

[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330296720 ## File path: maven-core/src/main/java/org/apache/maven/xml/filter/ConsumerPomXMLFilter.java ##

[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330296309 ## File path:

[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330297864 ## File path: maven-core/src/main/java/org/apache/maven/xml/internal/DefaultBuildPomXMLFilterFactory.java

[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330298724 ## File path: maven-xml/src/main/java/org/apache/maven/xml/SAXEventUtils.java ## @@ -0,0 +1,38 @@

[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330297691 ## File path: maven-core/src/main/java/org/apache/maven/xml/internal/DefaultBuildPomXMLFilterFactory.java

[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330297344 ## File path: maven-core/src/main/java/org/apache/maven/xml/filter/FastForwardFilter.java ## @@

[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330298491 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java

[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330295497 ## File path:

[GitHub] [maven] eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330293977 ## File path:

[jira] [Commented] (MNG-6397) Maven Transitive Dependency Resolution Does Not Respect Repository Definition in pom.xml

2019-10-01 Thread Alan Czajkowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-6397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942323#comment-16942323 ] Alan Czajkowski commented on MNG-6397: -- [~ewiegs4] unfortunately, I don't think anybody is looking

[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-537231848 @Col-E If you are done, you can squash it. There's one failing test. I guess you forgot to use JUnit assumption

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330274591 ## File path: maven-xml/src/main/java/org/apache/maven/xml/filter/BuildPomXMLFilterFactory.java

[GitHub] [maven] rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-537226579 Here's how I see it: Maven 3.7.x+ : experiment with adjusting files using Model 4.0.0 Maven 4.0.0 : apply adjusting files

[GitHub] [maven] rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330268573 ## File path: maven-xml/src/main/java/org/apache/maven/xml/filter/BuildPomXMLFilterFactory.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330265590 ## File path: maven-xml/src/main/java/org/apache/maven/xml/filter/BuildPomXMLFilterFactory.java

[GitHub] [maven] Tibor17 commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
Tibor17 commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330264585 ## File path:

[GitHub] [maven] rmannibucau commented on issue #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rmannibucau commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-537221013 The reason to attach both is that dev will prefer original pom and tools the deployed one. At the end syntaxes can diverge

[GitHub] [maven] Tibor17 commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
Tibor17 commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330264585 ## File path:

[GitHub] [maven] rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330263942 ## File path: maven-xml/src/main/java/org/apache/maven/xml/filter/BuildPomXMLFilterFactory.java

[GitHub] [maven] rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330263200 ## File path:

[GitHub] [maven] rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330263200 ## File path:

[jira] [Commented] (MNG-6065) Creating opton --fail-level / -fl which is error by default, but could be changed to warning/warn.

2019-10-01 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNG-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942290#comment-16942290 ] Martin Kanters commented on MNG-6065: - Yes, I'll try to finalize the work that I currently have on a

[GitHub] [maven] Tibor17 commented on issue #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
Tibor17 commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-537206583 @rfscholte I found this in the emails. You should not throw RuntimeException in `DefaultModelBuilder`. It is bad practice and seen

[jira] [Commented] (MNG-6397) Maven Transitive Dependency Resolution Does Not Respect Repository Definition in pom.xml

2019-10-01 Thread Eddie Wiegers (Jira)
[ https://issues.apache.org/jira/browse/MNG-6397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942276#comment-16942276 ] Eddie Wiegers commented on MNG-6397: I just ran into a similar-sounding issue that based on your build

[jira] [Created] (MNG-6772) Super POM overwrites remapped central repository in nested import POMs

2019-10-01 Thread Eddie Wiegers (Jira)
Eddie Wiegers created MNG-6772: -- Summary: Super POM overwrites remapped central repository in nested import POMs Key: MNG-6772 URL: https://issues.apache.org/jira/browse/MNG-6772 Project: Maven

[jira] [Commented] (MNG-6759) Maven fails to use section from dependency when resolving transitive dependencies in some cases

2019-10-01 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/MNG-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942272#comment-16942272 ] Tibor Digana commented on MNG-6759: --- the inheritance of REPOs do not work via inheritance of typical

[GitHub] [maven] rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-537198294 > On the feature I have mainly one point: are the transformed pom and real project pom attached? Think it makes sense to attach both

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330237064 ## File path: maven-xml/src/main/java/org/apache/maven/xml/filter/DependencyKey.java ## @@ -0,0

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330236983 ## File path: maven-xml/src/main/java/org/apache/maven/xml/SAXEventUtils.java ## @@ -0,0 +1,38 @@

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330235852 ## File path: maven-xml/src/main/java/org/apache/maven/xml/filter/BuildPomXMLFilterFactory.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330235426 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330234983 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330234343 ## File path:

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330232022 ## File path: maven-xml/src/test/java/org/apache/maven/xml/filter/ConsumerPomXMLFilterTest.java

[GitHub] [maven] rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330215757 ## File path: maven-xml/src/main/java/org/apache/maven/xml/filter/DependencyKey.java ## @@

[GitHub] [maven] rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330213813 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java

[GitHub] [maven] rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330211611 ## File path:

[GitHub] [maven] rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330210928 ## File path:

[GitHub] [maven] rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330215407 ## File path: maven-xml/src/main/java/org/apache/maven/xml/SAXEventUtils.java ## @@ -0,0 +1,38

[GitHub] [maven] rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rmannibucau commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330214814 ## File path: maven-xml/src/main/java/org/apache/maven/xml/filter/BuildPomXMLFilterFactory.java

[jira] [Commented] (MNG-6771) Please fix license issues

2019-10-01 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942232#comment-16942232 ] Vladimir Sitnikov commented on MNG-6771: {quote}They likely need to be fixed and then we can

[jira] [Commented] (MNG-6771) Please fix license issues

2019-10-01 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942229#comment-16942229 ] Vladimir Sitnikov commented on MNG-6771: I agree it would be great if all the third-party

[jira] [Commented] (MNG-6771) Please fix license issues

2019-10-01 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942227#comment-16942227 ] Vladimir Sitnikov commented on MNG-6771: One does not simply get a license from ASM: 

[jira] [Comment Edited] (MDEP-204) go-offline fails to resolve artifact available in maven reactor

2019-10-01 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MDEP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927963#comment-16927963 ] Robert Scholte edited comment on MDEP-204 at 10/1/19 6:32 PM: -- Fixed in

[GitHub] [maven-dependency-plugin] rfscholte merged pull request #21: MDEP-204 Transitively resolve both dependencies and plugins

2019-10-01 Thread GitBox
rfscholte merged pull request #21: MDEP-204 Transitively resolve both dependencies and plugins URL: https://github.com/apache/maven-dependency-plugin/pull/21 This is an automated message from the Apache Git Service. To

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330204588 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330204200 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330201980 ## File path: maven-core/src/test/java/org/apache/maven/xml/filter/ConsumerPomXMLFilterTest.java

[jira] [Commented] (MSKINS-105) Provide alt for all images

2019-10-01 Thread Jira
[ https://issues.apache.org/jira/browse/MSKINS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942213#comment-16942213 ] Michael Prieß commented on MSKINS-105: -- It seems like this must be fixed in doxia:

[jira] [Commented] (MNG-6771) Please fix license issues

2019-10-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942208#comment-16942208 ] Michael Osipov commented on MNG-6771: - As fart as I know, the license URLs are extracted from their

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330198943 ## File path: maven-core/src/main/java/org/apache/maven/xml/internal/DefaultBuildPomXMLFilterFactory.java

[GitHub] [maven] michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330189648 ## File path:

[GitHub] [maven] michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330191841 ## File path: maven-core/src/main/java/org/apache/maven/xml/internal/DefaultBuildPomXMLFilterFactory.java

[GitHub] [maven] michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330192304 ## File path: maven-core/src/test/java/org/apache/maven/xml/filter/ConsumerPomXMLFilterTest.java

[GitHub] [maven] michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330195066 ## File path: maven-xml/src/test/java/org/apache/maven/xml/filter/ConsumerPomXMLFilterTest.java

[GitHub] [maven] michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330189511 ## File path:

[GitHub] [maven] michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330193378 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java

[GitHub] [maven] michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330193092 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java

[jira] [Commented] (MNG-6759) Maven fails to use section from dependency when resolving transitive dependencies in some cases

2019-10-01 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942188#comment-16942188 ] Stig Rohde Døssing commented on MNG-6759: - Ah, okay. I don't think the inherited repos are

[GitHub] [maven] rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330185735 ## File path: pom.xml ## @@ -47,8 +47,8 @@ under the License. 3.0.5 -1.7 -1.7

[GitHub] [maven] sormuras commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
sormuras commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330182509 ## File path: pom.xml ## @@ -47,8 +47,8 @@ under the License. 3.0.5 -1.7 -1.7 +

[GitHub] [maven] rfscholte opened a new pull request #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte opened a new pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA

[jira] [Commented] (MNG-6759) Maven fails to use section from dependency when resolving transitive dependencies in some cases

2019-10-01 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/MNG-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942179#comment-16942179 ] Tibor Digana commented on MNG-6759: --- You wrote this: {{Copying the section from ChildB into ChildA}}

[jira] [Commented] (MNG-6759) Maven fails to use section from dependency when resolving transitive dependencies in some cases

2019-10-01 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942170#comment-16942170 ] Stig Rohde Døssing commented on MNG-6759: - Hi Tibor, thanks for responding. If I'm understanding

[jira] [Commented] (MNG-6759) Maven fails to use section from dependency when resolving transitive dependencies in some cases

2019-10-01 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/MNG-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942153#comment-16942153 ] Tibor Digana commented on MNG-6759: --- Open the parent POM and parent of that parent. There is already the

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r330158130 ## File path:

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r330156065 ## File path:

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r330156065 ## File path:

[GitHub] [maven-surefire] Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-537098853 See: [this discussion](https://github.com/apache/maven-surefire/pull/245#discussion_r330129552) for the new commit's

[GitHub] [maven-surefire] Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#discussion_r330129552 ## File path:

[jira] [Created] (SUREFIRE-1696) Support reportNameSuffix for ConsoleReporter

2019-10-01 Thread Diego Lovison (Jira)
Diego Lovison created SUREFIRE-1696: --- Summary: Support reportNameSuffix for ConsoleReporter Key: SUREFIRE-1696 URL: https://issues.apache.org/jira/browse/SUREFIRE-1696 Project: Maven Surefire

[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-537041815 @Col-E These are our new test?

[jira] [Created] (MNG-6771) Please fix license issues

2019-10-01 Thread Vladimir Sitnikov (Jira)
Vladimir Sitnikov created MNG-6771: -- Summary: Please fix license issues Key: MNG-6771 URL: https://issues.apache.org/jira/browse/MNG-6771 Project: Maven Issue Type: Bug

[GitHub] [maven-surefire] Col-E edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Col-E edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-537007114 > Pls check if the difference between those two methods is what I used in the previous comment because I was too

[GitHub] [maven-surefire] Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-537007114 > Pls check if the difference between those two methods is what I used in the previous comment because I was too fast

[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-537003525 @Col-E thx, the build is running https://builds.apache.org/job/maven-box/job/maven-surefire/job/SUREFIRE-1584/

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-536989553 @jon-bell @Col-E Sorry for the delay. Let's continue, guys! So I have compared these two

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-536994438 One can see that the method must alter the behavior . In practice we do it easily the way that we have

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-536994438 One can see that the method must alter the behavior . In practice we do it easily the way that we have

[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-536994438 One can see that the method must alter the behavior . In practice we do it easily the way that we have algorithm in

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-536989553 @jon-bell @Col-E Sorry for the delay. Let's continue, guys! So I have compare these two methods,

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

2019-10-01 Thread GitBox
Tibor17 edited a comment on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5 URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-536989553 @jon-bell @Col-E Sorry for the delay. Let's continue, guys! So I have compare these two methods,

  1   2   >