[jira] [Commented] (MNG-7924) Better control over and better integration with Resolver

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784306#comment-17784306 ] ASF GitHub Bot commented on MNG-7924: - rmannibucau commented on PR #1299: URL:

Re: [PR] [MNG-7924] Better control over and better integration with Resolver [maven]

2023-11-08 Thread via GitHub
rmannibucau commented on PR #1299: URL: https://github.com/apache/maven/pull/1299#issuecomment-1803303626 Is it planned to make the properties injected from the pom "mvn 4 version" and therefore makes the type dictionnary useless? If so +1 (means the toggles will be exposed to users and

[jira] [Commented] (MNG-7924) Better control over and better integration with Resolver

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784305#comment-17784305 ] ASF GitHub Bot commented on MNG-7924: - gnodet commented on code in PR #1299: URL:

Re: [PR] [MNG-7924] Better control over and better integration with Resolver [maven]

2023-11-08 Thread via GitHub
gnodet commented on code in PR #1299: URL: https://github.com/apache/maven/pull/1299#discussion_r1387548574 ## api/maven-api-core/src/main/java/org/apache/maven/api/Type.java: ## @@ -51,14 +51,21 @@ public interface Type { * Returns the dependency type id. * The id

[jira] [Commented] (MNG-7924) Better control over and better integration with Resolver

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784304#comment-17784304 ] ASF GitHub Bot commented on MNG-7924: - gnodet commented on code in PR #1299: URL:

Re: [PR] [MNG-7924] Better control over and better integration with Resolver [maven]

2023-11-08 Thread via GitHub
gnodet commented on code in PR #1299: URL: https://github.com/apache/maven/pull/1299#discussion_r1387543172 ## api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Updated] (MCOMPILER-555) Bad service configuration file, or exception thrown while constructing Processor object: Invalid index

2023-11-08 Thread Liang Wang (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liang Wang updated MCOMPILER-555: - Description: 1. Error log

[jira] [Updated] (MCOMPILER-555) Bad service configuration file, or exception thrown while constructing Processor object: Invalid index

2023-11-08 Thread Liang Wang (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liang Wang updated MCOMPILER-555: - Description: 1. Error log

[jira] [Created] (MCOMPILER-555) Bad service configuration file, or exception thrown while constructing Processor object: Invalid index

2023-11-08 Thread Liang Wang (Jira)
Liang Wang created MCOMPILER-555: Summary: Bad service configuration file, or exception thrown while constructing Processor object: Invalid index Key: MCOMPILER-555 URL:

[jira] [Closed] (MPOM-446) Upgrade Parent to 31

2023-11-08 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-446. Resolution: Fixed > Upgrade Parent to 31 > > > Key:

[jira] [Commented] (MPOM-446) Upgrade Parent to 31

2023-11-08 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784228#comment-17784228 ] Slawomir Jaranowski commented on MPOM-446: -- Done in

[jira] [Created] (MPOM-446) Upgrade Parent to 31

2023-11-08 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-446: Summary: Upgrade Parent to 31 Key: MPOM-446 URL: https://issues.apache.org/jira/browse/MPOM-446 Project: Maven POMs Issue Type: Dependency upgrade

[jira] [Closed] (MPOM-444) Bump maven-pmd-plugin from 3.21.0 to 3.21.2

2023-11-08 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-444. Resolution: Fixed > Bump maven-pmd-plugin from 3.21.0 to 3.21.2 >

Re: [PR] [MPOM-444] Bump maven-pmd-plugin from 3.21.0 to 3.21.2 [maven-parent]

2023-11-08 Thread via GitHub
slawekjaranowski merged PR #148: URL: https://github.com/apache/maven-parent/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (MPOM-445) Use maven-checkstyle-plugin version from parent

2023-11-08 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-445. Resolution: Fixed > Use maven-checkstyle-plugin version from parent >

Re: [PR] [MPOM-445] Use maven-checkstyle-plugin version from parent [maven-parent]

2023-11-08 Thread via GitHub
slawekjaranowski merged PR #149: URL: https://github.com/apache/maven-parent/pull/149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MNG-7924) Better control over and better integration with Resolver

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784218#comment-17784218 ] ASF GitHub Bot commented on MNG-7924: - cstamas opened a new pull request, #1299: URL:

[jira] [Closed] (MPOM-443) Skip empty surefire reports

2023-11-08 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-443. Resolution: Fixed > Skip empty surefire reports > --- > >

Re: [PR] [MPOM-443] Skip empty surefire reports [maven-parent]

2023-11-08 Thread via GitHub
slawekjaranowski merged PR #147: URL: https://github.com/apache/maven-parent/pull/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (MASSEMBLY-1004) Remove ignored and deprecated parameter - useJvmChmod

2023-11-08 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MASSEMBLY-1004. -- Resolution: Fixed > Remove ignored and deprecated parameter - useJvmChmod

[jira] [Commented] (MASSEMBLY-1004) Remove ignored and deprecated parameter - useJvmChmod

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784217#comment-17784217 ] ASF GitHub Bot commented on MASSEMBLY-1004: --- slawekjaranowski merged PR #163: URL:

Re: [PR] [MASSEMBLY-1004] Remove ignored and deprecated parameter - useJvmChmod [maven-assembly-plugin]

2023-11-08 Thread via GitHub
slawekjaranowski merged PR #163: URL: https://github.com/apache/maven-assembly-plugin/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (MNG-7924) Better control over and better integration with Resolver

2023-11-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7924: - Summary: Better control over and better integration with Resolver (was: Better control over

[jira] [Updated] (MNG-7924) Better control over and better integration with Resolver

2023-11-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7924: - Description: Integrate better and obtain better control over Resolver. These changes did stem

[jira] [Updated] (MNG-7924) Better control over and better integration with Resolver

2023-11-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7924: - Description: Integrate better and obtain better control over Resolver. These changes did stem

[jira] [Created] (MNG-7924) Better control over Resolver and better integration

2023-11-08 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-7924: Summary: Better control over Resolver and better integration Key: MNG-7924 URL: https://issues.apache.org/jira/browse/MNG-7924 Project: Maven Issue Type:

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784208#comment-17784208 ] Tamas Cservenak commented on MRESOLVER-302: --- MNG-7653 will integrate these changes into

[jira] [Assigned] (MRESOLVER-422) Fix javadoc report

2023-11-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-422: - Assignee: Tamas Cservenak > Fix javadoc report > -- > >

[jira] [Closed] (MRESOLVER-422) Fix javadoc report

2023-11-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-422. - Resolution: Fixed > Fix javadoc report > -- > > Key:

[jira] [Commented] (MRESOLVER-422) Fix javadoc report

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784201#comment-17784201 ] ASF GitHub Bot commented on MRESOLVER-422: -- cstamas merged PR #359: URL:

Re: [PR] [MRESOLVER-422] Fix javadoc configuration [maven-resolver]

2023-11-08 Thread via GitHub
cstamas merged PR #359: URL: https://github.com/apache/maven-resolver/pull/359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SUREFIRE-1618) Configure module path with additional modules

2023-11-08 Thread David M. Lloyd (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784192#comment-17784192 ] David M. Lloyd commented on SUREFIRE-1618: -- We've also hit this issue. [~marx.freedom], WDYT

[jira] [Commented] (SUREFIRE-1731) Unable to test Multi Release Jar with surefire or failsafe

2023-11-08 Thread David M. Lloyd (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784190#comment-17784190 ] David M. Lloyd commented on SUREFIRE-1731: -- Just bumping this issue. There is a workaround,

[jira] [Commented] (MRESOLVER-422) Fix javadoc report

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784188#comment-17784188 ] ASF GitHub Bot commented on MRESOLVER-422: -- cstamas opened a new pull request, #359: URL:

[PR] [MRESOLVER-422] Fix javadoc configuration [maven-resolver]

2023-11-08 Thread via GitHub
cstamas opened a new pull request, #359: URL: https://github.com/apache/maven-resolver/pull/359 Not much to fix really, but simply put the "minimally required Java" and Javadoc URL needs to be kept in sync. But, as former is a range, latter is a "base version", it goes only manually.

[jira] [Commented] (MRESOLVER-426) Move some HTTP configuration properties from transport-http

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784185#comment-17784185 ] ASF GitHub Bot commented on MRESOLVER-426: -- cstamas merged PR #356: URL:

[jira] [Closed] (MRESOLVER-426) Move some HTTP configuration properties from transport-http

2023-11-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-426. - Resolution: Fixed > Move some HTTP configuration properties from transport-http >

Re: [PR] [MRESOLVER-426] Make some HTTP configuration shared [maven-resolver]

2023-11-08 Thread via GitHub
cstamas merged PR #356: URL: https://github.com/apache/maven-resolver/pull/356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (MRESOLVER-430) Make build time requirement for Java 21

2023-11-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-430. - Resolution: Fixed > Make build time requirement for Java 21 >

[jira] [Assigned] (MRESOLVER-430) Make build time requirement for Java 21

2023-11-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-430: - Assignee: Tamas Cservenak > Make build time requirement for Java 21 >

[jira] [Commented] (MRESOLVER-430) Make build time requirement for Java 21

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784180#comment-17784180 ] ASF GitHub Bot commented on MRESOLVER-430: -- cstamas merged PR #358: URL:

Re: [PR] [MRESOLVER-430] Build time Java 21 required [maven-resolver]

2023-11-08 Thread via GitHub
cstamas merged PR #358: URL: https://github.com/apache/maven-resolver/pull/358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MRESOLVER-424) Make DependencyGraphDumper extensible

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784179#comment-17784179 ] ASF GitHub Bot commented on MRESOLVER-424: -- cstamas merged PR #355: URL:

[jira] [Closed] (MRESOLVER-424) Make DependencyGraphDumper extensible

2023-11-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-424. - Resolution: Fixed > Make DependencyGraphDumper extensible >

Re: [PR] [MRESOLVER-424] Make graph dumper extensible [maven-resolver]

2023-11-08 Thread via GitHub
cstamas merged PR #355: URL: https://github.com/apache/maven-resolver/pull/355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MRESOLVER-308) HTTP transport showdown

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784178#comment-17784178 ] ASF GitHub Bot commented on MRESOLVER-308: -- cstamas commented on PR #231: URL:

Re: [PR] [MRESOLVER-308] HTTP transport showdown. [maven-resolver]

2023-11-08 Thread via GitHub
cstamas commented on PR #231: URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1802485551 Removed this PR from 2.0.0 milestone, but am keeping it, as while main code is already on master, there may be some test related bits we will need. -- This is an automated message

[jira] [Commented] (MNG-7662) Allow Graphbuilder to use session scoped components

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784176#comment-17784176 ] ASF GitHub Bot commented on MNG-7662: - rmannibucau commented on code in PR #950: URL:

Re: [PR] [MNG-7662] Use proxies for session scoped beans [maven]

2023-11-08 Thread via GitHub
rmannibucau commented on code in PR #950: URL: https://github.com/apache/maven/pull/950#discussion_r1387070244 ## maven-core/pom.xml: ## @@ -144,6 +144,12 @@ under the License. org.slf4j slf4j-api + Review Comment: the new interceptor is a new proxy

[jira] [Commented] (MRESOLVER-430) Make build time requirement for Java 21

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784175#comment-17784175 ] ASF GitHub Bot commented on MRESOLVER-430: -- cstamas opened a new pull request, #358: URL:

[PR] [MRESOLVER-430] Build time Java 21 required [maven-resolver]

2023-11-08 Thread via GitHub
cstamas opened a new pull request, #358: URL: https://github.com/apache/maven-resolver/pull/358 Actually, 21.0.1 as 21 had a bug that one of two needed preconditions are always met in case of Maven (as m-compiler-p always sets debug=true). ---

[jira] [Created] (MRESOLVER-430) Make build time requirement for Java 21

2023-11-08 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-430: - Summary: Make build time requirement for Java 21 Key: MRESOLVER-430 URL: https://issues.apache.org/jira/browse/MRESOLVER-430 Project: Maven Resolver

[jira] [Commented] (MNG-7662) Allow Graphbuilder to use session scoped components

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784170#comment-17784170 ] ASF GitHub Bot commented on MNG-7662: - gnodet commented on code in PR #950: URL:

Re: [PR] [MNG-7662] Use proxies for session scoped beans [maven]

2023-11-08 Thread via GitHub
gnodet commented on code in PR #950: URL: https://github.com/apache/maven/pull/950#discussion_r1387041873 ## maven-core/pom.xml: ## @@ -144,6 +144,12 @@ under the License. org.slf4j slf4j-api + Review Comment: I'm not following. What are you worried

[jira] [Commented] (MRESOLVER-426) Move some HTTP configuration properties from transport-http

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784162#comment-17784162 ] ASF GitHub Bot commented on MRESOLVER-426: -- cstamas commented on PR #356: URL:

Re: [PR] [MRESOLVER-426] Make some HTTP configuration shared [maven-resolver]

2023-11-08 Thread via GitHub
cstamas commented on PR #356: URL: https://github.com/apache/maven-resolver/pull/356#issuecomment-1802391250 This PR needs more: instead of doing hoops and loops (all to circumvent enforcer on dependencies and more) just raise the build Java requirement to 21, as HttpClient::close method

[jira] [Commented] (MNG-7662) Allow Graphbuilder to use session scoped components

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784143#comment-17784143 ] ASF GitHub Bot commented on MNG-7662: - rmannibucau commented on code in PR #950: URL:

Re: [PR] [MNG-7662] Use proxies for session scoped beans [maven]

2023-11-08 Thread via GitHub
rmannibucau commented on code in PR #950: URL: https://github.com/apache/maven/pull/950#discussion_r1386957429 ## maven-core/pom.xml: ## @@ -144,6 +144,12 @@ under the License. org.slf4j slf4j-api + Review Comment: Well, this is not really the same,

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784137#comment-17784137 ] ASF GitHub Bot commented on MRESOLVER-302: -- kwin commented on code in PR #357: URL:

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784135#comment-17784135 ] ASF GitHub Bot commented on MRESOLVER-302: -- kwin commented on code in PR #357: URL:

Re: [PR] [MRESOLVER-302] Introduce onSessionClose [maven-resolver]

2023-11-08 Thread via GitHub
kwin commented on code in PR #357: URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386938264 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -304,8 +314,26 @@ List newResolutionRepositories( * When shutdown happens,

Re: [PR] [MRESOLVER-302] Introduce onSessionClose [maven-resolver]

2023-11-08 Thread via GitHub
kwin commented on code in PR #357: URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386937750 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -304,8 +314,26 @@ List newResolutionRepositories( * When shutdown happens,

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784131#comment-17784131 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas commented on code in PR #357: URL:

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784130#comment-17784130 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas commented on code in PR #357: URL:

Re: [PR] [MRESOLVER-302] Introduce onSessionClose [maven-resolver]

2023-11-08 Thread via GitHub
cstamas commented on code in PR #357: URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386923270 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystemLifecycle.java: ## @@ -69,6 +74,59 @@ public void

Re: [PR] [MRESOLVER-302] Introduce onSessionClose [maven-resolver]

2023-11-08 Thread via GitHub
cstamas commented on code in PR #357: URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386923270 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystemLifecycle.java: ## @@ -69,6 +74,59 @@ public void

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784129#comment-17784129 ] ASF GitHub Bot commented on MRESOLVER-302: -- gnodet commented on code in PR #357: URL:

Re: [PR] [MRESOLVER-302] Introduce onSessionClose [maven-resolver]

2023-11-08 Thread via GitHub
gnodet commented on code in PR #357: URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386917972 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -304,8 +314,26 @@ List newResolutionRepositories( * When shutdown

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784128#comment-17784128 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas commented on code in PR #357: URL:

Re: [PR] [MRESOLVER-302] Introduce onSessionClose [maven-resolver]

2023-11-08 Thread via GitHub
cstamas commented on code in PR #357: URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386915751 ## maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/main/java/org/eclipse/aether/transport/jdk/JdkHttpTransporter.java: ## @@ -417,7

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784127#comment-17784127 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas commented on code in PR #357: URL:

Re: [PR] [MRESOLVER-302] Introduce onSessionClose [maven-resolver]

2023-11-08 Thread via GitHub
cstamas commented on code in PR #357: URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386915751 ## maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/main/java/org/eclipse/aether/transport/jdk/JdkHttpTransporter.java: ## @@ -417,7

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784126#comment-17784126 ] ASF GitHub Bot commented on MRESOLVER-302: -- gnodet commented on code in PR #357: URL:

Re: [PR] [MRESOLVER-302] Introduce onSessionClose [maven-resolver]

2023-11-08 Thread via GitHub
gnodet commented on code in PR #357: URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386866973 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -304,8 +314,26 @@ List newResolutionRepositories( * When shutdown

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784124#comment-17784124 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas commented on code in PR #357: URL:

Re: [PR] [MRESOLVER-302] Introduce onSessionClose [maven-resolver]

2023-11-08 Thread via GitHub
cstamas commented on code in PR #357: URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386903268 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -304,8 +314,26 @@ List newResolutionRepositories( * When shutdown

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784123#comment-17784123 ] ASF GitHub Bot commented on MRESOLVER-302: -- kwin commented on code in PR #357: URL:

Re: [PR] [MRESOLVER-302] Introduce onSessionClose [maven-resolver]

2023-11-08 Thread via GitHub
kwin commented on code in PR #357: URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386901050 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -304,8 +314,26 @@ List newResolutionRepositories( * When shutdown happens,

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784120#comment-17784120 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas commented on code in PR #357: URL:

Re: [PR] [MRESOLVER-302] Introduce onSessionClose [maven-resolver]

2023-11-08 Thread via GitHub
cstamas commented on code in PR #357: URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386892496 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystemSession.java: ## @@ -48,6 +51,350 @@ */ public interface RepositorySystemSession { +

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784117#comment-17784117 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas commented on code in PR #357: URL:

Re: [PR] [MRESOLVER-302] Introduce onSessionClose [maven-resolver]

2023-11-08 Thread via GitHub
cstamas commented on code in PR #357: URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386889932 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -304,8 +314,26 @@ List newResolutionRepositories( * When shutdown

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784114#comment-17784114 ] ASF GitHub Bot commented on MRESOLVER-302: -- kwin commented on code in PR #357: URL:

Re: [PR] [MRESOLVER-302] Introduce onSessionClose [maven-resolver]

2023-11-08 Thread via GitHub
kwin commented on code in PR #357: URL: https://github.com/apache/maven-resolver/pull/357#discussion_r1386875573 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -304,8 +314,26 @@ List newResolutionRepositories( * When shutdown happens,

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784111#comment-17784111 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas commented on PR #232: URL:

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784110#comment-17784110 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas closed pull request #232: [MRESOLVER-302]

Re: [PR] [MRESOLVER-302] Introduce onSessionClose hooks [maven-resolver]

2023-11-08 Thread via GitHub
cstamas closed pull request #232: [MRESOLVER-302] Introduce onSessionClose hooks URL: https://github.com/apache/maven-resolver/pull/232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [MRESOLVER-302] Introduce onSessionClose hooks [maven-resolver]

2023-11-08 Thread via GitHub
cstamas commented on PR #232: URL: https://github.com/apache/maven-resolver/pull/232#issuecomment-1802207404 Superseded by https://github.com/apache/maven-resolver/pull/357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784107#comment-17784107 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas opened a new pull request, #357: URL:

[jira] [Commented] (MPLUGIN-492) Documentation for plugins in general: Goals comprises more than that.

2023-11-08 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784093#comment-17784093 ] Michael Osipov commented on MPLUGIN-492: I agree with you. There are several points need to be

[jira] [Assigned] (MPLUGIN-492) Documentation for plugins in general: Goals comprises more than that.

2023-11-08 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MPLUGIN-492: -- Assignee: Michael Osipov > Documentation for plugins in general: Goals comprises

[jira] [Commented] (MNG-7662) Allow Graphbuilder to use session scoped components

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784086#comment-17784086 ] ASF GitHub Bot commented on MNG-7662: - gnodet commented on code in PR #950: URL:

Re: [PR] [MNG-7662] Use proxies for session scoped beans [maven]

2023-11-08 Thread via GitHub
gnodet commented on code in PR #950: URL: https://github.com/apache/maven/pull/950#discussion_r1386757692 ## maven-core/pom.xml: ## @@ -144,6 +144,12 @@ under the License. org.slf4j slf4j-api + Review Comment: ASM has always been included in maven

[jira] [Commented] (MNGSITE-527) broken link to settings-1.3.0.xsd

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784080#comment-17784080 ] ASF GitHub Bot commented on MNGSITE-527: gnodet commented on PR #464: URL:

Re: [PR] MNGSITE-527 broken link to settings-1.3.0.xsd [maven-site]

2023-11-08 Thread via GitHub
gnodet commented on PR #464: URL: https://github.com/apache/maven-site/pull/464#issuecomment-1802027696 > Should we have license headers in files? Does missing license will break site builds? Those files are generated. Not sure if the old ones have been manually edited to add the

[jira] [Commented] (MNG-7662) Allow Graphbuilder to use session scoped components

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784076#comment-17784076 ] ASF GitHub Bot commented on MNG-7662: - rmannibucau commented on code in PR #950: URL:

Re: [PR] [MNG-7662] Use proxies for session scoped beans [maven]

2023-11-08 Thread via GitHub
rmannibucau commented on code in PR #950: URL: https://github.com/apache/maven/pull/950#discussion_r1386715402 ## maven-core/pom.xml: ## @@ -144,6 +144,12 @@ under the License. org.slf4j slf4j-api + Review Comment: well while asm is toggable it is

[jira] [Moved] (MPLUGIN-492) Documentation for plugins in general: Goals comprises more than that.

2023-11-08 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov moved MSITE-989 to MPLUGIN-492: -- Component/s: (was: documentation) Key:

[jira] [Created] (MSITE-989) Documentation for plugins in general: Goals comprises more than that.

2023-11-08 Thread Ernst Reissner (Jira)
Ernst Reissner created MSITE-989: Summary: Documentation for plugins in general: Goals comprises more than that. Key: MSITE-989 URL: https://issues.apache.org/jira/browse/MSITE-989 Project: Maven

[jira] [Commented] (MNG-7662) Allow Graphbuilder to use session scoped components

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784051#comment-17784051 ] ASF GitHub Bot commented on MNG-7662: - gnodet commented on code in PR #950: URL:

  1   2   >