[jira] [Commented] (METRON-1704) Message Timestamp Logic Should be Shared

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581992#comment-16581992 ] ASF GitHub Bot commented on METRON-1704: Github user mmiklavc commented on the i

[GitHub] metron issue #1146: METRON-1704 Message Timestamp Logic Should be Shared [Fe...

2018-08-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1146 lgtm @nickwallen. +1 via inspection. ---

[jira] [Commented] (METRON-1737) Document Job cleanup

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581739#comment-16581739 ] ASF GitHub Bot commented on METRON-1737: Github user merrimanr closed the pull r

[jira] [Commented] (METRON-1738) Pcap directories should have correct permissions

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581740#comment-16581740 ] ASF GitHub Bot commented on METRON-1738: Github user merrimanr closed the pull r

[GitHub] metron pull request #1166: METRON-1738: Pcap directories should have correct...

2018-08-15 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1166 ---

[GitHub] metron pull request #1164: METRON-1737: Document Job cleanup

2018-08-15 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1164 ---

[GitHub] metron pull request #1141: Metron-1727: metron-rest service needs to be rest...

2018-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1141 ---

[GitHub] metron issue #1141: Metron-1727: metron-rest service needs to be restarted a...

2018-08-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1141 @MohanDV - in the future, please make sure the PR title matches the Jira ticket title. ---

[GitHub] metron issue #1166: METRON-1738: Pcap directories should have correct permis...

2018-08-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1166 @merrimanr - this has been merged into the feature branch, please close. ---

[jira] [Commented] (METRON-1738) Pcap directories should have correct permissions

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581675#comment-16581675 ] ASF GitHub Bot commented on METRON-1738: Github user mmiklavc commented on the i

[jira] [Commented] (METRON-1737) Document Job cleanup

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581669#comment-16581669 ] ASF GitHub Bot commented on METRON-1737: Github user mmiklavc commented on the i

[GitHub] metron issue #1164: METRON-1737: Document Job cleanup

2018-08-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1164 @merrimanr - this has been merged into the feature branch, please close. ---

[jira] [Commented] (METRON-1737) Document Job cleanup

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581656#comment-16581656 ] ASF GitHub Bot commented on METRON-1737: Github user mmiklavc commented on the i

[GitHub] metron issue #1164: METRON-1737: Document Job cleanup

2018-08-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1164 +1, thanks @merrimanr ---

[jira] [Commented] (METRON-1738) Pcap directories should have correct permissions

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581621#comment-16581621 ] ASF GitHub Bot commented on METRON-1738: Github user mmiklavc commented on the i

[GitHub] metron issue #1166: METRON-1738: Pcap directories should have correct permis...

2018-08-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1166 > I validated this in full dev. After full finishes building these are the HDFS permissions: I was literally about to tear down my full dev and duplicate exactly this effort. I'm happy to

[jira] [Commented] (METRON-1737) Document Job cleanup

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581581#comment-16581581 ] ASF GitHub Bot commented on METRON-1737: Github user merrimanr commented on the

[GitHub] metron issue #1164: METRON-1737: Document Job cleanup

2018-08-15 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1164 The latest commit adds that link. ---

[jira] [Commented] (METRON-1738) Pcap directories should have correct permissions

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581577#comment-16581577 ] ASF GitHub Bot commented on METRON-1738: Github user merrimanr commented on the

[GitHub] metron issue #1166: METRON-1738: Pcap directories should have correct permis...

2018-08-15 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1166 I validated this in full dev. After full finishes building these are the HDFS permissions: ``` [root@node1 vagrant]# hdfs dfs -ls /apps/metron/pcap Found 3 items drwxrwxr-x - met

[jira] [Updated] (METRON-1703) Make Core Profiler Components Serializable

2018-08-15 Thread Nick Allen (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Allen updated METRON-1703: --- Fix Version/s: (was: Next + 1) > Make Core Profiler Components Serializable > --

[jira] [Updated] (METRON-1703) Make Core Profiler Components Serializable

2018-08-15 Thread Nick Allen (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Allen updated METRON-1703: --- Fix Version/s: Next + 1 > Make Core Profiler Components Serializable > -

[jira] [Commented] (METRON-1724) Date/time validation missing in PCAP query

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581549#comment-16581549 ] ASF GitHub Bot commented on METRON-1724: Github user tiborm commented on the iss

[jira] [Commented] (METRON-1724) Date/time validation missing in PCAP query

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581550#comment-16581550 ] ASF GitHub Bot commented on METRON-1724: Github user tiborm closed the pull requ

[GitHub] metron issue #1165: METRON-1724: Date/time validation missing in PCAP query

2018-08-15 Thread tiborm
Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1165 Thank you guys for the reivew! It seems there is too many issue with the PR. I'm going to close it and open a new one after we fixed the merge issues etc. ---

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread tiborm
Github user tiborm closed the pull request at: https://github.com/apache/metron/pull/1165 ---

[jira] [Commented] (METRON-1734) Src and Dst port filters are incorrect after changing to empty

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581547#comment-16581547 ] ASF GitHub Bot commented on METRON-1734: Github user tiborm commented on the iss

[jira] [Commented] (METRON-1715) Create DEB Packaging for Batch Profiler

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581544#comment-16581544 ] ASF GitHub Bot commented on METRON-1715: GitHub user nickwallen opened a pull re

[GitHub] metron issue #1159: METRON-1734: Src and Dst port filters are incorrect afte...

2018-08-15 Thread tiborm
Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1159 Thanks guys for the reviews! It seems too many issue with the PR with it's current state. I close it and open another one later we solved bad merges etc. ---

[GitHub] metron pull request #1167: METRON-1715 Create DEB Packaging for Batch Profil...

2018-08-15 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1167 METRON-1715 Create DEB Packaging for Batch Profiler This creates a DEB package that makes it simple to install the Batch Profiler. There are now two separate packages created for the Profiler;

[jira] [Assigned] (METRON-1715) Create DEB Packaging for Batch Profiler

2018-08-15 Thread Nick Allen (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Allen reassigned METRON-1715: -- Assignee: Nick Allen > Create DEB Packaging for Batch Profiler >

[jira] [Commented] (METRON-1737) Document Job cleanup

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581530#comment-16581530 ] ASF GitHub Bot commented on METRON-1737: Github user mmiklavc commented on the i

[GitHub] metron issue #1164: METRON-1737: Document Job cleanup

2018-08-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1164 Thanks for the updates/clarification @merrimanr. Per comments from @ottobackwards in the discuss thread, do we want/need to link to this? https://hadoop.apache.org/docs/current/hadoop-yarn

[jira] [Assigned] (METRON-1737) Document Job cleanup

2018-08-15 Thread Michael Miklavcic (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Miklavcic reassigned METRON-1737: - Assignee: Ryan Merriman (was: Michael Miklavcic) > Document Job cleanup >

[jira] [Assigned] (METRON-1738) Pcap directories should have correct permissions

2018-08-15 Thread Michael Miklavcic (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Miklavcic reassigned METRON-1738: - Assignee: Ryan Merriman (was: Michael Miklavcic) > Pcap directories should hav

[jira] [Commented] (METRON-1724) Date/time validation missing in PCAP query

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581510#comment-16581510 ] ASF GitHub Bot commented on METRON-1724: Github user tiborm commented on a diff

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread tiborm
Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1165#discussion_r210379924 --- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts --- @@ -17,13 +17,13 @@ */ export class PcapRequest { - sta

[jira] [Assigned] (METRON-1738) Pcap directories should have correct permissions

2018-08-15 Thread Michael Miklavcic (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Miklavcic reassigned METRON-1738: - Assignee: Michael Miklavcic (was: Ryan Merriman) > Pcap directories should hav

[jira] [Assigned] (METRON-1738) Pcap directories should have correct permissions

2018-08-15 Thread Michael Miklavcic (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Miklavcic reassigned METRON-1738: - Assignee: Ryan Merriman > Pcap directories should have correct permissions > --

[jira] [Assigned] (METRON-1737) Document Job cleanup

2018-08-15 Thread Michael Miklavcic (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Miklavcic reassigned METRON-1737: - Assignee: Michael Miklavcic (was: Ryan Merriman) > Document Job cleanup >

[jira] [Assigned] (METRON-1737) Document Job cleanup

2018-08-15 Thread Michael Miklavcic (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Miklavcic reassigned METRON-1737: - Assignee: Ryan Merriman > Document Job cleanup > > >

[jira] [Commented] (METRON-1724) Date/time validation missing in PCAP query

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581417#comment-16581417 ] ASF GitHub Bot commented on METRON-1724: Github user mmiklavc commented on the i

[GitHub] metron issue #1165: METRON-1724: Date/time validation missing in PCAP query

2018-08-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1165 @tiborm - I'm a little uneasy about the merge conflicts and commit history, as pointed out by @merrimanr. The number of changes *seems* relatively small, but per Ryan's review it looks like we had

[jira] [Commented] (METRON-1738) Pcap directories should have correct permissions

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581406#comment-16581406 ] ASF GitHub Bot commented on METRON-1738: Github user merrimanr commented on the

[GitHub] metron issue #1166: METRON-1738: Pcap directories should have correct permis...

2018-08-15 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1166 Good catch. The latest commit should address that. ---

[jira] [Commented] (METRON-1732) Fix job status liveness bug and parallelize finalizer file writing

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581391#comment-16581391 ] ASF GitHub Bot commented on METRON-1732: Github user mmiklavc commented on the i

[GitHub] metron issue #1157: METRON-1732: Fix job status liveness bug and parallelize...

2018-08-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1157 Closing as merged ---

[jira] [Commented] (METRON-1732) Fix job status liveness bug and parallelize finalizer file writing

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581392#comment-16581392 ] ASF GitHub Bot commented on METRON-1732: Github user mmiklavc closed the pull re

[GitHub] metron pull request #1157: METRON-1732: Fix job status liveness bug and para...

2018-08-15 Thread mmiklavc
Github user mmiklavc closed the pull request at: https://github.com/apache/metron/pull/1157 ---

[jira] [Commented] (METRON-1738) Pcap directories should have correct permissions

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581378#comment-16581378 ] ASF GitHub Bot commented on METRON-1738: Github user mmiklavc commented on the i

[GitHub] metron issue #1166: METRON-1738: Pcap directories should have correct permis...

2018-08-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1166 @merrimanr - just for clarification on the directory permissions: **Non-Kerberized** - storm:hadoop, 0775 - Storm impersonation does not work - Storm runs the topology, so i

[jira] [Commented] (METRON-1732) Fix job status liveness bug and parallelize finalizer file writing

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581344#comment-16581344 ] ASF GitHub Bot commented on METRON-1732: Github user mmiklavc commented on the i

[GitHub] metron issue #1157: METRON-1732: Fix job status liveness bug and parallelize...

2018-08-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1157 Awesome! Thanks for the review and smoke test @nickwallen and @merrimanr. I am going to go ahead and merge this. ---

[GitHub] metron issue #1157: METRON-1732: Fix job status liveness bug and parallelize...

2018-08-15 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1157 +1 I ran this up successfully. Validated... - [x] Alerts visible in the UI - [x] Metron Service Check - [x] Capture PCAP in HDFS - [x] Read PCAP from HDFS using CLI. - [x] Ab

[jira] [Commented] (METRON-1732) Fix job status liveness bug and parallelize finalizer file writing

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581321#comment-16581321 ] ASF GitHub Bot commented on METRON-1732: Github user nickwallen commented on the

[jira] [Commented] (METRON-1738) Pcap directories should have correct permissions

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581320#comment-16581320 ] ASF GitHub Bot commented on METRON-1738: GitHub user merrimanr opened a pull req

[GitHub] metron pull request #1166: METRON-1738: Pcap directories should have correct...

2018-08-15 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1166 METRON-1738: Pcap directories should have correct permissions ## Contributor Comments This PR corrects the Pcap HDFS directory permissions. When a cluster is not Kerberized, the Pcap topolog

[jira] [Commented] (METRON-1732) Fix job status liveness bug and parallelize finalizer file writing

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581314#comment-16581314 ] ASF GitHub Bot commented on METRON-1732: Github user merrimanr commented on the

[GitHub] metron issue #1157: METRON-1732: Fix job status liveness bug and parallelize...

2018-08-15 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1157 Please disregard. I failed to deploy the Ambari changes correctly. ---

[jira] [Commented] (METRON-1732) Fix job status liveness bug and parallelize finalizer file writing

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581308#comment-16581308 ] ASF GitHub Bot commented on METRON-1732: Github user merrimanr commented on the

[GitHub] metron issue #1157: METRON-1732: Fix job status liveness bug and parallelize...

2018-08-15 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1157 I ran a quick test in REST and it looks like the status never gets to `SUCCEEDED`. Here is my request: ``` curl -X POST --header 'Content-Type: application/json' --header 'Accept:

[jira] [Created] (METRON-1738) Pcap directories should have correct permissions

2018-08-15 Thread Ryan Merriman (JIRA)
Ryan Merriman created METRON-1738: - Summary: Pcap directories should have correct permissions Key: METRON-1738 URL: https://issues.apache.org/jira/browse/METRON-1738 Project: Metron Issue Typ

[jira] [Commented] (METRON-1724) Date/time validation missing in PCAP query

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581230#comment-16581230 ] ASF GitHub Bot commented on METRON-1724: Github user merrimanr commented on a di

[jira] [Commented] (METRON-1724) Date/time validation missing in PCAP query

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581228#comment-16581228 ] ASF GitHub Bot commented on METRON-1724: Github user merrimanr commented on a di

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1165#discussion_r210306554 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts --- @@ -179,19 +171,6 @@ describe('PcapFiltersComponent

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1165#discussion_r210306465 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts --- @@ -263,10 +230,10 @@ describe('PcapFiltersComponen

[GitHub] metron issue #1141: Metron-1727: metron-rest service needs to be restarted a...

2018-08-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1141 +1, lgtm. Thanks for the contribution @MohanDV! ---

[jira] [Commented] (METRON-1724) Date/time validation missing in PCAP query

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581175#comment-16581175 ] ASF GitHub Bot commented on METRON-1724: Github user merrimanr commented on the

[GitHub] metron issue #1165: METRON-1724: Date/time validation missing in PCAP query

2018-08-15 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1165 I tested this in full dev and it is not working. The From date is `1969-12-31 18:00:00` and the To date says `Invalid date`. The Src and Dst port fields are also populated with 0. It al

[jira] [Commented] (METRON-1696) Pcap parser fails to write pacap sequence file to hdfs on kerberized cluster

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581160#comment-16581160 ] ASF GitHub Bot commented on METRON-1696: Github user MohanDV commented on the is

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-15 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/1134 I am fine wuth closing this PR as this is currently implemented in REST. When pcap gets its own start/stop script in Ambari we can move the code from REST to respective file. ---

[jira] [Commented] (METRON-1724) Date/time validation missing in PCAP query

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581138#comment-16581138 ] ASF GitHub Bot commented on METRON-1724: Github user merrimanr commented on a di

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1165#discussion_r210285682 --- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts --- @@ -17,13 +17,13 @@ */ export class PcapRequest { -

[jira] [Commented] (METRON-1724) Date/time validation missing in PCAP query

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581135#comment-16581135 ] ASF GitHub Bot commented on METRON-1724: Github user merrimanr commented on a di

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1165#discussion_r210284527 --- Diff: metron-platform/metron-pcap-backend/src/test/java/org/apache/metron/pcap/query/PcapCliTest.java --- @@ -172,7 +172,8 @@ public void runs_fixed

[jira] [Commented] (METRON-1724) Date/time validation missing in PCAP query

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581134#comment-16581134 ] ASF GitHub Bot commented on METRON-1724: Github user merrimanr commented on a di

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1165#discussion_r210284388 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/mr/PcapJob.java --- @@ -494,6 +494,10 @@ protected void setMrJob(Job mrJob) {

[jira] [Commented] (METRON-1724) Date/time validation missing in PCAP query

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581080#comment-16581080 ] ASF GitHub Bot commented on METRON-1724: Github user tiborm commented on the iss

[GitHub] metron issue #1165: METRON-1724: Date/time validation missing in PCAP query

2018-08-15 Thread tiborm
Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1165 Thanks for reviewing! Please test this PR carefully becasue of the large amount of merge conflicts we solved part of this. We tested manually too, but it would be great to double check. All

[jira] [Commented] (METRON-1724) Date/time validation missing in PCAP query

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581077#comment-16581077 ] ASF GitHub Bot commented on METRON-1724: GitHub user tiborm opened a pull reques

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread tiborm
GitHub user tiborm opened a pull request: https://github.com/apache/metron/pull/1165 METRON-1724: Date/time validation missing in PCAP query ## Contributor Comments This PR contains date range validation. We also added validation messages with hints for the user how to correct a

[jira] [Updated] (METRON-1724) Date/time validation missing in PCAP query

2018-08-15 Thread Tibor Meller (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-1724: - Description: Validation formula should be the following:  From < To < current date/time   Val

[jira] [Commented] (METRON-1703) Make Core Profiler Components Serializable

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581065#comment-16581065 ] ASF GitHub Bot commented on METRON-1703: Github user nickwallen commented on the

[jira] [Commented] (METRON-1703) Make Core Profiler Components Serializable

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581066#comment-16581066 ] ASF GitHub Bot commented on METRON-1703: Github user nickwallen closed the pull

[GitHub] metron pull request #1145: METRON-1703 Make Core Profiler Components Seriali...

2018-08-15 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/1145 ---

[GitHub] metron issue #1145: METRON-1703 Make Core Profiler Components Serializable [...

2018-08-15 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1145 Thanks @merrimanr ! I merged this one. ---

[jira] [Commented] (METRON-1703) Make Core Profiler Components Serializable

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581043#comment-16581043 ] ASF GitHub Bot commented on METRON-1703: Github user merrimanr commented on the

[GitHub] metron issue #1145: METRON-1703 Make Core Profiler Components Serializable [...

2018-08-15 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1145 Thanks for the explanation @nickwallen. +1 ---

[jira] [Commented] (METRON-1703) Make Core Profiler Components Serializable

2018-08-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581026#comment-16581026 ] ASF GitHub Bot commented on METRON-1703: Github user nickwallen commented on the

[GitHub] metron issue #1145: METRON-1703 Make Core Profiler Components Serializable [...

2018-08-15 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1145 @merrimanr It just happens that the classes in `org.apache.metron.profiler.hbase` are not serialized and sent over the wire. Those classes are instantiated as-needed. You can see that in #1150