[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1190 ---

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-10-04 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r222823946 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java --- @@ -282,4 +276,27 @@ public Document getLat

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-10-04 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r222750671 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java --- @@ -282,4 +276,27 @@ public Document getLa

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-10-03 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r222470180 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java --- @@ -282,4 +276,27 @@ public Document getLat

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-10-03 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r222421545 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/dao/ElasticsearchUpdateDaoTest.java --- @@ -0,0 +1,48 @@

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-10-03 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r222420697 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java --- @@ -282,4 +276,27 @@ public Document getLa

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-10-02 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r222000643 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java --- @@ -282,4 +276,27 @@ public Document getLat

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-13 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r217462174 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/dao/ElasticsearchUpdateDaoTest.java --- @@ -0,0 +1,48 @@

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-13 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r217462087 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/InMemoryMetaAlertRetrieveLatestDao.java --- @@ -0,0 +1,45 @@ +/*

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r217461869 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/dao/ElasticsearchUpdateDaoTest.java --- @@ -0,0 +1,48 @@

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-13 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r217459943 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java --- @@ -282,4 +276,27 @@ public Document getLat

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-13 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r217459852 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/dao/ElasticsearchUpdateDaoTest.java --- @@ -0,0 +1,48 @@

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r217441951 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/InMemoryMetaAlertRetrieveLatestDao.java --- @@ -0,0 +1,45 @@ +/*

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r217441386 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java --- @@ -282,4 +276,27 @@ public Document getLa

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r217439809 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java --- @@ -101,48 +103,59 @@ public void batchUpd

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r217438881 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/dao/ElasticsearchUpdateDaoTest.java --- @@ -0,0 +1,48 @@

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216739437 --- Diff: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrUpdateDao.java --- @@ -117,18 +118,19 @@ public void batchUpdate(Map>

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216733487 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java --- @@ -121,20 +131,30 @@ public void addComme

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216725905 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchUpdateDao.java --- @@ -108,20 +109,21 @@ p

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216727723 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -280,14 +282,14 @@ protected Put buildPut(Do

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216735553 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/metaalert/lucene/AbstractLuceneMetaAlertUpdateDao.java --- @@ -17

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216728030 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -309,28 +311,28 @@ public void addCommentToA

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216733316 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java --- @@ -121,20 +131,30 @@ public void addComme

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216726476 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchUpdateDao.java --- @@ -133,21 +135,21 @@ p

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216739553 --- Diff: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrUpdateDao.java --- @@ -172,7 +174,7 @@ public void removeCommentFrom

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216739478 --- Diff: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrUpdateDao.java --- @@ -149,21 +151,21 @@ public void addCommentToAler

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216735006 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/metaalert/lucene/AbstractLuceneMetaAlertUpdateDao.java --- @@ -17

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-07 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216092662 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/integration/HBaseDaoIntegrationTest.java --- @@ -61,8 +60,8 @@

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-07 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216092562 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/metaalert/MetaAlertIntegrationTest.java --- @@ -985,6 +1024,30 @@

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-07 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216091611 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/InMemoryMetaAlertUpdateDao.java --- @@ -0,0 +1,86 @@ +/* +

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-07 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216091258 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/InMemoryMetaAlertDao.java --- @@ -174,145 +193,29 @@ public Search

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-07 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216090892 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/InMemoryMetaAlertRetrieveLatestDao.java --- @@ -0,0 +1,45 @@ +/*

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-07 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216090740 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/metaalert/lucene/AbstractLuceneMetaAlertUpdateDao.java --- @@ -170

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-07 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216090450 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java --- @@ -121,20 +131,30 @@ public void addCommen

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-07 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1190#discussion_r216090059 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchUpdateDao.java --- @@ -108,20 +109,21 @@ pu

[GitHub] metron pull request #1190: METRON-1771: Update REST endpoints to support eve...

2018-09-07 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1190 METRON-1771: Update REST endpoints to support eventually consistent UI updates ## Contributor Comments This PR updates several REST endpoints to return the state of an object on update opera