[jira] [Commented] (METRON-1730) Update steps to run pycapa on Centos 6

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572539#comment-16572539 ] ASF GitHub Bot commented on METRON-1730: GitHub user mmiklavc opened a pull request:

[GitHub] metron pull request #1152: METRON-1730: Update steps to run pycapa on Centos...

2018-08-07 Thread mmiklavc
GitHub user mmiklavc opened a pull request: https://github.com/apache/metron/pull/1152 METRON-1730: Update steps to run pycapa on Centos 6 ## Contributor Comments https://issues.apache.org/jira/browse/METRON-1730 This is piggybacking off of the Kerberos work in

[jira] [Created] (METRON-1730) Update steps to run pycapa on Centos 6

2018-08-07 Thread Michael Miklavcic (JIRA)
Michael Miklavcic created METRON-1730: - Summary: Update steps to run pycapa on Centos 6 Key: METRON-1730 URL: https://issues.apache.org/jira/browse/METRON-1730 Project: Metron Issue

[jira] [Commented] (METRON-1695) Expose pcap properties through Ambari

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572490#comment-16572490 ] ASF GitHub Bot commented on METRON-1695: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1132: METRON-1695: Expose pcap properties through Ambari

2018-08-07 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1132 @anandsubbu, I hate to give you whiplash, but @merrimanr may have a point here. There benefit of exposing the pcap properties via Ambari is lessened by now requiring the user to do 3 things

[jira] [Commented] (METRON-1726) Refactor PcapTopologyIntegrationTest

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572334#comment-16572334 ] ASF GitHub Bot commented on METRON-1726: Github user mmiklavc closed the pull request at:

[jira] [Commented] (METRON-1726) Refactor PcapTopologyIntegrationTest

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572333#comment-16572333 ] ASF GitHub Bot commented on METRON-1726: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1140: METRON-1726: Refactor PcapTopologyIntegrationTest

2018-08-07 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1140 Merged into feature branch, closing ---

[GitHub] metron pull request #1140: METRON-1726: Refactor PcapTopologyIntegrationTest

2018-08-07 Thread mmiklavc
Github user mmiklavc closed the pull request at: https://github.com/apache/metron/pull/1140 ---

[jira] [Created] (METRON-1729) Split Pcap integration tests into separate topology and query tests

2018-08-07 Thread Michael Miklavcic (JIRA)
Michael Miklavcic created METRON-1729: - Summary: Split Pcap integration tests into separate topology and query tests Key: METRON-1729 URL: https://issues.apache.org/jira/browse/METRON-1729

[jira] [Commented] (METRON-1726) Refactor PcapTopologyIntegrationTest

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572319#comment-16572319 ] ASF GitHub Bot commented on METRON-1726: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1140: METRON-1726: Refactor PcapTopologyIntegrationTest

2018-08-07 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1140 @merrimanr - agreed. Pcap hasn't gotten nearly as much attention as the rest of the core infrastructure for quite some time. I created a Jira to track this -

[jira] [Commented] (METRON-1713) PCAP UI - Add a way to kill a pcap job

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572312#comment-16572312 ] ASF GitHub Bot commented on METRON-1713: Github user justinleet commented on the issue:

[GitHub] metron issue #1143: METRON-1713: Adding "cancel query" button

2018-08-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1143 If the job has been submitted, but not yet returned with a job id (because it takes a few seconds to kick of a job), the kill request fails. The request goes to (for example)

[GitHub] metron issue #1132: METRON-1695: Expose pcap properties through Ambari

2018-08-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1132 I don't see any good reason to put off making pcap it's own Ambari component. Having to restart the parsers component (which is unrelated to pcap) to propagate pcap changes is a deal breaker for

[jira] [Commented] (METRON-1695) Expose pcap properties through Ambari

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572304#comment-16572304 ] ASF GitHub Bot commented on METRON-1695: Github user merrimanr commented on the issue:

[jira] [Commented] (METRON-1696) Pcap parser fails to write pacap sequence file to hdfs on kerberized cluster

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572269#comment-16572269 ] ASF GitHub Bot commented on METRON-1696: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-07 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1134 Good catch @merrimanr https://github.com/apache/metron/pull/1019/files#diff-72aaf03b3dda189de983e94bc8dfcb64R119 When I was testing queries in some other feature branch PR's, I had to

[jira] [Commented] (METRON-1695) Expose pcap properties through Ambari

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572258#comment-16572258 ] ASF GitHub Bot commented on METRON-1695: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1132: METRON-1695: Expose pcap properties through Ambari

2018-08-07 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1132 @anandsubbu thanks for the updates, I'm going merge your PR. ---

[jira] [Commented] (METRON-1726) Refactor PcapTopologyIntegrationTest

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572245#comment-16572245 ] ASF GitHub Bot commented on METRON-1726: Github user merrimanr commented on the issue:

[GitHub] metron issue #1140: METRON-1726: Refactor PcapTopologyIntegrationTest

2018-08-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1140 That's fine with me. Just wanted to point out that this test is still deficient because the pcap topology part really isn't tested that well and the only coverage we have right now is that it

[jira] [Commented] (METRON-1728) Handle null values in config in Pcap backend more gracefully

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572241#comment-16572241 ] ASF GitHub Bot commented on METRON-1728: GitHub user mmiklavc opened a pull request:

[GitHub] metron pull request #1151: METRON-1728: Handle null values in config in Pcap...

2018-08-07 Thread mmiklavc
GitHub user mmiklavc opened a pull request: https://github.com/apache/metron/pull/1151 METRON-1728: Handle null values in config in Pcap backend more gracefully ## Contributor Comments https://issues.apache.org/jira/browse/METRON-1728 I modified the ConfigOptions

[jira] [Created] (METRON-1728) Handle null values in config in Pcap backend more gracefully

2018-08-07 Thread Michael Miklavcic (JIRA)
Michael Miklavcic created METRON-1728: - Summary: Handle null values in config in Pcap backend more gracefully Key: METRON-1728 URL: https://issues.apache.org/jira/browse/METRON-1728 Project:

[jira] [Commented] (METRON-1713) PCAP UI - Add a way to kill a pcap job

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572231#comment-16572231 ] ASF GitHub Bot commented on METRON-1713: Github user justinleet commented on the issue:

[GitHub] metron issue #1143: METRON-1713: Adding "cancel query" button

2018-08-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1143 Please change the title to "METRON-1713: PCAP UI - Add a way to kill a pcap job" to match https://issues.apache.org/jira/browse/METRON-1713 ---

[jira] [Commented] (METRON-1726) Refactor PcapTopologyIntegrationTest

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572229#comment-16572229 ] ASF GitHub Bot commented on METRON-1726: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1140: METRON-1726: Refactor PcapTopologyIntegrationTest

2018-08-07 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1140 > If I introduced a bug to the pcap topology code, which test would fail? @merrimanr They would all fail because the writing to HDFS sequence files is incorrect. Prior to this refactoring,

[GitHub] metron issue #1142: Metron-1712: Input validation

2018-08-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1142 I ran this up and I'm able to run a query with ip: - 999.999.999.999 Each of the four octets should be in the range [0-255], e.g. 0.0.0.0, 255.255.255.255, 255.0.12.100 etc.

[jira] [Commented] (METRON-1683) PCAP UI - Fix the download progress bar

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572205#comment-16572205 ] ASF GitHub Bot commented on METRON-1683: Github user merrimanr commented on the issue:

[GitHub] metron issue #1122: METRON-1683: Fix the download progress bar in PCAP UI

2018-08-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1122 @sardell this is merged. Can you close? ---

[GitHub] metron issue #1142: Metron-1712: Input validation

2018-08-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1142 Can you please change the title of this PR to "Metron-1712: PCAP UI - Input validation"? ---

[jira] [Commented] (METRON-1722) PcapCLI should print progress to stdout

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572181#comment-16572181 ] ASF GitHub Bot commented on METRON-1722: Github user justinleet commented on the issue:

[GitHub] metron issue #1138: METRON-1722: PcapCLI should print progress to stdout

2018-08-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1138 +1 by inspection, assuming @mmiklavc is good. ---

[jira] [Commented] (METRON-1696) Pcap parser fails to write pacap sequence file to hdfs on kerberized cluster

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572158#comment-16572158 ] ASF GitHub Bot commented on METRON-1696: Github user merrimanr commented on the issue:

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1134 Just FYI, this work was already done in https://github.com/apache/metron/pull/1019. I do not see much value in merging this into master since it will likely be overwritten when the pcap feature

[jira] [Commented] (METRON-1726) Refactor PcapTopologyIntegrationTest

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572153#comment-16572153 ] ASF GitHub Bot commented on METRON-1726: Github user merrimanr commented on the issue:

[GitHub] metron issue #1140: METRON-1726: Refactor PcapTopologyIntegrationTest

2018-08-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1140 First off, I think this is definitely an improvement. Putting the individual pcap queries into separate tests makes it easier to understand when things go wrong. Would it make sense to

[jira] [Commented] (METRON-1722) PcapCLI should print progress to stdout

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572123#comment-16572123 ] ASF GitHub Bot commented on METRON-1722: Github user merrimanr commented on the issue:

[GitHub] metron issue #1138: METRON-1722: PcapCLI should print progress to stdout

2018-08-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1138 @mmiklavc the latest commit includes the changes you suggested. Let me know what you think. ---

[GitHub] metron issue #1122: METRON-1683: Fix the download progress bar in PCAP UI

2018-08-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1122 +1, this there's good stuff here. Thanks! ---

[jira] [Commented] (METRON-1683) PCAP UI - Fix the download progress bar

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572093#comment-16572093 ] ASF GitHub Bot commented on METRON-1683: Github user justinleet commented on the issue:

[jira] [Commented] (METRON-1707) Port Profiler to Spark

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572024#comment-16572024 ] ASF GitHub Bot commented on METRON-1707: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1150: METRON-1707 Port Profiler to Spark [Feature Branc...

2018-08-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1150#discussion_r208320208 --- Diff: metron-analytics/metron-profiler-spark/src/main/java/org/apache/metron/profiler/spark/BatchProfiler.java --- @@ -0,0 +1,188 @@ +/* +

[jira] [Commented] (METRON-1707) Port Profiler to Spark

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572017#comment-16572017 ] ASF GitHub Bot commented on METRON-1707: GitHub user nickwallen opened a pull request:

[GitHub] metron pull request #1150: METRON-1707 Port Profiler to Spark

2018-08-07 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1150 METRON-1707 Port Profiler to Spark This ports the Profiler to run in Spark. This is a pull request against the `METRON-1699-create-batch-profiler` feature branch. This is

[jira] [Commented] (METRON-1707) Port Profiler to Spark

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572016#comment-16572016 ] ASF GitHub Bot commented on METRON-1707: Github user nickwallen closed the pull request at:

[jira] [Commented] (METRON-1707) Port Profiler to Spark

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572014#comment-16572014 ] ASF GitHub Bot commented on METRON-1707: GitHub user nickwallen opened a pull request:

[GitHub] metron pull request #1149: METRON-1707 Port Profiler to Spark

2018-08-07 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/1149 ---

[GitHub] metron pull request #1149: METRON-1707 Port Profiler to Spark

2018-08-07 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1149 METRON-1707 Port Profiler to Spark This ports the Profiler to run in Spark. This is a pull request against the `METRON-1699-create-batch-profiler` feature branch. This is

[jira] [Commented] (METRON-1705) Create ProfilePeriod Using Period ID

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571972#comment-16571972 ] ASF GitHub Bot commented on METRON-1705: GitHub user nickwallen opened a pull request:

[GitHub] metron pull request #1148: METRON-1705 Create ProfilePeriod Using Period ID ...

2018-08-07 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1148 METRON-1705 Create ProfilePeriod Using Period ID [Feature Branch] In some cases you need to be able to create a `ProfilerPeriod` using an epoch timestamp. In other cases, you need to be able

[jira] [Commented] (METRON-1706) HbaseClient.mutate should return the number of mutations

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571965#comment-16571965 ] ASF GitHub Bot commented on METRON-1706: GitHub user nickwallen opened a pull request:

[GitHub] metron pull request #1147: METRON-1706: HbaseClient.mutate should return the...

2018-08-07 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1147 METRON-1706: HbaseClient.mutate should return the number of mutations [Feature Branch] The `HbaseClient.mutate` method should return the number of mutations. This is a pull request

[jira] [Commented] (METRON-1704) Message Timestamp Logic Should be Shared

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571956#comment-16571956 ] ASF GitHub Bot commented on METRON-1704: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1146: METRON-1704 Message Timestamp Logic Should be Sha...

2018-08-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1146#discussion_r208305293 --- Diff: metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/StandAloneProfiler.java --- @@ -112,26 +112,14 @@ public

[jira] [Commented] (METRON-1704) Message Timestamp Logic Should be Shared

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571953#comment-16571953 ] ASF GitHub Bot commented on METRON-1704: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1146: METRON-1704 Message Timestamp Logic Should be Sha...

2018-08-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1146#discussion_r208304859 --- Diff: metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/DefaultMessageRouter.java --- @@ -53,10 +56,16 @@ */

[jira] [Commented] (METRON-1704) Message Timestamp Logic Should be Shared

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571950#comment-16571950 ] ASF GitHub Bot commented on METRON-1704: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1146: METRON-1704 Message Timestamp Logic Should be Sha...

2018-08-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1146#discussion_r208304304 --- Diff: metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/DefaultMessageDistributor.java --- @@ -146,16 +146,14 @@

[GitHub] metron pull request #1146: METRON-1704 Message Timestamp Logic Should be Sha...

2018-08-07 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1146 METRON-1704 Message Timestamp Logic Should be Shared The Profiler can operate using either processing time or event time. This is controlled by the user by defining the "timestampField" option

[jira] [Commented] (METRON-1683) PCAP UI - Fix the download progress bar

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571946#comment-16571946 ] ASF GitHub Bot commented on METRON-1683: Github user merrimanr commented on the issue:

[GitHub] metron issue #1122: METRON-1683: Fix the download progress bar in PCAP UI

2018-08-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1122 The unit tests look good to me. I am +1 contingent on the issues that @justinleet found are fixed with the recent commits. ---

[jira] [Updated] (METRON-1704) Message Timestamp Logic Should be Shared

2018-08-07 Thread Nick Allen (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Allen updated METRON-1704: --- Summary: Message Timestamp Logic Should be Shared (was: Message Timestamp Determination Should be

[jira] [Commented] (METRON-1703) Make Core Profiler Components Serializable

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571928#comment-16571928 ] ASF GitHub Bot commented on METRON-1703: GitHub user nickwallen opened a pull request:

[GitHub] metron pull request #1145: METRON-1703 Make Core Profiler Components Seriali...

2018-08-07 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1145 METRON-1703 Make Core Profiler Components Serializable All of the core Profiler components are now tagged as Serializable. This allows users to use Java serialization if desired, when

[jira] [Commented] (METRON-1703) Make Core Profiler Components Serializable

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571926#comment-16571926 ] ASF GitHub Bot commented on METRON-1703: GitHub user nickwallen opened a pull request:

[jira] [Commented] (METRON-1703) Make Core Profiler Components Serializable

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571927#comment-16571927 ] ASF GitHub Bot commented on METRON-1703: Github user nickwallen closed the pull request at:

[GitHub] metron pull request #1144: METRON-1703 Make Core Profiler Components Seriali...

2018-08-07 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1144 METRON-1703 Make Core Profiler Components Serializable All of the core Profiler components are now tagged as Serializable. This allows users to use Java serialization if desired, when

[GitHub] metron pull request #1144: METRON-1703 Make Core Profiler Components Seriali...

2018-08-07 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/1144 ---

[jira] [Commented] (METRON-1726) Refactor PcapTopologyIntegrationTest

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571898#comment-16571898 ] ASF GitHub Bot commented on METRON-1726: Github user justinleet commented on the issue:

[GitHub] metron issue #1140: METRON-1726: Refactor PcapTopologyIntegrationTest

2018-08-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1140 +1 by inspection. This is great cleanup and makes it a lot easier to understand. ---

[jira] [Commented] (METRON-1713) PCAP UI - Add a way to kill a pcap job

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571895#comment-16571895 ] ASF GitHub Bot commented on METRON-1713: GitHub user tiborm opened a pull request:

[GitHub] metron pull request #1143: METRON-1713: Adding "cancel query" button

2018-08-07 Thread tiborm
GitHub user tiborm opened a pull request: https://github.com/apache/metron/pull/1143 METRON-1713: Adding "cancel query" button ## Contributor Comments This PR contains the implementation of the cancel button of a running pcap query.

[jira] [Updated] (METRON-1713) PCAP UI - Add a way to kill a pcap job

2018-08-07 Thread Shane Ardell (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-1713: - Description: As a user, I would like to be able to cancel my ongoing PCAP query request. In

[jira] [Commented] (METRON-1724) Date/time validation missing in PCAP query

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571847#comment-16571847 ] ASF GitHub Bot commented on METRON-1724: GitHub user tiborm opened a pull request:

[GitHub] metron pull request #1142: Metron-1712: Input validation

2018-08-07 Thread tiborm
GitHub user tiborm opened a pull request: https://github.com/apache/metron/pull/1142 Metron-1712: Input validation ## Contributor Comments This PR contains the input validation for ipSrcAdr, ipSrcPort, ipDestAdr, ipDestPort fiels. Please find the details in the

[jira] [Commented] (METRON-1712) PCAP UI - Input validation

2018-08-07 Thread Tibor Meller (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571844#comment-16571844 ] Tibor Meller commented on METRON-1712: -- There is a followup ticket on this: *Date rage validation*

[jira] [Comment Edited] (METRON-1712) PCAP UI - Input validation

2018-08-07 Thread Tibor Meller (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571844#comment-16571844 ] Tibor Meller edited comment on METRON-1712 at 8/7/18 3:31 PM: -- There is a

[jira] [Updated] (METRON-1712) PCAP UI - Input validation

2018-08-07 Thread Shane Ardell (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-1712: - Description: The following fields need input validation: IP Source Address: should accept

[jira] [Commented] (METRON-1683) PCAP UI - Fix the download progress bar

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571745#comment-16571745 ] ASF GitHub Bot commented on METRON-1683: Github user sardell commented on the issue:

[GitHub] metron issue #1122: METRON-1683: Fix the download progress bar in PCAP UI

2018-08-07 Thread sardell
Github user sardell commented on the issue: https://github.com/apache/metron/pull/1122 @justinleet No problem at all. Those conflicts have now been resolved. ---

[jira] [Commented] (METRON-1723) PCAP UI - Unable to select/copy from packets details in PCAP query panel

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571721#comment-16571721 ] ASF GitHub Bot commented on METRON-1723: Github user justinleet commented on the issue:

[GitHub] metron issue #1139: METRON-1723: Unable to select/copy from packets details ...

2018-08-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1139 Spun this up and it worked great. Once we can get the parents in and the merge conflicts resolved, I'm very happy with this, it's a great QoL change. ---

[jira] [Commented] (METRON-1683) PCAP UI - Fix the download progress bar

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571720#comment-16571720 ] ASF GitHub Bot commented on METRON-1683: Github user justinleet commented on the issue:

[GitHub] metron issue #1122: METRON-1683: Fix the download progress bar in PCAP UI

2018-08-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1122 @sardell Heads up, looks like you have some merge conflicts to take care off. Thanks for taking care of those, that's a great fix to have in! ---

[GitHub] metron issue #1121: METRON-1675: Add Pagination to PCAP

2018-08-07 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1121 lgtm, +1 via inspection. Thanks for the updates to this PR. ---

[jira] [Commented] (METRON-1675) PCAP UI - Introduce the paging capability

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571717#comment-16571717 ] ASF GitHub Bot commented on METRON-1675: Github user mmiklavc commented on the issue:

[jira] [Commented] (METRON-1675) PCAP UI - Introduce the paging capability

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571714#comment-16571714 ] ASF GitHub Bot commented on METRON-1675: Github user sardell closed the pull request at:

[GitHub] metron pull request #1121: METRON-1675: Add Pagination to PCAP

2018-08-07 Thread sardell
Github user sardell closed the pull request at: https://github.com/apache/metron/pull/1121 ---

[jira] [Commented] (METRON-1675) PCAP UI - Introduce the paging capability

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571713#comment-16571713 ] ASF GitHub Bot commented on METRON-1675: Github user merrimanr commented on the issue:

[GitHub] metron issue #1121: METRON-1675: Add Pagination to PCAP

2018-08-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1121 This has been merged @sardell. Can you close? ---

[jira] [Commented] (METRON-1675) PCAP UI - Introduce the paging capability

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571697#comment-16571697 ] ASF GitHub Bot commented on METRON-1675: Github user justinleet commented on the issue:

[GitHub] metron issue #1121: METRON-1675: Add Pagination to PCAP

2018-08-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1121 +1, thanks for the contribution! ---

[jira] [Commented] (METRON-1683) PCAP UI - Fix the download progress bar

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571687#comment-16571687 ] ASF GitHub Bot commented on METRON-1683: Github user sardell commented on the issue:

[GitHub] metron issue #1122: METRON-1683: Fix the download progress bar in PCAP UI

2018-08-07 Thread sardell
Github user sardell commented on the issue: https://github.com/apache/metron/pull/1122 @justinleet Thanks for the feedback. I've updated the panel component to disable the submit button and display the progress bar on search submit rather than first response from REST. ---

[jira] [Commented] (METRON-1675) PCAP UI - Introduce the paging capability

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571675#comment-16571675 ] ASF GitHub Bot commented on METRON-1675: Github user merrimanr commented on the issue:

[jira] [Commented] (METRON-1683) PCAP UI - Fix the download progress bar

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571676#comment-16571676 ] ASF GitHub Bot commented on METRON-1683: Github user justinleet commented on the issue:

[GitHub] metron issue #1122: METRON-1683: Fix the download progress bar in PCAP UI

2018-08-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1122 Couple quick comments on this after spinning it up. 1. The progress bar doesn't show up until the job submission returns. However, because this is a MapReduce job, it can take a few

  1   2   >