[jira] [Commented] (MINIFICPP-264) Implement CompressContent Processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219920#comment-16219920 ] ASF GitHub Bot commented on MINIFICPP-264: -- Github user minifirocks commented on the issue:

[GitHub] nifi-minifi-cpp issue #151: MINIFICPP-264: CompressContent Processor

2017-10-25 Thread minifirocks
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/151 refactor to use lib archive extension. ---

[jira] [Commented] (MINIFICPP-265) Disable incidental -fsanitize address

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219875#comment-16219875 ] ASF GitHub Bot commented on MINIFICPP-265: -- Github user asfgit closed the pull request at:

[GitHub] nifi-minifi-cpp pull request #154: MINIFICPP-265 Disabled fsanitize=address ...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/154 ---

[jira] [Commented] (MINIFICPP-263) Move libarchive functionality to an extension

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219876#comment-16219876 ] ASF GitHub Bot commented on MINIFICPP-263: -- Github user asfgit closed the pull request at:

[GitHub] nifi-minifi-cpp pull request #153: MINIFICPP-263: Move merge content to an e...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/153 ---

[jira] [Commented] (MINIFICPP-263) Move libarchive functionality to an extension

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219821#comment-16219821 ] ASF GitHub Bot commented on MINIFICPP-263: -- Github user apiri commented on the issue:

[GitHub] nifi-minifi-cpp issue #153: MINIFICPP-263: Move merge content to an extensio...

2017-10-25 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/153 @phrocker Included the closes phrase in the commit but didn't seem to get picked up here. If you could please close this when you get the opportunity it would be appreciated. ---

[jira] [Updated] (MINIFICPP-263) Move libarchive functionality to an extension

2017-10-25 Thread Aldrin Piri (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri updated MINIFICPP-263: -- Fix Version/s: 0.3.0 > Move libarchive functionality to an extension >

[jira] [Resolved] (MINIFICPP-263) Move libarchive functionality to an extension

2017-10-25 Thread Aldrin Piri (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri resolved MINIFICPP-263. --- Resolution: Fixed > Move libarchive functionality to an extension >

[GitHub] nifi-minifi-cpp issue #153: MINIFICPP-263: Move merge content to an extensio...

2017-10-25 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/153 Looks great. Will get this merged. Thanks! ---

[jira] [Commented] (MINIFICPP-263) Move libarchive functionality to an extension

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219813#comment-16219813 ] ASF GitHub Bot commented on MINIFICPP-263: -- Github user apiri commented on the issue:

[GitHub] nifi-minifi-cpp issue #154: MINIFICPP-265 Disabled fsanitize=address for now...

2017-10-25 Thread minifirocks
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/154 looks good. ---

[jira] [Commented] (MINIFICPP-265) Disable incidental -fsanitize address

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219748#comment-16219748 ] ASF GitHub Bot commented on MINIFICPP-265: -- Github user minifirocks commented on the issue:

[jira] [Commented] (NIFI-4410) PutElasticsearchHttp needs better error handling and logging

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219672#comment-16219672 ] ASF GitHub Bot commented on NIFI-4410: -- Github user mattyb149 commented on the issue:

[GitHub] nifi issue #2175: NIFI-4410: Improved error handling/logging in PutElasticse...

2017-10-25 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2175 If you need to raise the logging level, you can add that processor to logback.xml with a setting of INFO, otherwise you can change all processors to INFO with the following sed statement (works on

[jira] [Commented] (NIFI-4410) PutElasticsearchHttp needs better error handling and logging

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219671#comment-16219671 ] ASF GitHub Bot commented on NIFI-4410: -- Github user mattyb149 commented on the issue:

[GitHub] nifi issue #2175: NIFI-4410: Improved error handling/logging in PutElasticse...

2017-10-25 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2175 Before the fix, you would probably see a log statement for each failed doc. Also for some "not found" errors, such as maybe deleting a doc that doesn't exist? you would see an empty reason. The fix

[jira] [Commented] (NIFI-4410) PutElasticsearchHttp needs better error handling and logging

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219658#comment-16219658 ] ASF GitHub Bot commented on NIFI-4410: -- Github user MikeThomsen commented on the issue:

[GitHub] nifi issue #2175: NIFI-4410: Improved error handling/logging in PutElasticse...

2017-10-25 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2175 I actually had a bad batch go through, and it sent them out properly. What log settings need to be set in the configuration files to make sure I see your changes? ---

[jira] [Commented] (NIFI-4506) Add date functions to Record Path

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219622#comment-16219622 ] ASF GitHub Bot commented on NIFI-4506: -- Github user mattyb149 commented on a diff in the pull request:

[GitHub] nifi pull request #2221: NIFI-4506 Adding toDate and format functions to rec...

2017-10-25 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2221#discussion_r146999573 --- Diff: nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/paths/RecordPathCompiler.java --- @@ -346,4 +356,19 @@ private static

[jira] [Created] (NIFI-4527) unable to get dynamicallyModifiesClasspath for PropertyDescriptor to work

2017-10-25 Thread Bob Whitehurst (JIRA)
Bob Whitehurst created NIFI-4527: Summary: unable to get dynamicallyModifiesClasspath for PropertyDescriptor to work Key: NIFI-4527 URL: https://issues.apache.org/jira/browse/NIFI-4527 Project:

[jira] [Commented] (NIFIREG-43) Provide configurable extension directories

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219502#comment-16219502 ] ASF GitHub Bot commented on NIFIREG-43: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (NIFIREG-43) Provide configurable extension directories

2017-10-25 Thread Bryan Bende (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-43. Resolution: Fixed > Provide configurable extension directories >

[GitHub] nifi-registry pull request #27: NIFIREG-43 Provide configurable extension di...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/27 ---

[jira] [Commented] (NIFIREG-43) Provide configurable extension directories

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219497#comment-16219497 ] ASF GitHub Bot commented on NIFIREG-43: --- Github user bbende commented on the issue:

[GitHub] nifi-registry issue #27: NIFIREG-43 Provide configurable extension directori...

2017-10-25 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/27 Thanks, I'll change that string so its not called system anymore, and then I'll merge to master. ---

[jira] [Commented] (MINIFICPP-263) Move libarchive functionality to an extension

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219482#comment-16219482 ] ASF GitHub Bot commented on MINIFICPP-263: -- Github user phrocker commented on the issue:

[GitHub] nifi-minifi-cpp issue #153: MINIFICPP-263: Move merge content to an extensio...

2017-10-25 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/153 @apiri I removed the tests in my last commit. ---

[jira] [Commented] (NIFIREG-43) Provide configurable extension directories

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219345#comment-16219345 ] ASF GitHub Bot commented on NIFIREG-43: --- Github user kevdoran commented on a diff in the pull

[GitHub] nifi-registry pull request #27: NIFIREG-43 Provide configurable extension di...

2017-10-25 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/27#discussion_r146961424 --- Diff: nifi-registry-framework/src/main/java/org/apache/nifi/registry/extension/ExtensionManager.java --- @@ -0,0 +1,213 @@ +/* + *

[jira] [Commented] (NIFI-4524) ListHDFS should allow for glob patterns

2017-10-25 Thread Benjamin Garrett (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219325#comment-16219325 ] Benjamin Garrett commented on NIFI-4524: A solution that works for me is here:

[jira] [Resolved] (NIFIREG-41) Update Travis config to eliminate Chrome disconnection issue

2017-10-25 Thread Bryan Bende (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-41. Resolution: Fixed Fix Version/s: 0.0.1 > Update Travis config to eliminate Chrome

[jira] [Commented] (NIFIREG-41) Update Travis config to eliminate Chrome disconnection issue

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219324#comment-16219324 ] ASF GitHub Bot commented on NIFIREG-41: --- Github user asfgit closed the pull request at:

[GitHub] nifi-registry pull request #26: [NIFIREG-41] increase disconnect tolerance a...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/26 ---

[jira] [Commented] (NIFIREG-41) Update Travis config to eliminate Chrome disconnection issue

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219320#comment-16219320 ] ASF GitHub Bot commented on NIFIREG-41: --- Github user bbende commented on the issue:

[GitHub] nifi-registry issue #26: [NIFIREG-41] increase disconnect tolerance and use ...

2017-10-25 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/26 Looks like this gets the travis build passing so I am a +1, we can just make a habit of running UI tests locally when reviewing, thanks @scottyaslan ---

[jira] [Resolved] (NIFIREG-44) Add integration tests for secure NiFi Registry

2017-10-25 Thread Bryan Bende (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-44. Resolution: Fixed Fix Version/s: 0.0.1 > Add integration tests for secure NiFi Registry >

[GitHub] nifi-registry pull request #28: NIFIREG-44 Refactor integration test framewo...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/28 ---

[jira] [Commented] (NIFIREG-44) Add integration tests for secure NiFi Registry

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219293#comment-16219293 ] ASF GitHub Bot commented on NIFIREG-44: --- Github user bbende commented on the issue:

[GitHub] nifi-registry issue #28: NIFIREG-44 Refactor integration test framework and ...

2017-10-25 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/28 +1 This looks good, nice to have some automation around our TLS/security setup, thanks! I'll merge in soon. ---

[jira] [Commented] (MINIFICPP-39) Create FocusArchive processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219283#comment-16219283 ] ASF GitHub Bot commented on MINIFICPP-39: - Github user calebj commented on the issue:

[GitHub] nifi-minifi-cpp issue #148: MINIFI-244 Un/FocusArchive processors

2017-10-25 Thread calebj
Github user calebj commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/148 @phrocker I already have a travis-ci.org account, but I've granted access to @NifiLocal and synced the account. ---

[jira] [Commented] (MINIFICPP-39) Create FocusArchive processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219255#comment-16219255 ] ASF GitHub Bot commented on MINIFICPP-39: - Github user phrocker commented on the issue:

[GitHub] nifi-minifi-cpp issue #148: MINIFI-244 Un/FocusArchive processors

2017-10-25 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/148 @calebj I emailed Travis their response: "" We've been experiencing some issues with our abuse system creating false positives lately, and I suspect that's what's happening

[jira] [Commented] (MINIFICPP-263) Move libarchive functionality to an extension

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219230#comment-16219230 ] ASF GitHub Bot commented on MINIFICPP-263: -- Github user apiri commented on a diff in the pull

[GitHub] nifi-minifi-cpp pull request #153: MINIFICPP-263: Move merge content to an e...

2017-10-25 Thread apiri
Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/153#discussion_r146940382 --- Diff: thirdparty/yaml-cpp-yaml-cpp-20171024/test/CMakeLists.txt --- @@ -0,0 +1,40 @@ +set(gtest_force_shared_crt ${MSVC_SHARED_RT} CACHE BOOL

[jira] [Commented] (MINIFICPP-263) Move libarchive functionality to an extension

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219179#comment-16219179 ] ASF GitHub Bot commented on MINIFICPP-263: -- Github user apiri commented on the issue:

[GitHub] nifi-minifi-cpp issue #153: MINIFICPP-263: Move merge content to an extensio...

2017-10-25 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/153 reviewing ---

[jira] [Commented] (NIFIREG-44) Add integration tests for secure NiFi Registry

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219049#comment-16219049 ] ASF GitHub Bot commented on NIFIREG-44: --- GitHub user kevdoran opened a pull request:

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219050#comment-16219050 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user calebj commented on a diff in the pull

[GitHub] nifi-registry pull request #28: NIFIREG-44 Refactor integration test framewo...

2017-10-25 Thread kevdoran
GitHub user kevdoran opened a pull request: https://github.com/apache/nifi-registry/pull/28 NIFIREG-44 Refactor integration test framework and add secure tests You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218995#comment-16218995 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146912119 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[GitHub] nifi-minifi-cpp issue #151: MINIFICPP-264: CompressContent Processor

2017-10-25 Thread minifirocks
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/151 @apiri @phrocker fix the test cast, change size and offset signature to uint6_t, it looks like travis passed. please review ---

[jira] [Commented] (MINIFICPP-264) Implement CompressContent Processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218972#comment-16218972 ] ASF GitHub Bot commented on MINIFICPP-264: -- Github user minifirocks commented on the issue:

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218963#comment-16218963 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user calebj commented on a diff in the pull

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread calebj
Github user calebj commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146907747 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class declaration

[jira] [Commented] (NIFI-3453) Provenance Events dont have the "relationship" from where the event came

2017-10-25 Thread Joseph Witt (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218957#comment-16218957 ] Joseph Witt commented on NIFI-3453: --- Ok thanks Scott. The thing is the connection identifier is only

[GitHub] nifi issue #2150: NIFI-3402: Added etag support to InvokeHTTP

2017-10-25 Thread m-hogue
Github user m-hogue commented on the issue: https://github.com/apache/nifi/pull/2150 @MikeThomsen : I've added your suggestions. Please let me know if you'd like any more changes. ---

[jira] [Commented] (NIFI-3402) Add ETag Support to InvokeHTTP

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218934#comment-16218934 ] ASF GitHub Bot commented on NIFI-3402: -- Github user m-hogue commented on the issue:

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218915#comment-16218915 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218904#comment-16218904 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218910#comment-16218910 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218909#comment-16218909 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Updated] (NIFI-2979) PriorityAttributePrioritizer violates Comparator contract

2017-10-25 Thread Mark Payne (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-2979: - Fix Version/s: 1.5.0 Status: Patch Available (was: Open) > PriorityAttributePrioritizer

[jira] [Commented] (NIFI-2979) PriorityAttributePrioritizer violates Comparator contract

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218901#comment-16218901 ] ASF GitHub Bot commented on NIFI-2979: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-2979) PriorityAttributePrioritizer violates Comparator contract

2017-10-25 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218899#comment-16218899 ] ASF subversion and git services commented on NIFI-2979: --- Commit

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146898758 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218913#comment-16218913 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on the issue:

[GitHub] nifi issue #2220: NIFI-2979 PriorityAttributePrioritizer violates Comparator...

2017-10-25 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2220 Agreed, great catch! +1 merged to master. Thanks for the contribution! ---

[GitHub] nifi-minifi-cpp issue #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/152 @calebj Thanks for updating all this, adding the test, and opening the PR. Overall looks good, mostly stylistic/idiom issues due to the style I was using at the time. ---

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146897792 --- Diff: libminifi/test/unit/ExtractTextTest.cpp --- @@ -0,0 +1,101 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146897535 --- Diff: libminifi/test/unit/ExtractTextTest.cpp --- @@ -0,0 +1,101 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146897196 --- Diff: libminifi/test/unit/ExtractTextTest.cpp --- @@ -0,0 +1,101 @@ +/** + * + * Licensed to the Apache Software Foundation

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218902#comment-16218902 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Commented] (NIFI-2979) PriorityAttributePrioritizer violates Comparator contract

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218900#comment-16218900 ] ASF GitHub Bot commented on NIFI-2979: -- Github user markap14 commented on the issue:

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146896653 --- Diff: libminifi/src/processors/ExtractText.cpp --- @@ -0,0 +1,105 @@ +/** + * @file ExtractText.cpp + * ExtractText class

[jira] [Updated] (NIFI-2979) PriorityAttributePrioritizer violates Comparator contract

2017-10-25 Thread Mark Payne (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-2979: - Resolution: Fixed Status: Resolved (was: Patch Available) > PriorityAttributePrioritizer violates

[GitHub] nifi pull request #2220: NIFI-2979 PriorityAttributePrioritizer violates Com...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2220 ---

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146893645 --- Diff: libminifi/src/processors/ExtractText.cpp --- @@ -0,0 +1,105 @@ +/** + * @file ExtractText.cpp + * ExtractText class

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218891#comment-16218891 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218885#comment-16218885 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218884#comment-16218884 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146892527 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146892220 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218881#comment-16218881 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218880#comment-16218880 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146891895 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218873#comment-16218873 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146891271 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[jira] [Commented] (MINIFICPP-52) Implement ExtractText processor

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218877#comment-16218877 ] ASF GitHub Bot commented on MINIFICPP-52: - Github user achristianson commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #152: MINIFICPP-52 basic ExtractText processor

2017-10-25 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146891117 --- Diff: libminifi/include/processors/ExtractText.h --- @@ -0,0 +1,91 @@ +/** + * @file ExtractText.h + * ExtractText class

[jira] [Commented] (MINIFICPP-265) Disable incidental -fsanitize address

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218849#comment-16218849 ] ASF GitHub Bot commented on MINIFICPP-265: -- Github user achristianson commented on the issue:

[GitHub] nifi-minifi-cpp issue #154: MINIFICPP-265 Disabled fsanitize=address for now...

2017-10-25 Thread achristianson
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/154 Fixed. Ready for review/merge now. ---

[jira] [Commented] (MINIFICPP-265) Disable incidental -fsanitize address

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218832#comment-16218832 ] ASF GitHub Bot commented on MINIFICPP-265: -- Github user achristianson commented on the issue:

[jira] [Commented] (MINIFICPP-265) Disable incidental -fsanitize address

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218829#comment-16218829 ] ASF GitHub Bot commented on MINIFICPP-265: -- GitHub user achristianson opened a pull request:

[GitHub] nifi-minifi-cpp pull request #154: MINIFICPP-265 Disabled fsanitize=address ...

2017-10-25 Thread achristianson
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/154 MINIFICPP-265 Disabled fsanitize=address for now, due to overly-verbo… …se log messages. This may be re-enabled in a more controlled fashion later on. Thank you for

[jira] [Created] (MINIFICPP-265) Disable incidental -fsanitize address

2017-10-25 Thread Andrew Christianson (JIRA)
Andrew Christianson created MINIFICPP-265: - Summary: Disable incidental -fsanitize address Key: MINIFICPP-265 URL: https://issues.apache.org/jira/browse/MINIFICPP-265 Project: NiFi MiNiFi C++

  1   2   >