[jira] [Commented] (NIFI-5823) DBCPConnectionPool minIdleConnections property name has a typo

2018-11-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688915#comment-16688915 ] ASF subversion and git services commented on NIFI-5823: --- Commit

[jira] [Resolved] (NIFI-5823) DBCPConnectionPool minIdleConnections property name has a typo

2018-11-15 Thread Koji Kawamura (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Kawamura resolved NIFI-5823. - Resolution: Fixed Fix Version/s: 1.9.0 Thanks for fixing it [~colindean]! I've added you

[jira] [Assigned] (NIFI-5823) DBCPConnectionPool minIdleConnections property name has a typo

2018-11-15 Thread Koji Kawamura (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Kawamura reassigned NIFI-5823: --- Assignee: Colin Dean > DBCPConnectionPool minIdleConnections property name has a typo >

[jira] [Commented] (NIFI-5823) DBCPConnectionPool minIdleConnections property name has a typo

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688917#comment-16688917 ] ASF GitHub Bot commented on NIFI-5823: -- Github user ijokarumawak commented on the issue:

[jira] [Commented] (NIFI-5823) DBCPConnectionPool minIdleConnections property name has a typo

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688916#comment-16688916 ] ASF GitHub Bot commented on NIFI-5823: -- Github user asfgit closed the pull request at:

[GitHub] nifi issue #3172: NIFI-5823: Fixes typo in min idle connections property nam...

2018-11-15 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/3172 LGTM +1, merged to master. Good catch before releasing :) ---

[GitHub] nifi pull request #3172: NIFI-5823: Fixes typo in min idle connections prope...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3172 ---

[jira] [Updated] (MINIFICPP-679) Improve Const correctness in core and ID

2018-11-15 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-679: - Description: Improve Const correctness in core and ID as a way to kick off

[jira] [Resolved] (MINIFICPP-677) HttpSiteToSiteTest failing on older versions of linux

2018-11-15 Thread Aldrin Piri (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri resolved MINIFICPP-677. --- Resolution: Fixed > HttpSiteToSiteTest failing on older versions of linux >

[jira] [Updated] (MINIFICPP-678) Improve const correctness of code base.

2018-11-15 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-678: - Priority: Minor (was: Major) > Improve const correctness of code base. >

[GitHub] nifi-minifi-cpp pull request #441: Minificpp 677 -- resolve travis failures....

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/441 ---

[jira] [Updated] (MINIFICPP-677) HttpSiteToSiteTest failing on older versions of linux

2018-11-15 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-677: - Description: Did some digging, turns out async as a primitive doesn't naturally

[jira] [Updated] (MINIFICPP-677) HttpSiteToSiteTest failing on older versions of linux

2018-11-15 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-677: - Fix Version/s: 0.6.0 > HttpSiteToSiteTest failing on older versions of linux >

[jira] [Updated] (MINIFICPP-677) HttpSiteToSiteTest failing on older versions of linux

2018-11-15 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-677: - Description: Did some digging, turns out async as a primitive doesn't naturally

[jira] [Updated] (MINIFICPP-679) Improve Const correctness in core and ID

2018-11-15 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-679: - Fix Version/s: 0.6.0 > Improve Const correctness in core and ID >

[jira] [Updated] (MINIFICPP-679) Improve Const correctness in core and ID

2018-11-15 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-679: - Description: Improve Const correctness in core and ID as a way to kick off

[jira] [Updated] (MINIFICPP-678) Improve const correctness of code base.

2018-11-15 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-678: - Fix Version/s: 0.6.0 > Improve const correctness of code base. >

[jira] [Updated] (MINIFICPP-678) Improve const correctness of code base.

2018-11-15 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-678: - Description: As per MINIFICPP-676 we should improve our long term const correctness.

[jira] [Updated] (MINIFICPP-678) Improve const correctness of code base.

2018-11-15 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-678: - Description: As per MINIFICPP-676 we should improve our long term const correctness.

[jira] [Updated] (MINIFICPP-678) Improve const correctness of code base.

2018-11-15 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-678: - Description: As per MINIFICPP-676 we should improve our long term const correctness.

[jira] [Commented] (NIFI-5820) NiFi built with Java 1.8 needs to run on Java 11

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688802#comment-16688802 ] ASF GitHub Bot commented on NIFI-5820: -- GitHub user jtstorck opened a pull request:

[GitHub] nifi pull request #3174: [WIP] NIFI-5820 NiFi built on Java 1.8 can run on J...

2018-11-15 Thread jtstorck
GitHub user jtstorck opened a pull request: https://github.com/apache/nifi/pull/3174 [WIP] NIFI-5820 NiFi built on Java 1.8 can run on Java 9/10/11 Updated RunNiFi.java to add libs need to run on Java 11 when it is the detected runtime java version and grant access to the necessary

[jira] [Commented] (MINIFICPP-679) Improve Const correctness in core and ID

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688763#comment-16688763 ] ASF GitHub Bot commented on MINIFICPP-679: -- Github user phrocker commented on a diff in the

[jira] [Assigned] (NIFI-5826) UpdateRecord processor throwing PatternSyntaxException

2018-11-15 Thread Ed Berezitsky (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ed Berezitsky reassigned NIFI-5826: --- Assignee: Ed Berezitsky > UpdateRecord processor throwing PatternSyntaxException >

[jira] [Updated] (NIFI-5826) UpdateRecord processor throwing PatternSyntaxException

2018-11-15 Thread ravi kargam (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ravi kargam updated NIFI-5826: -- Description: with replacement value strategy as Record Path Value, I am trying to replace square

[jira] [Created] (NIFI-5826) UpdateRecord processor throwing PatternSyntaxException

2018-11-15 Thread ravi kargam (JIRA)
ravi kargam created NIFI-5826: - Summary: UpdateRecord processor throwing PatternSyntaxException Key: NIFI-5826 URL: https://issues.apache.org/jira/browse/NIFI-5826 Project: Apache NiFi Issue

[GitHub] nifi-minifi-cpp pull request #442: MINIFICPP-679: Make minor changes for con...

2018-11-15 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/442#discussion_r234040428 --- Diff: libminifi/include/core/Core.h --- @@ -142,52 +141,30 @@ class CoreComponent { * Constructor that sets the name and uuid.

[GitHub] nifi-minifi-cpp issue #441: Minificpp 677 -- resolve travis failures.

2018-11-15 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/441 reviewing ---

[jira] [Updated] (NIFI-5825) ConsumeJMS - Not using Clientid / durable does not works

2018-11-15 Thread Firenz (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Firenz updated NIFI-5825: - Description: I cannot make the ConsumeJMS 1.8.0 processor work as a "durable consumer". I set the client id, but

[jira] [Updated] (NIFI-5825) ConsumeJMS - Not using Clientid / durable does not works

2018-11-15 Thread Firenz (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Firenz updated NIFI-5825: - Attachment: amq_consume.JPG > ConsumeJMS - Not using Clientid / durable does not works >

[jira] [Updated] (NIFI-5825) ConsumeJMS - Not using Clientid / durable does not works

2018-11-15 Thread Firenz (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Firenz updated NIFI-5825: - Attachment: nifi_consumejms.JPG > ConsumeJMS - Not using Clientid / durable does not works >

[jira] [Created] (NIFI-5825) ConsumeJMS - Not using Clientid / durable does not works

2018-11-15 Thread Firenz (JIRA)
Firenz created NIFI-5825: Summary: ConsumeJMS - Not using Clientid / durable does not works Key: NIFI-5825 URL: https://issues.apache.org/jira/browse/NIFI-5825 Project: Apache NiFi Issue Type: Bug

[jira] [Commented] (MINIFICPP-679) Improve Const correctness in core and ID

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688715#comment-16688715 ] ASF GitHub Bot commented on MINIFICPP-679: -- GitHub user phrocker opened a pull request:

[GitHub] nifi-minifi-cpp pull request #442: MINIFICPP-679: Make minor changes for con...

2018-11-15 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/442 MINIFICPP-679: Make minor changes for const correctness improvements Running a windows build now. If I see errors there I'll re-submit, but ran general tests and build across a variety of

[jira] [Updated] (MINIFICPP-679) Improve Const correctness in core and ID

2018-11-15 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-679: - Description: Improve Const correctness in core and ID as a way to kick off

[jira] [Created] (MINIFICPP-679) Improve Const correctness in core and ID

2018-11-15 Thread Mr TheSegfault (JIRA)
Mr TheSegfault created MINIFICPP-679: Summary: Improve Const correctness in core and ID Key: MINIFICPP-679 URL: https://issues.apache.org/jira/browse/MINIFICPP-679 Project: NiFi MiNiFi C++

[jira] [Created] (MINIFICPP-678) Improve const correctness of code base.

2018-11-15 Thread Mr TheSegfault (JIRA)
Mr TheSegfault created MINIFICPP-678: Summary: Improve const correctness of code base. Key: MINIFICPP-678 URL: https://issues.apache.org/jira/browse/MINIFICPP-678 Project: NiFi MiNiFi C++

[jira] [Commented] (MINIFICPP-676) Cleanup and fix serializable interface implementation

2018-11-15 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688693#comment-16688693 ] Mr TheSegfault commented on MINIFICPP-676: -- I also believe that there is a lot of other low,

[jira] [Commented] (MINIFICPP-676) Cleanup and fix serializable interface implementation

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688689#comment-16688689 ] ASF GitHub Bot commented on MINIFICPP-676: -- Github user phrocker commented on the issue:

[GitHub] nifi-minifi-cpp issue #440: MINIFICPP-676 - Cleanup and fix serializable int...

2018-11-15 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/440 hmmm, I should have checked appveyor because I would have saved some time building on windows...but as I suspected we have issues there too. ---

[jira] [Commented] (MINIFICPP-645) Move from new to malloc in CAPI to facilitate eventual change from C++ to C

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688673#comment-16688673 ] ASF GitHub Bot commented on MINIFICPP-645: -- Github user phrocker commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #439: MINIFICPP-645 - Move from new to malloc i...

2018-11-15 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/439#discussion_r234012390 --- Diff: nanofi/src/api/nanofi.cpp --- @@ -205,7 +205,7 @@ flow_file_record* create_ff_object(const char *file, const size_t len, const uin

[jira] [Commented] (MINIFICPP-667) Create Structural definitions for moving away from C++ classes

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688668#comment-16688668 ] ASF GitHub Bot commented on MINIFICPP-667: -- Github user phrocker commented on a diff in the

[jira] [Commented] (MINIFICPP-676) Cleanup and fix serializable interface implementation

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688658#comment-16688658 ] ASF GitHub Bot commented on MINIFICPP-676: -- Github user phrocker commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #436: MINIFICPP-667: Add structural definitions...

2018-11-15 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/436#discussion_r234011794 --- Diff: nanofi/include/core/utlist.h --- @@ -0,0 +1,1073 @@ +/* --- End diff -- As per the title this is to work out a plan so

[GitHub] nifi-minifi-cpp pull request #440: MINIFICPP-676 - Cleanup and fix serializa...

2018-11-15 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/440#discussion_r234011459 --- Diff: extensions/http-curl/client/HTTPCallback.h --- @@ -78,7 +78,7 @@ class HttpStreamingCallback : public ByteInputCallBack { }

[jira] [Commented] (MINIFICPP-676) Cleanup and fix serializable interface implementation

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688666#comment-16688666 ] ASF GitHub Bot commented on MINIFICPP-676: -- Github user phrocker commented on a diff in the

[jira] [Commented] (MINIFICPP-676) Cleanup and fix serializable interface implementation

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688660#comment-16688660 ] ASF GitHub Bot commented on MINIFICPP-676: -- Github user phrocker commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #440: MINIFICPP-676 - Cleanup and fix serializa...

2018-11-15 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/440#discussion_r234009476 --- Diff: libminifi/src/io/FileStream.cpp --- @@ -82,16 +82,16 @@ void FileStream::seek(uint64_t offset) { file_stream_->seekp(offset_);

[jira] [Commented] (MINIFICPP-676) Cleanup and fix serializable interface implementation

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688659#comment-16688659 ] ASF GitHub Bot commented on MINIFICPP-676: -- Github user phrocker commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #440: MINIFICPP-676 - Cleanup and fix serializa...

2018-11-15 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/440#discussion_r234009236 --- Diff: libminifi/include/io/tls/TLSSocket.h --- @@ -173,19 +173,19 @@ class TLSSocket : public Socket { * @param buflen buffer to write

[GitHub] nifi-minifi-cpp pull request #440: MINIFICPP-676 - Cleanup and fix serializa...

2018-11-15 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/440#discussion_r234008835 --- Diff: libminifi/include/io/Serializable.h --- @@ -173,8 +147,22 @@ class Serializable { **/ int readUTF(std::string , DataStream

[jira] [Commented] (MINIFICPP-676) Cleanup and fix serializable interface implementation

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688655#comment-16688655 ] ASF GitHub Bot commented on MINIFICPP-676: -- Github user phrocker commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #440: MINIFICPP-676 - Cleanup and fix serializa...

2018-11-15 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/440#discussion_r234008240 --- Diff: libminifi/include/io/Serializable.h --- @@ -22,11 +22,36 @@ #include #include "EndianCheck.h" #include "DataStream.h"

[jira] [Commented] (MINIFICPP-676) Cleanup and fix serializable interface implementation

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688651#comment-16688651 ] ASF GitHub Bot commented on MINIFICPP-676: -- Github user phrocker commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #440: MINIFICPP-676 - Cleanup and fix serializa...

2018-11-15 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/440#discussion_r234007116 --- Diff: libminifi/include/io/CRCStream.h --- @@ -194,15 +194,12 @@ int CRCStream::readData(uint8_t *buf, int buflen) { } template

[jira] [Commented] (MINIFICPP-676) Cleanup and fix serializable interface implementation

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688637#comment-16688637 ] ASF GitHub Bot commented on MINIFICPP-676: -- Github user phrocker commented on the issue:

[jira] [Commented] (MINIFICPP-676) Cleanup and fix serializable interface implementation

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688649#comment-16688649 ] ASF GitHub Bot commented on MINIFICPP-676: -- Github user phrocker commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #440: MINIFICPP-676 - Cleanup and fix serializa...

2018-11-15 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/440#discussion_r234006270 --- Diff: extensions/http-curl/client/HTTPStream.h --- @@ -100,14 +100,14 @@ class HttpStream : public io::BaseStream { * @param buflen

[jira] [Commented] (MINIFICPP-676) Cleanup and fix serializable interface implementation

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688646#comment-16688646 ] ASF GitHub Bot commented on MINIFICPP-676: -- Github user phrocker commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #440: MINIFICPP-676 - Cleanup and fix serializa...

2018-11-15 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/440#discussion_r234005818 --- Diff: extensions/http-curl/client/HTTPStream.cpp --- @@ -53,16 +53,16 @@ void HttpStream::seek(uint64_t offset) { throw

[GitHub] nifi-minifi-cpp issue #440: MINIFICPP-676 - Cleanup and fix serializable int...

2018-11-15 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/440 @arpadboda I've run some flows and seen a lot of failures as well. ---

[jira] [Commented] (NIFI-5604) Allow GenerateTableFetch to send empty flow files when no rows would be fetched

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688616#comment-16688616 ] ASF GitHub Bot commented on NIFI-5604: -- Github user patricker commented on the issue:

[GitHub] nifi-minifi-cpp pull request #441: Minificpp 677 -- resolve travis failures....

2018-11-15 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/441 Minificpp 677 -- resolve travis failures. Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you

[jira] [Commented] (NIFI-5744) Put exception message to attribute while ExecuteSQL fail

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688620#comment-16688620 ] ASF GitHub Bot commented on NIFI-5744: -- Github user patricker commented on the issue:

[GitHub] nifi issue #3107: NIFI-5744: Put exception message to attribute while Execut...

2018-11-15 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/3107 Hey, @yjhyjhyjh0, can you rebase against master and push a new squashed commit? I think this is ready to merge if we resolve this new code conflict. ---

[jira] [Commented] (NIFI-5604) Allow GenerateTableFetch to send empty flow files when no rows would be fetched

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688617#comment-16688617 ] ASF GitHub Bot commented on NIFI-5604: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-5604) Allow GenerateTableFetch to send empty flow files when no rows would be fetched

2018-11-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688615#comment-16688615 ] ASF subversion and git services commented on NIFI-5604: --- Commit

[GitHub] nifi pull request #3075: NIFI-5604: Added property to allow empty FlowFile w...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3075 ---

[GitHub] nifi issue #3075: NIFI-5604: Added property to allow empty FlowFile when no ...

2018-11-15 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/3075 +1 LGTM. I tested this out with several different scenarios. After our chat on Slack, I squashed this down to a single commit under your name to make things cleaner. ---

[jira] [Created] (MINIFICPP-677) HttpSiteToSiteTest failing on older versions of linux

2018-11-15 Thread Mr TheSegfault (JIRA)
Mr TheSegfault created MINIFICPP-677: Summary: HttpSiteToSiteTest failing on older versions of linux Key: MINIFICPP-677 URL: https://issues.apache.org/jira/browse/MINIFICPP-677 Project: NiFi

[GitHub] nifi issue #3156: NIFI-5780 Add pre and post statements to ExecuteSQL and Ex...

2018-11-15 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/3156 +1 Looks good. Built and tested. I ran into one issue that I might submit a seperate enhancement for (allowing `;` in the SQL string if they are surrounded by `'` or `"`). ---

[jira] [Commented] (NIFI-5780) Add pre and post statements to ExecuteSQL and ExecuteSQLRecord

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688596#comment-16688596 ] ASF GitHub Bot commented on NIFI-5780: -- Github user patricker commented on the issue:

[jira] [Commented] (NIFI-5780) Add pre and post statements to ExecuteSQL and ExecuteSQLRecord

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688593#comment-16688593 ] ASF GitHub Bot commented on NIFI-5780: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-5780) Add pre and post statements to ExecuteSQL and ExecuteSQLRecord

2018-11-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688592#comment-16688592 ] ASF subversion and git services commented on NIFI-5780: --- Commit

[GitHub] nifi pull request #3156: NIFI-5780 Add pre and post statements to ExecuteSQL...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3156 ---

[jira] [Commented] (NIFI-5824) Add test to FlowController to ensure that NIFI-5822 is properly resolved

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688572#comment-16688572 ] ASF GitHub Bot commented on NIFI-5824: -- Github user bbende commented on the issue:

[jira] [Commented] (NIFI-5824) Add test to FlowController to ensure that NIFI-5822 is properly resolved

2018-11-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688574#comment-16688574 ] ASF subversion and git services commented on NIFI-5824: --- Commit

[jira] [Updated] (NIFI-5824) Add test to FlowController to ensure that NIFI-5822 is properly resolved

2018-11-15 Thread Bryan Bende (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-5824: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Add test to FlowController to

[GitHub] nifi issue #3173: NIFI-5824: Added unit test to FlowController to ensure tha...

2018-11-15 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/3173 Code looks good and tests pass, will merge ---

[jira] [Commented] (NIFI-5824) Add test to FlowController to ensure that NIFI-5822 is properly resolved

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688543#comment-16688543 ] ASF GitHub Bot commented on NIFI-5824: -- GitHub user markap14 opened a pull request:

[jira] [Updated] (NIFI-5824) Add test to FlowController to ensure that NIFI-5822 is properly resolved

2018-11-15 Thread Mark Payne (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-5824: - Status: Patch Available (was: Open) > Add test to FlowController to ensure that NIFI-5822 is properly

[GitHub] nifi pull request #3173: NIFI-5824: Added unit test to FlowController to ens...

2018-11-15 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3173 NIFI-5824: Added unit test to FlowController to ensure that the Proce… …ssScheduler that it creates is properly initialized. Also updated the properties file used by TestFlowController to use a

[jira] [Created] (NIFI-5824) Add test to FlowController to ensure that NIFI-5822 is properly resolved

2018-11-15 Thread Mark Payne (JIRA)
Mark Payne created NIFI-5824: Summary: Add test to FlowController to ensure that NIFI-5822 is properly resolved Key: NIFI-5824 URL: https://issues.apache.org/jira/browse/NIFI-5824 Project: Apache NiFi

[jira] [Created] (NIFI-5823) DBCPConnectionPool minIdleConnections property name has a typo

2018-11-15 Thread Colin Dean (JIRA)
Colin Dean created NIFI-5823: Summary: DBCPConnectionPool minIdleConnections property name has a typo Key: NIFI-5823 URL: https://issues.apache.org/jira/browse/NIFI-5823 Project: Apache NiFi

[jira] [Commented] (NIFI-5823) DBCPConnectionPool minIdleConnections property name has a typo

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688504#comment-16688504 ] ASF GitHub Bot commented on NIFI-5823: -- GitHub user colindean opened a pull request:

[GitHub] nifi pull request #3172: NIFI-5823: Fixes typo in min idle connections prope...

2018-11-15 Thread colindean
GitHub user colindean opened a pull request: https://github.com/apache/nifi/pull/3172 NIFI-5823: Fixes typo in min idle connections property name So many people missed it :-( Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[jira] [Commented] (NIFI-5780) Add pre and post statements to ExecuteSQL and ExecuteSQLRecord

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688498#comment-16688498 ] ASF GitHub Bot commented on NIFI-5780: -- Github user patricker commented on the issue:

[GitHub] nifi issue #3156: NIFI-5780 Add pre and post statements to ExecuteSQL and Ex...

2018-11-15 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/3156 Sorry for the delay, been having issues with a bug that just got fixed in NIFI-5822. Will wrap up testing. ---

[jira] [Commented] (NIFI-5822) ControllerServices not available during @OnScheduled

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688479#comment-16688479 ] ASF GitHub Bot commented on NIFI-5822: -- Github user asfgit closed the pull request at:

[GitHub] nifi pull request #3171: NIFI-5822: Ensure that we don't call FlowController...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3171 ---

[jira] [Commented] (NIFI-5822) ControllerServices not available during @OnScheduled

2018-11-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688478#comment-16688478 ] ASF subversion and git services commented on NIFI-5822: --- Commit

[jira] [Updated] (NIFI-5822) ControllerServices not available during @OnScheduled

2018-11-15 Thread Bryan Bende (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-5822: -- Resolution: Fixed Status: Resolved (was: Patch Available) > ControllerServices not available

[jira] [Commented] (NIFI-5822) ControllerServices not available during @OnScheduled

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688477#comment-16688477 ] ASF GitHub Bot commented on NIFI-5822: -- Github user bbende commented on the issue:

[GitHub] nifi issue #3171: NIFI-5822: Ensure that we don't call FlowController.getCon...

2018-11-15 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/3171 +1 code looks good, verified functionality, will merge ---

[jira] [Commented] (NIFI-5822) ControllerServices not available during @OnScheduled

2018-11-15 Thread Mark Payne (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688472#comment-16688472 ] Mark Payne commented on NIFI-5822: -- [~joewitt] fortunately it appears that this only affects master, not

[jira] [Updated] (NIFI-5822) ControllerServices not available during @OnScheduled

2018-11-15 Thread Mark Payne (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-5822: - Affects Version/s: (was: 1.8.0) 1.9.0 > ControllerServices not available

[GitHub] nifi-minifi-cpp pull request #437: MINIFICPP-558: initial provisioning for C...

2018-11-15 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/437#discussion_r233951286 --- Diff: extensions/coap/controllerservice/CoapConnector.cpp --- @@ -0,0 +1,189 @@ +/** + * + * Licensed to the Apache Software

[jira] [Commented] (MINIFICPP-558) Move PayloadSerializer in preparation for Coap

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688452#comment-16688452 ] ASF GitHub Bot commented on MINIFICPP-558: -- Github user phrocker commented on a diff in the

[jira] [Commented] (MINIFICPP-558) Move PayloadSerializer in preparation for Coap

2018-11-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688448#comment-16688448 ] ASF GitHub Bot commented on MINIFICPP-558: -- Github user phrocker commented on a diff in the

  1   2   >