[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs

2021-04-26 Thread GitBox
adamdebreceni commented on a change in pull request #1062: URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620906869 ## File path: extensions/jni/JVMCreator.h ## @@ -40,7 +40,7 @@ namespace jni { class JVMCreator : public minifi::core::CoreComponent { pu

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs

2021-04-26 Thread GitBox
adamdebreceni commented on a change in pull request #1062: URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620907627 ## File path: extensions/script/ExecuteScript.h ## @@ -36,7 +36,7 @@ namespace processors { class ExecuteScript : public core::Processor

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs

2021-04-26 Thread GitBox
adamdebreceni commented on a change in pull request #1062: URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620907335 ## File path: extensions/opencv/CaptureRTSPFrame.h ## @@ -37,7 +37,7 @@ class CaptureRTSPFrame : public core::Processor { public: - e

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs

2021-04-26 Thread GitBox
adamdebreceni commented on a change in pull request #1062: URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620906869 ## File path: extensions/jni/JVMCreator.h ## @@ -40,7 +40,7 @@ namespace jni { class JVMCreator : public minifi::core::CoreComponent { pu

[GitHub] [nifi] thenatog commented on a change in pull request #4988: NIFI-7870 - Fix anonymous access control for advanced UI resources

2021-04-26 Thread GitBox
thenatog commented on a change in pull request #4988: URL: https://github.com/apache/nifi/pull/4988#discussion_r620740659 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/jwt/NiFiBearerTokenResolv

[GitHub] [nifi] thenatog commented on a change in pull request #4988: NIFI-7870 - Fix anonymous access control for advanced UI resources

2021-04-26 Thread GitBox
thenatog commented on a change in pull request #4988: URL: https://github.com/apache/nifi/pull/4988#discussion_r620740330 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/jwt/JwtAuthenticationFilt

[GitHub] [nifi] sushilkm commented on pull request #3750: NIFI-4913 Added preserve.environment to read environment variables while using run.as

2021-04-26 Thread GitBox
sushilkm commented on pull request #3750: URL: https://github.com/apache/nifi/pull/3750#issuecomment-827220306 Sure, I will do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] thenatog commented on pull request #3750: NIFI-4913 Added preserve.environment to read environment variables while using run.as

2021-04-26 Thread GitBox
thenatog commented on pull request #3750: URL: https://github.com/apache/nifi/pull/3750#issuecomment-827213859 I verified that these changes preserve the environment variables from the parent user using the `preserve.environment` variable in bootstrap.conf. This PR would need to be rebased

[jira] [Commented] (NIFI-8478) Unable to build the project (XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature")

2021-04-26 Thread Paul Grey (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332808#comment-17332808 ] Paul Grey commented on NIFI-8478: - Able to reproduce by applying this diff:   {{diff --g

[jira] [Commented] (NIFI-8478) Unable to build the project (XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature")

2021-04-26 Thread Paul Grey (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332800#comment-17332800 ] Paul Grey commented on NIFI-8478: - The test looks like it is looking for an English langua

[jira] [Commented] (NIFI-8478) Unable to build the project (XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature")

2021-04-26 Thread Julien G. (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332795#comment-17332795 ] Julien G. commented on NIFI-8478: - I change my System language globally from fr_FR to en_U

[jira] [Created] (NIFI-8478) Unable to build the project (XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature")

2021-04-26 Thread Julien G. (Jira)
Julien G. created NIFI-8478: --- Summary: Unable to build the project (XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature") Key: NIFI-8478 URL: h

[jira] [Commented] (NIFI-8236) Nifi Cluster Autoscaling on Kubernetes

2021-04-26 Thread DEOM Damien (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332720#comment-17332720 ] DEOM Damien commented on NIFI-8236: --- We've used this one successfully in our company; [

[jira] [Updated] (NIFI-8474) Add new Replacement Strategy for variable substitution in ReplaceText

2021-04-26 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-8474: -- Status: Patch Available (was: Open) > Add new Replacement Strategy for variable substitution in

[GitHub] [nifi] turcsanyip opened a new pull request #5032: NIFI-8474: Added new Replacement Strategy for variable substitution i…

2021-04-26 Thread GitBox
turcsanyip opened a new pull request #5032: URL: https://github.com/apache/nifi/pull/5032 …n ReplaceText. https://issues.apache.org/jira/browse/NIFI-8474 In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ##

[jira] [Created] (NIFI-8477) If a node completely dies, can not delete it from the cluster; AKA Zombie Node

2021-04-26 Thread Chris McKeever (Jira)
Chris McKeever created NIFI-8477: Summary: If a node completely dies, can not delete it from the cluster; AKA Zombie Node Key: NIFI-8477 URL: https://issues.apache.org/jira/browse/NIFI-8477 Project: A

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-26 Thread GitBox
fgerlits closed pull request #1059: URL: https://github.com/apache/nifi-minifi-cpp/pull/1059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [nifi-registry] mtien-apache commented on pull request #319: NIFIREG-395 - Implemented the ability to import and export versioned flows through the UI

2021-04-26 Thread GitBox
mtien-apache commented on pull request #319: URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-827030107 > Hey @mtien-apache - thanks for all your work on this. @andrewmlim 's comments all make sense to me and I would proceed with his recommendations. RE the Delete button

[jira] [Created] (NIFI-8476) ConverRecord JSON to AVRO with logicalType date fails

2021-04-26 Thread Christian Danner (Jira)
INT and logicalType date passed to the processor, I get the result 0. Idk what I am doing wrong, so I attached the Flow I used. Generate Flowfile: Custom Text: {code:java} {"DOCNUM":"12345678","ERSDA":20210426,"LAEDA":18743} {code} avro.s

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1061: MINIFICPP-1549 Add automake packages to MacOS environments

2021-04-26 Thread GitBox
fgerlits closed pull request #1061: URL: https://github.com/apache/nifi-minifi-cpp/pull/1061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[jira] [Updated] (NIFI-8475) EL query parser can produce wrong output when input contains multiple escaped expressions

2021-04-26 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-8475: -- Summary: EL query parser can produce wrong output when input contains multiple escaped expressio

[jira] [Updated] (NIFI-8475) EL query parser can produce wrong output when multiple escaped expressions are used

2021-04-26 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-8475: -- Status: Patch Available (was: In Progress) > EL query parser can produce wrong output when mult

[GitHub] [nifi] turcsanyip opened a new pull request #5031: NIFI-8475: Fixed EL query parser when input contains multiple escaped…

2021-04-26 Thread GitBox
turcsanyip opened a new pull request #5031: URL: https://github.com/apache/nifi/pull/5031 … expressions https://issues.apache.org/jira/browse/NIFI-8475 In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [nifi] tpalfy commented on a change in pull request #4973: NIFI-8373 Add Kerberos support to Accumulo processors

2021-04-26 Thread GitBox
tpalfy commented on a change in pull request #4973: URL: https://github.com/apache/nifi/pull/4973#discussion_r620407997 ## File path: nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java ##

[jira] [Updated] (NIFI-8475) EL query parser can produce wrong output when multiple escaped expressions are used

2021-04-26 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-8475: -- Affects Version/s: 1.13.2 > EL query parser can produce wrong output when multiple escaped expre

[jira] [Updated] (NIFI-8474) Add new Replacement Strategy for variable substitution in ReplaceText

2021-04-26 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-8474: -- Component/s: Extensions > Add new Replacement Strategy for variable substitution in ReplaceText

[jira] [Created] (NIFI-8475) EL query parser can produce wrong output when multiple escaped expressions are used

2021-04-26 Thread Peter Turcsanyi (Jira)
Peter Turcsanyi created NIFI-8475: - Summary: EL query parser can produce wrong output when multiple escaped expressions are used Key: NIFI-8475 URL: https://issues.apache.org/jira/browse/NIFI-8475 Pro

[jira] [Updated] (NIFI-8465) Correct intermittent failures in PasswordBasedEncryptorGroovyTest

2021-04-26 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-8465: --- Affects Version/s: 1.13.2 > Correct intermittent failures in PasswordBasedEncryptorGroovyTest

[jira] [Resolved] (NIFI-8465) Correct intermittent failures in PasswordBasedEncryptorGroovyTest

2021-04-26 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-8465. Fix Version/s: 1.14.0 Resolution: Fixed > Correct intermittent failures in PasswordBa

[GitHub] [nifi] asfgit closed pull request #5029: NIFI-8465; issue with legacy KDF logic

2021-04-26 Thread GitBox
asfgit closed pull request #5029: URL: https://github.com/apache/nifi/pull/5029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[jira] [Commented] (NIFI-8465) Correct intermittent failures in PasswordBasedEncryptorGroovyTest

2021-04-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332579#comment-17332579 ] ASF subversion and git services commented on NIFI-8465: --- Commit 835f

[jira] [Created] (NIFI-8474) Add new Replacement Strategy for variable substitution in ReplaceText

2021-04-26 Thread Peter Turcsanyi (Jira)
Peter Turcsanyi created NIFI-8474: - Summary: Add new Replacement Strategy for variable substitution in ReplaceText Key: NIFI-8474 URL: https://issues.apache.org/jira/browse/NIFI-8474 Project: Apache N

[jira] [Updated] (NIFI-8473) REST API Documentation Missing Parameter Contexts

2021-04-26 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-8473: --- Status: Patch Available (was: In Progress) > REST API Documentation Missing Parameter Context

[GitHub] [nifi] exceptionfactory opened a new pull request #5030: NIFI-8473 Added Parameter Contexts section to REST API documentation

2021-04-26 Thread GitBox
exceptionfactory opened a new pull request #5030: URL: https://github.com/apache/nifi/pull/5030 Description of PR NIFI-8473 Adds Parameter Context section to REST API documentation template so that Parameter Context resources are not grouped under the default Controller section

[jira] [Assigned] (NIFI-6826) Description in REST Api is misaligned

2021-04-26 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-6826: -- Assignee: David Handermann > Description in REST Api is misaligned > --

[jira] [Issue Comment Deleted] (NIFI-6826) Description in REST Api is misaligned

2021-04-26 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-6826: --- Comment: was deleted (was: There appears to be an issue with the {{summary}} class not being h

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1055: MINIFICPP-1454 Reduce duplication of CMake parameters in docker build

2021-04-26 Thread GitBox
lordgamez commented on a change in pull request #1055: URL: https://github.com/apache/nifi-minifi-cpp/pull/1055#discussion_r620443589 ## File path: docker/DockerBuild.sh ## @@ -112,7 +80,13 @@ while [[ $# -gt 0 ]]; do -c|--cmake-param) IFS='=' read -ra ARR <<< "$2"

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1047: MINIFICPP-1503 Build Tensorflow extension in the CI

2021-04-26 Thread GitBox
lordgamez commented on a change in pull request #1047: URL: https://github.com/apache/nifi-minifi-cpp/pull/1047#discussion_r620439674 ## File path: .github/workflows/ci.yml ## @@ -215,8 +215,14 @@ jobs: sudo ln -s /usr/lib/x86_64-linux-gnu/odbc/libsqlite3odbc.so /us

[jira] [Assigned] (NIFI-8445) Implement HashicorpVaultCommunicationService

2021-04-26 Thread Joseph Gresock (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Gresock reassigned NIFI-8445: Assignee: Joseph Gresock > Implement HashicorpVaultCommunicationService > -

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1055: MINIFICPP-1454 Reduce duplication of CMake parameters in docker build

2021-04-26 Thread GitBox
fgerlits commented on a change in pull request #1055: URL: https://github.com/apache/nifi-minifi-cpp/pull/1055#discussion_r620428878 ## File path: docker/DockerBuild.sh ## @@ -112,7 +80,13 @@ while [[ $# -gt 0 ]]; do -c|--cmake-param) IFS='=' read -ra ARR <<< "$2"

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5028: NIFI-8325: Complete SNMP refactor: SNMP GET and SET processors rework, unit tests added

2021-04-26 Thread GitBox
exceptionfactory commented on a change in pull request #5028: URL: https://github.com/apache/nifi/pull/5028#discussion_r620420099 ## File path: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/processor/util/StandardValidators.java ## @@ -151,7 +152,24 @@ public Validatio

[jira] [Assigned] (MINIFICPP-1541) Move ODBC dependent SQL testing to the docker integration tests

2021-04-26 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1541: Assignee: Gabor Gyimesi > Move ODBC dependent SQL testing to the docker integr

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1047: MINIFICPP-1503 Build Tensorflow extension in the CI

2021-04-26 Thread GitBox
fgerlits commented on a change in pull request #1047: URL: https://github.com/apache/nifi-minifi-cpp/pull/1047#discussion_r620412480 ## File path: .github/workflows/ci.yml ## @@ -215,8 +215,14 @@ jobs: sudo ln -s /usr/lib/x86_64-linux-gnu/odbc/libsqlite3odbc.so /usr

[jira] [Assigned] (MINIFICPP-1494) InvokeHTTP should behave in the same way as NiFi

2021-04-26 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1494: Assignee: Gabor Gyimesi > InvokeHTTP should behave in the same way as NiFi > -

[GitHub] [nifi] exceptionfactory commented on pull request #4986: NIFI-8403: Generating Self-signed cert on startup when applicable

2021-04-26 Thread GitBox
exceptionfactory commented on pull request #4986: URL: https://github.com/apache/nifi/pull/4986#issuecomment-826933134 Thanks for making updating the logic to check password properties @gresockj, those changes look good. Do you have any additional feedback @bbende? -- This is an automat

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs

2021-04-26 Thread GitBox
lordgamez opened a new pull request #1062: URL: https://github.com/apache/nifi-minifi-cpp/pull/1062 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[jira] [Commented] (NIFI-8465) Correct intermittent failures in PasswordBasedEncryptorGroovyTest

2021-04-26 Thread Paul Grey (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332486#comment-17332486 ] Paul Grey commented on NIFI-8465: - Trying to bound the work here. Since we plan to revisi

[GitHub] [nifi] greyp9 opened a new pull request #5029: NIFI-8465; issue with legacy KDF logic

2021-04-26 Thread GitBox
greyp9 opened a new pull request #5029: URL: https://github.com/apache/nifi/pull/5029 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR fallback logic to prevent random test case failure

[GitHub] [nifi-minifi-cpp] fgerlits commented on pull request #1017: MINIFICPP-1515 - Add integration tests testing different flowfile sizes in a simple flow

2021-04-26 Thread GitBox
fgerlits commented on pull request #1017: URL: https://github.com/apache/nifi-minifi-cpp/pull/1017#issuecomment-826910263 > The check still shows that we do not handle the file size 2.1 GiB properly. Merge only once it is fixed. Right -- #1028 needs to be merged first, and probably i

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1061: MINIFICPP-1549 Add automake packages to MacOS environments

2021-04-26 Thread GitBox
lordgamez opened a new pull request #1061: URL: https://github.com/apache/nifi-minifi-cpp/pull/1061 After a [Github Actions image update](https://github.com/actions/virtual-environments/commit/1cfd4804166402f910a59d74bfc29263a669d434#diff-dec3b956a881e60d26ef4404bbc288a4c7fcbb07dd0bfa0d26cf

[jira] [Created] (MINIFICPP-1549) MacOS builds fail with missing automake package

2021-04-26 Thread Gabor Gyimesi (Jira)
Gabor Gyimesi created MINIFICPP-1549: Summary: MacOS builds fail with missing automake package Key: MINIFICPP-1549 URL: https://issues.apache.org/jira/browse/MINIFICPP-1549 Project: Apache NiFi MiN

[jira] [Assigned] (MINIFICPP-1549) MacOS builds fail with missing automake package

2021-04-26 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1549: Assignee: Gabor Gyimesi > MacOS builds fail with missing automake package > --

[jira] [Created] (NIFI-8473) REST API Documentation Missing Parameter Contexts

2021-04-26 Thread David Handermann (Jira)
David Handermann created NIFI-8473: -- Summary: REST API Documentation Missing Parameter Contexts Key: NIFI-8473 URL: https://issues.apache.org/jira/browse/NIFI-8473 Project: Apache NiFi Issue

[jira] [Commented] (NIFI-6826) Description in REST Api is misaligned

2021-04-26 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332451#comment-17332451 ] David Handermann commented on NIFI-6826: There appears to be an issue with the {{s

[GitHub] [nifi] thenatog commented on pull request #3750: NIFI-4913 Added preserve.environment to read environment variables while using run.as

2021-04-26 Thread GitBox
thenatog commented on pull request #3750: URL: https://github.com/apache/nifi/pull/3750#issuecomment-826873555 I'll check it out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [nifi] joewitt commented on pull request #3750: NIFI-4913 Added preserve.environment to read environment variables while using run.as

2021-04-26 Thread GitBox
joewitt commented on pull request #3750: URL: https://github.com/apache/nifi/pull/3750#issuecomment-826872619 removing stale label. we really should review this one. looks helpful and easily tested -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (NIFI-8236) Nifi Cluster Autoscaling on Kubernetes

2021-04-26 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332437#comment-17332437 ] Joe Witt commented on NIFI-8236: [~DamD] Obviously you'll need to speak with the vendor fo

[GitHub] [nifi] cosh commented on pull request #4884: NIFI-8294 - Functional processor and service for sending flowfile content to Azur…

2021-04-26 Thread GitBox
cosh commented on pull request #4884: URL: https://github.com/apache/nifi/pull/4884#issuecomment-826859031 Hi @sjyang18 , may I ask what's missing for this PR to be merged? the failing Ubuntu test failed because of another component which is not related to this functionality. Please

[GitHub] [nifi-registry] moranr commented on pull request #319: NIFIREG-395 - Implemented the ability to import and export versioned flows through the UI

2021-04-26 Thread GitBox
moranr commented on pull request #319: URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-826853222 Hey @mtien-apache - thanks for all your work on this. @andrewmlim 's comments all make sense to me and I would proceed with his recommendations. RE the Delete button color, y

[GitHub] [nifi] Lehel44 closed pull request #4898: NIFI-8325: Improve SNMP processors

2021-04-26 Thread GitBox
Lehel44 closed pull request #4898: URL: https://github.com/apache/nifi/pull/4898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please co

[GitHub] [nifi] Lehel44 commented on pull request #4898: NIFI-8325: Improve SNMP processors

2021-04-26 Thread GitBox
Lehel44 commented on pull request #4898: URL: https://github.com/apache/nifi/pull/4898#issuecomment-826849329 Hey, Thank you for the comments again, I opened a new PR with better version of it: https://github.com/apache/nifi/pull/5028 -- This is an automated message from the Apache

[GitHub] [nifi] Lehel44 opened a new pull request #5028: NIFI-8325: Complete SNMP refactor: SNMP GET and SET processors rework, unit tests added

2021-04-26 Thread GitBox
Lehel44 opened a new pull request #5028: URL: https://github.com/apache/nifi/pull/5028 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR - complete SNMP refactor - restructured with fa

[jira] [Created] (MINIFICPP-1548) Investigate merging the three rocksdb repos

2021-04-26 Thread Adam Debreceni (Jira)
Adam Debreceni created MINIFICPP-1548: - Summary: Investigate merging the three rocksdb repos Key: MINIFICPP-1548 URL: https://issues.apache.org/jira/browse/MINIFICPP-1548 Project: Apache NiFi MiNiF

[jira] [Updated] (MINIFICPP-1548) Investigate merging the three rocksdb databases

2021-04-26 Thread Adam Debreceni (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Debreceni updated MINIFICPP-1548: -- Summary: Investigate merging the three rocksdb databases (was: Investigate merging

[GitHub] [nifi] gresockj commented on a change in pull request #4988: NIFI-7870 - Fix anonymous access control for advanced UI resources

2021-04-26 Thread GitBox
gresockj commented on a change in pull request #4988: URL: https://github.com/apache/nifi/pull/4988#discussion_r620241802 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/NiFiCsrfTokenRepository.java ##

[jira] [Commented] (NIFI-8236) Nifi Cluster Autoscaling on Kubernetes

2021-04-26 Thread DEOM Damien (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332109#comment-17332109 ] DEOM Damien commented on NIFI-8236: --- Any news ? I've seen this : [https://www.cloudera.c

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-26 Thread GitBox
lordgamez commented on a change in pull request #1059: URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620222683 ## File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp ## @@ -307,6 +315,6 @@ TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]"

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-26 Thread GitBox
lordgamez commented on a change in pull request #1059: URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620222408 ## File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp ## @@ -270,19 +276,21 @@ TEST_CASE("HTTPTestsWithResourceClaimPOST", "[httpte

[GitHub] [nifi-minifi-cpp] aminadinari19 commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-26 Thread GitBox
aminadinari19 commented on a change in pull request #1059: URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620161673 ## File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp ## @@ -270,19 +276,21 @@ TEST_CASE("HTTPTestsWithResourceClaimPOST", "[ht

[GitHub] [nifi-minifi-cpp] aminadinari19 commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-26 Thread GitBox
aminadinari19 commented on a change in pull request #1059: URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620159779 ## File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp ## @@ -307,6 +315,6 @@ TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptes

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

2021-04-26 Thread GitBox
fgerlits commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r620140801 ## File path: extensions/sftp/processors/SFTPProcessorBase.cpp ## @@ -180,7 +180,7 @@ void SFTPProcessorBase::parseCommonPropertiesOnSchedule(co

[GitHub] [nifi-minifi-cpp] aminadinari19 commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-26 Thread GitBox
aminadinari19 commented on a change in pull request #1059: URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620151494 ## File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp ## @@ -270,19 +276,21 @@ TEST_CASE("HTTPTestsWithResourceClaimPOST", "[ht

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-26 Thread GitBox
szaszm commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r620142973 ## File path: libminifi/include/core/Annotation.h ## @@ -0,0 +1,79 @@ +/** + + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Assigned] (MINIFICPP-1502) Update processors that take their name/id constructor arguments as values

2021-04-26 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1502: Assignee: Gabor Gyimesi > Update processors that take their name/id constructo

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

2021-04-26 Thread GitBox
lordgamez commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r620103666 ## File path: libminifi/include/utils/ValueCaster.h ## @@ -0,0 +1,48 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

2021-04-26 Thread GitBox
martinzink commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r620100424 ## File path: libminifi/include/utils/ValueCaster.h ## @@ -0,0 +1,48 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

2021-04-26 Thread GitBox
martinzink commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r620090718 ## File path: libminifi/include/utils/ProcessCPUUsageTracker.h ## @@ -0,0 +1,96 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-26 Thread GitBox
adamdebreceni commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r620066444 ## File path: libminifi/include/core/Annotation.h ## @@ -0,0 +1,79 @@ +/** + + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-26 Thread GitBox
adam-markovics commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r620064134 ## File path: libminifi/include/core/Processor.h ## @@ -251,6 +252,10 @@ class Processor : public Connectable, public ConfigurableComponen

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-26 Thread GitBox
adamdebreceni commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r620063174 ## File path: libminifi/include/core/Annotation.h ## @@ -0,0 +1,79 @@ +/** + + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements

2021-04-26 Thread GitBox
adamdebreceni commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r620060353 ## File path: libminifi/include/core/Processor.h ## @@ -251,6 +252,10 @@ class Processor : public Connectable, public ConfigurableComponent

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1053: MINIFICPP-1373 - Add integration tests for ConsumeKafka and test cleanup issues

2021-04-26 Thread GitBox
lordgamez commented on pull request #1053: URL: https://github.com/apache/nifi-minifi-cpp/pull/1053#issuecomment-826603773 Do these tests cover all the test cases of `ConsumeKafkaTests.cpp`? If so can we remove that test suite? It does not run in the CI currently. -- This is an automated

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on pull request #1060: MINIFI-CPP-1203 - Add linter recommended missing whitespaces

2021-04-26 Thread GitBox
hunyadi-dev commented on pull request #1060: URL: https://github.com/apache/nifi-minifi-cpp/pull/1060#issuecomment-826602868 > I'm not a fan of space before the colon in range-based for loops. > Why does the linter check pass without these changes? Are these rules disabled? 1. I a

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #1060: MINIFI-CPP-1203 - Add linter recommended missing whitespaces

2021-04-26 Thread GitBox
hunyadi-dev commented on a change in pull request #1060: URL: https://github.com/apache/nifi-minifi-cpp/pull/1060#discussion_r620056414 ## File path: extensions/windows-event-log/wel/WindowsEventLog.h ## @@ -87,36 +87,36 @@ class WindowsEventLogMetadata { static std::string

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-26 Thread GitBox
lordgamez commented on a change in pull request #1059: URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620055279 ## File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp ## @@ -270,19 +276,21 @@ TEST_CASE("HTTPTestsWithResourceClaimPOST", "[httpte

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #1060: MINIFI-CPP-1203 - Add linter recommended missing whitespaces

2021-04-26 Thread GitBox
hunyadi-dev commented on a change in pull request #1060: URL: https://github.com/apache/nifi-minifi-cpp/pull/1060#discussion_r620054454 ## File path: extensions/sftp/tests/PutSFTPTests.cpp ## @@ -809,7 +809,7 @@ TEST_CASE_METHOD(PutSFTPTestsFixture, "PutSFTP batching does not

[GitHub] [nifi-minifi-cpp] aminadinari19 commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-26 Thread GitBox
aminadinari19 commented on a change in pull request #1059: URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620052349 ## File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp ## @@ -270,19 +276,21 @@ TEST_CASE("HTTPTestsWithResourceClaimPOST", "[ht

[GitHub] [nifi] github-actions[bot] commented on pull request #3511: NIFI-6175 Spark Livy - Improving Livy

2021-04-26 Thread GitBox
github-actions[bot] commented on pull request #3511: URL: https://github.com/apache/nifi/pull/3511#issuecomment-826171173 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be clos

[GitHub] [nifi] github-actions[bot] commented on pull request #3905: adding openId support in configuration file

2021-04-26 Thread GitBox
github-actions[bot] commented on pull request #3905: URL: https://github.com/apache/nifi/pull/3905#issuecomment-826171016 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be clos

[GitHub] [nifi] github-actions[bot] commented on pull request #3896: NIFI-6881 - Add JDBC AtomicDistributedMapCacheClient

2021-04-26 Thread GitBox
github-actions[bot] commented on pull request #3896: URL: https://github.com/apache/nifi/pull/3896#issuecomment-826171024 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be clos

[GitHub] [nifi] github-actions[bot] commented on pull request #4036: NIFI-7099: AbstractDatabaseLookupService: Add new option to use a Select Statement alternatively to table name and key column

2021-04-26 Thread GitBox
github-actions[bot] commented on pull request #4036: URL: https://github.com/apache/nifi/pull/4036#issuecomment-826170949 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be clos

[GitHub] [nifi] tolaini commented on pull request #5026: NIFI-8470

2021-04-26 Thread GitBox
tolaini commented on pull request #5026: URL: https://github.com/apache/nifi/pull/5026#issuecomment-826119347 > Hey @tolaini the change looks good to me, but the base branch needs to be `main`, not `support/nifi-1.13`. Can you change that? If we do end up doing another 1.13.x release, it c

[GitHub] [nifi] github-actions[bot] commented on pull request #3616: NIFI-6501: Add config to limit buffer queue size in CaptureChangeMySQL

2021-04-26 Thread GitBox
github-actions[bot] commented on pull request #3616: URL: https://github.com/apache/nifi/pull/3616#issuecomment-826171131 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be clos

[GitHub] [nifi] github-actions[bot] commented on pull request #4385: NIFI-7600 - Defining JMS attribute types breaks due to invalid charac…

2021-04-26 Thread GitBox
github-actions[bot] commented on pull request #4385: URL: https://github.com/apache/nifi/pull/4385#issuecomment-826170743 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be clos

[GitHub] [nifi] github-actions[bot] commented on pull request #4175: NIFI-7307 - Add User Metadata support to the Azure Blob Processors + LookupService

2021-04-26 Thread GitBox
github-actions[bot] commented on pull request #4175: URL: https://github.com/apache/nifi/pull/4175#issuecomment-826170860 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be clos

[GitHub] [nifi] github-actions[bot] commented on pull request #4355: QueryElasticsearchHttp to support nested JSON objects

2021-04-26 Thread GitBox
github-actions[bot] commented on pull request #4355: URL: https://github.com/apache/nifi/pull/4355#issuecomment-826170752 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be clos

[GitHub] [nifi] github-actions[bot] commented on pull request #3921: add or replace properties in nifi.properties by environment variable

2021-04-26 Thread GitBox
github-actions[bot] commented on pull request #3921: URL: https://github.com/apache/nifi/pull/3921#issuecomment-826171007 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be clos

[GitHub] [nifi] github-actions[bot] commented on pull request #4059: NIFI-7098 - Added count file count information in ListSFTP processor

2021-04-26 Thread GitBox
github-actions[bot] commented on pull request #4059: URL: https://github.com/apache/nifi/pull/4059#issuecomment-826170932 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be clos

[GitHub] [nifi] github-actions[bot] commented on pull request #3388: NIFI-1693

2021-04-26 Thread GitBox
github-actions[bot] commented on pull request #3388: URL: https://github.com/apache/nifi/pull/3388#issuecomment-826171193 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be clos

[GitHub] [nifi] github-actions[bot] commented on pull request #4310: NIFI-7498 Adding unique prefix to every swagger operationId

2021-04-26 Thread GitBox
github-actions[bot] commented on pull request #4310: URL: https://github.com/apache/nifi/pull/4310#issuecomment-826170794 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be clos

  1   2   >