Github user benqiu2016 closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r127535449
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -84,19 +107,41 @@ void RemoteProcessorGroupPort::initialize() {
std::set
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r127531375
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +194,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126458724
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +194,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126457339
--- Diff: libminifi/include/utils/HTTPUtils.h ---
@@ -88,6 +90,40 @@ struct HTTPRequestResponse {
};
+static void
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126455887
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -84,19 +107,41 @@ void RemoteProcessorGroupPort::initialize() {
std::set
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126455434
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -20,6 +20,9 @@
#include "../include/RemoteProcessorGroupPort.h"
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126240211
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -20,6 +20,9 @@
#include "../include/RemoteProcessorGroupPort.h"
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126239506
--- Diff: libminifi/include/utils/HTTPUtils.h ---
@@ -88,6 +90,40 @@ struct HTTPRequestResponse {
};
+static void
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126219277
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -20,6 +20,9 @@
#include "../include/RemoteProcessorGroupPort.h"
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126214904
--- Diff: libminifi/include/utils/HTTPUtils.h ---
@@ -88,6 +90,40 @@ struct HTTPRequestResponse {
};
+static void
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126211327
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +194,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126210180
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +194,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126209183
--- Diff: libminifi/include/Site2SiteClientProtocol.h ---
@@ -387,6 +387,15 @@ class DataPacket {
};
+/**
+ * Site2Site
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126208386
--- Diff: libminifi/include/utils/HTTPUtils.h ---
@@ -88,6 +90,40 @@ struct HTTPRequestResponse {
};
+static void
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126160245
--- Diff: libminifi/include/RemoteProcessorGroupPort.h ---
@@ -84,6 +93,17 @@ class RemoteProcessorGroupPort : public core::Processor {
void
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126172307
--- Diff: libminifi/include/Site2SiteClientProtocol.h ---
@@ -387,6 +387,15 @@ class DataPacket {
};
+/**
+ * Site2Site
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126173718
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +194,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126168614
--- Diff: libminifi/include/utils/HTTPUtils.h ---
@@ -88,6 +90,40 @@ struct HTTPRequestResponse {
};
+static void
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126181684
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +194,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123769093
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -54,19 +57,29 @@ bool create = true) {
std::unique_ptr nextProtocol = nullptr;
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123768801
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -54,19 +57,29 @@ bool create = true) {
std::unique_ptr nextProtocol = nullptr;
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123764442
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -314,10 +314,8 @@ void
YamlConfiguration::parseProvenanceReportingYaml(YAML::Node
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123748661
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -314,10 +314,8 @@ void
YamlConfiguration::parseProvenanceReportingYaml(YAML::Node
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123530192
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -314,10 +314,8 @@ void
YamlConfiguration::parseProvenanceReportingYaml(YAML::Node
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123529970
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -344,7 +427,8 @@ int
Site2SiteClientProtocol::readRequestType(RequestType ) {
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123529541
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -319,6 +344,64 @@ void Site2SiteClientProtocol::tearDown() {
_peerState = IDLE;
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123529125
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +147,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123528501
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -278,26 +301,28 @@ bool Site2SiteClientProtocol::handShake() {
}
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123528403
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -38,7 +39,8 @@ namespace minifi {
bool Site2SiteClientProtocol::establish()
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123527545
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -76,27 +89,20 @@ void
RemoteProcessorGroupPort::returnProtocol(std::unique_ptr
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123527427
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -54,19 +57,29 @@ bool create = true) {
std::unique_ptr nextProtocol = nullptr;
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123526843
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -54,19 +57,29 @@ bool create = true) {
std::unique_ptr nextProtocol = nullptr;
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123501252
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -344,7 +427,8 @@ int
Site2SiteClientProtocol::readRequestType(RequestType ) {
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123503614
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -54,19 +57,29 @@ bool create = true) {
std::unique_ptr nextProtocol = nullptr;
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123504131
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -76,27 +89,20 @@ void
RemoteProcessorGroupPort::returnProtocol(std::unique_ptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123503771
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -54,19 +57,29 @@ bool create = true) {
std::unique_ptr nextProtocol = nullptr;
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123500940
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -278,26 +301,28 @@ bool Site2SiteClientProtocol::handShake() {
}
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123501069
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -319,6 +344,64 @@ void Site2SiteClientProtocol::tearDown() {
_peerState = IDLE;
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123502816
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -314,10 +314,8 @@ void
YamlConfiguration::parseProvenanceReportingYaml(YAML::Node
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123500630
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -38,7 +39,8 @@ namespace minifi {
bool Site2SiteClientProtocol::establish() {
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r123500565
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +147,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114
site2site port negotiation
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure
43 matches
Mail list logo
