[GitHub] [nifi] jfrazee opened a new pull request #4479: NIFI-7599 Make noLocal flag on the JMS consumer false

2020-08-13 Thread GitBox
jfrazee opened a new pull request #4479: URL: https://github.com/apache/nifi/pull/4479 Description of PR This changes the noLocal flag on the JMS consumer to false. It was previously being set to true for all Topic destinations which is unnecessary and breaks with some

[GitHub] [nifi] jfrazee commented on pull request #4460: NIFI-7717 Updated main NiFi images to JRE 11.

2020-08-13 Thread GitBox
jfrazee commented on pull request #4460: URL: https://github.com/apache/nifi/pull/4460#issuecomment-673723245 @joewitt @MikeThomsen Can I suggest that this be a build arg in the Dockerfile (they can be used in a FROM) and a property in the pom? That'd make the build pretty flexible and

[GitHub] [nifi] joewitt commented on pull request #4321: NIFI-7506 - CompressContent Add Snappy-Hadoop

2020-08-13 Thread GitBox
joewitt commented on pull request #4321: URL: https://github.com/apache/nifi/pull/4321#issuecomment-673707607 this needs to be rebased against the lastest 'main'. Master is no longer being used. and please use a far smaller test file. We have too many of these 1MB test files and

[GitHub] [nifi-registry] bbende commented on a change in pull request #296: NIFIREG-313 - Add OpenId Connect support for authenticating users

2020-08-13 Thread GitBox
bbende commented on a change in pull request #296: URL: https://github.com/apache/nifi-registry/pull/296#discussion_r470210095 ## File path: nifi-registry-core/nifi-registry-web-ui/src/main/java/org/apache/nifi/registry/web/filter/LogoutFilter.java ## @@ -0,0 +1,56 @@ +/* + *

[GitHub] [nifi] mattyb149 commented on a change in pull request #3735: NIFI-6670: Add TextLineReader to read lines of text as single-field records

2020-08-13 Thread GitBox
mattyb149 commented on a change in pull request #3735: URL: https://github.com/apache/nifi/pull/3735#discussion_r470234851 ## File path:

[jira] [Commented] (NIFI-7692) Conduct Apache NiFi 1.12.0 Release

2020-08-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177310#comment-17177310 ] ASF subversion and git services commented on NIFI-7692: --- Commit

[jira] [Commented] (NIFI-7692) Conduct Apache NiFi 1.12.0 Release

2020-08-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177309#comment-17177309 ] ASF subversion and git services commented on NIFI-7692: --- Commit

[jira] [Updated] (MINIFICPP-1333) PublishKafka should penalize flowfiles sent to failure

2020-08-13 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-1333: -- Labels: selected-for-development (was: ) > PublishKafka should penalize flowfiles sent to

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #872: MINIFICPP-1333 - PublishKafka should penalize flowfiles sent to failure

2020-08-13 Thread GitBox
arpadboda commented on a change in pull request #872: URL: https://github.com/apache/nifi-minifi-cpp/pull/872#discussion_r470218080 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -701,6 +701,7 @@ void PublishKafka::onTrigger(const std::shared_ptr if

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #872: MINIFICPP-1333 - PublishKafka should penalize flowfiles sent to failure

2020-08-13 Thread GitBox
szaszm commented on a change in pull request #872: URL: https://github.com/apache/nifi-minifi-cpp/pull/872#discussion_r470211664 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -701,6 +701,7 @@ void PublishKafka::onTrigger(const std::shared_ptr if (success) {

[jira] [Commented] (NIFIREG-313) Add OpenId Connect support for authenticating users

2020-08-13 Thread Nathan Gough (Jira)
[ https://issues.apache.org/jira/browse/NIFIREG-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177303#comment-17177303 ] Nathan Gough commented on NIFIREG-313: -- Hi Christian,  I've added a PR for this ticket which

[GitHub] [nifi-minifi-cpp] arpadboda opened a new pull request #872: MINIFICPP-1333 - PublishKafka should penalize flowfiles sent to failure

2020-08-13 Thread GitBox
arpadboda opened a new pull request #872: URL: https://github.com/apache/nifi-minifi-cpp/pull/872 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[jira] [Updated] (MINIFICPP-1333) PublishKafka should penalize flowfiles sent to failure

2020-08-13 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-1333: -- Description: Flowfiles sent to PublishKafka and looped back are not penalised, so they

[jira] [Created] (MINIFICPP-1333) PublishKafka should penalize flowfiles sent to failure

2020-08-13 Thread Arpad Boda (Jira)
Arpad Boda created MINIFICPP-1333: - Summary: PublishKafka should penalize flowfiles sent to failure Key: MINIFICPP-1333 URL: https://issues.apache.org/jira/browse/MINIFICPP-1333 Project: Apache NiFi

[jira] [Updated] (MINIFICPP-1333) PublishKafka should penalize flowfiles sent to failure

2020-08-13 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-1333: -- Description: Flowfiles sent to PublishKafka and looped back are not penalised, so they

[GitHub] [nifi-registry] thenatog edited a comment on pull request #296: NIFIREG-313 - Add OpenId Connect support for authenticating users

2020-08-13 Thread GitBox
thenatog edited a comment on pull request #296: URL: https://github.com/apache/nifi-registry/pull/296#issuecomment-673631378 This change matches, as close as possible, the OIDC authentication code in NiFi. When opening the NiFi Registry UI with OIDC configured, there should be a Login

[GitHub] [nifi-registry] thenatog commented on pull request #296: NIFIREG-313 - Add OpenId Connect support for authenticating users

2020-08-13 Thread GitBox
thenatog commented on pull request #296: URL: https://github.com/apache/nifi-registry/pull/296#issuecomment-673631378 This change matches, as close as possible, the OIDC authentication code in NiFi. When opening the NiFi Registry UI with OIDC configured, there should be a Login button in

[GitHub] [nifi-registry] thenatog opened a new pull request #296: NIFIREG-313 - Add OpenId Connect support for authenticating users

2020-08-13 Thread GitBox
thenatog opened a new pull request #296: URL: https://github.com/apache/nifi-registry/pull/296 NIFIREG-313 - Added Login and Logout filters. Added unit tests. NIFIREG-313 - Added changes from NiFi PR #4344. Fixing tests. NIFIREG-313 - alopresto provided a patch to fix failing

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
hunyadi-dev commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470123463 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +352,50 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
hunyadi-dev commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470123463 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +352,50 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
hunyadi-dev commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470123463 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +352,50 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
hunyadi-dev commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470048623 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +352,50 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
hunyadi-dev commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470048623 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +352,50 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
hunyadi-dev commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470048623 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +352,50 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
lordgamez commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470070629 ## File path: extensions/libarchive/MergeContent.h ## @@ -259,20 +259,56 @@ class ZipMerge: public ArchiveMerge, public MergeBin { } };

[jira] [Created] (NIFI-7738) Provenance Search Events - add feature to allow inverse query

2020-08-13 Thread Nissim Shiman (Jira)
Nissim Shiman created NIFI-7738: --- Summary: Provenance Search Events - add feature to allow inverse query Key: NIFI-7738 URL: https://issues.apache.org/jira/browse/NIFI-7738 Project: Apache NiFi

[jira] [Updated] (NIFI-7738) Provenance Search Events - add feature to allow inverse query

2020-08-13 Thread Nissim Shiman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nissim Shiman updated NIFI-7738: Attachment: provenanceSearchEvents_InverseSearch.png > Provenance Search Events - add feature to

[GitHub] [nifi] alopresto commented on pull request #4476: NIFI-7673 Standalone diagnosis mode verifies independent node

2020-08-13 Thread GitBox
alopresto commented on pull request #4476: URL: https://github.com/apache/nifi/pull/4476#issuecomment-673560087 Reviewing... This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
hunyadi-dev commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470052761 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +352,50 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[jira] [Commented] (NIFI-7692) Conduct Apache NiFi 1.12.0 Release

2020-08-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177111#comment-17177111 ] ASF subversion and git services commented on NIFI-7692: --- Commit

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
hunyadi-dev commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470048623 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +352,50 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
hunyadi-dev commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470048623 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +352,50 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
hunyadi-dev commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470048623 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +352,50 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #864: MINIFICPP-1319 - Stream refactor

2020-08-13 Thread GitBox
adamdebreceni commented on a change in pull request #864: URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r470035889 ## File path: libminifi/include/io/Stream.h ## @@ -0,0 +1,52 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi] Woutifier opened a new pull request #4478: NIFI-7737: add string[] array option to putcassandrarecord

2020-08-13 Thread GitBox
Woutifier opened a new pull request #4478: URL: https://github.com/apache/nifi/pull/4478 Description of PR _adds string[] array option to putcassandrarecord; implements NIFI-7737._ In order to streamline the review of the contribution we ask you to ensure the following

[jira] [Created] (NIFI-7737) Add support for String[] to PutCassandraRecord

2020-08-13 Thread Wouter de Vries (Jira)
Wouter de Vries created NIFI-7737: - Summary: Add support for String[] to PutCassandraRecord Key: NIFI-7737 URL: https://issues.apache.org/jira/browse/NIFI-7737 Project: Apache NiFi Issue

[jira] [Resolved] (NIFI-7736) Duplicated permission checks in Empty All Queues

2020-08-13 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-7736. -- Resolution: Fixed > Duplicated permission checks in Empty All Queues >

[jira] [Commented] (NIFI-7736) Duplicated permission checks in Empty All Queues

2020-08-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177067#comment-17177067 ] ASF subversion and git services commented on NIFI-7736: --- Commit

[GitHub] [nifi] markap14 commented on pull request #4477: NIFI-7736 Duplicated permission checks in Empty All Queues

2020-08-13 Thread GitBox
markap14 commented on pull request #4477: URL: https://github.com/apache/nifi/pull/4477#issuecomment-673520174 Thanks @tpalfy all looks good to me. +1 merged to main. This is an automated message from the Apache Git Service.

[GitHub] [nifi] markap14 merged pull request #4477: NIFI-7736 Duplicated permission checks in Empty All Queues

2020-08-13 Thread GitBox
markap14 merged pull request #4477: URL: https://github.com/apache/nifi/pull/4477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (NIFI-7736) Duplicated permission checks in Empty All Queues

2020-08-13 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-7736: --- Fix Version/s: 1.12.0 > Duplicated permission checks in Empty All Queues >

[jira] [Resolved] (NIFI-6666) InvokeHTTP should provide a User-agent header

2020-08-13 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt resolved NIFI-. Resolution: Fixed > InvokeHTTP should provide a User-agent header >

[jira] [Commented] (NIFI-6666) InvokeHTTP should provide a User-agent header

2020-08-13 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177040#comment-17177040 ] Joe Witt commented on NIFI-: It did. That was removed for similar concerns you had. But all the

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #871: MINIFICPP-1203 - Remove extra spaces around parentheses according to linter recommendation

2020-08-13 Thread GitBox
hunyadi-dev commented on a change in pull request #871: URL: https://github.com/apache/nifi-minifi-cpp/pull/871#discussion_r469969075 ## File path: extensions/jni/jvm/JVMLoader.h ## @@ -349,7 +349,7 @@ class JVMLoader { } #ifdef _MSC_VER -#pragma warning( suppress:

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #871: MINIFICPP-1203 - Remove extra spaces around parentheses according to linter recommendation

2020-08-13 Thread GitBox
hunyadi-dev commented on a change in pull request #871: URL: https://github.com/apache/nifi-minifi-cpp/pull/871#discussion_r469969174 ## File path: main/AgentDocs.cpp ## @@ -129,7 +129,7 @@ void AgentDocs::generate(const std::string , std::ostream ) { auto fileFind =

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #864: MINIFICPP-1319 - Stream refactor

2020-08-13 Thread GitBox
adamdebreceni commented on a change in pull request #864: URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469966242 ## File path: libminifi/include/io/OutputStream.h ## @@ -0,0 +1,107 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi] tpalfy opened a new pull request #4477: NIFI-7736 Duplicated permission checks in Empty All Queues

2020-08-13 Thread GitBox
tpalfy opened a new pull request #4477: URL: https://github.com/apache/nifi/pull/4477 Fix: Empty All Queues performance - When authorizing request, checking read/write credentials on encapsulated process groups and connections was doubly recursive (for each element it added all child

[jira] [Created] (MINIFICPP-1332) MiNiFi should properly handle running out of diskspace

2020-08-13 Thread Arpad Boda (Jira)
Arpad Boda created MINIFICPP-1332: - Summary: MiNiFi should properly handle running out of diskspace Key: MINIFICPP-1332 URL: https://issues.apache.org/jira/browse/MINIFICPP-1332 Project: Apache NiFi

[jira] [Comment Edited] (NIFI-6666) InvokeHTTP should provide a User-agent header

2020-08-13 Thread Wouter de Vries (Jira)
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176862#comment-17176862 ] Wouter de Vries edited comment on NIFI- at 8/13/20, 1:33 PM: - Looking

[jira] [Assigned] (NIFI-7696) MultiQueryRecord Processor

2020-08-13 Thread Mahieddine Cherif (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahieddine Cherif reassigned NIFI-7696: --- Assignee: Mahieddine Cherif > MultiQueryRecord Processor >

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #864: MINIFICPP-1319 - Stream refactor

2020-08-13 Thread GitBox
adamdebreceni commented on a change in pull request #864: URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469928037 ## File path: extensions/coap/tests/CoapC2VerifyHeartbeat.cpp ## @@ -132,18 +132,18 @@ class VerifyCoAPServer : public CoapIntegrationBase {

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #864: MINIFICPP-1319 - Stream refactor

2020-08-13 Thread GitBox
szaszm commented on a change in pull request #864: URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469923156 ## File path: extensions/coap/tests/CoapC2VerifyHeartbeat.cpp ## @@ -132,18 +132,18 @@ class VerifyCoAPServer : public CoapIntegrationBase {

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #864: MINIFICPP-1319 - Stream refactor

2020-08-13 Thread GitBox
szaszm commented on a change in pull request #864: URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469916009 ## File path: libminifi/include/io/OutputStream.h ## @@ -0,0 +1,107 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #864: MINIFICPP-1319 - Stream refactor

2020-08-13 Thread GitBox
szaszm commented on a change in pull request #864: URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469864618 ## File path: libminifi/include/io/Stream.h ## @@ -0,0 +1,52 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #864: MINIFICPP-1319 - Stream refactor

2020-08-13 Thread GitBox
adamdebreceni commented on a change in pull request #864: URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469903259 ## File path: libminifi/src/io/BufferStream.cpp ## @@ -0,0 +1,56 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #864: MINIFICPP-1319 - Stream refactor

2020-08-13 Thread GitBox
adamdebreceni commented on a change in pull request #864: URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469902822 ## File path: libminifi/src/io/InputStream.cpp ## @@ -0,0 +1,141 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #864: MINIFICPP-1319 - Stream refactor

2020-08-13 Thread GitBox
adamdebreceni commented on a change in pull request #864: URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469902504 ## File path: libminifi/src/io/OutputStream.cpp ## @@ -0,0 +1,118 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #864: MINIFICPP-1319 - Stream refactor

2020-08-13 Thread GitBox
adamdebreceni commented on a change in pull request #864: URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469901701 ## File path: libminifi/test/unit/FileStreamTests.cpp ## @@ -235,12 +235,12 @@ TEST_CASE("TestFileExceedSize", "[TestLoader]") {

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
lordgamez commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r469899411 ## File path: extensions/libarchive/MergeContent.h ## @@ -259,20 +259,56 @@ class ZipMerge: public ArchiveMerge, public MergeBin { } };

[jira] [Assigned] (NIFI-7736) Duplicated permission checks in Empty All Queues

2020-08-13 Thread Tamas Palfy (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Palfy reassigned NIFI-7736: - Assignee: Tamas Palfy > Duplicated permission checks in Empty All Queues >

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
szaszm commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r469883065 ## File path: extensions/libarchive/MergeContent.h ## @@ -259,20 +259,56 @@ class ZipMerge: public ArchiveMerge, public MergeBin { } }; +class

[jira] [Created] (NIFI-7736) Duplicated permission checks in Empty All Queues

2020-08-13 Thread Peter Turcsanyi (Jira)
Peter Turcsanyi created NIFI-7736: - Summary: Duplicated permission checks in Empty All Queues Key: NIFI-7736 URL: https://issues.apache.org/jira/browse/NIFI-7736 Project: Apache NiFi Issue

[jira] [Created] (NIFI-7735) MongoDB Connection Issue

2020-08-13 Thread Venkatesh Raman (Jira)
Venkatesh Raman created NIFI-7735: - Summary: MongoDB Connection Issue Key: NIFI-7735 URL: https://issues.apache.org/jira/browse/NIFI-7735 Project: Apache NiFi Issue Type: Bug

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #871: MINIFICPP-1203 - Remove extra spaces around parentheses according to linter recommendation

2020-08-13 Thread GitBox
szaszm commented on a change in pull request #871: URL: https://github.com/apache/nifi-minifi-cpp/pull/871#discussion_r469841552 ## File path: extensions/jni/jvm/JVMLoader.h ## @@ -349,7 +349,7 @@ class JVMLoader { } #ifdef _MSC_VER -#pragma warning( suppress: 4054 )

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #864: MINIFICPP-1319 - Stream refactor

2020-08-13 Thread GitBox
arpadboda commented on a change in pull request #864: URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469787490 ## File path: libminifi/include/io/OutputStream.h ## @@ -0,0 +1,107 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #868: MINIFICPP-1326 improve PublishKafka logging

2020-08-13 Thread GitBox
szaszm commented on a change in pull request #868: URL: https://github.com/apache/nifi-minifi-cpp/pull/868#discussion_r469830729 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -144,6 +159,305 @@ struct rd_kafka_conf_deleter { struct rd_kafka_topic_conf_deleter {

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #868: MINIFICPP-1326 improve PublishKafka logging

2020-08-13 Thread GitBox
lordgamez commented on a change in pull request #868: URL: https://github.com/apache/nifi-minifi-cpp/pull/868#discussion_r469828169 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -144,6 +159,305 @@ struct rd_kafka_conf_deleter { struct rd_kafka_topic_conf_deleter

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
adamdebreceni commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r469823575 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -156,7 +159,7 @@ void MergeContent::onSchedule(core::ProcessContext *context,

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #870: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-13 Thread GitBox
adamdebreceni commented on a change in pull request #870: URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r469822537 ## File path: extensions/libarchive/MergeContent.h ## @@ -259,20 +259,56 @@ class ZipMerge: public ArchiveMerge, public MergeBin { } };

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #868: MINIFICPP-1326 improve PublishKafka logging

2020-08-13 Thread GitBox
szaszm commented on a change in pull request #868: URL: https://github.com/apache/nifi-minifi-cpp/pull/868#discussion_r469819190 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -144,6 +159,305 @@ struct rd_kafka_conf_deleter { struct rd_kafka_topic_conf_deleter {

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #868: MINIFICPP-1326 improve PublishKafka logging

2020-08-13 Thread GitBox
lordgamez commented on a change in pull request #868: URL: https://github.com/apache/nifi-minifi-cpp/pull/868#discussion_r469808973 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -144,6 +159,305 @@ struct rd_kafka_conf_deleter { struct rd_kafka_topic_conf_deleter

[jira] [Commented] (NIFI-6666) InvokeHTTP should provide a User-agent header

2020-08-13 Thread Wouter de Vries (Jira)
[ https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176862#comment-17176862 ] Wouter de Vries commented on NIFI-: --- Looking at user-agents in general, we are (were) including

[jira] [Updated] (MINIFICPP-1331) Upgrade yaml-cpp to eliminate issues with "NULL" string in config

2020-08-13 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi updated MINIFICPP-1331: Description: *Background:* Parsing the value "NULL" for a configuration node

[jira] [Created] (MINIFICPP-1331) Upgrade yaml-cpp to eliminate issues with "NULL" string in config

2020-08-13 Thread Adam Hunyadi (Jira)
Adam Hunyadi created MINIFICPP-1331: --- Summary: Upgrade yaml-cpp to eliminate issues with "NULL" string in config Key: MINIFICPP-1331 URL: https://issues.apache.org/jira/browse/MINIFICPP-1331

[GitHub] [nifi-minifi-cpp] hunyadi-dev opened a new pull request #871: MINIFICPP-1203 - Remove extra spaces around parentheses according to linter recommendation

2020-08-13 Thread GitBox
hunyadi-dev opened a new pull request #871: URL: https://github.com/apache/nifi-minifi-cpp/pull/871 Automatic fixes done using: ```zsh ➜ make linter |& egrep -v '^Done processing|^Ignoring' |& tee errors.txt | less ➜ cat errors.txt | grep "Extra space before (" | tr ":" " " |