[jira] [Updated] (NIFI-12966) Upgrade Netty to 4.1.108
[ https://issues.apache.org/jira/browse/NIFI-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12966: Summary: Upgrade Netty to 4.1.108 (was: Upgrade Netty to 4.1.108E) > Upgrade Netty to 4.1.108 > > > Key: NIFI-12966 > URL: https://issues.apache.org/jira/browse/NIFI-12966 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > Netty dependencies should be upgraded to > [4.1.108|https://netty.io/news/2024/03/21/4-1-108-Final.html] to incorporate > several improvements and a resolution for CVE-2024-29025 related to HTTP POST > request decoding. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12966) Upgrade Netty to 4.1.108
[ https://issues.apache.org/jira/browse/NIFI-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12966: Status: Patch Available (was: Open) > Upgrade Netty to 4.1.108 > > > Key: NIFI-12966 > URL: https://issues.apache.org/jira/browse/NIFI-12966 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > Netty dependencies should be upgraded to > [4.1.108|https://netty.io/news/2024/03/21/4-1-108-Final.html] to incorporate > several improvements and a resolution for CVE-2024-29025 related to HTTP POST > request decoding. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12966 Upgrade Netty from 4.1.106 to 4.1.108 [nifi]
exceptionfactory opened a new pull request, #8578: URL: https://github.com/apache/nifi/pull/8578 # Summary [NIFI-12966](https://issues.apache.org/jira/browse/NIFI-12966) Upgrades Netty from 4.1.106 to [4.1.108](https://netty.io/news/2024/03/21/4-1-108-Final.html) incorporating several improvements as well as a resolution for CVE-2024-29025 related to decoding multipart HTTP POST requests. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12966) Upgrade Netty to 4.1.108E
David Handermann created NIFI-12966: --- Summary: Upgrade Netty to 4.1.108E Key: NIFI-12966 URL: https://issues.apache.org/jira/browse/NIFI-12966 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: David Handermann Assignee: David Handermann Netty dependencies should be upgraded to [4.1.108|https://netty.io/news/2024/03/21/4-1-108-Final.html] to incorporate several improvements and a resolution for CVE-2024-29025 related to HTTP POST request decoding. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12965) Upgrade Guava to 33.1.0
[ https://issues.apache.org/jira/browse/NIFI-12965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12965: Status: Patch Available (was: Open) > Upgrade Guava to 33.1.0 > --- > > Key: NIFI-12965 > URL: https://issues.apache.org/jira/browse/NIFI-12965 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Time Spent: 10m > Remaining Estimate: 0h > > Google Guava dependencies should be upgraded to > [33.1.0|https://github.com/google/guava/releases/tag/v33.1.0] to incorporate > bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12965 Upgrade Guava from 32.1.2 to 33.1.0 [nifi]
exceptionfactory opened a new pull request, #8577: URL: https://github.com/apache/nifi/pull/8577 # Summary [NIFI-12965](https://issues.apache.org/jira/browse/NIFI-12965) Upgrades Google Guava dependencies from 32.1.2 to [33.1.0](https://github.com/google/guava/releases/tag/v33.1.0) incorporating bug fixes and improvements. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12017) EncodeContent: Allow single line output for base64 and base32
[ https://issues.apache.org/jira/browse/NIFI-12017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12017. - Fix Version/s: 2.0.0-M3 Resolution: Fixed > EncodeContent: Allow single line output for base64 and base32 > - > > Key: NIFI-12017 > URL: https://issues.apache.org/jira/browse/NIFI-12017 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.23.2 >Reporter: Umar Hussain >Assignee: crissaegrim >Priority: Minor > Fix For: 2.0.0-M3 > > Time Spent: 19h 20m > Remaining Estimate: 0h > > This ticket focuses on adding the option in EncodeContent processor for > outputting Base64 and Base32 encoded content in a single line, in addition to > by default splitting output. > This option will only appear when encoding base64 and base32 (will not apply > to hex) and not in any decoding. > It will help in cases where single line encoded content is required, for > which currently we need to use an additional ReplaceText processor to remove > line separator -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12017) EncodeContent: Allow single line output for base64 and base32
[ https://issues.apache.org/jira/browse/NIFI-12017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831598#comment-17831598 ] ASF subversion and git services commented on NIFI-12017: Commit 5cc857b99c780afb0a28112a73d73ae130b7b1fa in nifi's branch refs/heads/main from knguyen [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=5cc857b99c ] NIFI-12017 Added Line Length Properties to EncodeContent This closes #8417 Signed-off-by: David Handermann > EncodeContent: Allow single line output for base64 and base32 > - > > Key: NIFI-12017 > URL: https://issues.apache.org/jira/browse/NIFI-12017 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.23.2 >Reporter: Umar Hussain >Assignee: crissaegrim >Priority: Minor > Time Spent: 19h 20m > Remaining Estimate: 0h > > This ticket focuses on adding the option in EncodeContent processor for > outputting Base64 and Base32 encoded content in a single line, in addition to > by default splitting output. > This option will only appear when encoding base64 and base32 (will not apply > to hex) and not in any decoding. > It will help in cases where single line encoded content is required, for > which currently we need to use an additional ReplaceText processor to remove > line separator -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12017 add ability to choose to output to single line for base32 base64 contents [nifi]
exceptionfactory closed pull request #8417: NIFI-12017 add ability to choose to output to single line for base32 base64 contents URL: https://github.com/apache/nifi/pull/8417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12017 add ability to choose to output to single line for base32 base64 contents [nifi]
exceptionfactory commented on PR #8417: URL: https://github.com/apache/nifi/pull/8417#issuecomment-2024255135 Thanks for the reviews as well @dan-s1! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12900) Avoid unnecessary directory listing in PutSFTP
[
https://issues.apache.org/jira/browse/NIFI-12900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831597#comment-17831597
]
ASF subversion and git services commented on NIFI-12900:
Commit a56046736366233dd60ddd0c07b4da6327cf5626 in nifi's branch
refs/heads/support/nifi-1.x from EndzeitBegins
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a560467363 ]
NIFI-12900 Avoid unnecessary file listing in PutSFTP
This closes #8503
Signed-off-by: David Handermann
(cherry picked from commit 83bc0e545331968d7827353b5ee7f225b5b76d1e)
> Avoid unnecessary directory listing in PutSFTP
> ---
>
> Key: NIFI-12900
> URL: https://issues.apache.org/jira/browse/NIFI-12900
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The processor {{PutSFTP}} is based on {{PutFileTransfer}}.
> Before an actual upload takes place, potential conflicts (e.g. existing file)
> are identified and resolved using {{identifyAndResolveConflictFile(...)}}.
> As part of this process, information on the target file is retrieved using
> {{FileTransfer.getRemoteFileInfo(...)}}.
> In case of {{PutSFTP}} this is implemented by {{SFTPTransfer}}.
> The implementation of {{getRemoteFileInfo}} executes {{ls}} on the target
> directory path. In case there are a lot of files inside the remote directory,
> e.g. >10.000 files, the listing reduces the performance of {{PutSFTP}}
> significantly.
> Instead of a listing on the directory, file information should be retrieved
> using either {{ls}} or {{stat}} on the target file directly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-12900) Avoid unnecessary directory listing in PutSFTP
[
https://issues.apache.org/jira/browse/NIFI-12900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-12900.
-
Fix Version/s: 2.0.0-M3
1.26.0
Resolution: Fixed
> Avoid unnecessary directory listing in PutSFTP
> ---
>
> Key: NIFI-12900
> URL: https://issues.apache.org/jira/browse/NIFI-12900
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M3, 1.26.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The processor {{PutSFTP}} is based on {{PutFileTransfer}}.
> Before an actual upload takes place, potential conflicts (e.g. existing file)
> are identified and resolved using {{identifyAndResolveConflictFile(...)}}.
> As part of this process, information on the target file is retrieved using
> {{FileTransfer.getRemoteFileInfo(...)}}.
> In case of {{PutSFTP}} this is implemented by {{SFTPTransfer}}.
> The implementation of {{getRemoteFileInfo}} executes {{ls}} on the target
> directory path. In case there are a lot of files inside the remote directory,
> e.g. >10.000 files, the listing reduces the performance of {{PutSFTP}}
> significantly.
> Instead of a listing on the directory, file information should be retrieved
> using either {{ls}} or {{stat}} on the target file directly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12900) Avoid unnecessary directory listing in PutSFTP
[
https://issues.apache.org/jira/browse/NIFI-12900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831596#comment-17831596
]
ASF subversion and git services commented on NIFI-12900:
Commit 83bc0e545331968d7827353b5ee7f225b5b76d1e in nifi's branch
refs/heads/main from EndzeitBegins
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=83bc0e5453 ]
NIFI-12900 Avoid unnecessary file listing in PutSFTP
This closes #8503
Signed-off-by: David Handermann
> Avoid unnecessary directory listing in PutSFTP
> ---
>
> Key: NIFI-12900
> URL: https://issues.apache.org/jira/browse/NIFI-12900
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The processor {{PutSFTP}} is based on {{PutFileTransfer}}.
> Before an actual upload takes place, potential conflicts (e.g. existing file)
> are identified and resolved using {{identifyAndResolveConflictFile(...)}}.
> As part of this process, information on the target file is retrieved using
> {{FileTransfer.getRemoteFileInfo(...)}}.
> In case of {{PutSFTP}} this is implemented by {{SFTPTransfer}}.
> The implementation of {{getRemoteFileInfo}} executes {{ls}} on the target
> directory path. In case there are a lot of files inside the remote directory,
> e.g. >10.000 files, the listing reduces the performance of {{PutSFTP}}
> significantly.
> Instead of a listing on the directory, file information should be retrieved
> using either {{ls}} or {{stat}} on the target file directly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12900 Avoid unnecessary directory listing in PutSFTP [nifi]
exceptionfactory closed pull request #8503: NIFI-12900 Avoid unnecessary directory listing in PutSFTP URL: https://github.com/apache/nifi/pull/8503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-7464) CSVRecordSetWriter does not output header for record sets with zero records
[ https://issues.apache.org/jira/browse/NIFI-7464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Fredrickson resolved NIFI-7464. Fix Version/s: 1.20.0 Resolution: Fixed This was resolved in [NIFI-10996|https://github.com/apache/nifi/commit/a9baa21f87eac5f2992c42ea4a45af00a3f19af6] > CSVRecordSetWriter does not output header for record sets with zero records > --- > > Key: NIFI-7464 > URL: https://issues.apache.org/jira/browse/NIFI-7464 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.11.3 >Reporter: Karl Fredrickson >Priority: Major > Fix For: 1.20.0 > > > If you configure CSVRecordSetWriter to output a header row, and a processor > such as QueryRecord or ConvertRecord writes out a flowfile with zero records > using the CSVRecordSetWriter, the header row will not be included. > This affects QueryRecord and ConvertRecord processors and presumably all > other processors that can be configured to use CSVRecordWriter. > I suppose this could be intentional behavior but older versions of NiFi like > 1.3 do output a header even when writing a zero record flowfile, and this > caused some non-trivial issues for us in the process of upgrading from 1.3 to > 1.11. We fixed this on our NiFi installation by making a small change to the > WriteCSVResult.java file and then rebuilding the NiFi record serialization > services NAR. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12965) Upgrade Guava to 33.1.0
David Handermann created NIFI-12965: --- Summary: Upgrade Guava to 33.1.0 Key: NIFI-12965 URL: https://issues.apache.org/jira/browse/NIFI-12965 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: David Handermann Assignee: David Handermann Google Guava dependencies should be upgraded to [33.1.0|https://github.com/google/guava/releases/tag/v33.1.0] to incorporate bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535: URL: https://github.com/apache/nifi/pull/8535#discussion_r1542117048 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-configuration-history/ui/flow-configuration-history-listing/purge-history/purge-history.component.html: ## @@ -34,7 +34,7 @@ Purge History - + Review Comment: https://issues.apache.org/jira/browse/NIFI-12964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12964) Date picker and Time Picker style updates
Scott Aslan created NIFI-12964: -- Summary: Date picker and Time Picker style updates Key: NIFI-12964 URL: https://issues.apache.org/jira/browse/NIFI-12964 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Attachments: Screenshot 2024-03-27 at 6.22.10 PM.png, image-2024-03-27-18-32-12-007.png There are several differences in height and width and padding etc. between the Data picker input field and the Time picker input fields: !image-2024-03-27-18-32-12-007.png! !Screenshot 2024-03-27 at 6.22.10 PM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535: URL: https://github.com/apache/nifi/pull/8535#discussion_r1542115674 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-configuration-history/ui/flow-configuration-history-listing/purge-history/purge-history.component.html: ## @@ -34,7 +34,7 @@ Purge History - + Review Comment: Yea these widgets are not the same size in the flow configuration history either: https://github.com/apache/nifi/assets/6797571/fb36f7c5-616d-4b39-9aef-727d9f5df590;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12875: Add unsuccessful HTTP status code handling logic [nifi]
exceptionfactory commented on code in PR #8484:
URL: https://github.com/apache/nifi/pull/8484#discussion_r1542112684
##
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java:
##
@@ -172,6 +173,20 @@ public class RestLookupService extends
AbstractControllerService implements Reco
.addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
.build();
+static final AllowableValue PASS_THROUGH = new
AllowableValue("Pass-through",
+"Pass-through","sends successful and unsuccessful HTTP responses
to the caller");
+static final AllowableValue HANDLE = new AllowableValue("Handle Service
Errors",
+"Handle Service Errors", "generates an exception when an
unsuccessful HTTP response code is received");
+public static final PropertyDescriptor PROP_RESPONSE_CODE_HANDLING = new
PropertyDescriptor.Builder()
+.name("rest-lookup-response-code-handling")
+.displayName("Response Code Handling Strategy")
Review Comment:
On further consideration, what do you think of naming this `Response
Handling Strategy` with values of `Returned` and `Evaluated`? Open to
additional suggestions, but having a single word could be useful, with the
description indicating all responses and response codes are returned, or the
response code is evaluated for success or failure based on standard HTTP
conventions?
##
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java:
##
@@ -172,6 +173,20 @@ public class RestLookupService extends
AbstractControllerService implements Reco
.addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
.build();
+static final AllowableValue PASS_THROUGH = new
AllowableValue("Pass-through",
+"Pass-through","sends successful and unsuccessful HTTP responses
to the caller");
+static final AllowableValue HANDLE = new AllowableValue("Handle Service
Errors",
+"Handle Service Errors", "generates an exception when an
unsuccessful HTTP response code is received");
Review Comment:
Declaring these options as an `enum` that implements `DescribedValue` makes
it easier to refer to the parsing value of the property. Recommend naming the
enum `ResponseHandlingStrategy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (NIFI-12934) RenameRecordField does not clear serialized form of records
[ https://issues.apache.org/jira/browse/NIFI-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12934. - Assignee: Mark Payne Resolution: Fixed > RenameRecordField does not clear serialized form of records > --- > > Key: NIFI-12934 > URL: https://issues.apache.org/jira/browse/NIFI-12934 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Critical > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > When RenameRecordField runs, it updates the parent record for any matches. > However, when this happens, the Record's "serialized form" does not get > cleared. As a result, the Record Writer may (depending on its configuration) > write out the 'cached' / serialized form of the Record, resulting in no > change to the records. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12934) RenameRecordField does not clear serialized form of records
[ https://issues.apache.org/jira/browse/NIFI-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831570#comment-17831570 ] ASF subversion and git services commented on NIFI-12934: Commit afed8c6f53196944fca1df7f3f6bddeaf898c5da in nifi's branch refs/heads/main from Mark Payne [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=afed8c6f53 ] NIFI-12934 Clear Serialized Form of Records on Field Changes Any time a Record's field is removed or renamed, ensure that we clear the Serialized Form so that a stale cached value cannot be written This closes #8576 Signed-off-by: David Handermann > RenameRecordField does not clear serialized form of records > --- > > Key: NIFI-12934 > URL: https://issues.apache.org/jira/browse/NIFI-12934 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Mark Payne >Priority: Critical > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > When RenameRecordField runs, it updates the parent record for any matches. > However, when this happens, the Record's "serialized form" does not get > cleared. As a result, the Record Writer may (depending on its configuration) > write out the 'cached' / serialized form of the Record, resulting in no > change to the records. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12934: Any time a Record's field is removed or renamed, ensure t… [nifi]
exceptionfactory closed pull request #8576: NIFI-12934: Any time a Record's field is removed or renamed, ensure t… URL: https://github.com/apache/nifi/pull/8576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1542102631
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts:
##
@@ -2189,11 +2190,12 @@ export class FlowEffects {
ofType(FlowActions.showOkDialog),
tap((request) => {
this.dialog.open(OkDialog, {
+...MEDIUM_DIALOG,
+maxWidth: '24rem',
Review Comment:
The approach I tried to take in regards to the dialog widths was to keep as
much parody with the current dialog widths as possible but to use the
mat-dialog API to set the dialog sizes and not using the dialog content widths
to determine the dialog width.
One thing to note here: The tailwind css `.max-w-sm` sets the max-width:
24rem; and the `.w-96` sets width: 24rem;.
So when I started looking throughout the nifi application I noticed that the
SMALL_DIALOG size was used almost exclusively for the YesNoDialog use cases. If
you look in the template for the YesNoDialog you will see that I removed the
`.max-w-sm` class from the template. Instead now the SMALL_DIALOG config sets
the maxWidth: '24rem'.
There were three remaining dialogs (other than YesNoDialogs) that used the
SMALL_DIALOG size. The OverridePolicyDialog, CreatePortDialog, and
AddPropertyDialog. For the OverridePolicayDialog the
override-policy-dialog.component.html template set a `.w-96` which as we noted
above sets a width: 24rem;. This is effectively the same thing as using the
`.max-w-sm` class and so we simply can use the SMALL_DIALOG size config for the
OverridePolicyDialog. For the other two SMALL_DIALOG's (CreatePortDialog and
the AddPropertyDialog) the maxWidth: '24rem' works really well so I left them
as SMALL_DIALOG.
The last place we had a width set by a tailwind style in an dialog component
template was in the OkDialog where `.max-w-sm` was setting a max-width: 24rem.
But not all OkDialogs are the same size. Some OkDialog are SMALL_DIALOG and
some OkDialog are MEDIUM_DIALOG. So in order that the OkDialog use cases to
have parody the OkDialogs need to receive their initial size config from a
SMALL_DIALOG or a MEDIUM_DIALOG config but all OkDialogs must also override
their `maxWidth: '24rem'` to account for the removal of the `.max-w-sm` from
the OkDialog template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1542075055
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/controller-services/controller-services.effects.ts:
##
@@ -382,9 +383,9 @@ export class ControllerServicesEffects {
const serviceId: string = request.id;
const enableDialogReference =
this.dialog.open(EnableControllerService, {
+...XL_DIALOG,
data: request,
-id: serviceId,
-panelClass: 'large-dialog'
+id: serviceId
Review Comment:
Yes this was intentional in order to keep the text for each of the 'Steps to
Disable' on a single row with the green check mark at the end of the single
line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12950) Use uiOnly flag
[ https://issues.apache.org/jira/browse/NIFI-12950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12950: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Use uiOnly flag > --- > > Key: NIFI-12950 > URL: https://issues.apache.org/jira/browse/NIFI-12950 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The REST API contains a number of endpoints that support a uiOnly flag. This > flag prunes a number of details that are not needed by the UI at that point. > This helps stabilize the usage of the UI when the flow size increases. The > new UI work currently does not leverage this flag. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12950: Updating front end to use the uiOnly flag where possible [nifi]
rfellows merged PR #8565: URL: https://github.com/apache/nifi/pull/8565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12950) Use uiOnly flag
[ https://issues.apache.org/jira/browse/NIFI-12950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831550#comment-17831550 ] ASF subversion and git services commented on NIFI-12950: Commit db09b44e40ae8e4cdd1674a516e49fbc166cad1c in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=db09b44e40 ] NIFI-12950: Updating front end to use the uiOnly flag where possible (#8565) * NIFI-12950: - Updating front end to use the uiOnly flag where possible. * NIFI-12950: - Addressing review feedback. This closes #8565 > Use uiOnly flag > --- > > Key: NIFI-12950 > URL: https://issues.apache.org/jira/browse/NIFI-12950 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > The REST API contains a number of endpoints that support a uiOnly flag. This > flag prunes a number of details that are not needed by the UI at that point. > This helps stabilize the usage of the UI when the flow size increases. The > new UI work currently does not leverage this flag. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12940] - Migrate to Nx [nifi]
mcgilman merged PR #8574: URL: https://github.com/apache/nifi/pull/8574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12940) Migrate to Nx
[ https://issues.apache.org/jira/browse/NIFI-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12940: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Migrate to Nx > - > > Key: NIFI-12940 > URL: https://issues.apache.org/jira/browse/NIFI-12940 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12940) Migrate to Nx
[ https://issues.apache.org/jira/browse/NIFI-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831543#comment-17831543 ] ASF subversion and git services commented on NIFI-12940: Commit a3dda5eb091049713fc20bb15eb510dde6c81c5b in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a3dda5eb09 ] [NIFI-12940] - Migrate to Nx (#8574) * [NIFI-12940] - Migrate to Nx * Set initial focus in the extension creation dialog to the filter input. This closes #8574 > Migrate to Nx > - > > Key: NIFI-12940 > URL: https://issues.apache.org/jira/browse/NIFI-12940 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12959: Support loading python processors from NARs [nifi]
exceptionfactory commented on code in PR #8573:
URL: https://github.com/apache/nifi/pull/8573#discussion_r1541949562
##
nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/python/PythonNarIT.java:
##
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.tests.system.python;
+
+import org.apache.nifi.tests.system.NiFiInstanceFactory;
+import org.apache.nifi.tests.system.NiFiSystemIT;
+import org.apache.nifi.toolkit.cli.impl.client.nifi.NiFiClientException;
+import org.apache.nifi.web.api.entity.ConnectionEntity;
+import org.apache.nifi.web.api.entity.ProcessorEntity;
+import org.junit.jupiter.api.Test;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.StandardCopyOption;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class PythonNarIT extends NiFiSystemIT {
+
+@Override
+public NiFiInstanceFactory getInstanceFactory() {
+return createPythonicInstanceFactory();
+}
+
+@Override
+protected boolean isAllowFactoryReuse() {
+return false;
+}
+
+@Test
+public void testRunProcessorWithBundledDependencies() throws IOException,
NiFiClientException, InterruptedException {
+final File nifiHome = getNiFiInstance().getInstanceDirectory();
+final File lib = new File(nifiHome, "lib");
+final File pythonNars = new File(lib, "python-nars");
+final File[] narFiles = pythonNars.listFiles((dir, name) ->
name.endsWith(".nar"));
+assertNotNull(narFiles);
+
+// Copy the python nar files to the lib directory so that they will be
loaded on restart.
+for (final File narFile : narFiles) {
+Files.copy(narFile.toPath(),
lib.toPath().resolve(narFile.getName()), StandardCopyOption.REPLACE_EXISTING);
+}
+
+// Delete all python extensions from the python/extensions directory
to ensure they are not loaded.
+final File pythonExtensions = new File(nifiHome, "python/extensions");
+final File[] extensionFiles = pythonExtensions.listFiles();
+assertNotNull(extensionFiles);
+for (final File extensionFile : extensionFiles) {
+deleteRecursively(extensionFile);
+}
+
+// Restart NiFi
+getNiFiInstance().stop();
+getNiFiInstance().start(true);
+
+// Create instance of the WriteNumpyVersionBundledDependency
processor, and connect a GenerateFlowFile to it
+final ProcessorEntity generate =
getClientUtil().createProcessor("GenerateFlowFile");
+ProcessorEntity writeVersion =
getClientUtil().createPythonProcessor("WriteJson5VersionBundledDependency");
+writeVersion =
getClientUtil().setAutoTerminatedRelationships(writeVersion, "failure");
+final ConnectionEntity generateToWriteVersion =
getClientUtil().createConnection(generate, writeVersion, "success");
+
+// Create a TerminateFlowFile processor and connect the
WriteNumpyVersionBundledDependency processor to it
+final ProcessorEntity terminate =
getClientUtil().createProcessor("TerminateFlowFile");
+final ConnectionEntity writeVersionToTerminate =
getClientUtil().createConnection(writeVersion, terminate, "success");
+
+// Wait for processor validation to complete
+getClientUtil().waitForValidProcessor(generate.getId());
+getClientUtil().waitForValidProcessor(writeVersion.getId());
+
+// Run the flow
+getClientUtil().startProcessor(generate);
+waitForQueueCount(generateToWriteVersion.getId(), 1);
+getClientUtil().startProcessor(writeVersion);
+waitForQueueCount(writeVersionToTerminate.getId(), 1);
+
+// Verify the output
+final String contents =
getClientUtil().getFlowFileContentAsUtf8(writeVersionToTerminate.getId(), 0);
+assertEquals("qpzry9x8gf2tvdw0s3jn54khce6mua7l", contents);
Review Comment:
Recommend calling this string out as a static variable named
`BECH32_CHARSET`.
##
Re: [PR] [NIFI-12940] - Migrate to Nx [nifi]
mcgilman commented on PR #8574: URL: https://github.com/apache/nifi/pull/8574#issuecomment-2023848676 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12343) PutElasticsearchJson exception with JSON strings over 20 MB
[
https://issues.apache.org/jira/browse/NIFI-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregory M. Foreman updated NIFI-12343:
--
Affects Version/s: 2.0.0-M2
> PutElasticsearchJson exception with JSON strings over 20 MB
> ---
>
> Key: NIFI-12343
> URL: https://issues.apache.org/jira/browse/NIFI-12343
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.23.2, 2.0.0-M2
>Reporter: Gregory M. Foreman
>Priority: Major
>
>
> PutElasticsearchJson throws an exception when reading JSON documents that
> contain string fields over 20 MB:
> {code:java}
> PutElasticsearchJson[id=] No FlowFiles successfully parsed for sending to
> Elasticsearch
> PutElasticsearchJson[id=] Could not read FlowFile content valid JSON.:
> com.fasterxml.jackson.core.exc.StreamConstraintsException: String length
> (20050553) exceeds the maximum length (2000)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12918 Fix Stateless NullPointerException on versioned sub-process groups - main branch [nifi]
slambrose commented on PR #8536:
URL: https://github.com/apache/nifi/pull/8536#issuecomment-2023618547
Thanks for taking another look :)
So, the storageLocation change is still needed to fix the bug and process
the flow in stateless. Otherwise, when it loops down to pull the sub-versioned
process flow, it'll append the /{bucketId}/{flowId} parameters twice and make a
bad call to the registry-api. The best way I came up to fix that was just to
make sure to start with the base registry url and append the storage location
parameters to always construct a valid registryUrl. I noticed the 1.x support
branch was originally setting the registryUrl to coordinates.getRegistryUrl(),
which was changed to coordinates.getStorageLocation() in main. This fix works
for the 1.x branch as well.
Do you have another value other than "1" you'd prefer me to set it to? FYI -
it has to be a static value in order for all of the current tests to work.
I can work on adding some unit tests for both of these fixes. I'll add a
comment here when I commit them and are ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-12934: Any time a Record's field is removed or renamed, ensure t… [nifi]
markap14 opened a new pull request, #8576: URL: https://github.com/apache/nifi/pull/8576 …hat we clear the Serialized Form so that a stale cached value cannot be written # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12934) RenameRecordField does not clear serialized form of records
[ https://issues.apache.org/jira/browse/NIFI-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-12934: -- Fix Version/s: 2.0.0-M3 > RenameRecordField does not clear serialized form of records > --- > > Key: NIFI-12934 > URL: https://issues.apache.org/jira/browse/NIFI-12934 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Mark Payne >Priority: Critical > Fix For: 2.0.0-M3 > > > When RenameRecordField runs, it updates the parent record for any matches. > However, when this happens, the Record's "serialized form" does not get > cleared. As a result, the Record Writer may (depending on its configuration) > write out the 'cached' / serialized form of the Record, resulting in no > change to the records. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12934) RenameRecordField does not clear serialized form of records
[ https://issues.apache.org/jira/browse/NIFI-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-12934: -- Priority: Critical (was: Major) > RenameRecordField does not clear serialized form of records > --- > > Key: NIFI-12934 > URL: https://issues.apache.org/jira/browse/NIFI-12934 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Mark Payne >Priority: Critical > > When RenameRecordField runs, it updates the parent record for any matches. > However, when this happens, the Record's "serialized form" does not get > cleared. As a result, the Record Writer may (depending on its configuration) > write out the 'cached' / serialized form of the Record, resulting in no > change to the records. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
mcgilman commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1541475885
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts:
##
@@ -2189,11 +2190,12 @@ export class FlowEffects {
ofType(FlowActions.showOkDialog),
tap((request) => {
this.dialog.open(OkDialog, {
+...MEDIUM_DIALOG,
+maxWidth: '24rem',
Review Comment:
I see this is used in a few places. I believe with this set up the
`minWidth` is wider than the `maxWidth`. `SMALL_DIALOG` is already set to use
`24rem`. What was the intention here?
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/controller-services/controller-services.effects.ts:
##
@@ -382,9 +383,9 @@ export class ControllerServicesEffects {
const serviceId: string = request.id;
const enableDialogReference =
this.dialog.open(EnableControllerService, {
+...XL_DIALOG,
data: request,
-id: serviceId,
-panelClass: 'large-dialog'
+id: serviceId
Review Comment:
Was moving to XL dialog intentional? This appears to have been done to both
Enable and Disable dialogs.
https://github.com/apache/nifi/assets/123395/dd52dbfc-b133-4174-8c9a-1fa5c2a4a203;>
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-configuration-history/ui/flow-configuration-history-listing/purge-history/purge-history.component.html:
##
@@ -34,7 +34,7 @@ Purge History
-
+
Review Comment:
I don't _think_ was introduced here but these two fields are different
widths. Happy to file something though and we can fix later unless you want to
get it here.
https://github.com/apache/nifi/assets/123395/312eee5e-b29f-41af-b138-549d630183be;>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-8960) Create ability for EvaluateJsonPath processor to match any or all defined json paths.
[ https://issues.apache.org/jira/browse/NIFI-8960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael W Moser updated NIFI-8960: -- Fix Version/s: (was: 1.14.0) Resolution: Won't Do Status: Resolved (was: Patch Available) Expression Language jsonPath() was built for this use case. > Create ability for EvaluateJsonPath processor to match any or all defined > json paths. > -- > > Key: NIFI-8960 > URL: https://issues.apache.org/jira/browse/NIFI-8960 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Tim Smith >Assignee: Tim Smith >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > Add the capability to set "Match Criteria" to "all" or "any", where all json > paths must match on json objects. Default behavior being "any". Also add the > ability to apply to either attributes matching regex or content, with > default being "match on content". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-8960) Create ability for EvaluateJsonPath processor to match any or all defined json paths.
[ https://issues.apache.org/jira/browse/NIFI-8960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831448#comment-17831448 ] Michael W Moser edited comment on NIFI-8960 at 3/27/24 4:29 PM: Expression Language jsonPath() was built for this use case. NIFI-1660 was (Author: mosermw): Expression Language jsonPath() was built for this use case. > Create ability for EvaluateJsonPath processor to match any or all defined > json paths. > -- > > Key: NIFI-8960 > URL: https://issues.apache.org/jira/browse/NIFI-8960 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Tim Smith >Assignee: Tim Smith >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > Add the capability to set "Match Criteria" to "all" or "any", where all json > paths must match on json objects. Default behavior being "any". Also add the > ability to apply to either attributes matching regex or content, with > default being "match on content". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-8930) Add ability for ScanAttribute processor to match on attribute values containing a delimited list of values.
[ https://issues.apache.org/jira/browse/NIFI-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831439#comment-17831439 ] Joe Witt commented on NIFI-8930: [~tlsmith]Hey sorry this one must have gotten lost in the shuffle. The processor works on the basis of an extremely fast [search algorithm|https://en.wikipedia.org/wiki/Aho%E2%80%93Corasick_algorithm] which is a very different animal than regex so that might be part of the delta. What you want to do makes sense for sure just not sure if 'this' is the right component or not. > Add ability for ScanAttribute processor to match on attribute values > containing a delimited list of values. > --- > > Key: NIFI-8930 > URL: https://issues.apache.org/jira/browse/NIFI-8930 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.14.0 >Reporter: Tim Smith >Assignee: Tim Smith >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > The ScanAttribute processor is limited in that an exact match is required > when applied for attribute value. There are many times an attribute contains > a delimited list of values. It would be useful to specify a delimiter and > have the match criteria applied to each delimited value in the attribute. Two > additional property descriptors need created, 'Delimiter' and 'Delimited > Match Criteria'. 'Delimiter' sets the delimiter to apply to the attribute(s). > 'Delimited Match Criteria' specifies how the delimited attributes should > match the dictionary. If 'All Must Match' is selected, all delimited values > must match a dictionary term/pattern for attribute to be matched. For 'At > Least 1 Must Match' , if any one delimited value matches,then the attribute > matches. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-8930) Add ability for ScanAttribute processor to match on attribute values containing a delimited list of values.
[ https://issues.apache.org/jira/browse/NIFI-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael W Moser updated NIFI-8930: -- Resolution: Won't Do Status: Resolved (was: Patch Available) > Add ability for ScanAttribute processor to match on attribute values > containing a delimited list of values. > --- > > Key: NIFI-8930 > URL: https://issues.apache.org/jira/browse/NIFI-8930 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.14.0 >Reporter: Tim Smith >Assignee: Tim Smith >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > The ScanAttribute processor is limited in that an exact match is required > when applied for attribute value. There are many times an attribute contains > a delimited list of values. It would be useful to specify a delimiter and > have the match criteria applied to each delimited value in the attribute. Two > additional property descriptors need created, 'Delimiter' and 'Delimited > Match Criteria'. 'Delimiter' sets the delimiter to apply to the attribute(s). > 'Delimited Match Criteria' specifies how the delimited attributes should > match the dictionary. If 'All Must Match' is selected, all delimited values > must match a dictionary term/pattern for attribute to be matched. For 'At > Least 1 Must Match' , if any one delimited value matches,then the attribute > matches. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2230 MergeContent should yield if no ready bins and no inco… [nifi-minifi-cpp]
martinzink commented on code in PR #1748:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1748#discussion_r1541314653
##
extensions/libarchive/BinFiles.cpp:
##
@@ -223,11 +223,14 @@ bool BinFiles::resurrectFlowFiles(core::ProcessSession
) {
return had_failure;
}
-void BinFiles::assumeOwnershipOfNextBatch(core::ProcessSession ) {
+bool BinFiles::assumeOwnershipOfNextBatch(core::ProcessSession ) {
for (size_t i = 0; i < batchSize_; ++i) {
auto flow = session.get();
if (flow == nullptr) {
+ if (i == 0) {
+return false;
+ }
Review Comment:
besides that, I wanna do a proper fix later aswell (we should probably
refactor the hasWorkToDo thingy so we can skip the ontrigger part if its not
neccesary) I just want to get this PR merged asap as it can cause some heavy
resource usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2230 MergeContent should yield if no ready bins and no inco… [nifi-minifi-cpp]
martinzink commented on code in PR #1748:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1748#discussion_r1541314653
##
extensions/libarchive/BinFiles.cpp:
##
@@ -223,11 +223,14 @@ bool BinFiles::resurrectFlowFiles(core::ProcessSession
) {
return had_failure;
}
-void BinFiles::assumeOwnershipOfNextBatch(core::ProcessSession ) {
+bool BinFiles::assumeOwnershipOfNextBatch(core::ProcessSession ) {
for (size_t i = 0; i < batchSize_; ++i) {
auto flow = session.get();
if (flow == nullptr) {
+ if (i == 0) {
+return false;
+ }
Review Comment:
besides that, I wanna do a proper fix aswell (we should probably refactor
the hasWorkToDo thingy so we can skip the ontrigger part if its not neccesary)
I just want to get this PR merged asap as it can cause some heavy resource
usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2230 MergeContent should yield if no ready bins and no inco… [nifi-minifi-cpp]
martinzink commented on code in PR #1748:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1748#discussion_r1541310212
##
extensions/libarchive/BinFiles.cpp:
##
@@ -223,11 +223,14 @@ bool BinFiles::resurrectFlowFiles(core::ProcessSession
) {
return had_failure;
}
-void BinFiles::assumeOwnershipOfNextBatch(core::ProcessSession ) {
+bool BinFiles::assumeOwnershipOfNextBatch(core::ProcessSession ) {
for (size_t i = 0; i < batchSize_; ++i) {
auto flow = session.get();
if (flow == nullptr) {
+ if (i == 0) {
+return false;
+ }
Review Comment:
https://github.com/apache/nifi-minifi-cpp/pull/1748/commits/4710593c41e64a4d27d3669c1d489ce3552aabbc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2230 MergeContent should yield if no ready bins and no inco… [nifi-minifi-cpp]
szaszm commented on code in PR #1748:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1748#discussion_r1541285411
##
extensions/libarchive/BinFiles.cpp:
##
@@ -223,11 +223,14 @@ bool BinFiles::resurrectFlowFiles(core::ProcessSession
) {
return had_failure;
}
-void BinFiles::assumeOwnershipOfNextBatch(core::ProcessSession ) {
+bool BinFiles::assumeOwnershipOfNextBatch(core::ProcessSession ) {
for (size_t i = 0; i < batchSize_; ++i) {
auto flow = session.get();
if (flow == nullptr) {
+ if (i == 0) {
+return false;
+ }
Review Comment:
More comments would be nice around the appreciated. What is special about
getting a nullptr at index 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12963) Process Group Versioning
[ https://issues.apache.org/jira/browse/NIFI-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12963: --- Description: * Start * Commit * Force Commit * Show changes * Revert changes * Change Flow version * Stop > Process Group Versioning > > > Key: NIFI-12963 > URL: https://issues.apache.org/jira/browse/NIFI-12963 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > > * Start > * Commit > * Force Commit > * Show changes > * Revert changes > * Change Flow version > * Stop -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] MINIFICPP-2230 MergeContent should yield if no ready bins and no inco… [nifi-minifi-cpp]
martinzink opened a new pull request, #1748: URL: https://github.com/apache/nifi-minifi-cpp/pull/1748 …ming flowfiles Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]
turcsanyip commented on code in PR #8544:
URL: https://github.com/apache/nifi/pull/8544#discussion_r1541225410
##
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java:
##
@@ -160,6 +170,14 @@ public class PutHDFS extends AbstractHadoopProcessor {
.allowableValues(WRITE_AND_RENAME_AV, SIMPLE_WRITE_AV)
.build();
+public static final PropertyDescriptor APPEND_MODE = new
PropertyDescriptor.Builder()
+.name("Append Mode")
+.description("Defines the append strategy to use when the Conflict
Resolution Strategy is set to 'append'.")
+.allowableValues(DEFAULT_APPEND_MODE, AVRO_APPEND_MODE)
+.defaultValue(DEFAULT_APPEND_MODE)
+.required(true)
+.build();
Review Comment:
`Append Mode` property should depend on `Conflict Resolution Strategy` and
should only be shown if the strategy is `append`.
I also suggest placing the new property just below `Conflict Resolution
Strategy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (NIFI-12918) Stateless NiFi NullPointerException on versioned PGs
[ https://issues.apache.org/jira/browse/NIFI-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831362#comment-17831362 ] Stephanie Ambrose edited comment on NIFI-12918 at 3/27/24 2:05 PM: --- Okay, so after some back and forth here is my final conclusion to this bug: I've submitted two PRs [https://github.com/apache/nifi/pull/8572/checks] <-- for support/1.x branch [https://github.com/apache/nifi/pull/8536/checks] <-- for main branch Here is what's happening. If you run a versioned stateless flow that has sub-versioned progress group, there is a NullPointerException thrown on the build method of StandardVersionControlInformation where there is a non-null requirement on "registryId". Code has changed in main versus support/1.x, but the bug exists on both. What I've found is the JerseyClient calls that are made to map the response from the registry-api back to the higher level VersionedProcessGroup -> VersionedFlowCoordinates both return JSON where the VersionedFlowCoordinates > registryId is always null. Now in the main branch, stateless uses some of these new "synchronizer" classes, so the best place to insert a solution is to add an else on the null check where the code runs the "determineRegistryId" method and set the value to "1" for versioned flows that do not have a registryId associated to them. Doing this passes all of the integration tests and code checks and fixes the bug. Since this class does not exist in the 1.x support branch, my best solution is to just comment out the null check (this breaks integration tests in main, but not in 1.x). I continued to look further at this idea of a "registryId" within the registry api code. The GET method on buckets/flow/version returns the same class that the stateless code uses to map into on the JerseyClient call. I then looked at the api code to POST new versioned flows, and it also expect the json as a parameter to match the same class. Well, since there is no "non-null" requirement on the registryId, versioned flows are stored in the database (or whichever storage adapter used) with this property as null. I did not check to see if the latest NiFi Registry UI is now setting this property, but making it non-null would break any older version of registry and not be backwards compatible. Therefore, the only solution at this point to fix stateless NiFi in its current state is to just set registryId to "1" if it is null. I believe this code is still probably prototype being worked and evolving, so this will be a temporary fix until those mandates are in place on a concept of "registryId". [~markap14] was (Author: JIRAUSER299049): Okay, so after some back and forth here is my final conclusion to this bug: I've submitted two PRs [https://github.com/apache/nifi/pull/8572/checks] <-- for support/1.x branch [https://github.com/apache/nifi/pull/8536/checks] <-- for main branch Here is what's happening. If you run a versioned stateless flow that has sub-versioned progress group, there is a NullPointerException thrown on the build method of StandardVersionControlInformation where there is a non-null requirement on "registryId". Code has changed in main versus support/1.x, but the bug exists on both. What I've found is the JerseyClient calls that are made to map the response from the registry-api back to the higher level VersionedProcessGroup -> VersionedFlowCoordinates both return JSON where the VersionedFlowCoordinates > registryId is always null. Now in the main branch, stateless uses some of these new "synchronizer" classes, so the best place to insert a solution is to add an else on the null check where the code runs the "determineRegistryId" method and set the value to "1" for versioned flows that do not have a registryId associated to them. Doing this passes all of the integration tests and code checks and fixes the bug. Since this class does not exist in the 1.x support branch, my best solution is to just comment out the null check (this breaks integration tests in main, but not in 1.x). I continued to look further at this idea of a "registryId" within the registry api code. The GET method on buckets/flow/version returns the same class that the stateless code uses to map into on the JerseyClient call. I then looked at the api code to POST new versioned flows, and it also expect the json as a parameter to match the same class. Well, since there is no "non-null" requirement on the registryId, versioned flows are stored in the database (or whichever storage adapter used) with this property as null. I did not check to see if the latest NiFi Registry UI is now setting this property, but making it non-null would break any older version of registry and not be backwards compatible. Therefore, the only solution at this point to fix stateless NiFi in its current state is to just set registryId to
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) ** Counter table has extra unnecessary can modify check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * Handle linking to components that are not on the canvas * PG Version (NIFI-12963) ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build (NIFI-12941) * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) ** Policies ** Status History * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Theme docs, view flow file, and custom ui's * Prompt user to save Parameter Context when Edit form is dirty * Upgrade to Angular 17 (NIFI-12790) * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu * Migrate NiFi UI to nx (NIFI-12940) *
[jira] [Created] (NIFI-12963) Process Group Versioning
Rob Fellows created NIFI-12963: -- Summary: Process Group Versioning Key: NIFI-12963 URL: https://issues.apache.org/jira/browse/NIFI-12963 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Rob Fellows Assignee: Rob Fellows -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12959: Support loading python processors from NARs [nifi]
markap14 commented on PR #8573: URL: https://github.com/apache/nifi/pull/8573#issuecomment-2022845935 @dan-s1 thanks great catch. I removed some carrige-return-newline combos in that file and my IDE did something I didn't expect :) Fixed that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12918 Fix Stateless NullPointerException on versioned sub-process groups - main branch [nifi]
slambrose commented on PR #8536: URL: https://github.com/apache/nifi/pull/8536#issuecomment-2022845523 Okay, so after some back and forth here is my final conclusion to this bug: I've submitted two PRs https://github.com/apache/nifi/pull/8572/checks <-- for support/1.x branch https://github.com/apache/nifi/pull/8536/checks <-- for main branch Here is what's happening. If you run a versioned stateless flow that has sub-versioned progress group, there is a NullPointerException thrown on the build method of StandardVersionControlInformation where there is a non-null requirement on "registryId". Code has changed in main versus support/1.x, but the bug exists on both. What I've found is the JerseyClient calls that are made to map the response from the registry-api back to the higher level VersionedProcessGroup -> VersionedFlowCoordinates both return JSON where the VersionedFlowCoordinates > registryId is always null. Now in the main branch, stateless uses some of these new "synchronizer" classes, so the best place to insert a solution is to add an else on the null check where the code runs the "determineRegistryId" method and set the value to "1" for versioned flows that do not have a registryId associated to them. Doing this passes all of the integration tests and code checks and fixes the bug. Since this class does not exist in the 1.x support branch, my best solution is to just comment out the null check (this breaks integration tests in main, but not in 1.x). I continued to look further at this idea of a "registryId" within the registry api code. The GET method on buckets/flow/version returns the same class that the stateless code uses to map into on the JerseyClient call. I then looked at the api code to POST new versioned flows, and it also expect the json as a parameter to match the same class. Well, since there is no "non-null" requirement on the registryId, versioned flows are stored in the database (or whichever storage adapter used) with this property as null. I did not check to see if the latest NiFi Registry UI is now setting this property, but making it non-null would break any older version of registry and not be backwards compatible. Therefore, the only solution at this point to fix stateless NiFi in its current state is to just set registryId to "1" if it is null. I believe this code is still probably prototype being worked and evolving, so this will be a temporary fix until those mandates are in place on a concept of "reg istryId". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12918 Fix Stateless NullPointerException on versioned sub-process groups - 1.x support branch [nifi]
slambrose commented on PR #8572: URL: https://github.com/apache/nifi/pull/8572#issuecomment-2022844115 Okay, so after some back and forth here is my final conclusion to this bug: I've submitted two PRs https://github.com/apache/nifi/pull/8572/checks <-- for support/1.x branch https://github.com/apache/nifi/pull/8536/checks <-- for main branch Here is what's happening. If you run a versioned stateless flow that has sub-versioned progress group, there is a NullPointerException thrown on the build method of StandardVersionControlInformation where there is a non-null requirement on "registryId". Code has changed in main versus support/1.x, but the bug exists on both. What I've found is the JerseyClient calls that are made to map the response from the registry-api back to the higher level VersionedProcessGroup -> VersionedFlowCoordinates both return JSON where the VersionedFlowCoordinates > registryId is always null. Now in the main branch, stateless uses some of these new "synchronizer" classes, so the best place to insert a solution is to add an else on the null check where the code runs the "determineRegistryId" method and set the value to "1" for versioned flows that do not have a registryId associated to them. Doing this passes all of the integration tests and code checks and fixes the bug. Since this class does not exist in the 1.x support branch, my best solution is to just comment out the null check (this breaks integration tests in main, but not in 1.x). I continued to look further at this idea of a "registryId" within the registry api code. The GET method on buckets/flow/version returns the same class that the stateless code uses to map into on the JerseyClient call. I then looked at the api code to POST new versioned flows, and it also expect the json as a parameter to match the same class. Well, since there is no "non-null" requirement on the registryId, versioned flows are stored in the database (or whichever storage adapter used) with this property as null. I did not check to see if the latest NiFi Registry UI is now setting this property, but making it non-null would break any older version of registry and not be backwards compatible. Therefore, the only solution at this point to fix stateless NiFi in its current state is to just set registryId to "1" if it is null. I believe this code is still probably prototype being worked and evolving, so this will be a temporary fix until those mandates are in place on a concept of "reg istryId". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12918) Stateless NiFi NullPointerException on versioned PGs
[
https://issues.apache.org/jira/browse/NIFI-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831362#comment-17831362
]
Stephanie Ambrose commented on NIFI-12918:
--
Okay, so after some back and forth here is my final conclusion to this bug:
I've submitted two PRs
[https://github.com/apache/nifi/pull/8572/checks] <-- for support/1.x branch
[https://github.com/apache/nifi/pull/8536/checks] <-- for main branch
Here is what's happening. If you run a versioned stateless flow that has
sub-versioned progress group, there is a NullPointerException thrown on the
build method of StandardVersionControlInformation where there is a non-null
requirement on "registryId".
Code has changed in main versus support/1.x, but the bug exists on both. What
I've found is the JerseyClient calls that are made to map the response from the
registry-api back to the higher level VersionedProcessGroup ->
VersionedFlowCoordinates both return JSON where the VersionedFlowCoordinates >
registryId is always null. Now in the main branch, stateless uses some of these
new "synchronizer" classes, so the best place to insert a solution is to add an
else on the null check where the code runs the "determineRegistryId" method and
set the value to "1" for versioned flows that do not have a registryId
associated to them. Doing this passes all of the integration tests and code
checks and fixes the bug. Since this class does not exist in the 1.x support
branch, my best solution is to just comment out the null check (this breaks
integration tests in main, but not in 1.x).
I continued to look further at this idea of a "registryId" within the registry
api code. The GET method on buckets/flow/version returns the same class that
the stateless code uses to map into on the JerseyClient call. I then looked at
the api code to POST new versioned flows, and it also expect the json as a
parameter to match the same class. Well, since there is no "non-null"
requirement on the registryId, versioned flows are stored in the database (or
whichever storage adapter used) with this property as null. I did not check to
see if the latest NiFi Registry UI is now setting this property, but making it
non-null would break any older version of registry and not be backwards
compatible. Therefore, the only solution at this point to fix stateless NiFi in
its current state is to just set registryId to "1" if it is null. I believe
this code is still probably prototype being worked and evolving, so this will
be a temporary fix until those mandates are in place on a concept of
"registryId".
> Stateless NiFi NullPointerException on versioned PGs
>
>
> Key: NIFI-12918
> URL: https://issues.apache.org/jira/browse/NIFI-12918
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Stephanie Ambrose
>Assignee: Stephanie Ambrose
>Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> If you create a process group and commit that to version control, and then
> add a sub-process group under that one and commit that to its own version
> control, it will throw a NullPointerException:
> *NOTE: This error only occurs for stateless nifi processing.*
> {code:java}
> 2024-03-15T12:25:38.565156967Z 2024-03-15 12:25:38,564 INFO [main]
> o.a.nifi.groups.StandardProcessGroup
> StandardProcessGroup[identifier=9688e64b-3f4a-3668-81b9-e25d9ea61454,name=Sub
> Group] added to StandardProcessGroup[identifier=stateless-flow,name=Test Flow]
> 2024-03-15T12:25:38.570693223Z Exception in thread "main"
> java.lang.NullPointerException: Registry ID must be specified
> at java.base/java.util.Objects.requireNonNull(Unknown Source)
> 2024-03-15T12:25:38.570722016Zat
> org.apache.nifi.registry.flow.StandardVersionControlInformation$Builder.build(StandardVersionControlInformation.java:134)
> 2024-03-15T12:25:38.570725111Zat
> org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:354)
> 2024-03-15T12:25:38.570729455Zat
> org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.addProcessGroup(StandardVersionedComponentSynchronizer.java:1185)
> at
> org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronizeChildGroups(StandardVersionedComponentSynchronizer.java:528)
> 2024-03-15T12:25:38.573083029Zat
> org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:426)
> 2024-03-15T12:25:38.573086447Zat
> org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.lambda$synchronize$0(StandardVersionedComponentSynchronizer.java:265)
> 2024-03-15T12:25:38.573092747Zat
>
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) ** Counter table has extra unnecessary can modify check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * Handle linking to components that are not on the canvas * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) ** Policies ** Status History * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Theme docs, view flow file, and custom ui's * Prompt user to save Parameter Context when Edit form is dirty * Upgrade to Angular 17 (NIFI-12790) * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu * Migrate NiFi UI to nx (NIFI-12940) * Migrate from Karma tests to Jest
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) ** Counter table has extra unnecessary can modify check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * Handle linking to components that are not on the canvas * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build (NIFI-12941) * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) ** Policies ** Status History * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Theme docs, view flow file, and custom ui's * Prompt user to save Parameter Context when Edit form is dirty * Upgrade to Angular 17 (NIFI-12790) * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu * Migrate NiFi UI to nx (NIFI-12940) * Migrate from Karma
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) ** Counter table has extra unnecessary can modfiy check * Bulletin Board (NIFI-12560) ** When the bulletin board polls it is missing the offset "after" query parameter * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * Handle linking to components that are not on the canvas * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) ** Policies ** Status History * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Theme docs, view flow file, and custom ui's * Prompt user to save Parameter Context when Edit form is dirty * Upgrade to Angular 17 (NIFI-12790) * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu * Migrate NiFi UI to nx (NIFI-12940) * Migrate from
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) ** Counter table has extra unnecessary can modfiy check * Bulletin Board (NIFI-12560) ** When the bulletin board polls it is missing the offset "after" query parameter * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * Handle linking to components that are not on the canvas * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) ** Policies ** Status History * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Theme docs, view flow file, and custom ui's * Prompt user to save Parameter Context when Edit form is dirty * Upgrade to Angular 17 (NIFI-12790) * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu * Migrate NiFi UI to nx (NIFI-12940) *
[jira] [Updated] (NIFI-12948) UI - Address minor bugs discovered during Angular migration
[ https://issues.apache.org/jira/browse/NIFI-12948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12948: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > UI - Address minor bugs discovered during Angular migration > --- > > Key: NIFI-12948 > URL: https://issues.apache.org/jira/browse/NIFI-12948 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > When migrating to Angular 17 and reviewing the control flow changes a handful > a bugs were discovered. This Jira is to address each of them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12959: Support loading python processors from NARs [nifi]
pvillard31 commented on PR #8573: URL: https://github.com/apache/nifi/pull/8573#issuecomment-2022800770 Yeah, I must admit that I tried to figure out a way to use ParseDocument with NiFi in a container and I didn't manage to find a clean way to bring Tesseract into it. I feel like it would probably be easier to have it as a side container or something but I didn't find a way to piece everything together so I was naively (without too much hopes) thinking that this improvement may help :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12945) Upgrade Commons Configuration and Guava Transitive Dependencies
[ https://issues.apache.org/jira/browse/NIFI-12945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12945: -- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Commons Configuration and Guava Transitive Dependencies > --- > > Key: NIFI-12945 > URL: https://issues.apache.org/jira/browse/NIFI-12945 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > Recent upgrades to Apache Commons Configuration 2.10.1 and should be > propagated to transitive dependencies in several extension modules. The > extension modules with transitive dependencies include Hadoop and Hive > components. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12945) Upgrade Commons Configuration and Guava Transitive Dependencies
[ https://issues.apache.org/jira/browse/NIFI-12945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831358#comment-17831358 ] ASF subversion and git services commented on NIFI-12945: Commit 8e0b83b0256addd25348eff2ab0dcd4d692f1fdb in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8e0b83b025 ] NIFI-12945 Moved Commons Configuration 2.10.1 to shared version - Moved Commons Configuration from nifi-lookup-services to project configuration - Moved Google Guava version from nifi-hive-test-utils to nifi-hive-bundle Signed-off-by: Pierre Villard This closes #8560. > Upgrade Commons Configuration and Guava Transitive Dependencies > --- > > Key: NIFI-12945 > URL: https://issues.apache.org/jira/browse/NIFI-12945 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Recent upgrades to Apache Commons Configuration 2.10.1 and should be > propagated to transitive dependencies in several extension modules. The > extension modules with transitive dependencies include Hadoop and Hive > components. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12945 Move Commons Configuration 2.10.1 to shared version [nifi]
asfgit closed pull request #8560: NIFI-12945 Move Commons Configuration 2.10.1 to shared version URL: https://github.com/apache/nifi/pull/8560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12959: Support loading python processors from NARs [nifi]
markap14 commented on PR #8573: URL: https://github.com/apache/nifi/pull/8573#issuecomment-2022733504 @pvillard31 no, it wouldn't really help there. The issue there is that a native library like Tesseract would need to be compiled for the correct OS and architecture. So in order to include that, we'd need to include many copies of the library. And currently, we do not set any sort of environment variables telling it to search for native libraries in the NAR's unpacked directory. It might be worth exploring as a future improvement, though. Even though it may not help for something like ParseDocument, it might be helpful at least for custom nars, where perhaps you know that you're only going to run in containers or on a specific architecture/os so you can include the appropriate library for the custom nar? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12925 disallow TRACE and OPTIONS methods in ListenHTTP [nifi]
markobean commented on PR #8548: URL: https://github.com/apache/nifi/pull/8548#issuecomment-2022717954 Thanks @exceptionfactory for the merge and @dan-s1 for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2320) MergeContent busy loop when MaxBinAge is set
Martin Zink created MINIFICPP-2320: -- Summary: MergeContent busy loop when MaxBinAge is set Key: MINIFICPP-2320 URL: https://issues.apache.org/jira/browse/MINIFICPP-2320 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Martin Zink Assignee: Martin Zink -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2320) MergeContent busy loop when MaxBinAge is set
[ https://issues.apache.org/jira/browse/MINIFICPP-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-2320: --- Priority: Blocker (was: Major) > MergeContent busy loop when MaxBinAge is set > > > Key: MINIFICPP-2320 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2320 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Blocker > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12959: Support loading python processors from NARs [nifi]
pvillard31 commented on PR #8573: URL: https://github.com/apache/nifi/pull/8573#issuecomment-2022389088 Nice improvement Mark! Would this approach help with a processor like ParseDocument where Tesseract has to be installed on the node first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12955) Update Dependency Check Suppressions
[ https://issues.apache.org/jira/browse/NIFI-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12955: -- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Update Dependency Check Suppressions > > > Key: NIFI-12955 > URL: https://issues.apache.org/jira/browse/NIFI-12955 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > The OWASP Dependency Check suppressions configuration includes a number of > items that no longer apply based on library upgrades and improvements to the > scanner itself. Unused suppressions should be removed and others should be > added as needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12955 Update OWASP Dependency Check Suppressions [nifi]
asfgit closed pull request #8570: NIFI-12955 Update OWASP Dependency Check Suppressions URL: https://github.com/apache/nifi/pull/8570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12955) Update Dependency Check Suppressions
[ https://issues.apache.org/jira/browse/NIFI-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831253#comment-17831253 ] ASF subversion and git services commented on NIFI-12955: Commit 358e4cb4512ba12f7168e45329e40177897c6669 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=358e4cb451 ] NIFI-12955 Updated OWASP Dependency Check Suppressions - Removed unused suppressions - Added suppressions for Clojure and Hadoop shaded libraries Signed-off-by: Pierre Villard This closes #8570. > Update Dependency Check Suppressions > > > Key: NIFI-12955 > URL: https://issues.apache.org/jira/browse/NIFI-12955 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The OWASP Dependency Check suppressions configuration includes a number of > items that no longer apply based on library upgrades and improvements to the > scanner itself. Unused suppressions should be removed and others should be > added as needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12957) Upgrade Azure SDK BOM to 1.2.21
[ https://issues.apache.org/jira/browse/NIFI-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831252#comment-17831252 ] ASF subversion and git services commented on NIFI-12957: Commit ce38c9769e51e12f10b5e03e02c081a93d8e in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ce38c9769e ] NIFI-12957 Upgraded Azure SDK BOM from 1.2.19 to 1.2.21 - Upgraded MSAL4J from 1.14.2 to 1.14.3 Signed-off-by: Pierre Villard This closes #8571. > Upgrade Azure SDK BOM to 1.2.21 > --- > > Key: NIFI-12957 > URL: https://issues.apache.org/jira/browse/NIFI-12957 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Labels: backport-needed > Time Spent: 20m > Remaining Estimate: 0h > > The Azure SDK BOM dependency should be upgraded to > [1.2.21|https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/boms/azure-sdk-bom/CHANGELOG.md] > to incorporate the latest set of Azure libraries. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12957) Upgrade Azure SDK BOM to 1.2.21
[ https://issues.apache.org/jira/browse/NIFI-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12957: -- Fix Version/s: 2.0.0-M3 1.26.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Azure SDK BOM to 1.2.21 > --- > > Key: NIFI-12957 > URL: https://issues.apache.org/jira/browse/NIFI-12957 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Labels: backport-needed > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The Azure SDK BOM dependency should be upgraded to > [1.2.21|https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/boms/azure-sdk-bom/CHANGELOG.md] > to incorporate the latest set of Azure libraries. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12957 Upgrade Azure SDK BOM from 1.2.19 to 1.2.21 [nifi]
asfgit closed pull request #8571: NIFI-12957 Upgrade Azure SDK BOM from 1.2.19 to 1.2.21 URL: https://github.com/apache/nifi/pull/8571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12962) Upgrade Spring Framework to 6.1.5
[ https://issues.apache.org/jira/browse/NIFI-12962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831249#comment-17831249 ] ASF subversion and git services commented on NIFI-12962: Commit 3bed30e9dba3712b52506430b74db84a8171589e in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3bed30e9db ] NIFI-12962 Upgraded Spring Framework from 6.0.18 to 6.1.5 - Enabled parameter names for reflection in nifi-web-api to support AspectJ Around expression parsing Signed-off-by: Pierre Villard This closes #8575. > Upgrade Spring Framework to 6.1.5 > - > > Key: NIFI-12962 > URL: https://issues.apache.org/jira/browse/NIFI-12962 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 10m > Remaining Estimate: 0h > > Spring Framework dependencies should be upgraded to > [6.1.5|https://github.com/spring-projects/spring-framework/releases/tag/v6.1.5] > to align both NiFi and NiFi Registry on the same version. > Spring 6.1.0 introduced changes in AspectJ annotation expression parsing, > resulting in test failures for Auditor classes. Enabling parameters during > Java compilation as described in [explicit argument > names|https://docs.spring.io/spring-framework/reference/core/aop/ataspectj/advice.html#aop-ataspectj-advice-params-names-explicit] > documentation for Spring Framework resolves expression parsing and allows > the AspectJ annotations to work without changes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12957) Upgrade Azure SDK BOM to 1.2.21
[ https://issues.apache.org/jira/browse/NIFI-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831250#comment-17831250 ] ASF subversion and git services commented on NIFI-12957: Commit daad0720b1a10cb21dcd5c4f0e9672b5a4bc5b02 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=daad0720b1 ] NIFI-12957 Upgraded Azure SDK BOM from 1.2.19 to 1.2.21 - Upgraded MSAL4J from 1.14.2 to 1.14.3 Signed-off-by: Pierre Villard This closes #8571. > Upgrade Azure SDK BOM to 1.2.21 > --- > > Key: NIFI-12957 > URL: https://issues.apache.org/jira/browse/NIFI-12957 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > The Azure SDK BOM dependency should be upgraded to > [1.2.21|https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/boms/azure-sdk-bom/CHANGELOG.md] > to incorporate the latest set of Azure libraries. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12962) Upgrade Spring Framework to 6.1.5
[ https://issues.apache.org/jira/browse/NIFI-12962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12962: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Spring Framework to 6.1.5 > - > > Key: NIFI-12962 > URL: https://issues.apache.org/jira/browse/NIFI-12962 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > Spring Framework dependencies should be upgraded to > [6.1.5|https://github.com/spring-projects/spring-framework/releases/tag/v6.1.5] > to align both NiFi and NiFi Registry on the same version. > Spring 6.1.0 introduced changes in AspectJ annotation expression parsing, > resulting in test failures for Auditor classes. Enabling parameters during > Java compilation as described in [explicit argument > names|https://docs.spring.io/spring-framework/reference/core/aop/ataspectj/advice.html#aop-ataspectj-advice-params-names-explicit] > documentation for Spring Framework resolves expression parsing and allows > the AspectJ annotations to work without changes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12962 Upgrade Spring Framework from 6.0.18 to 6.1.5 [nifi]
asfgit closed pull request #8575: NIFI-12962 Upgrade Spring Framework from 6.0.18 to 6.1.5 URL: https://github.com/apache/nifi/pull/8575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]
balazsgerner commented on code in PR #8544:
URL: https://github.com/apache/nifi/pull/8544#discussion_r1540709931
##
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java:
##
@@ -160,6 +170,14 @@ public class PutHDFS extends AbstractHadoopProcessor {
.allowableValues(WRITE_AND_RENAME_AV, SIMPLE_WRITE_AV)
.build();
+public static final PropertyDescriptor APPEND_MODE = new
PropertyDescriptor.Builder()
+.name("Append mode")
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
