Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114137427
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -538,14 +561,62 @@ void YamlConfiguration::parsePropertiesNodeYaml(
std
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
@apiri Issues experience by @brosander appear to be solved with
https://github.com/phrocker/nifi-minifi-cpp/tree/minifi-274-jsoncpp. The top
two commits are the necessary commits. Feel free
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114792218
--- Diff: libminifi/include/core/Processor.h ---
@@ -243,7 +244,7 @@ class Processor : public Connectable, public
ConfigurableComponent,
std
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114792714
--- Diff: libminifi/src/io/ClientSocket.cpp ---
@@ -39,7 +40,7 @@ namespace io {
char *Socket::HOSTNAME =
const_cast<char*>(
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114793189
--- Diff: libminifi/src/io/tls/TLSSocket.cpp ---
@@ -31,14 +32,11 @@ namespace nifi {
namespace minifi {
namespace io {
-std
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118527482
--- Diff: libminifi/test/TestBase.h ---
@@ -21,35 +21,104 @@
#include
#include
#include
+#include
#include
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118496711
--- Diff: libminifi/include/Site2SitePeer.h ---
@@ -72,8 +73,8 @@ class Site2SitePeer : public
org::apache::nifi::minifi::io::BaseStream
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/105
MINIFI-327: Clarify libcurl install instructions.
Ensure we mention that users must install and link curl with OpenSSL
Thank you for submitting a contribution to Apache NiFi
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/104
@brosander yeah I think an atomic would solve the problem.
yeah, I think the pattern would be cool.
---
If your project is set up for it, you can reply to this email and have
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/104
This is good stuff. I'm taking a look
General comments before I dive in. Did we lose the ability to change the
logger format real time? If there was an issue in production and we
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118500266
--- Diff: libminifi/include/core/logging/LoggerConfiguration.h ---
@@ -0,0 +1,147 @@
+/**
+ * @file LoggerConfiguration.h
+ * Logger
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118524108
--- Diff: libminifi/include/utils/StringUtils.h ---
@@ -89,6 +89,25 @@ class StringUtils {
s.end());
return s
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118497254
--- Diff: conf/minifi-log.properties ---
@@ -0,0 +1,42 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118527831
--- Diff: libminifi/test/TestBase.h ---
@@ -21,35 +21,104 @@
#include
#include
#include
+#include
#include
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118497504
--- Diff: libminifi/include/core/controller/ControllerService.h ---
@@ -64,7 +64,7 @@ class ControllerService : public ConfigurableComponent
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/108
MINIFI-329: Ensure boolean value is checked before creating a secure â¦
â¦socket
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r120232599
--- Diff: libminifi/src/FlowController.cpp ---
@@ -175,7 +211,7 @@ void FlowController::stop(bool force) {
this->flow_file_repo_-&g
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/111
MINIFI-331: Apply formatter with increased line length to source
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r120234911
--- Diff: libminifi/src/FlowController.cpp ---
@@ -163,6 +174,31 @@ FlowController::~FlowController() {
provenance_repo_ = nullptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r120233311
--- Diff: libminifi/src/ConfigurationListener.cpp ---
@@ -0,0 +1,130 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r120235144
--- Diff: libminifi/src/FlowController.cpp ---
@@ -163,6 +174,31 @@ FlowController::~FlowController() {
provenance_repo_ = nullptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/107#discussion_r120234097
--- Diff: libminifi/src/FlowController.cpp ---
@@ -163,6 +174,31 @@ FlowController::~FlowController() {
provenance_repo_ = nullptr
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/133
@minifirocks Can you rebase against master? Your commits have unrelated
content.
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r139699391
--- Diff: libminifi/include/c2/C2Payload.h ---
@@ -0,0 +1,187 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r139696520
--- Diff: libminifi/include/FlowController.h ---
@@ -158,7 +176,7 @@ class FlowController : public
core::controller::ControllerServiceProvider
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r139694071
--- Diff: libminifi/include/FlowController.h ---
@@ -124,14 +123,33 @@ class FlowController : public
core::controller::ControllerServiceProvider
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r139702066
--- Diff: libminifi/include/core/Processor.h ---
@@ -153,7 +154,8 @@ class Processor : public Connectable, public
ConfigurableComponent, public
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/137
MINIFI-372: Replace leveldb with RocksDB
MINIFI-372: Update Cmake
MINIFI-372: Fix tests
MINIFI-372: Include deps
MINIFI-372: Rename data
MINIFI-372: Change cmake cxx flags
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/137
Just dawned on me that I missed editing the license filewill add that
shortly.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/134
@achristianson It slipped my mind but was hoping to get ideas on what to do
when we have an invalid c2 configuration. C2 is a local element too, so at some
point we'll have scripts
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/133
@minifirocks What did you use to open it? The procedure is the same, but
the interpretation of that data is not. Seems that we need to at least verify
that NiFi can interpret what we send it.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/133
@minifirocks I did have a question that popped up after I hit
approvewith the header and footer you're serializing the data directly. Did
you have any issues when opening those merged
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/133
@minifirocks thanks! I'll merge to master at some point today
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r139965480
--- Diff: libminifi/include/core/Processor.h ---
@@ -212,19 +217,35 @@ class Processor : public Connectable, public
ConfigurableComponent, public
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/137
@minifirocks I removed tests from being built, but did not remove the
source code. I think that's a good idea. I'll also remove the docs since they
aren't really necessary. Thanks!
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/137
Closing to make additional changes without the fear of it being merged.
---
Github user phrocker closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/137
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/143
MINIFICPP-254: Resolve odd naming of isRunning variable so that it's â¦
â¦clear we do not lock when we are running
Originally identified by Fredrick Stakem.
Thank you
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/142
MINIFI-372: Replace leveldb with RocksDB
MINIFI-372: Update Cmake
MINIFI-372: Fix tests
MINIFI-372: Include deps
MINIFI-372: Rename data
MINIFI-372: Change cmake cxx flags
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/142
@minifirocks and @jdye64 I've re-opened this since I found an issue that I
wanted to clean up in the previous PR
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/141#discussion_r142679677
--- Diff: cmake/BuildTests.cmake ---
@@ -88,7 +98,19 @@ FOREACH(testfile ${INTEGRATION_TESTS})
ENDFOREACH()
message("-- Finished bui
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/146#discussion_r143514354
--- Diff: libminifi/include/processors/MergeContent.h ---
@@ -125,6 +127,127 @@ class BinaryConcatenationMerge : public MergeBin
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/146#discussion_r143513518
--- Diff: libminifi/include/processors/MergeContent.h ---
@@ -125,6 +127,127 @@ class BinaryConcatenationMerge : public MergeBin
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/146#discussion_r143514069
--- Diff: extensions/http-curl/CMakeLists.txt ---
@@ -24,7 +24,7 @@ find_package(CURL REQUIRED)
set(CMAKE_EXE_LINKER_FLAGS "-Wl,--expor
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/146#discussion_r143514525
--- Diff: libminifi/src/processors/MergeContent.cpp ---
@@ -276,6 +287,46 @@ std::shared_ptr
BinaryConcatenationMerge::merge(core::ProcessCon
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/146#discussion_r143514729
--- Diff: libminifi/src/processors/MergeContent.cpp ---
@@ -276,6 +287,46 @@ std::shared_ptr
BinaryConcatenationMerge::merge(core::ProcessCon
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/146#discussion_r143513901
--- Diff: libminifi/include/processors/MergeContent.h ---
@@ -125,6 +127,127 @@ class BinaryConcatenationMerge : public MergeBin
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/146#discussion_r143758285
--- Diff: libminifi/src/processors/MergeContent.cpp ---
@@ -276,6 +287,46 @@ std::shared_ptr
BinaryConcatenationMerge::merge(core::ProcessCon
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/134
@achristianson MiNiFi adheres to a protocol defined by Garcon. I think we
should add documentation to the c2 server or Apache wiki ( or both ? ) and link
to it from here. In the interest
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137833409
--- Diff: CMakeLists.txt ---
@@ -35,6 +35,8 @@ ENDIF(POLICY CMP0048)
include(CheckCXXCompilerFlag)
CHECK_CXX_COMPILER_FLAG("-std=
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/134
@achristianson is the centos 7 a fresh build and did you install leveldb?
I've seen that error but when we installed leveldb the error went away and we
were able to run tests and ran about
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/134
@benqiu2016 , much like the response to @achristianson , were' adhering to
something that isn't published yet, so I'll pose the same question to you.
"I think we shoul
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137859201
--- Diff: libminifi/include/c2/C2Payload.h ---
@@ -0,0 +1,187 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137858594
--- Diff: libminifi/include/ResourceClaim.h ---
@@ -55,23 +58,20 @@ class ResourceClaim : public
std::enable_shared_from_this
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137862598
--- Diff: libminifi/include/c2/C2Payload.h ---
@@ -0,0 +1,187 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/133
@benqiu2016 I"m currently reviewing, but have yet to finish it, at which
point the comments will open up.
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134
MINIFI-339: Add C2 base allowing for 1 protocol and n heartbeat reporâ¦
â¦ters
MINIFI-339: Add GetTCP Processor
MINIFI-339: Add listener server
MINIFI-339: Update
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r136140985
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r136137946
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r137020354
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r137021281
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r137021454
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r137022742
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r137023241
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/133#discussion_r137022835
--- Diff: libminifi/include/processors/BinFiles.h ---
@@ -0,0 +1,295 @@
+/**
+ * @file BinFiles.h
+ * BinFiles class declaration
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/137
@achristianson I completely forgot that I made it. I readied this a while
ago and forgot I made this functionality, pleasantly surprised though! Thanks
I'll add some tests.
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/138
MINIFICPP-109: Add header guards for civetweb so users who don't haveâ¦
⦠pragma defs can build
Extracted from
https://github.com/KevinCalderone/civetweb/commit
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/137
I'm going to add a conditional check for RocksDB. If it is already
installed then we will not attempt to re-build it.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/137
@achristianson should be RepoTests. Additionally, many unit tests use
FlowFileRepository, which uses rocksdb the way that we do through all other
repos.
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/140
MINIFICPP-217: Resolve compilation failures within Bin files and mergâ¦
â¦e files test
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r141920195
--- Diff: libminifi/include/c2/C2Agent.h ---
@@ -0,0 +1,203 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/131
@calebj Thanks. I know some of us build with Ubuntu 14 and have run into
similar issues. If you submit a PR I'll spin up an instance, verify, and can
merge. Thanks!
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/131
@calebj sure! Can you tell me what distro you are building on?
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/141
Make libCuRL containing classes extensions.
MINIFI-215: Add conditional to HTTP-CURL
MINIFI-215: Update Readme
MINIFICPP-215: Udate tests and ensure extensions doc is up
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/131#discussion_r134802972
--- Diff: thirdparty/civetweb-1.9.1/src/civetweb.c ---
@@ -11856,7 +11859,24 @@ ssl_get_client_cert_info(struct mg_connection
*conn
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/129
MINIFI-375: Update integration test
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/131#discussion_r134278103
--- Diff: docker/Dockerfile ---
@@ -100,6 +100,10 @@ RUN mkdir -p $MINIFI_BASE_DIR
COPY --from=builder ${MINIFI_HOME} ${MINIFI_HOME}
RUN
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/131#discussion_r136576120
--- Diff: thirdparty/civetweb-1.9.1/src/civetweb.c ---
@@ -11856,7 +11859,24 @@ ssl_get_client_cert_info(struct mg_connection
*conn
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/132
merging shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/147
MINIFI-256: Resolve Putfile name and ensure that call backs over 1k tâ¦
â¦hat rely on the return code to be zero when finished receive zero
Thank you for submitting
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/141
Having new compilation issues in linux. Addressing now.
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/146#discussion_r144019540
--- Diff: extensions/http-curl/CMakeLists.txt ---
@@ -24,7 +24,7 @@ find_package(CURL REQUIRED)
set(CMAKE_EXE_LINKER_FLAGS "-Wl,--expor
Github user phrocker closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/147
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r146259050
--- Diff: libminifi/include/core/ProcessSessionReadCallback.h ---
@@ -0,0 +1,33 @@
+#ifndef __PROCESS_SESSION_READ_CALLBACK_H__
--- End
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj One minor change RE the license header for
ProcessSessionReadCallback. Assuming @apiri is good, we can merge. I'm going to
make a follow on to break these archive classes
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/150
MINIFI-372: Resolve issues with missed commits
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/151
@minifirocks Can you provide some context regarding "the seek issue in
stream?"
I only see that you changed the variable from a uint64_t to a uint32_t.
This reduce
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/170#discussion_r150220088
--- Diff: .travis.yml ---
@@ -84,4 +84,4 @@ matrix:
- package='libpng'; [[ $(brew ls --versions ${package}) ]] && {
brew
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/186#discussion_r151273283
--- Diff: libminifi/include/core/ContentRepository.h ---
@@ -63,10 +63,13 @@ class ContentRepository : public
StreamManager {
remove
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/187
MINIFICPP-305: remove Boost from BuildTests
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/206
@calebj There was a commit to resolve it on my rhel7 platform. This was
merged before that could be added ( once I saw Travis ) -- I put that commit
within https://github.com/apache/nifi
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/208
MINIFICPP-325: Up semantic version
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/168#discussion_r153562525
--- Diff: .travis.yml ---
@@ -21,7 +21,7 @@ cache:
timeout: 300
env:
- CMAKE_BUILD_OPTIONS="-DENABLE_PCAP
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/157#discussion_r153563171
--- Diff: CMakeLists.txt ---
@@ -173,6 +173,12 @@ if (ENABLE_TENSORFLOW)
createExtension(TENSORFLOW-EXTENSIONS "TENSORFLOW EXTEN
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/185
CMake Error at
/usr/local/Cellar/cmake/3.10.0/share/cmake/Modules/WriteBasicConfigVersionFile.cmake:40
(message):
No VERSION specified for WRITE_BASIC_CONFIG_VERSION_FILE()
Call
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/157#discussion_r153616882
--- Diff: CMakeLists.txt ---
@@ -173,6 +173,12 @@ if (ENABLE_TENSORFLOW)
createExtension(TENSORFLOW-EXTENSIONS "TENSORFLOW EXTEN
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/157#discussion_r153585936
--- Diff: CMakeLists.txt ---
@@ -173,6 +173,12 @@ if (ENABLE_TENSORFLOW)
createExtension(TENSORFLOW-EXTENSIONS "TENSORFLOW EXTEN
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/157
@calebj change your root env in travis to be
- CMAKE_BUILD_OPTIONS="-DENABLE_PCAP=TRUE -DENABLE_BUSTACHE=TRUE"
Unless this is a linux only extension. Is it?
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/206
MINIFICPP-320: Change Processors to be within their own linked object
This will facilitate the eventual move and documentation that follows
enabling a processor module.
Thank
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/205
MINIFICPP-319: Resolve missing licenses
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
301 - 400 of 1063 matches
Mail list logo
