[GitHub] nifi-minifi-cpp pull request #264: Minificpp 400

2018-02-15 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/264 Minificpp 400 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi-minifi-cpp issue #260: MINIFICPP-382: Implement SUSE release support fo...

2018-02-15 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/260 @apiri I made an update to the readme last night. https://github.com/apache/nifi-minifi-cpp/pull/260/commits/7a3e81066c007053adc77a315f490e44671cbd34 ---

[GitHub] nifi-minifi-cpp pull request #266: MINIFICPP-407: Update readme to clarify t...

2018-02-20 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/266 MINIFICPP-407: Update readme to clarify that we use semver and will n… …ot break api and abi compatibility Thank you for submitting a contribution to Apache NiFi - MiNiFi C

[GitHub] nifi-minifi-cpp issue #267: MINIFICPP-409 Removing unused constants relating...

2018-02-20 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/267 +1 pending travis successdoh ---

[GitHub] nifi-minifi-cpp pull request #265: MINIFICPP-406: Ensure that Context Servic...

2018-02-19 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/265 MINIFICPP-406: Ensure that Context Service OR minifi properties can b… …e used to configure secure comms ( HTTP & Socket) Thank you for submitting a contribu

[GitHub] nifi-minifi-cpp issue #265: MINIFICPP-406: Ensure that Context Service OR mi...

2018-02-20 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/265 Adding https://issues.apache.org/jira/browse/MINIFICPP-408 to this ---

[GitHub] nifi-minifi-cpp pull request #225: MINIFICPP-356: Switch site to site API UR...

2017-12-21 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/225 MINIFICPP-356: Switch site to site API URL from the 0.x endpoint to s… …ite-to-site Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order

[GitHub] nifi-minifi-cpp issue #224: MINIFICPP-344 Added initial implementation of TF...

2018-01-02 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/224 reviewing ---

[GitHub] nifi-minifi-cpp pull request #383: MINIFICPP-582: Add constraints for gcc in...

2018-08-01 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/383#discussion_r206940228 --- Diff: linux.sh --- @@ -0,0 +1,40 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] nifi-minifi-cpp pull request #387: MINIFICPP-583: Allow Expression language ...

2018-08-03 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/387 MINIFICPP-583: Allow Expression language to compile if CURL is disabl… …ed while also honoring the request to disable CURL functionality Thank you for submitting

[GitHub] nifi-minifi-cpp issue #360: MINIFICPP-427 - add PublishKafka headers support

2018-07-30 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/360 @dtrodrigues thanks for pointing out the readme update for bustache. I'll add that via MINIFICPP-582 and merge this. ---

[GitHub] nifi-minifi-cpp pull request #383: Minificpp 582

2018-07-30 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/383 Minificpp 582 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi-minifi-cpp issue #360: MINIFICPP-427 - add PublishKafka headers support

2018-07-29 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/360 @dtrodrigues Cool, I'll take a look at the changes tomorrow. I'll probably just make a follow on ticket for the bootstrap and merge if everything else looks good. Thanks ---

[GitHub] nifi-minifi-cpp pull request #360: MINIFICPP-427 - add PublishKafka headers ...

2018-07-27 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r205800065 --- Diff: extensions/librdkafka/PublishKafka.h --- @@ -28,6 +28,7 @@ #include "core/Property.h" #include &qu

[GitHub] nifi-minifi-cpp pull request #384: MINIFICPP-586: Move Hashbangs to first li...

2018-07-31 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/384 MINIFICPP-586: Move Hashbangs to first line of file Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we

[GitHub] nifi-minifi-cpp pull request #388: MINIFICPP-590: Fix zero length files at s...

2018-08-04 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/388 MINIFICPP-590: Fix zero length files at startup MINIFICPP-589: Institute regex filtering for interfaces MINIFICPP-589: Limit Pcap to 4.9.4+ Thank you for submitting

[GitHub] nifi-minifi-cpp issue #388: MINIFICPP-590: Fix zero length files at startup

2018-08-04 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/388 Did not experience issue noted in MINIFICPP-590. The only issue were zero length files at predictable times due to memory collisions. Batching appears to work as designed. ---

[GitHub] nifi-minifi-cpp pull request #383: MINIFICPP-582: Add constraints for gcc in...

2018-08-01 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/383#discussion_r206953865 --- Diff: linux.sh --- @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] nifi-minifi-cpp pull request #347: MINIFIPP-514 Incorporated regex property ...

2018-07-25 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/347#discussion_r205109263 --- Diff: extensions/http-curl/processors/InvokeHTTP.cpp --- @@ -65,7 +65,13 @@ core::Property InvokeHTTP::FollowRedirects("Follow Redi

[GitHub] nifi-minifi-cpp issue #381: MINIFICPP-573: Remove lower level build informat...

2018-07-25 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/381 @achristianson Ah those pieces were recently added with the intention that they *may* be removed to facilitate SIT in a docker container, which is not part of this build. As a result

[GitHub] nifi-minifi-cpp pull request #388: MINIFICPP-590: Fix zero length files at s...

2018-08-06 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/388#discussion_r208027287 --- Diff: extensions/pcap/CapturePacket.cpp --- @@ -54,13 +54,15 @@ namespace processors { std::shared_ptr CapturePacket::id_generator_

[GitHub] nifi-minifi-cpp pull request #388: MINIFICPP-590: Fix zero length files at s...

2018-08-06 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/388#discussion_r208026845 --- Diff: extensions/pcap/CapturePacket.cpp --- @@ -54,13 +54,15 @@ namespace processors { std::shared_ptr CapturePacket::id_generator_

[GitHub] nifi-minifi-cpp issue #389: MINIFICPP-592: Update RPG to fall back when cURL...

2018-08-06 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/389 MINIFICPP-593 was created to facilitate docker testing. Happy to merge that effort into this one. I don't like the lack of testing but we can't really do this type of test without some

[GitHub] nifi-minifi-cpp issue #388: MINIFICPP-590: Fix zero length files at startup

2018-08-06 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/388 @apiri also created https://issues.apache.org/jira/browse/MINIFICPP-594 since I think the documentation was created after the CapturePacket processor. Happy to combine the PRs if you

[GitHub] nifi-minifi-cpp pull request #389: MINIFICPP-592: Update RPG to fall back wh...

2018-08-06 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/389 MINIFICPP-592: Update RPG to fall back when cURL is not enable MINIFICPP-593 was created to facilitate some docker testing. Thank you for submitting a contribution to Apache

[GitHub] nifi-minifi-cpp issue #391: MINIFICPP-597 Convert error log statement to inf...

2018-08-15 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/391 will merge. ---

[GitHub] nifi-minifi-cpp pull request #390: MINIFICPP-594: Add CapturePacket to Proce...

2018-08-07 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/390 MINIFICPP-594: Add CapturePacket to Processors documentation MINIFICPP-590: Update boolean to not keep source PCAP -- done in testing for MINIFICPP-590 fix. Thank you

[GitHub] nifi-minifi-cpp pull request #392: MINIFICPP-598: Add relationship support i...

2018-08-20 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/392 MINIFICPP-598: Add relationship support into manifest MINIFICPP-600: Add default value into property descriptors Thank you for submitting a contribution to Apache NiFi - MiNiFi C

[GitHub] nifi-minifi-cpp issue #168: MINIFICPP-280 Move extension tests and test head...

2018-08-24 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/168 @calebj Obviously this PR is a bit dated in code but a positive step forward. Everytime I notice structural issues in code in extensions I think back to this PR. If I do the leg work

[GitHub] nifi-minifi-cpp pull request #389: MINIFICPP-592: Update RPG to fall back wh...

2018-08-28 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/389#discussion_r213438194 --- Diff: libminifi/src/RemoteProcessorGroupPort.cpp --- @@ -209,7 +225,8 @@ void RemoteProcessorGroupPort::onTrigger(const std

[GitHub] nifi-minifi-cpp pull request #393: MINIFICPP 601: Add Scheduling information

2018-08-28 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/393 MINIFICPP 601: Add Scheduling information This is predicated upon #392 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline

[GitHub] nifi-minifi-cpp pull request #373: MINIFICPP-554: Add checkpointing to the s...

2018-07-17 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/373 MINIFICPP-554: Add checkpointing to the startup process to delete flow files to avoid startup problems. Thank you for submitting a contribution to Apache NiFi - MiNiFi C

[GitHub] nifi-minifi-cpp issue #371: MINIFICPP-556 Added initial snapcraft build

2018-07-17 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/371 @jdye64 I was able to with some documentation you provided offline; however, following guides available online previously it failed with the error I sent you. Perhaps it would be useful

[GitHub] nifi-minifi-cpp pull request #372: MINIFICPP-557: Previously the empty flag ...

2018-07-16 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/372 MINIFICPP-557: Previously the empty flag was not a necessary check as… … we didn't have the case where empty ValueNodes could or should occur ( and these were dealt

[GitHub] nifi-minifi-cpp issue #372: MINIFICPP-557: Previously the empty flag was not...

2018-07-16 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/372 @apiri feel free to try this ---

[GitHub] nifi-minifi-cpp issue #371: MINIFICPP-556 Added initial snapcraft build

2018-07-15 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/371 I had a failure after approving. Will retry tomorrow before merging. Might be my issue. ---

[GitHub] nifi-minifi-cpp issue #347: MINIFIPP-514 Incorporated regex property validat...

2018-07-24 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/347 @achristianson and @apiri I don't believe the requests made in these pull requests were ever responded to. It includes this PR and two others that are all the same commits, just layered

[GitHub] nifi-minifi-cpp pull request #374: MINIFICPP-559 Move cURL external build up...

2018-07-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/374#discussion_r204225393 --- Diff: CMakeLists.txt --- @@ -165,6 +165,56 @@ else() set(UUID_LIBRARIES "uuid") endif() +if(NOT USE_S

[GitHub] nifi-minifi-cpp issue #375: MINIFICPP-561 Added internal/static build of bzi...

2018-07-21 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/375 Would you be able to move this to a separate submodule. The combination of these is making CMAKE a bit difficult to read. ---

[GitHub] nifi-minifi-cpp pull request #378: MINFICIPP-568: Change resp to componentma...

2018-07-21 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/378 MINFICIPP-568: Change resp to componentmanifest Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask

[GitHub] nifi-minifi-cpp issue #378: MINFICIPP-568: Change resp to componentmanifest

2018-07-21 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/378 For any reviewer note that this is a dependency for MINIFICPP-569, as such the structure needs to change. I've decided to make a change tonight to create a short term patch to the issue. ---

[GitHub] nifi-minifi-cpp pull request #382: MINIFICPP-575: Include cstring for strcmp

2018-07-24 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/382 MINIFICPP-575: Include cstring for strcmp Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you

[GitHub] nifi-minifi-cpp pull request #381: MINIFICPP-573: Remove lower level build i...

2018-07-24 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/381 MINIFICPP-573: Remove lower level build information that is unnecessary Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review

[GitHub] nifi-minifi-cpp pull request #396: MINIFICPP-604: Convert C++ namespace oper...

2018-09-10 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/396 MINIFICPP-604: Convert C++ namespace operators to Java packing operators Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review

[GitHub] nifi-minifi-cpp pull request #395: MINIFICPP-602: Add ability to use CSV wit...

2018-09-07 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/395 MINIFICPP-602: Add ability to use CSV within url field Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution

[GitHub] nifi-minifi-cpp issue #191: MINIFICPP-114 Consolidate JSON API use to RapidJ...

2018-01-16 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/191 @calebj HTTP Site to Site and C2 don't seem to work. Do you need help in testing these? ---

[GitHub] nifi-minifi-cpp pull request #246: MINIFICPP-377: Change log level for Invok...

2018-01-22 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/246 MINIFICPP-377: Change log level for InvokeHTTP to trace Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution

[GitHub] nifi-minifi-cpp pull request #247: MINIFICPP-378: Detach new threads if daem...

2018-01-22 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/247 MINIFICPP-378: Detach new threads if daemon threads is true Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review

[GitHub] nifi-minifi-cpp issue #247: MINIFICPP-378: Detach new threads if daemon thre...

2018-01-23 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/247 Currently testing something with this PR. will remove comment when ready to merge. ---

[GitHub] nifi-minifi-cpp issue #247: MINIFICPP-378: Detach new threads if daemon thre...

2018-01-23 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/247 performing additional testing verification... ---

[GitHub] nifi-minifi-cpp pull request #279: Minificpp 424

2018-03-13 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/279 Minificpp 424 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi-minifi-cpp pull request #276: MINIFICPP-424: Manually specify CAFile so...

2018-03-13 Thread phrocker
Github user phrocker closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/276 ---

[GitHub] nifi-minifi-cpp pull request #279: Minificpp 424

2018-03-14 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/279#discussion_r174445579 --- Diff: extensions/http-curl/client/HTTPClient.cpp --- @@ -334,6 +334,8 @@ void HTTPClient::configure_secure_connection(CURL *http_session

[GitHub] nifi-minifi-cpp issue #275: MINIFICPP-414 Added boolean Expression Language ...

2018-03-14 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/275 @achristianson I see conflicts. they may be easy to resolve, so i can take a look if need be. ---

[GitHub] nifi-minifi-cpp issue #268: MINIFICPP-397 Added implementation of RouteOnAtt...

2018-03-14 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/268 Will build and merge now ---

[GitHub] nifi-minifi-cpp pull request #276: MINIFICPP-424: Manually specify CAFile so...

2018-03-12 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/276 MINIFICPP-424: Manually specify CAFile so users do not need to update… … the cert bundle on their local machine Thank you for submitting a contribution to Apache NiFi - MiNiFi

[GitHub] nifi-minifi-cpp pull request #293: MINIFICPP-445 Added escape/unescape CSV e...

2018-04-05 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/293#discussion_r179582611 --- Diff: libminifi/include/utils/StringUtils.h --- @@ -88,7 +91,10 @@ class StringUtils { */ static inline bool equalsIgnoreCase

[GitHub] nifi-minifi-cpp issue #295: MINFICPP-403: Flow Meta tagging

2018-04-05 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/295 @minifirocks that script is used with cmake to provide that information in a codified, statically defined way, to the code base. It's built at compile time and provides the agent

[GitHub] nifi-minifi-cpp pull request #295: MINFICPP-403: Flow Meta tagging

2018-04-06 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/295#discussion_r179732500 --- Diff: libminifi/include/core/MetaInfo.h --- @@ -0,0 +1,180 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] nifi-minifi-cpp issue #295: MINFICPP-403: Flow Meta tagging

2018-04-06 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/295 I've been thinking more about this @minifirocks . I'm curious about the inception of this idea. I see that there is coupling amongst components that probably don't have a need to know

[GitHub] nifi-minifi-cpp pull request #299: MINIFICPP-454: Fix apt-get install statem...

2018-04-13 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/299 MINIFICPP-454: Fix apt-get install statement Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you

[GitHub] nifi-minifi-cpp pull request #296: MINIFICPP-449 Add cURL external project b...

2018-04-09 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/296#discussion_r180264480 --- Diff: CMakeLists.txt --- @@ -117,6 +118,49 @@ else () message( FATAL_ERROR "OpenSSL was not found. Please install OpenSSL" )

[GitHub] nifi-minifi-cpp pull request #296: MINIFICPP-449 Add cURL external project b...

2018-04-09 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/296#discussion_r180265512 --- Diff: extensions/http-curl/CMakeLists.txt --- @@ -42,9 +42,9 @@ if(CMAKE_THREAD_LIBS_INIT) endif() if (CURL_FOUND

[GitHub] nifi-minifi-cpp pull request #296: MINIFICPP-449 Add cURL external project b...

2018-04-09 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/296#discussion_r180264700 --- Diff: main/CMakeLists.txt --- @@ -66,7 +66,7 @@ else () target_link_libraries (minifiexe -Wl,--whole-archive minifi -Wl,--no-whole

[GitHub] nifi-minifi-cpp issue #295: MINFICPP-403: Flow Meta tagging

2018-04-05 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/295 `#ifndef AGENT_BUILD_H #define AGENT_BUILD_H #include namespace org { namespace apache { namespace nifi { namespace minifi { class AgentBuild

[GitHub] nifi-minifi-cpp issue #292: MINIFICPP-443 Add support for GET requests in Li...

2018-04-18 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/292 I was reminded why I haven't merged this. I get what seem like unrelated test failures in this PR. I will investigate a little later. ---

[GitHub] nifi-minifi-cpp issue #295: MINFICPP-403: Flow Meta tagging

2018-04-18 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/295 @minifirocks per your comment twelve days ago you mentioned that you didn't want to use a processor because you're putting this on every flow file. That's pretty reasonable, but why do we

[GitHub] nifi-minifi-cpp pull request #302: MINIFICPP-460: InvokeHTTP should handle a...

2018-04-18 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/302 MINIFICPP-460: InvokeHTTP should handle a missing content type gracef… …ully Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order

[GitHub] nifi-minifi-cpp issue #292: MINIFICPP-443 Add support for GET requests in Li...

2018-04-18 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/292 @achristianson #302 should solve the issue. ---

[GitHub] nifi-minifi-cpp issue #304: Providing fixes for sourcing RHEL based distribu...

2018-04-20 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/304 @apiri what was the problem you were experiencing and on what distro specifically? I don't see an issue on the clean rhel distros I have running now, ---

[GitHub] nifi-minifi-cpp issue #304: Providing fixes for sourcing RHEL based distribu...

2018-04-20 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/304 These changes look good at face value. I'm going to try it across a few platforms and await travis completion before merging. Thanks! ---

[GitHub] nifi-minifi-cpp issue #304: Providing fixes for sourcing RHEL based distribu...

2018-04-20 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/304 @apiri looks good. will merge. ---

[GitHub] nifi-minifi-cpp issue #308: MINIFICPP-470: Remove old extensions listing

2018-04-24 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/308 @apiri I assume most would arrive here via the ReadMe,but it doesn't hurt to add a link. I'm on the fence about the review process. there are some things that may not make sense to review

[GitHub] nifi-minifi-cpp pull request #308: MINIFICPP-470: Remove old extensions list...

2018-04-24 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/308 MINIFICPP-470: Remove old extensions listing Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you

[GitHub] nifi-minifi-cpp pull request #307: MINIFICPP-469 Added encode/decode base64 ...

2018-04-25 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/307#discussion_r184142402 --- Diff: extensions/expression-language/base64.h --- @@ -0,0 +1,188

[GitHub] nifi-minifi-cpp issue #311: MINIFICPP-432 Added docs for ApplyTemplate

2018-04-25 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/311 I don't agree. I think if you place them in the ReadMe, then the ReadMe should include a comment since that is where bootstrapping information. ---

[GitHub] nifi-minifi-cpp pull request #307: MINIFICPP-469 Added encode/decode base64 ...

2018-04-25 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/307#discussion_r184137048 --- Diff: extensions/expression-language/base64.h --- @@ -0,0 +1,188

[GitHub] nifi-minifi-cpp issue #289: MINIFICPP-440 Added LibreSSL as an external proj...

2018-03-29 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/289 The travis failure is not related. will merge. Thanks ---

[GitHub] nifi-minifi-cpp pull request #280: MINIFICPP-404: http proxy support for s2s

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/280#discussion_r175146488 --- Diff: extensions/http-curl/client/HTTPClient.h --- @@ -172,6 +172,20 @@ class HTTPClient : public BaseHTTPClient, public core::Connectable

[GitHub] nifi-minifi-cpp issue #284: MINIFICPP-434 Added ExecuteSQL(ite) implementati...

2018-03-18 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/284 Seems like there is no need for #283. If these both contain 433. ---

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175205415 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/OperationRequest.java --- @@ -0,0 +1,72

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175203879 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/C2Operation.java --- @@ -0,0 +1,99 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175204853 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/FlowStatus.java --- @@ -0,0 +1,51 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175204137 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/Device.java --- @@ -0,0 +1,48 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175200073 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/AgentInfo.java --- @@ -0,0 +1,81 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175205789 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/Bundle.java --- @@ -0,0 +1,106

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175201509 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/AgentRepositoryStatus.java --- @@ -0,0 +1,63

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175202125 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/AgentStatus.java --- @@ -0,0 +1,50 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175206927 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/DefinedType.java --- @@ -0,0 +1,69

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175201914 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/AgentRepositoryStatus.java --- @@ -0,0 +1,63

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175202384 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/AgentInfo.java --- @@ -0,0 +1,81 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175200116 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/AgentInfo.java --- @@ -0,0 +1,81 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175207806 --- Diff: minifi-c2/minifi-c2-web-api/src/main/java/org/apache/nifi/minifi/c2/web/api/C2ProtocolResource.java --- @@ -0,0 +1,119

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175202203 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/AgentManifest.java --- @@ -0,0 +1,82 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175208409 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/DefinedType.java --- @@ -0,0 +1,69

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175206733 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/ExtensionComponent.java --- @@ -0,0 +1,85

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175207121 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/ExtensionComponent.java --- @@ -0,0 +1,85

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175208131 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/C2OperationAck.java --- @@ -0,0 +1,35 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175203025 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/C2Heartbeat.java --- @@ -0,0 +1,66 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-16 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175207453 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/PropertyDescriptor.java --- @@ -0,0 +1,123

<    3   4   5   6   7   8   9   10   11   >