Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/415
Ah. I thought I pushed that fix because I specifically remember that. Will
check tomorrow morn . Probably forgot the old pusharoo
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225492447
--- Diff: libminifi/src/capi/api.cpp ---
@@ -237,25 +239,58 @@ void update_attribute(flow_file_record *ff, char
*key, void *value, size_t size
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/418#discussion_r225742123
--- Diff: docker/Dockerfile ---
@@ -67,7 +67,7 @@ ENV MINIFI_HOME
$MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION
RUN cd $MINIFI_BASE_DIR
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/418#discussion_r225742402
--- Diff: docker/Dockerfile ---
@@ -67,7 +67,7 @@ ENV MINIFI_HOME
$MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION
RUN cd $MINIFI_BASE_DIR
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225745605
--- Diff: libminifi/src/capi/api.cpp ---
@@ -237,25 +239,58 @@ void update_attribute(flow_file_record *ff, char
*key, void *value, size_t size
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225493178
--- Diff: libminifi/src/capi/api.cpp ---
@@ -237,25 +239,58 @@ void update_attribute(flow_file_record *ff, char
*key, void *value, size_t size
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225498252
--- Diff: libminifi/test/capi/CAPITests.cpp ---
@@ -0,0 +1,199 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225496575
--- Diff: libminifi/src/capi/api.cpp ---
@@ -212,7 +214,7 @@ void free_flowfile(flow_file_record *ff) {
* @param size size of value
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225492979
--- Diff: libminifi/src/capi/api.cpp ---
@@ -237,25 +239,58 @@ void update_attribute(flow_file_record *ff, char
*key, void *value, size_t size
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225497705
--- Diff: libminifi/src/capi/api.cpp ---
@@ -237,25 +239,58 @@ void update_attribute(flow_file_record *ff, char
*key, void *value, size_t size
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225498085
--- Diff: libminifi/test/CPPLINT.cfg ---
@@ -1,4 +1,5 @@
set noparent
filter=-build/include_order,-build/include_alpha
exclude_files
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225493056
--- Diff: libminifi/src/capi/api.cpp ---
@@ -237,25 +239,58 @@ void update_attribute(flow_file_record *ff, char
*key, void *value, size_t size
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225745984
--- Diff: libminifi/src/capi/api.cpp ---
@@ -32,6 +32,7 @@
using string_map = std::map;
class API_INITIALIZER {
+ public
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225746086
--- Diff: libminifi/include/capi/cstructs.h ---
@@ -86,11 +86,16 @@ typedef struct {
*/
typedef struct {
- char *key
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225500703
--- Diff: libminifi/src/capi/api.cpp ---
@@ -361,6 +396,18 @@ processor *add_processor(flow *flow, const char
*processor_name
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225500772
--- Diff: libminifi/src/capi/api.cpp ---
@@ -361,6 +396,18 @@ processor *add_processor(flow *flow, const char
*processor_name
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225496736
--- Diff: libminifi/src/capi/api.cpp ---
@@ -212,7 +214,7 @@ void free_flowfile(flow_file_record *ff) {
* @param size size of value
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225495011
--- Diff: libminifi/src/capi/api.cpp ---
@@ -237,25 +239,58 @@ void update_attribute(flow_file_record *ff, char
*key, void *value, size_t size
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/418#discussion_r225749503
--- Diff: docker/Dockerfile ---
@@ -67,7 +67,7 @@ ENV MINIFI_HOME
$MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION
RUN cd $MINIFI_BASE_DIR
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/418#discussion_r225755839
--- Diff: docker/Dockerfile ---
@@ -67,7 +67,7 @@ ENV MINIFI_HOME
$MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION
RUN cd $MINIFI_BASE_DIR
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225960797
--- Diff: libminifi/src/capi/api.cpp ---
@@ -237,25 +239,58 @@ void update_attribute(flow_file_record *ff, char
*key, void *value, size_t size
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225978725
--- Diff: libminifi/include/capi/cstructs.h ---
@@ -86,11 +86,16 @@ typedef struct {
*/
typedef struct {
- char *key
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/417
@arpadboda so as not to slow you down here I've made a number of blockers
for this release to address before we can close out -- so if you fix the linter
issues I can merge. We can di
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/418#discussion_r226049373
--- Diff: docker/Dockerfile ---
@@ -67,7 +67,7 @@ ENV MINIFI_HOME
$MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION
RUN cd $MINIFI_BASE_DIR
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/419
Minificpp 643
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/418#discussion_r226095265
--- Diff: docker/Dockerfile ---
@@ -67,7 +67,7 @@ ENV MINIFI_HOME
$MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION
RUN cd $MINIFI_BASE_DIR
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/418#discussion_r226095438
--- Diff: docker/Dockerfile ---
@@ -67,7 +67,7 @@ ENV MINIFI_HOME
$MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION
RUN cd $MINIFI_BASE_DIR
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/420
MINIFICPP-647: Begin process of deprecating functions and remove thosâ¦
â¦e which were added recently that aren't needed
Thank you for submitting a contribution to Apache
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/420#discussion_r226320291
--- Diff: libminifi/test/capi/CAPITests.cpp ---
@@ -33,8 +32,14 @@
#include
#include
+static nifi_instance
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/420#discussion_r226320573
--- Diff: python/minifi/__init__.py ---
@@ -66,9 +66,9 @@ def setBase(self, proc):
def get(self, session):
ff = self
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/420#discussion_r226384252
--- Diff: libminifi/src/capi/api.cpp ---
@@ -57,38 +57,28 @@ class DirectoryConfiguration {
}
};
-nifi_port *create_port
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/424
MINIFICPP-623: Add trace capabilities to controller and agent
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/421#discussion_r226716905
--- Diff: libminifi/include/capi/Plan.h ---
@@ -93,11 +95,50 @@ class ExecutionPlan {
next_ff_ = ptr;
}
+ static std
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/421#discussion_r226302333
--- Diff: libminifi/include/capi/Plan.h ---
@@ -93,11 +95,50 @@ class ExecutionPlan {
next_ff_ = ptr;
}
+ static std
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/421#discussion_r226306211
--- Diff: libminifi/include/capi/Plan.h ---
@@ -93,11 +95,50 @@ class ExecutionPlan {
next_ff_ = ptr;
}
+ static std
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/421#discussion_r226309091
--- Diff: libminifi/src/capi/Plan.cpp ---
@@ -202,29 +180,31 @@ std::shared_ptr
ExecutionPlan::getCurrentSession() {
return
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/421#discussion_r226717192
--- Diff: libminifi/include/capi/api.h ---
@@ -79,6 +79,13 @@ processor *add_processor_with_linkage(flow *flow, const
char *processor_name
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/424
@apiri yeah it seems that it's because they are run in parallel and there
is a port collision. I am changing port numbers in the tests.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/424
I tried adding commits but GH is not correctly tracking my branch for some
reason. Travis and Appveyor have passed and I added an empty commit and
updates to the readme to no avail. May
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/422
Merging now.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/422
@arpadboda Sorry I just noticed build failures in linux and tried it on a
VM and it failed too. Seems pretty easy. The issue is in CMAKE, previously some
artifacts weren't included
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/421#discussion_r227411014
--- Diff: libminifi/include/capi/api.h ---
@@ -79,6 +79,13 @@ processor *add_processor_with_linkage(flow *flow, const
char *processor_name
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/421#discussion_r227422808
--- Diff: libminifi/include/capi/Plan.h ---
@@ -93,11 +95,50 @@ class ExecutionPlan {
next_ff_ = ptr;
}
+ static std
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/421#discussion_r227425691
--- Diff: libminifi/include/capi/api.h ---
@@ -79,6 +79,13 @@ processor *add_processor_with_linkage(flow *flow, const
char *processor_name
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/422
new travis failure appears to be unrelated to this commit, so will merge.
thanks!
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427
MINIFICPP-653: Check if empty content, if so don't produce log messagâ¦
â¦e that can segfault client
Thank you for submitting a contribution to Apache NiFi - MiN
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/427
One of the docker tests fails -- currently debugging.
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/428
MINIFICPP-652: Add traceability to repositories and flow controller
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/428#discussion_r228764724
--- Diff: libminifi/include/core/TraceableResource.h ---
@@ -0,0 +1,53 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/428#discussion_r228764771
--- Diff: libminifi/src/FlowController.cpp ---
@@ -911,11 +911,18 @@ uint64_t FlowController::getUptime() {
}
std::vector
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/428#discussion_r228764823
--- Diff: libminifi/src/FlowController.cpp ---
@@ -911,11 +911,18 @@ uint64_t FlowController::getUptime() {
}
std::vector
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228765124
--- Diff: docker/test/integration/test_zero_file.py ---
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228765232
--- Diff: docker/test/integration/test_zero_file.py ---
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228769725
--- Diff: docker/test/integration/minifi/__init__.py ---
@@ -664,8 +674,8 @@ def nifi_flow_xml(connectable, nifi_version=None,
root=None, visited
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228769742
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -40,21 +39,24 @@ def __init__(self, output_validator):
# Create
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/429
@arpadboda is this ready for review? You stated, "it's not final"
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229018124
--- Diff: libminifi/include/capi/Plan.h ---
@@ -46,11 +48,50 @@
#include "capi/cstructs.h"
#include "capi/api.h&q
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229018550
--- Diff: libminifi/src/capi/api.cpp ---
@@ -170,31 +165,31 @@ flow_file_record* create_ff_object_na(const char
*file, const size_t len, const
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229017394
--- Diff: libminifi/include/capi/Plan.h ---
@@ -46,11 +48,50 @@
#include "capi/cstructs.h"
#include "capi/api.h&q
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229020814
--- Diff: libminifi/src/capi/api.cpp ---
@@ -400,11 +395,19 @@ processor *add_processor_with_linkage(flow *flow,
const char *processor_name
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229016579
--- Diff: libminifi/include/capi/Plan.h ---
@@ -46,11 +48,50 @@
#include "capi/cstructs.h"
#include "capi/api.h&q
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229015052
--- Diff: libminifi/include/capi/Plan.h ---
@@ -16,6 +16,8 @@
* limitations under the License.
*/
+#pragma once
--- End
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229021535
--- Diff: libminifi/include/capi/Plan.h ---
@@ -46,11 +48,50 @@
#include "capi/cstructs.h"
#include "capi/api.h&q
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229015497
--- Diff: libminifi/include/capi/Plan.h ---
@@ -46,11 +48,50 @@
#include "capi/cstructs.h"
#include "capi/api.h&q
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/429
Looks good. minor comments, nothing that's a big deal
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/430
MINIFICPP-659: Break out CAPI into nanofi
Break out structure -- facilitating Python and new nanofi structure
Thank you for submitting a contribution to Apache NiFi - MiNiFi C
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/168
@arpadboda I started a branch as of my last comment -- but it's only a
small part of my work, so it will take a bit of time. I don't think there is
any harm in keeping it open
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/430#discussion_r229138444
--- Diff: nanofi/examples/CMakeLists.txt ---
@@ -61,18 +61,18 @@ add_executable(generate_flow generate_flow.c)
add_executable
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/430#discussion_r229138685
--- Diff: thirdparty/rocksdb/CMakeLists.txt ---
@@ -592,16 +592,16 @@ if(WIN32)
set(LIBS ${ROCKSDB_STATIC_LIB} ${THIRDPARTY_LIBS
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229265673
--- Diff: libminifi/include/capi/Plan.h ---
@@ -16,6 +16,8 @@
* limitations under the License.
*/
+#pragma once
--- End
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r229300368
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -142,7 +147,7 @@ def check_output(self, timeout=5
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/431
@arpadboda this was merged but I used the wrong commit hook to close it. I
closed the wrong PR. So can you close this when you have a chance? Sorry about
that.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/430
@apiri rebasing now, thanks.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/430
@apiri rebased but don't see the updates in the PR. Do you see them?
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/433
Minificpp 659
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/433
@apiri this is the same PR
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/433
This is the accidentally closed PR. I've updated darwin.sh of the bootstrap
to ensure users have a known working version of bison.
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r229665609
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -117,12 +119,15 @@ def log_nifi_output(self):
for container in
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r229665932
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -142,7 +147,7 @@ def check_output(self, timeout=5
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r230799918
--- Diff: libminifi/CMakeLists.txt ---
@@ -141,11 +141,14 @@ endif()
SET (LIBMINIFI core-minifi PARENT_SCOPE)
if (ENABLE_PYTHON
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r230801158
--- Diff: libminifi/CMakeLists.txt ---
@@ -141,11 +141,14 @@ endif()
SET (LIBMINIFI core-minifi PARENT_SCOPE)
if (ENABLE_PYTHON
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r230803774
--- Diff: libminifi/CMakeLists.txt ---
@@ -141,11 +141,14 @@ endif()
SET (LIBMINIFI core-minifi PARENT_SCOPE)
if (ENABLE_PYTHON
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/432
@arpadboda is this good? I'm good with this otherwise.
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/434
MINIFICPP-664: Require C2 agent class to be defined
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231865178
--- Diff: nanofi/include/cxx/CallbackProcessor.h ---
@@ -65,7 +65,7 @@ class CallbackProcessor : public core::Processor {
public
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r23188
--- Diff: nanofi/src/api/nanofi.cpp ---
@@ -323,55 +360,45 @@ int transmit_flowfile(flow_file_record *ff,
nifi_instance *instance
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231867815
--- Diff: nanofi/src/api/nanofi.cpp ---
@@ -323,55 +360,45 @@ int transmit_flowfile(flow_file_record *ff,
nifi_instance *instance
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231865240
--- Diff: nanofi/include/cxx/Plan.h ---
@@ -44,7 +44,7 @@
#include "core/ProcessSession.h"
#include "core/ProcessorNode.h
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231867605
--- Diff: nanofi/src/api/nanofi.cpp ---
@@ -323,55 +360,45 @@ int transmit_flowfile(flow_file_record *ff,
nifi_instance *instance
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231865773
--- Diff: nanofi/src/api/nanofi.cpp ---
@@ -89,6 +93,39 @@ nifi_instance *create_instance(const char *url,
nifi_port *port) {
return
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231868999
--- Diff: nanofi/src/cxx/Plan.cpp ---
@@ -162,6 +153,21 @@ bool
ExecutionPlan::runNextProcessor(std::function current_session =
std::make_shared
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231864832
--- Diff: nanofi/include/core/cxxstructs.h ---
@@ -0,0 +1,41 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231865428
--- Diff: nanofi/include/cxx/Plan.h ---
@@ -133,8 +133,29 @@ class ExecutionPlan {
next_ff_ = ptr;
}
+ bool hasProcessor
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/435
MINIFICPP-665: Add reference checks for self
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/435
@arpadboda yah we can compare templates. But we lose the ability to change
source of streams. Was on fence about that
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r23274
--- Diff: nanofi/include/core/cxxstructs.h ---
@@ -0,0 +1,41 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r232751327
--- Diff: nanofi/src/api/nanofi.cpp ---
@@ -323,55 +360,45 @@ int transmit_flowfile(flow_file_record *ff,
nifi_instance *instance
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/436
MINIFICPP-667: Add structural definitions to work out plan for C migrâ¦
â¦ation
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/437
MINIFICPP-558: initial provisioning for CoAP
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/437
Adding tests presently, but providing a wip view.
---
801 - 900 of 1084 matches
Mail list logo
