[GitHub] [openwhisk-deploy-kube] hunhoffe commented on a diff in pull request #729: Deploy with new scheduler

hunhoffe commented on code in PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#discussion_r977058484 ## helm/openwhisk/values.yaml: ## @@ -139,9 +139,9 @@ whisk: includeSystemTests: false versions: openwhisk: - buildDate: "2022-06-23-06:1

[GitHub] [openwhisk-deploy-kube] hunhoffe commented on pull request #729: Deploy with new scheduler

hunhoffe commented on PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#issuecomment-1254328584 I believe I've addressed all comments except the external etcd feature. I wrote a comment that it is not yet supported in the values.yaml file, and I'm hoping that it is a f

[GitHub] [openwhisk-runtime-go] bdoyle0182 commented on pull request #176: Add mutex lock to safe-guard bufio.Reader access in Executor

bdoyle0182 commented on PR #176: URL: https://github.com/apache/openwhisk-runtime-go/pull/176#issuecomment-1254316564 I thought adobe was using the concurrent executions feature in production so I don't know if it's still considered experimental? There's definitely value to it as it signif

[GitHub] [openwhisk-runtime-go] dgrove-oss commented on pull request #176: Add mutex lock to safe-guard bufio.Reader access in Executor

dgrove-oss commented on PR #176: URL: https://github.com/apache/openwhisk-runtime-go/pull/176#issuecomment-1254231609 Thanks for the detailed review @sciabarracom! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [openwhisk-runtime-go] msciabarra commented on pull request #176: Add mutex lock to safe-guard bufio.Reader access in Executor

msciabarra commented on PR #176: URL: https://github.com/apache/openwhisk-runtime-go/pull/176#issuecomment-1254223780 > However the concurrency is already handled by the goroutines that >serve each of the HTTP requests. No. The goroutine there is used only to avoid a blocking behaviour w

[GitHub] [openwhisk-runtime-go] msciabarra commented on pull request #176: Add mutex lock to safe-guard bufio.Reader access in Executor

msciabarra commented on PR #176: URL: https://github.com/apache/openwhisk-runtime-go/pull/176#issuecomment-1254208331 Yes it is true that the invoker supports concurrent requests but so far the only runtime that supports (experimentally afaik) the concurrent requests is the nodejs one. Act

[GitHub] [openwhisk-runtime-go] 0x161e-swei commented on pull request #176: Add mutex lock to safe-guard bufio.Reader access in Executor

0x161e-swei commented on PR #176: URL: https://github.com/apache/openwhisk-runtime-go/pull/176#issuecomment-1254183598 @msciabarra Thanks a lot for taking a look at this! > Runtimes are not expected to execute concurrent requests. My understanding from reading the openwhisk inv

[GitHub] [openwhisk-runtime-go] msciabarra commented on pull request #176: Add mutex lock to safe-guard bufio.Reader access in Executor

msciabarra commented on PR #176: URL: https://github.com/apache/openwhisk-runtime-go/pull/176#issuecomment-1253985851 Runtimes are not expected to execute concurrent requests. To implement concurrent requests a lot of work is required to create multiple executors of the functions and disp

[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5326: Fix Orphaned Container Edge Case In Paused State of Container Proxy

bdoyle0182 commented on code in PR #5326: URL: https://github.com/apache/openwhisk/pull/5326#discussion_r976743330 ## core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala: ## @@ -732,7 +735,12 @@ class FunctionPullingContaine

[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5326: Fix Orphaned Container Edge Case In Paused State of Container Proxy

bdoyle0182 commented on code in PR #5326: URL: https://github.com/apache/openwhisk/pull/5326#discussion_r976738766 ## tests/src/test/scala/org/apache/openwhisk/core/containerpool/v2/test/FunctionPullingContainerProxyTests.scala: ## @@ -1036,6 +1048,84 @@ class FunctionPullingCon

[GitHub] [openwhisk-runtime-go] dgrove-oss commented on pull request #176: Add mutex lock to safe-guard bufio.Reader access in Executor

dgrove-oss commented on PR #176: URL: https://github.com/apache/openwhisk-runtime-go/pull/176#issuecomment-1253932401 @michele-sciabarra -- can you please take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5326: Fix Orphaned Container Edge Case In Paused State of Container Proxy

bdoyle0182 commented on code in PR #5326: URL: https://github.com/apache/openwhisk/pull/5326#discussion_r97665 ## core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala: ## @@ -732,7 +735,12 @@ class FunctionPullingContaine

[GitHub] [openwhisk-runtime-go] falkzoll opened a new pull request, #177: Update to recent travis build vm to unblock build.

falkzoll opened a new pull request, #177: URL: https://github.com/apache/openwhisk-runtime-go/pull/177 Current travis build VM is still using xenial (16.04) as base. Updates to this image caused build breaks. Updating to a more recent build environment (same as for apache/openwhisk -> h

[GitHub] [openwhisk] style95 commented on a diff in pull request #5326: Fix Orphaned Container Edge Case In Paused State of Container Proxy

style95 commented on code in PR #5326: URL: https://github.com/apache/openwhisk/pull/5326#discussion_r976038644 ## tests/src/test/scala/org/apache/openwhisk/core/containerpool/v2/test/FunctionPullingContainerProxyTests.scala: ## @@ -1036,6 +1048,84 @@ class FunctionPullingContai

[GitHub] [openwhisk] codecov-commenter commented on pull request #5326: Fix Orphaned Container Edge Case In Paused State of Container Proxy

codecov-commenter commented on PR #5326: URL: https://github.com/apache/openwhisk/pull/5326#issuecomment-1253187615 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5326?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5326: Fix Orphaned Container Edge Case In Paused State of Container Proxy

bdoyle0182 commented on code in PR #5326: URL: https://github.com/apache/openwhisk/pull/5326#discussion_r975895167 ## core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/ShardingContainerPoolBalancer.scala: ## @@ -158,7 +158,7 @@ class ShardingContainerPoolBala

[GitHub] [openwhisk] bdoyle0182 opened a new pull request, #5326: Fix Orphaned Container Edge Case In Paused State of Container Proxy

bdoyle0182 opened a new pull request, #5326: URL: https://github.com/apache/openwhisk/pull/5326 ## Description You can read a more detailed series of events to hit this case in the corresponding issue, but here's the tldr: 1. Container doesn't have activations so transitions to pau

[GitHub] [openwhisk-deploy-kube] style95 commented on a diff in pull request #729: Deploy with new scheduler

style95 commented on code in PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#discussion_r973816585 ## helm/openwhisk/templates/scheduler-pod.yaml: ## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [openwhisk-deploy-kube] hunhoffe commented on a diff in pull request #729: Deploy with new scheduler

hunhoffe commented on code in PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#discussion_r973326256 ## helm/openwhisk/templates/scheduler-pod.yaml: ## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributo

[GitHub] [openwhisk-deploy-kube] hunhoffe commented on a diff in pull request #729: Deploy with new scheduler

hunhoffe commented on code in PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#discussion_r973281374 ## helm/openwhisk/templates/scheduler-pod.yaml: ## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributo

[GitHub] [openwhisk-deploy-kube] hunhoffe commented on a diff in pull request #729: Deploy with new scheduler

hunhoffe commented on code in PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#discussion_r973069049 ## helm/openwhisk/values.yaml: ## @@ -249,20 +255,69 @@ nginx: # Controller configurations controller: imageName: "openwhisk/controller" - imageTag:

[GitHub] [openwhisk-deploy-kube] style95 commented on a diff in pull request #729: Deploy with new scheduler

style95 commented on code in PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#discussion_r972595284 ## helm/openwhisk/templates/scheduler-pod.yaml: ## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [openwhisk-deploy-kube] hunhoffe commented on a diff in pull request #729: Deploy with new scheduler

hunhoffe commented on code in PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#discussion_r972478031 ## helm/openwhisk/templates/scheduler-pod.yaml: ## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributo

[GitHub] [openwhisk-deploy-kube] hunhoffe commented on a diff in pull request #729: Deploy with new scheduler

hunhoffe commented on code in PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#discussion_r972478031 ## helm/openwhisk/templates/scheduler-pod.yaml: ## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributo

[GitHub] [openwhisk-deploy-kube] style95 commented on pull request #729: Deploy with new scheduler

style95 commented on PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#issuecomment-1248054310 @hunhoffe This is great! Thank you for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [openwhisk-deploy-kube] style95 commented on a diff in pull request #729: Deploy with new scheduler

style95 commented on code in PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#discussion_r971917119 ## helm/openwhisk/templates/scheduler-pod.yaml: ## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [openwhisk] style95 commented on issue #5325: [New Scheduler] Container unpausing results in key remaining in etcd for deleted container

style95 commented on issue #5325: URL: https://github.com/apache/openwhisk/issues/5325#issuecomment-1247996217 Awesome analysis! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on a diff in pull request #729: Deploy with new scheduler

dgrove-oss commented on code in PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#discussion_r971446437 ## helm/openwhisk/values.yaml: ## @@ -249,20 +255,69 @@ nginx: # Controller configurations controller: imageName: "openwhisk/controller" - imageTag

[GitHub] [openwhisk] bdoyle0182 commented on issue #5325: [New Scheduler] Container unpausing results in key remaining in etcd for deleted container

bdoyle0182 commented on issue #5325: URL: https://github.com/apache/openwhisk/issues/5325#issuecomment-1247467187 Actually it's a bit simpler and an unhandled failure case in the paused state as this is the only place that could return an etcd error in the FunctionPullingContainerProxy

[GitHub] [openwhisk] bdoyle0182 commented on issue #5325: [New Scheduler] Container unpausing results in key remaining in etcd for deleted container

bdoyle0182 commented on issue #5325: URL: https://github.com/apache/openwhisk/issues/5325#issuecomment-1247415358 Figured it out. So when the container is unpaused by the `FunctionPullingContainerProxy`, it changes state to `Running` while the async unpause code runs and a failure me

[GitHub] [openwhisk] bdoyle0182 opened a new issue, #5325: [New Scheduler] Container Unpausing results in key remaining in etcd for existing container

bdoyle0182 opened a new issue, #5325: URL: https://github.com/apache/openwhisk/issues/5325 This is consistently reproducible for me now. When a container is unpaused, the keys are first unwatched and possibly deleted before the unpause operation completes. At the same time as the unpause op

[GitHub] [openwhisk-deploy-kube] hunhoffe commented on a diff in pull request #729: Deploy with new scheduler

hunhoffe commented on code in PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#discussion_r970251615 ## helm/openwhisk/values.yaml: ## @@ -249,20 +255,69 @@ nginx: # Controller configurations controller: imageName: "openwhisk/controller" - imageTag:

[GitHub] [openwhisk-deploy-kube] hunhoffe commented on a diff in pull request #729: Deploy with new scheduler

hunhoffe commented on code in PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#discussion_r918524790 ## helm/openwhisk/values.yaml: ## @@ -259,6 +265,54 @@ controller: jvmOptions: "" loglevel: "INFO" +# Scheduler configurations +scheduler: + enabl

[GitHub] [openwhisk-deploy-kube] hunhoffe commented on a diff in pull request #729: Deploy with new scheduler

hunhoffe commented on code in PR #729: URL: https://github.com/apache/openwhisk-deploy-kube/pull/729#discussion_r918524619 ## helm/openwhisk/values.yaml: ## @@ -248,8 +254,8 @@ nginx: # Controller configurations controller: - imageName: "openwhisk/controller" - imageTag:

[GitHub] [openwhisk] style95 commented on a diff in pull request #5323: Clean Up Etcd Worker Actor

style95 commented on code in PR #5323: URL: https://github.com/apache/openwhisk/pull/5323#discussion_r969287893 ## tests/src/test/scala/org/apache/openwhisk/common/etcd/EtcdWorkerTests.scala: ## @@ -0,0 +1,176 @@ +package org.apache.openwhisk.common.etcd + +import akka.actor.{Ac

[GitHub] [openwhisk] bdoyle0182 merged pull request #5324: add container and creation ids to memory queue log

bdoyle0182 merged PR #5324: URL: https://github.com/apache/openwhisk/pull/5324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwh

[GitHub] [openwhisk] codecov-commenter commented on pull request #5324: add container and creation ids to memory queue log

codecov-commenter commented on PR #5324: URL: https://github.com/apache/openwhisk/pull/5324#issuecomment-1244771604 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5324?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [openwhisk] bdoyle0182 opened a new pull request, #5324: add container and creation ids to memory queue log

bdoyle0182 opened a new pull request, #5324: URL: https://github.com/apache/openwhisk/pull/5324 ## Description Include the container and creation ids in the log when queue attempts to stop. Will help with debugging when in memory queue data gets out of sync with etcd or if etcd data hasn

[GitHub] [openwhisk] codecov-commenter commented on pull request #5323: Clean Up Etcd Worker Actor

codecov-commenter commented on PR #5323: URL: https://github.com/apache/openwhisk/pull/5323#issuecomment-1244661804 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5323?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [openwhisk] bdoyle0182 opened a new pull request, #5323: Clean Up Etcd Worker Actor

bdoyle0182 opened a new pull request, #5323: URL: https://github.com/apache/openwhisk/pull/5323 ## Description I don't think this is the root of my issue with the scheduler not learning that a container has been removed, but nevertheless this is a valuable refactor to make sure everythin

[GitHub] [openwhisk-website] jtownley commented on issue #499: Slack invitation not sent

jtownley commented on issue #499: URL: https://github.com/apache/openwhisk-website/issues/499#issuecomment-1243623964 I can confirm this is still an issue. I get the same result as @linuswagner. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [openwhisk] bdoyle0182 merged pull request #5103: Add note on concurrency limit config to concurrency.md

bdoyle0182 merged PR #5103: URL: https://github.com/apache/openwhisk/pull/5103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwh

[GitHub] [openwhisk] bdoyle0182 commented on pull request #5103: Add note on concurrency limit config to concurrency.md

bdoyle0182 commented on PR #5103: URL: https://github.com/apache/openwhisk/pull/5103#issuecomment-1242534129 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [openwhisk-runtime-java] bdoyle0182 commented on a diff in pull request #130: Support action-level concurrency in Java runtime.

bdoyle0182 commented on code in PR #130: URL: https://github.com/apache/openwhisk-runtime-java/pull/130#discussion_r963980315 ## core/java8/proxy/src/main/java/org/apache/openwhisk/runtime/java/action/Proxy.java: ## @@ -48,7 +51,20 @@ public Proxy(int port) throws IOException {

[GitHub] [openwhisk-runtime-java] bdoyle0182 commented on pull request #130: Support action-level concurrency in Java runtime.

bdoyle0182 commented on PR #130: URL: https://github.com/apache/openwhisk-runtime-java/pull/130#issuecomment-1238437805 On top of @rabbah 's point, the action concurrency feature in openwhisk is still fairly new and experimental. It adds an additional level of capacity planning required on

[GitHub] [openwhisk-runtime-java] Scusemua commented on a diff in pull request #130: Support action-level concurrency in Java runtime.

Scusemua commented on code in PR #130: URL: https://github.com/apache/openwhisk-runtime-java/pull/130#discussion_r963964879 ## core/java8/proxy/src/main/java/org/apache/openwhisk/runtime/java/action/Proxy.java: ## @@ -48,7 +51,20 @@ public Proxy(int port) throws IOException {

[GitHub] [openwhisk-runtime-java] Scusemua commented on a diff in pull request #130: Support action-level concurrency in Java runtime.

Scusemua commented on code in PR #130: URL: https://github.com/apache/openwhisk-runtime-java/pull/130#discussion_r963963461 ## core/java8/proxy/src/main/java/org/apache/openwhisk/runtime/java/action/Proxy.java: ## @@ -48,7 +51,20 @@ public Proxy(int port) throws IOException {

[GitHub] [openwhisk-runtime-java] bdoyle0182 commented on a diff in pull request #130: Support action-level concurrency in Java runtime.

bdoyle0182 commented on code in PR #130: URL: https://github.com/apache/openwhisk-runtime-java/pull/130#discussion_r963961751 ## core/java8/proxy/src/main/java/org/apache/openwhisk/runtime/java/action/Proxy.java: ## @@ -48,7 +51,20 @@ public Proxy(int port) throws IOException {

[GitHub] [openwhisk-runtime-java] bdoyle0182 commented on a diff in pull request #130: Support action-level concurrency in Java runtime.

bdoyle0182 commented on code in PR #130: URL: https://github.com/apache/openwhisk-runtime-java/pull/130#discussion_r963958697 ## core/java8/proxy/src/main/java/org/apache/openwhisk/runtime/java/action/Proxy.java: ## @@ -48,7 +51,20 @@ public Proxy(int port) throws IOException {

[GitHub] [openwhisk-runtime-java] bdoyle0182 commented on pull request #130: Support action-level concurrency in Java runtime.

bdoyle0182 commented on PR #130: URL: https://github.com/apache/openwhisk-runtime-java/pull/130#issuecomment-1238413978 Hey Ben I replied on your slack thread and didn't realize you had an open pr for this will take a look -- This is an automated message from the Apache Git Service. To r

[GitHub] [openwhisk-runtime-java] Scusemua commented on pull request #130: Support action-level concurrency in Java runtime.

Scusemua commented on PR #130: URL: https://github.com/apache/openwhisk-runtime-java/pull/130#issuecomment-1238408086 Not extensively. We could probably create a unit test in which we have a single container serve multiple requests simultaneously and watch for this by checking the value of

[GitHub] [openwhisk] style95 merged pull request #5278: Prepare to integrate new scheduler into apache/openwhisk-deploy-kube

style95 merged PR #5278: URL: https://github.com/apache/openwhisk/pull/5278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwhisk

[GitHub] [openwhisk] style95 commented on pull request #5278: Prepare to integrate new scheduler into apache/openwhisk-deploy-kube

style95 commented on PR #5278: URL: https://github.com/apache/openwhisk/pull/5278#issuecomment-1236464179 Thank you, Erika, for your effort. 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [openwhisk] style95 commented on a diff in pull request #5278: Prepare to integrate new scheduler into apache/openwhisk-deploy-kube

style95 commented on code in PR #5278: URL: https://github.com/apache/openwhisk/pull/5278#discussion_r962411907 ## core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/Scheduler.scala: ## @@ -289,6 +292,11 @@ object Scheduler { implicit val logger = new Akka

[GitHub] [openwhisk-runtime-go] 0x161e-swei commented on pull request #176: Add mutex lock to safe-guard bufio.Reader access in Executor

0x161e-swei commented on PR #176: URL: https://github.com/apache/openwhisk-runtime-go/pull/176#issuecomment-1236046305 Hi @mhenke1 @dgrove-oss , could you please take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [openwhisk-deploy-kube] linuswagner closed issue #749: Gen-certs Job has issues accessing the K8 cluster

linuswagner closed issue #749: Gen-certs Job has issues accessing the K8 cluster URL: https://github.com/apache/openwhisk-deploy-kube/issues/749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [openwhisk-runtime-nodejs] mhenke1 merged pull request #224: Update Nodejs 16 base image

mhenke1 merged PR #224: URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [openwhisk-runtime-nodejs] Luke-Roy-IBM opened a new pull request, #224: Update Nodejs 16 base image

Luke-Roy-IBM opened a new pull request, #224: URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/224 Setting Nodejs 16 image to `node:16-bullseye` to get latest vulnerability fixes -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [openwhisk] hunhoffe commented on pull request #5278: Prepare to integrate new scheduler into apache/openwhisk-deploy-kube

hunhoffe commented on PR #5278: URL: https://github.com/apache/openwhisk/pull/5278#issuecomment-1234919518 Rebased to master, finished addressing comments about changes to controller (by removing changes to the controller) -- This is an automated message from the Apache Git Service. To re

[GitHub] [openwhisk] hunhoffe commented on a diff in pull request #5278: Prepare to integrate new scheduler into apache/openwhisk-deploy-kube

hunhoffe commented on code in PR #5278: URL: https://github.com/apache/openwhisk/pull/5278#discussion_r961183630 ## core/controller/src/main/scala/org/apache/openwhisk/core/controller/Controller.scala: ## @@ -230,6 +233,10 @@ object Controller { def main(args: Array[String]):

[GitHub] [openwhisk] bdoyle0182 merged pull request #5305: add config to fail async scheduler throttles as whisk errors

bdoyle0182 merged PR #5305: URL: https://github.com/apache/openwhisk/pull/5305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwh

[GitHub] [openwhisk] bdoyle0182 commented on issue #5322: [New Scheduler] Container Unpausing Path is Suboptimal Due to Potential Function Cache Miss

bdoyle0182 commented on issue #5322: URL: https://github.com/apache/openwhisk/issues/5322#issuecomment-1234619671 Actually it seems like the cache is still used in the function pulling container proxy when getting every new activation. Maybe it is just a problem of increasing the cache time

[GitHub] [openwhisk] bdoyle0182 opened a new issue, #5322: [New Scheduler] Container Unpausing Path is Suboptimal Due to Potential Function Cache Miss

bdoyle0182 opened a new issue, #5322: URL: https://github.com/apache/openwhisk/issues/5322 The new scheduler will send a container creation message from the scheduler to the invoker over kafka. When this message is consumed in the invoker, it immediately does a get from the artifact db to r

[GitHub] [openwhisk] bdoyle0182 closed pull request #5305: add config to fail async scheduler throttles as whisk errors

bdoyle0182 closed pull request #5305: add config to fail async scheduler throttles as whisk errors URL: https://github.com/apache/openwhisk/pull/5305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [openwhisk] bdoyle0182 merged pull request #5320: add error handling to container manager when invoker query fails

bdoyle0182 merged PR #5320: URL: https://github.com/apache/openwhisk/pull/5320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwh

[GitHub] [openwhisk] codecov-commenter commented on pull request #5320: add error handling to container manager when invoker query fails

codecov-commenter commented on PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#issuecomment-1233546167 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

bdoyle0182 commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r960042504 ## tests/src/test/scala/org/apache/openwhisk/core/scheduler/container/test/ContainerManagerTests.scala: ## @@ -910,6 +910,49 @@ class ContainerManagerTests

[GitHub] [openwhisk] style95 commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

style95 commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959366630 ## tests/src/test/scala/org/apache/openwhisk/core/scheduler/container/test/ContainerManagerTests.scala: ## @@ -910,6 +910,49 @@ class ContainerManagerTests No

[GitHub] [openwhisk] ningyougang commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

ningyougang commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959366380 ## tests/src/test/scala/org/apache/openwhisk/core/scheduler/container/test/ContainerManagerTests.scala: ## @@ -910,6 +910,49 @@ class ContainerManagerTests

[GitHub] [openwhisk] style95 commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

style95 commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959366630 ## tests/src/test/scala/org/apache/openwhisk/core/scheduler/container/test/ContainerManagerTests.scala: ## @@ -910,6 +910,49 @@ class ContainerManagerTests No

[GitHub] [openwhisk] ningyougang commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

ningyougang commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959366380 ## tests/src/test/scala/org/apache/openwhisk/core/scheduler/container/test/ContainerManagerTests.scala: ## @@ -910,6 +910,49 @@ class ContainerManagerTests

[GitHub] [openwhisk] ningyougang commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

ningyougang commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959355220 ## core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/ContainerManager.scala: ## @@ -144,6 +144,11 @@ class ContainerManager(jobManagerFac

[GitHub] [openwhisk] Rajiv2605 opened a new issue, #5321: Not able to run any function in Openwhisk after running a empty file action

Rajiv2605 opened a new issue, #5321: URL: https://github.com/apache/openwhisk/issues/5321 ## Environment details: * **Kubernetes** v1.22.6 * **Ubuntu** 20.04.4 LTS * **Docker** 20.10.12, build 20.10.12-0ubuntu2~20.04.1 ## Steps to reproduce the issue: I had an Openw

[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

bdoyle0182 commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959211216 ## core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/ContainerManager.scala: ## @@ -144,6 +144,11 @@ class ContainerManager(jobManagerFact

[GitHub] [openwhisk] ningyougang commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

ningyougang commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959168882 ## core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/ContainerManager.scala: ## @@ -144,6 +144,11 @@ class ContainerManager(jobManagerFac

[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

bdoyle0182 commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959200114 ## core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/ContainerManager.scala: ## @@ -144,6 +144,11 @@ class ContainerManager(jobManagerFact

[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

bdoyle0182 commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959200114 ## core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/ContainerManager.scala: ## @@ -144,6 +144,11 @@ class ContainerManager(jobManagerFact

[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

bdoyle0182 commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959200114 ## core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/ContainerManager.scala: ## @@ -144,6 +144,11 @@ class ContainerManager(jobManagerFact

[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

bdoyle0182 commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959200114 ## core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/ContainerManager.scala: ## @@ -144,6 +144,11 @@ class ContainerManager(jobManagerFact

[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

bdoyle0182 commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959200114 ## core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/ContainerManager.scala: ## @@ -144,6 +144,11 @@ class ContainerManager(jobManagerFact

[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

bdoyle0182 commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959200114 ## core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/ContainerManager.scala: ## @@ -144,6 +144,11 @@ class ContainerManager(jobManagerFact

[GitHub] [openwhisk] ningyougang commented on a diff in pull request #5320: add error handling to container manager when invoker query fails

ningyougang commented on code in PR #5320: URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959168882 ## core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/ContainerManager.scala: ## @@ -144,6 +144,11 @@ class ContainerManager(jobManagerFac

[GitHub] [openwhisk] style95 closed issue #5312: [Bug] When scheduling container creation, disabled invokers are used when there are warmed containers in them.

style95 closed issue #5312: [Bug] When scheduling container creation, disabled invokers are used when there are warmed containers in them. URL: https://github.com/apache/openwhisk/issues/5312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [openwhisk] style95 commented on issue #5312: [Bug] When scheduling container creation, disabled invokers are used when there are warmed containers in them.

style95 commented on issue #5312: URL: https://github.com/apache/openwhisk/issues/5312#issuecomment-1232336725 closed by #5313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [openwhisk] bdoyle0182 opened a new pull request, #5320: add error handling to container manager when invoker query fails

bdoyle0182 opened a new pull request, #5320: URL: https://github.com/apache/openwhisk/pull/5320 There is no failure handling if ## Description There is no failure handling if the query to etcd for list of healthy invokers fails. The container manager swallows the message and the m

[GitHub] [openwhisk] bdoyle0182 commented on issue #5312: [Bug] When scheduling container creation, disabled invokers are used when there are warmed containers in them.

bdoyle0182 commented on issue #5312: URL: https://github.com/apache/openwhisk/issues/5312#issuecomment-1231999881 @style95 good to close? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [openwhisk] SirHao closed issue #5319: How to deploy openwhisk with source code?

SirHao closed issue #5319: How to deploy openwhisk with source code? URL: https://github.com/apache/openwhisk/issues/5319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [openwhisk] SirHao commented on issue #5319: How to deploy openwhisk with source code?

SirHao commented on issue #5319: URL: https://github.com/apache/openwhisk/issues/5319#issuecomment-1231587771 > https://github.com/apache/openwhisk-deploy-kube#deploying-a-locally-built-docker-image Thanks -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [openwhisk] dgrove-oss commented on issue #5319: How to deploy openwhisk with source code?

dgrove-oss commented on issue #5319: URL: https://github.com/apache/openwhisk/issues/5319#issuecomment-1231586716 https://github.com/apache/openwhisk-deploy-kube#deploying-a-locally-built-docker-image -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [openwhisk] SirHao commented on issue #5319: How to deploy openwhisk with source code?

SirHao commented on issue #5319: URL: https://github.com/apache/openwhisk/issues/5319#issuecomment-1231491977 > You can deploy OpenWhisk with [Ansible](https://github.com/apache/openwhisk/tree/master/ansible#deploying-openwhisk-using-ansible) or a [Helm chart](https://github.com/apache/open

[GitHub] [openwhisk] SirHao commented on issue #5319: How to deploy openwhisk with source code?

SirHao commented on issue #5319: URL: https://github.com/apache/openwhisk/issues/5319#issuecomment-1231491566 > Thank u for help. Now I guess I can build the source code by ansible. But I still confused about the deploy method of using helm chart. I see lots of configure files and I gues

[GitHub] [openwhisk] style95 commented on issue #5319: How to deploy openwhisk with source code?

style95 commented on issue #5319: URL: https://github.com/apache/openwhisk/issues/5319#issuecomment-1231454627 You can deploy OpenWhisk with [Ansible](https://github.com/apache/openwhisk/tree/master/ansible#deploying-openwhisk-using-ansible) or a [Helm chart](https://github.com/apache/openw

[GitHub] [openwhisk-deploy-kube] SirHao closed issue #750: How to deploy openwhisk with source code

SirHao closed issue #750: How to deploy openwhisk with source code URL: https://github.com/apache/openwhisk-deploy-kube/issues/750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [openwhisk] SirHao opened a new issue, #5319: How to deploy openwhisk with source code?

SirHao opened a new issue, #5319: URL: https://github.com/apache/openwhisk/issues/5319 I am trying to modify the logic of openwhisk controller and invoker for acadmic research. How can I build Openwhisk with modifed code and deploy it into a cluster? -- This is an automated message fro

[GitHub] [openwhisk-deploy-kube] SirHao opened a new issue, #750: How to deploy openwhisk with source code

SirHao opened a new issue, #750: URL: https://github.com/apache/openwhisk-deploy-kube/issues/750 I am trying to modify the logic of openwhisk controller and invoker for acadmic research. How can I build Openwhisk with modifed code? -- This is an automated message from the Apache Git S

[GitHub] [openwhisk-cli] ningyougang commented on pull request #516: Support array result

ningyougang commented on PR #516: URL: https://github.com/apache/openwhisk-cli/pull/516#issuecomment-1230987397 Closed as https://github.com/apache/openwhisk-cli/pull/517 merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [openwhisk-cli] ningyougang closed pull request #516: Support array result

ningyougang closed pull request #516: Support array result URL: https://github.com/apache/openwhisk-cli/pull/516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [openwhisk-cli] ningyougang merged pull request #517: Fix deprecated issue & Support array result

ningyougang merged PR #517: URL: https://github.com/apache/openwhisk-cli/pull/517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ope

[GitHub] [openwhisk-cli] ningyougang commented on a diff in pull request #517: Fix deprecated issue & Support array result

ningyougang commented on code in PR #517: URL: https://github.com/apache/openwhisk-cli/pull/517#discussion_r957031960 ## settings.gradle: ## @@ -25,10 +25,14 @@ gradle.ext.openwhisk = [ gradle.ext.scala = [ version: '2.12.7', -compileFlags: ['-feature', '-unchecked',

[GitHub] [openwhisk-runtime-go] 0x161e-swei opened a new pull request, #176: Add mutex lock to safe-guard bufio.Reader access in Executor

0x161e-swei opened a new pull request, #176: URL: https://github.com/apache/openwhisk-runtime-go/pull/176 bufio is not thread/goroutine safe. Under high concurrency, the executor may read in multiple responses or empty response from the underlying process. -- This is an automated mess

<    1   2   3   4   5   6   7   8   9   10   >