[jira] [Commented] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

[ https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180006#comment-17180006 ] Thomas D'Silva commented on PHOENIX-6083: - Nice find. > View index creation do

[jira] [Commented] (PHOENIX-6072) SYSTEM.MUTEX not created with a TTL on a fresh cluster connected to by a 4.15+ client

[ https://issues.apache.org/jira/browse/PHOENIX-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176523#comment-17176523 ] Thomas D'Silva commented on PHOENIX-6072: - [~ckulkarni]  Nice catch, the fix so

[jira] [Commented] (PHOENIX-5958) Diverged view created via an older client still sees dropped column data

[ https://issues.apache.org/jira/browse/PHOENIX-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164141#comment-17164141 ] Thomas D'Silva commented on PHOENIX-5958: - I think we ignored the mutations tha

[jira] [Commented] (PHOENIX-6033) Unable to add back a parent column that was earlier dropped from a view

[ https://issues.apache.org/jira/browse/PHOENIX-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162301#comment-17162301 ] Thomas D'Silva commented on PHOENIX-6033: - You are right this can be supported,

[jira] [Commented] (PHOENIX-6033) Unable to add back a parent column that was earlier dropped from a view

[ https://issues.apache.org/jira/browse/PHOENIX-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161702#comment-17161702 ] Thomas D'Silva commented on PHOENIX-6033: - We just decided to not allow adding

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161701#comment-17161701 ] Thomas D'Silva commented on PHOENIX-6032: - The excluded column row should be ad

[jira] [Commented] (PHOENIX-6025) alter view column doesn't update ordinal position

[ https://issues.apache.org/jira/browse/PHOENIX-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160567#comment-17160567 ] Thomas D'Silva commented on PHOENIX-6025: - For views {{ViewUtil.addDerivedColum

[jira] [Commented] (PHOENIX-5958) Diverged view created via an older client still sees dropped column data

[ https://issues.apache.org/jira/browse/PHOENIX-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159707#comment-17159707 ] Thomas D'Silva commented on PHOENIX-5958: - Looking at the code in addDerivedCol

[jira] [Commented] (PHOENIX-5958) Diverged view created via an older client still sees dropped column data

[ https://issues.apache.org/jira/browse/PHOENIX-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159700#comment-17159700 ] Thomas D'Silva commented on PHOENIX-5958: - [~ckulkarni] Its been a while since

[jira] [Commented] (PHOENIX-5404) Move check to client side to see if there are any child views that need to be dropped while receating a table/view

[ https://issues.apache.org/jira/browse/PHOENIX-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110819#comment-17110819 ] Thomas D'Silva commented on PHOENIX-5404: - If we drop the orphaned child views

[jira] [Commented] (PHOENIX-5404) Move check to client side to see if there are any child views that need to be dropped while receating a table/view

[ https://issues.apache.org/jira/browse/PHOENIX-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110698#comment-17110698 ] Thomas D'Silva commented on PHOENIX-5404: - Can we check if the table/view being

[jira] [Commented] (PHOENIX-4475) Change PhoenixRuntime.getTable to fetch the latest metadata of the table being looked up

[ https://issues.apache.org/jira/browse/PHOENIX-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993229#comment-16993229 ] Thomas D'Silva commented on PHOENIX-4475: - When we run a query we make an rpc t

[jira] [Commented] (PHOENIX-5584) Older clients don't get correct view metadata when a 4.15 client creates a view

[ https://issues.apache.org/jira/browse/PHOENIX-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981884#comment-16981884 ] Thomas D'Silva commented on PHOENIX-5584: - +1 on v4. > Older clients don't get

[jira] [Commented] (PHOENIX-5584) Older clients don't get correct view metadata when a 4.15 client creates a view

[ https://issues.apache.org/jira/browse/PHOENIX-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981791#comment-16981791 ] Thomas D'Silva commented on PHOENIX-5584: - https://issues.apache.org/jira/brows

[jira] [Commented] (PHOENIX-5584) Older clients don't get correct view metadata when a 4.15 client creates a view

[ https://issues.apache.org/jira/browse/PHOENIX-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981314#comment-16981314 ] Thomas D'Silva commented on PHOENIX-5584: - The {{doGetTable}} will only work as

[jira] [Commented] (PHOENIX-5584) old client can't get right view metadata when 4.15 client created view

[ https://issues.apache.org/jira/browse/PHOENIX-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980975#comment-16980975 ] Thomas D'Silva commented on PHOENIX-5584: - I agree, best to change the default

[jira] [Commented] (PHOENIX-5584) old client can't get right view metadata when 4.15 client created view

[ https://issues.apache.org/jira/browse/PHOENIX-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980970#comment-16980970 ] Thomas D'Silva commented on PHOENIX-5584: - In {{MetaDataSplitPolicy}} we only a

[jira] [Commented] (PHOENIX-5584) old client can't get right view metadata when 4.15 client created view

[ https://issues.apache.org/jira/browse/PHOENIX-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980965#comment-16980965 ] Thomas D'Silva commented on PHOENIX-5584: - Thinking about this some more, for o

[jira] [Commented] (PHOENIX-5584) old client can't get right view metadata when 4.15 client created view

[ https://issues.apache.org/jira/browse/PHOENIX-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980869#comment-16980869 ] Thomas D'Silva commented on PHOENIX-5584: - [~larsh] {{phoenix.allow.system.cat

[jira] [Commented] (PHOENIX-5584) old client can't get right view metadata when 4.15 client created view

[ https://issues.apache.org/jira/browse/PHOENIX-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980603#comment-16980603 ] Thomas D'Silva commented on PHOENIX-5584: - [~yanxinyi] the query from the 4.14

[jira] [Commented] (PHOENIX-5545) DropChildViews Task fails for a base table when its child view has an index

[ https://issues.apache.org/jira/browse/PHOENIX-5545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974808#comment-16974808 ] Thomas D'Silva commented on PHOENIX-5545: - +1, thanks for fix these issues. >

[jira] [Commented] (PHOENIX-5546) TASK_TS being set as HConstants.LATEST_TIMESTAMP in SYSTEM.TASK table

[ https://issues.apache.org/jira/browse/PHOENIX-5546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971974#comment-16971974 ] Thomas D'Silva commented on PHOENIX-5546: - I believe using STORE_NULLS for SYST

[jira] [Commented] (PHOENIX-5544) Dropping a base table with cascade with an older client does not clear all child view metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960507#comment-16960507 ] Thomas D'Silva commented on PHOENIX-5544: - Creating a view with an old client a

[jira] [Commented] (PHOENIX-5546) TASK_TS being set as HConstants.LATEST_TIMESTAMP in SYSTEM.TASK table

[ https://issues.apache.org/jira/browse/PHOENIX-5546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960160#comment-16960160 ] Thomas D'Silva commented on PHOENIX-5546: - For ROW_TIMESTAMP I think we set the

[jira] [Commented] (PHOENIX-5544) Dropping a base table with cascade with an older client does not clear all child view metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959500#comment-16959500 ] Thomas D'Silva commented on PHOENIX-5544: - For the case when you have a 4.14 cl

[jira] [Commented] (PHOENIX-5103) Can't create/drop table using 4.14 client against 4.15 server

[ https://issues.apache.org/jira/browse/PHOENIX-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957543#comment-16957543 ] Thomas D'Silva commented on PHOENIX-5103: - Are you are referring to this code :

[jira] [Commented] (PHOENIX-5533) Creating a view or index with a 4.14 client and 4.15.0 server fails with a NullPointerException

[ https://issues.apache.org/jira/browse/PHOENIX-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957544#comment-16957544 ] Thomas D'Silva commented on PHOENIX-5533: - +1 > Creating a view or index with

[jira] [Commented] (PHOENIX-5533) Creating a view or index with a 4.14 client and 4.15.0 server fails with a NullPointerException

[ https://issues.apache.org/jira/browse/PHOENIX-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956511#comment-16956511 ] Thomas D'Silva commented on PHOENIX-5533: - Yes, for #1 we call doGetTable a sec

[jira] [Commented] (PHOENIX-5533) Creating a view or index with a 4.14 client and 4.15.0 server fails with a NullPointerException

[ https://issues.apache.org/jira/browse/PHOENIX-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956405#comment-16956405 ] Thomas D'Silva commented on PHOENIX-5533: - +1 thanks for the fix , I should hav

[jira] [Commented] (PHOENIX-4306) Add more tests for DESC sort order

[ https://issues.apache.org/jira/browse/PHOENIX-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948955#comment-16948955 ] Thomas D'Silva commented on PHOENIX-4306: - Since these are just test, I think n

[jira] [Commented] (PHOENIX-4905) Remove SpoolingResultIteratorFactory and ChunkedResultIteratorFactory

[ https://issues.apache.org/jira/browse/PHOENIX-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948190#comment-16948190 ] Thomas D'Silva commented on PHOENIX-4905: - This JIRA was dependent on using the

[jira] [Commented] (PHOENIX-5510) LoggingPhoenixConnection on close does not log with unclosed statements/result sets

[ https://issues.apache.org/jira/browse/PHOENIX-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946034#comment-16946034 ] Thomas D'Silva commented on PHOENIX-5510: - [~dbwong] what would the additional

[jira] [Commented] (PHOENIX-5499) Upgrading from 4.14.3 client to 4.15.0 client does not remove parent->child links from SYSTEM.CATALOG

[ https://issues.apache.org/jira/browse/PHOENIX-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944991#comment-16944991 ] Thomas D'Silva commented on PHOENIX-5499: - +1 Thanks for fixing this. > Upgrad

[jira] [Commented] (PHOENIX-4306) Add more tests for DESC sort order

[ https://issues.apache.org/jira/browse/PHOENIX-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944626#comment-16944626 ] Thomas D'Silva commented on PHOENIX-4306: - [~mihir6692] can you please commit t

[jira] [Commented] (PHOENIX-5499) Upgrading from 4.14.3 client to 4.15.0 client does not remove parent->child links from SYSTEM.CATALOG

[ https://issues.apache.org/jira/browse/PHOENIX-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942243#comment-16942243 ] Thomas D'Silva commented on PHOENIX-5499: - I didn't notice that, that should wo

[jira] [Commented] (PHOENIX-5499) Upgrading from 4.14.3 client to 4.15.0 client does not remove parent->child links from SYSTEM.CATALOG

[ https://issues.apache.org/jira/browse/PHOENIX-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942206#comment-16942206 ] Thomas D'Silva commented on PHOENIX-5499: - Should be possible to just pass in t

[jira] [Commented] (PHOENIX-5499) Upgrading from 4.14.3 client to 4.15.0 client does not remove parent->child links from SYSTEM.CATALOG

[ https://issues.apache.org/jira/browse/PHOENIX-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939830#comment-16939830 ] Thomas D'Silva commented on PHOENIX-5499: - Nice find, this is a bug with {{move

[jira] [Commented] (PHOENIX-4810) Send parent->child link mutations to SYSTEM.CHILD_LINK table in MetdataClient.createTableInternal

[ https://issues.apache.org/jira/browse/PHOENIX-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938135#comment-16938135 ] Thomas D'Silva commented on PHOENIX-4810: - Good catch, the client should handle

[jira] [Commented] (PHOENIX-4306) Add more tests for DESC sort order

[ https://issues.apache.org/jira/browse/PHOENIX-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938132#comment-16938132 ] Thomas D'Silva commented on PHOENIX-4306: - +1 please resolve PHOENIX-3996 as in

[jira] [Commented] (PHOENIX-4306) Add more tests for DESC sort order

[ https://issues.apache.org/jira/browse/PHOENIX-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16936968#comment-16936968 ] Thomas D'Silva commented on PHOENIX-4306: - Can you also include a test for the

[jira] [Commented] (PHOENIX-4810) Send parent->child link mutations to SYSTEM.CHILD_LINK table in MetdataClient.createTableInternal

[ https://issues.apache.org/jira/browse/PHOENIX-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934814#comment-16934814 ] Thomas D'Silva commented on PHOENIX-4810: - I think this can be fixed in 4.16, s

[jira] [Commented] (PHOENIX-5322) Upsert on a view of an indexed table fails with ArrayIndexOutOfBound Exception

[ https://issues.apache.org/jira/browse/PHOENIX-5322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926210#comment-16926210 ] Thomas D'Silva commented on PHOENIX-5322: - This looks like a bug to me, as Jame

[jira] [Commented] (PHOENIX-4306) Add more tests for DESC sort order

[ https://issues.apache.org/jira/browse/PHOENIX-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921576#comment-16921576 ] Thomas D'Silva commented on PHOENIX-4306: - That sounds like the right approach.

[jira] [Comment Edited] (PHOENIX-4878) Remove SharedTableState and replace with PTable

[ https://issues.apache.org/jira/browse/PHOENIX-4878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916875#comment-16916875 ] Thomas D'Silva edited comment on PHOENIX-4878 at 8/27/19 5:02 PM: ---

[jira] [Commented] (PHOENIX-4878) Remove SharedTableState and replace with PTable

[ https://issues.apache.org/jira/browse/PHOENIX-4878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916875#comment-16916875 ] Thomas D'Silva commented on PHOENIX-4878: - That looks like a separate issue, if

[jira] [Commented] (PHOENIX-4878) Remove SharedTableState and replace with PTable

[ https://issues.apache.org/jira/browse/PHOENIX-4878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910076#comment-16910076 ] Thomas D'Silva commented on PHOENIX-4878: -   [~yanxinyi]  looks pretty good. Ca

[jira] [Commented] (PHOENIX-5418) ResultTest failure in phoenix-pherf

[ https://issues.apache.org/jira/browse/PHOENIX-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899279#comment-16899279 ] Thomas D'Silva commented on PHOENIX-5418: - I think you just have to set the sce

[jira] [Commented] (PHOENIX-5316) Use callable instead of runnable so that Pherf exceptions cause tests to fail

[ https://issues.apache.org/jira/browse/PHOENIX-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899238#comment-16899238 ] Thomas D'Silva commented on PHOENIX-5316: - That isn't the right fix, its not va

[jira] [Commented] (PHOENIX-5418) ResultTest failure in phoenix-pherf

[ https://issues.apache.org/jira/browse/PHOENIX-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899178#comment-16899178 ] Thomas D'Silva commented on PHOENIX-5418: - Can you post the complete stack trac

[jira] [Commented] (PHOENIX-5416) Fix Array2IT testArrayRefToLiteral

[ https://issues.apache.org/jira/browse/PHOENIX-5416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899023#comment-16899023 ] Thomas D'Silva commented on PHOENIX-5416: - Looks like the getMaxLength() for th

[jira] [Commented] (PHOENIX-5416) Fix Array2IT testArrayRefToLiteral

[ https://issues.apache.org/jira/browse/PHOENIX-5416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897414#comment-16897414 ] Thomas D'Silva commented on PHOENIX-5416: - It fails after PHOENIX-5403, I just

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896648#comment-16896648 ] Thomas D'Silva commented on PHOENIX-4845: - Even for salter tables I think you w

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896602#comment-16896602 ] Thomas D'Silva commented on PHOENIX-4845: - You will need to think through if OF

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896571#comment-16896571 ] Thomas D'Silva commented on PHOENIX-4845: - If the user wants to use RVC offset

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896557#comment-16896557 ] Thomas D'Silva commented on PHOENIX-4845: - I am not clear why you cannot simply

[jira] [Commented] (PHOENIX-5104) PHOENIX-3547 breaks client backwards compatability

[ https://issues.apache.org/jira/browse/PHOENIX-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894828#comment-16894828 ] Thomas D'Silva commented on PHOENIX-5104: - [~m2je] the patch does not apply cle

[jira] [Commented] (PHOENIX-5403) Optimize metadata cache lookup of global tables using a tenant specific connection

[ https://issues.apache.org/jira/browse/PHOENIX-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894827#comment-16894827 ] Thomas D'Silva commented on PHOENIX-5403: - [~ckulkarni] can you please review?

[jira] [Commented] (PHOENIX-4893) Move parent column combining logic of view and view indexes from server to client

[ https://issues.apache.org/jira/browse/PHOENIX-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889624#comment-16889624 ] Thomas D'Silva commented on PHOENIX-4893: - I just modified the jenkins job to e

[jira] [Commented] (PHOENIX-4893) Move parent column combining logic of view and view indexes from server to client

[ https://issues.apache.org/jira/browse/PHOENIX-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889617#comment-16889617 ] Thomas D'Silva commented on PHOENIX-4893: - Thanks for the fix [~lhofhansl], the

[jira] [Commented] (PHOENIX-5275) Remove accidental imports from curator-client-2.12.0

[ https://issues.apache.org/jira/browse/PHOENIX-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889175#comment-16889175 ] Thomas D'Silva commented on PHOENIX-5275: - I will see if I can change the jenki

[jira] [Commented] (PHOENIX-4195) PHOENIX-4195 Deleting view rows with extended PKs through the base table silently fails

[ https://issues.apache.org/jira/browse/PHOENIX-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887346#comment-16887346 ] Thomas D'Silva commented on PHOENIX-4195: - FYI [~sukuna...@gmail.com] [~abhishe

[jira] [Commented] (PHOENIX-5275) Remove accidental imports from curator-client-2.12.0

[ https://issues.apache.org/jira/browse/PHOENIX-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886301#comment-16886301 ] Thomas D'Silva commented on PHOENIX-5275: - [~willshen] , sorry for the delay th

[jira] [Commented] (PHOENIX-5327) PherfMainIT fails with duplicate TABLE/INDEX.

[ https://issues.apache.org/jira/browse/PHOENIX-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885651#comment-16885651 ] Thomas D'Silva commented on PHOENIX-5327: - [~mihir6692], I think the tests are

[jira] [Commented] (PHOENIX-4861) While adding a view column make a single RPC to update the encoded column qualifier counter and remove the table from the cache of the physical table

[ https://issues.apache.org/jira/browse/PHOENIX-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884821#comment-16884821 ] Thomas D'Silva commented on PHOENIX-4861: - In MetadataClient the encoded col qu

[jira] [Commented] (PHOENIX-5389) Push down PostFilter to Sub-JoinTable for SortMergeJoin and NoStarJoin

[ https://issues.apache.org/jira/browse/PHOENIX-5389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884779#comment-16884779 ] Thomas D'Silva commented on PHOENIX-5389: - +1 > Push down PostFilter to Sub-Jo

[jira] [Commented] (PHOENIX-5136) Rows with null values inserted by UPSERT .. ON DUPLICATE KEY UPDATE are included in query results when they shouldn't be

[ https://issues.apache.org/jira/browse/PHOENIX-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884065#comment-16884065 ] Thomas D'Silva commented on PHOENIX-5136: - [~hnguyen08] For a table that has "O

[jira] [Commented] (PHOENIX-5136) Rows with null values inserted by UPSERT .. ON DUPLICATE KEY UPDATE are included in query results when they shouldn't be

[ https://issues.apache.org/jira/browse/PHOENIX-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884013#comment-16884013 ] Thomas D'Silva commented on PHOENIX-5136: - [~hnguyen08] [~mspielberg] Can you p

[jira] [Commented] (PHOENIX-5290) HashJoinMoreIT is flapping

[ https://issues.apache.org/jira/browse/PHOENIX-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883321#comment-16883321 ] Thomas D'Silva commented on PHOENIX-5290: - I don't think any of us are very fam

[jira] [Commented] (PHOENIX-5327) PherfMainIT fails with duplicate TABLE/INDEX.

[ https://issues.apache.org/jira/browse/PHOENIX-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16880614#comment-16880614 ] Thomas D'Silva commented on PHOENIX-5327: - LGTM [~mihir6692], can you also plea

[jira] [Commented] (PHOENIX-5268) HBase 2.0.5 compatibility

[ https://issues.apache.org/jira/browse/PHOENIX-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879454#comment-16879454 ] Thomas D'Silva commented on PHOENIX-5268: - ping [~elserj], are you still workin

[jira] [Commented] (PHOENIX-5170) Update meta timestamp of parent table when dropping index

[ https://issues.apache.org/jira/browse/PHOENIX-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879452#comment-16879452 ] Thomas D'Silva commented on PHOENIX-5170: - [~gabry] Are you saying that after t

[jira] [Commented] (PHOENIX-5383) Metrics for the IndexRegionObserver coprocesor

[ https://issues.apache.org/jira/browse/PHOENIX-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879448#comment-16879448 ] Thomas D'Silva commented on PHOENIX-5383: - [~priyankporwal] is someone planning

[jira] [Commented] (PHOENIX-5103) Can't create/drop table using 4.14 client against 4.15 server

[ https://issues.apache.org/jira/browse/PHOENIX-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879431#comment-16879431 ] Thomas D'Silva commented on PHOENIX-5103: - [~ckulkarni] Thats a good point, let

[jira] [Comment Edited] (PHOENIX-5103) Can't create/drop table using 4.14 client against 4.15 server

[ https://issues.apache.org/jira/browse/PHOENIX-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879411#comment-16879411 ] Thomas D'Silva edited comment on PHOENIX-5103 at 7/5/19 4:35 PM:

[jira] [Commented] (PHOENIX-5103) Can't create/drop table using 4.14 client against 4.15 server

[ https://issues.apache.org/jira/browse/PHOENIX-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879411#comment-16879411 ] Thomas D'Silva commented on PHOENIX-5103: - [~ckulkarni] While adding a column w

[jira] [Commented] (PHOENIX-5381) Increase phoenix.task.handling.interval.ms to 10s for tests

[ https://issues.apache.org/jira/browse/PHOENIX-5381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875422#comment-16875422 ] Thomas D'Silva commented on PHOENIX-5381: - Lgtm > Increase phoenix.task.handli

[jira] [Commented] (PHOENIX-4893) Move parent column combining logic of view and view indexes from server to client

[ https://issues.apache.org/jira/browse/PHOENIX-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874384#comment-16874384 ] Thomas D'Silva commented on PHOENIX-4893: - Yeah thinking about this some more,

[jira] [Commented] (PHOENIX-4893) Move parent column combining logic of view and view indexes from server to client

[ https://issues.apache.org/jira/browse/PHOENIX-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872982#comment-16872982 ] Thomas D'Silva commented on PHOENIX-4893: - I was trying to decide if this jira,

[jira] [Commented] (PHOENIX-4846) WhereOptimizer.pushKeyExpressionsToScan() does not work correctly if the sort order of pk columns being filtered on changes

[ https://issues.apache.org/jira/browse/PHOENIX-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872954#comment-16872954 ] Thomas D'Silva commented on PHOENIX-4846: - [~dsmwong] any chance you can work o

[jira] [Commented] (PHOENIX-5370) Address RAT failures

[ https://issues.apache.org/jira/browse/PHOENIX-5370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872950#comment-16872950 ] Thomas D'Silva commented on PHOENIX-5370: - [~elserj] Sorry for missing this, th

[jira] [Commented] (PHOENIX-5371) SystemCatalogCreationOnConnectionIT is slow

[ https://issues.apache.org/jira/browse/PHOENIX-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872949#comment-16872949 ] Thomas D'Silva commented on PHOENIX-5371: - I haven't worked on this test. testM

[jira] [Commented] (PHOENIX-5313) All mappers grab all RegionLocations from .META

[ https://issues.apache.org/jira/browse/PHOENIX-5313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867252#comment-16867252 ] Thomas D'Silva commented on PHOENIX-5313: - I think your proposed solution makes

[jira] [Commented] (PHOENIX-5318) Slots passed to SkipScan filter is incorrect for desc primary keys that are prefixes of each other

[ https://issues.apache.org/jira/browse/PHOENIX-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866152#comment-16866152 ] Thomas D'Silva commented on PHOENIX-5318: - Yes this should be applied to the st

[jira] [Commented] (PHOENIX-5308) Unable to run the some end2end tests in real cluster mainly the once using accessing hbase internals from minihbasecluster or custom coprocessors

[ https://issues.apache.org/jira/browse/PHOENIX-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865276#comment-16865276 ] Thomas D'Silva commented on PHOENIX-5308: - +1 LGTM > Unable to run the some en

[jira] [Comment Edited] (PHOENIX-5332) Fix slow running Integration Tests

[ https://issues.apache.org/jira/browse/PHOENIX-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864585#comment-16864585 ] Thomas D'Silva edited comment on PHOENIX-5332 at 6/15/19 3:27 AM: ---

[jira] [Commented] (PHOENIX-5332) Fix slow running Integration Tests

[ https://issues.apache.org/jira/browse/PHOENIX-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864585#comment-16864585 ] Thomas D'Silva commented on PHOENIX-5332: - [~lhofhansl] I think these are being

[jira] [Commented] (PHOENIX-5269) PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission checks

[ https://issues.apache.org/jira/browse/PHOENIX-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863856#comment-16863856 ] Thomas D'Silva commented on PHOENIX-5269: - [~kiran.maturi] I was able to get th

[jira] [Commented] (PHOENIX-5269) PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission checks

[ https://issues.apache.org/jira/browse/PHOENIX-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861970#comment-16861970 ] Thomas D'Silva commented on PHOENIX-5269: - [~kiran.maturi] if you add a getRegi

[jira] [Comment Edited] (PHOENIX-5269) PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission checks

[ https://issues.apache.org/jira/browse/PHOENIX-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859703#comment-16859703 ] Thomas D'Silva edited comment on PHOENIX-5269 at 6/12/19 7:53 AM: ---

[jira] [Commented] (PHOENIX-5335) Fix ViewIT

[ https://issues.apache.org/jira/browse/PHOENIX-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861798#comment-16861798 ] Thomas D'Silva commented on PHOENIX-5335: - Thanks [~lhofhansl], I will take a l

[jira] [Comment Edited] (PHOENIX-5269) PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission checks

[ https://issues.apache.org/jira/browse/PHOENIX-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859703#comment-16859703 ] Thomas D'Silva edited comment on PHOENIX-5269 at 6/10/19 5:04 AM: ---

[jira] [Commented] (PHOENIX-5269) PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission checks

[ https://issues.apache.org/jira/browse/PHOENIX-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859703#comment-16859703 ] Thomas D'Silva commented on PHOENIX-5269: - [~lhofhansl], my bad, I wanted to i

[jira] [Commented] (PHOENIX-5325) Some pherf tests are failing

[ https://issues.apache.org/jira/browse/PHOENIX-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859130#comment-16859130 ] Thomas D'Silva commented on PHOENIX-5325: - +1 LGTM, sorry for missing this. >

[jira] [Commented] (PHOENIX-5294) getIndexes() on a view should return only the indexes on that view

[ https://issues.apache.org/jira/browse/PHOENIX-5294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858967#comment-16858967 ] Thomas D'Silva commented on PHOENIX-5294: - What do you mean by duplicate entrie

[jira] [Commented] (PHOENIX-4306) Add more tests for DESC sort order

[ https://issues.apache.org/jira/browse/PHOENIX-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858890#comment-16858890 ] Thomas D'Silva commented on PHOENIX-4306: - >From PR on PHOENIX-5318 "Ok I look

[jira] [Commented] (PHOENIX-5122) PHOENIX-4322 breaks client backward compatibility

[ https://issues.apache.org/jira/browse/PHOENIX-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858237#comment-16858237 ] Thomas D'Silva commented on PHOENIX-5122: - After talking offline, I understand

[jira] [Commented] (PHOENIX-5122) PHOENIX-4322 breaks client backward compatibility

[ https://issues.apache.org/jira/browse/PHOENIX-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858233#comment-16858233 ] Thomas D'Silva commented on PHOENIX-5122: - writeBoolean ends up writing a byte

[jira] [Commented] (PHOENIX-5122) PHOENIX-4322 breaks client backward compatibility

[ https://issues.apache.org/jira/browse/PHOENIX-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858225#comment-16858225 ] Thomas D'Silva commented on PHOENIX-5122: - [~jisaac] The latest patch doesn't c

[jira] [Commented] (PHOENIX-5269) PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission checks

[ https://issues.apache.org/jira/browse/PHOENIX-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858078#comment-16858078 ] Thomas D'Silva commented on PHOENIX-5269: - ping [~kiran.maturi], still waiting

[jira] [Commented] (PHOENIX-5311) Integration tests leak tables when running on distributed cluster

[ https://issues.apache.org/jira/browse/PHOENIX-5311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858014#comment-16858014 ] Thomas D'Silva commented on PHOENIX-5311: - LGTM any change you can review and c

  1   2   3   4   5   >