Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/423
@jmahonin Thanks for the review. The Datasource V2 API is marked evolving
and the API changed from Spark 2.3 to 2.4 and it will change again in Spark
3.0. The DataSource v2 connector
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/423#discussion_r245397674
--- Diff:
phoenix-spark/src/it/scala/org/apache/phoenix/spark/AbstractPhoenixSparkIT.scala
---
@@ -50,7 +51,7 @@ class AbstractPhoenixSparkIT extends
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/423
@vincentpoon can you review?
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/424#discussion_r245188153
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/BaseExpression.java ---
@@ -255,4 +255,15 @@ public boolean requiresFinalEvaluation
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/424#discussion_r245187754
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/BaseExpression.java ---
@@ -255,4 +255,15 @@ public boolean requiresFinalEvaluation
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/416#discussion_r245172433
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/query/PhoenixStatsCacheLoaderTest.java
---
@@ -0,0 +1,123 @@
+/*
+ * Licensed
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/424#discussion_r245145423
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/BaseExpression.java ---
@@ -255,4 +255,15 @@ public boolean requiresFinalEvaluation
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/423
@ChinmaySKulkarni can you please review ?
---
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/423
The PR adds ```PhoenixDataSource``` which implements the new [DataSourceV2
API](https://issues.apache.org/jira/browse/SPARK-15689). This will allow
further optimizations in the future
GitHub user twdsilva opened a pull request:
https://github.com/apache/phoenix/pull/423
PHOENIX-5059 Use the Datasource v2 api in the spark connector
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twdsilva/phoenix PHOENIX-5059
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/422
+1 , perhaps you can commit this PR along with the PR to create the modules
in the ```phoenix-queryserver``` repo.
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/417#discussion_r244065455
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/OrderByCompiler.java ---
@@ -88,7 +88,8 @@ public static OrderBy compile(StatementContext
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/417#discussion_r244065508
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/ExpressionUtil.java ---
@@ -68,4 +76,144 @@ public static boolean isPkPositionChanging
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/417#discussion_r244065574
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java ---
@@ -2951,6 +2951,129 @@ public void testOrderPreservingGroupBy
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/417#discussion_r244065522
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/ExpressionUtil.java ---
@@ -68,4 +76,144 @@ public static boolean isPkPositionChanging
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/419#discussion_r243718429
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java
---
@@ -154,7 +154,8 @@
public enum
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/419#discussion_r243718523
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/parse/UpdateStatisticsStatement.java
---
@@ -23,6 +23,7 @@
import java.util.Map
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/417#discussion_r243703560
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/Expression.java ---
@@ -88,4 +88,10 @@
* @return
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/417#discussion_r243703928
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/OrderByCompiler.java ---
@@ -88,7 +88,8 @@ public static OrderBy compile(StatementContext
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/420
+1 LGTM
---
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/418
+1 LGTM, nice work!
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/418#discussion_r242645365
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/OmidTransactionalProcessor.java
---
@@ -17,13 +17,16 @@
*/
package
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/405
+1
---
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/408
+1 LGTM
---
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/404
LGTM, thanks for the patch @kadirozde . @ChinmaySKulkarni can you please
complete your review and if it looks good to you, can you pleas commit this
patch?
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/405#discussion_r240321942
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertWithSCNIT.java ---
@@ -0,0 +1,137 @@
+package org.apache.phoenix.end2end
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/405#discussion_r238808710
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java ---
@@ -399,8 +401,21 @@ public Integer call() throws SQLException
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/405#discussion_r238806770
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertWithSCNIT.java ---
@@ -0,0 +1,167 @@
+package org.apache.phoenix.end2end
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/405#discussion_r238793618
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertWithSCNIT.java ---
@@ -0,0 +1,167 @@
+package org.apache.phoenix.end2end
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/405#discussion_r238808013
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
---
@@ -459,7 +459,18 @@ public SQLException newException
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/408#discussion_r238787003
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java ---
@@ -353,6 +403,18 @@ public static int getSaltBuckets(List
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/408#discussion_r238790586
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/util/MetaDataUtilTest.java ---
@@ -65,21 +100,67 @@ public void testCompatibility
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/408#discussion_r238039996
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -2340,7 +2365,7 @@ public void createTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/408#discussion_r238039864
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1447,6 +1457,12 @@ private PTable getTable
Github user twdsilva closed the pull request at:
https://github.com/apache/phoenix/pull/406
---
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/406
@karanmehta93 Can you please review?
---
GitHub user twdsilva opened a pull request:
https://github.com/apache/phoenix/pull/406
PHOENIX-4765 Add client and server side config property to enable rolâ¦
â¦lback of splittable System Catalog if required
@ChinmaySKulkarni can you please review. This PR adds a config
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/403#discussion_r232861770
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java
---
@@ -428,14 +433,78 @@ public void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/403#discussion_r232851836
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java
---
@@ -428,14 +433,78 @@ public void
Github user twdsilva closed the pull request at:
https://github.com/apache/phoenix/pull/402
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/362#discussion_r230509377
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java ---
@@ -242,6 +260,12 @@ public static Expression
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/401
Nice work @ChinmaySKulkarni , LGTM will commit after the precommit build is
run.
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/362#discussion_r226392353
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java ---
@@ -242,6 +260,12 @@ public static Expression
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/402
Thank @ChinmaySKulkarni , fixed the nits, will get this committed.
---
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/402
@ChinmaySKulkarni I removed the use of the deprecated SqlContext
constructor, please take a look.
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/402#discussion_r230130599
--- Diff: phoenix-spark/src/it/java/org/apache/phoenix/spark/OrderByIT.java
---
@@ -0,0 +1,444 @@
+package org.apache.phoenix.spark;
+
+import
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/402#discussion_r229888377
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/QueryBuilder.java ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/402
@ChinmaySKulkarni Thanks for the review, I have updated the PR please take
a look.
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/402#discussion_r229900126
--- Diff:
phoenix-spark/src/it/java/org/apache/phoenix/spark/AggregateIT.java ---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/402#discussion_r229898379
--- Diff:
phoenix-spark/src/it/java/org/apache/phoenix/spark/AggregateIT.java ---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/402#discussion_r229889139
--- Diff: phoenix-spark/pom.xml ---
@@ -487,6 +487,16 @@
src/it/scala
src/it/resources
+
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/402#discussion_r229889444
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AggregateIT.java ---
@@ -17,507 +17,29 @@
*/
package org.apache.phoenix.end2end
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/402#discussion_r229897850
--- Diff:
phoenix-spark/src/it/java/org/apache/phoenix/spark/AggregateIT.java ---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/402#discussion_r229885734
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AggregateIT.java ---
@@ -17,507 +17,29 @@
*/
package org.apache.phoenix.end2end
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/402#discussion_r229889691
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ParallelStatsDisabledIT.java
---
@@ -41,4 +53,29 @@ public static final void doSetup
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/402#discussion_r229901798
--- Diff:
phoenix-spark/src/main/java/org/apache/phoenix/spark/SparkResultSet.java ---
@@ -0,0 +1,1056 @@
+/*
+ * Licensed to the Apache Software
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/401
It would be cleaner if we don't need the override props map. Currently
makePTableFromExisting calls init() and then build() using all the fields from
the passed in table *except* those
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/401
After talking with Chinmay offline, I don't think its possible to move
init() into the build() as its not always being called. +1 assuming the tests
pass.
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/399#discussion_r229528028
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -70,7 +70,11 @@
private long timeMaxInterval
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/401
@ChinmaySKulkarni looks pretty good. Since we always call the init()
method, it should be possible to just call the corresponding setter methods
(for tenantId, schemaName etc) and then make init
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/402
I also had to bump up the spark version to 2.3.2 as this version has more
sql support, in order to get the tests to pass.
---
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/401
I also had to bump up the spark version to 2.3.2 as this version has more
sql support, in order to get the tests to pass.
---
GitHub user twdsilva opened a pull request:
https://github.com/apache/phoenix/pull/402
PHOENIX-4981 Add tests for ORDER BY, GROUP BY and salted tables usingâ¦
⦠phoenix-spark]
@karanmehta93 thanks for the review nice catch, I modified the
SparkContext variable
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/400
LGTM, Thanks for fixing this @karanmehta93. Can you please submit the patch
to JIRA to confirm that the precommit build runs the test during the IT phase.
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/397#discussion_r229055918
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/MapReduceParallelScanGrouper.java
---
@@ -80,18 +83,39 @@ public boolean
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/397#discussion_r229057356
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/TableSnapshotReadsMapReduceIT.java
---
@@ -151,13 +147,17 @@ private void configureJob(Job
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/364
+1 , @ChinmaySKulkarni can you attach this patch on the JIRA so that we
can get a test run?
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/363#discussion_r227621900
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/PropertiesInSyncIT.java ---
@@ -402,16 +486,17 @@ private String createBaseTableWithProps
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/363#discussion_r227622543
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -151,6 +152,14 @@
+ "(TENANT_ID, TABLE_
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/331
@danicat Thanks for the contribution, please file a JIRA for tracking
purposes so that this PR can be committed.
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r226393542
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableWithViewsIT.java
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/355#discussion_r226383941
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ComparisonExpression.java
---
@@ -327,6 +328,9 @@ public boolean evaluate(Tuple tuple
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/363
@ChinmaySKulkarni I don't think we will ALTER TABLE UPDATE_CACHE_FREQUENCY
during SYSTEM.CATALOG upgrade. What will currently happen if we do run this
statement during the upgrade?
The index
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/363#discussion_r225346235
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/rpc/UpdateCacheIT.java ---
@@ -136,14 +137,55 @@ public void testUpdateCacheForChangingUpdateTable
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/362#discussion_r224643012
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryMoreIT.java ---
@@ -17,26 +17,7 @@
*/
package org.apache.phoenix.end2end
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/362#discussion_r224644325
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java ---
@@ -242,6 +260,12 @@ public static Expression
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/362#discussion_r22468
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java ---
@@ -2060,10 +2084,13 @@ public Integer getScale
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/355#discussion_r224636819
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ComparisonExpression.java
---
@@ -242,19 +242,6 @@ public static Expression create
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/355#discussion_r224637219
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataProtocol.java
---
@@ -381,10 +371,10 @@ public static MetaDataMutationResult
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/355#discussion_r224639651
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/KeyValueSchema.java ---
@@ -121,7 +122,15 @@ public boolean isNull(int position
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/355#discussion_r224635422
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java ---
@@ -1298,7 +1284,322 @@ public void testAddingColumnsToTablesAndViews
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/355#discussion_r224635037
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java ---
@@ -1298,7 +1284,322 @@ public void testAddingColumnsToTablesAndViews
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/355#discussion_r224636691
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -17,108 +17,20 @@
*/
package
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/355#discussion_r224636783
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
---
@@ -392,6 +375,13 @@ public SQLException newException
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/355
@jaanai0 From the example that @dbwong gave, I don't think we can support
decreasing the length of a column. If the column is present in an index this
can cause queries to return different
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/355#discussion_r224207564
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java ---
@@ -1294,7 +1276,272 @@ public void testAddingColumnsToTablesAndViews
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/355#discussion_r224182097
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java ---
@@ -1294,7 +1276,272 @@ public void testAddingColumnsToTablesAndViews
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/355#discussion_r224208120
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -4588,4 +4424,195 @@ private TableName
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/355#discussion_r224206646
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -4588,4 +4424,195 @@ private TableName
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/355#discussion_r224210097
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
---
@@ -384,6 +367,12 @@ public SQLException newException
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r223910162
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -2655,10 +2666,19 @@ private MetaDataMutationResult
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r223888793
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -357,18 +357,28
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r223886613
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableWithViewsIT.java
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r223886374
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableWithViewsIT.java
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r223886927
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/359#discussion_r223888132
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apache
Github user twdsilva closed the pull request at:
https://github.com/apache/phoenix/pull/339
---
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/339#discussion_r222475810
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableWithViewsIT.java
---
@@ -810,59 +827,65 @@ public void
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/360#discussion_r222480439
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/PhoenixTxIndexMutationGenerator.java
---
@@ -313,7 +326,18 @@ public int compare(Cell o1
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/360#discussion_r222480675
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
@@ -184,9 +184,24 @@ public boolean apply(PTable index
1 - 100 of 177 matches
Mail list logo
