virajjasani merged PR #2290:
URL: https://github.com/apache/phoenix/pull/2290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix
kadirozde opened a new pull request, #2290:
URL: https://github.com/apache/phoenix/pull/2290
…… (#2245)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
kadirozde commented on PR #2290:
URL: https://github.com/apache/phoenix/pull/2290#issuecomment-3320796548
Cherry-pick from master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
tkhurana commented on code in PR #2289:
URL: https://github.com/apache/phoenix/pull/2289#discussion_r2363925407
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java:
##
@@ -702,6 +708,10 @@ public boolean next(List resultsToRet
d-c-manning commented on code in PR #2286:
URL: https://github.com/apache/phoenix/pull/2286#discussion_r2345625277
##
phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java:
##
@@ -314,8 +314,8 @@ public class QueryServicesOptions {
public static
virajjasani commented on PR #2289:
URL: https://github.com/apache/phoenix/pull/2289#issuecomment-3314292433
Let's cherry-pick the commit in 5.3 branch also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
virajjasani commented on PR #2245:
URL: https://github.com/apache/phoenix/pull/2245#issuecomment-3314292869
Let's cherry-pick the commit in 5.3 branch also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
tkhurana merged PR #2289:
URL: https://github.com/apache/phoenix/pull/2289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.ap
virajjasani opened a new pull request, #2286:
URL: https://github.com/apache/phoenix/pull/2286
Co-authored-by: David Manning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
kadirozde commented on code in PR #2289:
URL: https://github.com/apache/phoenix/pull/2289#discussion_r2361550702
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java:
##
@@ -702,6 +708,10 @@ public boolean next(List resultsToRe
kadirozde commented on code in PR #2289:
URL: https://github.com/apache/phoenix/pull/2289#discussion_r2361550702
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java:
##
@@ -702,6 +708,10 @@ public boolean next(List resultsToRe
tkhurana merged PR #2281:
URL: https://github.com/apache/phoenix/pull/2281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.ap
tkhurana opened a new pull request, #2289:
URL: https://github.com/apache/phoenix/pull/2289
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
lokiore opened a new pull request, #2288:
URL: https://github.com/apache/phoenix/pull/2288
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
NihalJain commented on PR #2031:
URL: https://github.com/apache/phoenix/pull/2031#issuecomment-3279102535
Hi @richardantal this is still relevant. Recently, we have onboarded phoenix
to prod for a new use case. We hit this in our env, where we had to give them
permissions to the 2 index tab
virajjasani merged PR #2287:
URL: https://github.com/apache/phoenix/pull/2287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix
virajjasani commented on PR #2287:
URL: https://github.com/apache/phoenix/pull/2287#issuecomment-3308750950
All tests passed on 2.6 profile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
kadirozde merged PR #2245:
URL: https://github.com/apache/phoenix/pull/2245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.a
meszinorbi commented on code in PR #202:
URL: https://github.com/apache/phoenix-omid/pull/202#discussion_r2359020446
##
common/src/main/proto/TSOProto.proto:
##
@@ -32,7 +33,7 @@ message TimestampRequest {
message CommitRequest {
optional int64 startTimestamp = 1;
-o
meszinorbi commented on code in PR #202:
URL: https://github.com/apache/phoenix-omid/pull/202#discussion_r2359096844
##
common/src/main/java/org/apache/omid/protobuf/OmidProtobufEncoder.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
stoty commented on code in PR #202:
URL: https://github.com/apache/phoenix-omid/pull/202#discussion_r2358998545
##
common/src/main/proto/TSOProto.proto:
##
@@ -32,7 +33,7 @@ message TimestampRequest {
message CommitRequest {
optional int64 startTimestamp = 1;
-option
meszinorbi commented on code in PR #202:
URL: https://github.com/apache/phoenix-omid/pull/202#discussion_r2358946310
##
common/src/main/proto/TSOProto.proto:
##
@@ -16,51 +16,52 @@
// limitations under the License.
//
+syntax = "proto3";
option java_package = "org.apache.om
stoty commented on code in PR #202:
URL: https://github.com/apache/phoenix-omid/pull/202#discussion_r2358816702
##
common/src/main/proto/TSOProto.proto:
##
@@ -16,51 +16,52 @@
// limitations under the License.
//
+syntax = "proto3";
option java_package = "org.apache.omid.pr
meszinorbi commented on code in PR #14:
URL: https://github.com/apache/phoenix-thirdparty/pull/14#discussion_r2358419320
##
phoenix-shaded-protobuf/pom.xml:
##
@@ -0,0 +1,88 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instanc
stoty commented on code in PR #14:
URL: https://github.com/apache/phoenix-thirdparty/pull/14#discussion_r2358360809
##
phoenix-shaded-protobuf/pom.xml:
##
@@ -0,0 +1,88 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+
virajjasani commented on PR #2287:
URL: https://github.com/apache/phoenix/pull/2287#issuecomment-3304659014
Once we get clean build on default hbase 2.5 profile, will make temporary
commit to update profile to hbase 2.6 to get full build results
--
This is an automated message from the Ap
virajjasani opened a new pull request, #2287:
URL: https://github.com/apache/phoenix/pull/2287
Jira: PHOENIX-7702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
kadirozde merged PR #2274:
URL: https://github.com/apache/phoenix/pull/2274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.a
ritegarg commented on code in PR #2274:
URL: https://github.com/apache/phoenix/pull/2274#discussion_r2353557571
##
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStoreClient.java:
##
@@ -638,4 +692,189 @@ private boolean
isUpdateNeeded(HAGroupStoreRecord.HAGro
tkhurana commented on PR #2245:
URL: https://github.com/apache/phoenix/pull/2245#issuecomment-3293939653
@kadirozde Can you run `mvn spotless:apply` to fix the spotless warnings as
reported here
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2245/15/artifact
ritegarg commented on code in PR #2274:
URL: https://github.com/apache/phoenix/pull/2274#discussion_r2349822075
##
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStoreClient.java:
##
@@ -293,10 +308,29 @@ public void
setHAGroupStatusIfNeeded(HAGroupStoreRecord
kadirozde commented on code in PR #2274:
URL: https://github.com/apache/phoenix/pull/2274#discussion_r2347803316
##
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStoreClient.java:
##
@@ -638,4 +692,189 @@ private boolean
isUpdateNeeded(HAGroupStoreRecord.HAGr
kadirozde commented on code in PR #2274:
URL: https://github.com/apache/phoenix/pull/2274#discussion_r2347792999
##
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStoreClient.java:
##
@@ -293,10 +308,29 @@ public void
setHAGroupStatusIfNeeded(HAGroupStoreRecor
virajjasani merged PR #2286:
URL: https://github.com/apache/phoenix/pull/2286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix
virajjasani commented on code in PR #2286:
URL: https://github.com/apache/phoenix/pull/2286#discussion_r2346841521
##
phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java:
##
@@ -314,8 +314,8 @@ public class QueryServicesOptions {
public static
virajjasani commented on code in PR #2286:
URL: https://github.com/apache/phoenix/pull/2286#discussion_r2345628915
##
phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##
@@ -1748,7 +1748,9 @@ private void checkAndRetry(RetriableOperati
virajjasani commented on PR #2286:
URL: https://github.com/apache/phoenix/pull/2286#issuecomment-3287148413
> @virajjasani Shouldn't we go to sleep only when success is false
https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQu
virajjasani commented on code in PR #2286:
URL: https://github.com/apache/phoenix/pull/2286#discussion_r2345633573
##
phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##
@@ -1748,7 +1748,9 @@ private void checkAndRetry(RetriableOperati
virajjasani commented on code in PR #2286:
URL: https://github.com/apache/phoenix/pull/2286#discussion_r2345632141
##
phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##
@@ -1730,16 +1730,16 @@ private void checkAndRetry(RetriableOpera
virajjasani commented on code in PR #2286:
URL: https://github.com/apache/phoenix/pull/2286#discussion_r2345630760
##
phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##
@@ -1748,7 +1748,9 @@ private void checkAndRetry(RetriableOperati
tkhurana commented on PR #2286:
URL: https://github.com/apache/phoenix/pull/2286#issuecomment-3287114622
@virajjasani Shouldn't we go to sleep only when success is false
https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQuerySe
meszinorbi commented on code in PR #14:
URL: https://github.com/apache/phoenix-thirdparty/pull/14#discussion_r2336889894
##
phoenix-shaded-protobuf/pom.xml:
##
@@ -0,0 +1,88 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instanc
stoty commented on code in PR #14:
URL: https://github.com/apache/phoenix-thirdparty/pull/14#discussion_r2336850647
##
phoenix-shaded-protobuf/pom.xml:
##
@@ -0,0 +1,88 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+
meszinorbi opened a new pull request, #202:
URL: https://github.com/apache/phoenix-omid/pull/202
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
stoty merged PR #2283:
URL: https://github.com/apache/phoenix/pull/2283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apach
stoty merged PR #2284:
URL: https://github.com/apache/phoenix/pull/2284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apach
stoty commented on PR #2284:
URL: https://github.com/apache/phoenix/pull/2284#issuecomment-3263735109
successfully re-run the failing tests locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
stoty opened a new pull request, #2283:
URL: https://github.com/apache/phoenix/pull/2283
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
stoty merged PR #2285:
URL: https://github.com/apache/phoenix/pull/2285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apach
stoty commented on PR #2284:
URL: https://github.com/apache/phoenix/pull/2284#issuecomment-3263536054
For some reson CI didn't get started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
stoty merged PR #2282:
URL: https://github.com/apache/phoenix/pull/2282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apach
stoty opened a new pull request, #2285:
URL: https://github.com/apache/phoenix/pull/2285
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
lokiore closed pull request #2092: PHOENIX-7502 :- Decouple principal from
HAGroupInfo (#2053)
URL: https://github.com/apache/phoenix/pull/2092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
stoty commented on PR #2282:
URL: https://github.com/apache/phoenix/pull/2282#issuecomment-3258119167
looks like the second commit wasn't needed after all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
stoty opened a new pull request, #2284:
URL: https://github.com/apache/phoenix/pull/2284
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
stoty opened a new pull request, #2282:
URL: https://github.com/apache/phoenix/pull/2282
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
Himanshu-g81 opened a new pull request, #2281:
URL: https://github.com/apache/phoenix/pull/2281
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
virajjasani merged PR #2280:
URL: https://github.com/apache/phoenix/pull/2280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix
virajjasani commented on PR #2280:
URL: https://github.com/apache/phoenix/pull/2280#issuecomment-3247011177
Let me merge this now, the above changes can be done as separate addendum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
virajjasani commented on code in PR #2280:
URL: https://github.com/apache/phoenix/pull/2280#discussion_r2317325118
##
phoenix-core/src/test/java/org/apache/phoenix/util/bson/UpdateExpressionValidationTest.java:
##
@@ -0,0 +1,417 @@
+/*
+ * Licensed to the Apache Software Foundat
virajjasani commented on code in PR #2280:
URL: https://github.com/apache/phoenix/pull/2280#discussion_r2309121492
##
phoenix-core-client/src/main/java/org/apache/phoenix/expression/util/bson/UpdateExpressionUtils.java:
##
@@ -445,10 +455,12 @@ private static void updateArrayAtL
stoty commented on code in PR #14:
URL: https://github.com/apache/phoenix-thirdparty/pull/14#discussion_r2307281766
##
phoenix-shaded-protobuf/pom.xml:
##
@@ -0,0 +1,86 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+
meszinorbi commented on code in PR #14:
URL: https://github.com/apache/phoenix-thirdparty/pull/14#discussion_r2307264206
##
phoenix-shaded-protobuf/pom.xml:
##
@@ -0,0 +1,86 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instanc
stoty commented on code in PR #14:
URL: https://github.com/apache/phoenix-thirdparty/pull/14#discussion_r2307243430
##
phoenix-shaded-protobuf/pom.xml:
##
@@ -0,0 +1,86 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+
meszinorbi opened a new pull request, #14:
URL: https://github.com/apache/phoenix-thirdparty/pull/14
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
palashc opened a new pull request, #2280:
URL: https://github.com/apache/phoenix/pull/2280
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
palashc closed pull request #2279: PHOENIX-7692: Path validations for bson
update expression
URL: https://github.com/apache/phoenix/pull/2279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
palashc opened a new pull request, #2279:
URL: https://github.com/apache/phoenix/pull/2279
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
Himanshu-g81 commented on PR #2243:
URL: https://github.com/apache/phoenix/pull/2243#issuecomment-3224629343
Raised https://github.com/apache/phoenix/pull/2278 instead, hence closing
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Himanshu-g81 closed pull request #2243: [DRAFT] Phoenix-7568 Replication Log
Replay
URL: https://github.com/apache/phoenix/pull/2243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Himanshu-g81 opened a new pull request, #2278:
URL: https://github.com/apache/phoenix/pull/2278
High Level Description of major Replication Replay Componenets added in this
PR
1. **ReplicationLogReplayService** - A singleton class that has single
thread which gets all the HA groups a
richardantal commented on PR #:
URL: https://github.com/apache/phoenix/pull/#issuecomment-3220045547
I rebased the change to resolve conflict with spotless change.
Lets wait for a test run
--
This is an automated message from the Apache Git Service.
To respond to the message, p
stoty commented on PR #2154:
URL: https://github.com/apache/phoenix/pull/2154#issuecomment-3218876092
Does this only affect 5.3 @tkhurana ?
If not, then looks important enough to be backported.
--
This is an automated message from the Apache Git Service.
To respond to the message,
palashc merged PR #2277:
URL: https://github.com/apache/phoenix/pull/2277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apa
palashc opened a new pull request, #2277:
URL: https://github.com/apache/phoenix/pull/2277
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
jpisaac merged PR #2273:
URL: https://github.com/apache/phoenix/pull/2273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apa
tkhurana merged PR #2276:
URL: https://github.com/apache/phoenix/pull/2276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.ap
virajjasani commented on PR #2273:
URL: https://github.com/apache/phoenix/pull/2273#issuecomment-3202451891
@jpisaac could you please rebase with master one time? just one final build
and we should be good to go
--
This is an automated message from the Apache Git Service.
To respond to th
tkhurana opened a new pull request, #2276:
URL: https://github.com/apache/phoenix/pull/2276
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
virajjasani merged PR #2226:
URL: https://github.com/apache/phoenix/pull/2226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix
meszinorbi opened a new pull request, #2275:
URL: https://github.com/apache/phoenix/pull/2275
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
meszinorbi opened a new pull request, #183:
URL: https://github.com/apache/phoenix-queryserver/pull/183
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
meszinorbi opened a new pull request, #201:
URL: https://github.com/apache/phoenix-omid/pull/201
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
jpisaac commented on PR #2273:
URL: https://github.com/apache/phoenix/pull/2273#issuecomment-3198827718
@virajjasani @palashc @tkhurana The test failures here in the Precommit
[job](https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2273/3/)
seems to some enviro
virajjasani commented on PR #2273:
URL: https://github.com/apache/phoenix/pull/2273#issuecomment-3197908125
Pending clean build results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
palashc commented on code in PR #2273:
URL: https://github.com/apache/phoenix/pull/2273#discussion_r2279700553
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/PhoenixRegionServerEndpoint.java:
##
@@ -54,6 +55,12 @@ public void start(CoprocessorEnvironment env
palashc merged PR #2252:
URL: https://github.com/apache/phoenix/pull/2252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apa
palashc commented on code in PR #2252:
URL: https://github.com/apache/phoenix/pull/2252#discussion_r2278115491
##
phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServices.java:
##
@@ -627,6 +627,10 @@ public interface QueryServices extends SQLCloseable {
Strin
virajjasani commented on PR #2252:
URL: https://github.com/apache/phoenix/pull/2252#issuecomment-3190316467
We also need to co-ordinate with this PR
https://github.com/apache/phoenix/pull/2273/files#diff-42d39a0ca68a86ad3d86a6d3bad511af8a273a520986ce269ab0e920da6596a7R58
It is also in
virajjasani commented on code in PR #2252:
URL: https://github.com/apache/phoenix/pull/2252#discussion_r2277999170
##
phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServices.java:
##
@@ -627,6 +627,10 @@ public interface QueryServices extends SQLCloseable {
S
virajjasani commented on code in PR #2252:
URL: https://github.com/apache/phoenix/pull/2252#discussion_r2277994440
##
phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java:
##
@@ -501,6 +501,9 @@ public class QueryServicesOptions {
public static
virajjasani commented on code in PR #2252:
URL: https://github.com/apache/phoenix/pull/2252#discussion_r2277977076
##
phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java:
##
@@ -501,6 +501,9 @@ public class QueryServicesOptions {
public static
ritegarg opened a new pull request, #2274:
URL: https://github.com/apache/phoenix/pull/2274
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
dependabot[bot] opened a new pull request, #200:
URL: https://github.com/apache/phoenix-omid/pull/200
Bumps [org.bouncycastle:bcpkix-jdk18on](https://github.com/bcgit/bc-java)
from 1.78 to 1.78.1.
Changelog
Sourced from https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.h
virajjasani merged PR #2255:
URL: https://github.com/apache/phoenix/pull/2255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix
virajjasani commented on PR #2255:
URL: https://github.com/apache/phoenix/pull/2255#issuecomment-3185935972
> checkstyle/spotless fixes etc
It's same spotless that keeps showing up on multiple PRs for one of the
javadocs in MetaDataClient. Given that this is big PR already, let's take
virajjasani commented on code in PR #2255:
URL: https://github.com/apache/phoenix/pull/2255#discussion_r2274717180
##
phoenix-core-client/src/main/java/org/apache/phoenix/compile/WhereCompiler.java:
##
@@ -294,6 +325,152 @@ protected ColumnRef resolveColumn(ColumnParseNode node)
virajjasani commented on code in PR #2255:
URL: https://github.com/apache/phoenix/pull/2255#discussion_r2274720081
##
phoenix-core/src/test/java/org/apache/phoenix/compile/ScanBoundaryFunctionTest.java:
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
palashc commented on code in PR #2255:
URL: https://github.com/apache/phoenix/pull/2255#discussion_r2274170040
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/ScanBoundaryFunctionIT.java:
##
@@ -0,0 +1,584 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
lokiore closed pull request #2182: [DRAFT] [Task of PHOENIX-7562] Updating the
name from ClusterRoleRecord to HAGroupStore
URL: https://github.com/apache/phoenix/pull/2182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
1 - 100 of 5459 matches
Mail list logo
