virajjasani commented on code in PR #1899:
URL: https://github.com/apache/phoenix/pull/1899#discussion_r1623279447
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/BaseIndexWithRegionMovesIT.java:
##
@@ -1709,6 +1709,7 @@ public void
virajjasani commented on code in PR #1899:
URL: https://github.com/apache/phoenix/pull/1899#discussion_r1623279331
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/BaseIndexWithRegionMovesIT.java:
##
@@ -1709,6 +1709,7 @@ public void
virajjasani commented on PR #1899:
URL: https://github.com/apache/phoenix/pull/1899#issuecomment-2143581414
Looks like tests are still failing
e.g.
```
java.lang.AssertionError: Ran out of time waiting for index state to become
BUILDING last seen actual state is ACTIVE
at
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1622980898
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1622978083
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1622813437
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -546,9 +568,22 @@ private void
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1622972944
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
virajjasani commented on PR #1899:
URL: https://github.com/apache/phoenix/pull/1899#issuecomment-2142944811
Pending build results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1899/2/
--
This is an automated message from the Apache Git Service.
To
jinggou commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1622875454
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
jinggou commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1622875454
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1622813437
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -546,9 +568,22 @@ private void
jpisaac opened a new pull request, #1900:
URL: https://github.com/apache/phoenix/pull/1900
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
haridsv opened a new pull request, #1899:
URL: https://github.com/apache/phoenix/pull/1899
Addendum to PR #1866
* Revert a change that broke
GlobalImmutableTxIndexIT#testLastDDLTimestampOnAsyncIndexes
* Remove ALTER CDC support as it is no longer needed.
--
This is an automated
stoty commented on PR #1898:
URL: https://github.com/apache/phoenix/pull/1898#issuecomment-2141236728
Come to think of it, we don't even run precommit tests with 2.4 anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
stoty commented on PR #1898:
URL: https://github.com/apache/phoenix/pull/1898#issuecomment-2141166561
But on the bright side, this is the very last 2.4 version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
stoty commented on PR #1898:
URL: https://github.com/apache/phoenix/pull/1898#issuecomment-2141166260
This needs to be tested locally as the yetus script cannot handle HBase 2.4
version changes.
--
This is an automated message from the Apache Git Service.
To respond to the message,
jinggou commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621528764
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
jinggou commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621528764
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
jinggou commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621525579
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
jinggou commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621525579
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
jinggou commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621525579
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
jinggou commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621525579
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
jinggou commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621525579
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
jinggou commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621523746
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621515584
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621514559
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621513679
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621512510
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
jinggou commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621511168
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621494203
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -546,9 +568,22 @@ private void
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621490281
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1588,10 +1680,36 @@ private List
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1621488729
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
virajjasani commented on code in PR #1866:
URL: https://github.com/apache/phoenix/pull/1866#discussion_r1621326444
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/BaseIndexIT.java:
##
@@ -1514,7 +1514,6 @@ public void testLastDDLTimestampOnAsyncIndexes() throws
palashc commented on code in PR #1866:
URL: https://github.com/apache/phoenix/pull/1866#discussion_r1621286330
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/BaseIndexIT.java:
##
@@ -1514,7 +1514,6 @@ public void testLastDDLTimestampOnAsyncIndexes() throws
palashc commented on code in PR #1866:
URL: https://github.com/apache/phoenix/pull/1866#discussion_r1621286330
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/BaseIndexIT.java:
##
@@ -1514,7 +1514,6 @@ public void testLastDDLTimestampOnAsyncIndexes() throws
palashc commented on code in PR #1866:
URL: https://github.com/apache/phoenix/pull/1866#discussion_r1621281779
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/BaseIndexIT.java:
##
@@ -1514,7 +1514,6 @@ public void testLastDDLTimestampOnAsyncIndexes() throws
tkhurana commented on code in PR #1866:
URL: https://github.com/apache/phoenix/pull/1866#discussion_r1621240178
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/BaseIndexIT.java:
##
@@ -1514,7 +1514,6 @@ public void testLastDDLTimestampOnAsyncIndexes() throws
palashc commented on code in PR #1866:
URL: https://github.com/apache/phoenix/pull/1866#discussion_r1621231370
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/BaseIndexIT.java:
##
@@ -1514,7 +1514,6 @@ public void testLastDDLTimestampOnAsyncIndexes() throws
tkhurana commented on PR #1897:
URL: https://github.com/apache/phoenix/pull/1897#issuecomment-2140469374
The latest run only had test failures due to known flappers. Merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tkhurana merged PR #1897:
URL: https://github.com/apache/phoenix/pull/1897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tkhurana commented on PR #1897:
URL: https://github.com/apache/phoenix/pull/1897#issuecomment-2140466779
> Based on this build result, perhaps CDC feature might have caused this
flakes
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-mulitbranch/job/master/679/
You are right
virajjasani commented on PR #1897:
URL: https://github.com/apache/phoenix/pull/1897#issuecomment-2138652103
Based on this build result, perhaps CDC feature might have caused this
flakes
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-mulitbranch/job/master/679/
--
This is an
virajjasani commented on PR #1897:
URL: https://github.com/apache/phoenix/pull/1897#issuecomment-2138650239
@kadirozde @tkhurana I am able to reproduce
`GlobalImmutableTxIndexIT#testLastDDLTimestampOnAsyncIndexes` test failure
locally:
```
java.lang.AssertionError: PTable DDL
virajjasani commented on PR #1897:
URL: https://github.com/apache/phoenix/pull/1897#issuecomment-2138646315
Triggered another build:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1897/3/
--
This is an automated message from the Apache Git Service.
To
virajjasani commented on code in PR #1896:
URL: https://github.com/apache/phoenix/pull/1896#discussion_r1619835351
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/CompactionScanner.java:
##
@@ -419,13 +551,15 @@ private void
kadirozde commented on PR #1897:
URL: https://github.com/apache/phoenix/pull/1897#issuecomment-2136641699
@tkhurana, the PR is good to me. There is one test failure related to this
PR which is OnDuplicateKeyIT.testAtomicUpdate. I will approve the PR if that is
resolved.
--
This is an
kadirozde commented on code in PR #1897:
URL: https://github.com/apache/phoenix/pull/1897#discussion_r1618278521
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -857,11 +864,30 @@ private void
ranganathg commented on code in PR #1897:
URL: https://github.com/apache/phoenix/pull/1897#discussion_r1618276259
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -857,11 +864,30 @@ private void
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618088560
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1588,10 +1680,36 @@ private List
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618088560
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1588,10 +1680,36 @@ private List
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618088560
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1588,10 +1680,36 @@ private List
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618082802
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1588,10 +1680,36 @@ private List
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618076149
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618076149
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618076149
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618076149
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618076149
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618068688
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618067235
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1588,10 +1680,36 @@ private List
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618052558
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618041568
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618019969
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
virajjasani commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1618005888
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1617934675
##
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##
@@ -1308,6 +1345,19 @@ public void
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1617918676
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java:
##
@@ -720,6 +747,470 @@ public void testMultiplePartialUpdatesInSameBatch()
throws
kadirozde commented on PR #1896:
URL: https://github.com/apache/phoenix/pull/1896#issuecomment-2136106662
I run the failed tests locally and all of them passes for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
virajjasani commented on PR #1866:
URL: https://github.com/apache/phoenix/pull/1866#issuecomment-2135708270
Belated +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kadirozde merged PR #1866:
URL: https://github.com/apache/phoenix/pull/1866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kadirozde commented on code in PR #1896:
URL: https://github.com/apache/phoenix/pull/1896#discussion_r1616049951
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##
@@ -581,92 +601,135 @@ private boolean
kadirozde commented on code in PR #1896:
URL: https://github.com/apache/phoenix/pull/1896#discussion_r1615887838
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##
@@ -581,92 +601,135 @@ private boolean
sanjeet006py commented on code in PR #1896:
URL: https://github.com/apache/phoenix/pull/1896#discussion_r1615843022
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##
@@ -581,92 +601,135 @@ private boolean
kadirozde commented on code in PR #1896:
URL: https://github.com/apache/phoenix/pull/1896#discussion_r1615326932
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java:
##
@@ -1654,7 +1655,8 @@ else if (linkType == PHYSICAL_TABLE) {
sanjeet006py commented on code in PR #1896:
URL: https://github.com/apache/phoenix/pull/1896#discussion_r1615288652
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java:
##
@@ -1654,7 +1655,8 @@ else if (linkType == PHYSICAL_TABLE) {
sanjeet006py commented on code in PR #1896:
URL: https://github.com/apache/phoenix/pull/1896#discussion_r1615288652
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java:
##
@@ -1654,7 +1655,8 @@ else if (linkType == PHYSICAL_TABLE) {
kadirozde opened a new pull request, #1896:
URL: https://github.com/apache/phoenix/pull/1896
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
jpisaac commented on PR #1855:
URL: https://github.com/apache/phoenix/pull/1855#issuecomment-2130645949
FYI @kadirozde I think the PR is almost ready except to removing debug
logging and additional docs and comments
--
This is an automated message from the Apache Git Service.
To respond
ranganathg opened a new pull request, #1895:
URL: https://github.com/apache/phoenix/pull/1895
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
kadirozde commented on code in PR #1888:
URL: https://github.com/apache/phoenix/pull/1888#discussion_r1610393385
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:
##
@@ -357,20 +357,33 @@ RegionScanner getWrappedScanner(final
kadirozde commented on code in PR #1888:
URL: https://github.com/apache/phoenix/pull/1888#discussion_r1610389977
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:
##
@@ -357,20 +357,33 @@ RegionScanner getWrappedScanner(final
d-c-manning commented on code in PR #1888:
URL: https://github.com/apache/phoenix/pull/1888#discussion_r1610344621
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:
##
@@ -357,20 +357,33 @@ RegionScanner getWrappedScanner(final
kadirozde commented on code in PR #1888:
URL: https://github.com/apache/phoenix/pull/1888#discussion_r1607030382
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:
##
@@ -357,20 +357,33 @@ RegionScanner getWrappedScanner(final
d-c-manning commented on code in PR #1888:
URL: https://github.com/apache/phoenix/pull/1888#discussion_r1607020005
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:
##
@@ -357,20 +357,33 @@ RegionScanner getWrappedScanner(final
d-c-manning commented on code in PR #1888:
URL: https://github.com/apache/phoenix/pull/1888#discussion_r1607018606
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:
##
@@ -357,20 +357,33 @@ RegionScanner getWrappedScanner(final
kadirozde commented on PR #1866:
URL: https://github.com/apache/phoenix/pull/1866#issuecomment-2119844040
> Now that JSON PR is merged, we can also address it with changes/pre/post
image and include some tests for JSON data.
Let us open a separate Jira to support complex data types
haridsv commented on code in PR #1866:
URL: https://github.com/apache/phoenix/pull/1866#discussion_r1606321093
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCQueryIT.java:
##
@@ -0,0 +1,667 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
haridsv commented on code in PR #1866:
URL: https://github.com/apache/phoenix/pull/1866#discussion_r1606320245
##
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/CDCGlobalIndexRegionScanner.java:
##
@@ -0,0 +1,274 @@
+/*
+ * Licensed to the Apache Software
chaijunjie0101 opened a new pull request, #1894:
URL: https://github.com/apache/phoenix/pull/1894
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
virajjasani merged PR #1892:
URL: https://github.com/apache/phoenix/pull/1892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ranganathg opened a new pull request, #1893:
URL: https://github.com/apache/phoenix/pull/1893
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
kadirozde merged PR #1888:
URL: https://github.com/apache/phoenix/pull/1888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kadirozde commented on PR #1888:
URL: https://github.com/apache/phoenix/pull/1888#issuecomment-2115876404
Tests are passing now. Only one test failed which passes when I run. I think
it
(ConcurrentMutationsIT.testSetIndexedColumnToNullAndValueAtSameTSWithStoreNulls2)
is a flapper.
ranganathg commented on PR #1892:
URL: https://github.com/apache/phoenix/pull/1892#issuecomment-2114182801
> Are you able to reproduce this locally?
virajjasani commented on PR #1892:
URL: https://github.com/apache/phoenix/pull/1892#issuecomment-2113980256
Are you able to reproduce this locally?
virajjasani commented on PR #1866:
URL: https://github.com/apache/phoenix/pull/1866#issuecomment-2113977192
Now that JSON PR is merged, we can also address it with changes/pre/post
image and include some tests for JSON data.
--
This is an automated message from the Apache Git Service.
To
jinggou commented on PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#issuecomment-2113125558
@tkhurana @virajjasani Please review my changes
1. reverted the formatting changes to IndexRegionObserver.java and keep
what's relevant
2. allocated results array only when
jinggou commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1602033292
##
phoenix-core-client/src/main/java/org/apache/phoenix/execute/MutationState.java:
##
@@ -1366,6 +1375,7 @@ private void sendMutations(Iterator>> mutationsI
tkhurana commented on PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#issuecomment-2111233772
@jinggou I think there seems to be some formatting changes to
IndexRegionObserver.java which has made the diff huge. Can we revert and just
keep what's relevant.
--
This is an
dependabot[bot] opened a new pull request, #164:
URL: https://github.com/apache/phoenix-omid/pull/164
Bumps [org.bouncycastle:bcpkix-jdk18on](https://github.com/bcgit/bc-java)
from 1.76 to 1.78.
Changelog
Sourced from
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1600621168
##
phoenix-core-client/src/main/java/org/apache/phoenix/execute/MutationState.java:
##
@@ -1366,6 +1375,7 @@ private void sendMutations(Iterator>> mutationsI
tkhurana commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1600619725
##
phoenix-core-client/src/main/java/org/apache/phoenix/execute/MutationState.java:
##
@@ -1415,8 +1425,23 @@ public List getMutationList() {
1 - 100 of 3219 matches
Mail list logo
